[pve-devel] [PATCH docs 4/4] Rewrite Translation

2019-06-17 Thread Aaron Lauterer
Polished phrasing Signed-off-by: Aaron Lauterer --- translation.adoc | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/translation.adoc b/translation.adoc index ff99296..42d2f26 100644 --- a/translation.adoc +++ b/translation.adoc @@ -6,24

[pve-devel] [PATCH docs 2/4] Rewrite Getting Help

2019-06-17 Thread Aaron Lauterer
Polished phrasing Signed-off-by: Aaron Lauterer --- getting-help.adoc | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/getting-help.adoc b/getting-help.adoc index 850d7a3..fef6f96 100644 --- a/getting-help.adoc +++ b/getting-help.adoc

[pve-devel] [PATCH docs 07/10] Rewrite Disk Health Monitoring

2019-06-17 Thread Aaron Lauterer
Polished phrasing Signed-off-by: Aaron Lauterer --- pve-disk-health-monitoring.adoc | 34 + 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/pve-disk-health-monitoring.adoc b/pve-disk-health-monitoring.adoc index 8ea9d5f..5b03c1c 100644 --- a/pve

[pve-devel] [PATCH docs 09/10] Rewrite ZFS - admin section

2019-06-17 Thread Aaron Lauterer
Polished phrasing, restuctured `advantages` list and removed double entries, extended RAID level descriptions, aligned CLI commands style Signed-off-by: Aaron Lauterer --- local-zfs.adoc | 295 - 1 file changed, 170 insertions(+), 125 deletions

[pve-devel] [PATCH docs 00/10] Rewrite Host System Administration

2019-06-17 Thread Aaron Lauterer
All files regarding the Host System Administration chapter. Aaron Lauterer (10): Rewrite Sysadmin Rewrite Package Repositories Rewrite System Software Updates Rewrite Network Rewrite Timesync Rewrite External Metric Server Rewrite Disk Health Monitoring Rewrite LVM - admin section

[pve-devel] [PATCH docs 03/10] Rewrite System Software Updates

2019-06-17 Thread Aaron Lauterer
Polished phrasing and aligned CLI command styling Signed-off-by: Aaron Lauterer --- system-software-updates.adoc | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/system-software-updates.adoc b/system-software-updates.adoc index 04c17f3..50f8c8e

[pve-devel] [PATCH docs 05/10] Rewrite Timesync

2019-06-17 Thread Aaron Lauterer
Polished phrasing Signed-off-by: Aaron Lauterer --- system-timesync.adoc | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/system-timesync.adoc b/system-timesync.adoc index c64455c..b3ffe5b 100644 --- a/system-timesync.adoc +++ b/system

[pve-devel] [PATCH docs 2/3] Rewrite System Requirements

2019-06-17 Thread Aaron Lauterer
Polished phrasing and restructured the requirements list a little bit Signed-off-by: Aaron Lauterer --- pve-system-requirements.adoc | 68 1 file changed, 37 insertions(+), 31 deletions(-) diff --git a/pve-system-requirements.adoc b/pve-system

[pve-devel] [PATCH docs 1/3] Rewrite Installation

2019-06-17 Thread Aaron Lauterer
Polished phrasing, added mentions of the EULA and summary page in the installer, unified style of cli commands. Signed-off-by: Aaron Lauterer --- pve-installation.adoc | 251 ++ 1 file changed, 129 insertions(+), 122 deletions(-) diff --git a/pve

[pve-devel] [PATCH docs 3/3] Rewrite Install from USB flash drive

2019-06-17 Thread Aaron Lauterer
Polished the phrasing, aligned different names for a USB flash drive, renamed OS X to macOS, changed primary recommendation for Windows to Rufus, removed mention of os forensics. Rufus now supports `dd` mode and is a much smaller download than etcher. Signed-off-by: Aaron Lauterer --- pve

[pve-devel] [PATCH docs 0/3] V2 Rewrite Installation

2019-06-17 Thread Aaron Lauterer
And here are the other files that I missed to add[0]. [0]: https://pve.proxmox.com/pipermail/pve-devel/2019-June/037582.html Aaron Lauterer (3): Rewrite Installation Rewrite System Requirements Rewrite Install from USB flash drive pve-installation.adoc| 251

[pve-devel] [PATCH docs] Rewrite: intro

2019-06-12 Thread Aaron Lauterer
Polished the phrasing in order to make it easer to read and understand. Some parts are rearranged. Signed-off-by: Aaron Lauterer --- pve-intro.adoc | 237 +++-- 1 file changed, 112 insertions(+), 125 deletions(-) diff --git a/pve-intro.adoc b/pve

[pve-devel] [PATCH docs 4/6] Rewrite: installation

2019-06-12 Thread Aaron Lauterer
Polished the phrasing in order to make it easer to read and understand. Signed-off-by: Aaron Lauterer --- pve-installation.adoc | 230 ++ 1 file changed, 119 insertions(+), 111 deletions(-) diff --git a/pve-installation.adoc b/pve-installation.adoc index

[pve-devel] [PATCH docs 5/6] Rewrite: system-requirements

2019-06-12 Thread Aaron Lauterer
Polished the phrasing in order to make it easer to read and understand. Signed-off-by: Aaron Lauterer --- pve-system-requirements.adoc | 64 1 file changed, 35 insertions(+), 29 deletions(-) diff --git a/pve-system-requirements.adoc b/pve-system

[pve-devel] [PATCH docs 2/6] Rewrite: howto-improve-pve-docs

2019-06-12 Thread Aaron Lauterer
Polished the phrasing in order to make it easer to read and understand. Signed-off-by: Aaron Lauterer --- howto-improve-pve-docs.adoc | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/howto-improve-pve-docs.adoc b/howto-improve-pve-docs.adoc

[pve-devel] [PATCH docs 6/6] Rewrite: usbstick

2019-06-12 Thread Aaron Lauterer
Polished the phrasing in order to make it easer to read and understand. Signed-off-by: Aaron Lauterer --- pve-usbstick.adoc | 87 +-- 1 file changed, 47 insertions(+), 40 deletions(-) diff --git a/pve-usbstick.adoc b/pve-usbstick.adoc index 5eb9132

[pve-devel] [PATCH docs 3/6] Rewrite: translation

2019-06-12 Thread Aaron Lauterer
Polished the phrasing in order to make it easer to read and understand. Signed-off-by: Aaron Lauterer --- translation.adoc | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/translation.adoc b/translation.adoc index ff99296..4fb927e 100644

[pve-devel] [PATCH docs 1/6] Rewrite: getting-help

2019-06-12 Thread Aaron Lauterer
Polished the phrasing in order to make it easer to read and understand. Signed-off-by: Aaron Lauterer --- getting-help.adoc | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/getting-help.adoc b/getting-help.adoc index 850d7a3..f2ac532 100644

[pve-devel] [PATCH] Add to gitignore

2019-06-12 Thread Aaron Lauterer
Added .swp for VIM Signed-off-by: Aaron Lauterer --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 04257db..36e2dd5 100644 --- a/.gitignore +++ b/.gitignore @@ -4,3 +4,4 @@ *.xml *.tmp *.epub +*.swp -- 2.20.1

[pve-devel] [PATCH docs 01/10] Rewrite Sysadmin

2019-06-17 Thread Aaron Lauterer
Polished phrasing. Signed-off-by: Aaron Lauterer --- sysadmin.adoc | 49 +++-- 1 file changed, 23 insertions(+), 26 deletions(-) diff --git a/sysadmin.adoc b/sysadmin.adoc index 21537f1..ef184ae 100644 --- a/sysadmin.adoc +++ b/sysadmin.adoc @@ -5,31

[pve-devel] [PATCH docs 02/10] Rewrite Package Repositories

2019-06-17 Thread Aaron Lauterer
Polished Phrasing, aligned CLI command styling and line width Signed-off-by: Aaron Lauterer --- pve-package-repos.adoc | 118 + 1 file changed, 60 insertions(+), 58 deletions(-) diff --git a/pve-package-repos.adoc b/pve-package-repos.adoc index 06d1b2f

[pve-devel] [PATCH docs 04/10] Rewrite Network

2019-06-17 Thread Aaron Lauterer
Polished phrasing, tried to make some explanations easier to comprehend, changed the styling of interfaces in the `Naming Conventions` section Signed-off-by: Aaron Lauterer --- pve-network.adoc | 302 --- 1 file changed, 153 insertions(+), 149

[pve-devel] [PATCH docs 06/10] Rewrite External Metric Server

2019-06-17 Thread Aaron Lauterer
Polished the phrasing Signed-off-by: Aaron Lauterer --- pve-external-metric-server.adoc | 39 ++--- 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a/pve-external-metric-server.adoc b/pve-external-metric-server.adoc index c9e1107..1d6efeb 100644

[pve-devel] [PATCH docs 08/10] Rewrite LVM - admin section

2019-06-17 Thread Aaron Lauterer
Polished phrasing, aligned CLI commands style Signed-off-by: Aaron Lauterer --- local-lvm.adoc | 126 - 1 file changed, 72 insertions(+), 54 deletions(-) diff --git a/local-lvm.adoc b/local-lvm.adoc index 2489b9d..b153862 100644 --- a/local

[pve-devel] [PATCH docs 10/10] Rewrite Certificate Management

2019-06-17 Thread Aaron Lauterer
Polished phrasing Signed-off-by: Aaron Lauterer --- certificate-management.adoc | 88 + 1 file changed, 50 insertions(+), 38 deletions(-) diff --git a/certificate-management.adoc b/certificate-management.adoc index 81660b2..d128c30 100644 --- a/certificate

[pve-devel] [PATCH docs 3/4] Rewrite Improve PVE Docs

2019-06-17 Thread Aaron Lauterer
Polished phrasing Signed-off-by: Aaron Lauterer --- howto-improve-pve-docs.adoc | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/howto-improve-pve-docs.adoc b/howto-improve-pve-docs.adoc index c0d277e..41a465c 100644 --- a/howto-improve-pve

[pve-devel] [PATCH docs 1/4] Rewrite Intro

2019-06-17 Thread Aaron Lauterer
Polished the phrasing and restructured some parts to improve readability and comprehension. Signed-off-by: Aaron Lauterer --- pve-intro.adoc | 229 +++-- 1 file changed, 108 insertions(+), 121 deletions(-) diff --git a/pve-intro.adoc b/pve-intro.adoc

[pve-devel] [PATCH docs 0/4] V2 Rewrite Intro and Installation

2019-06-17 Thread Aaron Lauterer
.html Aaron Lauterer (4): Rewrite Intro Rewrite Getting Help Rewrite Improve PVE Docs Rewrite Translation getting-help.adoc | 33 +++--- howto-improve-pve-docs.adoc | 29 +++-- pve-intro.adoc | 229 +--- translation.adoc

Re: [pve-devel] [PATCH docs 2/2] Update pvecm documentation for corosync 3

2019-07-09 Thread Aaron Lauterer
Added a few notes, mostly regarding style and readability. On 7/8/19 6:26 PM, Stefan Reiter wrote: Parts about multicast and RRP have been removed entirely. Instead, a new section 'Corosync Redundancy' has been added explaining the concept of links and link priorities. Signed-off-by: Stefan

Re: [pve-devel] [PATCH docs 1/2] Add documentation on bootloaders (systemd-boot)

2019-07-08 Thread Aaron Lauterer
Some things that I have seen, mostly regarding style and readability. On 7/5/19 6:31 PM, Stoiko Ivanov wrote: With the recently added support for booting ZFS on root on EFI systems via `systemd-boot` the documentation needs adapting (mostly related to editing the kernel commandline). This

Re: [pve-devel] [PATCH docs 2/2] Refer to the bootloader chapter in remaining docs

2019-07-08 Thread Aaron Lauterer
Not much here but one instance where it helps to simplify a sentence. On 7/5/19 6:31 PM, Stoiko Ivanov wrote: Editing the kernel commandline is described centrally in the bootloaders chapter. Refer to it where appropriate (qm-pci-passthrough.adoc). Additionally update the documentation on ZFS

Re: [pve-devel] [PATCH manager 4/5] Add icon for audio device

2019-07-16 Thread Aaron Lauterer
On 7/16/19 1:48 PM, Thomas Lamprecht wrote: On 7/15/19 3:34 PM, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer --- www/images/Makefile | 7 --- www/images/icon-audio.svg | 2 ++ 2 files changed, 6 insertions(+), 3 deletions(-) create mode 100644 www/images/icon-audio.svg

Re: [pve-devel] [PATCH docs 1/3] boot: add new pve-efiboot-tool commands

2019-07-15 Thread Aaron Lauterer
some thoughts from my side regarding readability: On 7/15/19 11:35 AM, Fabian Grünbichler wrote: to manage manually selected kernel list. Signed-off-by: Fabian Grünbichler --- reflecting my last, not-yet-applied series for pve-kernel-meta system-booting.adoc | 39

Re: [pve-devel] [PATCH docs 2/3] boot: mention pve-efiboot-tool earlier

2019-07-15 Thread Aaron Lauterer
On 7/15/19 3:07 PM, Fabian Grünbichler wrote: On Mon, Jul 15, 2019 at 02:37:45PM +0200, Aaron Lauterer wrote: Found a missing possible missing comma On 7/15/19 11:35 AM, Fabian Grünbichler wrote: Signed-off-by: Fabian Grünbichler --- system-booting.adoc | 3 ++- 1 file changed, 2

Re: [pve-devel] [PATCH manager 2/3] Add PCI address for audio device

2019-07-15 Thread Aaron Lauterer
Sorry, this is not part of the pve-manager repo but qemu-server. Misconfiguration on my side... On 7/15/19 3:34 PM, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer --- PVE/QemuServer/PCI.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServer

Re: [pve-devel] [PATCH manager 3/3] Add permission setting for audio device

2019-07-15 Thread Aaron Lauterer
Sorry, this is not part of the pve-manager repo but qemu-server. Misconfiguration on my side... On 7/15/19 3:34 PM, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer --- PVE/API2/Qemu.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index e2a63be

Re: [pve-devel] [PATCH manager 1/3] Add audio device support

2019-07-15 Thread Aaron Lauterer
Sorry, this is not part of the pve-manager repo but qemu-server. Misconfiguration on my side... On 7/15/19 3:34 PM, Aaron Lauterer wrote: Used `audio0` with the extra `0` to be able to add support for multiple audio devices in the future if it will ever be necessary. Cleaned some old

Re: [pve-devel] [PATCH docs 2/3] boot: mention pve-efiboot-tool earlier

2019-07-15 Thread Aaron Lauterer
On 7/15/19 3:51 PM, Fabian Grünbichler wrote: On Mon, Jul 15, 2019 at 03:39:59PM +0200, Aaron Lauterer wrote: On 7/15/19 3:07 PM, Fabian Grünbichler wrote: On Mon, Jul 15, 2019 at 02:37:45PM +0200, Aaron Lauterer wrote: Found a missing possible missing comma On 7/15/19 11:35 AM, Fabian

Re: [pve-devel] [PATCH docs 2/3] boot: mention pve-efiboot-tool earlier

2019-07-15 Thread Aaron Lauterer
Found a missing possible missing comma On 7/15/19 11:35 AM, Fabian Grünbichler wrote: Signed-off-by: Fabian Grünbichler --- system-booting.adoc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/system-booting.adoc b/system-booting.adoc index c7f6534..fc8d896 100644 ---

[pve-devel] [PATCH manager 1/3] Add audio device support

2019-07-15 Thread Aaron Lauterer
Used `audio0` with the extra `0` to be able to add support for multiple audio devices in the future if it will ever be necessary. Cleaned some old commented out code regarding audio device support. Signed-off-by: Aaron Lauterer --- PVE/QemuServer.pm | 36 ++-- 1

[pve-devel] [PATCH manager 3/3] Add permission setting for audio device

2019-07-15 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- PVE/API2/Qemu.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index e2a63be..8be0b7b 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -260,6 +260,7 @@ my $hwtypeoptions = { 'tablet' => 1, 'vga' =

[pve-devel] [PATCH manager 5/5] Add CSS for audio device icon

2019-07-15 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/css/ext6-pve.css | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/www/css/ext6-pve.css b/www/css/ext6-pve.css index 535f8e60..bfb6fc8d 100644 --- a/www/css/ext6-pve.css +++ b/www/css/ext6-pve.css @@ -279,7 +279,8 @@ .pve-itype

[pve-devel] [PATCH manager 1/5] Add edit dialog for audio device

2019-07-15 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/Makefile | 1 + www/manager6/qemu/AudioEdit.js | 61 ++ 2 files changed, 62 insertions(+) create mode 100644 www/manager6/qemu/AudioEdit.js diff --git a/www/manager6/Makefile b/www/manager6/Makefile index

[pve-devel] [PATCH manager 3/5] Add renderer for audio devices

2019-07-15 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/Utils.js | 15 +++ 1 file changed, 15 insertions(+) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 946b8709..3980b750 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -467,6 +467,21 @@ Ext.define

[pve-devel] [PATCH manager 4/5] Add icon for audio device

2019-07-15 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/images/Makefile | 7 --- www/images/icon-audio.svg | 2 ++ 2 files changed, 6 insertions(+), 3 deletions(-) create mode 100644 www/images/icon-audio.svg diff --git a/www/images/Makefile b/www/images/Makefile index b7e001f4..ac5ba7a4 100644

[pve-devel] [PATCH manager 2/5] Add audio device support to HardwareView

2019-07-15 Thread Aaron Lauterer
Including: * permission checks * disable button to add a new audio device if one already exists Signed-off-by: Aaron Lauterer --- www/manager6/qemu/HardwareView.js | 30 ++ 1 file changed, 30 insertions(+) diff --git a/www/manager6/qemu/HardwareView.js b/www

[pve-devel] [PATCH manager 2/3] Add PCI address for audio device

2019-07-15 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- PVE/QemuServer/PCI.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServer/PCI.pm index d847146..9c72f3a 100644 --- a/PVE/QemuServer/PCI.pm +++ b/PVE/QemuServer/PCI.pm @@ -79,6 +79,7 @@ my $devices = { 'virtio14

[pve-devel] [PATCH manager/qemu-server 0/8] #413 Add audio device support

2019-07-15 Thread Aaron Lauterer
Add support for audio devices on the CLI and GUI. Audio devices that can be selected are: * ich9-intel-hda * intel-hda (ich6) * AC97 (for older OS versions) Right now this supports only one audio device per VM but is written so that adding support for multiple audio devices should be easy to add.

Re: [pve-devel] [PATCH manager 4/5] Add icon for audio device

2019-07-16 Thread Aaron Lauterer
On 7/16/19 3:43 PM, Aaron Lauterer wrote: On 7/16/19 1:48 PM, Thomas Lamprecht wrote: On 7/15/19 3:34 PM, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer ---   www/images/Makefile   | 7 ---   www/images/icon-audio.svg | 2 ++   2 files changed, 6 insertions(+), 3 deletions

Re: [pve-devel] [PATCH qemu-server] Fix #2041, #2272 Add spice enhancements

2019-08-19 Thread Aaron Lauterer
I finally found some time to look into this. Answers are inline. On 8/12/19 5:34 PM, Thomas Lamprecht wrote: Am 7/29/19 um 10:59 AM schrieb Aaron Lauterer: This adds a new config option called `spice_enhancements` and two settings for it: * videostreaming * foldersharing Signed-off-by: Aaron

[pve-devel] [PATCH v3 qemu-server] Fix #2041, #2272 Add Spice enhancements

2019-08-22 Thread Aaron Lauterer
This adds a new config option called `spice_enhancements` with two optional settings: * videostreaming * foldersharing Signed-off-by: Aaron Lauterer --- v2 -> v3: Move the video-streaming string creation out of the '-spice' string for backwards compatibility. Remove the `// 0` from sett

[pve-devel] [PATCH v2 qemu-server] Fix #2041, #2272 Add Spice enhancements

2019-08-20 Thread Aaron Lauterer
This adds a new config option called `spice_enhancements` with two optional settings: * videostreaming * foldersharing Signed-off-by: Aaron Lauterer v1 -> v2: format changes suggested by dominik: * changed descriptions * changed `videostreaming` to enum refactoring suggested by thomas:

[pve-devel] [PATCH qemu-server 2/2] Fix local resources check for USB3 Spice devices

2019-08-30 Thread Aaron Lauterer
The check relied on the fact, that spice usb devices could not be usb3 in the past. Signed-off-by: Aaron Lauterer --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 6e3b19e..0a0fda7 100644 --- a/PVE/QemuServer.pm

[pve-devel] [PATCH manager] Add USB3 support for Spice USB redirection

2019-08-30 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/qemu/USBEdit.js | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/USBEdit.js b/www/manager6/qemu/USBEdit.js index 8fc95c99..20c30fe6 100644 --- a/www/manager6/qemu/USBEdit.js +++ b/www/manager6/qemu

[pve-devel] [PATCH qemu-server 1/2] Add USB3 support to Spice USB redirection

2019-08-30 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- PVE/QemuServer/USB.pm | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer/USB.pm b/PVE/QemuServer/USB.pm index a2097b9..05c78cf 100644 --- a/PVE/QemuServer/USB.pm +++ b/PVE/QemuServer/USB.pm @@ -87,9 +87,12 @@ sub

Re: [pve-devel] [PATCH docs] pve-network: add short section explaining Open vSwitch

2019-08-28 Thread Aaron Lauterer
On 8/28/19 9:42 AM, Thomas Lamprecht wrote: On 27.08.19 16:31, Aaron Lauterer wrote: On 8/27/19 12:27 PM, Christian Ebner wrote: Signed-off-by: Christian Ebner +In contrast to Linux virtual bridges, OVS bridges can carry multiple VLANs over +a sinlge bridge. # this is not true. by now

[pve-devel] [PATCH qemu-server] Fix #2343 Add USB3 support for Spice USB redirection

2019-08-28 Thread Aaron Lauterer
If USB3 is enabled for a USB port of host type spice add a USB3 controller and use it. To not break live migration this is only enabled for qemu 4.1 and higher. Signed-off-by: Aaron Lauterer --- PVE/QemuServer.pm | 4 ++-- PVE/QemuServer/USB.pm | 22 -- 2 files changed

Re: [pve-devel] [PATCH qemu-server] Fix #2343 Add USB3 support for Spice USB redirection

2019-08-28 Thread Aaron Lauterer
In a discussion with Stefan we came to the conclusion / realization that all the checks for $kvmver and $machine may not be necessary. This patch is most likely not correct the way it is now. More feedback is welcome :) On 8/28/19 4:26 PM, Aaron Lauterer wrote: If USB3 is enabled for a USB

[pve-devel] [PATCH qemu-server] Improve error output for queues

2019-08-26 Thread Aaron Lauterer
Add the name of the failed command to the error message, similar as the error messages when running a single command. --- Reason: I had a situation with a customer where we got an error but could not connect it to which command actually caused it. A similar but way hackier patch proved helpful to

Re: [pve-devel] [PATCH docs 1/2] Mention GUI for creating a cluster and adding nodes

2019-08-26 Thread Aaron Lauterer
Some things I would write differently. Mainly simpler, more precise language, avoiding clutter and reducing the amount of "you". On 8/22/19 4:53 PM, Stefan Reiter wrote: Signed-off-by: Stefan Reiter --- pvecm.adoc | 81 -- 1 file changed,

[pve-devel] [PATCH manager] Add support for up to 10 PCI devices

2019-09-02 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/qemu/HardwareView.js | 4 ++-- www/manager6/qemu/PCIEdit.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 606c66e5..28384d37 100644 --- a/www

[pve-devel] [PATCH qemu-server 0/1 pve-manager 0/1] Fix #2347 Support 10 PCI(e) devices

2019-09-02 Thread Aaron Lauterer
ports here is probably a bad idea and we need to create a new `pve-q35-4.1.cfg` file? But this would mean that the other changes could only be available once we ship Qemu 4.1? Aaron Lauterer (1): Add support for up to 10 PCI(e) devices qemu-server: PVE/QemuServer.pm | 2 +- PVE

[pve-devel] [PATCH qemu-server 1/1] Add support for up to 10 PCI(e) devices

2019-09-02 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- PVE/QemuServer.pm | 2 +- PVE/QemuServer/PCI.pm | 18 + pve-q35-4.0.cfg | 60 +++ 3 files changed, 79 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 6e3b19e

Re: [pve-devel] [PATCH qemu-server 1/2] Add USB3 support to Spice USB redirection

2019-09-02 Thread Aaron Lauterer
On 9/2/19 1:57 PM, Thomas Lamprecht wrote: On 8/30/19 9:40 AM, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer --- PVE/QemuServer/USB.pm | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer/USB.pm b/PVE/QemuServer/USB.pm index a2097b9..05c78cf

Re: [pve-devel] [PATCH docs] pve-network: add short section explaining Open vSwitch

2019-08-27 Thread Aaron Lauterer
Some notes from my side, changing sentence structure to put the important parts to the beginning and using a more active voice. Some typos and missed use of {pve} got changed as well. More inline :) On 8/27/19 12:27 PM, Christian Ebner wrote: Signed-off-by: Christian Ebner ---

[pve-devel] [PATCH manager] Add support for 16 PCI(e) devices

2019-09-05 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/qemu/HardwareView.js | 4 ++-- www/manager6/qemu/PCIEdit.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 606c66e5..cad29cc6 100644 --- a/www

[pve-devel] [PATCH v2 qemu-server 1/1] Add support for up to 16 PCI(e) devices

2019-09-05 Thread Aaron Lauterer
are created on demand. This helps to keep live migration possible without adding a new pve-q35*.cfg file. For the windows 7 like guests additional addresses are reserved as well. Signed-off-by: Aaron Lauterer --- I decided to move the creation of the device string for the additional root ports

[pve-devel] [PATCH v2 qemu-server 0/1 pve-manager 0/1] Fix #2347 Support 16 PCI(e) devices

2019-09-05 Thread Aaron Lauterer
com/pipermail/pve-devel/2019-September/038743.html Aaron Lauterer (2): Add support for up to 16 PCI(e) devices qemu-server: PVE/QemuServer.pm | 8 +++-- PVE/QemuServer/PCI.pm | 70 +++ 2 files changed, 76 insertions(+), 2 deletions(-) pve-manager:

Re: [pve-devel] [PATCH v2 qemu-server 1/1] Add support for up to 16 PCI(e) devices

2019-09-06 Thread Aaron Lauterer
On 9/6/19 2:45 PM, Dominik Csapak wrote: looks mostly ok, one (important) comment inline   # win7 is picky about pcie assignments   hostpci0bus0 => { bus => "pcie.0", addr => 16 },   hostpci1bus0 => { bus => "pcie.0", addr => 17 },   hostpci2bus0 => { bus => "pcie.0", addr =>

[pve-devel] [PATCH v3 qemu-server 2/3] Fix local resource check of Spice USB devices

2019-09-06 Thread Aaron Lauterer
set. Signed-off-by: Aaron Lauterer --- The proposed[0] /^spice(,)?$/ regex does not match the `usb3=1` part and fails. I opted for the simpler regex that checks if `spice` is that the beginning. [0]: https://pve.proxmox.com/pipermail/pve-devel/2019-September/038749.html PVE/QemuServer.pm | 2

[pve-devel] [PATCH v3 qemu-server pve-manager 0/3] Fix #2343 Spice USB3 support

2019-09-06 Thread Aaron Lauterer
upport Aaron Lauterer (3): (qemu-server) Add USB3 capablities to Spice USB devices (qemu-server) Fix local resource check of Spice USB devices (pve-manager) Enable USB3 for Spice USB passthrough qemu-server: PVE/QemuServer.pm | 4 ++-- PVE/QemuServer/USB.pm | 10 +++--- 2 files chan

[pve-devel] [PATCH v3 manager 3/3] Enable USB3 for Spice USB passthrough

2019-09-06 Thread Aaron Lauterer
Instead of having two times the check if the USB3 setting needs to be added to the config string it is now checked at one place only. If USB3 is checked for a non USB3 device it will be attached to the USB2 root hub of the xhci controller. Signed-off-by: Aaron Lauterer --- @Thomas: I hope I

[pve-devel] [PATCH v3 qemu-server 1/3] Add USB3 capablities to Spice USB devices

2019-09-06 Thread Aaron Lauterer
or the machine type was set to Q35 an ehci controller was present and the VM was able to boot. With this patch the behaviour is changing and the bus is set to xhci if USB3 is set for the Spice USB device and the VM is running under Qemu v4.1. Signed-off-by: Aaron Lauterer --- I use

[pve-devel] [PATCH manager 2/4] spice: Add enhancements form component

2019-09-13 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/Makefile | 1 + www/manager6/form/SpiceEnhancementSelector.js | 66 +++ 2 files changed, 67 insertions(+) create mode 100644 www/manager6/form/SpiceEnhancementSelector.js diff --git a/www/manager6/Makefile

[pve-devel] [PATCH manager 3/4] spice: Add enhancements to VM Options panel

2019-09-13 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/Utils.js| 18 ++ www/manager6/qemu/Options.js | 13 + 2 files changed, 31 insertions(+) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 6a489e7e..139200c3 100644 --- a/www/manager6/Utils.js +++ b

[pve-devel] [PATCH manager 1/4] Cleanup: align backslashes in manager6 Makefile

2019-09-13 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/Makefile | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/www/manager6/Makefile b/www/manager6/Makefile index 7ee7cd40..82e25c79 100644 --- a/www/manager6/Makefile +++ b/www/manager6/Makefile @@ -14,7 +14,7 @@ JSSRC

[pve-devel] [PATCH manager 4/4] spice: Add enhancements to VM Creation wizard

2019-09-13 Thread Aaron Lauterer
enabled if qxl/spice display selected Signed-off-by: Aaron Lauterer --- www/manager6/qemu/SystemEdit.js | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/SystemEdit.js b/www/manager6/qemu/SystemEdit.js index 846baa73..15ae9a73 100644

[pve-devel] [PATCH manager 0/4] Fix #2041, #2272 GUI for Spice Enhancements

2019-09-13 Thread Aaron Lauterer
about/appreciate feedback for: * the phrasing in the options panel * right now with this implementation the System tab in the VM creation wizard looks a bit unbalanced. [0]: https://pve.proxmox.com/pipermail/pve-devel/2019-September/038799.html Aaron Lauterer (4): Cleanup: align backslashes

[pve-devel] [PATCH docs 6/9] Rewrite Install from USB flash drive

2019-09-10 Thread Aaron Lauterer
Polished the phrasing, aligned different names for a USB flash drive, renamed OS X to macOS, changed primary recommendation for Windows to Rufus, removed mention of os forensics. Rufus now supports `dd` mode and is a much smaller download than etcher. Signed-off-by: Aaron Lauterer --- pve

[pve-devel] [PATCH docs 4/9] Rewrite Installation

2019-09-10 Thread Aaron Lauterer
Polished phrasing, added mentions of the EULA and summary page in the installer, unified style of cli commands. Signed-off-by: Aaron Lauterer --- pve-installation.adoc | 278 -- 1 file changed, 134 insertions(+), 144 deletions(-) diff --git a/pve

[pve-devel] [PATCH docs 1/9] Rewrite Getting Help

2019-09-10 Thread Aaron Lauterer
Polished phrasing Signed-off-by: Aaron Lauterer --- getting-help.adoc | 42 -- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/getting-help.adoc b/getting-help.adoc index 850d7a3..49d9085 100644 --- a/getting-help.adoc +++ b/getting

[pve-devel] [PATCH docs 2/9] Rewrite Improve PVE Docs

2019-09-10 Thread Aaron Lauterer
Polished phrasing Signed-off-by: Aaron Lauterer --- howto-improve-pve-docs.adoc | 42 + 1 file changed, 19 insertions(+), 23 deletions(-) diff --git a/howto-improve-pve-docs.adoc b/howto-improve-pve-docs.adoc index c0d277e..940e050 100644 --- a/howto-improve

[pve-devel] [PATCH docs 0/9] Documentation overhaul chapt. 1.9 to 3.2

2019-09-10 Thread Aaron Lauterer
are not yet happy with few things there. Aaron Lauterer (9): Rewrite Getting Help Rewrite Improve PVE Docs Rewrite Translation Rewrite Installation Rewrite System Requirements Rewrite Install from USB flash drive Rewrite Sysadmin Rewrite Package Repositories Rewrite System Software

[pve-devel] [PATCH docs 3/9] Rewrite Translation

2019-09-10 Thread Aaron Lauterer
Polished phrasing Signed-off-by: Aaron Lauterer --- translation.adoc | 38 -- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/translation.adoc b/translation.adoc index ff99296..21dd1eb 100644 --- a/translation.adoc +++ b/translation.adoc

[pve-devel] [PATCH docs 5/9] Rewrite System Requirements

2019-09-10 Thread Aaron Lauterer
Polished phrasing and restructured the requirements list a little bit Signed-off-by: Aaron Lauterer --- pve-system-requirements.adoc | 69 +++- 1 file changed, 36 insertions(+), 33 deletions(-) diff --git a/pve-system-requirements.adoc b/pve-system

[pve-devel] [PATCH docs 8/9] Rewrite Package Repositories

2019-09-10 Thread Aaron Lauterer
Polished phrasing, aligned cli command styling and line width Signed-off-by: Aaron Lauterer --- pve-package-repos.adoc | 154 + 1 file changed, 79 insertions(+), 75 deletions(-) diff --git a/pve-package-repos.adoc b/pve-package-repos.adoc index 06d1b2f

[pve-devel] [PATCH docs 9/9] Rewrite System Software Updates

2019-09-10 Thread Aaron Lauterer
Polished phrasing and aligned cli command styling Signed-off-by: Aaron Lauterer --- system-software-updates.adoc | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/system-software-updates.adoc b/system-software-updates.adoc index 04c17f3..bd5ff30

[pve-devel] [PATCH docs 7/9] Rewrite Sysadmin

2019-09-10 Thread Aaron Lauterer
Polished phrasing Signed-off-by: Aaron Lauterer --- sysadmin.adoc | 40 +++- 1 file changed, 15 insertions(+), 25 deletions(-) diff --git a/sysadmin.adoc b/sysadmin.adoc index e045610..9592c4a 100644 --- a/sysadmin.adoc +++ b/sysadmin.adoc @@ -5,31 +5,21

Re: [pve-devel] [PATCH v3 qemu-server 2/3] Fix local resource check of Spice USB devices

2019-09-10 Thread Aaron Lauterer
On 9/10/19 11:03 AM, Thomas Lamprecht wrote: On 06.09.19 15:26, Aaron Lauterer wrote: The check relied on the fact that in a regular use case a usb device of type spice would not have any other settings like `usb3=1`. An exact match worked fine for this. This patch changes the behaviour

Re: [pve-devel] [PATCH v3 qemu-server 1/3] Add USB3 capablities to Spice USB devices

2019-09-10 Thread Aaron Lauterer
On 9/10/19 10:46 AM, Thomas Lamprecht wrote: On 06.09.19 15:26, Aaron Lauterer wrote: To not change current behaviour and thus breaking live migration USB3 for a Spice USB device requires Qemu v4.1. The old behavior was that even though technically it was possible to the set `usb3=1` setting

[pve-devel] [PATCH v4 qemu-server 1/4] usb: Cleanup redundant if condition

2019-09-11 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- PVE/QemuServer/USB.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer/USB.pm b/PVE/QemuServer/USB.pm index a2097b9..2c09490 100644 --- a/PVE/QemuServer/USB.pm +++ b/PVE/QemuServer/USB.pm @@ -86,7 +86,7 @@ sub get_usb_devices

[pve-devel] [PATCH v4 0/4] Fix #2343 Spice USB3 support

2019-09-11 Thread Aaron Lauterer
one or with a following comma. Thanks Thomas for pointing out how to make it future proof v2 -> v3: * don't modify current behavior * fix local resource check * fix and cleanup GUI code v1 -> v2: * no qemu version checks * fix local resource check on migration * add GUI support Aaron Lauterer (

[pve-devel] [PATCH v4 qemu-server 2/4] usb: Add USB3 capabilities to Spice USB devices

2019-09-11 Thread Aaron Lauterer
or the machine type was set to Q35 an ehci controller was present and the VM was able to boot. With this patch the behaviour is changing and the bus is set to xhci if USB3 is set for the Spice USB device and the VM is running under Qemu v4.1. Signed-off-by: Aaron Lauterer --- I created the new

[pve-devel] [PATCH v4 qemu-server 3/4] usb: Fix local resource check of Spice USB devices

2019-09-11 Thread Aaron Lauterer
set. Signed-off-by: Aaron Lauterer --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 78ccf8c..05f0ab5 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2925,7 +2925,7 @@ sub check_local_resources

[pve-devel] [PATCH v4 manager 4/4] usb: Enable USB3 for Spice USB passthrough

2019-09-11 Thread Aaron Lauterer
Instead of having two times the check if the USB3 setting needs to be added to the config string it is now checked at one place only. If USB3 is checked for a non USB3 device it will be attached to the USB2 root hub of the xhci controller. Signed-off-by: Aaron Lauterer --- www/manager6/qemu

Re: [pve-devel] [PATCH manager 4/4] spice: Add enhancements to VM Creation wizard

2019-09-17 Thread Aaron Lauterer
ort titled "SPICE"? Yeah, the next version of this series will contain a different layout of that panel that should make it clearer. On 9/13/19 3:16 PM, Aaron Lauterer wrote: enabled if qxl/spice display selected Signed-off-by: Aaron Lauterer ---   www/manager6/qem

Re: [pve-devel] [PATCH manager 2/4] spice: Add enhancements form component

2019-09-17 Thread Aaron Lauterer
On 9/16/19 2:44 PM, Stefan Reiter wrote: Tried my hand at a proper code review, I like the patches in general. On 9/13/19 3:16 PM, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer ---   www/manager6/Makefile |  1 +   www/manager6/form/SpiceEnhancementSelector.js

Re: [pve-devel] [PATCH manager 3/4] spice: Add enhancements to VM Options panel

2019-09-17 Thread Aaron Lauterer
On 9/16/19 2:56 PM, Christian Ebner wrote: On September 16, 2019 2:44 PM Stefan Reiter wrote: +render_spice_enhancements: function(value) { + if (!value) { + return Proxmox.Utils.disabledText; + } + var props = PVE.Parser.parsePropertyString(value); +

Re: [pve-devel] [PATCH manager 3/4] spice: Add enhancements to VM Options panel

2019-09-17 Thread Aaron Lauterer
On 9/16/19 2:44 PM, Stefan Reiter wrote: On 9/13/19 3:16 PM, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer ---   www/manager6/Utils.js    | 18 ++   www/manager6/qemu/Options.js | 13 +   2 files changed, 31 insertions(+) diff --git a/www/manager6

[pve-devel] [PATCH manager v2 3/4] spice: Add enhanecements to VM Options panel

2019-09-17 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/Utils.js| 18 ++ www/manager6/qemu/Options.js | 13 + 2 files changed, 31 insertions(+) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 6a489e7e..a9adb382 100644 --- a/www/manager6/Utils.js +++ b

  1   2   3   4   >