Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

[Emmanuel Kasper]

On 09/19/2016 11:23 AM, Emmanuel Kasper wrote:
> On 09/19/2016 10:38 AM, Caspar Smit wrote:
>> Ok, but since the scsihw: 'virtio-scsi-pci' is set at the generic OSdefault
>> template and the w2k OSdefaults has a parent generic, doesn't that inherit
>> all settings from generic? Why else does it need a parent?
>>
>> As i read the code the 'w2k' OSdefaults are:
>>
>> busType: 'ide' (from generic parent)
>> scsihw: 'virtio-scsi-pci' (from generic parent)
>> networkCard: 'rtl8139' (from w2k template, overriding e1000 from generic)
>>
>> So creating a w2k VM will use IDE as default for disks so everything works,
>> BUT when you change IDE to SCSI you have to change the SCSI Controller too
>> (virtio-scsi-pci is not compatible with W2K). Wouldn't it be better to have
>> a 'sane' default SCSI controller for w2k?
> 
> I am wondering how often people install w2k from scratch this days on
> and then decide they want to switch from IDE to SCSI but since the
> change is trivial, I will propose a patch.

Can you also submit a bugzilla entry so we can properly track the issue
? ( https://bugzilla.proxmox.com/ )


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

[Emmanuel Kasper]

On 09/19/2016 10:38 AM, Caspar Smit wrote:
> Ok, but since the scsihw: 'virtio-scsi-pci' is set at the generic OSdefault
> template and the w2k OSdefaults has a parent generic, doesn't that inherit
> all settings from generic? Why else does it need a parent?
> 
> As i read the code the 'w2k' OSdefaults are:
> 
> busType: 'ide' (from generic parent)
> scsihw: 'virtio-scsi-pci' (from generic parent)
> networkCard: 'rtl8139' (from w2k template, overriding e1000 from generic)
> 
> So creating a w2k VM will use IDE as default for disks so everything works,
> BUT when you change IDE to SCSI you have to change the SCSI Controller too
> (virtio-scsi-pci is not compatible with W2K). Wouldn't it be better to have
> a 'sane' default SCSI controller for w2k?

I am wondering how often people install w2k from scratch this days on
and then decide they want to switch from IDE to SCSI but since the
change is trivial, I will propose a patch.

BTW w2k3 would also be a candidate here for keeping lsi as:
 * it does not support any kind VirtIO ( ie nothing for w2k3 in the last
VirtIO iso)
 * when we researched it, we found out w2k3 also includes the LSI drivers



___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

[Caspar Smit]

Ok, but since the scsihw: 'virtio-scsi-pci' is set at the generic OSdefault
template and the w2k OSdefaults has a parent generic, doesn't that inherit
all settings from generic? Why else does it need a parent?

As i read the code the 'w2k' OSdefaults are:

busType: 'ide' (from generic parent)
scsihw: 'virtio-scsi-pci' (from generic parent)
networkCard: 'rtl8139' (from w2k template, overriding e1000 from generic)

So creating a w2k VM will use IDE as default for disks so everything works,
BUT when you change IDE to SCSI you have to change the SCSI Controller too
(virtio-scsi-pci is not compatible with W2K). Wouldn't it be better to have
a 'sane' default SCSI controller for w2k?


Kind regards,
Caspar Smit

2016-09-19 10:18 GMT+02:00 Emmanuel Kasper :

> On 09/16/2016 03:11 PM, Caspar Smit wrote:
> > Hi,
> >
> > I'm assuming this commit will break the 'w2k' pveOS default (because the
> > scsihw will be inherited from generic):
>
> not really, because presetting a different kind of SCSI controller will
> not impact the _default_ controller which will still be IDE
> for all new VMs except l26
>
>
>
> ___
> pve-devel mailing list
> pve-devel@pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

[Emmanuel Kasper]

On 09/16/2016 03:11 PM, Caspar Smit wrote:
> Hi,
> 
> I'm assuming this commit will break the 'w2k' pveOS default (because the
> scsihw will be inherited from generic):

not really, because presetting a different kind of SCSI controller will
not impact the _default_ controller which will still be IDE
for all new VMs except l26



___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

[Alexandre DERUMIER]

I think that w2k don't support virtio-scsi driver.
(same for linux 2.4)


- Mail original -
De: "Dominik Csapak" <d.csa...@proxmox.com>
À: "pve-devel" <pve-devel@pve.proxmox.com>
Envoyé: Vendredi 16 Septembre 2016 15:19:17
Objet: Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for 
new VMS fix #1106

On 09/16/2016 03:11 PM, Caspar Smit wrote: 
> Hi, 
> 
> I'm assuming this commit will break the 'w2k' pveOS default (because the 
> scsihw will be inherited from generic): 
> 

what will be broken? 

existing vms do not change, only newly created get a different default 
scsi controller so there is no problem? (you have to install the drivers 
of course, but in case you want scsi you would have to install them anyway?) 


___ 
pve-devel mailing list 
pve-devel@pve.proxmox.com 
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel 

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

[Dominik Csapak]

On 09/16/2016 03:11 PM, Caspar Smit wrote:

Hi,

I'm assuming this commit will break the 'w2k' pveOS default (because the
scsihw will be inherited from generic):



what will be broken?

existing vms do not change, only newly created get a different default 
scsi controller so there is no problem? (you have to install the drivers 
of course, but in case you want scsi you would have to install them anyway?)



___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

[Caspar Smit]

Hi,

I'm assuming this commit will break the 'w2k' pveOS default (because the
scsihw will be inherited from generic):

Here's a fix for that (sorry for not submitting a proper patch, i did a
quick diff on the pvemanagerlib.js):

@@ -17684,7 +17684,8 @@
addOS({
pveOS: 'w2k',
parent : 'generic',
-   networkCard: 'rtl8139'
+   networkCard: 'rtl8139',
+   scsihw: 'lsi'
});

 }

Kind regards,
Caspar

2016-09-15 9:34 GMT+02:00 Emmanuel Kasper :

> ---
>  www/manager6/qemu/HDEdit.js | 4 
>  www/manager6/qemu/OSDefaults.js | 3 ++-
>  2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
> index c86ab44..312b218 100644
> --- a/www/manager6/qemu/HDEdit.js
> +++ b/www/manager6/qemu/HDEdit.js
> @@ -111,6 +111,10 @@ Ext.define('PVE.qemu.HDInputPanel', {
>
> params[confid] = PVE.Parser.printQemuDrive(me.drive);
>
> +   if (me.insideWizard) {
> +   params.scsihw = PVE.qemu.OSDefaults.generic.scsihw;
> +   }
> +
> return params;
>  },
>
> diff --git a/www/manager6/qemu/OSDefaults.js b/www/manager6/qemu/
> OSDefaults.js
> index 3a834fa..7ebfef0 100644
> --- a/www/manager6/qemu/OSDefaults.js
> +++ b/www/manager6/qemu/OSDefaults.js
> @@ -36,7 +36,8 @@ Ext.define('PVE.qemu.OSDefaults', {
> // default values
> me.generic = {
> busType: 'ide',
> -   networkCard: 'e1000'
> +   networkCard: 'e1000',
> +   scsihw: 'virtio-scsi-pci'
> };
>
> // both of them are in kernel since 2.6.25
> --
> 2.1.4
>
>
> ___
> pve-devel mailing list
> pve-devel@pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

[Dietmar Maurer]

applied

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 1/2] virtio-scsi-pci as default SCSI for new VMS fix #1106

[Emmanuel Kasper]

---
 www/manager6/qemu/HDEdit.js | 4 
 www/manager6/qemu/OSDefaults.js | 3 ++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
index c86ab44..312b218 100644
--- a/www/manager6/qemu/HDEdit.js
+++ b/www/manager6/qemu/HDEdit.js
@@ -111,6 +111,10 @@ Ext.define('PVE.qemu.HDInputPanel', {

params[confid] = PVE.Parser.printQemuDrive(me.drive);

+   if (me.insideWizard) {
+   params.scsihw = PVE.qemu.OSDefaults.generic.scsihw;
+   }
+
return params;  
 },
 
diff --git a/www/manager6/qemu/OSDefaults.js b/www/manager6/qemu/OSDefaults.js
index 3a834fa..7ebfef0 100644
--- a/www/manager6/qemu/OSDefaults.js
+++ b/www/manager6/qemu/OSDefaults.js
@@ -36,7 +36,8 @@ Ext.define('PVE.qemu.OSDefaults', {
// default values
me.generic = {
busType: 'ide',
-   networkCard: 'e1000'
+   networkCard: 'e1000',
+   scsihw: 'virtio-scsi-pci'
};
 
// both of them are in kernel since 2.6.25
-- 
2.1.4


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel