Re: [pve-devel] [PATCH] Usability: enhance password label in LXC wizzard

2015-07-31 Thread Daniel Hunsaker
 And what if the language is read from right to left, eg. Chinese?

That's why the %s is part of the string to be translated, you can always
add a formatting convention that would flip the inserted string ;-

)



Readers in rtl languages (which rarely use Latin characters to begin with)
tend to expect untranslated words will remain unflipped as well - so
drowssap root would be expected, while drowssap toor would just look
odd.  It's also worth noting, here, that we have a plethora of other
untranslated terms scattered throughout the existing translations, so
whatever mechanism those are using is probably the (currently) preferred
one.  I'd suggest taking a peek at a few to see what's already being done
in this area.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] Usability: enhance password label in LXC wizzard

2015-07-31 Thread Michael Rasmussen
On Fri, 31 Jul 2015 07:51:26 +0200
Wolfgang Bumiller w.bumil...@proxmox.com wrote:

 
 Word order may differ across languages, though. The ideal solution would
 be to use a formatting print with a string like %s password, but this
 one would need to be translated, too, unless it's already available.
 
And what if the language is read from right to left, eg. Chinese?

-- 
Hilsen/Regards
Michael Rasmussen

Get my public GnuPG keys:
michael at rasmussen dot cc
http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xD3C9A00E
mir at datanom dot net
http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE501F51C
mir at miras dot org
http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE3E80917
--
/usr/games/fortune -es says:
Q:  Why does Washington have the most lawyers per capita and
New Jersey the most toxic waste dumps?
A:  God gave New Jersey first choice.


pgptw2svVKJLw.pgp
Description: OpenPGP digital signature
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] Usability: enhance password label in LXC wizzard

2015-07-31 Thread Wolfgang Bumiller
On Fri, Jul 31, 2015 at 09:30:44AM +0200, Michael Rasmussen wrote:
 On Fri, 31 Jul 2015 07:51:26 +0200
 Wolfgang Bumiller w.bumil...@proxmox.com wrote:
 
  
  Word order may differ across languages, though. The ideal solution would
  be to use a formatting print with a string like %s password, but this
  one would need to be translated, too, unless it's already available.
  
 And what if the language is read from right to left, eg. Chinese?

That's why the %s is part of the string to be translated, you can always
add a formatting convention that would flip the inserted string ;-)
(I wonder why printf has no option for this yet...
  %s password = drowssap %Rs or something :-P)


signature.asc
Description: Digital signature
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] Usability: enhance password label in LXC wizzard

2015-07-30 Thread Thomas Lamprecht

How about:

fieldLabel: 'root ' + gettext('password'),


So it's clear and translation doesn't becomes a problem.

On 07/30/2015 12:46 PM, Dietmar Maurer wrote:

I am not keen to to add that, because we need to re-translate it for all
languages.
Worse, 'root' is a system name, and it is quite unclear how to translate that
;-)

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel




___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] Usability: enhance password label in LXC wizzard

2015-07-30 Thread Dietmar Maurer
 How about:
 
 fieldLabel: 'root ' + gettext('password'),
 
 
 So it's clear and translation doesn't becomes a problem.

This does not need to be the 'root' password at all (although it is currently)?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] Usability: enhance password label in LXC wizzard

2015-07-30 Thread Thomas Lamprecht



On 07/30/2015 04:02 PM, Dietmar Maurer wrote:

How about:

fieldLabel: 'root ' + gettext('password'),


So it's clear and translation doesn't becomes a problem.

This does not need to be the 'root' password at all (although it is currently)?
Yes, currently it's root. And the code suggests also that is the 
purpose, in pve-container/src/PVE/API2/LXC.pm we have the following 
parameter description in the create_vm method:

password = {
optional = 1,
type = 'string',
description = Sets root password inside container.,
minLength = 5,
},

And it's also hard coded root in the Base.pm plugin for LXCSetup:

$self-set_user_password($conf, 'root', $root_password);


and for container it's always the root password, AFAIK. But I have 
absolutely no problems if it stays like it is :D



___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] Usability: enhance password label in LXC wizzard

2015-07-30 Thread Wolfgang Bumiller
On Thu, Jul 30, 2015 at 02:33:42PM +0200, Thomas Lamprecht wrote:
 How about:
 
 fieldLabel: 'root ' + gettext('password'),
 
 
 So it's clear and translation doesn't becomes a problem.

Word order may differ across languages, though. The ideal solution would
be to use a formatting print with a string like %s password, but this
one would need to be translated, too, unless it's already available.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] Usability: enhance password label in LXC wizzard

2015-07-30 Thread Thomas Lamprecht



On 07/31/2015 07:51 AM, Wolfgang Bumiller wrote:

On Thu, Jul 30, 2015 at 02:33:42PM +0200, Thomas Lamprecht wrote:

How about:

fieldLabel: 'root ' + gettext('password'),


So it's clear and translation doesn't becomes a problem.

Word order may differ across languages, though. The ideal solution would
be to use a formatting print with a string like %s password, but this
one would need to be translated, too, unless it's already available.
This one should be a bit better, and language independent, I'm no 
language expert, though :D


 gettext('Password') + ' (root)';

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH] Usability: enhance password label in LXC wizzard

2015-07-30 Thread Dietmar Maurer
I am not keen to to add that, because we need to re-translate it for all
languages.
Worse, 'root' is a system name, and it is quite unclear how to translate that
;-)

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel