Re: [pypy-dev] unaligned raw_load (align_float_cast branch)

2014-02-23 Thread Armin Rigo
Hi Brian, On 23 February 2014 20:14, Brian Kearns wrote: > I believe all of them in micronumpy are at risk -- any type could be a > subtype of a record type consisting of something like a single char followed > by whatever type. I agree about the ones in the types.py module, but there are more i

Re: [pypy-dev] unaligned raw_load (align_float_cast branch)

2014-02-23 Thread Brian Kearns
I believe all of them in micronumpy are at risk -- any type could be a subtype of a record type consisting of something like a single char followed by whatever type. On Sun, Feb 23, 2014 at 1:43 AM, Armin Rigo wrote: > Hi Matti, > > I've checked in some new code in rawstorage.py on default: > r

Re: [pypy-dev] unaligned raw_load (align_float_cast branch)

2014-02-23 Thread Armin Rigo
Hi Matti, I've checked in some new code in rawstorage.py on default: raw_storage_{get,set}item_unaligned(). It's regular RPython code that checks if the argument is aligned or not, and if not, it falls back to a memcpy(). It should be relatively jit-friendly. Note that I also changed the non-un

Re: [pypy-dev] unaligned raw_load (align_float_cast branch)

2014-02-22 Thread Matti Picus
Thanks for taking a look. My immediate goal is to get micronumpy tests passing on ARM. micronumpy uses raw_storage_getitem, which needs to be fixed. I thought nonaligned access would be a problem in other parts of pypy, but do not have the perspective to judge that, so I tried to stick xxx in al

Re: [pypy-dev] unaligned raw_load (align_float_cast branch)

2014-02-22 Thread Armin Rigo
Hi Matti, On 18 February 2014 14:05, matti picus wrote: > I would like to ask for help with this branch, as I have not been able to > move it forward fast enough. I moved it forward a little bit, but now I'm wondering if it actually makes sense. What is the goal? Is it to fix a problem in ctyp

[pypy-dev] unaligned raw_load (align_float_cast branch)

2014-02-18 Thread matti picus
I would like to ask for help with this branch, as I have not been able to move it forward fast enough. micronumpy tests crash on ARM, due to issues accessing raw memory in struct arrays. It turn out that casting unaligned memory to a float or double causes a segfault on ARM, I started to fix this