Re: [pytest-dev] extended asserts

2014-08-04 Thread holger krekel
Hi Floris, On Fri, Aug 01, 2014 at 22:09 +0100, Floris Bruynooghe wrote: Hi, On 29 July 2014 09:24, Anatoly Bubenkov bubenk...@gmail.com wrote: what do you think about extending the existing assert representation with this https://pypi.python.org/pypi/datadiff would be nice if we

Re: [pytest-dev] extended asserts

2014-08-04 Thread Floris Bruynooghe
On 4 August 2014 08:35, holger krekel hol...@merlinux.eu wrote: On Fri, Aug 01, 2014 at 22:09 +0100, Floris Bruynooghe wrote: * Re-write what datadiff produces directly inside _pytest/assertion/utils.py. It's not that a crazy task. This is only a bad idea if datadiff keeps evolving a lot,

Re: [pytest-dev] extended asserts

2014-08-02 Thread Anatoly Bubenkov
On 1 August 2014 23:09, Floris Bruynooghe f...@devork.be wrote: So datadiff is not as good as comparing strings then what py.test does now? it doesn't even support such comparison - raises notimplemented We should always strive to make the assertions better. If you think they can be

Re: [pytest-dev] extended asserts

2014-08-02 Thread Floris Bruynooghe
On 2 August 2014 10:08, Anatoly Bubenkov bubenk...@gmail.com wrote: On 1 August 2014 23:09, Floris Bruynooghe f...@devork.be wrote: * Vendor datadiff, I think the licenses are compatible. by vendoring you mean using it as a dependency? No, vendoring means taking the datadiff source and

Re: [pytest-dev] extended asserts

2014-08-01 Thread Floris Bruynooghe
Hi, On 29 July 2014 09:24, Anatoly Bubenkov bubenk...@gmail.com wrote: what do you think about extending the existing assert representation with this https://pypi.python.org/pypi/datadiff would be nice if we could extend datadiff with what pytest does for string diff So datadiff is not as

[pytest-dev] extended asserts

2014-07-29 Thread Anatoly Bubenkov
what do you think about extending the existing assert representation with this https://pypi.python.org/pypi/datadiff would be nice if we could extend datadiff with what pytest does for string diff and then just use datadiff for all assertions because for now, it's not too useful to see a

Re: [pytest-dev] extended asserts

2014-07-29 Thread Bruno Oliveira
Hi, Perhaps this could a plugin (pytest-datadiff)? I know you can customize assertion messages for other types (see http://pytest.org/latest/assert.html#defining-your-own-assertion-comparison), but I don't know how that plays with assertions already built in pytest. Cheers, On Tue, Jul 29,

Re: [pytest-dev] extended asserts

2014-07-29 Thread Bruno Oliveira
Nice, be sure to keep the mailing list informed. :) Cheers, On Tue, Jul 29, 2014 at 5:17 PM, Anatoly Bubenkov bubenk...@gmail.com wrote: Yes I'll do it as a separate plugin first Then we can think about including it in the core On Jul 29, 2014 9:46 PM, Bruno Oliveira nicodde...@gmail.com

Re: [pytest-dev] extended asserts

2014-07-29 Thread Anatoly Bubenkov
Yes I'll do it as a separate plugin first Then we can think about including it in the core On Jul 29, 2014 9:46 PM, Bruno Oliveira nicodde...@gmail.com wrote: Hi, Perhaps this could a plugin (pytest-datadiff)? I know you can customize assertion messages for other types (see