[issue19145] Inconsistent behaviour in itertools.repeat when using negative times

2014-01-26 Thread Vajrasky Kok
Vajrasky Kok added the comment: How to handle this "problem" in Python maintenance releases (2.7, 3.3 and soon-to-be 3.4) is being discussed here: https://mail.python.org/pipermail/python-dev/2014-January/132101.html In case, we are taking "backporting the full fix" road, here is the patch. I

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

2014-01-26 Thread Nick Coghlan
Nick Coghlan added the comment: Assigning to myself to make it clear that bltinmodule is the only part of this still under consideration for 3.4. The test_pydoc and test_gdb failures pointed to real issues with the previous patch: - the pydoc errors themselves were incidental, indicating that

[issue19966] Wrong mtimes of Include/Python-ast.h and Python/Python-ast.c in tarballs

2014-01-26 Thread Georg Brandl
Georg Brandl added the comment: OK, 3.3.4rc1 shouldn't have the problem, and neither 3.4.0b4 ff. with the changes I just checked into hgtouch. -- ___ Python tracker ___

[issue19966] Wrong mtimes of Include/Python-ast.h and Python/Python-ast.c in tarballs

2014-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0279445c05d5 by Georg Brandl in branch 'default': Closes #19966: allow hgtouch to operate on a base dir that is != the repo root. http://hg.python.org/cpython/rev/0279445c05d5 -- nosy: +python-dev resolution: -> fixed stage: -> committed/r

[issue20405] Add io.BinaryTransformWrapper and a "transform" parameter to open()

2014-01-26 Thread Nick Coghlan
Nick Coghlan added the comment: That's certainly a reasonable position to take - they use the same object->object model that the codecs module in general provides, which means Python 3.x can already handle the relevant use cases. Any such PEP would be about deciding whether or not binary trans

[issue15189] tkinter.messagebox does not use the application's icon

2014-01-26 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue20394] Coverity complains on audioop

2014-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: If Coverity is silenced, this patch should be backported to 2.7 and 3.3. -- ___ Python tracker ___ ___

[issue20405] Add io.BinaryTransformWrapper and a "transform" parameter to open()

2014-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think this is redundant because codecs.StreamReader and codecs.StreamWriter already exist. They are buggy, but now they are less buggy then at the time when Victor wrote PEP 400 and can be improved more. TextIOWrapper serves important special case, but for

[issue20173] Derby #4: Convert 53 sites to Argument Clinic across 5 files

2014-01-26 Thread Vajrasky Kok
Vajrasky Kok added the comment: Here is the updated patch for sha256module after changes from Larry to clinic. -- Added file: http://bugs.python.org/file33739/clinic_sha256module_v3.patch ___ Python tracker ___

[issue19620] tokenize documentation contains typos (argment instead of argument)

2014-01-26 Thread Christopher Welborn
Changes by Christopher Welborn : -- nosy: -cjwelborn ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue19620] tokenize documentation contains typos (argment instead of argument)

2014-01-26 Thread Christopher Welborn
Christopher Welborn added the comment: I should've made the patch, sorry about that. I got really busy and by the time I came back it had been fixed already. (fast turnaround :) I'm just glad it got fixed. I'm removing myself from the nosy-list. -- _

[issue20386] socket.SocketType enum overwrites import of _socket.SocketType

2014-01-26 Thread Georg Brandl
Georg Brandl added the comment: "integer enumerations of " sounds weird to me. Also, here it might be nice to link to IntEnum (use :class:`.IntEnum`). -- ___ Python tracker ___

[issue20401] inspect.signature removes initial starred method params (bug)

2014-01-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: Sorry, I should have said that I tried repository versions of both 3.3 and 3.4. -- ___ Python tracker ___ __

[issue20404] Delayed exception using non-text encodings with TextIOWrapper

2014-01-26 Thread Nick Coghlan
Nick Coghlan added the comment: I also created issue 20405 as an RFE for 3.5, since it seems there is a possible gap in capability relative to Python 2 here. -- ___ Python tracker _

[issue20405] Add io.BinaryTransformWrapper and a "transform" parameter to open()

2014-01-26 Thread Nick Coghlan
New submission from Nick Coghlan: Issue 20404 points out that io.TextIOWrapper can't be used with binary transform codecs like bz2 because the types are wrong. By contrast, codecs.open() still defaults to working in binary mode, and just switches to returning a different type based on the spec

[issue7776] http.client.HTTPConnection tunneling is broken

2014-01-26 Thread Nikolaus Rath
Nikolaus Rath added the comment: Thanks for the review! I've attached an updated patch. An update to the set_tunnel library documentation is being discussed in issue 11448. I'm not sure how to best handle the overlap. Maybe the best way is to first deal with issue 11448, and then add the chang

[issue20404] Delayed exception using non-text encodings with TextIOWrapper

2014-01-26 Thread Nick Coghlan
New submission from Nick Coghlan: TextIOWrapper doesn't check the codec type early the way the convenience methods now do, so the open() method currently still suffers from the problems Victor described in issue 19619 for str.encode() and bytes.decode(): >>> with open("hex.txt", 'w') as f: ...

[issue15216] Support setting the encoding on a text stream after creation

2014-01-26 Thread Nick Coghlan
Nick Coghlan added the comment: That's entirely plausible - Victor's current patch is definitely a proof-of-concept rather than a battle-tested implementation. I'm not sure you could actually *provoke* that bug with any of our existing codecs, though. -- _

[issue15216] Support setting the encoding on a text stream after creation

2014-01-26 Thread Nikolaus Rath
Nikolaus Rath added the comment: Thanks Nick! Will take this into account. I've stumbled over another question in the meantime: It seems to me that after the call to set_encoding(), self._snapshot contains the decoder flags from the state of the *old* decoder. On the next call of eg. tell(),

[issue20401] inspect.signature removes initial starred method params (bug)

2014-01-26 Thread Yury Selivanov
Yury Selivanov added the comment: Yes, that's s bug. I'll take a look tomorrow. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue20366] SQLite FTS (full text search)

2014-01-26 Thread Tshepang Lekhonkhobe
Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue20173] Derby #4: Convert 53 sites to Argument Clinic across 5 files

2014-01-26 Thread Vajrasky Kok
Vajrasky Kok added the comment: Here is the updated patch for sha1module after changes from Larry to clinic. -- Added file: http://bugs.python.org/file33737/clinic_sha1module_v5.patch ___ Python tracker ___

[issue20338] Idle: increase max calltip width

2014-01-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: Actually, all new-style classes .__new__ and .__init__ from object if not over-ridden. The calltip code depends on the .__init__ inheritance. -- ___ Python tracker ___

[issue19145] Inconsistent behaviour in itertools.repeat when using negative times

2014-01-26 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: If "equivalent to" code is not considered to be part of documentation, then the meaning of negative times should be documented. -- nosy: +belopolsky ___ Python tracker _

[issue12704] Language Reference: Clarify behaviour of yield when generator is not resumed

2014-01-26 Thread Benjamin Peterson
Benjamin Peterson added the comment: Thank you. In the future, please remember to wrap paragraphs to 80 chars and run "make patchcheck" to cleanup whitespace issues. -- nosy: +benjamin.peterson ___ Python tracker

[issue12704] Language Reference: Clarify behaviour of yield when generator is not resumed

2014-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset e02da391741f by Benjamin Peterson in branch '3.3': eliminate redundancy between yield stmt and yield expr docs (closes #12704) http://hg.python.org/cpython/rev/e02da391741f New changeset c6b4a5354c23 by Benjamin Peterson in branch 'default': merge 3

[issue20401] inspect.signature removes initial starred method params (bug)

2014-01-26 Thread Larry Hastings
Larry Hastings added the comment: I just tried it in 3.3 (3.3.1rc1) and it had the same problem. -- ___ Python tracker ___ ___ Python-

[issue20401] inspect.signature removes initial starred method params (bug)

2014-01-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: There does not appear to be a test for this. If so, this case may not have ever worked right. Here is the only failure at the moment (which should also be fixed). F:\Python\dev>4\py34\pcbuild\python_d.exe -m test test_inspect [1/1] test_inspect test test_inspe

[issue15216] Support setting the encoding on a text stream after creation

2014-01-26 Thread Nick Coghlan
Nick Coghlan added the comment: A given encoding may have multiple aliases, and also variant spellings that are normalized before doing the codec lookup. Doing the lookup first means we run through all of the normalisation and aliasing machinery and then compare the *canonical* names. For exam

[issue17721] Help button on preference window doesn't work

2014-01-26 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- assignee: -> terry.reedy resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue17721] Help button on preference window doesn't work

2014-01-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: #20403 is about making Help work and putting the button back. -- ___ Python tracker ___ ___ Python-b

[issue20403] Idle options dialog: add help

2014-01-26 Thread Terry J. Reedy
New submission from Terry J. Reedy: The Idle options/configuration dialog had a useless Help button that did nothing. #17721 commented out the creation and packing of the button. This issue is about making the Help method work. Perhaps it should open the general help document at the options se

[issue7776] http.client.HTTPConnection tunneling is broken

2014-01-26 Thread Benjamin Peterson
Benjamin Peterson added the comment: A few comments - Your docstring for set_tunnel claims the method sends CONNECT when it in fact doesn't touch the network at all. - Instead of 3 parallel arrays for tunnel information, it would be better to have a TunnelInfo class to contain host/port/headers

[issue17721] Help button on preference window doesn't work

2014-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3d343dfe6269 by Terry Jan Reedy in branch '2.7': Issue #17721: Remove non-functional configuration dialog help button until we http://hg.python.org/cpython/rev/3d343dfe6269 New changeset 6e4b94019eae by Terry Jan Reedy in branch '3.3': Issue #17721:

[issue20402] List comprehensions should be noted in for loop documentation

2014-01-26 Thread Rob Lanphier
New submission from Rob Lanphier: The current list comprehension documentation is difficult to find for someone who doesn't know what a list comprehension is. Example of this problem: http://www.reddit.com/r/learnprogramming/comments/1w6slm/different_kind_of_for_loop_python/ Since list compreh

[issue19903] Idle: Use inspect.signature for calltips

2014-01-26 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- dependencies: +inspect.signature does not support new functools.partialmethod, inspect.signature removes initial starred method params (bug) ___ Python tracker __

[issue20401] inspect.signature removes initial starred method params (bug)

2014-01-26 Thread Larry Hastings
Larry Hastings added the comment: Yury, can you look in to this? I have been modifying inspect.signature, but (almost) exclusively in from_builtin. If this is my fault I'll be happy to fix it. -- nosy: +larry ___ Python tracker

[issue20401] inspect.signature removes initial starred method params (bug)

2014-01-26 Thread Terry J. Reedy
New submission from Terry J. Reedy: >>> import inspect >>> class C: def meth(*args): pass >>> str(inspect.signature(C.meth)) '(*args)' >>> c=C() >>> str(s=inspect.signature(c.meth)) '()' *args should have been left in even for the bound method, as idlelib calltips do. Since '*'

[issue15216] Support setting the encoding on a text stream after creation

2014-01-26 Thread Nikolaus Rath
Nikolaus Rath added the comment: Second question: The following looks as if a BOM might be written for writeable, non-seekable streams: # don't write a BOM in the middle of a file if self._seekable and self.writable(): position = self.buffer.tell() if po

[issue15216] Support setting the encoding on a text stream after creation

2014-01-26 Thread Nikolaus Rath
Nikolaus Rath added the comment: Question: What is the point of the old_encoding = codecs.lookup(self._encoding).name encoding = codecs.lookup(encoding).name if encoding == old_encoding and errors == self._errors: # no change return dance? Isn't

[issue19081] zipimport behaves badly when the zip file changes while the process is running

2014-01-26 Thread Gregory P. Smith
Gregory P. Smith added the comment: Updated to make that function (zipimporter_init) easier to follow by not repurposing the path variable mid-function and allocate the local path buffer rather than keeping it on the stack. -- Added file: http://bugs.python.org/file33736/issue19081-sub

[issue20338] Idle: increase max calltip width

2014-01-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: I increased indent to 4 spaces and made it easier to change. I believe old-styles classes do not have .__new__, so test of TextWrapper will ensure that they work. Inspect.signature should have correct logic to handle .__new__, with or without .__init__. (I pr

[issue20399] Comparison of memoryview

2014-01-26 Thread Antoine Pitrou
Antoine Pitrou added the comment: This sounds reasonable, at least when the two memoryviews have the same shape. -- components: +Interpreter Core -Library (Lib) nosy: +pitrou, skrah type: behavior -> enhancement ___ Python tracker

[issue20338] Idle: increase max calltip width

2014-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset d960c4cabb2b by Terry Jan Reedy in branch '2.7': Issue #20338: Increase allowed tip width slightly and wrap long signagure lines. http://hg.python.org/cpython/rev/d960c4cabb2b New changeset 7dcc19308a7b by Terry Jan Reedy in branch '3.3': Issue #203

[issue20391] windows python launcher should support explicit 64-bit version

2014-01-26 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue19023] ctypes docs: Unimplemented and undocumented features

2014-01-26 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +amaury.forgeotdarc, belopolsky, meador.inge ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue20394] Coverity complains on audioop

2014-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset bf52f2dbfdde by Christian Heimes in branch 'default': Issue #20394: Attempt to silence CID 1164423: Division or modulo by zero in audioop_ratecv_impl() http://hg.python.org/cpython/rev/bf52f2dbfdde -- nosy: +python-dev

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

2014-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset c2e425a05d35 by Christian Heimes in branch 'default': Issue #20193: Fix commit r6f217456b9ba by including clinic/zlibmodule.c.h instead http://hg.python.org/cpython/rev/c2e425a05d35 -- ___ Python tracker

[issue20395] Extract generated clinic code in Modules/_pickle.c to separate file

2014-01-26 Thread Alexandre Vassalotti
Alexandre Vassalotti added the comment: +1 from me as well for a separate file. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue20394] Coverity complains on audioop

2014-01-26 Thread Christian Heimes
Christian Heimes added the comment: Coverity is concerned about the value of `q` when `len < 0`. The expression Py_ssize_t q = len > 0 ? 1 + (len - 1) / inrate : 0; returns a positive, non-null value for len > 0. Another check ensures that len != 0 a couple of lines earlier. In theory it is

[issue20367] concurrent.futures.as_completed() fails when given duplicate Futures

2014-01-26 Thread Glenn Langford
Glenn Langford added the comment: @Victor: Thank you, and I appreciate all your advice! I am still learning the dev environment but hope to be helpful. :) -- ___ Python tracker

[issue20400] Add create_read_pipe_protocol/create_write_pipe_protocol to asyncio.SubprocessProtocol

2014-01-26 Thread STINNER Victor
New submission from STINNER Victor: I reported the issue in Tulip project: http://code.google.com/p/tulip/issues/detail?id=115 I consider this issue as as serious API flaw and I would like to fix it before Python 3.4 final. -- messages: 209366 nosy: gvanrossum, haypo, larry priority: r

[issue19456] ntpath doesn't join paths correctly when a drive is present

2014-01-26 Thread Merlijn van Deen
Merlijn van Deen added the comment: I'm not sure whether that question was aimed at me -- I think both options have their merits, but I'd suggest to adopt the .NET semantics. The semantics are also explicitly defined [1] and the behavior seems to be acceptable for the .NET world. [1] http://

[issue15216] Support setting the encoding on a text stream after creation

2014-01-26 Thread Nikolaus Rath
Nikolaus Rath added the comment: I am working on this now. -- nosy: +nikratio ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue19077] More robust TemporaryDirectory cleanup

2014-01-26 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Here are updated patches for 3.3 and 3.4. Changed tests for 3.4, a patch for > 3.3 is changed more. Unfortunately in 3.3 exceptions still can be raised when > try to emit a warning during shutdown. Is there any way to determine the > shutdown mode? There's

[issue19456] ntpath doesn't join paths correctly when a drive is present

2014-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Merlijn for your information. So which patch is more preferable? -- ___ Python tracker ___

[issue20367] concurrent.futures.as_completed() fails when given duplicate Futures

2014-01-26 Thread Guido van Rossum
Guido van Rossum added the comment: Sorry, I suppose it needs to be backported to 3.3. If someone wants to do that, please do (I'm afraid I'd mess up the merge). -- resolution: fixed -> remind status: closed -> open ___ Python tracker

[issue20367] concurrent.futures.as_completed() fails when given duplicate Futures

2014-01-26 Thread STINNER Victor
STINNER Victor added the comment: @Guido: Why not fixing the issue in Python 3.3? You forgot to add Gleen Langford to Misc/ACKS! @Gleen: Congrats for your first commit :) -- ___ Python tracker ___

[issue20367] concurrent.futures.as_completed() fails when given duplicate Futures

2014-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1dac8c954488 by Victor Stinner in branch 'default': Issue #20367: Add Glenn Langford to Misc/ACKS http://hg.python.org/cpython/rev/1dac8c954488 -- ___ Python tracker _

[issue20293] pydoc fails with the "unspecified" default value

2014-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Since Argument Clinic no more supports "unspecified" default value, this issue can be closed. -- resolution: -> out of date stage: -> committed/rejected status: open -> closed ___ Python tracker

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

2014-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for reviews, Nadeem, Larry. -- dependencies: -pydoc fails with the "unspecified" default value resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

2014-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6f217456b9ba by Serhiy Storchaka in branch 'default': Issue #20193: The zlib module now uses Argument Clinic. http://hg.python.org/cpython/rev/6f217456b9ba -- ___ Python tracker

[issue19990] Add unittests for imghdr module

2014-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Claudiu. I have reorganized tests somewhat and added new test for file position. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue19990] Add unittests for imghdr module

2014-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset b28909d501c0 by Serhiy Storchaka in branch '2.7': Issue #19990: Added tests for the imghdr module. http://hg.python.org/cpython/rev/b28909d501c0 New changeset fde9e9832749 by Serhiy Storchaka in branch '3.3': Issue #19990: Added tests for the imghdr

[issue20386] socket.SocketType enum overwrites import of _socket.SocketType

2014-01-26 Thread Ethan Furman
Ethan Furman added the comment: Okay, staying with SocketKind. This patch also has a very small doc enhancement. -- keywords: +patch Added file: http://bugs.python.org/file33735/issue20386.stoneleaf.03.patch ___ Python tracker

[issue20339] Make bytes() use tp_as_buffer for cmp

2014-01-26 Thread fin swimmer
fin swimmer added the comment: This is exactly what I need! Would be a great work. -- nosy: +fin.swimmer ___ Python tracker ___ ___ P

[issue20399] Comparison of memoryview

2014-01-26 Thread fin swimmer
New submission from fin swimmer: Comparison by using memoryview seems not to work completely. This works: >>> memoryview(bytearray(range(5))) != memoryview(bytearray(range(5))) False >>> memoryview(bytearray(range(5))) == memoryview(bytearray(range(5))) True But: >>> memoryview(bytearray(range(

[issue19081] zipimport behaves badly when the zip file changes while the process is running

2014-01-26 Thread Gregory P. Smith
Gregory P. Smith added the comment: I refactored the unittests a bit and added another test for subimports when a directory within the .zip file is in sys.path as well. The quizzical "wtf" TODO I had in the code has been "answered" in that I am unable to trigger a situation where path != buf a

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

2014-01-26 Thread Nadeem Vawda
Nadeem Vawda added the comment: The patch for zlib looks good to me. Thanks for working on this, Serhiy. > We're not allowing changes in semantics for Argument Clinic conversion for > 3.4. If it doesn't currently accept None, we can't add it right now, and > we'll have to save it for 3.5. Fa

[issue20395] Extract generated clinic code in Modules/_pickle.c to separate file

2014-01-26 Thread Antoine Pitrou
Antoine Pitrou added the comment: +1 for a separate file from me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue20398] stem crashes python

2014-01-26 Thread Antoine Pitrou
Antoine Pitrou added the comment: If this is a cygwin build (rather than a standard MSVC build), I'm afraid that's not a supported platform at all. Did you compile Python yourself? -- nosy: +pitrou ___ Python tracker

[issue19990] Add unittests for imghdr module

2014-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Oh, yes, my bad. I used the patch utility. Sorry. -- ___ Python tracker ___ ___ Python-bugs-list m

[issue19990] Add unittests for imghdr module

2014-01-26 Thread Claudiu.Popa
Claudiu.Popa added the comment: Ah, I understand now. Maybe it is related to the fact that I used `hg diff --git`? Doing the following works for me, both Windows and FreeBsd and all the files are present afterwards: 1. hg diff --git > patch 2. hg import --no-commit patch Although I'm not sure

[issue19990] Add unittests for imghdr module

2014-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Last patch contains only pbm and xbm test files, while test_imghdr expects 11 different image files: png, gif, bmp, etc. -- ___ Python tracker __

[issue19990] Add unittests for imghdr module

2014-01-26 Thread Claudiu.Popa
Claudiu.Popa added the comment: Here's a smaller patch. Serhiy, what test files are missing? -- Added file: http://bugs.python.org/file33733/test_imghdr_4.patch ___ Python tracker __

[issue13866] {urllib, urllib.parse}.urlencode should not use quote_plus

2014-01-26 Thread Jeff Edwards
Jeff Edwards added the comment: It's interesting how long this issue has been around. It seems to be because the form-urlencoded spec is specified as url-percent-encoding EXCEPT for ' ' -> '+', which does seem to be unintuitive. To note, there are a few known cases where the exception does le

[issue19990] Add unittests for imghdr module

2014-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Looks as you forgot to include some test files in the patch. And these files are too large. Much smaller images would be enough. For example you can use python.org icon: http://www.python.org/favicon.ico. -- ___ P

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-01-26 Thread Guido van Rossum
Guido van Rossum added the comment: AFAICT the changes to selectmodule.c have been rolled back, both in the 3.3 and the 3.4 (default) branches. That takes care of backwards compatibility. :-) So what we're talking about is whether (a) the selectors module (new in 3.3) should export a resolutio

[issue19898] No tests for dequereviter_new

2014-01-26 Thread Claudiu.Popa
Claudiu.Popa added the comment: Hi. Here's a patch. -- keywords: +patch nosy: +Claudiu.Popa Added file: http://bugs.python.org/file33732/test_deque_19898.patch ___ Python tracker ___

[issue20367] concurrent.futures.as_completed() fails when given duplicate Futures

2014-01-26 Thread Guido van Rossum
Changes by Guido van Rossum : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue20367] concurrent.futures.as_completed() fails when given duplicate Futures

2014-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 58b0f3e1ddf8 by Guido van Rossum in branch 'default': Fix issue #20367: concurrent.futures.as_completed() for duplicate arguments. http://hg.python.org/cpython/rev/58b0f3e1ddf8 -- nosy: +python-dev ___ Py

[issue8260] When I use codecs.open(...) and f.readline() follow up by f.read() return bad result

2014-01-26 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue8260] When I use codecs.open(...) and f.readline() follow up by f.read() return bad result

2014-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset e24265eb2271 by Serhiy Storchaka in branch '2.7': Issue #8260: The read(), readline() and readlines() methods of http://hg.python.org/cpython/rev/e24265eb2271 New changeset 9c96c266896e by Serhiy Storchaka in branch '3.3': Issue #8260: The read(), r

[issue19990] Add unittests for imghdr module

2014-01-26 Thread Claudiu.Popa
Claudiu.Popa added the comment: Hello! Here's the new version of the patch, with tests proposed by Serhiy. -- Added file: http://bugs.python.org/file33731/test_imghdr_3.patch ___ Python tracker

[issue8260] When I use codecs.open(...) and f.readline() follow up by f.read() return bad result

2014-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Actually this patch doesn't work around misbehaving codecs. It just makes specific tests (one readline, one read) be passed. More complex tests which use multiple readline's or read's still can fail with these misbehaving codecs. --

[issue20398] stem crashes python

2014-01-26 Thread R. David Murray
R. David Murray added the comment: For anyone else who wants to look at this: it doesn't look like stem involves any C code, and the 'signal' method appears to be a text-based interprocess communication. Can you reproduce this with 3.3.3? 3.2 is in security-fix-only mode, and while a crash c

[issue19920] TarFile.list() fails on some files

2014-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: 1. No. Just use existing nonmodified testtar.tar now. Later we will add new items in it. 2. The encoding of sys.stdout is not always the same as default locale encoding. You can redirect sys.stdout to text file (opened with different encoding) or to socket

[issue20392] Inconsistency with uppercase file extensions in MimeTypes.guess_type

2014-01-26 Thread R. David Murray
R. David Murray added the comment: I'm tagging this for 3.5 instead, since there are backward compatibility concerns and the 3.4 RC will probably be a couple weeks from now. -- nosy: +r.david.murray versions: +Python 3.5 -Python 3.4 ___ Python tracke

[issue19920] TarFile.list() fails on some files

2014-01-26 Thread Vajrasky Kok
Vajrasky Kok added the comment: I already have a patch addressing your concerns, Serhiy. But before I upload it here, some questions: 1. "Yes, we can add unencodable tarinfo.linkname later. Just add tests for external tar files." You mean, we need to create a tar file containing unencodable t

[issue8260] When I use codecs.open(...) and f.readline() follow up by f.read() return bad result

2014-01-26 Thread Nick Coghlan
Nick Coghlan added the comment: Patch looks good to me, but if any specific features are needed to work around misbehaving codecs (as per issue 20132), a comment in the appropriate place referencing that issue would be helpful. And if that workaround means we can remove the special casing from

[issue19863] Missing function attributes in 2.7 docs.

2014-01-26 Thread Raymond Hettinger
Raymond Hettinger added the comment: > LGTM, but may be write Py3k compatible names at first place? +1 -- nosy: +rhettinger ___ Python tracker ___ __

[issue20398] stem crashes python

2014-01-26 Thread lothar
New submission from lothar: setup: python 3.2 ; cygwin64 python crashes with a stackdump, which is attached. stem is a python controller module for tor. stem-1.1.1 can be had from here: https://pypi.python.org/pypi/stem/ the code is in version 2 form, but "python3 setup install" runs 2to3 on

[issue16074] Bad error message in os.rename, os.link, and os.symlink

2014-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The 3.4 patch LGTM, but the 3.3 patch perhaps has a bug. -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue20218] Add `pathlib.Path.write` and `pathlib.Path.read`

2014-01-26 Thread Ram Rachum
Ram Rachum added the comment: New patch attached. Not tested. -- Added file: http://bugs.python.org/file33729/pathlib.readwrite4.patch ___ Python tracker ___

[issue20105] Codec exception chaining is losing traceback details

2014-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset b27352f87404 by Nick Coghlan in branch 'default': Close #20105: set __traceback__ when chaining exceptions in C http://hg.python.org/cpython/rev/b27352f87404 -- nosy: +python-dev resolution: -> fixed stage: test needed -> committed/rejected

[issue20326] Argument Clinic should use a non-error-prone syntax to mark text signatures

2014-01-26 Thread Nick Coghlan
Nick Coghlan added the comment: Right, the macros I quoted all include the signature automatically (because it's consistent) and *then* the DOC that is passed in. So when you use them, the signature should be left out of the slot definition itself. Currently, we're defining it in both places, hen

[issue20396] Argument Clinic: Touch source file if any output file changed

2014-01-26 Thread Nick Coghlan
Nick Coghlan added the comment: With Serhiy's modification, sounds like a reasonable plan to me. -- ___ Python tracker ___ ___ Python-

[issue20385] Argument Clinic: Support for __new__ not checking _PyArg_NoKeywords for sub-classes

2014-01-26 Thread Tal Einat
Tal Einat added the comment: Using the latest clinic.py from default branch, everything in itertools works like a charm :) -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue20367] concurrent.futures.as_completed() fails when given duplicate Futures

2014-01-26 Thread Glenn Langford
Glenn Langford added the comment: Ah...ok, here is a patch that includes an update to Doc/library/concurrent.futures.rst as well. -- Added file: http://bugs.python.org/file33728/issue20367.patch ___ Python tracker

[issue20397] distutils --record option does not validate existance of byte-compiled files

2014-01-26 Thread Marcus von Appen
New submission from Marcus von Appen: Using the --record argument with distutils' install command currently assumes that all .py files can be compiled (and optimized) successfully. If this is not the case for whatever reason, you end up with invalid entries in the record list. install_lib._by

  1   2   >