Remi Pointel added the comment:
Are you ok with this diff reworked?
--
Added file: http://bugs.python.org/file35505/Lib_test_test_urllib2net_py.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21456
Saimadhav Heblikar added the comment:
The patch fixes the refleak. Importing EditorWindow, was perhaps the cause. It
uses a dummy editwin instead.
With reference to the current test, was there a particular reason to import
real EditorWindow module?
--
keywords: +patch
Added file:
Terry J. Reedy added the comment:
I ran the patched code but have not looked at the code itself. Pending such a
look, I would consider committing it if we cannot do better, as it solves both
issues. However, there are two visual issues.
1. The minor one: The blue label does not have drop
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +yselivanov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21684
___
___
Ned Deily added the comment:
It looks like the 2.7 checkin has caused a number of buildbots to fail.
Examples:
http://buildbot.python.org/all/builders/AMD64%20Ubuntu%20LTS%202.7/builds/1094/steps/test/logs/stdio
==
ERROR:
STINNER Victor added the comment:
The _posixsubprocess module is not compiled on Windows.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21627
___
Serhiy Storchaka added the comment:
Please don't create Tk object at module creating stage. I afraid this will
break unittest discoverity.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18910
Terry J. Reedy added the comment:
This concerns me. I expect that we will eventually want to test a live
EditorWindow or subclass. It appears that root.destroy does not clear all the
widgets created by EditorWindow(root=root). My guess it that something is
created without passing in root, so
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18910
___
___
Python-bugs-list
Terry J. Reedy added the comment:
The 3.4 stable buildbots are green except for two that ran test_idle ok.
The problem is that in 2.7, unittest.loader does not catch ResourceDenied at
module level whereas is does in 3.4. The only indication that there should be a
difference is that the 3.x doc
Giampaolo Rodola' added the comment:
Looking back at this I think a send_blocksize argument is necessary after
all. shutil.copyfileobj() has it, so is ftplib.FTP.storbinary() and httplib
(issue 13559) which will both be using socket.sendfile() once it gets included.
Updated patch is in
Charles-François Natali added the comment:
Looking back at this I think a send_blocksize argument is necessary after
all. shutil.copyfileobj() has it, so is ftplib.FTP.storbinary() and httplib
(issue 13559) which will both be using socket.sendfile() once it gets
included.
Those APIs are
Giampaolo Rodola' added the comment:
I agree it is not necessary for sendfile() (you were right).
Do not introducing it for send(), though, poses some questions.
For instance, should we deprecate or ignore 'blocksize' argument in ftplib as
well?
Generally speaking, when using send() there are
Giampaolo Rodola' added the comment:
...speaking of which, now that I look back at those benchmarks it looks like
65536 bytes is the best compromise (in my latest patch I used 16348).
--
___
Python tracker rep...@bugs.python.org
Charles-François Natali added the comment:
Here's a patch fixing both issues.
--
keywords: +needs review, patch
nosy: +haypo, pitrou
stage: - patch review
Added file: http://bugs.python.org/file35508/socketserver_reap.diff
___
Python tracker
Serhiy Storchaka added the comment:
Here is a patch. It fixes also the same error in TextIOWrapper.
--
assignee: - serhiy.storchaka
keywords: +patch
stage: - patch review
versions: +Python 2.7, Python 3.5
Added file:
Nick Coghlan added the comment:
Updated patch with the heuristics factored out into a helper function, with a
more detailed explanation and additional logic to handle compound statements.
def foo():
... print bar
File stdin, line 2
print bar
^
SyntaxError: Missing
New submission from Raimondo Giammanco:
Steps to reproduce
¯¯
-1- Create a document.odt containing an input (text) field and a conditional
text field; the latter will show a different text based upon the content of the
input text field. [use attached example.odt]
-2- Edit the
Julian Taylor added the comment:
for median alone a multiselect is probably overkill (thats why I mentioned the
minimum trick)
but a selection algorithm is useful on its own for all of python and then a
multiselect should be considered.
Of course that means it would need to be implemented in
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21684
___
___
SilentGhost added the comment:
Raimondo, the documentation clearly states that the compression method is
either inherited from ZipInfo instance (when that one is passed) or set to
ZIP_STORED otherwise. Since you're not passing ZipInfo instance, but the string
(as the first argument to
Roundup Robot added the comment:
New changeset 6ffb6909c439 by Nick Coghlan in branch '3.4':
Issue #21667: Clarify string data model description
http://hg.python.org/cpython/rev/6ffb6909c439
New changeset 7c120e77d6f7 by Nick Coghlan in branch 'default':
Merge issue #21667 from 3.4
Nick Coghlan added the comment:
I've merged the character-code point clarifications, without the
implementation detail section.
For the time being, that leaves doesn't provide O(1) indexing of strings as
the kind of discrepancy that often makes an appearance in differences from the
CPython
Roundup Robot added the comment:
New changeset 7c28b3a92f40 by Nick Coghlan in branch '2.7':
Updates to Python 2.7 What's New preamble
http://hg.python.org/cpython/rev/7c28b3a92f40
--
nosy: +python-dev
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset d23cea976f46 by Nick Coghlan in branch '3.4':
Issue #21569: sync Python 2.7 What's New with 2.7 version
http://hg.python.org/cpython/rev/d23cea976f46
New changeset b167df2912d6 by Nick Coghlan in branch 'default':
Merge issue #21569 from 3.4
Changes by Nick Coghlan ncogh...@gmail.com:
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21569
___
Steven D'Aprano added the comment:
On Sat, Jun 07, 2014 at 01:02:52PM +, Julian Taylor wrote:
but a selection algorithm is useful on its own for all of python and
then a multiselect should be considered.
I like the idea of a select and/or multiselect for 3.5. As a
new feature, it cannot
Jan Kanis added the comment:
I tried changing the last block in turtulemodule/__init__.py to
if __name__ == '__main__':
demo = DemoWindow()
print(ENTERING mainloop)
demo.root.mainloop()
print(Bye)
but that does not solve the problem:
python3 -m turtledemo
ENTERING mainloop
New submission from Saimadhav Heblikar:
Test for idlelib.HyperParser
5 lines not tested. Any suggestion on how to hit those lines welcome.
Will submit backport 2.7 once the patch for 3.4 is OK.
--
components: IDLE
files: test-hyperparser.diff
keywords: patch
messages: 219942
nosy:
Mark Lawrence added the comment:
Is any more work needed here as msg106725 asks about updating doc strings?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8840
___
New submission from Florian Walch:
The documentation for Py_SetPath [1] states:
The path components should be separated by semicolons.
I believe this should not say semicolons, but colons; the default path as
output by Py_GetPath is separated by colons.
[1]
Mark Lawrence added the comment:
PEP 384 is listed as finished while 3121 is accepted so what if anything needs
to be done here? I've checked https://docs.python.org/devguide/experts.html
and nobody is listed against the signal module. The patch is C code which I
don't have the knowledge to
Remi Pointel added the comment:
For your information, this bug has been fixed in OpenBSD and the developper has
contacted the NetBSD developper:
http://marc.info/?l=openbsd-techm=140209064821540w=2
So I think we could close this issue because it's a system issue, not Python.
--
Mark Lawrence added the comment:
msg104677, msg104822 and msg104845 refer to various commits but msg104955
suggests that a follow up is needed so where do we stand with this issue?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
Mark Lawrence added the comment:
msg111078 refers to r82035 for Visual Studio 2005 (VC8) builds. Given that
http://code.activestate.com/lists/python-dev/131023/ refers to VC14 for 3.5 can
we close this as out of date?
--
nosy: +BreamoreBoy
___
paul j3 added the comment:
First, 'parse_intermixed_args' on stack is not relevant. It's from an
unreleased patch that we worked on.
What matters is the 'print_help', invoked probably with a '-h'.
The error message that normally specifies the problem argument is produced by
ArgumentError.
Changes by Brian Curtin br...@python.org:
--
nosy: -brian.curtin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8576
___
___
Python-bugs-list
Paul Moore added the comment:
TBH, I don't think I ever took this any further. As noted, the earlier patches
fixed the failures I was hitting.
It looks like Python 3.4 now has *two* definitions of find_unused_port, in
test.test_support and in test.support. And test_asyncio and test_ftplib
Changes by Paul Moore p.f.mo...@gmail.com:
--
nosy: -pmoore
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8576
___
___
Python-bugs-list mailing
fumihiko kakuma added the comment:
Hi michael,
Certainly, thank you for your many advices. I attached the new patch file.
--
Added file: http://bugs.python.org/file35513/support_patch_dict_by_stopall.diff
___
Python tracker rep...@bugs.python.org
Mark Lawrence added the comment:
msg121605 says the OP isn't seeing issues with this so I'd guess this can be
closed?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10002
eryksun added the comment:
A Windows path uses : after the drive letter, e.g. C:\\Windows, so the
delimiter is a semicolon on Windows. Other platforms use a colon.
CPython uses DELIM, which is defined in osdefs.h. This header isn't included by
Python.h.
Greg added the comment:
Here's a wording change in the documentation to clarify this.
--
keywords: +patch
nosy: +εσχατοκυριος
Added file: http://bugs.python.org/file35514/mywork.patch
___
Python tracker rep...@bugs.python.org
Yayoi Ukai added the comment:
Documentation is updated to be more clear
--
keywords: +patch
nosy: +terab
Added file: http://bugs.python.org/file35515/mywork.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13143
Yuyang Guo added the comment:
Made change based on Terry J. Reedy's suggestion
--
keywords: +patch
nosy: +Yuyang.Guo
Added file: http://bugs.python.org/file35516/issue21548.patch
___
Python tracker rep...@bugs.python.org
Ned Deily added the comment:
See issue12673 msg219946. Apparently this was caused by a long-standing BSD
sparc bug.
--
nosy: +ned.deily
resolution: - third party
stage: test needed - resolved
status: open - closed
___
Python tracker
Jan Kanis added the comment:
I have verified that DemoWindow._destroy(self) indeed gets called before the
exception is raised.
I did a bisect, on the default branch the bug was introduced by commit
f0833e6ff2d2: Issue #1545463: Global variables caught in reference cycles are
now
Emily Zhao added the comment:
I moved the 3 misplaced roles (envvar, keyword, and option) and changed the
description for the new section per Terry's suggestions. Patch is attached and
needs to go in the devguide repo.
Georg Brandl added the comment:
Well, it's entirely logical to follow our own policies :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21671
___
New submission from Olive Kilburn:
Currently if someone runs make.bat htmlhelp without first installing Htmlhelp
Workshop, it outputs:
c:\program not a valid . . . .
This isn't very informative if you don't know you need Htmlhelp Workshop. The
included patch has make.bat give a more helpful
Dhanam Prakash added the comment:
Hi,
submitting a patch for the documentation.
Thanks
--
hgrepos: +254
keywords: +patch
nosy: +dhanamp
Added file: http://bugs.python.org/file35519/issue12833.patch
___
Python tracker rep...@bugs.python.org
Katherine Busch added the comment:
Here's a patch. The docs built and I inspected the output. Everything looks
correct.
--
keywords: +patch
nosy: +Katherine.Busch
Added file: http://bugs.python.org/file35520/tardocs.patch
___
Python tracker
Changes by Jessica McKellar jesst...@mit.edu:
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21404
___
___
Kavya Joshi added the comment:
I added a `Benchmarking` section in the dev guide with the relevant links and
the intended use (testing rather than optimizing).
I also added an entry for the section in the Index.
Testing/verification:
I built the docs and visually inspected them.
--
Roundup Robot added the comment:
New changeset 4ad33d82193d by Benjamin Peterson in branch '3.4':
allow the keyword else immediately after (no space) an integer (closes #21642)
http://hg.python.org/cpython/rev/4ad33d82193d
New changeset 29d34f4f8900 by Benjamin Peterson in branch '2.7':
allow
Skyler Leigh Amador added the comment:
I've made a test for this patch with a very minimal mock ftpwrapper. We can see
it fails on dictionary size change without Erik's fix:
==
ERROR: test_ftp_cache_pruning
New submission from Yuly Tenorio:
Using Python on a Mac needs updating since it is pointing to old tools and
documentation.
This is related to http://bugs.python.org/issue12594
--
assignee: docs@python
components: Documentation
messages: 219968
nosy: docs@python, ned.deily, yuly
Roundup Robot added the comment:
New changeset 390b7fd617a9 by Benjamin Peterson in branch '2.7':
document the compress_level argument to tarfile.open (closes #21404)
http://hg.python.org/cpython/rev/390b7fd617a9
New changeset 0c712828fb6e by Benjamin Peterson in branch '3.4':
document the
Glenn Linderman added the comment:
Yes, I hope someday the parse_intermixed_args patch can be released... but I
know it is not relevant to this issue.
I was aware of the %(substitution_variables) in the default help formatter, but
I (1) goofed and entered % without escaping it (2) was
Changes by Ned Deily n...@acm.org:
--
title: Docs for py3k still refer to MacPython 2.5 folder - Docs for Using
Python on a Macintosh needs to be updated
versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3
___
Python tracker
Ned Deily added the comment:
Yes but I don't think we need to have two issues open. Let's make any comments
in the already open issue.
--
resolution: - duplicate
stage: - resolved
status: open - closed
superseder: - Docs for Using Python on a Macintosh needs to be updated
Benjamin Peterson added the comment:
Thanks for the patch! It looks like the synopsis function also has this bug.
Could you fix that, too?
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21548
Benjamin Peterson added the comment:
(I left some comments on Rietveld.)
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21463
___
Roundup Robot added the comment:
New changeset 19172062e5c0 by Benjamin Peterson in branch '3.4':
specify that getuid() returns the real uid (closes #10503)
http://hg.python.org/cpython/rev/19172062e5c0
New changeset 6dfbe504f659 by Benjamin Peterson in branch '2.7':
specify that getuid()
B D added the comment:
added unit test for this behavior with roxane. verified that the updated patch
applies cleanly, passes make patch check, and unit tests all pass.
--
nosy: +bdettmer, roxane
Added file: http://bugs.python.org/file35523/issue11709.patch
Greg added the comment:
In the definition of FTP.connect(), I've changed the code to actually use None
as a lack-of-explicit-timeout sentinel instead of -999. For FTP and FTP_TLS,
I've changed the documentation to reflect what the code is doing.
--
keywords: +patch
nosy: +εσχατοκυριος
Emily Zhao added the comment:
I don't know too much about robots.txt but how about
Disallow: */rev/*
Disallow: */shortlog/*
Allow:
Are there any other directories we'd like to exclude?
--
nosy: +emily.zhao
___
Python tracker rep...@bugs.python.org
Mark Lawrence added the comment:
Is there any value in the proof of concept patches attached here?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6701
___
Skyler Leigh Amador added the comment:
The patch still applies cleanly, so I've just updated the comment. test passes,
make patchcheck passes.
--
nosy: +shiinee
Added file: http://bugs.python.org/file35525/pydoc-self.patch
___
Python tracker
Emily Zhao added the comment:
Can someone close this? I think it's fixed.
--
nosy: +emily.zhao
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21314
___
Yuly Tenorio added the comment:
Built with sphinx. No RST errors.
--
keywords: +patch
nosy: +yuly
Added file: http://bugs.python.org/file35526/pythonusage_mac.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12594
Mark Lawrence added the comment:
Has maintenance of asyncore effectively ceased owing to tulip/asyncio or are
outstanding problems here, if any, still considered valid?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
Emily Zhao added the comment:
Might be worth making this addition from 3 (I'm not sure how to add this to 2)
-b : issue warnings about str(bytes_instance), str(bytearray_instance)
and comparing bytes/bytearray with str. (-bb: issue errors)
Building on Martin's example:
On all of
Benjamin Peterson added the comment:
The original bug (junk in various doc strings) has been fixed, but I think the
positional argument / syntax still needs docs. It's a little tricky because
/ is not actually valid syntax; it's just for documentation signatures.
--
nosy:
B D added the comment:
added try finally as suggested by berkerpeksag. make patchcheck still works and
all test cases still pass. did not use the test.support.swap_attr context
manager because it may inhibit readability for those that are not familiar with
it.
--
Added file:
Emily Zhao added the comment:
Here's an attempt (based on 3's main.c
http://hg.python.org/cpython/file/8866ac6f2269/Modules/main.c)
--
keywords: +patch
Added file: http://bugs.python.org/file35528/issue11681.patch
___
Python tracker
Skyler Leigh Amador added the comment:
Addressed review comments
--
Added file: http://bugs.python.org/file35529/urllib-request-ftpcache-test.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21463
Emily Zhao added the comment:
where's the best place for that documentation to live?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21314
___
Roundup Robot added the comment:
New changeset b8f9ae84d211 by Benjamin Peterson in branch '3.4':
in ftp cache pruning, avoid changing the size of a dict while iterating over it
(closes #21463)
http://hg.python.org/cpython/rev/b8f9ae84d211
New changeset 6f70a18313e5 by Benjamin Peterson in
Ned Deily added the comment:
Thank you for the patch, Yuly! You've made some good improvements to the
current page. Because the current section is so old and out-of-sync with
current practices (as you've noted in your changes) and with the nuances of
Python on OS X, a more comprehensive
Changes by Olive Kilburn olive...@gmail.com:
Added file: http://bugs.python.org/file35530/mywork.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21688
___
Changes by Olive Kilburn olive...@gmail.com:
Removed file: http://bugs.python.org/file35518/mywork.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21688
___
Changes by Vinay Sajip vinay_sa...@yahoo.co.uk:
--
nosy: -vinay.sajip
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8576
___
___
Python-bugs-list
B D added the comment:
removed comments.
--
Added file: http://bugs.python.org/file35531/issue11709.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11709
___
Amandine Lee added the comment:
I confirmed that the behavior acts as described. I added a patch documenting
the behavior, built the docs with the patch, and visually confirmed that the
docs looks appropriate.
Ready for review!
--
keywords: +patch
nosy: +amandine
Added file:
Renee Chu added the comment:
Submitting a patch for documentation.
--
hgrepos: +255
keywords: +patch
nosy: +reneighbor
Added file: http://bugs.python.org/file35533/issue11974.patch
___
Python tracker rep...@bugs.python.org
Jan Kanis added the comment:
The 3.3 branch is not affected as the f0833e6ff2d2 changeset was never merged
into that branch.
In the default branch the exception stops appearing after commit 79e2f5bbc30c:
Issue #18214: Improve finalization of Python modules to avoid setting their
globals to
Yayoi Ukai added the comment:
I did make patchcheck and make html and checked all versions HTML documents and
looks great. Good job!
--
nosy: +terab
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16667
Kelley Nielsen added the comment:
I have verified that this feature is unused in the source tree; in fact, there
are no internal calls to bytearray_getbuffer() at all. The only thing
bytearray_getbuffer() does with its second arg is pass it to
PyBuffer_FillInfo(), which immediately checks it
Benjamin Peterson added the comment:
Unfortunately, the test doesn't fail without the fix in, probably because the
pager() function replaces itself in the module and thus can only be called
once. It might make more sense to just directly test the getpager function with
sys.stdin = None.
New submission from Julian Gilbey:
In re.rst, the re.compile documentation says:
Compile a regular expression pattern into a regular expression object, which
can be used for matching using its :func:`match` and :func:`search` methods,
described below.
This results in linking to the
Yuly Tenorio added the comment:
Ok, I will definitely use that checker next time :) thanks!
Thanks Ned!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12594
___
Mark Lawrence added the comment:
Is this worth pursuing given the wording here
https://docs.python.org/3/library/subprocess.html#replacing-os-popen-os-popen2-os-popen3
?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
Martin Panter added the comment:
Trouble is, in Python 2 bytes() and str() are the same thing, and most of those
conditions don’t apply. Maybe something like this is more correct:
-b : issue warnings about comparing bytearray with unicode.
(-bb: issue errors)
--
Mark Lawrence added the comment:
I agree with the sentiment expressed in msg160237. Having said that I believe
that a lot of work has been put into the build system recently that might have
covered this.
--
nosy: +BreamoreBoy
___
Python tracker
Roundup Robot added the comment:
New changeset 7aa72075d440 by Benjamin Peterson in branch '3.4':
don't remove self from example code in the HTML output (closes #13223)
http://hg.python.org/cpython/rev/7aa72075d440
New changeset e89c39125892 by Benjamin Peterson in branch '2.7':
don't remove
Benjamin Peterson added the comment:
Unfortunately, I don't think it will be that easy because I don't think
robots.txt supports wildcard paths like that. Possibly, we should just
whitelist a few important repositories.
--
nosy: +benjamin.peterson
Raimondo Giammanco added the comment:
SilentGhost, thank you for your reply but I am probably missing something with
it. Maybe there is some misunderstanding because of my unclear report. Please
let me sum up my point and excuse some repetitiveness
From the documentation of .writestr:
``If
Berker Peksag added the comment:
The attached patch combines my changes with Andrew's patch.
--
versions: +Python 3.5 -Python 3.2, Python 3.3
Added file: http://bugs.python.org/file35534/issue16667_v3.diff
___
Python tracker rep...@bugs.python.org
Changes by Brian Curtin br...@python.org:
--
nosy: -brian.curtin
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1559298
___
___
Python-bugs-list
1 - 100 of 111 matches
Mail list logo