Serhiy Storchaka added the comment:
Then the patch LGTM except few nitpicks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23704
___
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22351
___
Martin Panter added the comment:
I am posting v6, which basically drops the buffer_size parameters. The change
is also pushed as a series of revisions to a Bit Bucket repository, see
https://bitbucket.org/vadmium/cpython/branches/compare/compression%0D@. I
thought that might help eliminate
Dmitry Kazakov added the comment:
Again, I'm honestly sorry if I'm being annoying, but is there anything else
that needs to be done in order to make this issue resolved? The stage is set
to patch review, although there were no messages posted since the latest
patch was submitted and there're
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +serhiy.storchaka
stage: - patch review
versions: +Python 3.5 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20132
___
Roundup Robot added the comment:
New changeset 3d33be07c5a2 by Raymond Hettinger in branch 'default':
Issue 23704: Add index(), copy(), and insert() to deques. Register deques as
a MutableSequence.
https://hg.python.org/cpython/rev/3d33be07c5a2
--
nosy: +python-dev
Raymond Hettinger added the comment:
Thank you for looking it over.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23704
___
Serhiy Storchaka added the comment:
Did you noticed my comments on Rietveld? You can found Rietveld messages in the
Spam folder.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23704
___
Serhiy Storchaka added the comment:
Current behavior is more complicated.
OSError(1, 2, 3, 4).args
(1, 2)
OSError(1, 2, 3, 4, 5).args
(1, 2)
OSError(1, 2, 3, 4, 5, 6).args
(1, 2, 3, 4, 5, 6)
If I remember correctly:
1 -- errno
2 -- strerror
3 -- filename
4 -- winerror (?)
5 -- filename2
Serhiy Storchaka added the comment:
These classes were introduced by Fred in issue624325. Is it intentional that
they were not added to __all__ Fred?
--
nosy: +fdrake
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23411
New submission from Martijn Pieters:
The documentation for zipfile.ZipFile.extract() doesn't mention at all that it
returns the local path created, either for the directory that the member
represents, or the new file created from the zipped data.
*Returns the full local path created (a
Serhiy Storchaka added the comment:
Looks as there is yet one difference in the behavior of Python and C
implementations. In Python implementation either self.target.doctype or
self.doctype are called. But in C implementation both are called.
--
nosy: +serhiy.storchaka
stage: - patch
koobs added the comment:
See also:
Issue: https://github.com/atgreen/libffi/issues/180
Title: OSX/i386 build is broken in v3.2.1
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23042
___
Serhiy Storchaka added the comment:
Thanks Martin. The patch LGTM.
--
stage: test needed - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22351
___
Raymond Hettinger added the comment:
For now, I prefer to continue using rotate() as a primitive and am saving
circular shifts for another day (likely when I start working on slices).
FWIW, the only way for append() to fail is a memory error; in which case, I
would ilke to stop doing any work
Roundup Robot added the comment:
New changeset e8878579eb68 by Serhiy Storchaka in branch '3.4':
Issue #22351: The nntplib.NNTP constructor no longer leaves the connection
https://hg.python.org/cpython/rev/e8878579eb68
New changeset 6622f68b064b by Serhiy Storchaka in branch 'default':
Issue
Daniil Bondarev added the comment:
issue17911 was submitted. I pulled latest updates and rechecked that ./python
-m test -uall passing with the same patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2786
Berker Peksag added the comment:
*Result and *ResultBytes classes are documented at
https://docs.python.org/3/library/urllib.parse.html#urllib.parse.DefragResult
+1 for adding them to __all__.
--
nosy: +berker.peksag
___
Python tracker
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22977
___
STINNER Victor added the comment:
Serhiy Storchaka added the comment:
Why this assert is needed? Why not always raise SystemError?
A SystemError exception may be ignored by a generic except Exception:
pass or logged at debug level at then ignored.
I consider that the bug is important, and
Paul Moore added the comment:
Regarding the poor relation argument, I'd see that as the other way round. We
don't have the resources to deal with major breakages, so we should be
relatively cautious.
--
___
Python tracker rep...@bugs.python.org
Mark Lawrence added the comment:
I'm concerned about being overcautious so that nothing ever happens. Do
something, break it, fix it. If you delay all you do is put off the fix. Plus
I've every confidence in our Windows developers to just do the right thing.
--
Serhiy Storchaka added the comment:
I'm +0.5 for the variant suggested by Berker and Ezio.
Do you have time to look at the patch Michael? I could commit modified patch
(there is one defect in tests).
--
nosy: +serhiy.storchaka
___
Python tracker
Serhiy Storchaka added the comment:
from fractions import Fraction as F
format(F(4, 27), 'f')
'0.1481481'
format(F(4, 27), '.1f')
'0.2'
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23602
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: patch review - needs patch
versions: +Python 3.5 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17232
___
New submission from Raymond Hettinger:
Show examples of how to search XML that contains namespaces.
Also indicate the ElementTree subset of XPath supports filters in the form
[tag=text].
--
assignee: rhettinger
components: Documentation
files: elementtree_doc.diff
keywords: patch
Roundup Robot added the comment:
New changeset 970f33dff5ca by Victor Stinner in branch 'default':
Issue #23571: Fix test_capi
https://hg.python.org/cpython/rev/970f33dff5ca
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
This exception or assertion is triggered by the bug in CPython or in an
extension. CPython developer uses release and debug builds of CPython and can
get both exception or assertion. An extension developer usually uses release
build of CPython with release
Serhiy Storchaka added the comment:
The documentation looks contradictory. The *data* argument must be, but The
*data* argument may also be. must be a bytes object, but If *data* is a
buffer.
Why not write just The data argument must be a bytes-like object, an iterable
of bytes-like objects,
Steve Dower added the comment:
Paul has basically summed up the pragmatism beats purity side of the argument.
Whether we like it or not, users are mostly coming to python.org for their
installer, and we need to support that.
That said, we can do some things to support all three cases once we
Mark Lawrence added the comment:
python35.exe follows things like pip so +1. py.exe to python.exe -1 from me,
how about pylaunch.exe as it's explicit? As for urgency in the Python world
Windows is and always has been the poor relation compared to *nix, so I say
let's bite the bullet and get
Paul Moore added the comment:
Updated patch with fixes for review comments. I did remove the tests for the
exact error messages, as testing for a non-zero exit code was actually what I
was trying to do, and I found a better way of doing that.
--
Added file:
Paul Moore added the comment:
Personally, I'd like to have 3.5 be the release that changes to using Program
Files as the default install, and offers a per-user install to Appdata. I
suspect there will be enough fallout from that change to keep us busy. Let's
look to 3.6 for major renamings of
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: patch review - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17840
___
___
STINNER Victor added the comment:
Serhiy was right: we should mention the name of the function in the
exception. In the Django traceback, it's not easy to guess what raised the
SystemError.
Ok to mention the change in What's New in Python 3.5.
--
Antoine Pitrou added the comment:
Instead of an assert(), you could use Py_FatalError() at the end of
_Py_CheckFunctionResult().
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23571
Antoine Pitrou added the comment:
Alexey, you're right that in this case (bug2.py) the cyclic GC is a bit less
friendly than it was. It's not obvious there's a way to change that without
introduce a lot of complexity. I'll try to take a look some day, although
others may help too :-)
That
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +tim.peters
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23720
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
There is a cycle involving the class object, but I don’t think there is a
cycle involving the instance objects this time.
It is.
a = A()
a.__class__.__del__.__globals__['a']
__main__.A object at 0xb702230c
And all objects referenced from user class or
New submission from Brett Cannon:
The porting HOWTO for Python 3.5 doesn't mention that bytes interpolation will
exist.
--
assignee: brett.cannon
components: Documentation
messages: 238804
nosy: brett.cannon
priority: normal
severity: normal
status: open
title: Update porting HOWTO for
New submission from Brett Cannon:
Thanks to http://bugs.python.org/issue23681 we now have a better story about
helping people find int/bytes comparison issues. The docs for Python 3.5 -- but
not Python 3.4! -- should get updated to point out this change.
--
assignee: brett.cannon
Antoine Pitrou added the comment:
Can you please provide timing numbers?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23723
___
___
Serhiy Storchaka added the comment:
Non-Linux buildbots failed.
http://buildbot.python.org/all/builders/AMD64%20Snow%20Leop%203.x/builds/2798/steps/test/logs/stdio
==
FAIL: test_return_result_with_error
Alexey Kazantsev added the comment:
Ok, even assuming that all module globals are in circular reference starting
with python 3.4, here is another example without using the globals:
Brief description:
v holds reference to d
a.v = v
b.d = d
Now when we form a circular reference a - b, the
STINNER Victor added the comment:
I will try to take a look next week. If not, ping me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23524
___
Serhiy Storchaka added the comment:
Yes, in bug2.py we have different cycle.
a ↔ b
↓ ↓
v → d
a and b are in a cycle, and therefore v and d are in cycle. I think that in
such case v always should be destroyed before d, independently of a cycle that
refers them. And this is the same
STINNER Victor added the comment:
I believe that this patch exposes some subtle bugs in Django (see
https://gist.github.com/berkerpeksag/8b8dbe594eb1a1c51275) and it would be
great to add a note for third party libraries.
Berker, can you please rerun your test with my new commit to check
Paul Moore added the comment:
One implication of Nick's (and Steve's) position seems to me that we don't view
per-user installs as a key aspect of the python.org installers. And yet the
impression I get of the direction that the 3.5 installers is taking seems to
contradict that - there's a
Martin Panter added the comment:
But in the case of bug2.py, “a” is a variable inside main(), not a global
variable.
BTW I take back my second paragraph questioning the whole order thing; I
clearly didn’t think that one through.
--
___
Python
Marc-Andre Lemburg added the comment:
@koobs: I was just looking at the 3.2.1 code where it still looks like
ffi_call_win32() gets called even on non-Win32 platforms.
That said, it's possible that ffi_call_win32() is indeed defined on other
platforms than Win32 as well in 3.2.1 - after all,
Nick Coghlan added the comment:
From a general philosophical perspective, I share Steve's view - the vast
majority of potential CPython users don't want to be consuming upstream Python
themselves, they want to be getting it from a redistributor.
This has nothing to do with the quality of the
New submission from Brett Cannon:
https://www.python.org/dev/peps/pep-0488/
--
assignee: brett.cannon
components: Interpreter Core
messages: 238799
nosy: brett.cannon
priority: release blocker
severity: normal
stage: test needed
status: open
title: Implement PEP 488
type: enhancement
Serhiy Storchaka added the comment:
Due to changes in issue17911 the patch no longer applied cleanly an should be
rewritten. But changes in issue17911 are close to my patch.
_tb_frame_lineno_iter matches walk_tb and _stack_frame_lineno_iter matches
walk_stack. So new patch is simpler.
Serhiy Storchaka added the comment:
Wouldn't zipimport provide better performance? If bytecode generation is
thoroughly controlled, could you collect your .pyc files in a ZIP file?
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
I proposed changed patch. It needs a review.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22619
___
___
Serhiy Storchaka added the comment:
There is a cycle for every class with a method.
class A:
... def __del__(self): pass
...
A.__del__.__globals__['A']
class '__main__.A'
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
Martin Panter added the comment:
There is a cycle involving the class object, but I don’t think there is a cycle
involving the instance objects this time.
However, I wonder if __del__() is meant to be called in any particular order
anyway. What’s to stop the garbage collector itself from
Nick Coghlan added the comment:
I like the change, but even though the current behaviour is arguably buggy (and
certainly undesirable) the fix does introduce a new class level attribute that
is visible during execution of Python level code.
Perhaps it would be worth rolling this change into
Nick Coghlan added the comment:
Short version of the above: I personally think we should be focusing on
addressing the system Python and Python as a library cases upstream, as
we're the only ones that can do that.
Solving the latter problem well then also sets the baseline for user focused
koobs added the comment:
@marc I took a look at the code upstream and it does indeed appear to be the
same. It was introduced in 3.1 [1].
I cant explain however how or why our Python ports work with libffi 3.2.1.
See msg238767 for a link to another similar (same?) issue, with failure of OSX
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23360
___
___
Brett Cannon added the comment:
What Greg said. =) Basically it would allow those who know what they are doing
to cut out a stat call per load. I suspect anyone deploying to a server is in a
similar situation where they are not actively editing the code once deployed,
and so saving on the
Roundup Robot added the comment:
New changeset f30a5f6a665c by Victor Stinner in branch 'default':
Issue #23571: _Py_CheckFunctionResult() now gives the name of the function
https://hg.python.org/cpython/rev/f30a5f6a665c
--
___
Python tracker
Changes by Barry A. Warsaw ba...@python.org:
--
nosy: +barry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23731
___
___
Python-bugs-list mailing
New submission from Gregory P. Smith:
The zipimport module checks the timestamp of a pyc file loaded from the zip
file against the timestamp of a corresponding py file in the zip if any. This
seems pointless. By the time someone has created a zip file for zipimport they
should have
Raymond Hettinger added the comment:
Can this be closed as not-a-bug.
--
nosy: +rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23720
___
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
versions: -Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15836
___
___
Mark Lawrence added the comment:
See the thread starting here
https://mail.python.org/pipermail/python-ideas/2014-December/030521.html
--
nosy: +BreamoreBoy
type: - enhancement
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset d0b497c86c60 by Serhiy Storchaka in branch '2.7':
Issue #23075: Whether __builtins__ is a module or a dict is undefined in
https://hg.python.org/cpython/rev/d0b497c86c60
--
nosy: +python-dev
___
Python
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +eli.bendersky, scoder
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23729
___
___
Serhiy Storchaka added the comment:
There are two issues. The one is that calculated Content-Length is not correct
for lists, tuples, and other types (such as deque or array.array). The right
solution is to calculate size using a technique used in urllib. Content-Length
shouldn't be
Changes by Mark Lawrence breamore...@yahoo.co.uk:
--
nosy: +michael.foord
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23097
___
___
Raymond Hettinger added the comment:
Attaching a runnable version of the namespace demo to show that the code works.
--
versions: +Python 2.7, Python 3.4
Added file: http://bugs.python.org/file38625/xml_namespace_demo.py
___
Python tracker
Mark Lawrence added the comment:
Can we have a commit review please as this is such a simple patch.
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23075
___
Gregory P. Smith added the comment:
We already use zipimport for most production deployments. It works well.
We've modified our own zipimport to ignore timestamps as keeping them in sync
between pyc and py files in the zip files own timestamps is painful.
Unfortunately the stdlib zipimport
Antoine Pitrou added the comment:
That sounds kind of reasonable, but how are we supposed to document this? Or is
this only a secret backdoor for people in the know?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23723
Mark Lawrence added the comment:
My feeling is that this is worth doing for the code clarity alone but what do
others think about it?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23106
Mark Lawrence added the comment:
The only PyString that I could find left is in unicodedata.c. I'm assuming
that there is little point is preparing a patch for a one word change, is this
correct?
--
nosy: +BreamoreBoy
___
Python tracker
Changes by Eugene Toder elto...@gmail.com:
Added file: http://bugs.python.org/file38624/class_gc2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23726
___
STINNER Victor added the comment:
Le 21 mars 2015 18:05, Serhiy Storchaka rep...@bugs.python.org a écrit :
But an assertion itself provides less information than an exception.
Debug build is less informative than release build.
I like Antoine's idea to replace the assertion with
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23075
___
Serhiy Storchaka added the comment:
Done. Thanks for raising it Mark.
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23075
___
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
Added file: http://bugs.python.org/file38626/elementtree_doc2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23729
___
Steve Dower added the comment:
Sorry, Standard Operating Environment. I intended it as shorthand for the as
if it were shipped with the OS case.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22516
Mark Lawrence added the comment:
It's a comprehensive patch so can we have a formal review please.
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22246
___
Mark Lawrence added the comment:
Without more detail I very much doubt that anybody can help.
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22659
___
Nick Coghlan added the comment:
I agree the migration to Program Files a different installer build process is
more than ambitious enough for 3.5.
For the embedding case, it's not that it *can't* be done, it's just a PITA.
Perhaps for the per-user no-admin-rights needed case, we could direct
Mark Lawrence added the comment:
It's a simple patch so can we have a formal review please.
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22608
___
Mark Lawrence added the comment:
It's a simple patch so can we have a formal review please.
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22610
___
Nick Coghlan added the comment:
Along those lines, another option to consider would be offering to publish
Portable Python from the python.org release pages in addition to publishing the
less comprehensive CPython-only installers.
--
___
Python
Nick Coghlan added the comment:
Larry,
Bringing you into this discussion as CPython 3.5 release manager - we're trying
to figure out what role we'd like the CPython Windows installers to play in the
Windows distribution ecosystem, and I raised the question of whether or not
typical Windows
Ned Deily added the comment:
Bringing an umbrella distribution into the CPython release process seems to me
like a very big leap and would that requires very careful consideration. It
would introduce a whole load of other dependencies into our release process,
i.e. that the third-party
Mark Mikofski added the comment:
WinPython and miniconda are more current distros than portable python, and they
come in both 32 64bit flavors.
Portable python hasn't been updated recently and only offers 32 bit which is
IMO worthless except for the bundle as app case, eg meld installer.
I
Paul Moore added the comment:
Sorry, SOE?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22516
___
___
Python-bugs-list mailing list
Martin Panter added the comment:
Thanks for this improvement; documenting namespace behaviour is sorely needed.
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23729
___
Martin Panter added the comment:
Technically I don’t think there is a bug. The documentation says [the]
“Content-Length header should be explicitly provided”, so if you don’t set it
you could argue that you’re using the library wrong.
For this issue I think Demian was trying to add support
Martin Panter added the comment:
Maybe these patches work around the problem in these cases, but it sounds like
the threading.Event class needs to grow a close() method or support the context
manager protocol, rather than relying on the garbage collector to clean it up.
--
nosy:
Steve Dower added the comment:
(when does Windows switch to 3.6? Honestly, it can probably never happen...).
On re-read, this isn't quite clear:
Hypothetically, if Windows 10 included Python 3.5, when would it be upgraded to
Python 3.6? Probably never. Back-compat is problematic on Linux,
Steve Dower added the comment:
Yeah, some of those are fairly ambitious, but at the same time, for the SOE use
case we probably don't want the Program Files install at all - it would be a
mix between System32 and CommonFiles, with the same environment issues you'd
see on Linux. Program Files
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13224
___
___
Python-bugs-list
1 - 100 of 127 matches
Mail list logo
