Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23781
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22079
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14260
Roundup Robot added the comment:
New changeset 5bea08f80e62 by Serhiy Storchaka in branch '2.7':
Issue #14904: Made test_unicode_repr_oflw to use less memory.
https://hg.python.org/cpython/rev/5bea08f80e62
--
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14904
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +ezio.melotti, haypo, michael.foord, pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23799
___
STINNER Victor added the comment:
Serhiy Storchaka added the comment:
May be rename _PyTime_AsTimeval_impl() to _PyTime_AsTimeval_noraise() and
check a result to raise an exception in _PyTime_AsTimeval()?
Ah yes correct, can you modify directly the code please?
--
Roundup Robot added the comment:
New changeset 442ebebad516 by Serhiy Storchaka in branch '3.4':
Issue #23785: Fixed memory leak in TextIOWrapper.tell() in rare circumstances.
https://hg.python.org/cpython/rev/442ebebad516
New changeset 2fcd99929dba by Serhiy Storchaka in branch 'default':
Roundup Robot added the comment:
New changeset c76a1a42799c by Serhiy Storchaka in branch '2.7':
Issue #23781: Add private helper function _PyErr_ReplaceException() that
https://hg.python.org/cpython/rev/c76a1a42799c
--
nosy: +python-dev
___
Python
Roundup Robot added the comment:
New changeset 74d766d819a6 by Serhiy Storchaka in branch '3.4':
Issue #23783: Fixed memory leak in PyObject_ClearWeakRefs() in case of
https://hg.python.org/cpython/rev/74d766d819a6
New changeset 6a4b83c56b86 by Serhiy Storchaka in branch 'default':
Issue
Roundup Robot added the comment:
New changeset cb96fd376baa by Serhiy Storchaka in branch 'default':
Issue #23466: %c, %o, %x, and %X in bytes formatting now raise TypeError on
https://hg.python.org/cpython/rev/cb96fd376baa
--
nosy: +python-dev
___
Roundup Robot added the comment:
New changeset cf5b62036445 by Serhiy Storchaka in branch 'default':
Issue #23171: csv.Writer.writerow() now supports arbitrary iterables.
https://hg.python.org/cpython/rev/cf5b62036445
--
nosy: +python-dev
___
Python
Serhiy Storchaka added the comment:
Could you please commit your patch (may be with changes) Larry?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23500
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23171
___
Serhiy Storchaka added the comment:
Thank you for fixing backported patch and tests Victor.
--
assignee: - serhiy.storchaka
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23783
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23785
Roundup Robot added the comment:
New changeset e00b581a65ec by Victor Stinner in branch 'default':
Issue #22117: Try to fix rounding in conversion from Python double to _PyTime_t
https://hg.python.org/cpython/rev/e00b581a65ec
--
___
Python tracker
STINNER Victor added the comment:
Hum, conversion from Python float to _PyTime_t is not rounded as expected on
x86 Ubuntu Shared 3.x. Example:
http://buildbot.python.org/all/builders/x86%20Ubuntu%20Shared%203.x/builds/11426/steps/test/logs/stdio
STINNER Victor added the comment:
Serhiy Storchaka added the comment:
Thank you for fixing backported patch and tests Victor.
No problem, thanks for your enhancement of regrtest ;-) I proposed the
idea and you implemented it, great team work!
--
Roundup Robot added the comment:
New changeset 05b96af72805 by Victor Stinner in branch '2.7':
Issue #23115: os.urandom() now releases the GIL when the getentropy() is used
https://hg.python.org/cpython/rev/05b96af72805
--
___
Python tracker
STINNER Victor added the comment:
Serhiy Storchaka added the comment:
The second (exception == NULL) check in _Py_PrintFatalError() looks
suspicious. When it is possible? And if it is possible, can it cause leaks?
Sorry, I have no idea. I didn't write this code myself. It comes from
Roundup Robot added the comment:
New changeset 1ad3d8d82b18 by Victor Stinner in branch 'default':
Issue #23605: Fix typo in an os.walk() comment
https://hg.python.org/cpython/rev/1ad3d8d82b18
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 128f92ae8bae by Victor Stinner in branch 'default':
Issue #23752: _Py_fstat() is now responsible to raise the Python exception
https://hg.python.org/cpython/rev/128f92ae8bae
--
___
Python tracker
STINNER Victor added the comment:
Hum, _Py_fstat() is not used correctly in _io.FilIO: it uses errno instead of
GetLastError() to raise the OSError. It's too hard to use the new _Py_fstat()
function directly, I modified it to raise directly the exception. So the caller
doesn't have to use
Roundup Robot added the comment:
New changeset 28b465d8c519 by Victor Stinner in branch 'default':
Issue #22181: os.urandom() now releases the GIL when the getrandom()
https://hg.python.org/cpython/rev/28b465d8c519
--
___
Python tracker
Roundup Robot added the comment:
New changeset 9d3013a383eb by Victor Stinner in branch '3.4':
Issue #22585: os.urandom() now releases the GIL when the getentropy() is used
https://hg.python.org/cpython/rev/9d3013a383eb
New changeset 7f1015e4277a by Victor Stinner in branch 'default':
(Merge
STINNER Victor added the comment:
Oh, there was another hang before, so it's probably not related:
http://buildbot.python.org/all/builders/AMD64%20Snow%20Leop%203.x/builds/2852/steps/test/logs/stdio
[393/393] test_ssl
Timeout (1:00:00)!
Thread 0x000102d81000 (most recent call first):
STINNER Victor added the comment:
I confirm the bug on Python 3.5.0a3+.
Is someone interested to fix buffered_peek() to add a check on the closed state?
--
nosy: +haypo
Added file: http://bugs.python.org/file38735/bug.py
___
Python tracker
Michael Foord added the comment:
The change to unittest is fine. I'd prefer the tests tweaking as Ezio suggested.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15836
___
STINNER Victor added the comment:
In this case all started threads left dangling and make MemotyError even more
probably
Oh, I didn't know that. Good catch.
test_support_start_threads.patch looks good to me and it looks like a nice
enhancement.
But would it be possible to emit a warning
Serhiy Storchaka added the comment:
Here is a patch that adds Decimal support for datetime.fromtimestamp() and
datetime.utcfromtimestamp(). As side effect Decimal timestamps now are
supported in few other places, e.g. in os.utime().
--
nosy: +haypo
stage: needs patch - patch review
STINNER Victor added the comment:
The changeset 128f92ae8bae also changed _Py_fstat() to release the GIL when
calling fstat(), I forgot to mention it in the changeset.
test_socket now hangs on AMD64 Snow Leop 3.x, I don't know yet if it's related:
STINNER Victor added the comment:
Oh, test_time now pass on x86 Ubuntu Shared 3.x. It looks like the volatile
keyword was enough to fix rounding issues, cool :-)
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
Martin Panter added the comment:
V4 fixes a merge conflict with recent gzip changes.
--
Added file: http://bugs.python.org/file38739/crc-sign.v4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22341
Ben Hoyt added the comment:
Yep, I'm good -- go ahead and close!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23605
___
___
Python-bugs-list
STINNER Victor added the comment:
Thanks for your great work Ben! I close the issue. The PEP 471 has already the
Final status.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23605
Stefan Krah added the comment:
Regarding Decimal:
1) The context precision isn't used for formatting. If you have
another reason for proposing the optional context argument for
dec_format(), please open another issue.
2) There's another problem: The mythical DefaultContext
STINNER Victor added the comment:
I reviewed datetime_fromtimestamp_decimal.patch.
As side effect Decimal timestamps now are supported in few other places, e.g.
in os.utime().
It would be more consistent to support decimal.Decimal nowhere or everywhere.
IMO the new
New submission from Akshet Pandey:
On the following test file (test.py):
```python
class Solution:
def repeatedNumber(self, A):
test = 1
return []
```
Running python -m py_compile test.py return the following error message:
Sorry: IndentationError: unexpected indent (test.py, line
Martin Panter added the comment:
Patch v3:
* Reverted to original crc32(bhello) example call with the implicit initial
CRC
* Added “Changed in version 3.0” notices, restoring a brief version of the
suggestion to use the bit mask, along with an explanation.
Python 2 compatibility information
STINNER Victor added the comment:
Ben: do you think that we are done with this issue? can I close it?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23605
___
Serhiy Storchaka added the comment:
Did you noticed my comments on Rietveld about setdefault() and the :meth: role?
--
assignee: serhiy.storchaka - r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
Brett Cannon added the comment:
Probably need to introduce a new keyword argument just for deprecated imports
or some helper function in importlib to get the stack depth right (else there
is a risk of breaking the stack depth in any minor release whenever importlib's
depth shifts). Something
Serhiy Storchaka added the comment:
The problem is that the Decimal *was* supported in 2.7. So this issue can be
considered not as adding new feature, but as fixing a regression. But changes
are too large for just bugfix.
It would be more consistent to support decimal.Decimal nowhere or
Changes by Paul Moore p.f.mo...@gmail.com:
--
nosy: +paul.moore
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14243
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset 7a5f30babc72 by R David Murray in branch '3.4':
#23792: also catch interrupt around pipe.write.
https://hg.python.org/cpython/rev/7a5f30babc72
New changeset 536c4f4acae1 by R David Murray in branch 'default':
Merge: #23792: also catch interrupt
Changes by Gustavo J. A. M. Carneiro gjcarne...@gmail.com:
Added file: http://bugs.python.org/file38741/Issue23812.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23812
___
Stefan Krah added the comment:
I think we should try to avoid depending on global state in
the stdlib, at least in new code. Also, if something is not
really a decimal computation, Decimal itself tries to ignore
the context (like Decimal.__repr__).
At least I would expect this datetime
Changes by Brett Cannon br...@python.org:
--
nosy: +brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23807
___
___
Python-bugs-list
New submission from Gustavo J. A. M. Carneiro:
I have a pattern where I read from a queue with a timeout, generally like this:
while True:
reader = asyncio.async(wait_for(queue.get(), 0.1))
try:
item = (yield from reader)
except asyncio.TimeoutError:
reader.cancel()
continue
Serhiy Storchaka added the comment:
Yes, self.assertFailure('-L', 'en') tests this case.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23807
___
Serhiy Storchaka added the comment:
Similar feature is needed for warnings in the re module. Methods of regular
expression pattern can be called directly or from module-level wrappers. In
these case the stack level differs by 1. And sometimes warnings are emitted in
recursive parser, when
Changes by STINNER Victor victor.stin...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22181
___
Stefan Krah added the comment:
I just looked at this very briefly: Is the patch context insensitive?
IOW, do things still work if you change the thread-local context:
from decimal import *
c = getcontext()
c.prec = 1
c.Emax = 1
c.Emin = -1
--
nosy: +skrah
Larry Hastings added the comment:
I want to redo it--it's smelly. I hope to get it done this week.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23500
___
Serhiy Storchaka added the comment:
Something like this?
--
Added file: http://bugs.python.org/file38738/test_support_start_threads_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23799
Ben Hoyt added the comment:
Thanks for the explanation (and the comment fix).
What's your point about complexity? Would you like to drop os.scandir
changes in os.walk(), or do you have a simpler version to propose?
No, not at all! I was just noting it and trying to brainstorm any ways to
R. David Murray added the comment:
No, sorry, I currently don't always notice reviews unless they are mentioned on
the tracker. I will take a look.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
R. David Murray added the comment:
Yeah, someone could theoretically manage to hit ctl-c between the time the
process is started and the call to pipe.write, or between it and the call to
wait, but I don't think those very-low-probability events are worth worrying
about.
--
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
Added file: http://bugs.python.org/file38742/namespace_doc_fixes.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23729
___
Guido van Rossum added the comment:
I'm a little surprised you didn't get pushback from asyncio (i.e. Victor). We
try to keep the source identical across releases while asyncio is in
provisional mode (i.e. until 3.5 is released).
--
nosy: +gvanrossum, haypo
Gustavo J. A. M. Carneiro added the comment:
- Are there other places where a cancellation can have a similar effect?
Maybe the same logic in put()?
Hm.. I didn't look, but yes, it does look like it might be affected by the same
issue. I'll try to create a test for that to confirm.
how
Serhiy Storchaka added the comment:
Should I restore __ne__ in asyncio? The version without __ne__ will work with
Python 3.4.3 because issue21408 patch was committed in 3.4 too. Explicit __ne__
implementation is just redundant.
--
___
Python
Guido van Rossum added the comment:
Make sense. I'll be waiting for your updated patch. Thanks for both the bug
report and the fix!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23812
J. Walter Clark added the comment:
I had the same issue using Python 3.4.2 x64 on Windows 7 x64 and resolved it by
setting PYTHONHOME and PYTHONPATH environmental variables.
--
nosy: +jwalterclark
___
Python tracker rep...@bugs.python.org
Bruno Cauet added the comment:
I'm not sure how you can have both, those two seem opposite to me:
- if 'from_bytes' returns the same type as the class it is called on then
the instantiation of the result object should go through its constructor
(patch proposed)
- if the subclass should override
Demian Brecht added the comment:
Thanks for following up on this David. The changes you've made all look good to
me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
___
Gustavo J. A. M. Carneiro added the comment:
I created a codereview issue: https://codereview.appspot.com/222930043
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23812
___
Guido van Rossum added the comment:
Looks like a valid bug report, I like the test you provided, and the fix seems
on the right track. Comments on the fix:
- I'd really like to see a rietveld diff for both patches.
- Are there other places where a cancellation can have a similar effect? Maybe
Guido van Rossum added the comment:
Yeah, I'd like to see it restored in asyncio. It seems to be just one file
that's currently out of sync with the tulip upstream repo.
On Mon, Mar 30, 2015 at 10:38 AM, Serhiy Storchaka rep...@bugs.python.org
wrote:
Serhiy Storchaka added the comment:
New submission from Serhiy Storchaka:
There are links to Atom and RSS feeds on https://www.python.org/dev/buildbot/:
http://buildbot.python.org/all/rss
http://buildbot.python.org/all/atom
Both referred pages are broken.
web.Server Traceback (most recent call last):
Serhiy Storchaka added the comment:
Current (after issue22364) error message is:
re.match('(?foo.*)', 'foo')
Traceback (most recent call last):
...
sre_constants.error: unknown extension ?f at position 1
Is it good enough or should be improved? In regex this syntax is legal and no
error is
Roundup Robot added the comment:
New changeset e881444f078f by Serhiy Storchaka in branch 'default':
Partially revert 3603bae63c13 (issue23326) for asyncio.
https://hg.python.org/cpython/rev/e881444f078f
--
___
Python tracker rep...@bugs.python.org
Guido van Rossum added the comment:
Thanks!
On Mon, Mar 30, 2015 at 12:26 PM, Roundup Robot rep...@bugs.python.org
wrote:
Roundup Robot added the comment:
New changeset e881444f078f by Serhiy Storchaka in branch 'default':
Partially revert 3603bae63c13 (issue23326) for asyncio.
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23810
___
___
Roundup Robot added the comment:
New changeset 0ff1090307c7 by Victor Stinner in branch 'default':
Issue #23485: select.select() is now retried automatically with the recomputed
https://hg.python.org/cpython/rev/0ff1090307c7
--
nosy: +python-dev
___
New submission from Serhiy Storchaka:
In 2.7 and 3.3:
import _tkinter
_tkinter.Tcl_Obj()
Traceback (most recent call last):
File stdin, line 1, in module
TypeError: cannot create '_tkinter.Tcl_Obj' instances
_tkinter.TkttType()
Traceback (most recent call last):
File stdin, line 1, in
STINNER Victor added the comment:
inject_signals.patch: Quick-and-dirty patch to send signals (SIGALRM) every
milliseconds when running unit tests.
On Linux, results are very good. Only multiprocessing fails because of the
issue #23618 (socket connect) which has a pending patch. I hope that
Roundup Robot added the comment:
New changeset 0591cf5c9ebd by Victor Stinner in branch 'default':
Issue #23485: Add _PyTime_FromMillisecondsObject() function
https://hg.python.org/cpython/rev/0591cf5c9ebd
New changeset 69b1683ee001 by Victor Stinner in branch 'default':
Issue #23485:
New submission from Karl O. Pinc:
In the argparse library parser library, contrary to the documentation,
parser-level defaults do not always override argument-level defaults.
https://docs.python.org/3.5/library/argparse.html#argparse.ArgumentParser.set_defaults
says Note that parser-level
STINNER Victor added the comment:
test_selectors.patch: Enhance test_selector to test the two kinds of signal
handlers: one raises an exception, the other one doesn't. I wait until kqueue
devpoll retry on EINTR to push test_selectors.patch.
--
Added file:
Roundup Robot added the comment:
New changeset 17b6d0d7da00 by Victor Stinner in branch 'default':
Issue #23485: Fix test_signal, select.select() now retries the syscall if the
https://hg.python.org/cpython/rev/17b6d0d7da00
--
___
Python tracker
STINNER Victor added the comment:
Last 5 builds of x86 Ubuntu Shared 3.x and AMD64 Debian root 3.x buildbots
are green (success). The sporadic hang is gone! I close the issue.
--
resolution: - fixed
status: open - closed
___
Python tracker
Josh Rosenberg added the comment:
I think my first addition example is wrong (should produce [2, 1, 2]), but you
get the idea.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23793
___
Berker Peksag added the comment:
Thanks for the patch, John.
I'm under the impression that the final patch will need to include a test
that confirms the patch worked,
Correct. You could convert the reproducers in msg239445 to a test case.
The patch looks good to me. I think you'll also
Martin Panter added the comment:
The new patch looks good, thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23729
___
___
Python-bugs-list
New submission from Jon Heiner:
I believe there is an issue with the _struct.c handling of Pascal style strings.
In the _struct.c:s_unpack_internal() function (reading 2.7.6 and 2.7.9 source
from tgz ball), the size parameter 'n' is clamped to code-size-1.
As far as I can tell, 'n' is set to
Josh Rosenberg added the comment:
The behavior for multiplying or adding doesn't seem quite so intuitive when you
allow for a bounded deque. In particular, it doesn't seem obvious that
multiplying when the deque is bounded, you'll get results like:
list(deque([1,2], 3) * 2)
[2, 1, 2]
John Hergenroeder added the comment:
If no-one else wants it, I'd love to tackle this as my first Python (and OSS in
general) contribution. Attached is a one-line patch that just does a
CHECK_CLOSED call in buffered_peek and is modeled on the pattern in the
buffered_flush function just above.
Martin Panter added the comment:
I agree with Serhiy that using a permissive error handler with pprint() is
appropriate.
What is the reasoning behind the DecodeWriter case, where the original stream
has an interesting encoding, but “buffer” is None? Are there any real-world
cases like that?
Raymond Hettinger added the comment:
The behavior for multiplying or adding doesn't seem quite so
intuitive when you allow for a bounded deque.
What would you want it to do? By design, the key feature of maxlen is pop old
inputs to make way newer appends -- that is its essence.
It would
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
type: behavior - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23484
___
Craig Holmquist added the comment:
New patch is attached.
--
Added file: http://bugs.python.org/file38749/imap_auth2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23779
___
Martin Panter added the comment:
I think this patch needs a test. I left some comments on Reitveld as well.
Perhaps there should also be a test to prove that redirects to URLs like
/spaced%20path/ do not get mangled.
Have a look at the HTTPRedirectHandler.redirect_request() method. Perhaps
Martin Panter added the comment:
Patch v4 adds back the reference to “universal newlines”. I did not alter the
doc string, because I don’t think doc strings need to be as detailed as the
main documentation.
--
Added file: http://bugs.python.org/file38748/linebreakdoc.v4.py3.5.patch
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +amaury.forgeotdarc, belopolsky, meador.inge
stage: - patch review
type: crash - behavior
versions: +Python 3.4, Python 3.5 -Python 3.6
___
Python tracker rep...@bugs.python.org
Changes by Berker Peksag berker.pek...@gmail.com:
--
resolution: - duplicate
stage: patch review - resolved
status: open - closed
superseder: - PyErr_Format in ctypes uses invalid parameter
type: crash - behavior
___
Python tracker
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5714
___
___
Python-bugs-list
Changes by Ned Deily n...@acm.org:
--
resolution: fixed -
stage: resolved - needs patch
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23458
___
1 - 100 of 125 matches
Mail list logo
