[issue24635] test_typing is flaky

2015-09-03 Thread STINNER Victor
STINNER Victor added the comment: Is there any progress on this issue? It's still failing randomly: http://buildbot.python.org/all/builders/x86%20Ubuntu%20Shared%203.5/builds/221/steps/test/logs/stdio -- ___ Python tracker

[issue24998] docs: subprocess.Popen example has extra/invalid parameter

2015-09-03 Thread eryksun
Changes by eryksun : -- keywords: +easy priority: normal -> low versions: +Python 3.4, Python 3.5, Python 3.6 ___ Python tracker ___ _

[issue24986] It should be possible to build successfully without external libraries

2015-09-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 252d4760f28b by Zachary Ware in branch '2.7': Issue #24986: Save some bandwidth from svn.python.org https://hg.python.org/cpython/rev/252d4760f28b New changeset 4e7ce0b10eea by Zachary Ware in branch '3.5': Issue #24986: Save some bandwidth from svn

[issue24989] scan_eol() Buffer Over-read

2015-09-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2b6ce7e9595c by Serhiy Storchaka in branch '3.5': Issue #24989: Fixed buffer overread in BytesIO.readline() if a position is https://hg.python.org/cpython/rev/2b6ce7e9595c -- ___ Python tracker

[issue24989] scan_eol() Buffer Over-read

2015-09-03 Thread Larry Hastings
Larry Hastings added the comment: Pull request accepted. Please forward-merge. Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker __

[issue24998] docs: subprocess.Popen example has extra/invalid parameter

2015-09-03 Thread Paul Clarke
New submission from Paul Clarke: in "subprocess" module documentation has a section for "replacing older functions with subprocess", specifically 17.1.4.5 "replacing os.popen", which includes the example on "return code handling", specifically this line: -- process = Popen("cmd", 'w', shell=Tru

[issue24997] mock.call_args compares as equal and not equal

2015-09-03 Thread A Kaptur
New submission from A Kaptur: mock.call_args can be both equal to and not equal to another object: >>> m = Mock() >>> m(1,2) >>> m.call_args call(1, 2) >>> m.call_args == call(1,2) True >>> m.call_args != call(1,2) True This appears to be a recent regression - it repros on trunk, but not on 3.

[issue21192] Idle: Print filename when running a file from editor

2015-09-03 Thread Larry Hastings
Larry Hastings added the comment: Pull request accepted, please forward-merge. Thanks! > There is something odd about the size of your clone. My cpython > clone is 928 MB on disk with 30300 files, while the clone of my fork > of your repository is 1.59 GB for 14500 files. I have no idea why.

[issue24986] It should be possible to build successfully without external libraries

2015-09-03 Thread Zachary Ware
Zachary Ware added the comment: The committed versions are slightly different, I had bad logic in adding _socket to ExtensionModules (if IncludeExternals was false while IncludeSSL was true, _socket wasn't added). build.bat also uses the property names instead of its own internal names so as

[issue24986] It should be possible to build successfully without external libraries

2015-09-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2bc91f1f2b34 by Zachary Ware in branch '2.7': Issue #24986: Allow building Python without external libraries on Windows https://hg.python.org/cpython/rev/2bc91f1f2b34 New changeset 301c36746e42 by Zachary Ware in branch '3.5': Issue #24986: Allow bu

[issue24989] scan_eol() Buffer Over-read

2015-09-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: https://bitbucket.org/larry/cpython350/pull-requests/13/issue-24989/diff -- ___ Python tracker ___ ___

[issue24857] mock: Crash on comparing call_args with long strings

2015-09-03 Thread A Kaptur
A Kaptur added the comment: Here's a simple patch + test for the original bug. I'll file the __ne__ question separately. -- keywords: +patch stage: needs patch -> patch review Added file: http://bugs.python.org/file40348/issue24857.patch ___ Python t

[issue24857] mock: Crash on comparing call_args with long strings

2015-09-03 Thread A Kaptur
A Kaptur added the comment: It looks like there's a related bug in call_args around __ne__: >>> m = Mock() >>> m(1,2) >>> m.call_args call(1, 2) >>> m.call_args == call(1,2) True >>> m.call_args != call(1,2) True Any reason not to define __ne__ as not __eq__? Otherwise it looks like you fall

[issue18540] imaplib.IMAP4() ends with "Name or service not known" on Fedora 18

2015-09-03 Thread Milan Oberkirch
Milan Oberkirch added the comment: I shouldn't criticize my own patches if I want to have them committed: Here comes the final and perfect patch for this issue ;) (I only rephrased the comment for the test to make the intuition clear.) -- Added file: http://bugs.python.org/file40347/ima

[issue17582] xml.etree.ElementTree does not preserve whitespaces in attributes

2015-09-03 Thread Duane Griffin
Duane Griffin added the comment: Here is a patch with a unit test for the new escaping functionality. I believe it covers all the new cases. Additional code is not required for cElementTree as the serialisation code is all Python. -- nosy: +duaneg Added file: http://bugs.python.org/fil

[issue24991] Define instance mutability explicitly on type objects

2015-09-03 Thread Eric Snow
Eric Snow added the comment: Yeah, this definitely relates to the project I'm working on. -- ___ Python tracker ___ ___ Python-bugs-li

[issue21192] Idle: Print filename when running a file from editor

2015-09-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: On 9/3/2015 4:31 AM, Larry Hastings wrote: > Terry, if you want this pulled in to Python 3.5.0, you'll need to create a > pull request on Bitbucket. Instructions are here: > > https://mail.python.org/pipermail/python-dev/2015-August/141167.html I don't rememb

[issue21192] Idle: Print filename when running a file from editor

2015-09-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: https://bitbucket.org/larry/cpython350/pull-requests/12/issue-21192-change-run-back-to-restart/diff -- ___ Python tracker ___ __

[issue24996] IDLE: debugger local/global vars should not be editable

2015-09-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: That makes sense, given that a string or list could be indefinitely long. -- ___ Python tracker ___

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

2015-09-03 Thread Eric Snow
Eric Snow added the comment: Thanks for taking care of this, Victor (and Serhiy). :) -- stage: -> resolved type: -> behavior ___ Python tracker ___

[issue24913] deque.index() overruns deque boundary

2015-09-03 Thread Brett Cannon
Brett Cannon added the comment: OK, that should cover 3.5.0 and then null merge through 3.5 and default. I thus consider my favour to Larry done and Raymond now owes me one. -- ___ Python tracker _

[issue24913] deque.index() overruns deque boundary

2015-09-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9f8c59e61594 by Brett Cannon in branch '3.5': Issue #24913: Fix overrun error in deque.index(). https://hg.python.org/cpython/rev/9f8c59e61594 New changeset d093d87e449c by Brett Cannon in branch '3.5': Merge from 3.5.0 for issue #24913 https://hg.p

[issue17849] Missing size argument in readline() method for httplib's class LineAndFileWrapper

2015-09-03 Thread Cory Benfield
Cory Benfield added the comment: Ok, version three of the patch is now available. -- Added file: http://bugs.python.org/file40345/readline_3.patch ___ Python tracker ___

[issue24989] scan_eol() Buffer Over-read

2015-09-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset a5858c30db7c by Serhiy Storchaka in branch '3.5': Issue #24989: Fixed buffer overread in BytesIO.readline() if a position is https://hg.python.org/cpython/rev/a5858c30db7c New changeset 215800fb955d by Serhiy Storchaka in branch 'default': Issue #24

[issue24996] IDLE: debugger local/global vars should not be editable

2015-09-03 Thread Mark Roseman
Mark Roseman added the comment: Thanks Terry, sorry I missed your previous mention of this. From what I recall the treeview doesn't allow editable items, but what I've done in similar circumstances before (editing text items on a canvas in drawing type programs) was 'place' an entry widget on

[issue24995] better exception message when an unsupported object is passed to `async for` (pep 492)

2015-09-03 Thread Yury Selivanov
Yury Selivanov added the comment: I saw this reddit thread: https://www.reddit.com/r/Python/comments/3ewnwq/async_function_as_generator_for_async_for/ where people are struggling with understanding how 'async for' works. Which led me to check what error messages we raise when we pass a wrong

[issue17849] Missing size argument in readline() method for httplib's class LineAndFileWrapper

2015-09-03 Thread Cory Benfield
Cory Benfield added the comment: Martin, the idea of simply rejecting the LifeAndFileWrapper HTTP/0.9 fallback for _tunnel feels reasonable to me, that can work. Let me whip up an alternative patch that does that. -- ___ Python tracker

[issue24996] IDLE: debugger local/global vars should not be editable

2015-09-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: I already brought this up as part of one of the StackViewer/Debugger/merge issues. Replacing the list with a tree would automatically change this unless the tree was changed to have a entry. Why? My speculation is an intention never carried out. Labels could

[issue24995] better exception message when an unsupported object is passed to `async for` (pep 492)

2015-09-03 Thread STINNER Victor
STINNER Victor added the comment: IMHO the current message is clear enough. -- ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue21192] Idle: Print filename when running a file from editor

2015-09-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: Sorry, my memory was that I was supposed to that as a signal, but maybe that was with a different RM. -- ___ Python tracker ___ ___

[issue24995] better exception message when an unsupported object is passed to `async for` (pep 492)

2015-09-03 Thread Guido van Rossum
Guido van Rossum added the comment: Did you get multiple complaints about this? The existing error doesn't seem so bad. -- ___ Python tracker ___ ___

[issue15348] IDLE - shell becomes unresponsive if debugger windows is closed while active.

2015-09-03 Thread Mark Roseman
Changes by Mark Roseman : -- nosy: +markroseman ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue15347] IDLE - does not close if the debugger was active

2015-09-03 Thread Mark Roseman
Changes by Mark Roseman : -- nosy: +markroseman ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue24996] IDLE: debugger local/global vars should not be editable

2015-09-03 Thread Mark Roseman
New submission from Mark Roseman: In the debugger, the values for the variables shown in the locals/globals panes are editable (i.e. using Entry widget) but I don't see any mechanism to have those changes affect anything. If I'm not missing something, why Entry and not Label? -- messa

[issue24995] better exception message when an unsupported object is passed to `async for` (pep 492)

2015-09-03 Thread Yury Selivanov
New submission from Yury Selivanov: Should we raise something like "'int' object is not an asynchronous iterable", instead of "'async for' requires an object with __aiter__ method, got int"? >>> foo().send(None) Traceback (most recent call last): File "", line 1, in File "", line 2, in fo

[issue24987] subprocess.Popen with shell=True doesn't create socket

2015-09-03 Thread Martin Panter
Changes by Martin Panter : -- resolution: -> works for me ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue24990] Foreign language support in turtle module

2015-09-03 Thread Al Sweigart
Al Sweigart added the comment: Good idea. I'll bring it up on the python-ideas list. -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue24991] Define instance mutability explicitly on type objects

2015-09-03 Thread Eugene Toder
Changes by Eugene Toder : -- nosy: +eltoder ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

2015-09-03 Thread Larry Hastings
Larry Hastings added the comment: That *is* easier, thanks. Though the UI for that is baffling. Protip: search for the section where all the "custom" builders are listed all in one section, three-quarters of the way down the page. -- ___ Python tr

[issue21192] Idle: Print filename when running a file from editor

2015-09-03 Thread Larry Hastings
Larry Hastings added the comment: On the other hand, I do not hold with marking a minor cosmetic change like this as "release blocker". I'm willing to accept the change, given PEP 434, but I'm not going to delay any releases for it. -- priority: release blocker -> normal

[issue24912] The type of cached objects is mutable

2015-09-03 Thread Mark Shannon
Mark Shannon added the comment: Larry, of the two choices, I prefer rolling back the change entirely. I would like to see the bug fixes for typeobject.c applied, but I see no reason why making the __class__ of module objects assignable should be included. -- __

[issue24913] deque.index() overruns deque boundary

2015-09-03 Thread Larry Hastings
Larry Hastings added the comment: Merged. Please do a (null) merge forward into 3.5.1 and 3.6. Thanks! -- resolution: -> fixed status: open -> closed ___ Python tracker ___ __

[issue3199] 2.6b1 Build Fails On OSX 10.5

2015-09-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 94f61fe22edf by Victor Stinner in branch '3.4': Don't use defined() in C preprocessor macros https://hg.python.org/cpython/rev/94f61fe22edf -- nosy: +python-dev ___ Python tracker

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

2015-09-03 Thread STINNER Victor
STINNER Victor added the comment: Yury wrote: > Is this something that we should ship in 3.5.0rc3? I don't think so. I agree with Serhiy who wrote: > It looks to me as an ordinal bug and that is encountered only in special > circumstances with small probability. I think it can wait for 3.5.1.

[issue24987] subprocess.Popen with shell=True doesn't create socket

2015-09-03 Thread asduj
asduj added the comment: Hello, Eric and Martin! I don't know what happened, but now it works. I have checked this problem on two computers two days ago, and then the command was not working. But now, I run exactly that command, and it works as should. I don't know what has changed. Maybe, bec

[issue24988] IDLE: debugger context menus not working on Mac

2015-09-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: I just found #24801 which addressed the editor issue. -- ___ Python tracker ___ ___ Python-bugs-list

[issue24988] IDLE: debugger context menus not working on Mac

2015-09-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: The standard on Windows is to bring up a context menu on right-button-release, not on r-b-press. What about linux and mac? Thunderbird and Notepad++ move the insertion cursor on rb-press, That is the paste position even if the mouse is moved before release.

[issue24913] deque.index() overruns deque boundary

2015-09-03 Thread Brett Cannon
Brett Cannon added the comment: PR created, Larry. -- assignee: brett.cannon -> larry stage: -> resolved ___ Python tracker ___ ___ P

[issue24979] Allow timezone offsets greater than 24 hours

2015-09-03 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: I always thought that restriction came from ISO 8601, but at the moment I don't have it to check. -- ___ Python tracker ___ _

[issue24979] Allow timezone offsets greater than 24 hours

2015-09-03 Thread TJ
TJ added the comment: Thanks for the pointer to #5288. Happy to consolidate there. In my reading of #5094 (from which I pulled your RFC 2822 reference), the justification I found was "For the allowable range, follow the datetime docs as someone might be relying on that specification already".

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

2015-09-03 Thread Yury Selivanov
Yury Selivanov added the comment: Is this something that we should ship in 3.5.0rc3? -- nosy: +yselivanov ___ Python tracker ___ ___ P

[issue24974] ICC on Windows 8.1: _decimal fails to compile with default fp model

2015-09-03 Thread Zachary Ware
Zachary Ware added the comment: Committed! Thank you Steve for the suggestion and Stefan for the approval. -- ___ Python tracker ___

[issue24974] ICC on Windows 8.1: _decimal fails to compile with default fp model

2015-09-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 863407e80370 by Zachary Ware in branch '3.5': Issue #24974: Force fp-model precice in mpdecimal.c on Windows https://hg.python.org/cpython/rev/863407e80370 New changeset 88c28d29afe4 by Zachary Ware in branch 'default': Closes #24974: Merge with 3.5

[issue24974] ICC on Windows 8.1: _decimal fails to compile with default fp model

2015-09-03 Thread Stefan Krah
Stefan Krah added the comment: We can always blame any fallout on ICC. ;) -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24974] ICC on Windows 8.1: _decimal fails to compile with default fp model

2015-09-03 Thread Zachary Ware
Zachary Ware added the comment: There's not a 32-bit ICC buildbot, though I could force one. But since you say commit it, I'll commit it ;) -- ___ Python tracker ___ ___

[issue24988] IDLE: debugger context menus not working on Mac

2015-09-03 Thread Mark Roseman
Mark Roseman added the comment: Terry, the new code I've proposed includes a "tkextras" module that is a good place for these sort of little convenience functions. -- ___ Python tracker ___

[issue24974] ICC on Windows 8.1: _decimal fails to compile with default fp model

2015-09-03 Thread Stefan Krah
Stefan Krah added the comment: Hmm, I don't see a 32-bit ICC buildbot. This problem can only occur on 32-bit with -DPPRO defined. Please go ahead and commit the patch. The inline asm miscompilation problem I mentioned earlier was solved in 12.0 (I think), so let's just assume it's gone (probabl

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

2015-09-03 Thread STINNER Victor
STINNER Victor added the comment: > I left a nitpick. In any case the patch LGTM. Ok, fixed. I pushed my fix. Thanks for the review Serhiy. -- resolution: -> fixed status: open -> closed ___ Python tracker _

[issue24984] document AF_BLUETOOTH socket address formats

2015-09-03 Thread R. David Murray
R. David Murray added the comment: Uploading new patches is correct. We generally don't unlink the old ones unless the history starts to get really confusing. -- nosy: +r.david.murray ___ Python tracker _

[issue24974] ICC on Windows 8.1: _decimal fails to compile with default fp model

2015-09-03 Thread Zachary Ware
Zachary Ware added the comment: I tested both 32 and 64 bit, with MSVC 14 (VS 2015) and ICC 15.0 (backed by VS 2015). I can go ahead and commit this to a sandbox for buildbot testing if it would help. -- ___ Python tracker

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

2015-09-03 Thread Brett Cannon
Changes by Brett Cannon : -- assignee: larry -> brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue7175] Define a standard location and API for configuration files

2015-09-03 Thread R. David Murray
R. David Murray added the comment: As someone else mentioned, the freedesktop standard is only really "widely followed" by desktop aps. My own .config directory contains 8 entries, while there are 13 rc files/directories in my homedir (one of which is my X windows manager :) That's not to me

[issue24305] The new import system makes it inconvenient to correctly issue a deprecation warning for a module

2015-09-03 Thread Zachary Ware
Zachary Ware added the comment: Just to note, there's an easier way to run a custom build on multiple bots: go to http://buildbot.python.org/all/builders/ and scroll (way) down to the section for forcing a build on custom builders (you can search for 'Repo path:' (with the colon)), check the b

[issue24994] Python 3.4.2 64-bit Installer error (Please insert the disk:)

2015-09-03 Thread Zachary Ware
Zachary Ware added the comment: Glad you solved it for yourself :) -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___

[issue1103213] Adding the missing socket.recvall() method

2015-09-03 Thread STINNER Victor
STINNER Victor added the comment: recvall.patch: implement socket.socket.recvall() in pure Python. It raises a new socket.IncompleteReadError (copied from asyncio) exception if the connection is closed before we got the expected number of bytes. The patch has unit tests, document the new metho

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

2015-09-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset ef1f5aebe1a6 by Victor Stinner in branch '3.5': Issue #24992: Fix error handling and a race condition (related to garbage https://hg.python.org/cpython/rev/ef1f5aebe1a6 -- nosy: +python-dev ___ Python tra

[issue24990] Foreign language support in turtle module

2015-09-03 Thread R. David Murray
R. David Murray added the comment: There is a discussion elsewhere about whether it is time to start formalizing translation efforts for the python docs (Sphinx supports it). Unfortunately I don't remember where I saw it (probably another issue in the tracker. I can see your argument about tu

[issue24984] document AF_BLUETOOTH socket address formats

2015-09-03 Thread Tim Tisdall
Tim Tisdall added the comment: changed "This protocol does not work under FreeBSD." to the more accurate "This protocol is not supported under FreeBSD." -- Added file: http://bugs.python.org/file40343/bluetooth_socket_docs_4.patch ___ Python tracker

[issue24994] Python 3.4.2 64-bit Installer error (Please insert the disk:)

2015-09-03 Thread Cameron Walker
Cameron Walker added the comment: Never mind. I just had to click repair... -- ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

2015-09-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I left a nitpick. In any case the patch LGTM. -- ___ Python tracker ___ ___ Python-bugs-list maili

[issue23406] interning and list comprehension leads to unexpected behavior

2015-09-03 Thread R. David Murray
R. David Murray added the comment: Looks good to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue23630] support multiple hosts in create_server/start_server

2015-09-03 Thread Yann Sionneau
Yann Sionneau added the comment: Here is a new patch without any dependency on netifaces. Thanks Victor for the great deal of help for all the mock() stuff! -- Added file: http://bugs.python.org/file40342/multibind6.patch ___ Python tracker

[issue24994] Python 3.4.2 64-bit Installer error (Please insert the disk:)

2015-09-03 Thread Cameron Walker
New submission from Cameron Walker: I had attempted to uninstall python 3.4.2 from the start menu in Windows 7, but it was still visible in my Programs and features. I tried to uninstall it from there but it said it was missing some files. So I re-downloaded the installer, but when it tried to

[issue24984] document AF_BLUETOOTH socket address formats

2015-09-03 Thread Tim Tisdall
Tim Tisdall added the comment: I added a note to BTPROTO_SCO that it doesn't work in FreeBSD (I forgot to mention that). -- Added file: http://bugs.python.org/file40341/bluetooth_socket_docs_3.patch ___ Python tracker

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

2015-09-03 Thread STINNER Victor
STINNER Victor added the comment: > It looks to me as an ordinal bug and that is encountered only in special > circumstances with small probability. I think it can wait for 3.5.1. Ok, I agree. What about the second patch, does it look ok? -- ___ Pyt

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

2015-09-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It looks to me as an ordinal bug and that is encountered only in special circumstances with small probability. I think it can wait for 3.5.1. -- ___ Python tracker _

[issue24993] The C function PyCodec_NameReplaceErrors doesn't handle PyCapsule_Import() failure

2015-09-03 Thread STINNER Victor
STINNER Victor added the comment: Thanks for your review and your cool error handler. -- ___ Python tracker ___ ___ Python-bugs-list m

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

2015-09-03 Thread STINNER Victor
STINNER Victor added the comment: @Serhiy: Python 3.5 is impacted. Do you consider this bug serious enough to request a pull request in Larry's branch for Python 3.5.0? -- nosy: +larry versions: +Python 3.5 ___ Python tracker

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

2015-09-03 Thread STINNER Victor
STINNER Victor added the comment: > See msg246573. PyDict_New() can trigger garbage collecting and traversing and > GC have a reference to underinitialized OrderedDict and can call > odict_traverse() for it. Oooh ok, I understand. I updated my patch to implement your idea. -- Added f

[issue24984] document AF_BLUETOOTH socket address formats

2015-09-03 Thread Tim Tisdall
Tim Tisdall added the comment: I'm not really sure how to add a `versionadded` tag to specify that only the BSD-specific support was added in 3.2 (as general support was there prior to that). If I just add the plain tag below that bullet point it would imply that the whole protocol was added

[issue24984] document AF_BLUETOOTH socket address formats

2015-09-03 Thread Tim Tisdall
Tim Tisdall added the comment: Martin, the odd thing with the SCO protocol is it's expecting an bluetooth address as a byte string (ex b'12:23:34:45:56:67' [note the `b`]) where the other 3 are expecting a regular string (ex '12:23:34:45:56:67'). I think it may have been a case of someone doi

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

2015-09-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > We only give the reference to the caller when the newly created OrderedDict > is fully initialized (consistent). See msg246573. PyDict_New() can trigger garbage collecting and traversing , and GC have a reference to underinitialized OrderedDict and can call

[issue24993] The C function PyCodec_NameReplaceErrors doesn't handle PyCapsule_Import() failure

2015-09-03 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue24993] The C function PyCodec_NameReplaceErrors doesn't handle PyCapsule_Import() failure

2015-09-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset ac1995b01028 by Victor Stinner in branch '3.5': Issue #24993: Handle import error in namereplace error handler https://hg.python.org/cpython/rev/ac1995b01028 -- nosy: +python-dev ___ Python tracker

[issue24993] The C function PyCodec_NameReplaceErrors doesn't handle PyCapsule_Import() failure

2015-09-03 Thread STINNER Victor
STINNER Victor added the comment: > It was optional in Python 2 (at least in Unicode-disabled build). Yeah, even if I don't think that anyone is really using python without unicode in the wild. I guess that too many libraries don't work without unicode. Well, anyway this issue is for Python 3.

[issue24993] The C function PyCodec_NameReplaceErrors doesn't handle PyCapsule_Import() failure

2015-09-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > In which case the unicodedata module is missing? It's always part of CPython > no? It was optional in Python 2 (at least in Unicode-disabled build). Perhaps it can be exclude from custom build in Python 3 too. > Yeah, it's not a good practice to *hide* err

[issue24984] document AF_BLUETOOTH socket address formats

2015-09-03 Thread Tim Tisdall
Tim Tisdall added the comment: I'm not sure the proper way to update the patch... I can't seem to edit the existing one or replace it. I'm uploading an updated one, but should I simply "unlink" (aka delete) the old one? -- Added file: http://bugs.python.org/file40339/bluetooth_socket_

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

2015-09-03 Thread STINNER Victor
STINNER Victor added the comment: > If don't initialize fields, then they will be not initialized in odict_dealloc Old code initialized all fields to zero (or NULL), like "_odict_FIRST(od) = NULL;". The type allocator fills the newly allocated with zeros. So setting fields again to zero is red

[issue23375] test_py3kwarn fails on Windows

2015-09-03 Thread Berker Peksag
Changes by Berker Peksag : -- stage: patch review -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue24992] collections.OrderedDict constructor (odict_new) doesn't handle PyDict_New() failure

2015-09-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: If don't initialize fields, then they will be not initialized in odict_dealloc, odict_tp_clear and odict_traverse. But _odict_FIRST(od) and od->od_weakreflist are used in these functions. I would allocate a dict for od_inst_dict before calling PyDict_Type.tp

[issue24993] The C function PyCodec_NameReplaceErrors doesn't handle PyCapsule_Import() failure

2015-09-03 Thread STINNER Victor
STINNER Victor added the comment: > The purpose was to make the dependence of unicodedata optional. In which case the unicodedata module is missing? It's always part of CPython no? > (...) but now I think that probably your approach is more preferable because > it makes the code simpler and er

[issue24993] The C function PyCodec_NameReplaceErrors doesn't handle PyCapsule_Import() failure

2015-09-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The purpose was to make the dependence of unicodedata optional. Here is a patch that adds missing lines to clear import error. But your approach looks reasonable too and the patch is correct. I have no strong preferences, but now I think that probably your a

[issue24748] Change of behavior for importlib between 3.4 and 3.5 with DLL loading

2015-09-03 Thread Petr Viktorin
Petr Viktorin added the comment: Indeed. I don't have access to a Windows machine, but I will try reproducing the problem on another system. -- ___ Python tracker ___ __

[issue24987] subprocess.Popen with shell=True doesn't create socket

2015-09-03 Thread Eric V. Smith
Eric V. Smith added the comment: With both python 2 and 3, what does "ps -efww | fgrep soffice" produce? -- nosy: +eric.smith ___ Python tracker ___ _

[issue23406] interning and list comprehension leads to unexpected behavior

2015-09-03 Thread Matheus Vieira Portela
Matheus Vieira Portela added the comment: Applying review comments. Now, there is an internal link to the FAQ entry on multidimensional lists. -- Added file: http://bugs.python.org/file40337/issue23406_doc_stdtypes_and_faq.patch ___ Python tracker

[issue7175] Define a standard location and API for configuration files

2015-09-03 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 03.09.2015 13:37, flying sheep wrote: > all three OSs have stable, widely followed standards in place, and the idea > of providing a python stdlib API for them received an almost unanimously > positive response – with the sole exception being you. I'm n

[issue7175] Define a standard location and API for configuration files

2015-09-03 Thread flying sheep
flying sheep added the comment: you’re right about the two problems being mixed, however not about the standards. also you’re intermingling conventions with actual standards. the directory standards for all three big OSs are either not going to change or fitted with a backwards-compatibility

[issue23719] PEP 475: port test_eintr to Windows

2015-09-03 Thread STINNER Victor
STINNER Victor added the comment: The change ed0e6a9c11af replaced os.fork() with subprocess to try to fix race conditions in test_eintr (the test sometimes hangs on FreeBSD buildbots). os.fork() is not available on Windows, so this change should help to port test_eintr to Windows. About win3

[issue7175] Define a standard location and API for configuration files

2015-09-03 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 02.09.2015 16:37, flying sheep wrote: > > hi mark, i’ve just lengthily replied to you on python-ideas. > > in short: nope! many command line tools that are relatively new (among them > your examples git and pip) honor the specs, my ~/.cache, ~/.config,

[issue24993] The C function PyCodec_NameReplaceErrors doesn't handle PyCapsule_Import() failure

2015-09-03 Thread STINNER Victor
STINNER Victor added the comment: Note: I found the bug when running test_codecs using failmalloc, a library to inject MemoryError. -- ___ Python tracker ___ ___

  1   2   >