[issue27647] Update Windows build to Tcl/Tk 8.6.6

Benjamin Peterson added the comment: I don't mind if it gets updated. On Wed, Nov 30, 2016, at 00:01, Serhiy Storchaka wrote: > > Serhiy Storchaka added the comment: > > Why not? 8.5.15 is 3 years old. There were 4 bugfix releases since it. > > -- > >

[issue28728] test_host_resolution in test_socket fails

Xiang Zhang added the comment: Ohh, sorry. > I was wondering if there was a separate way to detect the troublesome ISP > environment. How could you differentiate the failure between ISP environment caused and function behaved wrongly? Successfully resolve an invalid ip address doesn't mean

[issue28848] Add CopyingMock to mock.py

wim glenn added the comment: Here's a first attempt at a patch. If it doesn't go into Lib finally, I'll just put up a CopyingMock on pypi instead. But it seemed like the kind of feature which should just be in mock directly rather than 3rd party, preferably. -- keywords: +patch

[issue28848] Add CopyingMock to mock.py

New submission from wim glenn: Would people be interested to consider adding the CopyingMock example shown in the documentation section "coping with mutable arguments" into the mock module? https://docs.python.org/3/library/unittest.mock-examples.html#coping-with-mutable-arguments It seems

[issue28841] urlparse.urlparse() parses invalid URI without generating an error (examples provided)

R. David Murray added the comment: Yes, I'm afraid so. But the rationale is presumably the same as it is in many RFCs: you should accept broken stuff if it can be interpreted unambiguously, but you should not *produce* the broken stuff. So I'd say the RFC is correct as quoted. It is then

[issue28728] test_host_resolution in test_socket fails

Martin Panter added the comment: I think the original test is trying to ensure that an invalid numeric IP address results in an OSError. So changing it to skip the test on OSError does not seem wise. Also, Silent Ghost said that the problem was with gethostbyaddr(), not gethostbyname(). I

[issue28847] dumbdbm should not commit if in read mode

New submission from Jonathan Ng: Or at the very least, if there is an OSError in _update, an error should be raised instead of ignoring this error. In the current state of the code, if there was an OSError while reading the dirfile, the dirfile would be overwritten with a blank file when it

[issue17490] Improve ast.literal_eval test suite coverage

Nick Coghlan added the comment: I don't know if the suggested test suite diff gives full coverage, but unless other improvements have been made to those tests in the meantime, it should give more coverage than we have right now. -- ___ Python

[issue28847] dumbdbm should not commit if

Changes by Jonathan Ng : -- nosy: Jonathan Ng priority: normal severity: normal status: open title: dumbdbm should not commit if type: behavior ___ Python tracker

[issue26363] __builtins__ propagation is misleading described in exec and eval documentation

Eryk Sun added the comment: As shown above, exec and eval default to calling PyEval_GetBuiltins when the globals dict doesn't define '__builtins__'. PyEval_GetBuiltins uses the current frame's f_builtins. If there isn't a current frame, it defaults to the interpreter's builtins, which should

[issue28728] test_host_resolution in test_socket fails

Changes by Xiang Zhang : Added file: http://bugs.python.org/file45714/test_host_resolution.patch ___ Python tracker ___

[issue26483] docs unclear on difference between str.isdigit() and str.isdecimal()

Martin Panter added the comment: “digits which do not form decimal radix forms” I see you have taken this from a Unicode document, but “forming a form” seems a long way of saying very little. The difference seems a bit vague, but I gather that digits not in the Unicode “decimal digit”

[issue28837] 2to3 does not wrap zip correctly

Changes by Xiang Zhang : -- nosy: +benjamin.peterson versions: +Python 3.6, Python 3.7 -Python 3.4 ___ Python tracker ___

[issue28841] urlparse.urlparse() parses invalid URI without generating an error (examples provided)

Amrith Kumar added the comment: Eric, Martin, I'm sure this is an interpretation (and I'll be fair and give you both) that a URL of the form: http://hostname.domain.tld:/path should be held invalid. The rationale is per the section of the spec you quoted. The other side of the argument is

[issue28820] Typo in section 6 of the Python 3.4 documentation

Ned Deily added the comment: Yes, there is no restriction on doc changes at the moment as long as they are relevant to 3.6.0. -- nosy: +ned.deily ___ Python tracker

[issue28846] Add a ProviderKey to the installer bundle

Ned Deily added the comment: Sounds good to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue28815] test_socket fails if /proc/modules is existent but not readable

Martin Panter added the comment: This seems reasonable in general. Did you test this exact patch Patrila? It looks to me like you need to change ENOENT → errno.ENOENT, etc. -- components: +Tests nosy: +martin.panter stage: -> patch review type: -> behavior versions: -Python 3.3,

[issue28728] test_host_resolution in test_socket fails

Martin Panter added the comment: Maybe you could factor out the first part of test_bad_address() that skips the test. It would only need to be used by negative test cases (that purposefully test invalid names). I presume positive tests would not need to be wrapped. --

[issue28771] Update documented signatures of tp_get/setattr

Roundup Robot added the comment: New changeset 2fd070fa6c15 by Martin Panter in branch '2.7': Issue #28771: Correct documentation of signatures using const https://hg.python.org/cpython/rev/2fd070fa6c15 -- nosy: +python-dev ___ Python tracker

[issue28755] Rework syntax highlighing in howto/clinic.rst

Martin Panter added the comment: It will apply to the 3.5 and 3.6 branches if I first backport revision 0a18d2cfeb52 (Issue 28753), which I think is valid. But I would wait until there is a branch for 3.6.1, and then commit to all three branches. (Ned asked for only release-critical changes

[issue28841] urlparse.urlparse() parses invalid URI without generating an error (examples provided)

Eric V. Smith added the comment: And note that there are tests that explicitly check that the colon with no port works (via issue 20270). Given that this behavior has been around for a while, and is explicitly allowed, I would recommend against changing this to an error. --

[issue28820] Typo in section 6 of the Python 3.4 documentation

Berker Peksag added the comment: Ned can correct me if I'm wrong, but you can push documentation patches without waiting for 3.6.0rc1. -- nosy: +berker.peksag ___ Python tracker

[issue28841] urlparse.urlparse() parses invalid URI without generating an error (examples provided)

Martin Panter added the comment: Also, this is in direct contradiction to Issue 20270. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue28841] urlparse.urlparse() parses invalid URI without generating an error (examples provided)

Martin Panter added the comment: The Python documentation refers to RFC 3986, which allows an empty port string introduced by a colon, although it recommends against it: The “port” subcomponent of “authority” is designated by an optional

[issue28846] Add a ProviderKey to the installer bundle

New submission from Steve Dower: Currently the installer bundles for 3.5 and later have an automatically generated dependency provider key. This makes it difficult for other installers to correctly depend on the bundle. For example, Visual Studio 2017 has an option to install CPython 3.5, but

[issue28841] urlparse.urlparse() parses invalid URI without generating an error (examples provided)

Amrith Kumar added the comment: As requested ... >>> urlparse.urlparse('http://www.google.com:/abc') ParseResult(scheme='http', netloc='www.google.com:', path='/abc', params='', query='', fragment='') I submit to you that this should generate an error. --

[issue28841] urlparse.urlparse() parses invalid URI without generating an error (examples provided)

Eric V. Smith added the comment: Can you please paste your code into a comment on this issue? Gist content has a habit of vanishing. Thanks! -- nosy: +eric.smith ___ Python tracker

[issue28838] Uniformize argument names of "call" functions (C API)

Eric V. Smith added the comment: Isn't this just a lot of churn for not a lot of benefit? I'm all for consistency, but you'll break patches on the bug tracker and externally maintained patches. -- nosy: +eric.smith ___ Python tracker

[issue28845] Clean up known issues for AIX

Julien Palard added the comment: Look like issue1745108 has only be closed for being "outdated" (msg240919 ), it does not clearly mean that the bug does no longer exists. Have you been able to test the example in it? -- ___ Python tracker

[issue17490] Improve ast.literal_eval test suite coverage

Julien Palard added the comment: > I also discovered several holes in the test suite coverage while refactoring > it. Are they all tested in the current diff? -- nosy: +mdk ___ Python tracker

[issue28845] Clean up known issues for AIX

Eric N. Vander Weele added the comment: > Having a few issues fixed does not mean that Python has been fully tested. I uploaded cleanup-readme-aix2.patch, which revives back the line removed in question and only removes lines which reference issues. I just noticed the results of Python's

[issue2771] Test issue

Ezio Melotti added the comment: Testing PR linking -- pull_requests: +1 ___ Python tracker ___ ___

[issue20185] Derby #17: Convert 49 sites to Argument Clinic across 13 files

Julien Palard added the comment: Look like this has never been applied, any reason for this? Tip has probably highly diverged, but I may try to rebase it, should I? -- nosy: +mdk ___ Python tracker

[issue28845] Clean up known issues for AIX

Julien Palard added the comment: You're also removing: > * Python has not been fully tested on AIX when compiled as a 64 bit > application. I do not have an AIX at hand but can someone at least confirm that all test passes? Having a few issues fixed does not mean that Python has been fully

[issue26363] __builtins__ propagation is misleading described in exec and eval documentation

Julien Palard added the comment: Hi Xavier, > It is not the dictionary of builtin module, which is inserted in , but the > current __builtin__ global It looks wrong, I'll even say the exact contrary: It _is_ the dictionary of builtin module which is inserted in, not the current __builtin__

[issue10444] A mechanism is needed to override waiting for Python threads to finish

Julien Palard added the comment: If nobody has nothing to add on this issue, I think it just should be closed. -- ___ Python tracker ___

[issue28755] Rework syntax highlighing in howto/clinic.rst

Julien Palard added the comment: Bump, 10 days later, hope this diff is still straightforward to merge. -- ___ Python tracker ___

[issue28845] Clean up known issues for AIX

Changes by Zachary Ware : -- nosy: +Michael.Felt stage: -> patch review versions: -Python 3.3, Python 3.4 ___ Python tracker

[issue28845] Clean up known issues for AIX

New submission from Eric N. Vander Weele: This patch cleans up Misc/README.AIX for addressed known issues. Issues that have been marked fixed: #11184, #11185 Issues resolved by new AIX version: #1745108 Issues resolved, but not yet marked fixed/closed: #11188 Additionally, it looks like #10709

[issue28833] cross compilation of third-party extension modules

Xavier de Gaye added the comment: So I suggest we start with this patch as it works for: * The standard library extension modules (for debian as well). * The third-party extension modules on platforms that have multiarch defined and on platforms that do not have multiarch defined (on debian

[issue28833] cross compilation of third-party extension modules

Xavier de Gaye added the comment: > I don't think that identifying the target by some path is the right way to > go, and you should be able to identify the target by giving the target > triplet as used by the configure parameters and then deduce the location from > the target (or have an

[issue28742] argparse.ArgumentDefaultsHelpFormatter sometimes provides inaccurate documentation of defaults, so they should be overrideable

Peter Eckersley added the comment: Thanks for your feedback Paul! I agree your proposed implementation strategy would probably be saner; I'll revise the patch to use that approach or something like it. As for the question of necessity, there are definitely more cases than just the

[issue28844] Pickling units

R. David Murray added the comment: To clarify: it looks from your report like units hasn't implemented pickling support. It isn't automatic for all classes. -- ___ Python tracker

[issue28844] Pickling units

R. David Murray added the comment: unit is not part of the stdlib. Please report this to whatever the upstream is for the package and/or to Anaconda. -- nosy: +r.david.murray resolution: -> third party stage: -> resolved status: open -> closed

[issue28844] Pickling units

New submission from Adam: See below code to show you can't round-trip units through pickle: Python 3.5.1 |Anaconda 4.0.0 (64-bit)| (default, Feb 16 2016, 09:49:46) [MSC v.1900 64 bit AMD64)] import units u = units.unit('myUnit') x = u(3.0) import pickle f = open('C:/temp/what.pkl', 'wb')

[issue28839] _PyFunction_FastCallDict(): replace PyTuple_New() with PyMem_Malloc()

Josh Rosenberg added the comment: Minor correction: No allocation when small stack used, so you'd only see (possibly) regressions with 6+ keyword arguments (assuming the tuple free list applies for tuples that large). Admittedly a minor concern; keyword processing is already pretty slow, and

[issue28791] update sqlite to 3.15.2

Steve Dower added the comment: I don't think we have anyone actively tracking SQLite right now, like we do for OpenSSL. All it really needs is someone to prepare and test the patch during the beta period, and to be available in case more fixes are required. At this stage, we're in the RC

[issue28733] Show how to use mock_open in modules other that __main__

Changes by Michał Bultrowicz : -- status: open -> closed ___ Python tracker ___

[issue28733] Show how to use mock_open in modules other that __main__

Michał Bultrowicz added the comment: Ok, I've checked again and now patching "file_writer.open" works. I have no idea what I was doing wrong the last time I checked... So I guess I'll close the issue. -- ___ Python tracker

[issue28839] _PyFunction_FastCallDict(): replace PyTuple_New() with PyMem_Malloc()

Josh Rosenberg added the comment: Given you can't avoid the refcounting overhead, how much does this really help? Are there meaningful benefits in microbenchmarks? I'd worry that unconditional allocation from PyMem_Malloc might lose out relative to PyTuple_New, which is likely to not involve

[issue28842] PyInstanceMethod_Type isn't hashable

Josh Rosenberg added the comment: Note: It's a little strange that instancemethod as a type sticks around even though literally nothing in Python uses it. Is there some reason we kept it in the 3.x transition? Extension types are using it, so I guess we can't drop it now, but I'm trying to

[issue28791] update sqlite to 3.15.2

Big Stone added the comment: I understand the decision. Yet it always baffles me that a version correcting known bugs is not included at beta stage. -- ___ Python tracker

[issue28843] asyncio.Task implemented in C loses __traceback__ for exceptions

New submission from Yury Selivanov: When a coroutine wrapped in a C asyncio.Task raises an Exception, the Task fails to correctly save the __traceback__. -- assignee: yselivanov components: asyncio files: task_tb.patch keywords: patch messages: 282092 nosy: gvanrossum, inada.naoki,

[issue28842] PyInstanceMethod_Type isn't hashable

New submission from David Wolever: The PyInstanceMethod_Type, unlike all other method types, isn't hashable. It seems like the code exists, it's just been commented out: https://github.com/python/cpython/blame/c30098c8c6014f3340a369a31df9c74bdbacc269/Objects/classobject.c#L569 This came up

[issue28840] IDLE not handling long lines correctly

Terry J. Reedy added the comment: The lengths of the strings on the 3 lines are 644, 432, and 7728, as determined by adding 4th line to print them. In Win10, the editor window shows. MESSAGE_1 = '02 MESSAGE_2 = 'Ag MESSAGE_1 = The problem is the blank after '=' on line 3. If I

[issue28427] WeakValueDictionary next bug (with multithreading)

Changes by Antoine Pitrou : -- stage: -> patch review ___ Python tracker ___ ___

[issue28427] WeakValueDictionary next bug (with multithreading)

Antoine Pitrou added the comment: Here is a patch showing the "atomic C function" approach. It will avoid the aforementioned memory growth in the common case, in exchange for a small bit of additional C code. -- Added file: http://bugs.python.org/file45710/issue28427-atomic.patch

[issue28841] urlparse.urlparse() parses invalid URI without generating an error (examples provided)

Changes by SilentGhost : -- nosy: +orsenthil versions: +Python 3.5, Python 3.6, Python 3.7 -Python 3.4 ___ Python tracker ___

[issue28427] WeakValueDictionary next bug (with multithreading)

Antoine Pitrou added the comment: Note the issue with this patch is that it may keep keys (with dead values) alive longer than necessary: - this may prevent memory consumption from decreasing - this may keep alive some system resources This is ok when keys are small simple objects (strings or

[issue28427] WeakValueDictionary next bug (with multithreading)

Antoine Pitrou added the comment: Here is a pure Python patch. -- Added file: http://bugs.python.org/file45709/issue28427-3.patch ___ Python tracker ___

[issue28841] urlparse.urlparse() parses invalid URI without generating an error (examples provided)

New submission from Amrith Kumar: The urlparse library incorrectly accepts a URI which specifies an invalid host identifier. Example: http://www.example.com:/abc Looking at the URI specifications, this is an invalid URI. By definition, you are supposed to specify a "hostport" and a hostport

[issue28838] Uniformize argument names of "call" functions (C API)

STINNER Victor added the comment: Serhiy: Can you please elaborate "Other changes looks not well justified too."? -- ___ Python tracker ___

[issue24339] iso6937 encoding missing

John Helour added the comment: Please ignore my previous question about: tmp += bytearray(encoding_map[c], 'latin1', 'ignore') The latest version don't needs such encoding ... -- Added file: http://bugs.python.org/file45708/iso6937.py ___ Python

[issue24339] iso6937 encoding missing

Changes by John Helour : Removed file: http://bugs.python.org/file45707/iso6937.py ___ Python tracker ___

[issue18777] Cannot compile _ssl.c using openssl > 1.0

James Matthews added the comment: This is marked as fixed but am still seeing this error in 2.7.12 on HP-UX 11.31. /opt/hp-gcc64-4.7.1/bin/gcc -pthread -shared build/temp.hp-ux-B.11.31-9000-800-2.7/root/build/Python-2.7.12/Modules/_ssl.o -L/usr/local/lib -lssl -lcrypto -o

[issue24339] iso6937 encoding missing

Changes by John Helour : Added file: http://bugs.python.org/file45707/iso6937.py ___ Python tracker ___

[issue24339] iso6937 encoding missing

Changes by John Helour : Added file: http://bugs.python.org/file45706/iso6937.py ___ Python tracker ___

[issue24339] iso6937 encoding missing

Changes by John Helour : Removed file: http://bugs.python.org/file45706/iso6937.py ___ Python tracker ___

[issue24339] iso6937 encoding missing

Changes by John Helour : Removed file: http://bugs.python.org/file45697/iso6937.py ___ Python tracker ___

[issue28840] IDLE not handling long lines correctly

New submission from piotr.sk: IDLE included in Python 3.5.2 does not display correctly files with very long lines under Windows 7. Attached example file does not show the third line correctly in Windows 7. These lines are part of a script that attempts to parse the messages. Even though very

[issue28838] Uniformize argument names of "call" functions (C API)

Nick Coghlan added the comment: Independently of anything else, any changes made to the parameter names in the implementation should be reflected in the API docs: https://docs.python.org/3/c-api/object.html#c.PyCallable_Check A style guide addition to PEP 7 would also be useful as a record of

[issue28839] _PyFunction_FastCallDict(): replace PyTuple_New() with PyMem_Malloc()

STINNER Victor added the comment: fastcalldict.patch avoided INCREF/DECREF on keyword keys and values. This is wrong: we must hold strong references because the keyword dictionary can be technically modified: see issue #2016 and test_extcall. Hum, I'm quite sure that it's not the first time

[issue28839] _PyFunction_FastCallDict(): replace PyTuple_New() with PyMem_Malloc()

New submission from STINNER Victor: Attached patch is a minor optimization for _PyFunction_FastCallDict(): avoid the creation of a tuple to pass keyword arguments, use a simple C array allocated by PyMem_Malloc(). It also uses a small stack of 80 bytes (2*5*sizeof(PyObject*)) allocated on the

[issue28838] Uniformize argument names of "call" functions

New submission from STINNER Victor: See python-dev thread about my changeset 7efddbf1aa70: https://mail.python.org/pipermail/python-dev/2016-November/146885.html Serhiy asked me to revert it. It's now reverted by the revision 20bb8babc505. So, here is my change as a patch to review it. See

[issue28838] Uniformize argument names of "call" functions (C API)

Changes by STINNER Victor : -- title: Uniformize argument names of "call" functions -> Uniformize argument names of "call" functions (C API) ___ Python tracker

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

Martin Panter added the comment: I made one minor change: element → slice -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

Roundup Robot added the comment: New changeset 83e3c863594c by Martin Panter in branch '2.7': Issue #25701: Document that some C APIs can both set and delete items https://hg.python.org/cpython/rev/83e3c863594c -- ___ Python tracker

[issue28837] 2to3 does not wrap zip correctly

New submission from Carsten: The following Python 2.7 code is not converted correctly to Python 3 by 2to3: c = [(1, 10), (2, 20)] # get a tuple with the first entries of every tuple in c, # i.e. (1, 2) x = zip(*c)[0] print x The result is c = [(1, 10), (2, 20)] # get a tuple with the

[issue22039] PyObject_SetAttr doesn't mention value = NULL

Martin Panter added the comment: As of Issue 25701, the null-to-delete feature is documented as being deprecated in favour of calling the related Del functions or macros. There was a python-dev thread at . I’m not sure if that is good

[issue28820] Typo in section 6 of the Python 3.4 documentation

Martin Panter added the comment: I’m waiting for the 3.6 release candidate before pushing to the Py 3 branches. -- ___ Python tracker ___

[issue28820] Typo in section 6 of the Python 3.4 documentation

Roundup Robot added the comment: New changeset 4f24641cd030 by Martin Panter in branch '2.7': Issue #28820: Fix spelling of “practice” as a noun https://hg.python.org/cpython/rev/4f24641cd030 -- nosy: +python-dev ___ Python tracker

[issue28832] Reduce memset in dict creation

INADA Naoki added the comment: > I think that clearing 120 bytes at a time is faster than clear it later > entry-by-entry. Ah, my word was wrong. This patch skips zero clear entirely. In pseudo code: // When allocating PyDictKeyObject. - memset(dk_entries, 0, sizeof(dk_entries)); // When

[issue11145] '%o' % user-defined instance

Armin Rigo added the comment: Looks ok now! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue11145] '%o' % user-defined instance

Serhiy Storchaka added the comment: Good catch Armin! Thank you for your review. Updated patch uses PyString_AsStringAndSize() and adds a check that result is exact str before changing it in-place. -- Added file: http://bugs.python.org/file45701/issue11145_5.patch

[issue28832] Reduce memset in dict creation

INADA Naoki added the comment: I ran pyperformance again on more large machine (Azure D2 -> D4) for more robust result. $ ./python-default -m perf compare_to default.json.gz patched.json.gz -G Slower (4): - xml_etree_generate: 425 ms +- 18 ms -> 442 ms +- 19 ms: 1.04x slower - call_method:

[issue28832] Reduce memset in dict creation

Changes by INADA Naoki : Added file: http://bugs.python.org/file45699/default.json.gz ___ Python tracker ___

[issue28781] On Installation of 3.5 Python get error message

Mark Harris added the comment: This is everything I have in my temp file that I could possibly send you, hope it helps. -- Added file: http://bugs.python.org/file45698/Python 4.zip ___ Python tracker

[issue11145] '%o' % user-defined instance

Armin Rigo added the comment: I reviewed your patch again. It does look good after all: I find only one issue---it seems I implied there were several ones but I can't find more. The issue is that PyString_AsString(result) will succeed if 'result' is a unicode. Then you call

[issue27647] Update Windows build to Tcl/Tk 8.6.6

Serhiy Storchaka added the comment: Why not? 8.5.15 is 3 years old. There were 4 bugfix releases since it. -- ___ Python tracker ___