[issue29044] Use after free in string '%c' formater

2016-12-21 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks Serhiy and Victor. The final commits applies the comments. :-) -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue29044] Use after free in string '%c' formater

2016-12-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset e572c323fe53 by Xiang Zhang in branch '3.5': Issue #29044: Fix a use-after-free in string '%c' formatter. https://hg.python.org/cpython/rev/e572c323fe53 New changeset cc61d1d45291 by Xiang Zhang in branch '3.6': Issue #29044: Merge 3.5.

[issue29045] Outdated C api doc about Windows error

2016-12-21 Thread Xiang Zhang
Xiang Zhang added the comment: > PyErr_SetFromWindowsErrWithFilenameObject was never implemented. See issue > 11210. > Since 3.3 WindowsError is simply an alias for OSError. See PEP 3151. Ohh, thanks for the info. I don't find the implementation in 2.7 either. -- versions: +Python

[issue29044] Use after free in string '%c' formater

2016-12-21 Thread STINNER Victor
STINNER Victor added the comment: I reviewed the change and added minor comments. The change LGTM. -- ___ Python tracker ___

[issue29045] Outdated C api doc about Windows error

2016-12-21 Thread Eryk Sun
Eryk Sun added the comment: PyErr_SetFromWindowsErrWithFilenameObject was never implemented. See issue 11210. Since 3.3 WindowsError is simply an alias for OSError. See PEP 3151. -- nosy: +eryksun ___ Python tracker

[issue29040] building Android with android-ndk-r14

2016-12-21 Thread Chi Hsuan Yen
Chi Hsuan Yen added the comment: Thanks for compiling up necessary changes for NDK r14! Seems that indicates future Python versions will require at least NDK r14 to build? Another headache from unified headers is that it requires different --sysroot in compilation and linking. Currently

[issue29045] Outdated C api doc about Windows error

2016-12-21 Thread Xiang Zhang
New submission from Xiang Zhang: https://docs.python.org/3.7/c-api/exceptions.html#c.PyErr_SetFromWindowsErrWithFilename it stills refers to PyErr_SetFromWindowsErrWithFilenameObject but this function doesn't exist since Py3.4. I didn't find when and why it's deleted. And

[issue29044] Use after free in string '%c' formater

2016-12-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. -- assignee: -> xiang.zhang nosy: +serhiy.storchaka stage: patch review -> commit review ___ Python tracker

[issue29044] Use after free in string '%c' formater

2016-12-21 Thread Xiang Zhang
New submission from Xiang Zhang: In string %c formater(formatchar), when receiving an integer-like objects, the return value is decrefed immediately before use. -- components: Interpreter Core files: use-after-free.patch keywords: patch messages: 283811 nosy: haypo, xiang.zhang

[issue28923] Nonexisting encoding specified in Tix.py

2016-12-21 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue28923] Nonexisting encoding specified in Tix.py

2016-12-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset eb8667196f93 by Terry Jan Reedy in branch '3.5': Issue 28923: Remove editor artifacts from Tix.py. https://hg.python.org/cpython/rev/eb8667196f93 New changeset 4a82412a3c51 by Terry Jan Reedy in branch '3.6': Issue 28923: Remove editor artifacts

[issue29043] dict view string representations are misleading

2016-12-21 Thread Raymond Hettinger
Raymond Hettinger added the comment: In this case, practicality beats purity. We want to repr to show the contents of the dictionary (that improves usability). The general rule that repr's need to round-trip is only a general rule and has many exceptions. As of course, in this case, it

[issue28923] Nonexisting encoding specified in Tix.py

2016-12-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset ef03aff3b195 by Terry Jan Reedy in branch '2.7': Issue 28923: Remove editor artifacts from Tix.py, https://hg.python.org/cpython/rev/ef03aff3b195 -- nosy: +python-dev ___ Python tracker

[issue29043] dict view string representations are misleading

2016-12-21 Thread Tadhg McDonald-Jensen
New submission from Tadhg McDonald-Jensen: Currently the string representation for dictionary views are a bit misleading as they look like valid expression but isn't: >>> {'a':1, 'b':2}.keys() dict_keys(['b', 'a']) >>> dict_keys = type({}.keys()) #get a reference to the type

[issue29042] os.path.exists should not throw "Embedded NUL character" exception

2016-12-21 Thread Dolda2000
New submission from Dolda2000: Currently, calling os.path.exists on a path which contains NUL characters behaves consistently with most file-system calls by throwing an exception: >>> os.path.exists('\0') Traceback (most recent call last): File "", line 1, in File

[issue29039] Segmentation fault when using PyUnicode_FromString

2016-12-21 Thread Xiang Zhang
Xiang Zhang added the comment: Just as Christoph said, you need to initialize first. -- nosy: +xiang.zhang resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker

[issue29038] Duplicate entry for SSLContext.get_ca_certs() in ssl

2016-12-21 Thread Xiang Zhang
Xiang Zhang added the comment: The codes in py2.7 looks same as in py3.4+, so make the doc same as in py3.4+. -- keywords: +patch nosy: +christian.heimes, xiang.zhang stage: -> patch review Added file: http://bugs.python.org/file45995/duplicate-doc-entry.patch

[issue29014] Python 3.5.2 installer doesn't register IDLE .py extensions on Windows 10

2016-12-21 Thread David
David added the comment: Thank you so much! This solved it. -- ___ Python tracker ___ ___ Python-bugs-list

[issue29014] Python 3.5.2 installer doesn't register IDLE .py extensions on Windows 10

2016-12-21 Thread Eryk Sun
Eryk Sun added the comment: openwithidle_for_frostyelsa.reg adds an open command for the current user that opens the target file in IDLE. This will take precedence over the per-machine open command that executes the file using the launcher. It also adds "Run" and "Run as administrator"

[issue29014] Python 3.5.2 installer doesn't register IDLE .py extensions on Windows 10

2016-12-21 Thread David
David added the comment: Before re-installing Windows 10, I was able to open up all my .py files by double-clicking on them and it would open them up in the IDLE (where I could edit the code manually and what have you). I'm not sure why it's never been a feature: I was doing that for many

[issue29014] Python 3.5.2 installer doesn't register IDLE .py extensions on Windows 10

2016-12-21 Thread Eryk Sun
Eryk Sun added the comment: > I want this to be a regular installation of Python wherein I can > associate .py files with IDLE That isn't a regular installation. It's not even an optional configuration, and never has been. You'd have to set that up manually. Are you looking to [-r]un files

[issue29014] Python 3.5.2 installer doesn't register IDLE .py extensions on Windows 10

2016-12-21 Thread Eryk Sun
Eryk Sun added the comment: > I did that, and now all the options are gone. Removing the broken HKLM entry shouldn't have removed all of the options. The "Edit with IDLE" menu should be there as long as Python.File is selected for the file association. It's defined for the current user on

[issue29014] Python 3.5.2 installer doesn't register IDLE .py extensions on Windows 10

2016-12-21 Thread David
David added the comment: Also, just to clarify, I want this to be a regular installation of Python wherein I can associate .py files with IDLE (i.e. when I double click on a .py file, it takes me straight to the code) *as well as* having the option to "Edit with IDLE" when right-clicking on a

[issue29014] Python 3.5.2 installer doesn't register IDLE .py extensions on Windows 10

2016-12-21 Thread David
David added the comment: Also, just to clarify, I want this to be a regular installation of Python wherein I can associate .py files with IDLE (i.e. when I double click on a .py file, it takes me straight to the code) *as well as* having the option to "Edit with IDLE" when right-clicking on a

[issue29014] Python 3.5.2 installer doesn't register IDLE .py extensions on Windows 10

2016-12-21 Thread David
David added the comment: I did that, and now all the options are gone. -- ___ Python tracker ___ ___

[issue29014] Python 3.5.2 installer doesn't register IDLE .py extensions on Windows 10

2016-12-21 Thread Eryk Sun
Eryk Sun added the comment: To remove the broken "Edit with IDLE" entry, open an elevated (administrator) command prompt and run the following: reg delete "HKLM\SOFTWARE\Classes\Python.File\shell\Edit with IDLE" /f -- ___ Python tracker

[issue29014] Python 3.5.2 installer doesn't register IDLE .py extensions on Windows 10

2016-12-21 Thread David
David added the comment: Following your instructions on key deletion, I have now 2 "Edit with IDLE" options now. The top one does *not* work. The second one, however, does work. But when I tried to associate the .py with idle (so it opens up in IDLE) it reverted back to the command-line run

[issue29014] Python 3.5.2 installer doesn't register IDLE .py extensions on Windows 10

2016-12-21 Thread David
David added the comment: Couple things to note: I was not able to delete a couple of the keys. Regardless I've made some progress which I will outline in the next comment. -- ___ Python tracker

[issue29031] 'from module import *' and __all__

2016-12-21 Thread Eryk Sun
Changes by Eryk Sun : -- nosy: +eryksun resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___

[issue29014] Python 3.5.2 installer doesn't register IDLE .py extensions on Windows 10

2016-12-21 Thread Eryk Sun
Eryk Sun added the comment: Let's do a bit of house cleaning. Run the following commands in a command prompt: reg delete HKCU\SOFTWARE\Classes\.py /f reg delete HKCU\SOFTWARE\Classes\py_auto_file /f reg delete HKCU\SOFTWARE\Classes\Applications\python.exe /f reg delete

[issue29041] Reference leaks on Windows

2016-12-21 Thread Zachary Ware
New submission from Zachary Ware: Discussion in #29034 inspired me to run a refleak check on Windows, with the following results from a 32-bit build of the current 3.6 branch: C:\cpython\3.6>PCbuild\build.bat -e -d C:\cpython\3.6>python -m test -uall -R 3:3:refleak_log.txt --timeout=7200 ...

[issue23903] Generate PC/python3.def by scraping headers

2016-12-21 Thread Steve Dower
Steve Dower added the comment: > would this change likely affect any third-party binaries already built for > 3.6.0? On the other hand, if we have to have one, it would be better to have > a compatibility break at 3.6.0 rather than at 3.6.1. Assuming we only make additive changes, then

[issue29014] Python 3.5.2 installer doesn't register IDLE .py extensions on Windows 10

2016-12-21 Thread David
David added the comment: Couple things: I installed PyCharm after all other options where exhausted. I needed to do some work on multiple projects. And also, I deleted .py key and it still doesn't show up. I tried associating it with idle.pyw and that didn't work either: Windows said it

[issue29014] Python 3.5.2 installer doesn't register IDLE .py extensions on Windows 10

2016-12-21 Thread Steve Dower
Steve Dower added the comment: It looks like PyCharm has taken over your shortcut: HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\FileExts\.py\UserChoice HashREG_SZ55jxudRhknE= ProgIdREG_SZPyCharm2016.3 If you delete the entire "FileExts\.py" key

[issue28762] lockf() is available now on Android API level 24, but the F_LOCK macro is not defined

2016-12-21 Thread STINNER Victor
STINNER Victor added the comment: The new patch now looks good to me. -- ___ Python tracker ___ ___

[issue29039] Segmentation fault when using PyUnicode_FromString

2016-12-21 Thread Christoph Reiter
Christoph Reiter added the comment: You're missing a call to Py_Initialize() [0] [0] https://docs.python.org/3/c-api/init.html#c.Py_Initialize -- nosy: +lazka ___ Python tracker

[issue29014] Python 3.5.2 installer doesn't register IDLE .py extensions on Windows 10

2016-12-21 Thread David
David added the comment: Thank you for your help. Attached is the py_config.txt that your .bat file gave me. -- Added file: http://bugs.python.org/file45991/py_config.txt ___ Python tracker

[issue28762] lockf() is available now on Android API level 24, but the F_LOCK macro is not defined

2016-12-21 Thread Xavier de Gaye
Xavier de Gaye added the comment: New patch. Please use autoreconf before running the patch (autoreconf instead of autoconf because the description of HAVE_LOCKF has been updated). -- title: configure links with lockf and F_LOCK is not declared in Android API 24 -> lockf() is

[issue29014] Python 3.5.2 installer doesn't register IDLE .py extensions on Windows 10

2016-12-21 Thread Eryk Sun
Changes by Eryk Sun : Added file: http://bugs.python.org/file45989/dump_py_config.bat ___ Python tracker ___

[issue29014] Python 3.5.2 installer doesn't register IDLE .py extensions on Windows 10

2016-12-21 Thread eryk sun
Changes by eryk sun : Removed file: http://bugs.python.org/file45988/dump_py_config.bat ___ Python tracker ___

[issue23903] Generate PC/python3.def by scraping headers

2016-12-21 Thread Ned Deily
Ned Deily added the comment: I don't know enough about how python3.dll is used in the Windows world to ask the right questions. One obvious one: would this change likely affect any third-party binaries already built for 3.6.0? On the other hand, if we have to have one, it would be better to

[issue29014] Python 3.5.2 installer doesn't register IDLE .py extensions on Windows 10

2016-12-21 Thread eryk sun
eryk sun added the comment: There are many possible points of failure, so I'd like to get a clearer picture of your system configuration. Please download and run the attached batch file "dump_py_config.bat" and upload the "py_config.txt" file that it creates. -- Added file:

[issue28695] Add SSL_CTX_set_client_cert_engine

2016-12-21 Thread Gennady Kovalev
Gennady Kovalev added the comment: Why not to call OPENSSL_config() to use openssl.cnf? --- ./Modules/_ssl.c.orig 2016-12-21 23:30:36.277184891 +0300 +++ ./Modules/_ssl.c2016-12-21 23:35:18.488508435 +0300 @@ -4514,6 +4514,8 @@ PySocketModule = *socket_api; /* Init OpenSSL

[issue28762] configure links with lockf and F_LOCK is not declared in Android API 24

2016-12-21 Thread Xavier de Gaye
Xavier de Gaye added the comment: Thanks for the review Victor. I have created issue 29040: building Android with android-ndk-r14. -- ___ Python tracker

[issue26865] Meta-issue: support of the android platform

2016-12-21 Thread Xavier de Gaye
Xavier de Gaye added the comment: issue #29040: building Android with android-ndk-r14 -- dependencies: +building Android with android-ndk-r14 ___ Python tracker

[issue29014] Python 3.5.2 installer doesn't register IDLE .py extensions on Windows 10

2016-12-21 Thread David
David added the comment: Yes, I have IDLE installed, and Launcher is installed as well. I can open up IDLE from the shortcut, however I am not able to access it within "Open With" or "Default Programs" or "Change" (within Properties). I _can_ open up the file only if I open up IDLE first then

[issue29040] building Android with android-ndk-r14

2016-12-21 Thread Xavier de Gaye
New submission from Xavier de Gaye: android-ndk-r14 introduces "Unified Headers" [1] and is planned to be released late january/early february 2017 [2]. __ANDROID_API__ is not anymore defined in 'android/api-level.h' that is currently included by Include/pyport.h, and is passed instead with

[issue28180] sys.getfilesystemencoding() should default to utf-8

2016-12-21 Thread Sworddragon
Changes by Sworddragon : -- nosy: +Sworddragon ___ Python tracker ___ ___

[issue29039] Segmentation fault when using PyUnicode_FromString

2016-12-21 Thread Matteo Cafasso
New submission from Matteo Cafasso: The following code snippet: -- #include #include int main() { char *broken_string[8]; char broken_char = 4294967252; sprintf(broken_string, "%c", broken_char);

[issue28538] _socket module cross-compilation error on android-24

2016-12-21 Thread Xavier de Gaye
Changes by Xavier de Gaye : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue24672] shutil.rmtree fails on non ascii filenames

2016-12-21 Thread Jason R. Coombs
Jason R. Coombs added the comment: In https://github.com/pypa/setuptools/issues/706, I've addressed this additional concern. -- resolution: -> wont fix status: open -> closed ___ Python tracker

[issue29038] Duplicate entry for SSLContext.get_ca_certs() in ssl

2016-12-21 Thread Daniel Bolgheroni
New submission from Daniel Bolgheroni: There is a duplicate entry for SSLContext.get_ca_certs() in ssl section 17.3.3. They are not equal, and the one that appears first has a more detailed description. -- assignee: docs@python components: Documentation messages: 283775 nosy:

[issue28992] Use bytes.fromhex()

2016-12-21 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue29035] regrtest: simplify regex to match test names for the --fromfile option

2016-12-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > --fromfile is written for developers who understand what they do, it's > just an helper. I don't understand the use case of it ;) , but when you need it, the patch LGTM. You can call just .group() instead of .group(0). --

[issue29037] Python 2.7.13 prints version header and exits immediately on Windows 10 x64

2016-12-21 Thread A.B., Khalid
New submission from A.B., Khalid: I updated my Python 2.7.12 to 2.7.13 on Windows 10 x64. When I run it in Windows command prompt shell, Python prints the version header and then exits immediately. Like so: """ E:\Users\thisuser>python Python 2.7.13 (v2.7.13:a06454b1afa1, Dec 17 2016,

[issue16058] ConfigParser no longer deepcopy compatible in 2.7

2016-12-21 Thread Łukasz Langa
Łukasz Langa added the comment: Solved in 3.2+ by making it compatible with the Mapping protocol. So while you can't do deepcopy(), you can `parser2.read_dict(parser1)`. -- dependencies: -Regex objects became uncopyable in 2.5 resolution: -> fixed

[issue23903] Generate PC/python3.def by scraping headers

2016-12-21 Thread Steve Dower
Steve Dower added the comment: Guess I should at least pose the question - Ned, would you consider the change in my patch for 3.6.0? Only the one file is affected, and it only contributes to one DLL that is (a) recommended, (b) not widely used and (c) very incompatible with the included

[issue29035] regrtest: simplify regex to match test names for the --fromfile option

2016-12-21 Thread STINNER Victor
STINNER Victor added the comment: Ah right, "Lib/ctypes/test/test_anon.py" doesn't work. I don't think that it's worth to support running directly such test. I don't think that it's worth it to modify the regex to exclude this case. --fromfile is written for developers who understand what they

[issue28538] _socket module cross-compilation error on android-24

2016-12-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset f34dac552ad8 by Xavier de Gaye in branch '3.6': Issue #28538: On Darwin net/if.h requires that sys/socket.h be included beforehand. https://hg.python.org/cpython/rev/f34dac552ad8 New changeset c568b6ac5e89 by Xavier de Gaye in branch 'default':

[issue28762] configure links with lockf and F_LOCK is not declared in Android API 24

2016-12-21 Thread STINNER Victor
STINNER Victor added the comment: Oh ok, the issue is more subtle than what I understood. I reviewed test_posix_flock.patch and proposed some changes to the comment/doc. -- ___ Python tracker

[issue28912] collections.abc.OrderedMapping

2016-12-21 Thread Joshua Bronson
Joshua Bronson added the comment: For the record, it looks like Victor Stinner suggested doing this in https://mail.python.org/pipermail/python-dev/2016-September/146349.html Brett Cannon replied in https://mail.python.org/pipermail/python-dev/2016-September/146350.html to suggest adding

[issue28538] _socket module cross-compilation error on android-24

2016-12-21 Thread Xavier de Gaye
Xavier de Gaye added the comment: These changes break the darwin platform, socket.if_nameindex() is not defined anymore. On Darwin, 'net/if.h' requires that 'sys/socket.h' be included beforehand (see the autoconf documentation). -- ___ Python

[issue29036] logging module: Add `full_module_name` to LogRecord details

2016-12-21 Thread Ram Rachum
New submission from Ram Rachum: LogRecord currently supplies `module` that you can show in your messages, but it's just the name of the module without the path. It'll be nice to have `full_module_name` that has the qualified name (e.g. foo.bar.baz instead of baz.) Usually it's the logger's

[issue28180] sys.getfilesystemencoding() should default to utf-8

2016-12-21 Thread Akira Li
Changes by Akira Li <4kir4...@gmail.com>: -- nosy: +akira ___ Python tracker ___ ___ Python-bugs-list mailing

[issue29031] 'from module import *' and __all__

2016-12-21 Thread Thomas Heller
Thomas Heller added the comment: Thanks Martin and eryk for correcting me and finding the real cause of the problem. Am 21.12.2016 um 13:04 schrieb eryk sun: > ... the private names _COORD, _FILETIME, _LARGE_INTEGER, > _POINTL, _RECTL, _SMALL_RECT, and _ULARGE_INTEGER are skipped by a > star

[issue29014] Python 3.5.2 installer doesn't register IDLE .py extensions on Windows 10

2016-12-21 Thread Steve Dower
Steve Dower added the comment: But you definitely have idle installed, right? The commands earlier made an assumption about your installation that could be wrong, so that would explain it. I'm still not entirely clear whether you've done these steps yet: 1. Right-click a .py file and select

[issue29035] regrtest: simplify regex to match test names for the --fromfile option

2016-12-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Reading file names from a file looks misleading. $ ls Lib/ctypes/test/*.py > list $ head list Lib/ctypes/test/__init__.py Lib/ctypes/test/__main__.py Lib/ctypes/test/test_anon.py Lib/ctypes/test/test_array_in_pointer.py Lib/ctypes/test/test_arrays.py

[issue29034] Fix memory leak in path_converter

2016-12-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There are many ways to write a solution of the original issue. You can just add a number of "Py_DECREF(bytes)" (path_converter.patch), or add new variable to_cleanup2 (path_converter-v2.patch), or reuse to_cleanup (path_converter-to_cleanup.patch), or clean

[issue29034] Fix memory leak in path_converter

2016-12-21 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file45986/path_converter-bytes.patch ___ Python tracker ___

[issue28762] configure links with lockf and F_LOCK is not declared in Android API 24

2016-12-21 Thread Xavier de Gaye
Xavier de Gaye added the comment: No, the patch prevents posix.flock() to be defined on Android API 24 with android-ndk-r13. But I plan to change it so that the test is skipped when posix does not have the F_LOCK attribute as this problem is not worth a change in the build machinery. It makes

[issue29034] Fix memory leak in path_converter

2016-12-21 Thread STINNER Victor
STINNER Victor added the comment: > The logic is complex ... Yeah, that's why I first proposed to add a dummy to_cleanup2 object. Another option is to use your first patch. I don't care much about the exact implementation :-) Maybe Serhiy has a better understanding of the code and can help to

[issue28762] configure links with lockf and F_LOCK is not declared in Android API 24

2016-12-21 Thread STINNER Victor
STINNER Victor added the comment: > The patch fixes the following error: Do you mean that the patch adds posix.F_LOCK constant on Android? -- nosy: +haypo ___ Python tracker

[issue29035] regrtest: simplify regex to match test names for the --fromfile option

2016-12-21 Thread STINNER Victor
STINNER Victor added the comment: FYI initially my idea was to use a very strict to avoid false positives. But when I used the feature, I found that the regex is more annoying than helping (ex: I had to modify the regex to accept filenames with directories). So I now prefer to use a very

[issue29035] regrtest: simplify regex to match test names for the --fromfile option

2016-12-21 Thread STINNER Victor
New submission from STINNER Victor: Lib/test/libregrtest/main.py uses a complex regex to find "test_builtin" in lines like '0:00:00 [ 4/400] test_builtin -- test_dict took 1 sec'. Recently, I changed (change d8222c197831) the regex to support a filename containing a list of filenames.

[issue29034] Fix memory leak in path_converter

2016-12-21 Thread Xiang Zhang
Xiang Zhang added the comment: Hmm, while considering Victor's comment, I find some new: path->object refers to the original object o, it owns a borrowed reference. But when received a PathLike object, o is assigned the return value of __fspath__ and decrefed at end. So path->object could

[issue28968] xml rpc server fails with connection reset by peer error no 104

2016-12-21 Thread R. David Murray
R. David Murray added the comment: The python-list mailing list subscription info can be found on the mail.python.org web page. It is also gatewayed to a usenet news group. -- ___ Python tracker

[issue28762] configure links with lockf and F_LOCK is not declared in Android API 24

2016-12-21 Thread Chi Hsuan Yen
Chi Hsuan Yen added the comment: FYI: Since Android NDK r14 beta1, F_LOCK is defined in unified headers. [1] In $ANDROID_NDK/sysroot/usr/include/bits/lockf.h: #define F_ULOCK 0 #define F_LOCK 1 #define F_TLOCK 2 #define F_TEST 3 [1]

[issue28992] Use bytes.fromhex()

2016-12-21 Thread STINNER Victor
STINNER Victor added the comment: Serhiy: "Oh how could I make such error?! Thanks Victor. It's simple: shit happens :-) Don't worry. -- ___ Python tracker

[issue28992] Use bytes.fromhex()

2016-12-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Oh how could I make such error?! Thanks Victor. -- ___ Python tracker ___

[issue28992] Use bytes.fromhex()

2016-12-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6ced540a92bc by Serhiy Storchaka in branch 'default': Fixed a type error introduced in issue #28992. https://hg.python.org/cpython/rev/6ced540a92bc -- ___ Python tracker

[issue29031] 'from module import *' and __all__

2016-12-21 Thread eryk sun
eryk sun added the comment: Python 3 does not skip names in __all__ that start with an underscore. wintypes in 2.x uses `from ctypes import *`, so it needs to define __all__. In 3.x it uses `import ctypes`, so it doesn't define __all__, and the private names _COORD, _FILETIME,

[issue28992] Use bytes.fromhex()

2016-12-21 Thread STINNER Victor
STINNER Victor added the comment: Unhappy buildbot: buildbot.python.org/all/builders/AMD64 Debian root 3.x/builds/103/steps/test/logs/stdio Example: == ERROR: test_complex_address_list

[issue29034] Fix memory leak in path_converter

2016-12-21 Thread STINNER Victor
STINNER Victor added the comment: > You could just reuse to_cleanup instead of to_cleanup2. Ah, it would be better to avoid a new variable, but this code is too complex for my head. I don't understand what is to_cleanup in this code path :-) -- ___

[issue28538] _socket module cross-compilation error on android-24

2016-12-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset e248bfb0f520 by Xavier de Gaye in branch '3.6': Issue #28538: Fix the compilation error that occurs because if_nameindex() is https://hg.python.org/cpython/rev/e248bfb0f520 New changeset 55bf0b79ec55 by Xavier de Gaye in branch 'default': Issue

[issue29025] random.seed() relation to hash() function and its determinism is vague

2016-12-21 Thread Jakub Mateusz Kowalski
Jakub Mateusz Kowalski added the comment: Python 2.7 I think note to the docs is enough. Python 3.5+ I have a doubt. Isn't .seed(a, version=1) still coupled with PYTHONHASHSEED? The manual says version 1 is "reproducing random sequences from older versions of Python", and for 3.1 (and

[issue29034] Fix memory leak in path_converter

2016-12-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: You could just reuse to_cleanup instead of to_cleanup2. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue29034] Fix memory leak in path_converter

2016-12-21 Thread Xiang Zhang
Xiang Zhang added the comment: v2 applies the comments. And another separate change is to change PyUnicode_AsWideCharString to PyUnicode_AsUnicodeAndSize. -- title: refleak in path_converter on error case -> Fix memory leak in path_converter Added file:

[issue28968] xml rpc server fails with connection reset by peer error no 104

2016-12-21 Thread Manish Singh
Manish Singh added the comment: Hi David, How can i port it to main python-dev list. Need to mail on it or some other group is there so that we can send the message to it. -- ___ Python tracker

[issue28992] Use bytes.fromhex()

2016-12-21 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue28992] Use bytes.fromhex()

2016-12-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 44c62456de75 by Serhiy Storchaka in branch 'default': Issue #28992: Use bytes.fromhex(). https://hg.python.org/cpython/rev/44c62456de75 -- nosy: +python-dev ___ Python tracker

[issue28871] Destructor of ElementTree.Element is recursive

2016-12-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 957091874ea0 by Serhiy Storchaka in branch '3.5': Issue #28871: Fixed a crash when deallocate deep ElementTree. https://hg.python.org/cpython/rev/957091874ea0 New changeset 78bf34b6a713 by Serhiy Storchaka in branch '2.7': Issue #28871: Fixed a

[issue28871] Destructor of ElementTree.Element is recursive

2016-12-21 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue29034] refleak in path_converter on error case

2016-12-21 Thread Xiang Zhang
Xiang Zhang added the comment: Ohh, I haven't read all related code so I didn't realize that's a leak. But if that is, there is still a wide = PyUnicode_AsWideCharString around the codes I altered. -- ___ Python tracker

[issue29034] refleak in path_converter on error case

2016-12-21 Thread STINNER Victor
STINNER Victor added the comment: Oh crap, memory leaks on Windows are rarely checked. I recall that I found a huge memory leak on Windows just before Python 3.6 beta 1 release: changeset: 103956:6232e610e310 branch: 3.6 parent: 103954:c1d9052996f1 user:Victor Stinner

[issue29034] refleak in path_converter on error case

2016-12-21 Thread Xiang Zhang
New submission from Xiang Zhang: It looks like the bytes variable should be Py_DECREFed on error cases as the patch shows. -- components: Library (Lib) files: path_converter.patch keywords: patch messages: 283736 nosy: haypo, steve.dower, xiang.zhang priority: normal severity: normal

[issue28512] PyErr_SyntaxLocationEx() and PyErr_SyntaxLocationObject() always set the offset attribute to None

2016-12-21 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue28988] Switch dict and set structures to PyVarObject

2016-12-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Since I don't see a benefit from this change I leave both patches to you Raymond. -- ___ Python tracker ___

[issue29031] 'from module import *' and __all__

2016-12-21 Thread Martin Panter
Martin Panter added the comment: Python 3 doesn’t have an __all__ list; it was removed in r85073 (Issue 3612). I don’t understand why it was removed. Maybe Hirokazu didn’t understand what it does. Since this is a regression, perhaps it should be added back. -- components: +Library

[issue28988] Switch dict and set structures to PyVarObject

2016-12-21 Thread STINNER Victor
STINNER Victor added the comment: Raymond Hettinger: > Please leave the set object patch for me. I would like to do it a bit > differently. Differently? How? -- ___ Python tracker

[issue28180] sys.getfilesystemencoding() should default to utf-8

2016-12-21 Thread STINNER Victor
STINNER Victor added the comment: Previous related work: changeset: 89836:bc06f67234d0 user:Victor Stinner date:Tue Mar 18 01:18:21 2014 +0100 files: Doc/whatsnew/3.5.rst Lib/test/test_sys.py Misc/NEWS Python/pythonru description: Issue #19977:

  1   2   >