[issue9163] test_gdb fails

Dave Malcolm dmalc...@redhat.com added the comment: Deciphering the output from the assertion, the stdout from gdb when running the test was: --- BEGIN --- Breakpoint 1, PyObject_Print (op=42, fp=0x401cf4e0, flags=1) at Objects/object.c:329 329 { #3 Frame 0x81e322c, for file /home/mike

[issue8605] test_gdb can fail with compiler opts

Dave Malcolm dmalc...@redhat.com added the comment: Thanks. The patch looks good to me, and appears to also fix issue 8482 and issue 9163: compiler optimization across all different compilers and configurations can somewhat arbitrarily break the ability for the debugger to work, and skipping

[issue9163] test_gdb fails

Dave Malcolm dmalc...@redhat.com added the comment: Thanks for the info. The final optimization option passed to gcc is the -O3, so the build was done with optimization. It's not going to be possible to determine if and when gdb will be able to work in an optimized build across all different

[issue9146] Segfault in hashlib in OpenSSL FIPS mode using non-FIPS-compliant hashes, if ssl imported before hashlib

New submission from Dave Malcolm dmalc...@redhat.com: Having run: prelink --undo --all the following works OK: OPENSSL_FORCE_FIPS_MODE=1 python -c import hashlib; m = m = hashlib.md5(); m.update('abc') but the following segfaults: OPENSSL_FORCE_FIPS_MODE=1 python -c import ssl; import

[issue9146] Segfault in hashlib in OpenSSL FIPS mode using non-FIPS-compliant hashes, if ssl imported before hashlib

Dave Malcolm dmalc...@redhat.com added the comment: Thanks First, is it only with 2.7 or 2.6? I've seen this with both 2.6 tarball builds and SVN trunk; in both cases against openssl-1.0.0-1.[ Second, I don't really get the point of the FIPS mode. The PDF you linked to seems full

[issue9146] Segfault in hashlib in OpenSSL FIPS mode using non-FIPS-compliant hashes, if ssl imported before hashlib

Dave Malcolm dmalc...@redhat.com added the comment: Attached patch checks for errors in the initialization of _hashlib, and only registers the names that are actually available. It also contains the ssl init from the first patch. I added a _hashlib._errors dict, containing errors, so that you

[issue9146] Segfault in hashlib in OpenSSL FIPS mode using non-FIPS-compliant hashes, if ssl imported before hashlib

Dave Malcolm dmalc...@redhat.com added the comment: Not quite ready yet: Named methods work: $ OPENSSL_FORCE_FIPS_MODE=1 ./python -c import hashlib; m = hashlib.md5(); m.update('abc\n'); print m.hexdigest()0bee89b07a248e27c83fc3d5951213c1 [15741 refs] but lookup by name still fails

[issue5673] Add timeout option to subprocess.Popen

Dave Malcolm dmalc...@redhat.com added the comment: The patch has bitrotted somewhat; I've had a go at reworking it so it applies against the latest version of trunk (r82429). All tests pass (or are skipped) on this x86_64 Linux box --with-pydebug (Fedora 13) There are still some TODOs

[issue9058] PyUnicodeDecodeError_Create asserts that various arguments are less than INT_MAX

New submission from Dave Malcolm dmalc...@redhat.com: Running this code (seen via http://bugs.python.org/file10013/python-2.5.2-unicode_resize-utf16.py for issue 2620): msg = 'A'*2147483647 ; msg.decode('utf16') leads to the python process exiting with an assertion failure: python: Objects

[issue9058] PyUnicodeDecodeError_Create asserts that various arguments are less than INT_MAX

Dave Malcolm dmalc...@redhat.com added the comment: Patch to remove the restriction that the fields be INT_MAX Tested on x86_64 on a machine with 12GB of RAM, leads to this exception, rather than the python process bailing out: Traceback (most recent call last): File stdin, line 1

[issue9058] PyUnicodeDecodeError_Create asserts that various arguments are less than INT_MAX

Dave Malcolm dmalc...@redhat.com added the comment: Actually, you should be able to just remove the asserts. Aha, thanks! Yes: #define PY_SSIZE_T_CLEAN is defined at the top of Objects/exceptions.c, so yes, Py_VaBuildValue is redirected to _Py_VaBuildValue_SizeT, so

[issue9054] pyexpat configured with --with-system-expat is incompatible with expat 2.0.1

New submission from Dave Malcolm dmalc...@redhat.com: pyexpat configured with --with-system-expat segfaults in one selftest when built against expat 2.0.1 SVN trunk: $ ./configure --with-system-expat (with expat-2.0.1) $ make $ ./python Lib/test/test_pyexpat.py [snip] test_parse_only_xml_data

[issue9054] pyexpat configured with --with-system-expat is incompatible with expat 2.0.1

Dave Malcolm dmalc...@redhat.com added the comment: With the attached patch all of Lib/test/test_pyexpat.py passes. -- keywords: +patch Added file: http://bugs.python.org/file17734/fix-issue-9054.patch ___ Python tracker rep...@bugs.python.org http

[issue9054] pyexpat configured with --with-system-expat is incompatible with expat 2.0.1

Changes by Dave Malcolm dmalc...@redhat.com: -- stage: - patch review type: - crash versions: +Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9054

[issue9054] pyexpat configured with --with-system-expat is incompatible with expat 2.0.1

Dave Malcolm dmalc...@redhat.com added the comment: For reference, I'm tracking this downstream here: https://bugzilla.redhat.com/show_bug.cgi?id=583931 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9054

[issue8892] 2to3 fails with assertion failure on from itertools import *

New submission from Dave Malcolm dmalc...@redhat.com: fix_itertools_imports.py fails on a * import 2to3 fails on this code: from itertools import * with a traceback: File /home/david/coding/python-svn/trunk-2to3-issues/Lib/lib2to3/tests/test_fixers.py, line 3680, in test_star

[issue8892] 2to3 fails with assertion failure on from itertools import *

Dave Malcolm dmalc...@redhat.com added the comment: I'm attaching a reproducer for the test suite (though not a fix) -- keywords: +patch Added file: http://bugs.python.org/file17540/itertools_import_star_reproducer.patch ___ Python tracker rep

[issue1621] Do not assume signed integer overflow behavior

Changes by Dave Malcolm dmalc...@redhat.com: -- nosy: +dmalcolm ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1621 ___ ___ Python-bugs-list

[issue5753] CVE-2008-5983 python: untrusted python modules search path

Dave Malcolm dmalc...@redhat.com added the comment: Attempting to summarize IRC discussion about this. PySys_SetArgv is used to set up sys.argv There is plenty of code which assumes that this is a list containing at least a zeroth string element; for example warnings.warn (see msg89688

[issue8600] test_gdb failures

Dave Malcolm dmalc...@redhat.com added the comment: Is the message about threads emitted every time you run python under gdb? Does gdb work? If so we should simply filter out the error message. I'm attaching a patch which strips out that error message from stderr (assuming that I reformatted

[issue8566] 2to3 should run under python 2.5

Changes by Dave Malcolm dmalc...@redhat.com: -- nosy: +dmalcolm ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8566 ___ ___ Python-bugs-list

[issue4835] SIZEOF_SOCKET_T not defined

Dave Malcolm dmalc...@redhat.com added the comment: I'm seeing this with gcc-4.4.3 with -Wall -Werror, leading to fatal errors trying to build an extension module against python 3.1 The references to SIZEOF_SOCKET_T within longobject.h appear to be just in the py3k branch, not trunk, and were

[issue4835] SIZEOF_SOCKET_T not defined

Dave Malcolm dmalc...@redhat.com added the comment: I'm seeing this with gcc-4.4.3 with -Wall -Werror, leading to fatal errors trying to build an extension module against python 3.1 Specifically, with gcc, I'm seeing this warning (trying to port SELinux Python support to Python3), which

[issue8482] test_gdb - (unable to read python frame information) mismatch

Dave Malcolm dmalc...@redhat.com added the comment: See https://bugzilla.redhat.com/show_bug.cgi?id=556975#c21 I'll try to summarize: as I understand things, the issue is that on 64-bit gcc builds with enough optimization, the argument PyFrameObject *f is passed as a register, and that gets

[issue8494] test_gdb assertEndsWith failing: Unable to read information on python frame

Dave Malcolm dmalc...@redhat.com added the comment: Thanks - yes, this does indeed look like a dup of issue 8482; resolving it as such. -- resolution: - duplicate status: open - closed superseder: - test_gdb - (unable to read python frame information) mismatch

[issue8479] test_gdb in Python3: No stack

Dave Malcolm dmalc...@redhat.com added the comment: Issue 8380 contains a port of the code and tests to python 3; it's awaiting review. -- superseder: - Port of the gdb7 debugging hooks to the py3k branch ___ Python tracker rep...@bugs.python.org

[issue8479] test_gdb in Python3: No stack

Changes by Dave Malcolm dmalc...@redhat.com: -- resolution: - duplicate status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8479

[issue8480] test_gdb: No frame is currently selected.

Dave Malcolm dmalc...@redhat.com added the comment: There was a patch for this attached to issue 8380, and you've fixed things in a different way. Should I regenerate a patch against what's now in SVN, or should we use my patch? -- assignee: dmalcolm - loewis

[issue8380] Port of the gdb7 debugging hooks to the py3k branch

Dave Malcolm dmalc...@redhat.com added the comment: Looking at issue 8480, it looks like this a partial fix was applied, which will mean this patch will no longer apply. Should I regenerate a patch against what's now in SVN, or should we use my patch

[issue8380] Port of the gdb7 debugging hooks to the py3k branch

Changes by Dave Malcolm dmalc...@redhat.com: -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8380 ___ ___ Python-bugs-list mailing

[issue8380] Port of the gdb7 debugging hooks to the py3k branch

Dave Malcolm dmalc...@redhat.com added the comment: Thanks; I'm working on a newer version of the patch based on what's in SVN. I prefer your choice of breakpoint, and I've changed my mind about the python2 vs python3 proxyval handling. Hope to have a fresh patch later today

[issue8380] Port of the gdb7 debugging hooks to the py3k branch

Dave Malcolm dmalc...@redhat.com added the comment: I'm attaching a new version of the patch, for the py3k branch. I changed my mind back about the breakpoint, using id and builtin_id as in my original patch. I prefer it since it has a single argument, which makes it very convenient to work

[issue8437] test_gdb: gdb.Frame has no attribute function

Dave Malcolm dmalc...@redhat.com added the comment: In msg103780 Martin v. Löwis wrote: Ah, ok. That was the problem indeed. The patch actually works fine. Good to hear. Thanks for tracking this down and clarifying it. As I understand it, the current status of this bug is that file17000 fixes

[issue8437] test_gdb: gdb.Frame has no attribute function

Dave Malcolm dmalc...@redhat.com added the comment: Fixed: r80289 (trunk), r80290 (py3k). I will check the buildbots :-) Please forgive my pedantry, but these appear to be off-by-one; the commits appear to have been: r80288 (trunk), r80289 (py3k

[issue8437] test_gdb: gdb.Frame has no attribute function

Dave Malcolm dmalc...@redhat.com added the comment: If I'm reading this bug correctly, there are two issues here: (A) that we shouldn't use gdb.Frame.function.name(), and should instead use gdb.Frame.name(). I believe this is a duplicate of issue 8279, and that this was fixed in trunk

[issue8437] test_gdb: gdb.Frame has no attribute function

Dave Malcolm dmalc...@redhat.com added the comment: Assigning to loewis for review -- assignee: dmalcolm - loewis stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8437

[issue8437] test_gdb: gdb.Frame has no attribute function

Dave Malcolm dmalc...@redhat.com added the comment: Attached patch is based on add-conditions-for-gdb.Frame.select-to- trunk.patch and fix described problems. Using test_gdb-2.patch, test_gdb pass without any error on my Debian Sid (gdb 7.1). The patch conditionalizes each test within

[issue8437] test_gdb: gdb.Frame has no attribute function

Dave Malcolm dmalc...@redhat.com added the comment: Sorry about that. Here's an updated version of the patch, combining my work with Victor's. -- Added file: http://bugs.python.org/file17000/add-conditions-for-gdb.Frame.select-to-trunk-003.patch

[issue7332] python script segment fault at PyMarshal_ReadLastObjectFromFile in import_submodule

Changes by Dave Malcolm dmalc...@redhat.com: -- nosy: +dmalcolm ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7332 ___ ___ Python-bugs-list

[issue8279] python-gdb PyListTests fail

Dave Malcolm dmalc...@redhat.com added the comment: New version of patch attached All tests continue to pass for me. I believe this will fix the py-list, py-locals, py-print commands and their respective tests on Ubuntu; I expect py-up/py-down to still fail due to missing gdb.Frame.select

[issue8380] Port of the gdb7 debugging hooks to the py3k branch

New submission from Dave Malcolm dmalc...@redhat.com: I'm attaching a patch for the py3k branch to port the gdb hooks to Python 3. The libpython.py code installed to python-gdb.py knows about the internal details of the Python within the tree. This patch makes the necessary changes

[issue8380] Port of the gdb7 debugging hooks to the py3k branch

Dave Malcolm dmalc...@redhat.com added the comment: Should we call it libpython3.py, in order to distinguish it from the 2.x version? We could; it gets copied to python-gdb.py by the Makefile though. The code is intended to track the low-level implementation details of the tree that its

[issue8330] Failures seen in test_gdb on buildbots

Changes by Dave Malcolm dmalc...@redhat.com: -- nosy: +loewis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8330 ___ ___ Python-bugs-list mailing

[issue8330] Failures seen in test_gdb on buildbots

Dave Malcolm dmalc...@redhat.com added the comment: There's also a deprecation warning in that log: /home/doko/buildarea/trunk.klose-debian-alpha/build/Lib/test/test_gdb.py:229: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6 if e.message != 'unichr() arg

[issue8337] test_gdb fails on Sparc Ubuntu

Dave Malcolm dmalc...@redhat.com added the comment: ( #8330 has a patch for a DeprecationWarning ) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8337

[issue8330] Failures seen in test_gdb on buildbots

Dave Malcolm dmalc...@redhat.com added the comment: Both of the failing tests use set inside gdb to try to corrupt the memory of the inferior process. I believe the issue here is that reading through 0xDEADBEEF within gdb on this machine isn't generating a RuntimeError; perhaps that _is_

[issue8337] test_gdb fails on Sparc Ubuntu

Dave Malcolm dmalc...@redhat.com added the comment: ( #8330 has a patch which may fix this ) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8337

[issue8330] Failures seen in test_gdb on buildbots

New submission from Dave Malcolm dmalc...@redhat.com: http://www.python.org/dev/buildbot/trunk/builders/alpha%20Debian%20trunk/builds/52/steps/test/logs/stdio shows some failures in test_gdb: == FAIL: test_corrupt_ob_type

[issue8316] test_gdb is susceptible to tty width settings

New submission from Dave Malcolm dmalc...@redhat.com: test_gdb's get_gdb_repr carves up a gdb backtrace to try to extract how gdb representated the data. When connected to a tty, gdb will insert additional newlines and spaces based on the width of the tty (internally it has a wrap_here

[issue8287] python-gdb.py triggers compile errors on FreeBSD and Solaris

Dave Malcolm dmalc...@redhat.com added the comment: I believe $(INSTALL_SCRIPT) was changed to $(INSTALL_DATA) in r79716 (see http://bugs.python.org/issue8032#msg102288 ) Attaching refreshed version of the patch. -- Added file: http://bugs.python.org/file16760/introduce-var-for-gdb

[issue8279] python-gdb PyListTests fail

Dave Malcolm dmalc...@redhat.com added the comment: It looks like all of the failures were due to gdb.Frame not having a function method. I did some digging, and it appears that this attribute may not yet be in the upstream version of gdb. The gdb/python integration was largely implemented

[issue8287] python-gdb.py triggers compile errors on FreeBSD and Solaris

Dave Malcolm dmalc...@redhat.com added the comment: Sorry about this. I believe this is the expansion of these fragments from the Makefile.pre.in (indenting for clarity): gdbhooks: $(BUILDPYTHON)-gdb.py $(BUILDPYTHON)-gdb.py: Tools/gdb/libpython.py $(INSTALL_SCRIPT

[issue8032] Add gdb7 hooks to make it easier to debug Python

Dave Malcolm dmalc...@redhat.com added the comment: A nitpick: on OS X, the gdb script ends up being called: python.exe-gdb.py Is this intentional? If it is, then I'll add this filename to the svn:ignore property. (And also to make distclean, I guess. Is python- gdb.py currently

[issue8279] python-gdb PyListTests fail

Dave Malcolm dmalc...@redhat.com added the comment: Thanks for reviewing the gdb work. I was mistakenly testing using: make ; ./python Lib/test/test_gdb.py which led to path assumptions in the code. I'm now testing with: make ; ./python Lib/test/regrtest.py -v test_gdb I'm attaching

[issue8279] python-gdb PyListTests fail

Changes by Dave Malcolm dmalc...@redhat.com: -- stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8279 ___ ___ Python-bugs-list

[issue8281] test_gdb_sample fails

Dave Malcolm dmalc...@redhat.com added the comment: Sorry about that. test_gdb_sample.py is merely a sample script for use by test_gdb.py (see issue 8032); it's not intended to do anything useful by itself (though it does need a print invocation, since test_gdb.py uses a breakpoint

[issue8281] test_gdb_sample fails

Dave Malcolm dmalc...@redhat.com added the comment: gdb_sample.py as a name works for me. I don't have commit rights to SVN so I can't perform the rename myself. (Note that due to issue 8279 the file isn't actually used at the moment by test_gdb.py so it should be safe to rename. I have

[issue8279] python-gdb PyListTests fail

Dave Malcolm dmalc...@redhat.com added the comment: I'm attaching a revised version of the patch; this is as before, but takes account of the rename of the sample file from test_gdb_sample.py to gdb_sample.py in r79557. -- Added file: http://bugs.python.org/file16727/fix

[issue8032] Add gdb7 hooks to make it easier to debug Python

Dave Malcolm dmalc...@redhat.com added the comment: I'm attaching a new version of the patch (v5), against svn trunk (r79517) I've been testing these hooks by using gdb attach to attach to real-world python programs. When doing this with earlier versions of the hooks, gdb would pause for many

[issue8032] Add gdb7 hooks to make it easier to debug Python

Dave Malcolm dmalc...@redhat.com added the comment: Adding diff from v4 to v5, for ease of review. For my reference, md5sum of v5's hooks: d3e039bb1279e71e847cc7ade10d3272 python-gdb.py -- Added file: http://bugs.python.org/file16716/diff-of-gdb7-hooks-v5-relative-to-v4.diff

[issue8032] Add gdb7 hooks to make it easier to debug Python

Dave Malcolm dmalc...@redhat.com added the comment: I'm attaching a new version of the patch (v4), against svn trunk (r79422) Changes since v3: * added support for PySetObject (set/frozenset) * added support for PyBaseExceptionObject (BaseException) * fixed a signed vs unsigned char issue

[issue8032] Add gdb7 hooks to make it easier to debug Python

Dave Malcolm dmalc...@redhat.com added the comment: (adding diff from v3 to v4, for ease of review) -- Added file: http://bugs.python.org/file16657/diff-of-gdb7-hooks-v4-relative-to-v3.diff ___ Python tracker rep...@bugs.python.org http

[issue8140] extend compileall to compile single files

Changes by Dave Malcolm dmalc...@redhat.com: -- nosy: +dmalcolm ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8140 ___ ___ Python-bugs-list

[issue7997] http://www.python.org/dev/faq/ doesn't seem to explain how to regenerate configure

Dave Malcolm dmalc...@redhat.com added the comment: Nitpick: Various occurrences of 2.6.1 in the above should probably be 2.61. Good catch - I think my brain or fingers are too used to Python's versioning scheme, rather than autoconf's. Here's a revised set of commands, hopefully fixing

[issue8119] Minor comment error in configure.in (malloc support appears twice)

New submission from Dave Malcolm dmalc...@redhat.com: A minor nit: configure.in has this comment twice: Check for Python-specific malloc support c.f.: # Check for Python-specific malloc support AC_MSG_CHECKING(for --with-tsc) (snip) # Check for Python-specific malloc support AC_MSG_CHECKING

[issue8032] Add gdb7 hooks to make it easier to debug Python

Dave Malcolm dmalc...@redhat.com added the comment: Thanks for reviewing the patch. I've changed the pretty-printing of NULL pointers to 0x0 as suggested, and I've updated frame printing. Frames are now printed like this (gdb) p f $1 = Frame 0x827e544, for file /home/david/coding/python-gdb

[issue8032] Add gdb7 hooks to make it easier to debug Python

Dave Malcolm dmalc...@redhat.com added the comment: Attaching diff from v2 to v3 -- Added file: http://bugs.python.org/file16526/diff-of-gdb7-hooks-v3-relative-to-v2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8032

[issue8101] w32-shared-ptr.c assertion on Windows 7 with 2.6.4

Dave Malcolm dmalc...@redhat.com added the comment: Perhaps this is an issue in a 3rd-party extension module? (Given that you're running Django, do you have a 3rd-party database connection module?; the last message in the log is Validating models, does that require Django to go to the db

[issue8032] Add gdb7 hooks to make it easier to debug Python

Dave Malcolm dmalc...@redhat.com added the comment: Martin: thanks for reviewing this. Re msg100537: sorry about the inauspicious start. I've added some bulletproofing for the case you discovered, and added two new unit tests. Re msg100538: OK. I've removed my name and the copyright notice

[issue8032] Add gdb7 hooks to make it easier to debug Python

Changes by Dave Malcolm dmalc...@redhat.com: Added file: http://bugs.python.org/file16497/diff-of-gdb7-hooks-v2-relative-to-v1.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8032

[issue8032] Add gdb7 hooks to make it easier to debug Python

Dave Malcolm dmalc...@redhat.com added the comment: (I faxed in my contributor agreement to the PSF on 2010-03-03) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8032

[issue8032] Add gdb7 hooks to make it easier to debug Python

New submission from Dave Malcolm dmalc...@redhat.com: gdb 7 can be extended with Python code, allowing the writing of domain-specific pretty-printers and commands. I've been working on gdb 7 hooks to make it easier to debug python itself, as mentioned here: https://fedoraproject.org/wiki

[issue8032] Add gdb7 hooks to make it easier to debug Python

Changes by Dave Malcolm dmalc...@redhat.com: -- keywords: +patch Added file: http://bugs.python.org/file16403/add-gdb7-python-hooks-to-trunk.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8032

[issue4111] Add Systemtap/DTrace probes

Dave Malcolm dmalc...@redhat.com added the comment: At Red Hat we've done some work on this feature. I'm sorry for not updating this issue, I was swamped with tasks both pre-PyCon and during the event; I did show the following to various folks at PyCon; I attempted to find Skip at PyCon

[issue4111] Add Systemtap/DTrace probes

Dave Malcolm dmalc...@redhat.com added the comment: Attached is the patch I'm currently applying in Fedora 13 to Python 3. The patch is actually against the 3.1.1 tarball, rather than SVN; sorry (swamped with post-pycon tasks here), as that's what I've been testing this work against

[issue7997] http://www.python.org/dev/faq/ doesn't seem to explain how to regenerate configure

New submission from Dave Malcolm dmalc...@redhat.com: http://www.python.org/dev/faq/ doesn't seem to explain how to regenerate configure Here's an attempt at answering that question; I hope the following is appropriate and factually correct: How to regenerate the configure script (e.g. to add

[issue7997] http://www.python.org/dev/faq/ doesn't seem to explain how to regenerate configure

Dave Malcolm dmalc...@redhat.com added the comment: Eric Smith: Isn't it true that after regenerating configure that you need to check it back in? Or is that so obvious to everyone except me that it's not worth mentioning? FWIW the above point wasn't obvious to me; if that's the case

[issue7861] 2to3: import foo - from . import foo

Changes by Dave Malcolm dmalc...@redhat.com: -- nosy: +dmalcolm ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7861 ___ ___ Python-bugs-list

[issue1475523] patch fixing #1448060 (gettext.py bug)

Changes by Dave Malcolm dmalc...@redhat.com: -- nosy: +dmalcolm ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1475523 ___ ___ Python-bugs-list

[issue5504] ctypes should work with systems where mmap can't be PROT_WRITE and PROT_EXEC

Changes by Dave Malcolm dmalc...@redhat.com: -- nosy: +dmalcolm ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5504 ___ ___ Python-bugs-list

[issue7737] Patch all tests to change assertTrue(a [not] in b [, c]) - assert[Not]In(a, b [, c])

New submission from Dave Malcolm dmalc...@redhat.com: In many places throughout the existing test suite, there are assertions of the form: self.assertTrue(chips in menu) and of the form: self.assertTrue(cheese not in shop) If these fail, the error message will merely tell you

[issue775964] fix test_grp failing on RedHat 6.2

Changes by Dave Malcolm dmalc...@redhat.com: -- nosy: +dmalcolm ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue775964 ___ ___ Python-bugs-list

[issue6690] BUILD_SET followed by COMPARE_OP (in) can be optimized if all items are consts

Dave Malcolm dmalc...@redhat.com added the comment: Thanks for the suggestions. Attached is a revised version of the patch. - I believe I've fixed all tab/space issues in this version of the patch, though I may have missed some (http://www.python.org/dev/tools/ doesn't recommend

[issue1634034] Show expected token on syntax error

Dave Malcolm dmalc...@redhat.com added the comment: I'm attaching a new version of the patch, based on Oliver's (from 3 years ago). This patch is against the py3k branch. I've introduced a new table of (const) strings: _PyParser_TokenDescs, giving descriptions of each token type, so that you

[issue4555] Smelly exports

Dave Malcolm dmalc...@redhat.com added the comment: Re: msg #77350: I propose to simply filter out init[_a-z]+ from the set of bad symbols. I'm attaching a patch (to trunk) to Makefile.pre.in which filters out such symbols. Relevant part of output of make smelly on my svn build

[issue6690] BUILD_SET followed by COMPARE_OP (in) can be optimized if all items are consts

Dave Malcolm dmalc...@redhat.com added the comment: Attaching a probably over-simplistic attempt at this patch, against the py3k branch. This patch attempts to extend the replacement of LOAD_CONST, , LOAD_CONST, BUILD_LIST, COMPARE_OP(in) with LOAD_CONST(tuple), COMPAREOP(in) so

[issue6690] BUILD_SET followed by COMPARE_OP (in) can be optimized if all items are consts

Dave Malcolm dmalc...@redhat.com added the comment: Alex: good point - thanks! Attaching updated version of the patch (again, against py3k, likewise, I'm somewhat new to this code, so I may have missed things) With this: dis.dis(lambda o: o in {1,2,3}) 1 0 LOAD_FAST

[issue6690] BUILD_SET followed by COMPARE_OP (in) can be optimized if all items are consts

Dave Malcolm dmalc...@redhat.com added the comment: Thanks for looking at the patch. Attached is an updated version (again against py3k) which adds tests to Lib/test/test_peepholer.py, for both the new folding away of BUILD_SET, and for the pre-existing folding of BUILD_LIST (which didn't

[issue7647] Add statvfs flags to the posix module

Changes by Dave Malcolm dmalc...@redhat.com: -- nosy: +dmalcolm ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7647 ___ ___ Python-bugs-list

[issue7543] RFE: introduce enum Py_Opcode

Dave Malcolm dmalc...@redhat.com added the comment: Are you doing anything specific which requires this change? No. I was looking for ways of making CPython easier to debug, and I experimented with this. It didn't help with debuggability as much as I hoped. Given that CPython's performance

[issue7543] RFE: introduce enum Py_Opcode

New submission from Dave Malcolm dmalc...@redhat.com: Currently, Python's opcodes are defined as preprocessor #defines. This means that they are invisible to the debugger. I'm attaching: (i) a simple script (fixup-opcode-header.py) which converts Include/opcode.h to use an anonymous enum

[issue7543] RFE: introduce enum Py_Opcode

Changes by Dave Malcolm dmalc...@redhat.com: Added file: http://bugs.python.org/file15598/fixup-opcode-header.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7543

[issue7543] RFE: introduce enum Py_Opcode

Changes by Dave Malcolm dmalc...@redhat.com: Added file: http://bugs.python.org/file15599/opcode.h ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7543

[issue7543] RFE: introduce enum Py_Opcode

Changes by Dave Malcolm dmalc...@redhat.com: -- keywords: +patch Added file: http://bugs.python.org/file15600/opcode.h.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7543

[issue7543] RFE: introduce enum Py_Opcode

Changes by Dave Malcolm dmalc...@redhat.com: Added file: http://bugs.python.org/file15601/use-opcode-enum.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7543

[issue7543] RFE: introduce enum Py_Opcode

Dave Malcolm dmalc...@redhat.com added the comment: Ooops, sorry; in an earlier version of this work, I was generating an enum of the form: enum { }; i.e. without an identifier (an anonymous enum) which I later changed to: enum Py_Opcode { }; Mea culpa; I forgot to update the text

[issue7543] RFE: introduce enum Py_Opcode

Changes by Dave Malcolm dmalc...@redhat.com: Added file: http://bugs.python.org/file15602/diff-in-generated-assembler-for-ceval.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7543

[issue1448060] gettext.py breaks on plural-forms header (PATCH)

Changes by Dave Malcolm dmalc...@redhat.com: -- nosy: +dmalcolm ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1448060 ___ ___ Python-bugs-list

[issue7425] [PATCH] Improve the robustness of pydoc -k in the face of broken modules

New submission from Dave Malcolm dmalc...@redhat.com: I see occasional failures where a broken module prevents pydoc -k (apropos) from working. Examples of failures (from our downstream bug tracker) are: https://bugzilla.redhat.com/show_bug.cgi?id=461419 : pydoc -k yields NameError: name

[issue1169193] Handle ungzipped man pages in rpm builds correctly

Changes by Dave Malcolm dmalc...@redhat.com: -- nosy: +dmalcolm ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1169193 ___ ___ Python-bugs-list

<    1   2   3   4   5   >