Eric Smith added the comment:
I haven't had time to look at this in detail, but the concept appears sound.
I'll try to devote some time to it, but hopefully someone else on
core-mentorship with more familiarity with this code will also be able to
review it.
One thing: You don
Eric Smith added the comment:
I agree with Georg, unfortunately.
And I say "unfortunately" because neither "logopt" nor "logoption" is a good
name. The "log" part adds nothing. The man page for syslog calls this "option",
which would be
Eric Smith added the comment:
I'll agree that the documentation could mention that. Reopening.
Patches accepted.
--
components: -2to3 (2.x to 3.0 conversion tool)
resolution: invalid ->
stage: committed/rejected ->
status: closed -> open
title: 2to3 example.py is no
Eric Smith added the comment:
Plus, it's recommended to move to 2.6 or 2.7 before trying to port to 3.x.
--
nosy: +eric.smith
___
Python tracker
<http://bugs.python.org/is
Changes by Eric Smith :
--
resolution: -> invalid
status: open -> closed
type: security ->
___
Python tracker
<http://bugs.python.org/issue11641>
___
Changes by Eric Smith :
--
nosy: +eric.smith
___
Python tracker
<http://bugs.python.org/issue7833>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Smith added the comment:
Yes, we recently switched to Mercurial. See
http://docs.python.org/devguide/faq.html
You shouldn't need to change your patches just because of the switch from svn.
--
___
Python tracker
<http://bugs.py
Eric Smith added the comment:
You're going to need to supply more information. What application? Can you post
the source code? What does "crashes" mean? Is it giving a Python traceback? If
so, please supply it.
Thanks.
--
no
Changes by Eric Smith :
--
nosy: +eric.smith
___
Python tracker
<http://bugs.python.org/issue11505>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Smith :
--
priority: release blocker -> deferred blocker
___
Python tracker
<http://bugs.python.org/issue9856>
___
___
Python-bugs-list mai
Eric Smith added the comment:
Next step is to make it a TypeError in 3.4.
--
priority: normal -> release blocker
title: Change object.__format__(s) where s is non-empty to a DeprecationWarning
-> Change object.__format__(s) where s is non-empty to a TypeError
versions: +Pyth
Eric Smith added the comment:
I removed the unused import (mostly as a simple test of mercurial, it's my
first commit there).
--
___
Python tracker
<http://bugs.python.org/i
Eric Smith added the comment:
So it is. I told you I hadn't done a proper review! I was mainly trying to say
I agree with lowercasing.
I'll shut up until I can read the whole patch.
--
___
Python tracker
<http://bugs.python.o
Eric Smith added the comment:
I'll give this a proper review in the next day or so (busy at PyCon).
Despite the fact that I typically hate changing values returned by the server,
I agree on case-folding the fact names to lowercase upon reading them. The RFC
clearly states they&#x
Eric Smith added the comment:
I agree that the callback isn't needed, and it reflects the older coding style
of much of the library (such as in retrlines). Instead, I'd make this a
generator, yielding each of the dicts. (Actually in some ideal rewrite of
ftplib, the whole callbac
Eric Smith added the comment:
I found part of the discussion I was looking for:
http://mail.python.org/pipermail/python-dev/2010-July/102252.html
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issu
Eric Smith added the comment:
There have been a number of discussions about this, but no concrete proposal.
The last one I recall was to add a __bformat__ method, but I couldn't find the
email trail just now.
See also issue 3982.
--
nosy: +eric.
Eric Smith added the comment:
I don't feel strongly one way or the other about it. I was just relaying the
reason I heard when I asked the question about why it's done the way it is.
I suggest mentioning that you're going to commit this change on python-dev,
since this seem
Changes by Eric Smith :
--
components: +Interpreter Core
nosy: +eric.smith, pitrou
___
Python tracker
<http://bugs.python.org/issue11382>
___
___
Python-bug
Eric Smith added the comment:
I appreciate that you're unconvinced of its usefulness, but you can be assured
that some of us do find it a useful and desirable behavior. And Python isn't
the only system that works this way, emacs does the same thing when you enter
filenames.
-
Eric Smith added the comment:
It would be redundant, so we don't need both. I don't recall any discussion
when PEP 3101 was developed as to choosing 'd' over 'i'. In all of the C code
I've seen use printf, I don't think I've ever seen 'i
Eric Smith added the comment:
[I doubt my terminology is exactly correct in this post, but I've tried my best
to make it so.)
The more I think about this the more I realize we can't implement a parser that
doesn't make guesses about '-' prefixed args and that works
Eric Smith added the comment:
Without guessing which args are options, I don't see how it's possible to
implement parse_known_args().
I'd propose raising an exception if it's called and
dont_assume_everything_that_looks_like_a_flag_is_intended_to_be_one (or
whatever it
Changes by Eric Smith :
--
nosy: +eric.smith
___
Python tracker
<http://bugs.python.org/issue11145>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Smith added the comment:
Steven: Yes, the current structure of the first pass scan makes any patch
problematic. It really would be an implementation of a different algorithm.
I'm still interested in looking at it, though.
--
___
P
Eric Smith added the comment:
Ah. I hadn't thought of generating them, only parsing them. In that case, then
yes, it's an issue for generation.
--
___
Python tracker
<http://bugs.python.o
Eric Smith added the comment:
I don't see the need for a parameter to support different sets of entities.
Just supporting the ones from HTML 5 seems like the right thing.
--
nosy: +eric.smith
___
Python tracker
<http://bugs.python.org/is
Eric Smith added the comment:
I'd also like to see this as the default. After all, presumably we'd like
Python scripts to work like all other command line programs, and I too am
unaware of any other option parsing library that works the way argparse does.
But changing released b
Eric Smith added the comment:
Good point, I hadn't thought of that. Maybe ArgumentParser needs a "don't try
to be so helpful, parse like optparse" option. Which is what Steven suggested
earlier, I believe.
I'd take a crack at this if there's general consensus on
Eric Smith added the comment:
"--" won't work. Traditionally, this has been used to separate optional
arguments from positional arguments. Continuing the "cd" example, that's what
would let you cd into a directory whose name starts with a hyphen:
$ cd -links-/
Eric Smith added the comment:
While I also dislike the existing behavior, note that you can get what you want
by using an equal sign.
>>> import argparse
>>> parser = argparse.ArgumentParser(prog='a2x')
>>> parser.add_argument('--asciidoc-opts
New submission from Eric Smith :
Many places open() is shown as a parameter to a csv method, but close() can't
be called. This is not a practice we should be advocating. Better would be to
show a 'with' statement, or at least a note explaining this isn't an ideal
usage.
Eric Smith added the comment:
"rpm -ba" is very old. I think it's been at least since 2002 that "-ba" was
supported by rpm.
I believe bdist_rpm is calling "rpmbuild -ba", and if that doesn't exist, then
"rpm -ba" is a transition str
Eric Smith added the comment:
Do you have a benchmark program you can post?
--
nosy: +eric.smith
___
Python tracker
<http://bugs.python.org/issue4>
___
___
Eric Smith added the comment:
1: subprocess.call is documented as taking a string, not bytes. If you think it
should also take bytes, I suggest opening a separate bug as a feature request.
2: You're running into both Python and the shell escaping. If you have an odd
number of backsl
Changes by Eric Smith :
--
nosy: +eric.smith
___
Python tracker
<http://bugs.python.org/issue11072>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Smith added the comment:
No further action required. I'm not going to remove format() and friends from
stringlib as long as there's chatter about adding a .format() for bytes.
--
resolution: -> accepted
stage: patch review -> committed/rejected
status
Eric Smith added the comment:
Actually this error doesn't exist on older versions because these used to be
methods on a string. The error was introduced in r85456 (issue 9418) when these
became functions in the _string module.
No need to backport.
--
resolution: -> accept
Eric Smith added the comment:
It looks like the canonical message is "expected X, got Y". With that change
I've checked it in in r88226. I'll backport.
--
assignee: haypo -> eric.smith
___
Python tracker
<http://
Eric Smith added the comment:
Release manager: You can decide if this fix should go in before 3.2. It's a
trivial fix to a crasher, but it's extremely unlikely anyone would trip over
it. It's been a crasher since 3.0.
It's also a crasher in 2.7, although there it's
Changes by Eric Smith :
--
type: -> crash
___
Python tracker
<http://bugs.python.org/issue11032>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Eric Smith :
--
nosy: +eric.smith
___
Python tracker
<http://bugs.python.org/issue11051>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Smith added the comment:
There is no suffix in python 3.x. Since this is a feature request, and there
will be no new releases of 2.x, I'm closing this.
--
nosy: +eric.smith
resolution: -> rejected
stage: -> committed/rejected
status: open -> closed
type: ->
Eric Smith added the comment:
The patch looks good to me. I've added some more tests to cover some corner
cases.
Go ahead and commit it.
--
Added file: http://bugs.python.org/file20572/_string0.patch
___
Python tracker
<http://bugs.py
Eric Smith added the comment:
I'll review this tomorrow.
--
nosy: +eric.smith
___
Python tracker
<http://bugs.python.org/issue11032>
___
___
Python-bugs-l
Changes by Eric Smith :
--
nosy: +eric.smith
title: Timer should be a class so that it can be derived -> threading.Timer
should be a class so that it can be derived
___
Python tracker
<http://bugs.python.org/issu
Eric Smith added the comment:
Or use a collections.defaultdict, which has a factory function as a constructor
argument. It sort of depends on what you're trying to do.
--
nosy: +eric.smith
___
Python tracker
<http://bugs.python.org/is
Eric Smith added the comment:
What do you mean by "is set to 610"? Can you show us the code that caused this
error?
--
nosy: +eric.smith
___
Python tracker
<http://bugs.python.o
Eric Smith added the comment:
This feature was added in 2.7 (and 3.1, I think). If the numeric indices are
not specified, they take the args in order.
--
assignee: d...@python -> eric.smith
nosy: +eric.smith
resolution: -> invalid
stage: -> committed/rejected
status: open
Eric Smith added the comment:
I think we're stuck with strftime for quite a while, no matter how ugly it is.
datetime.__format__ uses it, for example. Although maybe it's possible to write
an strftime-format to new-format translator.
If we're going to take this on (re-writi
Changes by Eric Smith :
--
nosy: +eric.smith
___
Python tracker
<http://bugs.python.org/issue3173>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Smith added the comment:
I always thought that one of the reasons for specifying the length was in case
a pointer pointed to garbage: at least you'd be limiting how much trash was
printed. But maybe that's just my imagination and there is no such reason.
--
nosy: +
Eric Smith added the comment:
Either use mode 'U' or the io module if you want to match 3.x.
$ python
Python 2.6.5 (r265:79063, Jun 12 2010, 17:07:01)
[GCC 4.3.4 20090804 (release) 1] on cygwin
Type "help", "copyright", "credits" or "lice
Eric Smith added the comment:
That change was just a tweak. The real change was in r86593. It references
issue 4925, of which this is a duplicate. I'm closing this, if you want to
follow the issue add yourself to 4925.
--
resolution: -> duplicate
stage: needs patch ->
Eric Smith added the comment:
This has already been fixed in 3.2:
Python 3.2b2 (py3k:87413, Dec 21 2010, 07:09:13)
[GCC 4.1.2 20070626 (Red Hat 4.1.2-13)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>
Changes by Eric Smith :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue10715>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Eric Smith :
--
title: uninformative error message -> Command name missing from exception in
subprocess.Popen
___
Python tracker
<http://bugs.python.org/issu
Eric Smith added the comment:
Here's a code snippet that shows the problem:
>>> import subprocess
>>> subprocess.Popen(['foo'])
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib/python2.5/subprocess.py", line 593
Eric Smith added the comment:
Because you're sending email as HTML, the message shows up both as plain text
and as an attachment. It's the attachments that are being removed. If you
could, please stop sending HTML email.
--
___
Pyth
Changes by Eric Smith :
Removed file: http://bugs.python.org/file20126/unnamed
___
Python tracker
<http://bugs.python.org/issue10715>
___
___
Python-bugs-list mailin
Eric Smith added the comment:
fwbackups is a third party package. See if you can submit a bug at
http://www.diffingo.com/oss/fwbackups
--
nosy: +eric.smith
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
_
Eric Smith added the comment:
Operating systems also return this errno for many, many things unrelated to
files. So while we might be able to fix this in some specific cases, in general
it's not possible to add file names to all errors.
Once we know your specific case we can see if
Changes by Eric Smith :
--
nosy: +eric.smith
___
Python tracker
<http://bugs.python.org/issue9232>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Smith added the comment:
Are the warnings originating in your code, or in the standard library, or
elsewhere?
If in the standard library, please provide specific details.
--
nosy: +eric.smith
___
Python tracker
<http://bugs.python.
Eric Smith added the comment:
This should be either:
'' % (self.text,)
or:
''.format(self.text)
If self.text is a tuple (which granted is its own error), then the version
checked in will raise an exception.
--
nosy: +eric.smith
resolution: fixed ->
Eric Smith added the comment:
I agree with David.
Here's an example of using such a subclass. It extends the format string for
strings to begin with an optional 'u' or 'l':
---
class U(str):
def __format__(self, fmt):
if fmt
Changes by Eric Smith :
Removed file: http://bugs.python.org/file19959/unnamed
___
Python tracker
<http://bugs.python.org/issue10516>
___
___
Python-bugs-list mailin
Eric Smith added the comment:
I disagree that your expected output is how it should behave. I believe it's
more likely that the user wants the entire field width specified. In addition,
compatibility with %-formatting would dictate that we keep the current behavior.
>>> &#x
Changes by Eric Smith :
Removed file: http://bugs.python.org/file19940/unnamed
___
Python tracker
<http://bugs.python.org/issue10621>
___
___
Python-bugs-list mailin
Eric Smith added the comment:
Checked-in in r87044.
--
resolution: -> accepted
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Eric Smith added the comment:
Modified all other tests to use support.requires_IEEE_754 in r87043.
--
resolution: -> accepted
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Eric Smith added the comment:
Technically the special handling in complex_repr() is for +0, but there needs
to be a test both ways.
--
___
Python tracker
<http://bugs.python.org/issue10
Eric Smith added the comment:
Moved from test_math.py into support.py in r87040. I'll fix up the other
modules shortly.
--
___
Python tracker
<http://bugs.python.org/is
New submission from Eric Smith :
There's a special test in the C code for this, but there no test for it in
test_complex. Note that this needs to be a IEEE 754 specific test.
--
assignee: eric.smith
components: Tests
keywords: easy
messages: 123348
nosy: eric.smith
priority: n
New submission from Eric Smith :
The decorator could be shared in at least datetimetester, test_cmath,
test_complex, test_decimal, test_fractions, test_long, and test_math.
--
assignee: eric.smith
components: Tests
keywords: easy
messages: 123346
nosy: eric.smith, mark.dickinson
Eric Smith added the comment:
There are no tests or docs to fix: it's an internal (static) helper function.
It's not a particularly straightforward change, because you're inserting a
space into the middle of the floating point imaginary string. There would be
extra bookkee
Eric Smith added the comment:
I agree. It would be nice, but the impact on existing code is too large. I can
easily imagine someone parsing the output of "print(somecomplexnumber)" and not
considering spaces.
For the record, it would require changing complex.__repr__ (which is als
Eric Smith added the comment:
According to comments in the code and verified by inspection,
PyOS_string_to_double does not accept any whitespace.
--
___
Python tracker
<http://bugs.python.org/issue10
Changes by Eric Smith :
--
components: +Extension Modules -Library (Lib)
keywords: +easy, patch
stage: -> unit test needed
___
Python tracker
<http://bugs.python.org/issu
Eric Smith added the comment:
Can you try this diff and see if it solves the problem:
Index: Modules/timemodule.c
===
--- Modules/timemodule.c(revision 86848)
+++ Modules/timemodule.c(working copy)
@@ -639,6 +639,7
Eric Smith added the comment:
What platform are you running this on? My Fedora 32 bit system won't support a
time_t that large.
--
___
Python tracker
<http://bugs.python.org/is
Eric Smith added the comment:
That should be strlen(), of course.
--
___
Python tracker
<http://bugs.python.org/issue10563>
___
___
Python-bugs-list mailin
Eric Smith added the comment:
There's an error in time_ctime where it expects the length of the string to be
fixed:
if (p[24] == '\n')
p[24] = '\0';
It doesn't count on the year having 5 digits. It should probably say (untested):
l = len(p);
Changes by Eric Smith :
--
nosy: +eric.smith
___
Python tracker
<http://bugs.python.org/issue10557>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Smith added the comment:
> The idea is that the first part refers to what the macro
> returns (Py_UCS4) and the "read" part of the name refers
> to moving a pointer across an array (any array of integers).
I thought the first part generally meant the type of
Eric Smith added the comment:
The compiler's decision to inline something should not be related to its
ability to put variables in a register.
But I definitely agree that we should get the abstraction right first and worry
about the implementation
Eric Smith added the comment:
The code will basically be:
Py_UCS4 fill;
parse_format_string(fmt, ..., &fill, ...);
/* lots more code */
if (fill_needed) {
/* compute how many characters to reserve */
space_needed = Py_UNICODE_NUM_NEEDED(
Eric Smith added the comment:
I'd need access to this without having to build a PyUnicodeObject, for
efficiency. But it sounds like it does have the basic functionality I need.
For my use I'd really need it to take the result of Py_UNICODE_NEXT. Something
like:
Eric Smith added the comment:
In addition to the proposed Py_UNICODE_NEXT and Py_UNICODE_PUT_NEXT,
str.__format__ would also need a function that tells it how many Py_UNICODEs
are needed to store a given Py_UCS4.
--
___
Python tracker
<h
Eric Smith added the comment:
I think these macros would be a reasonable approach. I think str.center, etc.
should support non-BMP chars, because to not do so can raise an exception.
Supporting composed graphemes seems like another problem altogether. And while
we could fix that, it&#
Eric Smith added the comment:
I'm not sure I understand. The output I get is:
f42e6be1-29bf-4f3c-ba58-1ae1d9ca5f88
g42e6be1-29bf-4f3c-ba58-1ae1d9ca5f88
False
The first string matches. The second string matches because the leading "g" is
being matched by "\w". The th
Eric Smith added the comment:
How about:
from collections import defaultdict
class defaultdict_value(defaultdict):
def __init__(self, value):
defaultdict.__init__(self, lambda : value)
x = defaultdict_value(3)
print(x[1
Eric Smith added the comment:
-1 from me. You can't use keywords, and if you make the value callable at a
later date then suddenly you'll change the behavior of seemingly unrelated
code. Is a lambda so bad?
--
nosy: +eric.smith
___
Pyth
Eric Smith added the comment:
The patch name has 2.7 in it, although "Versions" says 3.2. As this is a
feature request, it can't be added to 2.7.
--
nosy: +eric.smith
___
Python tracker
<http://bugs.pyt
Eric Smith added the comment:
Checked in r86751. I'm leaving this open until I fix the remaining issue with
'#g' for Decimal.
--
components: +Library (Lib)
___
Python tracker
<http://bugs.py
Changes by Eric Smith :
--
nosy: +eric.smith
___
Python tracker
<http://bugs.python.org/issue10528>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Smith added the comment:
str.__format__ and friends (int, float, complex) also have this same problem.
For example, when they're computing the "fill" character:
>>> format('', 'x^')
''
>>> format('', '\U00
Eric Smith added the comment:
Guido's email is archived at:
http://mail.python.org/pipermail/python-ideas/2010-November/008732.html
--
nosy: +eric.smith
___
Python tracker
<http://bugs.python.org/is
Changes by Eric Smith :
--
stage: unit test needed -> patch review
___
Python tracker
<http://bugs.python.org/issue7094>
___
___
Python-bugs-list mai
Eric Smith added the comment:
I agree that:
format(Decimal('1.23'), '#.6g')
should give '1.23000', just as:
format(1.23, '#.6g')
does.
I'll work on fixing the patch, although if I don't get to it in the next few
days I'll commit
1 - 100 of 805 matches
Mail list logo
