[issue40295] doctest handling of multiline strings is broken

2020-04-15 Thread Filip Rembiałkowski
Filip Rembiałkowski added the comment: Actually, the behavior does not depend on leading spaces, and test case can be isolated even further. Sample is attached [doctest-bugs-2.py]. -- Added file: https://bugs.python.org/file49066/doctest-bugs-2.py

[issue40295] doctest handling of multiline strings is broken

2020-04-15 Thread Filip Rembiałkowski
Filip Rembiałkowski added the comment: @Serhiy, Thank you for feedback. Yes the "testme" function (indeed trivial) works as expected - both in interactive Python interpreter and in script file. If you go to Lib/doctest.py, search for "string-identical" and debug my

[issue40295] doctest handling of multiline strings is broken

2020-04-15 Thread Filip Rembiałkowski
New submission from Filip Rembiałkowski : The doctest module does not compare multiline strings properly, as attached example proves. Tested on 2.7, 3.6 and 3.9.0a5+. (platform: Ubuntu 18.04). Related: https://stackoverflow.com/questions/60956015/unexpected-errors-while-testing-python3-code

[issue37305] Add MIME type for Web App Manifest

2019-06-18 Thread Filip Š
Change by Filip Š : -- keywords: +patch pull_requests: +14036 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14199 ___ Python tracker <https://bugs.python.org/issu

[issue37305] Add MIME type for Web App Manifest

2019-06-16 Thread Filip Š
New submission from Filip Š : Web App Manifest ( https://w3c.github.io/manifest/ ) is "JSON-based manifest file that provides developers with a centralized place to put metadata associated with a web application". Although it is not required, it is recommended by W3C ( https://w3c

[issue20906] Issues in Unicode HOWTO

2019-05-06 Thread Filip Bengtsson
Change by Filip Bengtsson : -- pull_requests: +13019 ___ Python tracker <https://bugs.python.org/issue20906> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35393] Typo in documentation

2018-12-03 Thread Filip Bengtsson
Filip Bengtsson added the comment: https://github.com/python/cpython/pull/10876/commits/00f39c15a13377f3920c72267b2b78a043d9b8ab -- ___ Python tracker <https://bugs.python.org/issue35

[issue35393] Typo in documentation

2018-12-03 Thread Filip Bengtsson
New submission from Filip Bengtsson : There are 256 characters in the range 0–255. -- assignee: docs@python components: Documentation messages: 330975 nosy: autom, docs@python priority: normal pull_requests: 10114 severity: normal status: open title: Typo in documentation

[issue33558] Python has no icon in taskbar and in start screen

2018-05-17 Thread Filip
New submission from Filip <knazko.fi...@gmail.com>: I've just downloaded the latest version of Python (3.6.5) from python.org. After installing, I launched it and I found out the app has no icon. Then I tried to download Python using different link, but it was the same as the firs

[issue33408] AF_UNIX is now supported in Windows

2018-05-02 Thread Filip *
New submission from Filip * <filip.stam...@hotmail.com>: Unix socket (AF_UNIX) is now avalible in Windows 10 (April 2018 Update). Please add Python support for it. More details about it on https://blogs.msdn.microsoft.com/commandline/2017/12/19/af_unix-comes-to-windows/ -- comp

[issue28154] Core dump after importing lxml in Python3.6b

2016-09-14 Thread Filip Stefanov
Filip Stefanov added the comment: My source was out of date... You are right now is working fine Sorry for the time wasted. :) -- resolution: -> out of date status: open -> closed ___ Python tracker <rep...@bugs.python.org> <http://

[issue28154] Core dump after importing lxml in Python3.6b

2016-09-14 Thread Filip Stefanov
New submission from Filip Stefanov: fstefanov@lin-0360: ~/bin/python/vm/python3.6b/bin $ python Python 3.6.0b1 (default, Sep 14 2016, 11:15:36) [GCC 4.8.4] on linux Type "help", "copyright", "credits" or "license" for more information. >>&g

[issue26077] Make slicing of immutable structures return a view instead of a copy

2016-01-10 Thread Filip Haglund
New submission from Filip Haglund: Slicing tuples returns a copy, which is O(n) time. This could be O(1) since tuples are immutable, by just pointing to the same data. This probably applies to other immutable structures as well, such as strings. -- components: Interpreter Core

[issue24663] ast.literal_eval does not handle empty set literals

2015-07-18 Thread Filip Haglund
Filip Haglund added the comment: Okey, then this is not a bug. I can just handle this special case myself. Thanks! -- status: pending - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24663

[issue20898] Missing 507 response description

2014-03-16 Thread Filip Malczak
Filip Malczak added the comment: If we're getting out of original scope, then I wonder... Maybe we should keep only standard status codes here? If not, which should we support, and which not? What about custom Spring 420 Method Failure? One way to clean up mess here is to create some

[issue20898] Missin 507 response description

2014-03-12 Thread Filip Malczak
New submission from Filip Malczak: I find it strange, that in http.client module we have variable: INSUFFICIENT_STORAGE = 507 yet in responses (dict mapping int codes to descriptions) 507 is missing. It's probably just mistake caused by short dev memory, fix is easy: add line: 507

[issue20898] Missing 507 response description

2014-03-12 Thread Filip Malczak
Changes by Filip Malczak filip.malc...@gmail.com: -- title: Missin 507 response description - Missing 507 response description ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20898

[issue19989] Error while sending function code over queue (multiprocessing)

2013-12-15 Thread Filip Malczak
New submission from Filip Malczak: Ive been using YAPSY to load plugins in one process. In this process I tried to put them in queue, and in another process I read them from queue. There was a problem with non-existing type of plugin in consumer process, so I tried to serialize plugin

[issue4037] doctest.py should include method descriptors when looking inside a class __dict__

2013-12-11 Thread Filip Zyzniewski
Filip Zyzniewski added the comment: It seems like there is also an issue with property classes defined in a different module. In the example below Foo.x uses standard property, and Foo.y uses prop imported from the prop module. This results in docstring for Foo.y to be missed: filip@klocek

[issue19162] datetime.datetime.min.strftime('%Y') not working

2013-10-04 Thread Filip Zyzniewski
New submission from Filip Zyzniewski: The datetime class provides a min datetime object which is not formattable: on Python 2: $ python Python 2.7.3 (default, Apr 10 2013, 05:13:16) [GCC 4.7.2] on linux2 Type help, copyright, credits or license for more information. import datetime

[issue16635] Interpreter not closing stdout/stderr on exit

2012-12-07 Thread Filip Zyzniewski
New submission from Filip Zyzniewski: When using a Python script as a unix pipe filter with its stdout redirected to a file: python script.py /nfs/foo user is not notified of some writing problems on NFS, because these are sometimes reported on close(), and the interpreter never does

[issue16635] Interpreter not closing stdout/stderr on exit

2012-12-07 Thread Filip Zyzniewski
Filip Zyzniewski added the comment: If stdout was closed before closing stderr, then stdout problems could be reported, and that is what I would expect when using Python this way. os.fsync(1) helps, but only if preceeded by sys.stdout.flush() and it seems a bit cumbersome. Is there any

[issue13896] Make shelf instances work with 'with' as context managers

2012-10-05 Thread Filip Gruszczyński
Filip Gruszczyński added the comment: Crap, it was so long ago, that I honestly don't remember why I added this if. It made sense back then. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13896

[issue11841] packaging.version: Bug when comparing versions with rc marker

2012-02-27 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: I prefer to be humble and trust core devs, when I post some patch to a codebase I don't know very well. I am glad you managed to reproduce it and I could help :-) -- ___ Python tracker rep

[issue8706] accept keyword arguments on all base type methods and builtins

2012-02-27 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Do you think I should put everything into a single patch or rather slowly add new patches with different methods or method groups? I would rather split it into several patches, I think it is easier to manage them, especially

[issue8706] accept keyword arguments on all base type methods and builtins

2012-02-27 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: I would stay away from methods that accept just a single argument. For those that accept more, I think it's reasonable to allow keyword args. -- ___ Python tracker rep...@bugs.python.org http

[issue8706] accept keyword arguments on all base type methods and builtins

2012-02-26 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: I don't know if this is exactly what you want, but this is an early patch. -- keywords: +patch nosy: +gruszczy Added file: http://bugs.python.org/file24644/8706.patch ___ Python tracker rep

[issue8706] accept keyword arguments on all base type methods and builtins

2012-02-26 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: With tests. -- Added file: http://bugs.python.org/file24650/8706_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8706

[issue13521] Make dict.setdefault() atomic

2012-02-26 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Fixed both issues. -- Added file: http://bugs.python.org/file24652/13521_27_4.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13521

[issue11807] Documentation of add_subparsers lacks information about parametres

2012-02-26 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Bump! I would like to remind about this issue and patch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11807

[issue13896] Make shelf instances work with 'with' as context managers

2012-02-04 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: closing was solving my problem, but I'll be happy on working on this patch, if you think it's useful after all. I don't think the stage should be test needed, since the patch has tests (I know the drill here

[issue13896] shelf doesn't work with 'with'

2012-01-29 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Oh, I haven't noticed that. Using contextlib.closing solves my problem. Thanks. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13896

[issue13896] shelf doesn't work with 'with'

2012-01-28 Thread Filip Gruszczyński
New submission from Filip Gruszczyński grusz...@gmail.com: It would be cool if use could use with to manage shelf object and forget about close. -- messages: 152159 nosy: gruszczy priority: normal severity: normal status: open title: shelf doesn't work

[issue13896] shelf doesn't work with 'with'

2012-01-28 Thread Filip Gruszczyński
Changes by Filip Gruszczyński grusz...@gmail.com: -- keywords: +patch Added file: http://bugs.python.org/file24347/13896.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13896

[issue13521] Make dict.setdefault() atomic

2012-01-15 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: No more double lookup. -- Added file: http://bugs.python.org/file24244/13521_27_3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13521

[issue11694] xdrlib raises ConversionError in inconsistent way

2012-01-15 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Bump! It's almost 3 months since I posted the patch, so I would like to remind about this bug. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11694

[issue13521] Make dict.setdefault() atomic

2012-01-08 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Bump! There was no activity here for two weeks. Is my patch for 2.7 ok or should I do something more about it? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13521

[issue13521] Make dict.setdefault() atomic

2012-01-08 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: I understand you are talking about this call: mp-ma_lookup(mp, key, hash); I haven't noticed that earlier. I'll try to provide a better fix (for 2.7 first, after we agree it's good enough, I will provide one for 3.3). Do you have any

[issue13521] Make dict.setdefault() atomic

2012-01-08 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Thanks, I'll try that. Like before I will probably find time next weekend. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13521

[issue13690] Add DEBUG flag to documentation of re.compile

2011-12-31 Thread Filip Gruszczyński
New submission from Filip Gruszczyński grusz...@gmail.com: This is a useful flag and it would be good, if it was in documentation. -- messages: 150423 nosy: gruszczy priority: normal severity: normal status: open title: Add DEBUG flag to documentation of re.compile

[issue13690] Add DEBUG flag to documentation of re.compile

2011-12-31 Thread Filip Gruszczyński
Changes by Filip Gruszczyński grusz...@gmail.com: -- keywords: +patch Added file: http://bugs.python.org/file24118/13690.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13690

[issue13521] Make dict.setdefault() atomic

2011-12-18 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Patch for 2.7. -- Added file: http://bugs.python.org/file24035/13521_27_1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13521

[issue11807] Documentation of add_subparsers lacks information about parametres

2011-12-18 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Fixed patch. -- Added file: http://bugs.python.org/file24042/11807_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11807

[issue13544] Add __qualname__ to functools.WRAPPER_ASSIGNMENTS

2011-12-12 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Pleasure :-) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13544 ___ ___ Python-bugs

[issue13521] Make dict.setdefault() atomic

2011-12-12 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: I haven't given it much thought, when I was making the choice of using nonlocal rather than self.count. I was rather excited to see, if the change will work as I wanted it to. If you believe it would be better to use an attribute, I'll

[issue13521] Make dict.setdefault() atomic

2011-12-12 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: I'll send a patch, when I get home from work. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13521

[issue13521] Make dict.setdefault() atomic

2011-12-12 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: I have tried to port patch to python2.7, but apparently I must be doing something wrong, because while most tests pass, several fail (including tests for unittest itself). I would like to continue working on this test, but incoming week

[issue13544] Add __qualname__ to functools.WRAPPER_ASSIGNMENTS

2011-12-11 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: I didn't know about `make patchcheck`, next time I will use it, thanks. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13544

[issue13544] Add __qualname__ to functools.WRAPPER_ASSIGNMENTS

2011-12-11 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Fixed tests. -- Added file: http://bugs.python.org/file23912/13544_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13544

[issue13521] Make dict.setdefault() atomic

2011-12-11 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: I have written a patch and a test, but since it's changing C code, I am far from being sure if it's achieve the expected behavior in the right way. There are also tests and running whole test suite didn't bring any errors

[issue13521] Make dict.setdefault() atomic

2011-12-11 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Also: I'll be happy to work further on this patch, if I get some comments and advice. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13521

[issue13521] Make dict.setdefault() atomic

2011-12-11 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Done. -- Added file: http://bugs.python.org/file23918/13521_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13521

[issue13544] Add __qualname__ to functools.WRAPPER_ASSIGNMENTS

2011-12-10 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Patch with tests. -- keywords: +patch nosy: +gruszczy Added file: http://bugs.python.org/file23906/13544.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13544

[issue13568] sqlite3 convert_date error with DATE type

2011-12-10 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: c.execute(insert into testdate values ('now')) This works, but you actually are putting string now into a field with DATE type. When conversion occurs after retrieving data, there is an error. Also if you use datetime() function

[issue11694] xdrlib raises ConversionError in inconsistent way

2011-09-17 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Patch with tests. -- keywords: +patch Added file: http://bugs.python.org/file23178/11694.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11694

[issue11767] Maildir iterator leaks file descriptors by default

2011-06-17 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Should I try to do something about this right now or should I wait until #1170 is finishedclosed and only then try to fix this issue too? -- ___ Python tracker rep...@bugs.python.org http

[issue6584] gzip module has no custom exception

2011-06-17 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Bump! Antoine, do you think the patch is acceptable and can be committed now? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6584

[issue12354] packaging.pypi.simple docs use both client and crawler variable, which might be confusing

2011-06-17 Thread Filip Gruszczyński
New submission from Filip Gruszczyński grusz...@gmail.com: In documentation for packaging.pypi.simple in first code snippet crawler variable is created on which further operations will be performed. However in all next snippets there is client variable, which is a little confusing on first

[issue12354] packaging.pypi.simple docs use both client and crawler variable, which might be confusing

2011-06-17 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: And a small, quick patch to docs. -- keywords: +patch Added file: http://bugs.python.org/file22396/12354.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12354

[issue12348] case sensitivity in packaging.pypi.simple.Crawler

2011-06-17 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: When I started looking at this I noticed following behaviour: from packaging.pypi.simple import Crawler client = Crawler() client.get_releases('webob') Traceback (most recent call last): File stdin, line 1, in module File /home

[issue12355] Crawler doesn't follow redirection

2011-06-17 Thread Filip Gruszczyński
New submission from Filip Gruszczyński grusz...@gmail.com: When looking at issue #12348 I have noticed following behaviour: from packaging.pypi.simple import Crawler c = Crawler() c.get_releases('webob') Traceback (most recent call last): File test_crawl.py, line 3, in module

[issue12355] Crawler doesn't follow redirection

2011-06-17 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: OK, I'll try to come up with some patch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12355

[issue12318] list + tuple inconsistency

2011-06-11 Thread Filip Gruszczyński
New submission from Filip Gruszczyński grusz...@gmail.com: You can do this: [1] + (1,) Traceback (most recent call last): File stdin, line 1, in module TypeError: can only concatenate list (not tuple) to list But you can do this: result = [1] result += (1,) result [1, 1

[issue12318] list + tuple inconsistency

2011-06-11 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Obviously first sentence should be You can't do this:. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12318

[issue8933] Invalid detection of metadata version

2011-04-19 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Bump! How about commiting this patch, Eric? -- status: pending - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8933

[issue11881] Add list.get

2011-04-19 Thread Filip Gruszczyński
New submission from Filip Gruszczyński grusz...@gmail.com: I have proposed on Core Mentorship list to add get(index, default) method to list object. I was suggested to bring it up here and also told, that improving operator module could be a better solution. This is why I would like to ask

[issue11881] Add list.get

2011-04-19 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Nick Coghlan suggested, that operator.getitem could be extended to accept default value. How does it sound to you? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue11841] Bug in the verson comparison

2011-04-15 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: The reason for the use of two constants is that previously there was comparison in the code with a hardcoded 'f': if postdev[0] == 'f': I think it's a common practice to create constants for such hardcoded values. Also

[issue11841] Bug in the verson comparison

2011-04-15 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: I understand that ML is mailing list, but I have no idea what is fellowship mailing list. Could you elaborate on this? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue9544] xdrlib.Packer().pack_fstring throws a TypeError when called with a str()

2011-04-14 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Actually documentation doesn't say that it supports only bytes, but: The following methods support packing strings, bytes, and opaque data: Also under python2 you can easily do this: In [1]: import xdrlib In [2]: p = xdrlib.Packer

[issue9544] xdrlib.Packer().pack_fstring throws a TypeError when called with a str()

2011-04-14 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: I am well aware of this, Benjamin. I am not trying to force any solution, but rather trying to point out, that current documentation is misleading. There might be no need for patching the code, but rather updating the docs to say

[issue9544] xdrlib.Packer().pack_fstring throws a TypeError when called with a str()

2011-04-14 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: I'll provide docs patch. -- assignee: - docs@python components: +Documentation -None nosy: +docs@python ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9544

[issue11841] Bug in the verson comparison

2011-04-13 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Here is a patch that I made against distutils2 tip. I have changed _FINAL_MARKER from 'f' to 'z', which works with rc. Also I have added constant _FINAL_MARKER_CHAR, since later in the code you make a check against 'f' and it surprised

[issue11807] Documentation of add_subparsers lacks information about parametres

2011-04-10 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Here is a patch for this. I am not much of technical writer, so please be patient with me. I tried to provide all the information about parameters, that can be inferred from the code and experimenting. I have left out one parameter

[issue11807] Documentation of add_subparsers lacks information about parametres

2011-04-09 Thread Filip Gruszczyński
New submission from Filip Gruszczyński grusz...@gmail.com: In argparse documentation parametres of add_subparsers are not listed. And yet there are some really useful parametres like parser_class. It would be useful, it they were described there well and one wouldn't have to look into the code

[issue11807] Documentation of add_subparsers lacks information about parametres

2011-04-09 Thread Filip Gruszczyński
Changes by Filip Gruszczyński grusz...@gmail.com: -- nosy: +bethard ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11807 ___ ___ Python-bugs-list

[issue6931] dreadful performance in difflib: ndiff and HtmlDiff

2011-04-08 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: I have no idea how I should do this. If you explain to me, how it should be done, I'll be happy to do this from now on :-) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue6931] dreadful performance in difflib: ndiff and HtmlDiff

2011-04-08 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Here it is. -- keywords: +patch Added file: http://bugs.python.org/file21588/11740.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6931

[issue11767] Maildir iterator leaks file descriptors by default

2011-04-07 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Here is a new patch, that uses with in __getitem__. I wonder, if we shouldn't check for an AttributeError in case object returned by get_file doesn't have __exit__ method, but does have close and use close instead of with. But it's

[issue11767] Maildir iterator leaks file descriptors by default

2011-04-07 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: I am sorry. This is the first time I see contextlib and haven't understood, that I should use a function from it. Here is a version with mock object having close method and __getitem__ using contextlib.closing. -- Added file

[issue11767] Maildir iterator leaks file descriptors by default

2011-04-06 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Shouldn't this be your responsibility to close this descriptor in the object used as self._factory? When self._factory is called it should read from the file like object and then simply close it, just as get_message (when self._factory

[issue11707] Create C version of functools.cmp_to_key()

2011-04-05 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: I have a follow-up question: why keyobject_type needed traverse function? From what I read in docs I assumed it is required for GC tracked types. Why was it required here and how it is used

[issue11707] Create C version of functools.cmp_to_key()

2011-04-05 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: I see. Thanks :-) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11707 ___ ___ Python

[issue11707] Create C version of functools.cmp_to_key()

2011-04-04 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Here are some example performance results: def cmp(x, y): return y - x sorted(range(1, 1000), key=cmp_to_key(cmp)) ''' C version: real0m19.994s user0m8.053s sys 0m1.044s Python version: real0m28.825s user

[issue11707] Create C version of functools.cmp_to_key()

2011-04-03 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: I worked a little on the tests. Only then I have noticed, that cmp_to_key tests weren't run, so I have encountered some problems, when I finally turned them on. I have added some of my tests, fixed some things in the patch and now

[issue11740] difflib html diff takes extremely long

2011-04-02 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: The culprit seems to be Differ._fancy_replace. There is a nasty quadratic loop there, that has pretty complex internal code. I have done a quick a fix, that makes example run below a second at the expense of not calling _fancy_replace

[issue8905] difflib should accept arbitrary line iterators

2011-04-02 Thread Filip Gruszczyński
Changes by Filip Gruszczyński grusz...@gmail.com: -- nosy: +gruszczy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8905 ___ ___ Python-bugs-list

[issue6931] dreadful performance in difflib: ndiff and HtmlDiff

2011-04-02 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Check also this: http://bugs.python.org/issue11740 -- nosy: +gruszczy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6931

[issue11707] Create C version of functools.cmp_to_key()

2011-04-02 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Here is a patch that passes functools tests. I'll be happy to work on it further. -- keywords: +patch Added file: http://bugs.python.org/file21504/11707.patch ___ Python tracker rep

[issue11707] Create C version of functools.cmp_to_key()

2011-04-02 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Ok, here is patch that keep python implementation of cmp_to_key if C version can't be imported. Thanks again for you help :-) -- Added file: http://bugs.python.org/file21505/11707_2.patch

[issue10791] Wrapping TextIOWrapper around gzip files

2011-04-01 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Is following change in GzipFile class enough: def read1(self, n): return self.read(n) ? This satisfies TextIOWrapper to run readline correctly. -- nosy: +gruszczy ___ Python

[issue11740] difflib html diff takes extremely long

2011-04-01 Thread Filip Gruszczyński
Changes by Filip Gruszczyński grusz...@gmail.com: -- nosy: +gruszczy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11740 ___ ___ Python-bugs-list

[issue11707] Create C version of functools.cmp_to_key()

2011-03-29 Thread Filip Gruszczyński
Changes by Filip Gruszczyński grusz...@gmail.com: -- nosy: +gruszczy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11707 ___ ___ Python-bugs-list

[issue9544] xdrlib.Packer().pack_fstring throws a TypeError when called with a str()

2011-03-28 Thread Filip Gruszczyński
Changes by Filip Gruszczyński grusz...@gmail.com: -- nosy: +mark.dickinson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9544 ___ ___ Python-bugs

[issue9696] xdrlib's pack_int generates DeprecationWarnings for negative in-range values

2011-03-27 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Here is a test and a patch. -- keywords: +patch nosy: +gruszczy Added file: http://bugs.python.org/file21426/9696.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue9544] xdrlib.Packer().pack_fstring throws a TypeError when called with a str()

2011-03-27 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Here is a simple patch with a test. Depending o bytes in this library seems strange, maybe it should be changed somehow? Anyway, this simple patch should be a quick fix to the problem. -- keywords: +patch nosy: +gruszczy Added

[issue11694] xdrlib raises ConversionError in inconsistent way

2011-03-27 Thread Filip Gruszczyński
New submission from Filip Gruszczyński grusz...@gmail.com: xdrlib defines ConversionError, but very seldom uses it. For example: def pack_float(self, x): try: self.__buf.write(struct.pack('f', x)) except struct.error as msg: raise ConversionError(msg

[issue9696] xdrlib's pack_int generates DeprecationWarnings for negative in-range values

2011-03-27 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: I believe this should be applied also against 3.3. I was working on this using 3.3 code base, so it is not working there too. -- ___ Python tracker rep...@bugs.python.org http

[issue9696] xdrlib's pack_int generates DeprecationWarnings for negative in-range values

2011-03-27 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: I'm sorry, I wasn't hurrying you. Just wanted to make sure you know. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9696

[issue11174] add argparse formatting option to display type names for metavar

2011-03-26 Thread Filip Gruszczyński
Filip Gruszczyński grusz...@gmail.com added the comment: Well, since you are the designer of the package, I believe you have better knowledge on how to extend it :-). I just provided a patch according to what you described in the first message. Anyway having separate help formatter seems

  1   2   >