Lita Cho added the comment:
Feel free.
On Tue, Jun 26, 2018, 3:21 AM RAJALAKSHMI V wrote:
>
> RAJALAKSHMI V added the comment:
>
> Hey, I am a new contributor here. Could I take this issue up?
>
> --
> nosy: +RAJALAKSHMI V
>
> _
Lita Cho added the comment:
Sounds good.
On Tuesday, December 22, 2015, Maciej Szulik <rep...@bugs.python.org> wrote:
>
> Maciej Szulik added the comment:
>
> Lita can you please apply the changes from latest review (from
> SilentGhost). Especially the one regarding new
Lita Cho added the comment:
Here is a patch after SlientGhost's review. I have added back the newline and
included the comments for the imaplib documentation.
--
Added file:
http://bugs.python.org/file41395/imaplib_after_silentghost_review.patch
Lita Cho added the comment:
Applied the changes that berkerpeksag made. Please review, and let me know if
further changes need to be made.
--
Added file: http://bugs.python.org/file41366/imaplib_after_review.patch
___
Python tracker <
Lita Cho added the comment:
Had some trouble setting up my dev environment for Python. Definitely going
to work on it today and tomorrow.
On Tue, Dec 8, 2015 at 12:33 PM, Maciej Szulik <rep...@bugs.python.org>
wrote:
>
> Maciej Szulik added the comment:
>
&g
Lita Cho added the comment:
I apologize, I completely forgot. I will do it this week. Thanks for the
reminder!
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Lita Cho added the comment:
Hi Maciej,
I am not seeing berkerpeksag review...? What was his comment? I apologize, but
I haven't used the bug tracker in awhile.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21815
Lita Cho added the comment:
Here is the patch merged together. I apologize for not getting it to you sooner.
--
Added file: http://bugs.python.org/file37245/imaplib_bracket_fix.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Lita Cho added the comment:
Sure, let me combine it into one change.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21815
___
___
Python-bugs
Lita Cho added the comment:
Hi Terry,
I had no idea we were moving away from using test_main.
So instead, of using support.run_unittest, we should import all the unittest
from tkinter/test/ and wrap everything with that exec method, setting
wantobjects=1 and again with wantobjects=0?
Also
Lita Cho added the comment:
Thank yo so much, Martin! I will incorporate these changes and add them soon!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1186900
Lita Cho added the comment:
pinging for another review. I have included tests for the patch as well as
documentation!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21815
Lita Cho added the comment:
ping!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21933
___
___
Python-bugs-list mailing list
Unsubscribe:
https
Lita Cho added the comment:
Hi Serhiy,
This patch was made while I was learning tkinter. I figured out how to run the
tests twice while changing wantobjects variable without creating new tests.
Fortunately, all the tests seem to fast when wantobjects is 0 or 1.
The only annoying thing
Lita Cho added the comment:
I'ved changed the comment to say Connection closed unexpectedly.
--
Added file: http://bugs.python.org/file36264/nntplib_error_v2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1186900
Lita Cho added the comment:
Hi David, I can take this on as I am learning the email api currently.
--
nosy: +Lita.Cho
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21991
Changes by Lita Cho lita@gmail.com:
--
nosy: +jesstess
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21991
___
___
Python-bugs-list mailing
Lita Cho added the comment:
Hey! So I have been investigating this bug, but I wanted to know is the issue
the fact that korka wants to create multiple turtles or do you really want to
use multiple threads with Turtle? I feel like this crash is due to Tkinter not
being thread safe and I am
Lita Cho added the comment:
I also want to note that you can create duplicate turtles by using clone, and I
am not sure why you would use multiple inheritance to draw more than 1 turtle
running around. I didn't think turtle was meant to be used this way. In order
to draw multiple turtles, I
Lita Cho added the comment:
I can make it worth such that it doesn't raise a Terminator error. This works
great when working with Turtle on the command line. I basically check if the
root exists for all Tk canvas calls.
If it got destroyed, then it just returns. However, if you run
Lita Cho added the comment:
Hi Terry,
I've added to the patch, so that the user is able to change the font size
through the GUI. I tried to match Google Doc's behaviour. I also added a max
font size. I choose 400 since that is what Google Docs limits their font size.
If you prefer to split
Lita Cho added the comment:
Thanks for the input Ronald! How would I go about forcing the turtledemo to be
in the foreground? Do I just need to call 'fg' on the subprocess? I've been
Googling and couldn't find anything obvious.
--
___
Python
Lita Cho added the comment:
I wasn't aware of make patchcheck. I will run this script when submitting
patches in the future. Thanks, Ned!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17172
Lita Cho added the comment:
I was going to add a dropdown menu to change the font size as well, but I am
going to wait till Serhiy's patch gets committed in issue22065 before I submit
my patch.
--
___
Python tracker rep...@bugs.python.org
http
Lita Cho added the comment:
I've updated this patch to include the changes Ned mentioned. I am waiting to
hear from Ronald if he has a better solution about dealing with the focus
problem with the keyboard and mouse.
--
Added file: http://bugs.python.org/file36121/turtle_demo_v3.patch
Lita Cho added the comment:
Hi Terry,
I originally had txtfont as a list, but I guess I was worried about readability
and accessing attributes by indices being unpythonic. But I might have been
over-doing it for this case. :)
In Mac, you don't need to divide event.delta by 120, only Windows
New submission from Lita Cho:
I updated my source code, and it looks like turtledemo doesn't launch anymore.
I get the following error:
Traceback (most recent call last):
File /Users/litacho/Development/cpython/Lib/runpy.py, line 170, in
_run_module_as_main
__main__, mod_spec)
File
Lita Cho added the comment:
Looks like this method was not doing anything. I removed it and the demo is
working just fine. Here is a patch.
--
keywords: +patch
Added file: http://bugs.python.org/file36076/tk_menubar_fix.patch
___
Python tracker rep
Lita Cho added the comment:
Here is an updated version of the patch now that Terry submitted the changes
from issue21597.
--
Added file: http://bugs.python.org/file36077/window_pane_font_size_v3.patch
___
Python tracker rep...@bugs.python.org
http
Lita Cho added the comment:
Here is a new patch where it checks to see if turtledemo exists first before
loading it onto the bindings.
--
Added file: http://bugs.python.org/file36081/turtle_demo_v2.patch
___
Python tracker rep...@bugs.python.org
Lita Cho added the comment:
Oops! I was suppose to add 'Control' not 'Ctrl'. I can fix that quickly but I
will wait till the other patch goes through.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21933
Lita Cho added the comment:
Just to clarify, should I submit a new patch with outlined style changes?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21597
Changes by Lita Cho lita@gmail.com:
--
nosy: -Lita.Cho
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1598
___
___
Python-bugs-list mailing
Lita Cho added the comment:
Sweet! Thank you so much, Terry!
On Wednesday, July 23, 2014, Terry J. Reedy rep...@bugs.python.org wrote:
Terry J. Reedy added the comment:
No, I believe this is done ;-). Onward to font sizing.
Thank you for the hard work on this. It is a great improvement
Lita Cho added the comment:
Sorry about that!! Thanks for letting me know.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21597
___
___
Python
Lita Cho added the comment:
Sounds good. I can wait till the sash code gets incorporated in order to
add in the font code.
I would have to generate a MOUSEWHEEL event and see if it fails. I have
generated mouse clicks before. I'll try to see if I can generate a
MOUSEWHEEL event and if it errors
Lita Cho added the comment:
I completely agree about the mousewheel. However, would it make sense for
OS X to combine command with mousewheel? I have never seen that before. I
am not sure if I can bind the zoom gesture with tkinter, but I can find
out.
I also think the shortcuts
Lita Cho added the comment:
What really? That is so awesome! I will check that out!
However, I figure I still need to create separate bindings for Linux,
Windows and Mac, right? Or does Tkinter unify all the mousewheel events?
Lita
On Tue, Jul 22, 2014 at 12:18 AM, Ned Deily rep
Lita Cho added the comment:
Oh I see. And then pinch on the trackpad just generates a overall MouseWheel
event, not a specific zoom-in event. For some reason, I thought there was a
different event depending on operating systems. Before, Linux would trigger
Button-4 and Button-5 events
Lita Cho added the comment:
I've added it so that if the OS is Mac, it will use Command-minus and
Command-=. If it is on Windows, it uses Ctrl-minus and Ctrl-= (I wasn't sure if
Windows uses shift sa well, but I don't think it does.)
When I tried the pinch movement in Mac, the MouseWheel
Lita Cho added the comment:
This is now fixed due to a patch in issue21868.
--
resolution: - fixed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21867
Lita Cho added the comment:
On Tue, Jul 22, 2014 at 8:20 PM, Terry J. Reedy rep...@bugs.python.org
wrote:
Terry J. Reedy added the comment:
I reviewed code and made the following changes in uploaded file:
Move some code and blank lines around.
Since you left packing within mBar frame
Lita Cho added the comment:
Sounds good. I will wait till #21587 and create a small patch afterwards.
Thanks!
On Tue, Jul 22, 2014 at 9:33 PM, Terry J. Reedy rep...@bugs.python.org
wrote:
Terry J. Reedy added the comment:
On windows, new patch gives this:
Traceback (most recent call last
Lita Cho added the comment:
Ping! Just wanted to see what the status was on getting this patch reviewed. I
hope your eye is feeling better, Terry!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21597
Lita Cho added the comment:
I have a version of this working with Ctrl-plus and Ctrl-minus. However, there
is a bug with Tk 8.5.9 where binding to MouseWheel crashes Tkinter for Macs
(issue10731), which I am running into. I need to update Tkinter to see if this
works
Lita Cho added the comment:
Here is a patch for changing the font size using the scroll wheel. I also added
the shortcuts Ctrl-plus to increase the font size and Ctrl-minus to
decrease the font size.
However, since the MouseWheel is now bound to changing the font
size, the canvas won't scroll
Changes by Lita Cho lita@gmail.com:
--
nosy: +jesstess
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1702036
___
___
Python-bugs-list mailing
Lita Cho added the comment:
Hi Roy,
Oh I see. Should we close this out as Won't Fix due to the fact that we
aren't sure how many users are using this with Domino servers?
Lita
On Fri, Jul 18, 2014 at 8:52 AM, Roy Hyunjin Han rep...@bugs.python.org
wrote:
Roy Hyunjin Han added the comment
Lita Cho added the comment:
I spent the last 2 hours trying to setup a Lotus Server, which is ending up to
be a lot more work then I thought in order to test this bug.
Is there anyway I can get a test Lotus account on a Lotus Server to test this
bug
Lita Cho added the comment:
R. David Murray added the comment:
Just to make sure I understand: the issue is that gmail may produce flags
with [] in them, and imaplib currently fails to process such flags when it
receives them from gmail?
This is correct. Gmail allows you to create flags
Lita Cho added the comment:
Okay, sounds good. I will also create a patch in the documentation that
explains this, as well as comment on the regex patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21815
Lita Cho added the comment:
Here is a patch for test_imaplib.py, adding the test for brackets. It should
fail with the current version of imaplib, but should pass with the
imap_regex.patch.
--
Added file: http://bugs.python.org/file35977/test_imaplib.patch
Lita Cho added the comment:
Updated the documentation in imaplib.rst to describe the RFC violation.
--
versions: -Python 3.4, Python 3.5
Added file: http://bugs.python.org/file35978/imap_doc.patch
___
Python tracker rep...@bugs.python.org
http
Lita Cho added the comment:
Updated my regex patch to include a comment about how we are violating the RFC
and allowing all characters rather thane excluding the ] character.
--
Added file: http://bugs.python.org/file35979/imap_regex.patch
Lita Cho added the comment:
Has this been determine as a server bug or a bug with imaplib? I am not able to
reproduce this bug with Gmail. Do I need to use it with Lotus Server to
recreate it?
--
nosy: +Lita.Cho
___
Python tracker rep
Lita Cho added the comment:
I have a patch for this. With my patch, the debug output is fixed.
--
keywords: +patch
Added file: http://bugs.python.org/file35962/imap_regex.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Lita Cho added the comment:
Here is a log of the output.
--
Added file: http://bugs.python.org/file35963/imaplib_log_with_patch.txt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21815
Lita Cho added the comment:
Yes! I agree, this change will need tests. I will start working on creating
those now.
Here is test I did to create a flag with brackets.
import imaplib
mail = imaplib.IMAP4_SSL('imap.gmail.com')
mail.login('usern...@gmail.com', 'password') # Enter your login here
Lita Cho added the comment:
Here is the code in order to see the bug.
imaplib.Debug = 5
mail = imaplib.IMAP4_SSL('imap.gmail.com')
mail.login(username, password) # Enter your login here
mail.select('test')
--
___
Python tracker rep
Changes by Lita Cho lita@gmail.com:
--
nosy: +Lita.Cho, jesstess
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21815
___
___
Python-bugs-list
Lita Cho added the comment:
I was reading the RFC spec, and it looks like it doesn't specificy '[' and ']'
are not allowed in the PERNANENTFLAGS names.
I can try to add a fix for this. But if anyone else knows if you are not
allowed to have '[' or ']' in flag names, please let me know
Lita Cho added the comment:
That's a good point. I can add that so the NNTPConnectError can inherit the
EOFError
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1186900
Lita Cho added the comment:
Here is an updated patch.
--
Added file: http://bugs.python.org/file35941/nntplib_error.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1186900
Lita Cho added the comment:
Make some changes to patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21914
___
___
Python-bugs-list mailing
Lita Cho added the comment:
Trying to attach a file again. I seem to be having trouble attaching it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21914
Changes by Lita Cho lita@gmail.com:
Added file: http://bugs.python.org/file35930/test_turtle_guionly_v2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21914
Lita Cho added the comment:
Hi Raymond! Just wanted to check if you had time to test this yet. I ran the
tests through the Turtle tests I wrote (issue21914), but those are still
pending approval.
This is off topic, but I also didn't realize till now that you gave a talk
about Transforming
Lita Cho added the comment:
That's perfect. I agree that this issue is closed! :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3015
Lita Cho added the comment:
Ingrid and I combined our tests. The patch now lives here:
http://bugs.python.org/issue21916
--
resolution: - duplicate
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21655
Lita Cho added the comment:
I personally think it would be better to check to see if the turtledemo exists
during startup, and if so, add the menu entry. Otherwise, don't add it when
loading up IDLE.
--
___
Python tracker rep...@bugs.python.org
Lita Cho added the comment:
I am going to fix it so that it raises the NNTPConnectionError rather than
update the documentation.
--
nosy: +Lita.Cho, jesstess
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1186900
Lita Cho added the comment:
I have a fix and added some test coverage in order to make sure the
NNTFConnectError was being called. However, in the test case, I am monkey
patching. If there is a way to do this with mock, I would appreciate the
feedback.
--
keywords: +patch
Added file
New submission from Lita Cho:
Currently, the turtledemo doesn't allow you to change font sizes of the demo
code, and the default font size is really small.
I can work on creating a patch to fix this. Best option be to have
control-mousewheel change size, as is standard in browsers, as well
Changes by Lita Cho lita@gmail.com:
Added file: http://bugs.python.org/file35890/turtledemo_pane_scroll_SOLID.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21597
Lita Cho added the comment:
Hi Terry,
So the shadow can easily be removed. I just went with the default sashrelief
style. I am going to attach two patches with different sashrelief styles, both
of which don't have the shadow.
--
Added file: http://bugs.python.org/file35889
Lita Cho added the comment:
I personally like the FLAT look because it matches with the rest of the GUI.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21597
Lita Cho added the comment:
Hey Terry,
So the reason why the tearing is a lot slower in 06/09 patch is because the
canvas is using the turtle.ScrolledCanvas widget. Everytime the window resizes,
it is calling a callback to `onResize` - `adjustScrolls` to update the
scrollbars. When I comment
Lita Cho added the comment:
I also put this patch out there. This doesn't have the PaneWindow, but I
manually widen the text pane. This would be the compromise if I can't figure
out the tearing due to the sash moving.
--
Added file: http://bugs.python.org/file35874
Lita Cho added the comment:
?! After debugging for awhile, I got it so that PanedWindow doesn't cause the
rightmost widget to tear! I had to disable the resizing binding on Turtle to
make it work.
However, now it seems like the canvas is no longer centered. Is there anyway
for me to get
Lita Cho added the comment:
I think I have a fix!! I made it so that centering works while fixing the
tearing.
For some reason, in the Turtle API, the adjustScrolls method creates a new
scroll widget for x and y and deletes the old one. I am not sure why it does it
this way. I'm sure
Lita Cho added the comment:
submitted a patch that tests all of this. Issue 21914
--
resolution: - duplicate
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21743
Lita Cho added the comment:
Hi Terry, I started digging into this deeper and it looks like my tests doesn't
tear in Python 2.7. I have tried on Python 3.5 and 3.4 and it tears on those
versions.
I also tried the ttk objects, and the widgets also teared when I added frames.
Here is the code I
Lita Cho added the comment:
Should I file a bug? I feel like this a bug specifically related to Python 3
and Tkinter.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21597
Lita Cho added the comment:
Oh I had no idea! That makes sense. How do I know which version of Tk I'm
working with? I'm testing on Mac OSX as well!
Would there be anyway for you to test my patch for turtledemo to see if the
sash causes artifacting for you? I see tearing but it snap back
Lita Cho added the comment:
I feel like the PaneWindow is nice. I could also see down the road making the
code text bigger.
However, if on Windows, the artifacting is really bad, I can totally switch
this back to the grid view.
--
___
Python
Lita Cho added the comment:
Oh man, I was running version '8.5.9' using 'aqua'. I am going to try and
upgrade and see if the artifacting goes away.
Lita
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21597
Lita Cho added the comment:
Hm, when I upgrade to 8.6, I still get the tearing action on the very right of
the window. Although, again, it doesn't seem that bad. I've attahed what I am
seeing, just to confirm we are all talking about the same thing.
--
Added file: http
Lita Cho added the comment:
Yes! This is the first version of the code without using ttk widgetd. Using
Labels instead of buttons.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21597
Lita Cho added the comment:
Hey Raymond, just wanted to ping you to see if you had a chance to review this
patch yet. Thanks!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21868
Changes by Lita Cho lita@gmail.com:
--
versions: +Python 3.4, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21868
___
___
Python
Changes by Lita Cho lita@gmail.com:
--
versions: +Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21868
___
___
Python-bugs-list
New submission from Lita Cho:
Create unit tests for the Turtle library, specifically on their gui commands.
--
components: Library (Lib), Tkinter
messages: 59
nosy: Lita.Cho, jesstess
priority: normal
severity: normal
status: open
title: Create unit tests for Turtle guionly
versions
Lita Cho added the comment:
I created tests for the gui portion of Turtle. This file combines both me and
Ingrid's work that is specifically the gui tests.
--
Added file: http://bugs.python.org/file35846/test_turtle_guionly.py
___
Python tracker rep
Lita Cho added the comment:
I forgot to make it a patch. Created it as a patch for convenience.
--
keywords: +patch
Added file: http://bugs.python.org/file35847/test_turtle_guionly.patch
___
Python tracker rep...@bugs.python.org
http
Changes by Lita Cho lita@gmail.com:
--
nosy: +jesstess
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21867
___
___
Python-bugs-list mailing
New submission from Lita Cho:
Turtle currently has a bug where it will return a TypeError when undobuffer is
set to less than or equal to 0 (aka undo is not allowed).
turtle.setundobuffer(0)
turtle.undo()
If an exception must be thrown, it should be a Turtle exception and not a
TypeError
New submission from Lita Cho:
Currently, you can set the undobuffer size to negative numbers. Aka, the
Tbuffer can be set to negative.
s = turtle.Screen()
raw = turtle.RawTurtle(s)
raw.setundobuffer(-10)
raw.undobuffer.bufsize == -10 -- returns True
This should not be possible. Tbuffer should
Changes by Lita Cho lita@gmail.com:
--
nosy: +jesstess
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21868
___
___
Python-bugs-list mailing
Lita Cho added the comment:
Here is a patch for this bug. Basically, when a user gives 0 and below, it
doesn't create a TBuffer. Then undo does the right thing.
--
keywords: +patch
Added file: http://bugs.python.org/file35778/undobuffer_fix.patch
Lita Cho added the comment:
The patch in issue21868 will fix this issue if it gets approved.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21867
1 - 100 of 150 matches
Mail list logo
