Meador Inge added the comment:
Whoops, the 'quit' case is actually intended and is documented
(http://docs.python.org/3.4/library/site.html):
or additions to the builtins. To explicitly trigger the usual site-specific
additions, call the site.main() function.
I think the right way to fix
Meador Inge added the comment:
Georg's proposal seems reasonable to me sans one very minor nit. I think the
e.g. bit is better off parenthesized:
There are, however, enough ways to crash Python with :mod:`ctypes`, so you
-should be careful anyway.
+should be careful anyway. The :mod
Meador Inge added the comment:
The cleanup of BYTESTR_DEPS and UNICODE_DEPS seems reasonable, but can you
explain the rationale behind removing the additional dependencies on
formatter_unicode.c? Why were those dependencies ever needed (I can't see the
dependencies from reading
Meador Inge added the comment:
Sorry, the BYTESTR_DEPS dependencies were already there pre-8beaa9a37387. I am
still curious why they are needed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16320
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16804
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16795
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16803
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16320
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15840
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16694
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16047
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14369
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16376
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16286
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16283
___
___
Python-bugs-list
Meador Inge added the comment:
See also issue9969.
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12486
___
___
Python-bugs
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12691
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16745
___
___
Python-bugs-list
Meador Inge added the comment:
Personally I prefer using attributes instead of pragmas. The GCC manual
recommends such as well. There are also other sources in Modules/* that use
'__attribute__ ((visibility (hidden)))'. Namely ctypes and zlib.
I can understand that it is more work, but I
Meador Inge added the comment:
I noticed functools in the list. issue14373 was opened somewhat recently to
reimplement functools.lru_cache in C. This issue seems to be promoting have
more things implemented in pure Python. Someone involved in this issue might
want to weigh in on issue14373
Meador Inge added the comment:
Ah, I missed how big of a line range these pragmas are covering when I scanned
the patch before. In that case, I agree with the current patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9974
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16576
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16575
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16447
___
___
Python-bugs-list
Meador Inge added the comment:
This is the same as issue13091. I proposed a similar fix there, but yours is
more complete and seems reasonable to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16628
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16619
___
___
Python-bugs-list
Meador Inge added the comment:
A string *is* a sequence. That is actually part of the problem.
Consider a slight variation on the original repro case:
class _OFFSET(Structure):
... _fields_ = [
... ('Offset', c_int),
... ('OffsetHigh', c_int)]
...
[70412 refs]
class
Meador Inge added the comment:
I'm not sure how much this is needed considering hashlib has been around,
since 2.5.
I hope people aren't having to port from before then.
Martin alluded to that when he opened the issue saying this wasn't necessary,
but a nice
to have. However, it has been
Meador Inge added the comment:
Attached is a refreshed patch that works for all active branches. The only
real change from the original is Éric's suggestion to s/hash/hashlib/. The 'u'
prefix isn't an issue any longer because of PEP 414.
Benjamin, does the attached look OK to you? If so
Meador Inge added the comment:
I haven't touched the patch since I attached it. I will refresh it today with
the feedback given.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2454
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16438
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16132
___
___
Python-bugs-list
Meador Inge added the comment:
Unassigning from myself. I thought I would have more time to review and push
this through.
--
assignee: meador.inge -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15475
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15675
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15675
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15671
___
___
Python-bugs-list
Meador Inge added the comment:
I debugged this a bit by comparing the behavior of 3.3 against 3.2. For both
cases I used the following code and debugged it in Python via pdb*:
import importlib
importlib.__import__('my_test_package')
ISTM that the difference in behavior is a result
Meador Inge added the comment:
On Mon, Aug 13, 2012 at 12:18 PM, Brett Cannon rep...@bugs.python.org wrote:
So deleting __init__.py and only having __init__.so in Python 3.2 should work.
It doesn't work:
quicksilver:bugs meadori$ python.exe --version
Python 3.2.3+
quicksilver:bugs meadori
Meador Inge added the comment:
I know the title says spurious, but is there a way to reproduce this at all?
Can I run a certain suite N times or something? How did you find the problem?
--
nosy: +meador.inge
___
Python tracker rep
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15627
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15623
___
___
Python-bugs-list
Meador Inge added the comment:
Thanks for the patches! (I fixed a minor nit on the 2.7 patch where
'array_sizeof' was defined inside #ifdef Py_USING_UNICODE).
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
Meador Inge added the comment:
On Wed, Aug 8, 2012 at 5:41 AM, Raymond Hettinger rep...@bugs.python.org
wrote:
I'm not sure why anyone would really want this functionality for itertools,
but I don't see any harm in adding it as long as the other implementations
aren't required to follow
Meador Inge added the comment:
Georg, yet another __sizeof__ fix. OK for 3.3?
--
nosy: +georg.brandl
stage: - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15424
Meador Inge added the comment:
I agree that the general case is complicated. It will get even more
complicated if the full of PEP 3118 gets implemented since it turns into a tree
comparison. In general, I think you will probably have to compute some
canonical form and then compare
Meador Inge added the comment:
Ah, good examples Mark. So, why is it ever useful keep a key with a value of
zero? In other words, why:
Counter(a=0)
Counter({'a': 0})
instead of:
Counter(a=0)
Counter()
?
The latter seems more consistent to me
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15568
___
___
Python-bugs-list
Meador Inge added the comment:
Raymond, Stephen's analysis seems correct. Are we missing something or can
this issue be closed?
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14182
Meador Inge added the comment:
I left some commits in Rietveld. Otherwise, looks OK.
--
assignee: - meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15424
Changes by Meador Inge mead...@gmail.com:
--
stage: - needs patch
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15566
Meador Inge added the comment:
LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15471
___
___
Python-bugs-list mailing list
Unsubscribe
Meador Inge added the comment:
Yup, it is still an issue. The recent activity was mostly related to Windows
builds (issue15431).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15352
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15530
___
___
Python-bugs-list
Meador Inge added the comment:
I am indifferent with respect to the use of the GCC extensions, but getting rid
of the umpteen different implementations of MIN/MAX is a nice , albeit very
minor, cleanup.
--
___
Python tracker rep...@bugs.python.org
Meador Inge added the comment:
OK, I finally had some time to look at this. The attached patch does fix the
issue. However, it has a nasty side effect in that the encoded bitfield size
stays with the field member object:
class SubByte(c_ubyte): pass
...
class A(Structure
Meador Inge added the comment:
The test should go in the 'SizeofTest' class and maybe a better test would be a
variant of the test already in that class:
@support.cpython_only
def test_buffer_freeing(self) :
bufsize = 4096
rawio = self.MockRawIO()
bufio
Meador Inge added the comment:
Nice work Victor.
Can we turn that particular optimisation off?
/OPT:NOICF is probably what we are looking for [1]:
/OPT:ICF can result in the same address being assigned to different functions
or read only data members (const variables compiled with /Gy). So
Meador Inge added the comment:
This is probably meant to imply that pointers to different functions must
not compare equal.
I think so. Also, in our case the functions have different names, therefore
they can't be the same function.
So if this is determined to be a compiler bug, the most
Meador Inge added the comment:
Hi Chris, it seems reasonable to me, but I would feel more comfortable if
someone (like Nick) that is more familiar with the generator implementation can
comment on this as well.
--
___
Python tracker rep
Changes by Meador Inge mead...@gmail.com:
--
stage: - committed/rejected
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15467
Meador Inge added the comment:
Serhiy, I didn't analyze it too in depth, but why aren't the test cases using
the __sizeof__ support work you implemented for issue15467? I think these
tests should be using the more exact method like your other '__sizeof__'
patches.
--
nosy
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15486
___
___
Python-bugs-list
Meador Inge added the comment:
On Sun, Jul 29, 2012 at 11:50 AM, Serhiy Storchaka rep...@bugs.python.org
wrote:
Serhiy, I didn't analyze it too in depth, but why aren't the test cases
using the __sizeof__ support work you implemented for issue15467? I think
these tests should be using
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15488
___
___
Python-bugs-list
Meador Inge added the comment:
How about the attached?
--
keywords: +patch
nosy: +meador.inge
stage: - patch review
type: - behavior
Added file: http://bugs.python.org/file26592/issue-15471.patch
___
Python tracker rep...@bugs.python.org
http
Meador Inge added the comment:
On Sat, Jul 28, 2012 at 3:27 AM, Serhiy Storchaka
rep...@bugs.python.org wrote:
Serhiy Storchaka storch...@gmail.com added the comment:
issue15456
efficiently demonstrates that the current style can detect bugs
which testing with object.__sizeof__ can't
Meador Inge added the comment:
Hmmm, in your original description you say that the 'generator.__next__'
documentation should be changed, but in the patch the note applies to all
generator methods. From looking at the code it seems that the patch is correct
and that '__next__', 'send', 'throw
Changes by Meador Inge mead...@gmail.com:
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15402
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15475
___
___
Python-bugs-list
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15469
___
___
Python-bugs-list
Meador Inge mead...@gmail.com added the comment:
While looking this up in the C Standard (ISO/IEC 9899:TC3) I also noticed
6.3.2.3p8:
A pointer to a function of one type may be converted to a pointer to a function
of another
type and back again; the result shall compare equal to the original
Meador Inge mead...@gmail.com added the comment:
On Wed, Jul 25, 2012 at 5:38 PM, Jesús Cea Avión rep...@bugs.python.org wrote:
So the good old int main(void) behaviour is undefined :-)
Actually the C Standard says that is OK. See 5.1.2.2.1 of ISO/IEC 9899:TC3
Meador Inge mead...@gmail.com added the comment:
The attached patch fixes: (1) the test cases to make them exact (inspired by
'test_sys.py'), (2) the definition of 's_sizeof' to add the dummy parameter,
and (3) simplifies the sizeof calculation using 's_len'.
--
Added file: http
Meador Inge mead...@gmail.com added the comment:
Any comments on this one? I plan on committing the changes tomorrow unless I
hear something otherwise.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14201
Meador Inge mead...@gmail.com added the comment:
It is part of runtime services and is mentioned in the documentation for
'sys.getsizeof' [1]:
getsizeof() calls the object’s __sizeof__ method and adds an additional garbage
collector overhead if the object is managed by the garbage collector
Meador Inge mead...@gmail.com added the comment:
What I meant by that was that Serhiy contributed a code change and was already
in Misc/ACKS, therefore no ACKS file should have been updated. I didn't mean
to imply that someone can't be in both files. My impression is that Misc/ACKS
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11549
___
___
Python-bugs-list
Meador Inge mead...@gmail.com added the comment:
I agree with Martin on having tests for the exact values and the s_len + 1
point. I will fix both issues.
--
assignee: - meador.inge
nosy: -python-dev
stage: patch review - needs patch
___
Python
Meador Inge mead...@gmail.com added the comment:
OK, I will commit this sometime today.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15402
Meador Inge mead...@gmail.com added the comment:
Thanks for the patch Serhiy!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15402
Meador Inge mead...@gmail.com added the comment:
Hi Jesús,
I replied to python-dev, but the Doc/ACKS.txt changes aren't necessary and I
was OK with the way Serhiy submitted the tests.
--
___
Python tracker rep...@bugs.python.org
http
Meador Inge mead...@gmail.com added the comment:
On Mon, Jul 23, 2012 at 5:04 PM, Martin v. Löwis rep...@bugs.python.org wrote:
The patch that Meador committed is incorrect: METH_NOARGS functions
still take a PyObject* args argument, which will be NULL. I'm puzzled, as
Serhiy's original
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11824
___
___
Python-bugs-list
Meador Inge mead...@gmail.com added the comment:
Thanks for the analysis Mark. I agree with your points.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15400
Meador Inge mead...@gmail.com added the comment:
Module a few cosmetic changes (variable names and doc string tweaks), the patch
looks good. Having a correct answer for `sys.getsizeof(struct.Struct('100B'))`
is definitely better. Per the documentation for 'sys.getsizeof' [1]:
All built
Meador Inge mead...@gmail.com added the comment:
Thanks for the patch. I will review it shortly.
--
assignee: - meador.inge
components: +ctypes
nosy: +meador.inge
stage: - patch review
type: - behavior
___
Python tracker rep...@bugs.python.org
Meador Inge mead...@gmail.com added the comment:
Thanks again for the patch Flávio. Please contribute again to Python (be sure
to fill out a contributor agreement if you do:
http://www.python.org/psf/contrib/).
--
resolution: - fixed
stage: patch review - committed/rejected
status
Meador Inge mead...@gmail.com added the comment:
This looks OK to me. I will commit later today.
--
assignee: - meador.inge
components: +Library (Lib) -Extension Modules
stage: - commit review
type: - behavior
___
Python tracker rep
Meador Inge mead...@gmail.com added the comment:
I already added you to ACKS with the ctypes patch :-)
http://hg.python.org/cpython/rev/f93efd4c45bd
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15409
Meador Inge mead...@gmail.com added the comment:
Thanks for the patch!
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15409
New submission from Meador Inge mead...@gmail.com:
While reviewing the change for issue15409 I noticed that the 'urlib.request'
documentation has an error in the deprecation note for
'urllib.request.Request.is_unverifiable' [1]:
Deprecated in 3.3, use Request.is_unverifiable
Changes by Meador Inge mead...@gmail.com:
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15410
Meador Inge mead...@gmail.com added the comment:
I can still reproduce the parsetok.c problem on the 'default' branch using the
CTRL+D method Stefan described.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3367
Meador Inge mead...@gmail.com added the comment:
This looks OK to me (I don't see a way to write a test case to cover the leak).
I will commit later today unless I hear some objections.
--
assignee: - meador.inge
nosy: +meador.inge
stage: - commit review
versions: +Python 3.3
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15397
Meador Inge mead...@gmail.com added the comment:
Thanks for the patch Julia!
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15394
Meador Inge mead...@gmail.com added the comment:
I just read through all this and see three separate points be discussed:
1. The unbounded caching behavior.
2. A more compact representation for repeat counts.
3. Correct __sizeof__ support for struct.
For issue (1) I think
Changes by Meador Inge mead...@gmail.com:
--
nosy: +meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15386
___
___
Python-bugs-list
Meador Inge mead...@gmail.com added the comment:
It could be argued that this is a bug fix for 2.7. I find the current behavior
odd at best since 'int' already accepts 'long' objects, but not the string
representation of a 'long' object:
sys.maxint
9223372036854775807
sys.maxint + 1
101 - 200 of 625 matches
Mail list logo
