Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10395
___
Paul Moore added the comment:
The patch looks good to me.
rhettinger: I'm not sure I see a problem with the doc changes in the latest
patch - noting that commonprefix may return an invalid path is fine, and what
the current docs say. Directing people to commonpath if they don't want invalid
Roundup Robot added the comment:
New changeset ec6c812fbc1f by Serhiy Storchaka in branch 'default':
Issue #10395: Added os.path.commonpath(). Implemented in posixpath and ntpath.
https://hg.python.org/cpython/rev/ec6c812fbc1f
--
nosy: +python-dev
Serhiy Storchaka added the comment:
The patch only adds a reference to commonpath() in commonprefix()
documentation. The note about invalid paths already was here.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10395
Paddy McCarthy added the comment:
Can we now:
1. Move os.path.commonprefix to str.commonprefix or string.commonprefix
2. Deprecate the use of os.path.commonprefix
3. Add os.path.commonpath
4. Update the documentation.
This seems to have lingered for too long and yet people have been willing
Serhiy Storchaka added the comment:
Here is revised patch. The behavior is changed in correspondence with results
of Python-ideas discussion, extended tests, fixed several bugs.
--
keywords: +patch
stage: commit review - patch review
Added file:
Raymond Hettinger added the comment:
This patch looks reasonable except for the doc change to
os.path.commonprefix(). Remember, that function IS working as documented and
that our policy is to document in an affirmative manner (here is what the
function does and how to use it versus being
Changes by Éric Araujo mer...@netwok.org:
--
stage: patch review - commit review
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10395
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10395
___
___
Serhiy Storchaka added the comment:
Some conclusions of discussion at Python-ideas
(http://comments.gmane.org/gmane.comp.python.ideas/17719):
1. commonpath() should eat double slashes in input (['/usr/bin', '/usr//bin']
- '/usr/bin'). In any case the current implementation eats slashes on
Changes by Rafik Draoui ra...@rafik.ca:
Added file: http://bugs.python.org/file27974/patch10395-3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10395
___
Rafik Draoui added the comment:
Here is a new patch addressing some of storchaka review comments, and
implementing a version in ntpath.
For the Windows version, I did as proposed in msg174819, but as I am not
familiar with the semantics and subtleties of paths in Windows maybe this
version
Rafik Draoui added the comment:
Here is a patch with an implementation of os.path.commonpath, along with tests
and documentation. At the moment, this is only implemented for POSIX, as I
don't feel like I know enough about Windows to tackle drive letters and UNC in
paths without spending some
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10395
___
___
Serhiy Storchaka added the comment:
At the moment, this is only implemented for POSIX, as I don't feel like I
know enough about Windows to tackle drive letters and UNC in paths without
spending some more time on it.
Just use splitdrive() and first ensure that all drivespecs are same, then
Éric Araujo added the comment:
Rafik is working on os.path.commonpath for the bug day.
--
versions: +Python 3.4 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10395
___
Changes by Santoso Wijaya santoso.wij...@gmail.com:
--
nosy: +santa4nt
versions: +Python 3.3 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10395
___
Eric Snow ericsnowcurren...@gmail.com added the comment:
You can already get the better prefix using os.path, albeit less efficiently.
Here's an example:
def commondirname(paths):
subpath = os.path.commonprefix(paths)
for path in paths:
if path == subpath:
return
Changes by Roman Evstifeev someuniquen...@gmail.com:
--
nosy: +Roman.Evstifeev
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10395
___
___
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10395
___
___
Python-bugs-list
R. David Murray rdmur...@bitdance.com added the comment:
Indeed, as I remember it there are people using commonprefix as a string
function in situations having nothing to do with os paths.
I'm changing the title to reflect the fact that this is really a feature
request for a new function.
21 matches
Mail list logo
