[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Tal Einat added the comment: To those following this issue, PR GH-14030 is now in a very good state, and would benefit from more feedback. -- ___ Python tracker ___

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Tal Einat added the comment: I've made some significant improvements in several aspects: 1. Scrolling: performance and behavior 2. Selection entire lines by dragging over line numbers 3. Color config: a separate highlighting setting for line numbers, which takes effect immediately I've

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Terry J. Reedy added the comment: Tal, I will be delighted to see this finally land. Please continue. Some immediate comments to update the years-ago discussion. 1a. IDLE now explicitly requires tk 8.5. AFAIK, it is only tested on 8.6. 1b. Feature are no longer extensions. 2a. The code

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Tal Einat added the comment: > Looks like a black belt always on the left side, this makes me feel a bit > oppressive. This currently uses the same colors as the code-context panes, which is configurable as the "context" fg/bg colors. We might find a better name for this, or even add a

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Tal Einat added the comment: Ned, thanks for taking a look! If it is decided to go forward with this then I will make sure to make the menu item state consistent with that of each window. -- ___ Python tracker

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Ma Lin added the comment: I tried PR 14030 today. By default, the fgcolor is black. Looks like a black belt always on the left side, this makes me feel a bit oppressive. Of course, the fgcolor can be changed. -- nosy: +Ma Lin Added file: https://bugs.python.org/file48455/1.png

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Ned Deily added the comment: Tal, I took a quick look at the results with the current PR and, as someone who doesn't use IDLE other than to smoke test, It looks fine to me. The concerns I raised previously about the interaction between changing the state of Options->Line Numbers and

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Tal Einat added the comment: I'm rather surprised at the lack of enthusiasm for this here and on idle-dev! I was sure people would be happy to see this finally approaching completion after so many years. To clarify, all I'm waiting for now is to hear whether this change is wanted, before I

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Change by Tal Einat : -- versions: +Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Tal Einat added the comment: In reference to previous discussion here about the effect of toggling line numbers on future opened windows: IMO toggling shouldn't affect future windows; those should behave according to the configured default state. The default state should be changed only by

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Tal Einat added the comment: Please see updated PR, GH-14030. It's not 100% ready yet. At this point the goal is to have some people try it and give feedback. So please, give it a go and let me know what you think! -- nosy: +taleinat ___ Python

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Change by Tal Einat : -- pull_requests: +13894 stage: commit review -> patch review pull_request: https://github.com/python/cpython/pull/14030 ___ Python tracker ___

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Change by Terry J. Reedy : -- versions: +Python 3.8 -Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Big Stone added the comment: Dear Mike Thompson, I think your most reasonnable option this year is to use the IDLEX fork, that works on Python-3.6/3.7 now: pip install IDLEX python idlex.pyw # or python [directory of python.exe]\scripts\idlex.pyw --

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Mike Thompson added the comment: I am a teacher, and this feature would really help me teach Python to my students. Especially when I am teaching the course remotely. -- nosy: +mthompsonwhs ___ Python tracker

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Change by Tal Einat : -- nosy: -taleinat ___ Python tracker ___ ___ Python-bugs-list

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Terry J. Reedy added the comment: Yes. When we are more or less done with reworking the config dialog, I expect to work on editor/shell. -- versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.4, Python 3.5 ___ Python tracker

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Big Stone added the comment: is there still any hope on this ? -- nosy: +Big Stone ___ Python tracker ___

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Mark Roseman added the comment: Just as a point of information and possible future reference, there is a 'tklib' (collection of Tk-related modules written in Tcl) module called 'ctext' which does syntax highlighting as well as implements the line numbering thing (also using a text widget

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Changes by Mark Roseman m...@markroseman.com: -- nosy: +markroseman ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17535 ___ ___ Python-bugs-list

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Changes by irdb dalba.w...@gmail.com: -- nosy: +irdb ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17535 ___ ___ Python-bugs-list mailing list

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Terry J. Reedy added the comment: A blog post replay mentioned http://tkinter.unpythonic.net/wiki/A_Text_Widget_with_Line_Numbers. I will take a look when I get back to this issue. I have also thought trying the Extension configure menu approach #3068 of pasting widgets on a scrollable

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Terry J. Reedy added the comment: And if you enable code context in the other window, neither will have the checkmark. As I said, the one button is being used to toggle two things: the state of the current window and the default for future windows, and the checkmark only indicates the second.

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Roger Serwy added the comment: When it comes to the checkmark next to Code Context in the menu, be aware of issue13179. You can launch IDLE, open two separate editors, enable Code Context in one, and the other will have its menu entry checked as well when it is not enabled. --

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Saimadhav Heblikar added the comment: @ Ned Deily: Thank you for the comment's. 1. I documented it in the config-extensions.def how to make it visible on startup(or not). In the new patch, it is not visible by default. 2. I have made the changes. 4. I'll explain the reason why this argument

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Ned Deily added the comment: Thanks for addressing the comments. With linenumber-text-widget-v2.diff: 1. With Tk 8.4, the extension gets a bit further but still fails: File /Users/nad/Projects/PyDev/active/dev/3x/t/idlelib/__main__.py, line 9, in module idlelib.PyShell.main() File

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Saimadhav Heblikar added the comment: On 16 August 2014 14:03, Ned Deily rep...@bugs.python.org wrote: 1. With Tk 8.4, the extension gets a bit further but still fails: I fixed this now. Please let me know how it works now. 2. I just noticed that the (now) Line Number menu item has no

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Ned Deily added the comment: 1. With Tk 8.4, the extension gets a bit further but still fails: I fixed this now. Please let me know how it works now. Yep, 8.4 now seems to work just fine. 2. I just noticed that the (now) Line Number menu item has no visual indication of its state nor does

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Terry J. Reedy added the comment: I believe the line number behavior Ned describes is the same as the Code Context behavior. I just tested the latter to verify Saimadhav's email report. I think both *should* be the same. The docs say Code Context is a toggle. However, it does not mention the

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Serhiy Storchaka added the comment: 3. Make the checkmark toggle local to the window and make the preferences option toggle default value to all windows. This is how it works in Kate (KDE text editor). -- ___ Python tracker rep...@bugs.python.org

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Terry J. Reedy added the comment: I believe your 3. is my 1b. It really requires being able to change preference for an extension without editing ~HOME/.idlerc/config-extensions.cfg by hand. See #3068. -- ___ Python tracker rep...@bugs.python.org

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Ned Deily added the comment: As Terry requested, here are a few comments on running linenumber-text-widget-v1.diff on OS X. Overall, this looks to me to be a useful option. 1. Having line numbering enabled by default was a bit of a surprise, particularly in light of 2. 2. The Toggle

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Terry J. Reedy added the comment: Thanks for the comments. 1. I previously said somewhere 'enabled but initially off' by default. I intend to make sure of that before committing. 2. Option menu sounds good.. 3. I tried out a *much* lighter gray, as with Notepad++. Saimadhav is leaving that

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Terry J. Reedy added the comment: I believe the patch works slightly better on my system with the above mentioned block uncommented. The problem being addressed is this. The editor sendx a set command to the vertical scrollbar after *any* action that affects the lines displayed. We intercept

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Saimadhav Heblikar added the comment: Attached is Text widget based implementation to add linenumbering to IDLE. NS: The purpose of comment block in update_sidebar_text_font The reason why it is there is to allow tk to catch up with changes(esp on large files) after a font change. While it

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Terry J. Reedy added the comment: I tried v2 and it works, subject to the following comments. 1. (The biggest issue) For me, the 'obvious' implementation would be a narrow text window using the same font and size as the main window. The canvas introduces the problem of having to calculate the

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Saimadhav Heblikar added the comment: List of additions/changes 1. EditorWindow uses LineNumber.Text instead of tkinter.Text. 2. Added linenumber canvas to IDLE windows except PyShell 3. Some info about LineNumber.Text a) Inherits tk.Text b) Generates Changed virtual

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Changes by Saimadhav Heblikar saimadhavhebli...@gmail.com: -- nosy: +taleinat ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17535 ___ ___

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Raymond Hettinger added the comment: FWIW, I don't think line numbers should be enabled by default for IDLE or any other editor. It isn't the norm and can be distracting. If you've ever tried to use IDLE to teach kids, you would value minimizing visual distractions. -- nosy:

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Tal Einat added the comment: Many IDEs do show line numbers by default. And it does make discussing code with others simpler, e.g. when teaching. But I tend to agree with Raymond that it would be better to keep the default interface clean. Anyone who will want line numbers will be able to

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Saimadhav Heblikar added the comment: Attached is a patch which adds linenumbering to IDLE. [1] is the current discussion regarding this topic at idle-dev. This patch is a initial patch. It is missing menu and config additions. I have posted it in this state, so that we can catch platform

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Saimadhav Heblikar added the comment: As a part of my GSOC 2014 proposal, i had prepared a mockup which adds linenumbering feature to a text widget.I am adding the mockup along with a image. Working: Intercepts low level calls and detects if any of the actions modify current view.If they do

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Changes by Saimadhav Heblikar saimadhavhebli...@gmail.com: Added file: http://bugs.python.org/file34396/Screenshot from 2014-03-09 16:09:37.png ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17535

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Changes by Saimadhav Heblikar saimadhavhebli...@gmail.com: Removed file: http://bugs.python.org/file34396/Screenshot from 2014-03-09 16:09:37.png ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17535

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Changes by Saimadhav Heblikar saimadhavhebli...@gmail.com: Added file: http://bugs.python.org/file34397/line numbering mockup image.png ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17535 ___

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17535 ___ ___

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Changes by R. Jayakrishnan raaj...@gmail.com: -- nosy: +JayKrish ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17535 ___ ___ Python-bugs-list

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Roger Serwy added the comment: I received permission from UIUC to relicense IdleX code used for contributions into Python. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17535 ___

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Terry J. Reedy added the comment: PSF accepts contributions from authors under Contributor Agreements. It does not grab software from 3rd parties, no matter how lenient the license. Roger, if you assigned all rights to the University, you should talk with them about either getting some back

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Todd Rovito added the comment: I got the extension from Roger Serwy's IDLEX, it is one of my favorite extensions. In addition to adding the extension I updated the documentation both idle.rst and help.txt. Finally I tested the patch on Mac OS X and it works great. This patch is for 3.4 but

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Todd Rovito added the comment: For this patch to work correctly the option menu must be present so issue 17532 http://bugs.python.org/issue17532 has to be resolved. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17535

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Roger Serwy added the comment: Todd, the LineNumbers.py extension from the IdleX project contains work-arounds for interacting cleanly with the Code Context extension. It also has a hack for dealing with the shortcomings of the Percolator/Delegator ordering. There are other shortcomings in

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Todd Rovito added the comment: The NCSA license is very permissive I would be surprised if the PSF didn't accept it since both are BSD based. Needless to say I am not a lawyer and I am not sure who to speak with about this issue. I was able to find some precedence with the PEP 3146 which

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Roger Serwy added the comment: The file uploaded in 2010 falls under my PSF contributor agreement which has the Apache V2.0 license. The updates to the code in the latest version of IdleX fall under the NCSA license. -- ___ Python tracker

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

New submission from Todd Rovito: I think it could be very helpful to add line numbers along the left side of the editor window. The feature could be toggled on/off easily enough. This was mentioned in the Invent with Python blog about IDLE so obviously other people would like the feature.

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

Changes by Todd Rovito rovit...@gmail.com: -- nosy: +roger.serwy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17535 ___ ___ Python-bugs-list