[issue21469] False positive hazards in robotparser

2014-05-12 Thread Ethan Furman
Changes by Ethan Furman et...@stoneleaf.us: -- nosy: +ethan.furman ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21469 ___ ___ Python-bugs-list

[issue21469] False positive hazards in robotparser

2014-05-12 Thread Tal Einat
Tal Einat added the comment: Changes LGTM. This module could certainly use some cleanup and updates. For example, last_changed should be a property and always accessed one way (instead of either .mtime() or .last_changed) and should be initialized to None instead of zero to avoid ambiguity,

[issue21469] False positive hazards in robotparser

2014-05-12 Thread Skip Montanaro
Skip Montanaro added the comment: Can this change be (easily) tested? If so, a test case akin to your original example would be nice. -- nosy: +skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21469

[issue21469] False positive hazards in robotparser

2014-05-12 Thread Raymond Hettinger
Raymond Hettinger added the comment: Changes LGTM. Thanks for the review :-) This module could certainly use some cleanup and updates. Yes, the API is a mess, but I would like to be very conservative with API modifications (preferably none at all) so we don't break the code of very few

[issue21469] False positive hazards in robotparser

2014-05-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4ea86cd87f95 by Raymond Hettinger in branch '3.4': Issue 21469: Mitigate risk of false positives with robotparser. http://hg.python.org/cpython/rev/4ea86cd87f95 -- nosy: +python-dev ___ Python tracker

[issue21469] False positive hazards in robotparser

2014-05-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset f67cf5747a26 by Raymond Hettinger in branch '3.4': Issue 21469: Add missing news item http://hg.python.org/cpython/rev/f67cf5747a26 -- ___ Python tracker rep...@bugs.python.org

[issue21469] False positive hazards in robotparser

2014-05-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset d4fd55278cec by Raymond Hettinger in branch '2.7': Issue 21469: Mitigate risk of false positives with robotparser. http://hg.python.org/cpython/rev/d4fd55278cec -- ___ Python tracker

[issue21469] False positive hazards in robotparser

2014-05-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset 560320c10564 by Raymond Hettinger in branch 'default': Issue 21469: Minor code modernization (convert and/or expression to an if/else expression). http://hg.python.org/cpython/rev/560320c10564 -- ___

[issue21469] False positive hazards in robotparser

2014-05-12 Thread Raymond Hettinger
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21469 ___

[issue21469] False positive hazards in robotparser

2014-05-11 Thread Raymond Hettinger
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- stage: - test needed title: Hazards in robots.txt parser - False positive hazards in robotparser ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21469