[issue26707] plistlib fails to parse bplist with 0x80 UID values

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue26707] plistlib fails to parse bplist with 0x80 UID values

Serhiy Storchaka added the comment: New changeset c981ad16b0f9740bd3381c96b4227a1faa1a88d9 by Serhiy Storchaka (Jon Janzen) in branch 'master': bpo-26707: Enable plistlib to read UID keys. (GH-12153) https://github.com/python/cpython/commit/c981ad16b0f9740bd3381c96b4227a1faa1a88d9

[issue26707] plistlib fails to parse bplist with 0x80 UID values

Jon Janzen added the comment: I recently upgraded my python version and my hot-patch broke due to changes in bpo-32072 (GH-4455). It reminded me of this b.p.o., and after reading through the messages to remind myself where the patch stood I realized that my tone friendly towards the end

[issue26707] plistlib fails to parse bplist with 0x80 UID values

Change by Jon Janzen : -- pull_requests: +12152 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26707] plistlib fails to parse bplist with 0x80 UID values

Jon Janzen added the comment: Ping -- ___ Python tracker ___ ___ Python-bugs-list

[issue26707] plistlib fails to parse bplist with 0x80 UID values

Jon Janzen added the comment: Support for KeyedArchives are not limited to the Swift implementation I linked to. They have been supported since Mac OS X since 10.2 (long before Swift came around). The documentation

[issue26707] plistlib fails to parse bplist with 0x80 UID values

Change by Serhiy Storchaka : -- type: behavior -> enhancement ___ Python tracker ___

[issue26707] plistlib fails to parse bplist with 0x80 UID values

Ronald Oussoren added the comment: I'm still not too happy about supporting UIDs in plistlib, especially because I'm not sure it that's all that's needed. AFAIK I removed more types that the underlying encoder supported from plistlib because those are never used in

[issue26707] plistlib fails to parse bplist with 0x80 UID values

Jon Janzen added the comment: Ping -- ___ Python tracker ___ ___ Python-bugs-list

[issue26707] plistlib fails to parse bplist with 0x80 UID values

Jon Janzen added the comment: @serhiy.storchaka: I've implemented a UID wrapper class I've also updated the parser and writer classes to support the UID wrapper. The implementations for reading/writing XML UID tags match the implementations given by Apple's plutil

[issue26707] plistlib fails to parse bplist with 0x80 UID values

Serhiy Storchaka added the comment: But they use the plist format for serialization (as plists theirself use the XML format). https://github.com/apple/swift-corelibs-foundation/blob/master/Foundation/NSKeyedArchiver.swift Direct support of keyed archives would be

[issue26707] plistlib fails to parse bplist with 0x80 UID values

Ronald Oussoren added the comment: @bigfootjon: Cocoa keyed archives are not plist files. -- ___ Python tracker ___

[issue26707] plistlib fails to parse bplist with 0x80 UID values

Jon Janzen added the comment: Hello, I have attached a file extracted from the database of the 2Do App for iOS and macOS. The file contains information about tags used in the app. plistlib cannot currently parse this file because it lacks the ability to read byte 0x80

[issue26707] plistlib fails to parse bplist with 0x80 UID values

Ronald Oussoren added the comment: Note that I'm still -1 on merging this patch because it is unclear how to create such plist files using public Apple APIs. P.S. The low-level code for creating and reading binary plist files appears to be used for more than juist

[issue26707] plistlib fails to parse bplist with 0x80 UID values

Change by Roundup Robot : -- pull_requests: +5693 ___ Python tracker ___

[issue26707] plistlib fails to parse bplist with 0x80 UID values

Serhiy Storchaka added the comment: The size of UID data is just tokenL + 1, not self._get_size(tokenL + 1). FYI, the code for support UIDs and other types was proposed in issue14455, but was excluded from the final patch. -- ___ Python tracker

[issue26707] plistlib fails to parse bplist with 0x80 UID values

Ronald Oussoren added the comment: How can you create plist files that contain UID values using Apple's APIs? The plist library is meant to be interoperable with files created using Apple's APIs for creating plist files, and I didn't find an API that created UID values at the time.

[issue26707] plistlib fails to parse bplist with 0x80 UID values

John Lehr added the comment: Based on the format specification pointed to by Serhiy, perhaps this a better patch, correcting size from previous patch submission and treating: 706,707c706,708 < # tokenH == 0x80 is documented as 'UID' and appears to be used for < #

[issue26707] plistlib fails to parse bplist with 0x80 UID values

Changes by Serhiy Storchaka : -- assignee: -> ronaldoussoren ___ Python tracker ___ ___

[issue26707] plistlib fails to parse bplist with 0x80 UID values

John Lehr added the comment: I’m sorry, but the files in which I detected the problem cannot be circulated. I will try to create a test account on Snapchat and generate some test data, but I can’t do this anytime soon. > On Apr 7, 2016, at 12:51 AM, SilentGhost

[issue26707] plistlib fails to parse bplist with 0x80 UID values

John Lehr added the comment: I’m glad you found it in the Apple specification. I looked, but missed it. I would absolutely defer to you on your assessment of the decoding. > On Apr 7, 2016, at 1:46 AM, Serhiy Storchaka wrote: > > > Serhiy Storchaka added the

[issue26707] plistlib fails to parse bplist with 0x80 UID values

Serhiy Storchaka added the comment: UID is rather int than bytes. And I would use a special UID type. According to Apple's sources [1], the size of UID data is tokenL+1, not self._get_size(tokenL). [1] http://www.opensource.apple.com/source/CF/CF-1153.18/CFBinaryPList.c --

[issue26707] plistlib fails to parse bplist with 0x80 UID values

SilentGhost added the comment: Here is the version of the patch suitable for the Rietveld. John, could you perhaps provide an example file that uses UID values? Also, the code is identical to handling of 0x50 token, perhaps it could be incorporated into it. -- nosy: +SilentGhost

[issue26707] plistlib fails to parse bplist with 0x80 UID values

Changes by Serhiy Storchaka : -- nosy: +ronaldoussoren, serhiy.storchaka type: crash -> behavior ___ Python tracker ___

[issue26707] plistlib fails to parse bplist with 0x80 UID values

New submission from John Lehr: libplist raises an invalid file exception on loading properly formed binary plists containing UID (0x80) values. The binary files were tested for form with plutil. Comments at line 706 state the value is defined but not in use in plists, and the object is not