[issue27485] urllib.splitport -- is it official or not?

STINNER Victor added the comment: Follow-up: I created bpo-45084 to remove these undocumented and deprecated functions in Python 3.11. -- nosy: +vstinner ___ Python tracker

[issue27485] urllib.splitport -- is it official or not?

Jason R. Coombs added the comment: Please refer to issue35891 for a description of an important use-case broken by the planned removal of splituser. -- nosy: +jason.coombs ___ Python tracker

[issue27485] urllib.splitport -- is it official or not?

Change by Serhiy Storchaka : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list

[issue27485] urllib.splitport -- is it official or not?

Serhiy Storchaka added the comment: New changeset 867b825830b9b0baff791c9bcda57bba3809722a by Serhiy Storchaka (Cheryl Sabella) in branch 'master': bpo-27485: Change urlparse tests to use private methods. (GH-7070)

[issue27485] urllib.splitport -- is it official or not?

Change by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___

[issue27485] urllib.splitport -- is it official or not?

Cheryl Sabella added the comment: Serhiy, Thanks for finding this. I've submitted a PR to fix the tests. -- ___ Python tracker

[issue27485] urllib.splitport -- is it official or not?

Change by Cheryl Sabella : -- keywords: +patch pull_requests: +6699 stage: resolved -> patch review ___ Python tracker ___

[issue27485] urllib.splitport -- is it official or not?

Serhiy Storchaka added the comment: This change made test_urlparse failing when ran with -We. Or just producing a lot of warnings in the default mode. == ERROR: test_splitattr

[issue27485] urllib.splitport -- is it official or not?

Łukasz Langa added the comment: Thanks! This is now fixed for Python 3.8 \o/ -- resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.8 -Python 2.7, Python 3.5, Python 3.6 ___ Python tracker

[issue27485] urllib.splitport -- is it official or not?

Łukasz Langa added the comment: New changeset 0250de48199552cdaed5a4fe44b3f9cdb5325363 by Łukasz Langa (Cheryl Sabella) in branch 'master': bpo-27485: Rename and deprecate undocumented functions in urllib.parse (GH-2205)

[issue27485] urllib.splitport -- is it official or not?

Cheryl Sabella added the comment: Martin, thank you for the information and for pointing out those other related issues. It makes sense to separate the security or bug issues from this change. -- ___ Python tracker

[issue27485] urllib.splitport -- is it official or not?

Changes by Cheryl Sabella : -- pull_requests: +2249 ___ Python tracker ___ ___

[issue27485] urllib.splitport -- is it official or not?

Martin Panter added the comment: I don't think it is worth changing the implementations to be in terms of urlsplit or urlparse. This is proposed for splithost in , but I suspect it would change the behaviour in some corner cases. See Issue 22852

[issue27485] urllib.splitport -- is it official or not?

Cheryl Sabella added the comment: Thank you. >From my understanding, urllib didn't officially supported the split* functions >(splittype, splithost, splitport, splinport, splituser, splitpasswd, >splitattr, splitquery, splitvalue, splittag) even though they were migrated to >urllib.parse.

[issue27485] urllib.splitport -- is it official or not?

Brett Cannon added the comment: Go for it, Cheryl! -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue27485] urllib.splitport -- is it official or not?

Guido van Rossum added the comment: Skimming the issue I can't even figure out what the task is -- Cheryl, I suppose you have, could you post a brief summary of your plan here? -- ___ Python tracker

[issue27485] urllib.splitport -- is it official or not?

Cheryl Sabella added the comment: Would it be OK for me to work on this? -- nosy: +csabella ___ Python tracker ___

[issue27485] urllib.splitport -- is it official or not?

Senthil Kumaran added the comment: I think that we use encourage everyone to use the higher level functions like urlparse() or urlsplit() and then get the .port from the named tuple result. Two things to do. 1. Update that Note the documentation which states a false statement that those

[issue27485] urllib.splitport -- is it official or not?

Brett Cannon added the comment: Probably a rename is good. Question then becomes whether the old names should raise an DeprecationWarning for a release? -- nosy: +brett.cannon ___ Python tracker

[issue27485] urllib.splitport -- is it official or not?

Guido van Rossum added the comment: Aha. I see you are referring to this note in the 2.7 docs for urllib: urllib also exposes certain utility functions like splittype, splithost and others parsing URL into various components. But it is recommended to use :mod:`urlparse` for parsing

[issue27485] urllib.splitport -- is it official or not?

Martin Panter added the comment: Previous discussion: Issue 1722, Issue 11009. In Python 2, most of the split- functions _have_ been in urllib.__all__ since revision 5d68afc5227c (2.1). Also, since revision c3656dca65e7 (Issue 1722, 2.7.4), the RST documentation does mention that at least

[issue27485] urllib.splitport -- is it official or not?

Serhiy Storchaka added the comment: splitport() doesn't work with IPv6 ("[::1]", see issue18191), nor with authority ("user:passw...@example.com"). Note that there is a almost duplicate function splitnport(). The existence of two similar functions that behave differently in corner cases looks

[issue27485] urllib.splitport -- is it official or not?

New submission from Guido van Rossum: I've seen and written some code that uses urllib.splitport() [1], but it's not in the export list, nor in the docs. However I see no easy other way to perform the same function. Should we make it official, or get rid of it? It's used internally in