[issue32232] building extensions as builtins is broken in 3.7

Nick Coghlan added the comment: Xavier's changes should fix the reported compile error, while keeping the increased isolation of the interpreter core from the optional extension modules. If the latter change causes a detectable performance regression, then I think that

[issue32232] building extensions as builtins is broken in 3.7

miss-islington added the comment: New changeset 18cd82815b9bdeabc5ac03aa7f58102109ccf368 by Miss Islington (bot) in branch '3.7': bpo-32232: by default, Setup modules are no longer built with -DPy_BUILD_CORE (GH-6489)

[issue32232] building extensions as builtins is broken in 3.7

Change by miss-islington : -- pull_requests: +6244 ___ Python tracker ___

[issue32232] building extensions as builtins is broken in 3.7

Nick Coghlan added the comment: New changeset 063db62aab4041ac47798e7e48b27b2f2bef21c5 by Nick Coghlan (xdegaye) in branch 'master': bpo-32232: by default, Setup modules are no longer built with -DPy_BUILD_CORE (GH-6489)

[issue32232] building extensions as builtins is broken in 3.7

Nick Coghlan added the comment: I also resolved my own puzzlement from the PR comments regarding why _weakrefs.c was fine with being built as a regular extension module: it's because the C level access API for __weakrefs__ is published through the regular C API, not as a

[issue32232] building extensions as builtins is broken in 3.7

Xavier de Gaye added the comment: To answer my own comment in PR 6489 about the interference of the pyconfig.h macros with the build of std lib extension modules, the py_config_macros.py script prints the list of pyconfig.h.in macros that are being used by the standard

[issue32232] building extensions as builtins is broken in 3.7

Nick Coghlan added the comment: Ah, oops - I commented before fully catching up on everything else, and now I see that Xavier already made exactly that point just above. I'll go review the PR now :) -- ___ Python tracker

[issue32232] building extensions as builtins is broken in 3.7

Nick Coghlan added the comment: Even when statically linked, extension modules should *NOT* be getting built with `-DPy_BUILD_CORE`. That preprocessor definition is for CPython core core only, and we moved the headers to help make that 100% crystal clear. --

[issue32232] building extensions as builtins is broken in 3.7

Ned Deily added the comment: Thanks, Xavier, for your analysis and your PR! We definitely meed to get this resolved before 3.7.0b4. Given the complexity and potential impact on this area and that we are approaching the final beta, I think we need a few pairs of eyes to

[issue32232] building extensions as builtins is broken in 3.7

Xavier de Gaye added the comment: The compilation failure is a consequence of the changes made in issue 30860. Simply adding '#include "internal/pystate.h"' in Modules/_elementtree.c fixes the compilation although this is not the correct fix. The modules configured in

[issue32232] building extensions as builtins is broken in 3.7

Change by Xavier de Gaye : -- pull_requests: +6188 ___ Python tracker ___ ___

[issue32232] building extensions as builtins is broken in 3.7

Ned Deily added the comment: Thanks Pablo for taking up the challenge! I just took a quick look at the current state of PR 5256 and I noted numerous issues that need to be addressed with the test. I don't have time at the moment to review the non-test changes. It would be

[issue32232] building extensions as builtins is broken in 3.7

Pablo Galindo Salgado added the comment: It seems that Microsoft compiler does not handle well the circular dependencies between Include/pystate.h and Include/internal/pystate.h so I have included guards for Windows in the new include for Include/pystate.h and deactivated

[issue32232] building extensions as builtins is broken in 3.7

Pablo Galindo Salgado added the comment: I have put together a PR with Matthias' patch and a test. -- nosy: +pablogsal ___ Python tracker

[issue32232] building extensions as builtins is broken in 3.7

Change by Pablo Galindo Salgado : -- pull_requests: +5103 stage: -> patch review ___ Python tracker ___

[issue32232] building extensions as builtins is broken in 3.7

Ned Deily added the comment: Can someone provide a pull request and a test for this prior to beta 1? -- ___ Python tracker ___

[issue32232] building extensions as builtins is broken in 3.7

Change by Ned Deily : -- nosy: +ned.deily priority: normal -> release blocker ___ Python tracker ___

[issue32232] building extensions as builtins is broken in 3.7

Matthias Klose added the comment: that patch lets the build succeed. two additional includes and a little bit of shuffling -- keywords: +patch Added file: https://bugs.python.org/file47325/ext-as-builtins.diff ___ Python tracker

[issue32232] building extensions as builtins is broken in 3.7

Change by STINNER Victor : -- nosy: +eric.snow, ncoghlan ___ Python tracker ___

[issue32232] building extensions as builtins is broken in 3.7

New submission from Matthias Klose : building extensions statically in linking these into the python binary is currently broken on 3.7. I'm attaching the change that worked for me in 3.7alpha2, but doesn't work anymore with alpha3. Currently investigating. When building