[issue33533] Provide an async-generator version of as_completed

2020-10-02 Thread Justin Arthur
Justin Arthur added the comment: Thanks, Hrvoje. I've updated the patch to match this bug's suggested format and have updated the documentation and What's New. The one quirk that comes with the benefit of getting the same futures back is that we still allow both coroutines and futures to be

[issue33533] Provide an async-generator version of as_completed

2020-10-02 Thread Hrvoje Nikšić
Hrvoje Nikšić added the comment: Hi, thanks for providing a PR. One thing I noticed is that the implementation in the PR yields results of the futures from the generator. This issue proposes a generator that instead yields the futures passed to as_completed. This is needed not just for

[issue33533] Provide an async-generator version of as_completed

2020-10-01 Thread Justin Arthur
Justin Arthur added the comment: I've added a new PR, PR 22491. This one has as_completed returning an iterator and includes tests for both the old and new style. I see a trivial amount of latency added in extra call stack over Guido's original implementation. Should we decide to deprecate

[issue33533] Provide an async-generator version of as_completed

2020-10-01 Thread Justin Arthur
Change by Justin Arthur : -- nosy: +JustinTArthur nosy_count: 5.0 -> 6.0 pull_requests: +21508 pull_request: https://github.com/python/cpython/pull/22491 ___ Python tracker

[issue33533] Provide an async-generator version of as_completed

2019-04-05 Thread Roman Evstifeev
Change by Roman Evstifeev : -- nosy: +Roman.Evstifeev ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33533] Provide an async-generator version of as_completed

2018-10-30 Thread Michael DePalatis
Change by Michael DePalatis : -- keywords: +patch pull_requests: +9565 stage: -> patch review ___ Python tracker ___ ___

[issue33533] Provide an async-generator version of as_completed

2018-10-26 Thread Hrvoje Nikšić
Hrvoje Nikšić added the comment: I didn't start working on the PR, so please go ahead if you're interested. One small suggestion: If you're implementing this, please note that the proof-of-concept implementation shown in the description is not very efficient because each call to `wait` has

[issue33533] Provide an async-generator version of as_completed

2018-10-25 Thread Michael DePalatis
Michael DePalatis added the comment: Is there any progress on this? I was thinking the exact same thing regarding the backwards-compatible approach and would like to work on it if no one else is. -- nosy: +mivade ___ Python tracker

[issue33533] Provide an async-generator version of as_completed

2018-09-30 Thread Hrvoje Nikšić
Hrvoje Nikšić added the comment: If there is interest in this, I'd like to attempt a PR for a sync/async variant of as_completed. Note that the new docs are *much* clearer, so the first (documentation) problem from the description is now fixed. Although the documentation is still brief, it

[issue33533] Provide an async-generator version of as_completed

2018-05-21 Thread Hrvoje Nikšić
Hrvoje Nikšić added the comment: Another option occurred to me: as_completed could return an object that implements both synchronous and asynchronous iteration protocol: class as_completed: def __init__(fs, *, loop=None, timeout=None): self.__fs = fs

[issue33533] Provide an async-generator version of as_completed

2018-05-17 Thread Yury Selivanov
Yury Selivanov added the comment: I like the idea. Let's revisit it after Python 3.7 is released. -- ___ Python tracker ___

[issue33533] Provide an async-generator version of as_completed

2018-05-16 Thread Hrvoje Nikšić
Change by Hrvoje Nikšić : -- type: -> enhancement ___ Python tracker ___ ___

[issue33533] Provide an async-generator version of as_completed

2018-05-16 Thread Hrvoje Nikšić
Hrvoje Nikšić added the comment: Of course, `yield from done` would actually have to be `for future in done: yield future`, since async generators don't support yield from. -- ___ Python tracker

[issue33533] Provide an async-generator version of as_completed

2018-05-16 Thread Hrvoje Nikšić
New submission from Hrvoje Nikšić : Judging by questions on the StackOverflow python-asyncio tag[1][2], it seems that users find it hard to understand how to use as_completed correctly. I have identified three issues: * It's somewhat sparingly documented. A StackOverflow