[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

STINNER Victor added the comment: Thanks everybody for your help. It is now documented. -- ___ Python tracker ___ ___

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

STINNER Victor added the comment: Ned Deily: > My preference remains to not make the flags change at all Well, "m" in ABI flags became useless around Python 3.4. I don't see the point of pretending that the "m" ABI is different and then provide two names for the same thing: python3.8

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

miss-islington added the comment: New changeset 3fde750cc4e4057076650a92946ec1d492464799 by Miss Islington (bot) in branch '3.8': bpo-36707: Document "m" removal from sys.abiflags (GH-14090) https://github.com/python/cpython/commit/3fde750cc4e4057076650a92946ec1d492464799 -- nosy:

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

Change by miss-islington : -- pull_requests: +13953 pull_request: https://github.com/python/cpython/pull/14097 ___ Python tracker ___

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

STINNER Victor added the comment: New changeset 7efc526e5cfb929a79c192ac2dcf7eb78d3a4401 by Victor Stinner in branch 'master': bpo-36707: Document "m" removal from sys.abiflags (GH-14090) https://github.com/python/cpython/commit/7efc526e5cfb929a79c192ac2dcf7eb78d3a4401 --

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

Change by STINNER Victor : -- pull_requests: +13946 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/14090 ___ Python tracker ___

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

Kubilay Kocak added the comment: Those script names would already have code to handle name changes based on existing abiflags/soabi string (as FreeBSD does), and would be trivial to modify for 'm' removal. For third party stuff: we use setuptools --record for 'everything', so as long as

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

Ned Deily added the comment: Another user-visible difference: $ ls /tmp/py37/bin/python* /tmp/py37/bin/python3/tmp/py37/bin/python3.7-config /tmp/py37/bin/python3.7m-config /tmp/py37/bin/python3.7 /tmp/py37/bin/python3.7m /tmp/py37/bin/python3-config $ ls /tmp/py38/bin/python*

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

Ned Deily added the comment: > One question I have is, can/does SOABI flag removal affect any third party > package/extension builds in any way, particularly affecting the names of > files they produce? Yep, the default file names of C extension modules differ on most/all? Unix-y platforms

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

Kubilay Kocak added the comment: For FreeBSD Python language ports, the change doesn't have a big negative impact for the Python language/interpreter ports themselves We have the following block in lang/python3? ports: .if ${PORT_OPTIONS:MPYMALLOC} ABIFLAGS:= m${ABIFLAGS} .endif .if

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

Miro Hrončok added the comment: I'm not sure either. So far most affected buildscripts are confused by: /usr/include/python3.Xm -> /usr/include/python3.X /usr/lib64/libpython3.Xm -> /usr/lib64/libpython3.X extension.cpython-3Xm-arch-linux-gnu.so -> extension.cpython-3X-arch-linux-gnu.so

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

STINNER Victor added the comment: > It's usually just custom ugly-hardcoded autotools/cmake. Nothing severe > enough. However, this change still is not documented anywhere in > https://docs.python.org/dev/whatsnew/3.8.html I concur that it should be documented. It's on my TODO list. But

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

Miro Hrončok added the comment: It's usually just custom ugly-hardcoded autotools/cmake. Nothing severe enough. However, this change still is not documented anywhere in https://docs.python.org/dev/whatsnew/3.8.html -- ___ Python tracker

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

Miro Hrončok added the comment: > But the impact of the change should probably also be discussed with at least > some of the large distributors. Adapting the Fedora package. Will try to mass rebuild our packages to see what breaks. -- nosy: +hroncok

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

STINNER Victor added the comment: > No, you didn't document all the changed file names, See, for instance, > /usr/bin/python3* for a start :) Oh, I see. I was thinking at something else. First I proposed to drop the "d" from the SOABI for debug build, but then I changed my mind. So yeah, I

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

Ned Deily added the comment: No, you didn't document all the changed file names, See, for instance, /usr/bin/python3* for a start :) -- ___ Python tracker ___

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

STINNER Victor added the comment: About the PEP, I asked Barry to review the change and he approved it. About the doc, I didn't know that anyone rely on the exact filename. I documented all changes in a top-level section of the What's New in Python 3.8:

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

Change by Ned Deily : -- assignee: -> vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

Ned Deily added the comment: This change has an impact on downstream packagers and users of Python 3.8 because the SOABI flag values are also used to construct a number of file names and directories names in an Unix or macOS framework install besides the extension module (*.so) file names.

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

STINNER Victor added the comment: New changeset 6c44fde3e03079e0c69f823dafbe04af50b5bd0d by Victor Stinner in branch 'master': bpo-36707: Remove the "m" flag (pymalloc) from SOABI (GH-12931) https://github.com/python/cpython/commit/6c44fde3e03079e0c69f823dafbe04af50b5bd0d --

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

Change by STINNER Victor : -- components: +Build resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

Change by Kubilay Kocak : -- nosy: +koobs ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

STINNER Victor added the comment: pymalloc is enabled by default. --without-pymalloc allows to build Python without pymalloc and use malloc by default. -- ___ Python tracker

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

Serhiy Storchaka added the comment: If --with-pymalloc does not impact the API, why we need this option? -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

STINNER Victor added the comment: I modified PyObject_MALLOC and other macros when I implemented the PEP 445 "Add new APIs to customize Python memory allocators": https://www.python.org/dev/peps/pep-0445/ ABI tags are defined by the PEP 3149:

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

Change by STINNER Victor : -- keywords: +patch pull_requests: +12856 stage: -> patch review ___ Python tracker ___ ___

[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

New submission from STINNER Victor : In Python 2.7, the WITH_PYMALLOC define (defined by ./configure --with-pymalloc which is the default) modified the Python API. For example, PyObject_MALLOC() is a macro replaced with PyObject_Malloc() with pymalloc but replaced with PyMem_MALLOC() without