[issue38673] REPL shows continuation prompt (...) when comment or space entered

Guido van Rossum added the comment: (And I'm giving up on 3.6 and 2.7 as these are close to their end of life.) -- ___ Python tracker ___

[issue38673] REPL shows continuation prompt (...) when comment or space entered

Change by Guido van Rossum : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38673] REPL shows continuation prompt (...) when comment or space entered

Guido van Rossum added the comment: Ned agreed, it's merged into 3.7, so let's close. -- ___ Python tracker ___ ___

[issue38673] REPL shows continuation prompt (...) when comment or space entered

Ned Deily added the comment: New changeset 188d5ae6f047342f3d6860646ccf1a523ef8b0ed by Ned Deily (Miss Islington (bot)) in branch '3.7': bpo-38673: dont switch to ps2 if the line starts with comment or whitespace (GH-17421) (GH-17522)

[issue38673] REPL shows continuation prompt (...) when comment or space entered

Change by miss-islington : -- pull_requests: +17000 pull_request: https://github.com/python/cpython/pull/17522 ___ Python tracker ___

[issue38673] REPL shows continuation prompt (...) when comment or space entered

Terry J. Reedy added the comment: I would prefer that. I think treating '\n' and ' \n' differently is a bit of a bug. And the fix pretty well matches code/codeop behavior. I have so far not imagined how it could break code.But you could let Ned Deily decide, before the next rc, if

[issue38673] REPL shows continuation prompt (...) when comment or space entered

Guido van Rossum added the comment: So 3.8.1 got backported by Miss Islington. Do we want this in earlier releases? -- ___ Python tracker ___

[issue38673] REPL shows continuation prompt (...) when comment or space entered

miss-islington added the comment: New changeset 184a3812b81e2f7d4bc6453bf7ceabe8ac590202 by Miss Islington (bot) in branch '3.8': bpo-38673: dont switch to ps2 if the line starts with comment or whitespace (GH-17421)

[issue38673] REPL shows continuation prompt (...) when comment or space entered

Change by miss-islington : -- pull_requests: +16993 pull_request: https://github.com/python/cpython/pull/17516 ___ Python tracker ___

[issue38673] REPL shows continuation prompt (...) when comment or space entered

Guido van Rossum added the comment: I'd like to backport this to 3.8.1 at least. Are people interested in getting it backported to earlier versions? -- ___ Python tracker

[issue38673] REPL shows continuation prompt (...) when comment or space entered

miss-islington added the comment: New changeset 109fc2792a490ee5cd8a423e17d415fbdedec5c8 by Miss Islington (bot) (Batuhan Taşkaya) in branch 'master': bpo-38673: dont switch to ps2 if the line starts with comment or whitespace (GH-17421)

[issue38673] REPL shows continuation prompt (...) when comment or space entered

Change by Batuhan : -- keywords: +patch pull_requests: +16902 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17421 ___ Python tracker ___

[issue38673] REPL shows continuation prompt (...) when comment or space entered

Guido van Rossum added the comment: > But is the 'fix' in _maybe_compile at all applicable to the REPL? Or might a > parser change REPL fix make the code in _maybe_compile unneeded? I don't know. Most of the contortions in code.py codeop.py are meant to emulate what the parser does

[issue38673] REPL shows continuation prompt (...) when comment or space entered

Terry J. Reedy added the comment: Fix corner case bugs in IDLE would definitely be a separate issue. But is the 'fix' in _maybe_compile at all applicable to the REPL? Or might a parser change REPL fix make the code in _maybe_compile unneeded? --

[issue38673] REPL shows continuation prompt (...) when comment or space entered

Guido van Rossum added the comment: Regarding the IDLE mystery, *if* there's a difference between how it treats " # a" and "# a", this must be due to some part of the code that's invoked before _maybe_compile() is called, right? But that's immaterial to this bug -- I'm only complaining

[issue38673] REPL shows continuation prompt (...) when comment or space entered

Terry J. Reedy added the comment: Entering 'pass' or a completely blank line results in a new primary prompt, at least on Windows. The Windows REPL otherwise prints ... even for effectively blank lines. IDLE usually prints a new prompt for effectively blank lines. >>> >>> #a >>> # a >>>

[issue38673] REPL shows continuation prompt (...) when comment or space entered

Guido van Rossum added the comment: Yes, that's likely where the change should be made. I think if the *first* token encountered is either NL or COMMENT the parse should be abandoned by the tokenizer. -- ___ Python tracker

[issue38673] REPL shows continuation prompt (...) when comment or space entered

Anders Lorentsen added the comment: As a person without much experience, it sounded like a simple enough task, but having dug a bit, I found it quite complicated. It seems to me that the interpreter loop (in the standard REPL, that you get when you start ./python, blocks for input somewhere

[issue38673] REPL shows continuation prompt (...) when comment or space entered

New submission from Guido van Rossum : This has always bothered me, and it shouldn't be necessary. This session: >>> #foo ... >>> should really have been >>> #foo >>> It's confusing that the REPL prompt switches to "..." here, for no good reason. It should just treat the line as empty.