[issue45548] Update Modules/Setup

Christian Heimes added the comment: Erlend and I have split off the pkg-config and autoconf work into bpo-45847, bpo-45573, and others. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue45548] Update Modules/Setup

Brett Cannon added the comment: @christian are you using this issue for your pkg-config work, or should I close this? -- ___ Python tracker ___

[issue45548] Update Modules/Setup

Christian Heimes added the comment: New changeset f0150ac94a85c863ec1dcb58b9e33ed7ce465ec8 by Christian Heimes in branch 'main': bpo-45548: Some test modules must be built as shared libs (GH-29268) https://github.com/python/cpython/commit/f0150ac94a85c863ec1dcb58b9e33ed7ce465ec8 --

[issue45548] Update Modules/Setup

Marc-Andre Lemburg added the comment: On 27.10.2021 22:58, Brett Cannon wrote: > > Brett Cannon added the comment: > >> Could Brett or you please add those notes back ? There's no other place > where such details are documented. > > It really depends on what "details" you're referring to.

[issue45548] Update Modules/Setup

Change by Christian Heimes : -- pull_requests: +27531 pull_request: https://github.com/python/cpython/pull/29268 ___ Python tracker ___

[issue45548] Update Modules/Setup

Christian Heimes added the comment: New changeset 4c95fb4640c0247903562dae4478158b348cea6d by Christian Heimes in branch 'main': bpo-45548: Fix out-of-tree and Debian builds (GH-29263) https://github.com/python/cpython/commit/4c95fb4640c0247903562dae4478158b348cea6d --

[issue45548] Update Modules/Setup

Change by Christian Heimes : -- pull_requests: +27528 pull_request: https://github.com/python/cpython/pull/29263 ___ Python tracker ___

[issue45548] Update Modules/Setup

Brett Cannon added the comment: > Could Brett or you please add those notes back ? There's no other place where such details are documented. It really depends on what "details" you're referring to. Most of what I removed were things like "Module by ", or saying _json.c is for "json

[issue45548] Update Modules/Setup

Anthony Sottile added the comment: I'm seeing some weird breakage in the deadsnakes builds, presumably due to this change: ``` ... 2021-10-27T08:55:21.9485959Z x86_64-linux-gnu-gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -g -fdebug-prefix-map=/tmp/code=.

[issue45548] Update Modules/Setup

Marc-Andre Lemburg added the comment: On 26.10.2021 20:47, Marc-Andre Lemburg wrote: >> Brett removed a lot of stuff in 01cf4fb9c1aa567484c2ffb1b11f9b3fe9949b05 to >> make the file more readable. I removed unnecessary -D, -I, and -L to make >> the file even more readable. You can pass custom

[issue45548] Update Modules/Setup

Marc-Andre Lemburg added the comment: On 26.10.2021 19:42, Christian Heimes wrote: > > Brett removed a lot of stuff in 01cf4fb9c1aa567484c2ffb1b11f9b3fe9949b05 to > make the file more readable. I removed unnecessary -D, -I, and -L to make the > file even more readable. You can pass custom

[issue45548] Update Modules/Setup

Christian Heimes added the comment: Brett removed a lot of stuff in 01cf4fb9c1aa567484c2ffb1b11f9b3fe9949b05 to make the file more readable. I removed unnecessary -D, -I, and -L to make the file even more readable. You can pass custom flags to ./configure. Setup should not be edited by

[issue45548] Update Modules/Setup

Marc-Andre Lemburg added the comment: On 26.10.2021 16:17, Christian Heimes wrote: > > Christian Heimes added the comment: > > Brett, we can use AM_CONDITIONAL() to conditionally enable/disable a feature > and AC_CONFIG_FILES() to create a Modules/Setup from a template: > > Example: > >

[issue45548] Update Modules/Setup

Christian Heimes added the comment: Typo, the last line should read "@HAVE_SCPROXY_FALSE@_scproxy" -- ___ Python tracker ___ ___

[issue45548] Update Modules/Setup

Christian Heimes added the comment: Brett, we can use AM_CONDITIONAL() to conditionally enable/disable a feature and AC_CONFIG_FILES() to create a Modules/Setup from a template: Example: The conditional AM_CONDITIONAL([HAVE_SCPROXY], [test "$ac_sys_system" = "Darwin"]) sets

[issue45548] Update Modules/Setup

Christian Heimes added the comment: New changeset b5ee79494b2e0d484b7cf59f6746010e22567702 by Christian Heimes in branch 'main': bpo-45548: makesetup improvements (GH-29225) https://github.com/python/cpython/commit/b5ee79494b2e0d484b7cf59f6746010e22567702 --

[issue45548] Update Modules/Setup

Change by Christian Heimes : -- pull_requests: +27489 pull_request: https://github.com/python/cpython/pull/29225 ___ Python tracker ___

[issue45548] Update Modules/Setup

Christian Heimes added the comment: New changeset 2b8677a3cd855eb3a579894c64588eab0e006269 by Christian Heimes in branch 'main': bpo-45548: FreeBSD doesn't like auto vars in makesetup (GH-29216) https://github.com/python/cpython/commit/2b8677a3cd855eb3a579894c64588eab0e006269 --

[issue45548] Update Modules/Setup

Change by Christian Heimes : -- pull_requests: +27478 pull_request: https://github.com/python/cpython/pull/29216 ___ Python tracker ___

[issue45548] Update Modules/Setup

Christian Heimes added the comment: New changeset ece916e92ce76cfdbfd208605a6fc827db0fbd52 by Christian Heimes in branch 'main': bpo-45548: Add missing extensions to Modules/Setup (GH-29199) https://github.com/python/cpython/commit/ece916e92ce76cfdbfd208605a6fc827db0fbd52 --

[issue45548] Update Modules/Setup

Christian Heimes added the comment: New changeset 77e3f224d6ae6d38e5fc899fb5eaadf2b7c255a1 by Christian Heimes in branch 'main': bpo-45548: Remove checks for finite and gamma (GH-29206) https://github.com/python/cpython/commit/77e3f224d6ae6d38e5fc899fb5eaadf2b7c255a1 --

[issue45548] Update Modules/Setup

Change by Christian Heimes : -- pull_requests: +27474 pull_request: https://github.com/python/cpython/pull/29206 ___ Python tracker ___

[issue45548] Update Modules/Setup

miss-islington added the comment: New changeset fa26245a1c1aa938cce391348d6bd879da357522 by Christian Heimes in branch 'main': bpo-45548: Remove _math.c workarounds for pre-C99 libm (GH-29179) https://github.com/python/cpython/commit/fa26245a1c1aa938cce391348d6bd879da357522 --

[issue45548] Update Modules/Setup

Change by Christian Heimes : -- pull_requests: +27468 pull_request: https://github.com/python/cpython/pull/29199 ___ Python tracker ___

[issue45548] Update Modules/Setup

Marc-Andre Lemburg added the comment: On 23.10.2021 21:30, Christian Heimes wrote: > > The trick would move the math function back into the core. Mark moved the > math functions out of the core on purpose, see bpo-7518. I don't follow you. With the _math.o target in Makefile.pre.in, _math.c

[issue45548] Update Modules/Setup

Christian Heimes added the comment: The trick would move the math function back into the core. Mark moved the math functions out of the core on purpose, see bpo-7518. -- ___ Python tracker

[issue45548] Update Modules/Setup

Marc-Andre Lemburg added the comment: On 23.10.2021 20:04, Christian Heimes wrote: > > PR GH-29179 or GH-29181 address the issue with _math.o I think those patches are both taking things a bit too far. This is a build problem, not a code problem. It's perfectly good style to link a single

[issue45548] Update Modules/Setup

Marc-Andre Lemburg added the comment: I'm using a very simple conditional logic in Setup, which is based on sed, mostly to add platform specific variables: In Setup: # @if macosx: TIME_DEFS= # @if not macosx: TIME_DEFS=-lrt time -DPy_BUILD_CORE_BUILTIN -I$(srcdir)/Include/internal

[issue45548] Update Modules/Setup

Christian Heimes added the comment: PR GH-29179 or GH-29181 address the issue with _math.o PR GH-29164 adds the missing modules and also introduces pkg-config lookups for dependencies. Brett and I discussed that we have to introduce conditionals to Modules/Setup to make use of the

[issue45548] Update Modules/Setup

Marc-Andre Lemburg added the comment: FYI: I've been working with a fixed Setup file in PyRun for a long while. There are indeed a number of modules missing from Setup, since the whole logic was left behind a bit after things moved to setup.py. The issue with _math.o is actually in the main

[issue45548] Update Modules/Setup

Change by Christian Heimes : -- pull_requests: +27459 pull_request: https://github.com/python/cpython/pull/29188 ___ Python tracker ___

[issue45548] Update Modules/Setup

Christian Heimes added the comment: I ran into another problem. In shared mode, Modules/Setup places the shared modules in ./Modules/ instead of the build directory ./build/lib.something/. The ./Modules/ directory is not on sys.path. getpath.c only adds the build dir to sys.path. It takes

[issue45548] Update Modules/Setup

Change by Brett Cannon : -- pull_requests: +27455 pull_request: https://github.com/python/cpython/pull/29181 ___ Python tracker ___

[issue45548] Update Modules/Setup

Change by Christian Heimes : -- pull_requests: +27453 pull_request: https://github.com/python/cpython/pull/29179 ___ Python tracker ___

[issue45548] Update Modules/Setup

Change by Brett Cannon : -- pull_requests: +27450 pull_request: https://github.com/python/cpython/pull/29177 ___ Python tracker ___

[issue45548] Update Modules/Setup

Christian Heimes added the comment: I added several missing module definitions in https://github.com/python/cpython/pull/29164 math/cmath conflict when _math.c is included twice. -- ___ Python tracker

[issue45548] Update Modules/Setup

Brett Cannon added the comment: New changeset 01cf4fb9c1aa567484c2ffb1b11f9b3fe9949b05 by Brett Cannon in branch 'main': bpo-45548: Make `Modules/Setup` easier to read (GH-29143) https://github.com/python/cpython/commit/01cf4fb9c1aa567484c2ffb1b11f9b3fe9949b05 --

[issue45548] Update Modules/Setup

Change by Brett Cannon : -- pull_requests: +27419 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29143 ___ Python tracker ___

[issue45548] Update Modules/Setup

Christian Heimes added the comment: I started https://github.com/python/cpython/compare/main...tiran:configure_pkgconfig?expand=1 to integrate pkg-config with configure. The patchset also contains examples how to pass flags from configure into Makefile and Modules/Setup. -- nosy:

[issue45548] Update Modules/Setup

Change by Ned Deily : -- nosy: +ned.deily ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45548] Update Modules/Setup

Change by Zachary Ware : -- nosy: +zach.ware stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue45548] Update Modules/Setup

Change by Zachary Ware : -- stage: patch review -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45548] Update Modules/Setup

Brett Cannon added the comment: Status is now: - math/cmath conflict with a build rule in Makefile.pre.in - _dbm needs more logic/comments (at least on macOS) - nis needs more logic/comments (at least on macOS) And the following modules are completely missing from the file: - _bz2 - _ctypes

[issue45548] Update Modules/Setup

miss-islington added the comment: New changeset dd86f63b551c8c255c6d8082c02f35608d294db9 by Brett Cannon in branch 'main': bpo-45548: add some missing entries to `Modules/Setup` (GH-29115) https://github.com/python/cpython/commit/dd86f63b551c8c255c6d8082c02f35608d294db9 -- nosy:

[issue45548] Update Modules/Setup

Change by Brett Cannon : -- keywords: +patch pull_requests: +27391 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29115 ___ Python tracker ___

[issue45548] Update Modules/Setup

New submission from Brett Cannon : `Modules/Setup` is currently incomplete/broken. Some things are completely missing from it, while others won't work if you uncomment them in the file. When trying to compile a completely static CPython interpreter I ran into the following issues: -