Ezio Melotti added the comment:
I'm going to close this as fixed then.
If other people report problems I can always apply the patch and/or try to
figure out something else.
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
Serhiy Storchaka added the comment:
I don't notice any improvement. :(
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4965
___
___
Roundup Robot added the comment:
New changeset d7ebe03fa752 by Ezio Melotti in branch '2.7':
#4965: Implement intelligent scrolling of the sidebar in the docs.
http://hg.python.org/cpython/rev/d7ebe03fa752
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Could you please make a scrolling more smooth? Or at least optional.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4965
___
Ezio Melotti added the comment:
I've looked into it, and I found that:
1) the scroll event can be triggered dozens of times per second;
2) sidebarwrapper.css(...) causes a browser repaint/reflow, which is slow;
Optimizing the function doesn't seem like a good solution, so I tried to
throttle
Georg Brandl added the comment:
Very nice, thanks for porting this. One minor nit: when I close the sidebar,
then scroll and then reopen it, it does not immediately update the sidebar
position, only when scrolling again.
--
___
Python tracker
Georg Brandl added the comment:
You said you made it a bit more efficient; is this python-specific or can it be
ported back to Sphinx?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4965
Ezio Melotti added the comment:
One minor nit: when I close the sidebar, then scroll and then reopen
it, it does not immediately update the sidebar position, only when
scrolling again.
I'll look into it.
You said you made it a bit more efficient; is this python-specific
or can it be
Ezio Melotti added the comment:
Updated patch should fix the nit and factors out $(document) from the scrolling
function. Tested on Firefox and Chromium.
--
Added file: http://bugs.python.org/file32098/issue4965-3.diff
___
Python tracker
Georg Brandl added the comment:
LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4965
___
___
Python-bugs-list mailing list
Unsubscribe:
Roundup Robot added the comment:
New changeset 3bb34d370871 by Ezio Melotti in branch '3.3':
#4965: Implement intelligent scrolling of the sidebar in the docs.
http://hg.python.org/cpython/rev/3bb34d370871
New changeset 8d916ea12efb by Ezio Melotti in branch 'default':
#4965: merge with 3.3.
Ezio Melotti added the comment:
I committed the patch on 3.3/3.x. I'm willing to port the patch on 2.7 too,
however sidebar.js is not in Doc/tools/sphinxext/static/ but in
Doc/tools/sphinx/themes/default/static/, which is not under version control.
How do you suggest to proceed?
--
Georg Brandl added the comment:
You'll have to put a copy in sphinxext/static.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4965
___
___
Georg Brandl added the comment:
See http://sphinx-doc.org/latest/ for my preferred solution.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4965
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
Added file: http://bugs.python.org/file32072/issue4965-2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4965
___
Ezio Melotti added the comment:
I stole the code from that page and adapted it to integrate better with
sidebar.js (and make it a bit more efficient).
To test the new patch, in the root of the clone, with the doc already built in
Doc/build (no need to rebuild it), do:
hg import --no-c
Ned Deily added the comment:
The patch seems to work well with both Safari 6.0.5 and Firefox 25.0 on OS X
10.8. Nice improvement.
--
nosy: +ned.deily
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4965
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
versions: +Python 3.4 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4965
___
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
keywords: +easy
stage: - patch review
versions: -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4965
___
Ezio Melotti added the comment:
In the root of the clone, with the doc already built in Doc/build (no need to
rebuild it), do:
hg import --no-c http://bugs.python.org/file27887/issue4965.diff
cp Doc/tools/sphinxext/static/basic.css Doc/build/html/_static/basic.css
firefox
Ezio Melotti added the comment:
The attached patch makes the sidebar fixed and adds a scrollbar to scroll it
separately when it's longer than the page.
To test the patch without rebuilding all the Docs you can do something like:
hg import --no-c url-of-the-patch
cp
Changes by Terry J. Reedy tjre...@udel.edu:
--
versions: -Python 2.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4965
___
___
Python-bugs-list
Changes by Terry J. Reedy tjre...@udel.edu:
--
versions: +Python 3.2 -Python 3.0
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4965
___
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
assignee: georg.brandl - ezio.melotti
priority: - normal
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4965
___
Ezio Melotti ezio.melo...@gmail.com added the comment:
See also #3143.
I'll try to do a proper patch to fix this issue.
--
assignee: georg.brandl - ezio.melotti
stage: - needs patch
___
Python tracker rep...@bugs.python.org
Ezio Melotti ezio.melo...@gmail.com added the comment:
overflow: auto should fix #4711 too (adding an horizontal scroll bar
at the bottom of the sidebar).
--
assignee: ezio.melotti - georg.brandl
stage: needs patch -
superseder: - Wide literals in the table of contents overflow in
Georg Brandl ge...@python.org added the comment:
I've experimented with a style variant that keeps the sidebar fixed on
the left side, however I did not manage to get it to show a separate
scrollbar. Maybe I was just stupid though.
___
Python tracker
Ezio Melotti ezio.melo...@gmail.com added the comment:
Something like this maybe?
div.sphinxsidebar {
float: left;
width: 230px;
height: 100%;
font-size: 90%
/* add these: */
margin-top: 30px;
height: 100%;
overflow: auto;
position: fixed;
}
...
div.related
Senthil orsent...@gmail.com added the comment:
Terry, I think you mean the Sidebar content, right?
Yes, I agree with you. It would be desirable to have the Sidebar
Fixed, while we scroll the document (Like this:
http://www.w3.org/Style/CSS/)
This has to be worked out in the Sphnix CSS.
New submission from Terry J. Reedy tjre...@udel.edu:
In the Windows help version of the docs that come with the Windows .msi
installer, the index pane to the left scrolls separately from the
content pane to the right. Very nice for jumping around even to other docs.
In the html versions at
30 matches
Mail list logo
