Mark Dickinson dicki...@gmail.com added the comment:
Applied in r72479, r72481, r72482, r72483.
As a side note, I'm not 100% convinced of the correctness of the
resource_setrlimit code. If rlim_t is smaller than an unsigned long then input
values might be wrapped to a smaller
value (by the
STINNER Victor victor.stin...@haypocalc.com added the comment:
For the second, I don't understand why you want to
compare the return result with RLIM_INFINITY: PyInt_AsLong
returns -1 to signal failure; is there some guarantee that
RLIM_INFINITY == -1 if it's defined?
rlim_t is an
Changes by STINNER Victor victor.stin...@haypocalc.com:
Removed file: http://bugs.python.org/file13884/sign_warning_resource.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5933
___
Changes by STINNER Victor victor.stin...@haypocalc.com:
Removed file: http://bugs.python.org/file13883/sign_warning.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5933
___
Georg Brandl ge...@python.org added the comment:
Yes, that looks better.
PS: Do not remove applied patches.
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5933
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
PS: Do not remove applied patches.
Oh ok, sorry.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5933
___
Changes by Georg Brandl ge...@python.org:
--
assignee: - marketdickinson
nosy: +marketdickinson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5933
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
About sign_warning_resource.patch: I don't know if RLIM_INFINITY
constant is standard (always defined if getrlimit() is present).
--
___
Python tracker rep...@bugs.python.org
Mark Dickinson dicki...@gmail.com added the comment:
Thanks for the patches.
The first patch looks fine; I'll apply it shortly.
For the second, I don't understand why you want to
compare the return result with RLIM_INFINITY: PyInt_AsLong
returns -1 to signal failure; is there some guarantee
Mark Dickinson dicki...@gmail.com added the comment:
Applied the first patch in r72344, r72345, r72346, r72347.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5933
___
New submission from STINNER Victor victor.stin...@haypocalc.com:
Simple patch to fix some gcc warnings (when using gcc -Wall -Wextra).
--
components: Library (Lib)
files: sign_warning.patch
keywords: patch
messages: 87192
nosy: haypo
severity: normal
status: open
title: fix gcc -Wextra
STINNER Victor victor.stin...@haypocalc.com added the comment:
Another patch to fix similar warnings in resource modules.
--
Added file: http://bugs.python.org/file13884/sign_warning_resource.patch
___
Python tracker rep...@bugs.python.org
12 matches
Mail list logo