R. David Murray added the comment:
For the record, this patch also introduced another regression (issue 15545).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9750
___
Roundup Robot added the comment:
New changeset 2cdb599172ab by R David Murray in branch '3.2':
#15545: fix sqlite3.iterdump regression on unsortable row_factory objects.
http://hg.python.org/cpython/rev/2cdb599172ab
New changeset 6a85894c428f by R David Murray in branch '3.3':
merge #15545: fix
R. David Murray rdmur...@bitdance.com added the comment:
Note that the use of 'format' in the 2.7 patch caused a regression (% causes an
implicit promotion to unicode, .format does not). See issue 15109.
--
nosy: +r.david.murray
___
Python tracker
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 60aa7dacb605 by Petri Lehtinen in branch '2.7':
Fix sqlite3.Connection.iterdump on tables/fields with reserved names or quotes
http://hg.python.org/cpython/rev/60aa7dacb605
New changeset 4b105d328fe7 by Petri
Éric Araujo mer...@netwok.org added the comment:
Petri, I think you can go ahead.
Lucas, thanks for your help, even though your patch is not used.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9750
Petri Lehtinen pe...@digip.org added the comment:
Marko's last patch looks good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9750
___
Marko Kohtala marko.koht...@gmail.com added the comment:
Here is finally an update to my patch modified according to comments received.
It should apply on 2.7 and 3.3 branches.
--
Added file: http://bugs.python.org/file24429/sqlite3dump.patch
___
Changes by Marko Kohtala marko.koht...@gmail.com:
Removed file: http://bugs.python.org/file18726/sqlite3dump.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9750
___
Changes by Marko Kohtala marko.koht...@gmail.com:
Removed file: http://bugs.python.org/file18725/sqlite3bug2.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9750
___
Changes by Marko Kohtala marko.koht...@gmail.com:
Removed file: http://bugs.python.org/file18720/sqlite3bug.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9750
___
Changes by Petri Lehtinen pe...@digip.org:
--
nosy: +petri.lehtinen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9750
___
___
Python-bugs-list
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9750
___
___
Lucas Sinclair blastoc...@mac.com added the comment:
My patch contains two new dump tests which originally fail, and the fixes to
the code that makes them pass.
--
Added file: http://bugs.python.org/file23629/issue9750.patch
___
Python tracker
Lucas Sinclair blastoc...@mac.com added the comment:
Sure, I can have a try at it and address the issues you pointed out.
The URL to the guidelines you provided gives a 404. In what form exactly would
you like the patch to be ?
I wouldn't mind either adding to the test suite, but I'm not sure
Éric Araujo mer...@netwok.org added the comment:
Sure, I can have a try at it and address the issues you pointed out.
Nice!
The URL to the guidelines you provided gives a 404.
They’ve moved to http://docs.python.org/devguide meanwhile.
I wouldn't mind either adding to the test suite, but
Lucas Sinclair blastoc...@mac.com added the comment:
I just encountered this issue today.
So, it's been several months, will the patch be merged into the master branch ?
Or will this never be fixed ?
--
nosy: +xapple
___
Python tracker
Éric Araujo mer...@netwok.org added the comment:
Hi Lucas. Have you read my previous message? The patch needs to be updated.
Would you like to do it?
--
versions: +Python 3.3 -Python 3.1
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
I have very limited time to use on this.
This is a perfectly reasonable stance, and we’re grateful for the work you’re
doing. When you say that you don’t have time, someone else will take up the
patch and update it to address reviews, and you
Changes by Marko Kohtala marko.koht...@gmail.com:
Removed file: http://bugs.python.org/file18721/sqlite3bug.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9750
___
Changes by Marko Kohtala marko.koht...@gmail.com:
Removed file: http://bugs.python.org/file18722/sqlite3ident.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9750
___
Marko Kohtala marko.koht...@gmail.com added the comment:
Thank you for the review.
I have very limited time to use on this. So even when I'd like to make
everything easy for you, have the time you give to python be as productive as
possible, I can not.
But I'll respond to your comments on
Éric Araujo mer...@netwok.org added the comment:
Thank you for the report and patch. Some bug tracker tips:
1) It’s possible to replace a file, so that there is always one bug.py and one
diff, which is easier for reviewers to understand than a long list of files
(possibly all with the same
New submission from Marko Kohtala marko.koht...@gmail.com:
Sqlite3 fails to dump a database with column names that are keywords.
--
components: Extension Modules
files: sqlite3bug.py
messages: 115420
nosy: Marko.Kohtala
priority: normal
severity: normal
status: open
title: sqlite3
Marko Kohtala marko.koht...@gmail.com added the comment:
Here is a patch that may resolve the bug.
--
keywords: +patch
Added file: http://bugs.python.org/file18721/sqlite3bug.patch
___
Python tracker rep...@bugs.python.org
Changes by Ned Deily n...@acm.org:
--
nosy: +ghaering
versions: +Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9750
___
___
Changes by Gerhard Häring g...@ghaering.de:
--
assignee: - ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9750
___
___
Python-bugs-list
Marko Kohtala marko.koht...@gmail.com added the comment:
The second patch contains also fixes for some places where the rules described
in http://www.sqlite.org/lang_keywords.html are not followed.
--
Added file: http://bugs.python.org/file18722/sqlite3ident.patch
Marko Kohtala marko.koht...@gmail.com added the comment:
It also fails if table or column names contain double quote.
--
Added file: http://bugs.python.org/file18725/sqlite3bug2.py
___
Python tracker rep...@bugs.python.org
Changes by Marko Kohtala marko.koht...@gmail.com:
Added file: http://bugs.python.org/file18726/sqlite3dump.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9750
___
29 matches
Mail list logo
