[issue21220] Enhance obmalloc allocation strategy

2014-04-16 Thread Charles-François Natali
Charles-François Natali added the comment: > In Python 3, arenas are allocated using mmap(), so wherever the arena ends up > in the address space shouldn't matter, should it? Indeed, although the effect on cache locality isn't clear. Also, I don't think this solves the problem of having a singl

[issue21233] Add *Calloc functions to CPython memory allocation API

2014-04-16 Thread Charles-François Natali
Charles-François Natali added the comment: >> So what is the point of _PyObject_GC_Calloc ? > > It calls calloc(size) instead of malloc(size), calloc() which can be faster > than malloc()+memset(), see: > https://mail.python.org/pipermail/python-dev/2014-April/133985.html It will only make a di

[issue1191964] asynchronous Subprocess

2014-04-16 Thread STINNER Victor
STINNER Victor added the comment: I started to review the patch 5: http://bugs.python.org/review/1191964/#ps11598 When I read unit tests, I realized that I don't like "write_nonblocking" name. It's too generic. A process has many files (more than just stdin, stdout, stderr: see pass_fds parame

[issue21207] urandom persistent fd - not re-openned after fd close

2014-04-16 Thread STINNER Victor
STINNER Victor added the comment: > I agree in part, but it's quite common to close fd's in some cases like in a > child process after using "os.fork()" Which project or Python module does that? Can you show me the code? -- nosy: +haypo ___ Python t

[issue21111] Add a new PyLong_AsUnsignedLongAndOverflow function

2014-04-16 Thread STINNER Victor
Changes by STINNER Victor : -- title: PyLong_AsUnsignedLongAndOverflow does not exist -> Add a new PyLong_AsUnsignedLongAndOverflow function ___ Python tracker ___ _

[issue20434] Fix error handler of _PyString_Resize() on allocation failure

2014-04-16 Thread STINNER Victor
Changes by STINNER Victor : -- title: Process crashes if not enough memory to import module -> Fix error handler of _PyString_Resize() on allocation failure ___ Python tracker _

[issue21180] Efficiently create empty array.array, consistent with bytearray

2014-04-16 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue21216] getaddrinfo is wrongly considered thread safe on linux

2014-04-16 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue21216] getaddrinfo is wrongly considered thread safe on linux

2014-04-16 Thread STINNER Victor
STINNER Victor added the comment: > It may only be reproductible when your getaddrinfo use a NETLINK to get > informations about your interfaces before doing the DNS query. What is your operation system? Name and version. What is your version of the C library? What is your Python version? Can

[issue21250] sqlite3 doesn't have unit tests for 'insert or [algorithm]' functionality.

2014-04-16 Thread Alex Lord
New submission from Alex Lord: In Lib/sqlite3/tests/dbapi.py there are no unit tests which test out sqlite3's 'insert or [algorithm].' These algorithms are also referred to as SQL 'insert on conflict.' More details at, https://www.sqlite.org/lang_conflict.html Not having unit tests for these

[issue21216] getaddrinfo is wrongly considered thread safe on linux

2014-04-16 Thread STINNER Victor
STINNER Victor added the comment: test_getaddrinfo.c: C program to run getaddrinfo() concurrently in different threads, it comes from the Debian issue. I ran this program with 10 threads, I stopped it after between 3000 and 5000 tries (depending on the thread). I'm running Fedora 20: Linux ker

[issue21216] getaddrinfo is wrongly considered thread safe on linux

2014-04-16 Thread STINNER Victor
STINNER Victor added the comment: Can you provide the C and Python backtrace of all threads of your program? -- ___ Python tracker ___ ___

[issue21233] Add *Calloc functions to CPython memory allocation API

2014-04-16 Thread STINNER Victor
STINNER Victor added the comment: >>> So what is the point of _PyObject_GC_Calloc ? >> >> It calls calloc(size) instead of malloc(size) > > No, the question is why you didn't simply change _PyObject_GC_Malloc > (which is a private function). Oh ok, I didn't understand. I don't like changing the

[issue21233] Add *Calloc functions to CPython memory allocation API

2014-04-16 Thread STINNER Victor
STINNER Victor added the comment: 2014-04-16 3:18 GMT-04:00 Charles-François Natali : >> It calls calloc(size) instead of malloc(size), calloc() which can be faster >> than malloc()+memset(), see: >> https://mail.python.org/pipermail/python-dev/2014-April/133985.html > > It will only make a diff

[issue21234] __contains__ and friends should check "is" for all elements first

2014-04-16 Thread Wolfgang Maier
Wolfgang Maier added the comment: I don't even know where to start with this. a) this recipe is not working b) it's hardly readable c) it is pointless Why are you complicating things by testing for != ? What advantage does this offer over == ? You do not need class methods at all to achi

[issue21167] float('nan') returns 0.0 on Python compiled with icc

2014-04-16 Thread Hrvoje Nikšić
Hrvoje Nikšić added the comment: Using -fp-model strict (or other appropriate icc flag) seems like a reasonable resolution. It should likely also be applied to Python 3.x, despite the version field of this issue. (Even if float('nan') happens to work in current 3.x, internal code that returns

[issue21233] Add *Calloc functions to CPython memory allocation API

2014-04-16 Thread Stefan Krah
Stefan Krah added the comment: I left a Rietveld comment, which probably did not get mailed. -- ___ Python tracker ___ ___ Python-bugs

[issue21015] support SSL_CTX_set_ecdh_auto on newer OpenSSLs

2014-04-16 Thread Stefan Krah
Stefan Krah added the comment: In case anyone wonders why the FreeBSD bot works again: I've installed OpenSSL from source. -- ___ Python tracker ___ _

[issue21234] __contains__ and friends should check "is" for all elements first

2014-04-16 Thread Jurjen N.E. Bos
Jurjen N.E. Bos added the comment: Oops. That was a hard lesson: 1) don't haste when posting 2) always run what you post. The point was the trick to define a custom __ne__ and not an __eq__ for an object (not for the container it is in!) so you can use "in" at full speed. Then not all(map(ne,

[issue20752] Difflib should provide the option of overriding the SequenceMatcher

2014-04-16 Thread Chris Rose
Changes by Chris Rose : -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue21237] Update Python 2/3 porting HOWTO's suggestion for dealing with map()

2014-04-16 Thread Josh Rosenberg
Josh Rosenberg added the comment: I think the suggestion is intended for "how do I keep Python 2 semantics in Python 3?", not "how can I write my Python 2 code so it will run equivalently in Python 3?" It wouldn't be a bad idea to point out that you can adopt Py3 semantics initially so as to

[issue21235] importlib's spec module create algorithm is not exposed

2014-04-16 Thread Tshepang Lekhonkhobe
Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue21251] Standard library trace module crashes with exception

2014-04-16 Thread Martin Kolman
New submission from Martin Kolman: We are currently working on adding tracing support to Anaconda, the Fedora/Red Hat Enterprise Linux installer and we have encountered some pretty strange behavior of the trace module. Anaconda (or to be concrete the Blivet storage library used by Anaconda) us

[issue21211] pkgutil.find_loader() raises ImportError instead of returning None

2014-04-16 Thread Eric Snow
Eric Snow added the comment: Ah, it's ValueError rather than ImportError that causes the problem. Regardless, handling it would be necessary. -- ___ Python tracker ___

[issue6490] os.popen documentation is probably wrong

2014-04-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3417a95df7e2 by Andrew Kuchling in branch 'default': #6490: Expand documentation for os.popen(). http://hg.python.org/cpython/rev/3417a95df7e2 -- nosy: +python-dev ___ Python tracker

[issue6490] os.popen documentation is probably wrong

2014-04-16 Thread A.M. Kuchling
A.M. Kuchling added the comment: Thanks for your patch! -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed title: os.popen documentation is probably wrong -> os.popen documentation is probably wrong ___ Python t

[issue21234] __contains__ and friends should check "is" for all elements first

2014-04-16 Thread Wolfgang Maier
Wolfgang Maier added the comment: that clarifies things, thanks. I would still not usually go that way though as it means defining __ne__ with no accompanying __eq__, which means that, in a simple case, you can't use == on instances of your class and, in the case that your class inherits __eq_

[issue21234] __contains__ and friends should check "is" for all elements first

2014-04-16 Thread Wolfgang Maier
Wolfgang Maier added the comment: > l=[myObj() for x in range(1)] > > now compare: > > >>> 1 in m # slowed down by myObj.__eq__ > False > > >>> any(e is 1 for e in m) # identity checks only > False oops, sorry for the inconsistency here. the first line should read: m = [myObj() for x in

[issue15002] urllib2 does not download 4 MB file completely using ftp

2014-04-16 Thread Christian Theune
Christian Theune added the comment: Looking into this. It seems that it doesn't happen for all servers, I can download large files reliably from other sources. I'll make another wireshark recording to get more details for me to analyze. -- nosy: +ctheune

[issue15002] urllib2 does not download 4 MB file completely using ftp

2014-04-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: > I'll make another wireshark recording to get more details for me to analyze. Thank you! That will be useful. Please test it against 3.x version as it has seen cleanups recently. -- ___ Python tracker

[issue21121] -Werror=declaration-after-statement is added even for extension modules through setup.py

2014-04-16 Thread Stefan Krah
Stefan Krah added the comment: Here is a patch. I do not see a really nice way to deal with the problem. The cleanest way I found was to introduce a new Makefile variable CFLAGS_NODIST and use that in the interpreter and stdlib build. -- keywords: +patch nosy: +skrah Added file: http://

[issue21167] float('nan') returns 0.0 on Python compiled with icc

2014-04-16 Thread Stefan Krah
Stefan Krah added the comment: Mark, if you agree that "fp-model strict" should not show up in the distutils CFLAGS once Python is installed, the issue now depends on #21121. -- dependencies: +-Werror=declaration-after-statement is added even for extension modules through setup.py

[issue12916] Add inspect.splitdoc

2014-04-16 Thread R. David Murray
R. David Murray added the comment: Well, perhaps inspect needs a get_doc_synopsis method :) Actually, I'm not sure that should be a smiley. I don't really have a strong opinion on this myself (say I'm +0 for inspect), so I asked a couple other core devs here at the sprint (Eric Smith and Eric

[issue12916] Add inspect.splitdoc

2014-04-16 Thread Eric Snow
Eric Snow added the comment: I agree with Éric that exposing splidoc publicly in the inspect module is the right thing. inspect already has other similar functions. If it doesn't land in inspect then the only other place that makes real sense to me would be a new module (docstring?). Howeve

[issue12523] 'str' object has no attribute 'more' [/usr/lib/python3.2/asynchat.py|initiate_send|245]

2014-04-16 Thread Caelyn McAulay
Caelyn McAulay added the comment: Here is a small script that runs fine under 2.7 but demonstrates the error when run at 3.5. If, at all the points annotated with '#not bytes :-(', the unicode strings are replaced with bytes objects, the example then successfully runs at 3.5. -- nosy:

[issue15002] urllib2 does not download 4 MB file completely using ftp

2014-04-16 Thread Christian Theune
Christian Theune added the comment: This is actually the same problem as #18879. Changing the sample to keep a reference to the addinfourl object avoids this issue. This is even worse than #18879 in the sense that the error goes undetected and just leaves you with partial data. Looking at th

[issue21015] support SSL_CTX_set_ecdh_auto on newer OpenSSLs

2014-04-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: > In case anyone wonders why the FreeBSD bot works again: I've > installed OpenSSL from source. Did you install the same version? -- ___ Python tracker ___

[issue21015] support SSL_CTX_set_ecdh_auto on newer OpenSSLs

2014-04-16 Thread Stefan Krah
Stefan Krah added the comment: Antoine Pitrou wrote: > Did you install the same version? No, I used the latest version + FIPS. Since FreeBSD 9.0 is EOL, I did not feel like investigating too much. :) -- ___ Python tracker

[issue21246] test_ssl handshake failure

2014-04-16 Thread ddve...@ucar.edu
ddve...@ucar.edu added the comment: Despite this being Red Hat, this is not at all the case! OpenSSL 1.0.1f has been released on Jan 6th, 2014 at 15:39:19 -- see https://www.openssl.org/source/ -- ___ Python tracker

[issue21121] -Werror=declaration-after-statement is added even for extension modules through setup.py

2014-04-16 Thread Wolfgang Maier
Wolfgang Maier added the comment: I ran into this issue right after 3.4 got released. I solved it by adding extra_compile_args=["-Wno-error=declaration-after-statement"] as an argument to the Extension() call in the package's setup.py . -- nosy: +wolma ___

[issue21246] test_ssl handshake failure

2014-04-16 Thread ddve...@ucar.edu
ddve...@ucar.edu added the comment: Just to make sure I'm using the right version: Python 2.7.6 (default, Apr 14 2014, 15:12:21) [GCC 4.8.2] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import ssl >>> ssl.OPENSSL_VERSION 'OpenSSL 1.0.1f 6 Jan 2014' >>>

[issue15414] os.path.join behavior on Windows (ntpath.join) is unexpected and not well documented

2014-04-16 Thread Martin Dengler
Changes by Martin Dengler : -- nosy: +mdengler ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue1669539] Improve Windows os.path.join (ntpath.join) "smart" joining

2014-04-16 Thread Martin Dengler
Changes by Martin Dengler : -- nosy: +mdengler ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue21252] Lib/asyncio/events.py has tons of docstrings which are just "XXX"

2014-04-16 Thread Alex Gaynor
New submission from Alex Gaynor: It would be nice if these said something useful. (http://hg.python.org/cpython/file/default/Lib/asyncio/events.py) -- components: Library (Lib) messages: 216478 nosy: alex priority: normal severity: normal status: open title: Lib/asyncio/events.py has to

[issue21253] Difflib

2014-04-16 Thread Nina Zakharenko
New submission from Nina Zakharenko: When difflib.compare() is used on two moderately large sequences with little or no common elements, a RuntimeError: maximum recursion depth exceeded occurs. This error became apparent when testing another bug (see: issue 19217) in the AssertEquals() method

[issue21253] Difflib.compare() crashes when sequences contain little or no common elements

2014-04-16 Thread Nina Zakharenko
Changes by Nina Zakharenko : -- title: Difflib -> Difflib.compare() crashes when sequences contain little or no common elements ___ Python tracker ___ __

[issue19217] Calling assertEquals for moderately long list takes too long

2014-04-16 Thread Nina Zakharenko
Nina Zakharenko added the comment: The cause of this has been identified as a bug in libdiff.compare(). See issue 21253 for more information. -- nosy: +nnja ___ Python tracker _

[issue21238] unittest.mock.Mock should not allow you to use non-existent assert methods

2014-04-16 Thread Kushal Das
Kushal Das added the comment: Patch with docs and test changes. -- keywords: +patch Added file: http://bugs.python.org/file34912/issue21238.patch ___ Python tracker ___ _

[issue21252] Lib/asyncio/events.py has tons of docstrings which are just "XXX"

2014-04-16 Thread Yury Selivanov
Yury Selivanov added the comment: I had plans to copy some documentation from python docs to asyncio docstrings. I'll try to do this sometime this week. Thanks for reminding us about the issue! -- assignee: -> yselivanov nosy: +gvanrossum, haypo, yselivanov ___

[issue21252] Lib/asyncio/events.py has tons of docstrings which are just "XXX"

2014-04-16 Thread Guido van Rossum
Guido van Rossum added the comment: My bad. But I think docstrings should NOT be just copies of the separate docs. On Apr 16, 2014 9:01 AM, "Yury Selivanov" wrote: > > Yury Selivanov added the comment: > > I had plans to copy some documentation from python docs to asyncio > docstrings. I'll try

[issue21252] Lib/asyncio/events.py has tons of docstrings which are just "XXX"

2014-04-16 Thread Yury Selivanov
Yury Selivanov added the comment: > My bad. But I think docstrings should NOT be just copies of the separate docs. I agree. I didn't want to blindly copy them, but rather use existing documentation as guidance & baseline. -- ___ Python tracker

[issue12523] 'str' object has no attribute 'more' [/usr/lib/python3.2/asynchat.py|initiate_send|245]

2014-04-16 Thread Caelyn McAulay
Caelyn McAulay added the comment: I was unable to locate a point in the code where we could be certain that the error was ultimately caused by trying to use (unicode) strings instead of bytes object. The patch adds a logging statement suggesting what the trouble is when the error is (probably

[issue12916] Add inspect.splitdoc

2014-04-16 Thread Yury Selivanov
Yury Selivanov added the comment: OK, since it's two-and-a-half votes against one, let's do this. I'll do the final review of the patch and commit it. -- ___ Python tracker ___

[issue21254] PropertyMock refuses to raise AttributeErrror as a side effect

2014-04-16 Thread Michael Foord
New submission from Michael Foord: What steps will reproduce the problem? >>> import mock >>> a_mock = mock.MagicMock() >>> no_attribute = mock.PropertyMock(side_effect=AttributeError) >>> type(a_mock).property = no_attribute What is the expected output? What do you see instead? I would expe

[issue21255] Attaching a PropertyMock records calls

2014-04-16 Thread Michael Foord
New submission from Michael Foord: What steps will reproduce the problem? >>> foo = Mock(name='foo') >>> prop = PropertyMock(name='prop') >>> type(foo).prop = prop >>> foo.attach_mock(prop, 'prop') >>> foo.mock_calls [call.prop()] Expected: >>> foo.mock_calls []

[issue5420] Queue deprecation warning patch

2014-04-16 Thread Raymond Hettinger
Raymond Hettinger added the comment: Martin von Löwis successfully lobbied to keep these methods. -- resolution: -> rejected status: open -> closed ___ Python tracker ___ ___

[issue21015] support SSL_CTX_set_ecdh_auto on newer OpenSSLs

2014-04-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset d6501421b86b by Antoine Pitrou in branch '3.4': Try to fix buildbot failures on old OpenSSLs (< 1.0.0) - followup to issue #21015 http://hg.python.org/cpython/rev/d6501421b86b New changeset 1305410bff2d by Antoine Pitrou in branch 'default': Try to

[issue21234] __contains__ and friends should check "is" for all elements first

2014-04-16 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: -> rhettinger nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue21256] Sort keyword arguments in mock _format_call_signature

2014-04-16 Thread Michael Foord
New submission from Michael Foord: Printing call args produces non-deterministic results, making them more or less useless in doctests. kwargs_string = ', '.join([ '%s=%r' % (key, value) for key, value in kwargs.items() ]) should be: kwargs_string = ', '.join([ '%s=%r' % (

[issue21227] Decimal class error messages for integer division aren't good

2014-04-16 Thread Stefan Krah
Stefan Krah added the comment: It is hard to get fine grained error messages in _decimal, since the errors come from libmpdec. A clean solution would require changes to libmpdec, and I'm reluctant to do that right now. It is certainly possible to document DivisionImpossible etc. -- __

[issue21015] support SSL_CTX_set_ecdh_auto on newer OpenSSLs

2014-04-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: So, I think I've found the issue. On OpenSSL < 1.0.0, the ECDH ciphers exist but the "ECDH" cipher alias doesn't. I've committed a patch which should fix the issue, although the set_ciphers() call may be entirely useless given our current default cipher list.

[issue21257] Document parse_headers function of http.client

2014-04-16 Thread Senthil Kumaran
New submission from Senthil Kumaran: It is undocumented. While fixing a doc issue issue18229 for http.server I noticed that I referenced that function and when I looked up for the documentation, it was lacking. -- assignee: orsenthil messages: 216494 nosy: orsenthil priority: normal se

[issue21015] support SSL_CTX_set_ecdh_auto on newer OpenSSLs

2014-04-16 Thread Ned Deily
Ned Deily added the comment: That does indeed make the test now pass on OS X 10.9: test_default_ecdh_curve (test.test_ssl.ThreadedTests) ... server: new connection from ('127.0.0.1', 60758) server: connection cipher is now ('AECDH-AES256-SHA', 'TLSv1/SSLv3', 256) server: selected protocol i

[issue21227] Decimal class error messages for integer division aren't good

2014-04-16 Thread Stefan Krah
Stefan Krah added the comment: Meanwhile, the pure Python decimal versions prior to Python 3.2 have better error messages. Right now in Python 3.3+ it is hard to import the Python version without going into contortions, but that may be fixed in #19232. -- dependencies: +Speed up _decima

[issue21192] Idle: Print filename when running a file from editor

2014-04-16 Thread Adnan Umer
Adnan Umer added the comment: I tried to replace RESTART by doing these little changing # PyShell.Py class ModifiedInterpreter(InteractiveInterpreter): def restart_subprocess(self, with_cwd=False, with_msg=True): ... if with_msg: halfbar = ((int(console.width) - 1

[issue21246] test_ssl handshake failure

2014-04-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: This was fixed in #20896 by a certain Benjamin Peterson. -- nosy: +pitrou resolution: -> duplicate status: open -> closed superseder: -> test_ssl.test_get_server_certificate() should use PROTOCOL_SSLv23, not PROTOCOL_SSLv3 ___

[issue21015] support SSL_CTX_set_ecdh_auto on newer OpenSSLs

2014-04-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: The buildbots seem happy as well, so I'm closing this. -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker _

[issue21247] test_asyncio: test_subprocess_send_signal hangs on Fedora builders

2014-04-16 Thread Orion Poplawski
Orion Poplawski added the comment: We have determined that the koji builder is indeed setting the SIGHUP sigaction to SIG_IGN, which the python test is inheriting, and are working on trying to get that fixed. However, it may be worth considering something like https://github.com/pexpect/pexpe

[issue21256] Sort keyword arguments in mock _format_call_signature

2014-04-16 Thread Eric Snow
Eric Snow added the comment: Ordered kwargs anyone? :) -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue20896] test_ssl.test_get_server_certificate() should use PROTOCOL_SSLv23, not PROTOCOL_SSLv3

2014-04-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 55f62fa5bebc by Antoine Pitrou in branch 'default': Issue #20896: ssl.get_server_certificate() now uses PROTOCOL_SSLv23, not PROTOCOL_SSLv3, for maximum compatibility. http://hg.python.org/cpython/rev/55f62fa5bebc -- __

[issue20896] test_ssl.test_get_server_certificate() should use PROTOCOL_SSLv23, not PROTOCOL_SSLv3

2014-04-16 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue21254] PropertyMock refuses to raise AttributeErrror as a side effect

2014-04-16 Thread Eric Snow
Eric Snow added the comment: Perhaps related to #1615? -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue21256] Sort keyword arguments in mock _format_call_signature

2014-04-16 Thread Kushal Das
Kushal Das added the comment: Patch uploaded for the same. -- keywords: +patch Added file: http://bugs.python.org/file34914/issue21256.patch ___ Python tracker ___ __

[issue15002] urllib2 does not download 4 MB file completely using ftp

2014-04-16 Thread Christian Theune
Changes by Christian Theune : -- versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3 ___ Python tracker ___ ___ Python-bugs-list

[issue17218] support title and description in argparse add_mutually_exclusive_group

2014-04-16 Thread paul j3
paul j3 added the comment: While mutually exclusive groups are a subclass of argument groups, they have very different uses. Argument groups are used solely to organize the help section. Groups are not used at all during parsing. 'parse_args' doesn't even pay attention to those 2 default gro

[issue18879] tempfile.NamedTemporaryFile can close the file too early, if not assigning to a variablwe

2014-04-16 Thread Christian Theune
Christian Theune added the comment: #15002 uses this patch to fix a similar wrapping problem in urllib. Also, this affects 2.7 as well and #15002 does report the problem for 2.7. I'd like to get this fix backported. Would that be OK? -- nosy: +ctheune title: tempfile.NamedTemporaryFile

[issue15002] urllib2 does not download 4 MB file completely using ftp

2014-04-16 Thread Christian Theune
Christian Theune added the comment: I wasn't able to come up with a good testcase. :( I tried similar approaches as in #18879 but I wasn't able to make them trigger the behaviour as it also seems to be an issue regarding actual network performance ... :/ Backport to 2.7 is currently missing a

[issue15002] urllib2 does not download 4 MB file completely using ftp

2014-04-16 Thread Christian Theune
Changes by Christian Theune : -- hgrepos: +237 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue15002] urllib2 does not download 4 MB file completely using ftp

2014-04-16 Thread Thomas Wouters
Changes by Thomas Wouters : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue15002] urllib2 does not download 4 MB file completely using ftp

2014-04-16 Thread Christian Theune
Christian Theune added the comment: Antoine, I'm adding you here as I'm leveraging your patch from #18879. I'd need some feedback about the backport, but this patch should be OK for 3.4. Also, if you had an idea how to test this - I tried, but failed so far. -- __

[issue21227] Decimal class error messages for integer division aren't good

2014-04-16 Thread leewz
leewz added the comment: Fine grained? Do you mean that the error can't be distinguished from other such errors? Or that it's difficult to attach the message to DivisionError? I thought DivisionError was always about precision. I looked up the error in libmpdec: "This occurs and signals invali

[issue15002] urllib2 does not download 4 MB file completely using ftp

2014-04-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: Christian , with respect to patch, I agree with the logic (using something similar to #18879). Does all current unittests succeed with this? (I suspect not) A unittest for coverage would be helpful. -- ___ Python t

[issue15002] urllib2 does not download 4 MB file completely using ftp

2014-04-16 Thread Christian Theune
Changes by Christian Theune : -- keywords: +patch Added file: http://bugs.python.org/file34915/d3c6ab639306.diff ___ Python tracker ___ __

[issue15002] urllib2 does not download 4 MB file completely using ftp

2014-04-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: Well, this looks ok on the principle, but I haven't investigated the urllib-specific parts, so I'll let Senthil delve into this :) -- ___ Python tracker __

[issue17752] many distutils tests fail when run from the installed location

2014-04-16 Thread Thomas Wouters
Thomas Wouters added the comment: Matthias, I think this is already fixed for Python 3.3 and later (at least.) There may still be problems in 2.7, but I'm not sure if it's worth fixing them there. Can you see if you still have problems, and if so, show us how to reproduce them? (Is it just 'py

[issue21256] Sort keyword arguments in mock _format_call_signature

2014-04-16 Thread Michael Foord
Michael Foord added the comment: Yes to ordered kwargs! I would very much like to be able to order the keyword args in the order they were passed in, information which is currently lost. -- ___ Python tracker

[issue21233] Add *Calloc functions to CPython memory allocation API

2014-04-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: On mer., 2014-04-16 at 08:06 +, STINNER Victor wrote: > I didn't check which objects use (indirectly) _PyObject_GC_Calloc(). I've checked: lists, tuples, dicts and sets at least seem to use it. Obviously, objects which are not tracked by the GC (such as str

[issue17449] dev guide appears not to cover the benchmarking suite

2014-04-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: Jeff: yes it could :) Do you want to provide a patch? -- ___ Python tracker ___ ___ Python-bugs-list

[issue21068] Make ssl.PROTOCOL_* an enum

2014-04-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: Anyone else has an opinion on this? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue2159] dbmmodule inquiry function is performance prohibitive

2014-04-16 Thread Eric Olson
Eric Olson added the comment: New patch with Pep 7 fix - no c++ // style comments. -Thanks johansen. -- Added file: http://bugs.python.org/file34916/dbm_bool_d.patch ___ Python tracker __

[issue21238] unittest.mock.Mock should not allow you to use non-existent assert methods

2014-04-16 Thread Michael Foord
Michael Foord added the comment: It needs a NEWS entry, but looks good to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue21207] urandom persistent fd - not re-openned after fd close

2014-04-16 Thread Steven Hiscocks
Steven Hiscocks added the comment: Issue where I hit this is in Fail2Ban: https://github.com/fail2ban/fail2ban/issues/687 Lines of code where this occurs: https://github.com/fail2ban/fail2ban/blob/1c65b946171c3bbc626ddcd9320ea2515018677b/fail2ban/server/server.py#L518-530 There are other exam

[issue21227] Decimal class error messages for integer division aren't good

2014-04-16 Thread Stefan Krah
Stefan Krah added the comment: My apologies if that wasn't clear: "fine grained" refers to the exception messages. A function can raise InvalidOperation for different reasons. decimal.py gives a specific error message in each case. libmpdec just signals the standard conforming InvalidOperation.

[issue21258] Add __iter__ support for mock_open

2014-04-16 Thread Michael Foord
New submission from Michael Foord: mock_open returns a mock object suitable for using as a mock file handle. File handles support iteration, so mock_open should support that. If possible it should be integrated with the current read/readlines support (only if possible), so the suggested patch

[issue18229] attribute headers of http.server.BaseHTTPRequestHandler sometimes does not exists

2014-04-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 104fab0143e9 by Senthil Kumaran in branch '3.4': Address issue 18229 - Explain http.server.BaseHTTPRequestHandler's .headers attribute further. http://hg.python.org/cpython/rev/104fab0143e9 -- nosy: +python-dev

[issue15002] urllib2 does not download 4 MB file completely using ftp

2014-04-16 Thread Christian Theune
Christian Theune added the comment: Antoine, could you check my last comment in here? (The nosy list got reset accidentally when I made that comment and got a conflict from the tracker). -- nosy: +pitrou ___ Python tracker

[issue18229] attribute headers of http.server.BaseHTTPRequestHandler sometimes does not exists

2014-04-16 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed versions: +Python 3.5 -Python 2.7, Python 3.3 ___ Python tracker ___ __

[issue21207] urandom persistent fd - not re-openned after fd close

2014-04-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: Well, on the one hand this does sound like a valid use case. On the other hand, once the urandom file descriptor is closed by third-party code, it can very well be re-opened to point to another file, and then os.urandom() will start behaving in a very bad way.

[issue21192] Idle: Print filename when running a file from editor

2014-04-16 Thread Terry J. Reedy
Terry J. Reedy added the comment: I took another look and tried the patch and discovered that my comments are partly wrong because restart_shell is called before runcode when runcode is use to run a file. (I am not sure how it is called otherwise with self.tkconsole.executing == True.) This ha

[issue21259] replace "except: pass" by "except Exception: pass"

2014-04-16 Thread Stéphane Wirtel
New submission from Stéphane Wirtel: Hi guys, Via this issue, I will attach a patch where I replace all the "except: pass" in the source code by a clear "except Exception: pass". -- components: Library (Lib) messages: 216524 nosy: matrixise priority: normal severity: normal status: ope

  1   2   3   >