Guido van Rossum added the comment:
Could use a test. Hopefully Victor can do a thorough review.
On Tue, Mar 10, 2015 at 12:20 PM, Sebastien Bourdeauducq
rep...@bugs.python.org wrote:
Sebastien Bourdeauducq added the comment:
See attached.
--
keywords: +patch
Added file:
Roundup Robot added the comment:
New changeset bf2016a1911f by Steve Dower in branch '3.4':
Issue #22028: Ensure mimetypes will not open registry keys with embedded nulls
https://hg.python.org/cpython/rev/bf2016a1911f
New changeset 6ccade563bf7 by Steve Dower in branch 'default':
Issue #22028:
New submission from Sebastien Bourdeauducq:
I would like to be able to bind asyncio TCP servers to an arbitrary list of
hosts, not just either one host or all interfaces.
I propose that the host parameter of create_server and start_server can be a
list of strings that describes each host.
Davin Potts added the comment:
Per Richard's post from 1 year ago where he offers both explanation and an
example, ultimately concluding that things are working as intended, and because
there have been no objections or requests for clarification in the past year,
closing this and marking it
Roundup Robot added the comment:
New changeset dbd48b22b477 by Antoine Pitrou in branch '2.7':
Issue #23629: Fix the default __sizeof__ implementation for variable-sized
objects.
https://hg.python.org/cpython/rev/dbd48b22b477
--
___
Python tracker
Bruno Cauet added the comment:
Hi,
I feel like this behaviour does not only affect IntEnum related but anything
that inherits from int.
Example:
class foo(int):
... def __init__(self, value, base=10):
... if value == 2:
... raise ValueError(not that!!)
...
Serhiy Storchaka added the comment:
Not all classmethods are constructors.
I see two solutions:
1) Override from_bytes() in IntEnum and every int subclass that needs this.
2) Change int.from_bytes() to call __new__.
--
___
Python tracker
Serhiy Storchaka added the comment:
The same issue exists in Lib/bz2.py, Lib/tarfile.py, Tools/freeze/bkfile.py.
May be write a code as
from builtins import open as _builtin_open
?
--
nosy: +brett.cannon, eric.snow, ncoghlan, serhiy.storchaka
type: - behavior
Serhiy Storchaka added the comment:
LGTM. Do you want to write a patch for other cases Thomas?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23615
___
Roundup Robot added the comment:
New changeset 1a972140ab62 by Victor Stinner in branch 'default':
Issue #23605: os.walk() doesn't need to call entry.is_symlink() if followlinks
https://hg.python.org/cpython/rev/1a972140ab62
--
___
Python tracker
Changes by Neil Girdhar mistersh...@gmail.com:
Added file: http://bugs.python.org/file38429/starunpack37.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2292
___
Roundup Robot added the comment:
New changeset f9afa4f87570 by Antoine Pitrou in branch '3.4':
Issue #23629: Fix the default __sizeof__ implementation for variable-sized
objects.
https://hg.python.org/cpython/rev/f9afa4f87570
New changeset 9994e0172a0c by Antoine Pitrou in branch 'default':
Wei Wu added the comment:
Updated the patch and addressed the previous review comments:
* Fixed the hasattr problem
* Added a default value None for filename in check_dump_traceback
* Reverted unnecessary code change in check_dump_traceback_later
* Added a new paragraph to the enable,
Bruno Cauet added the comment:
I took the liberty of putting together a small patch which makes from_bytes()
call return type(value_found) if type != long (Serhiy's my 2nd solution).
Ethan: in that case, type.from_bytes() would always return an int, and not
resort to build-a-pseudo-int,
David Beazley added the comment:
Note: Might be related to Issue 19713.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23642
___
___
Serhiy Storchaka added the comment:
Added new tests and tweaked regexpes. Thank you for your contribution Demian.
Now we can start long-standing deprecation process for conforming to RFC.
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
versions: +Python
Amaury Forgeot d'Arc added the comment:
So the recursion crash was fixed in python3,
but it's still one of the limits of the Python AST compiler.
I suggest to replace your long expression by a list:
exprs = [(1-a36)*(a37)*(1-a41), (a22)*(a33)*(1-a23), ...]
return sum(exprs)
...but this
STINNER Victor added the comment:
1) Serhiy's point about not needing to build the symlinks set when
followlinks is True is a good one, because it'll never get used. Just a if
not followlinks: ... around that try/except would do it. Though this is a
small optimization, as I expect 95% of
Roundup Robot added the comment:
New changeset 1c45047c5102 by Serhiy Storchaka in branch '2.7':
Issue #22928: Disabled HTTP header injections in httplib.
https://hg.python.org/cpython/rev/1c45047c5102
New changeset bf3e1c9b80e9 by Serhiy Storchaka in branch '3.4':
Issue #22928: Disabled HTTP
Serhiy Storchaka added the comment:
Happy? :-)
No, it doesn't fix my example. :-(
I see following possibilities:
1. Partially revert the patch and always call path.islink(). I will not kill
all the benefit of using os.scandir(), because there is a benefit from avoiding
path.isdir() and in
Serhiy Storchaka added the comment:
Trailing spaces, newlines and like were disabled in put_header() in issue22928.
Now we can start long-standing deprecation process for headers that don't
conform RFC 7230.
--
nosy: +serhiy.storchaka
stage: commit review - needs patch
versions:
Serhiy Storchaka added the comment:
Committed with non-dis test. Thank you for your contribution Bruno.
--
resolution: - fixed
stage: test needed - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset c06ebb57d4ed by Victor Stinner in branch '3.4':
Issue #23605: Refactor os.walk() tests to also run them on os.fwalk()
https://hg.python.org/cpython/rev/c06ebb57d4ed
--
___
Python tracker
Terry J. Reedy added the comment:
C:\Users\Terrynotepad %localappdata%
Access denied
Alongside the EXE is not fine. I only knew to look in C:/Windows because I
have using DOS/Windoes since the early 80s (and there is still much that I do
not know, like 'icacls'), and I believe there was a
STINNER Victor added the comment:
walk_added_symlink_to_dir-2.patch: Ok, here is a new patch, now with tests.
Without the fix on os.walk(), WalkTests.test_add_dir_symlink() fails, whereas
FwalkTests.test_add_dir_symlink() pass.
--
Added file:
Stefan Krah added the comment:
Yes, to be clear I'm +1 on this specific feature -- and separate issues. :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23632
___
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10967
___
___
New submission from Joshua J Cogliati:
The attached example works fine with Python 3.4.2, but fails with Python
3.5.0a1 and 3.5.0a2
I am using:
$ g++ --version
g++ (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6)
$ swig -version
SWIG Version 3.0.5
Compiled with g++ [x86_64-redhat-linux-gnu]
STINNER Victor added the comment:
Let me know if there is possible further improvement in this patch.
I was going to push your change, but I noticed that you use stderr.fileno() in
tests. I modified the test to use a different file descriptor. sys.stderr is
also the default value, so the
Antoine Pitrou added the comment:
Well, we could certainly do both :) I don't think we should weigh this issue
with separate features, though.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23632
Brett Cannon added the comment:
There is a proposed PEP on the import-sig:
https://mail.python.org/pipermail/import-sig/2015-March/000904.html . I'm
hoping to add it for the author to the PEP index on Friday.
Basically we punted on extension modules as we ran out of time in Python 3.4.
Brett Cannon added the comment:
I understood what you asked. My point is that mentioning eggs in the imp
doesn't make sense since the imp module nor import supports them natively. Eggs
are a setuptools thing, not a Python standard library thing.
--
Serhiy Storchaka added the comment:
May be add support of multi-dimensional sub-views?
m = memoryview(bytearray(range(12)))
m2 = m.cast('B', (3,4))
m2[0]
Traceback (most recent call last):
File stdin, line 1, in module
NotImplementedError: multi-dimensional sub-views are not implemented
STINNER Victor added the comment:
Oops, I forgot Windows. On Windows, we should maybe use stderr.fileno() and
avoid pass_fds.
(Or maybe just skip the tests on Windows?)
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/5828/steps/test/logs/stdio
Stefan Krah added the comment:
sub-views and multi-dimensional slicing are not that bad: They're already
implemented in _testbuffer (indeed with intermediate objects though).
--
___
Python tracker rep...@bugs.python.org
David Beazley added the comment:
This is great news. Read the PEP draft and think this is a very good thing to
be addressing. Thanks, Brett.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23642
Roundup Robot added the comment:
New changeset e78de5b1e3ef by Victor Stinner in branch 'default':
Issue #23566: enable(), register(), dump_traceback() and dump_traceback_later()
https://hg.python.org/cpython/rev/e78de5b1e3ef
--
nosy: +python-dev
___
Antoine Pitrou added the comment:
Sub-views are not as easily implemented. Besides, they create an intermediate
object which is immediately thrown away. And tuple indexing is a very common
idiom in the Numpy universe.
--
___
Python tracker
Akira Li added the comment:
POSIX timestamp doesn't count (literally) past/future leap seconds.
It allows to find out that the timestamp 2**31-1 corresponds to
2038-01-19T03:14:07Z (UTC) regardless of how many leap seconds will
occur before 2038:
from datetime import datetime, timedelta
Wei Wu added the comment:
Or we could reuse the file created by filename in subprocess?
if filename:
file = open(filename, wb)
if use_fd:
file = file.fileno()
else:
file = None
In this case, we need to pass two arguments(both filename and a bool use_fd) to
check_xxx
Ben Hoyt added the comment:
Thanks, Victor.
I haven't quite grokked all the changes here -- it's gotten somewhat more
complicated with the scandir_it and manual next() call -- but I ran some
benchmarks (via a hacked version of my scandir project's benchmark.py). The
results were surprising,
Davin Potts added the comment:
After pondering it for two days and coming back to it with hopefully fresh
eyes, I believe that changing the for-loop to a while-loop is not overall
easier to understand -- I would lean towards keeping the for-loop.
I do think the change to the while-loop very
Martin Panter added the comment:
Some of these that I believe are at least partially documented, so could be
added to the index. But the index for these is not very good anyway, because
they are listed in a funny (ASCII-betical?) order in a special section called
“symbols”, rather than
STINNER Victor added the comment:
Oh, test_signal fails with the patch because time.sleep() is not interrupted by
a signal. New patch.
I also reverted #ifdef order in floatsleep() to have a patch easier to review.
--
Added file: http://bugs.python.org/file38457/sleep_eintr-2.patch
STINNER Victor added the comment:
The problem is more general than Python: #include stdatomic.h fails in C++.
Try to compiled atomic.cpp with g++, you will get the same error.
The following bug report in the glibc has been closed as WONTFIX:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60932
Roundup Robot added the comment:
New changeset eb48295e1f8b by Victor Stinner in branch 'default':
Issue #23644, #22038: Move #include stdatomic.c inside the extern C { ... }
https://hg.python.org/cpython/rev/eb48295e1f8b
--
nosy: +python-dev
___
Joshua J Cogliati added the comment:
I have:
/local/python_fix/include/python3.5m/pyatomic.h
#ifndef Py_LIMITED_API
#ifndef Py_ATOMIC_H
#define Py_ATOMIC_H
#include dynamic_annotations.h
#include pyconfig.h
#ifdef __cplusplus
extern C {
#endif
#if defined(HAVE_STD_ATOMIC)
#include
Changes by STINNER Victor victor.stin...@gmail.com:
--
dependencies: +PEP 475 - EINTR handling, PEP 475: handle EINTR in the select
and selectors module, PEP 475: handle EINTR in the socket module, PEP 475:
handle EINTR in the time module, retry sleep()
Demian Brecht added the comment:
Thanks for the tweaks Serhiy, those seem reasonable to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22928
___
New submission from Gaëtan de Menten:
The documentation for __getslice__ at
https://docs.python.org/2/reference/datamodel.html#object.__getslice__ states:
Note that missing i or j in the slice expression are replaced by zero or
sys.maxint, respectively.
However, in practice, it seems like it
Joshua J Cogliati added the comment:
If I change the header to:
#ifndef Py_LIMITED_API
#ifndef Py_ATOMIC_H
#define Py_ATOMIC_H
#include dynamic_annotations.h
#include pyconfig.h
#ifdef __cplusplus
extern C {
#endif
#if defined(HAVE_STD_ATOMIC)
#ifdef __cplusplus
#include atomic
using
Charles-François Natali added the comment:
As for the change to select/poll/etc, IIRC Guido was opposed to it,
that's why I didn't update them.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23646
STINNER Victor added the comment:
_Atomic was added by the issue #22038.
--
nosy: +gustavotemple, haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23644
___
STINNER Victor added the comment:
Note: test_signal will have to be modified again when select will also retry on
EINTR :-) See issue #23485. For example, test_signal.test_wakeup_fd_early() can
register a signal handler which raises an exception and catch InterruptedError.
--
New submission from Srdjan Grubor:
When running tarfile.extract through multiple threads, the archive reading
pointer is not protected from simultaneous seeks and causes various convoluted
bugs:
some code
self.archive_object.extract(member, extraction_path)
File
Roundup Robot added the comment:
New changeset eb48295e1f8b by Victor Stinner in branch 'default':
Issue #23644, #22038: Move #include stdatomic.c inside the extern C { ... }
https://hg.python.org/cpython/rev/eb48295e1f8b
--
___
Python tracker
STINNER Victor added the comment:
Can you please try with the latest development version?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23644
___
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +Vitor.de.Lima
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23644
___
___
STINNER Victor added the comment:
The patch includes a unit test for POSIX.
For Windows, you can test manually using the attached sleep.py program: press
CTRL+c to send SIGINT signals.
--
Added file: http://bugs.python.org/file38455/sleep.py
___
New submission from STINNER Victor:
Attached patch changes time.sleep() to retry select() when select() is
interrupted by a signal or retry WaitForSingleObjectEx() when the signal SIGINT
is received on Windows.
The patch drops support for EMX, sorry! I didn't know EMX, I had to Google it:
New submission from Arnt Gulbrandsen:
http://stackoverflow.com/q/28923997 and various other SO questions point out
that imaplib's _MAXLINE value is a bit behind the times. Fine for 1997, when
people had 10MB mailbox quotas, not so fine for the age of gmail.
I'm tired of seeing those
New submission from STINNER Victor:
I created this issue to group all issues related to the implementation of the
PEP 475 Retry system calls failing with EINTR.
https://www.python.org/dev/peps/pep-0475/
- Issue #23646: the time module, retry sleep()
- Issue #23618: the socket module
- Issue
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +neologix
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23648
___
___
Gustavo Frederico Temple Pedrosa added the comment:
@haypo, @lbianc will investigate this issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23644
___
Changes by R. David Murray rdmur...@bitdance.com:
--
stage: - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23647
___
___
Changes by Srdjan Grubor sg...@sgnn7.org:
--
type: behavior - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23649
___
___
Srdjan Grubor added the comment:
Also, extract_member in tarfile.py is not thread-safe since the check for
folder existence might occur during another thread's creation of that same dir
causing the code to error out.
File /usr/lib/python3.4/concurrent/futures/thread.py, line 54, in run
Changes by Srdjan Grubor sg...@sgnn7.org:
--
type: enhancement - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23649
___
___
Berker Peksag added the comment:
Thanks Xavier and Mark.
--
components: +Tests -Library (Lib)
nosy: +berker.peksag
resolution: - fixed
stage: - resolved
status: open - closed
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
Srdjan Grubor added the comment:
The code around tarfile multi-threading was fixed for me on the user-side with
threading.Lock() usage so it might work to use this within the library and the
directory creation could be improved by probably doing a try/except around the
makedirs() call with
R. David Murray added the comment:
If you want to use an object that has state in more than one thread you
generally have to put some locking around it. Unless I'm missing something
(which I might be) I don't think it is tarfile's responsibility to do this.
--
nosy: +r.david.murray
New submission from François-Michel L'Heureux:
Using TreeBuilder to put data into XML tree.
Convert that tree to a string.
Parse that string.
XML parser error.
I expect XML library to be able to parse its own output.
Reference example:
R. David Murray added the comment:
Gmail breaks the standards again, eh? I suppose we'll have to accommodate them
;)
--
components: +email
nosy: +barry, r.david.murray
title: imaplib.py MAXLINE value is too low for 2015 (patch attached) -
imaplib.py MAXLINE value is too low for gmail
Roundup Robot added the comment:
New changeset 2b7cf33ccd74 by Berker Peksag in branch '3.4':
Issue #20617: Remove unused import in test_ssl.
https://hg.python.org/cpython/rev/2b7cf33ccd74
New changeset 07e8c0ae232c by Berker Peksag in branch 'default':
Issue #20617: Remove unused import in
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +haypo, lars.gustaebel
versions: +Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23649
___
Changes by François-Michel L'Heureux fm.lheur...@gmail.com:
--
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23650
___
___
François-Michel L'Heureux added the comment:
Note that you cannot copy paste the code and expect to reproduce the issue
because it contains special characters that cannot be copy pasted via a web
browser.
Here is the output when run.
?xml version='1.0' encoding='utf-8'?
topline2015-03-12
Srdjan Grubor added the comment:
I don't know if that's true of core libraries. Why complicate things for end
users when those issues could be done in the library itself and be completely
transparent to the devs? A simple RLock latch wouldn't pose almost any speed
degradation but would work
R. David Murray added the comment:
Use \x escapes to construct your example, then.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23650
___
Berker Peksag added the comment:
Good catch, Nathan. Thanks!
--
nosy: +berker.peksag
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23651
François-Michel L'Heureux added the comment:
Updated file where copy/pasting works.
--
Added file: http://bugs.python.org/file38460/python_xml_builder_bug.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23650
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23644
___
R. David Murray added the comment:
Sorry, I was being a facetious, but despite the smiley that wasn't clear. I
*have* run into a number of cases where gmail violates the standard, but I
wasn't really serious about this case.
--
___
Python tracker
New submission from Matt Frank:
With the LSB (Linux Standard Base) headers for libc Modules/selectmodule.c
fails to compile because we have code that uses EPOLLRDNORM, EPOLLRDBAND,
EPOLLWRNORM and EPOLLMSG without first checking that they are defined.
The patch wraps the five uses of
New submission from Nathan West:
A common Python idiom is to test objects by value in an if. This includes
container emptiness and regular expression matches, or using 'or' to specify a
default value:
if my_list:
# list isn't empty
if regex.match(string):
# string
Changes by Matt Frank matthew.i.fr...@intel.com:
--
type: - compile error
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23652
___
___
Arnt Gulbrandsen added the comment:
The RFC in question is 2683, which isn't a standard, it's just advice.
What gmail breaks is the expectation that mailboxes and seach results are
smallish. If you run a python script on gmail and it runs a search, the result
can be a great deal bigger than
Changes by Ned Deily n...@acm.org:
--
nosy: +neologix
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23652
___
___
Python-bugs-list mailing list
Srdjan Grubor added the comment:
After some thinking, for the makedirs it should only need
makedirs(exist_ok=True)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23649
___
Changes by Leonardo Bianconi leonardo.bianc...@eldorado.org.br:
--
nosy: +lbianc
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22038
___
___
Changes by Leonardo Bianconi leonardo.bianc...@eldorado.org.br:
--
nosy: +lbianc
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23644
___
___
Ned Deily added the comment:
This is a duplicate of Issue5166. Note that in your example, you are not
serializing valid XML 1.0: \x1b (ESC) is not a valid XML character, it has to
be escaped and, as the discussion in Issue5166 points out, etree does not
automatically do that for you.
Serhiy Storchaka added the comment:
Committed all except changes to multiprocessing.sharedctypes (remove
__getslice__ and __setslice__) and unittest.mock (remove __div__, add
__getnewargs_ex__).
--
___
Python tracker rep...@bugs.python.org
Alex Zhang added the comment:
Never mind, I used ccleaner and revo uninstaller to delete traces, then
reinstalled using the msi. Thanks for help, it's all good now!
--
resolution: - fixed
status: open - closed
___
Python tracker
STINNER Victor added the comment:
Le jeudi 12 mars 2015, Charles-François Natali rep...@bugs.python.org a
écrit :
As for the change to select/poll/etc, IIRC Guido was opposed to it,
that's why I didn't update them.
Wait what? can you elaborate? I'm not aware of that.
--
Roundup Robot added the comment:
New changeset 7522bb14e36a by Serhiy Storchaka in branch '3.4':
Issue #23641: Cleaned out legacy dunder names from tests and docs.
https://hg.python.org/cpython/rev/7522bb14e36a
New changeset 9332a545ad85 by Serhiy Storchaka in branch 'default':
Issue #23641:
Serhiy Storchaka added the comment:
Do you want first commit the patch in issue23581 Berker?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23641
___
Changes by François-Michel L'Heureux fm.lheur...@gmail.com:
Removed file: http://bugs.python.org/file38459/python_xml_builder_bug.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23650
___
Berker Peksag added the comment:
Do you want first commit the patch in issue23581 Berker?
I just committed it. Thanks for the review :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23641
New submission from Nathan West:
The documentation for the new argparse feature allow_abrev contains a typo:
parser.add_argument('--foobar', action='store_true')
parser.add_argument('--foonley', action='store_false')
parser.parse_args([--foon])
usage: PROG [-h] [--foobar] [--foonley]
PROG:
1 - 100 of 130 matches
Mail list logo
