[issue24018] add a Generator ABC

Stefan Behnel added the comment: > Please either > 1) drop the throw() method entirely or > 2) make throw an abstractmethod() Ok, as I already said, I think it's important to provide the complete protocol as code will usually expect that. Also, close() has a helpful implementation, but it dep

[issue9858] Python and C implementations of io are out of sync

Laura Rupprecht added the comment: There were originally three methods present in RawIOBase that were not present in PyRawIOBase_Type: 1. readinto 2. write 3. __weakref__ I've created a patch that adds the first two to PyRawIOBase_Type. The python class readinto and write methods raise Unsupp

[issue23955] Add python.ini file for embedded/applocal installs

Steve Dower added the comment: Having looked at the implementation, the easiest way to do this will be to add an "applocal = true" option to pyvenv.cfg, which would behave identically to setting %PYTHONHOME% to the directory containing the config before launch. I wanted to support relative pat

[issue23970] Update distutils.msvccompiler for VC14

Steve Dower added the comment: Made some updates to the patch to use the existing infrastructure for setting include and library paths, and to fix bdist_wininst. While it may be worth doing more significant restructuring to help people with overriding aspects of build, that's almost certainly

[issue23668] Support os.ftruncate on Windows

Changes by Steve Dower : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue24064] Make the property doctstring writeable

New submission from Raymond Hettinger: I can't see any reason for property docstrings to be readonly: >>> p = property(doc='basic') >>> p.__doc__ 'basic' >>> p.__doc__ = 'extended' Traceback (most recent call last): File "", line 1, in p.__doc__ = 'extended'

[issue23749] asyncio missing wrap_socket

Elizabeth Myers added the comment: For what it's worth, IRC has an optional STARTTLS extension which is implemented by some servers. IMAP and SMTP also have STARTTLS as a fundamental component of their protocols. As gc pointed out, LDAP also supports it. IMO this is a pretty glaring omission.

[issue16669] Docstrings for namedtuple

Raymond Hettinger added the comment: FWIW, here's a proposed new classmethod that makes it possible to easily customize the field docstrings but without cluttering the API of the factory function: @classmethod def _set_docstrings(cls, **docstrings): '''Customize the field docst

[issue23749] asyncio missing wrap_socket

Elizabeth Myers added the comment: What needs to be done to make this happen? I can try to implement it. -- nosy: +Elizacat ___ Python tracker ___ ___

[issue24018] add a Generator ABC

Guido van Rossum added the comment: I'm with Raymond. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue23910] C implementation of namedtuple (WIP)

Joe Jevnik added the comment: This was very exciting, I have never run gprof before; so just to make sure I did this correctly, I will list my steps: 1. compile with the -pg flag set 1. run the test with ./python -m timeit ... 1. $ gprof python gmon.out > profile.out Here is default: Each sam

[issue22619] Possible implementation of negative limit for traceback functions

Robert Collins added the comment: Nice, looks pretty elegant to me. I have nothing to add to the prior reviewers comments. -- ___ Python tracker ___

[issue23910] C implementation of namedtuple (WIP)

Raymond Hettinger added the comment: If you have a chance, run a C profiler so we can see whether most of the time is being spent in an attribute lookup for the current property(itemgetter) approach versus your nt-indexer approach. Without a profile, I have only my instincts that the overhead

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

Christie added the comment: @serhiy.storchaka - just double checking, do you guys need me to make any more changes to the patch? And is there any more review needed, or is it possible for this to be merged? Thanks very much! -- ___ Python tracker

[issue23910] C implementation of namedtuple (WIP)

Joe Jevnik added the comment: I was unable to see a performance increase by playing with the itemgetter.__call__ code; however, updating the propery code seemed to show a small improvement. I think that for simple indexing the cost of checking if it is a sequence outways the faster dispatch (w

[issue24061] Python 2.x breaks with address sanitizer

Roundup Robot added the comment: New changeset 4234b0dd2a54 by Benjamin Peterson in branch '2.7': allow 2.7 to be built with asan (closes #24061) https://hg.python.org/cpython/rev/4234b0dd2a54 -- nosy: +python-dev resolution: -> fixed stage: -> resolved status: open -> closed

[issue24018] add a Generator ABC

Raymond Hettinger added the comment: > Therefore, I think it's important to cover the complete protocol > in the Generator ABC. I also think it's helpful to not require > users to override throw() in a subclass, as they might not need it. Sorry, but I think you're fighting the fundament nature

[issue24017] Implemenation of the PEP 492 - Coroutines with async and await syntax

Yury Selivanov added the comment: In fact I will likely add tp_await in the next PEP iteration. I need it to implement another feature. -- ___ Python tracker ___ ___

[issue23910] C implementation of namedtuple (WIP)

Raymond Hettinger added the comment: One other thought: the itemgetter.__call__ method is already pretty thin: if (!PyArg_UnpackTuple(args, "itemgetter", 1, 1, &obj)) return NULL; if (nitems == 1) return PyObject_GetItem(obj, ig->item); But you could add a special case f

[issue24050] [2.7] crash in third party module mopidy

STINNER Victor added the comment: mopidy is not maintained by Python. Report the bug to mopidy authors: https://www.mopidy.com/ -- nosy: +haypo resolution: -> not a bug status: open -> closed title: Segmentation fault (core dumped) -> [2.7] crash in third party module mopidy _

[issue22057] The doc say all globals are copied on eval(), but only __builtins__ is copied

Antti Haapala added the comment: +1 for this patch, the current documentation states it very wrong. -- nosy: +ztane ___ Python tracker ___ ___

[issue24061] Python 2.x breaks with address sanitizer

Changes by Ned Deily : -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue23910] C implementation of namedtuple (WIP)

Raymond Hettinger added the comment: FWIW, the current property(itemgetter(index)) code has a Python creation step, but the actual attribute lookup and dispatch is done entirely in C (no pure python steps around the eval lookup). Rather than making a user visible C hack directly to namedtuple,

[issue22881] show median in benchmark results

Wolfgang Maier added the comment: ah sorry, it's late here already and I forgot what file this change is about. So forget my last comment then. -- ___ Python tracker ___ ___

[issue22881] show median in benchmark results

Wolfgang Maier added the comment: > It's not available in older Python versions, e.g. 2.6. I know, I was talking about 3.5+, of course. This would not be backported to Python2 anyway, would it? -- ___ Python tracker

[issue22881] show median in benchmark results

Stefan Behnel added the comment: > In general, wouldn't it be good to let the statistics module do all the stats > calculations? It's not available in older Python versions, e.g. 2.6. -- ___ Python tracker __

[issue22881] show median in benchmark results

Wolfgang Maier added the comment: for the even number case, I think you shouldn't do // 2, but / 2. In general, wouldn't it be good to let the statistics module do all the stats calculations? -- ___ Python tracker

[issue24018] add a Generator ABC

Stefan Behnel added the comment: PEP 342 isn't really conclusive here as it intended to define the protocol based on the de-facto design of a yield-based generator function. Trying to abstract from that poses the question how a class based generator implementation should look like. Specificall

[issue22881] show median in benchmark results

Changes by Wolfgang Maier : -- nosy: +wolma ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue23796] BufferedReader.peek() crashes if closed

John Hergenroeder added the comment: It looks like my contributor form has gone through -- what should my next steps here be? Thanks! -- ___ Python tracker ___ _

[issue24058] Compiler warning for readline extension

Roundup Robot added the comment: New changeset ec6ed10d611e by Benjamin Peterson in branch '3.4': remove extern definition, since it's in a header file (closes #24058) https://hg.python.org/cpython/rev/ec6ed10d611e New changeset 192f9efe4a38 by Benjamin Peterson in branch '2.7': remove extern de

[issue24058] Compiler warning for readline extension

Masayuki Yamamoto added the comment: I tried another two case changing variable declaration. First case of just removing "extern", Compiler similarly warns, and test passed. Second case of removing "_PyOS_ReadlineTState" declaration, Compiler has not warned, and test passed. First: $ hg diff di

[issue24063] Support Mageia and Arch Linux in the platform module

New submission from Rémi Verschelde: Support for Mageia and Arch Linux was added in the platform module for Python 3.x [1, 2], but the fix was not backported to the 2.7.x branch. It would be nice to see these fixes cherry-picked for the incoming 2.7.10 release. [1] https://hg.python.org/cpyth

[issue24018] add a Generator ABC

Antoine Pitrou added the comment: I think the throw() method should be required. If you don't need throw(), send() or close(), then you aren't really asking for a full-blown generator: you are asking for an iterator, so you can just check for collections.Iterator. (PS: why is this bug assigned

[issue24018] add a Generator ABC

Raymond Hettinger added the comment: In the lastest patch, the close() method is now a valid mixin method. However, the throw() method should be made abstract because it doesn't provide the required operation (it doesn't even use the "self" argument) or it should be left out entirely (i.e. N

[issue24062] links to os.stat() in documentation lead to stat module instead

New submission from July Tikhonov: Documentation of os.fstat() https://docs.python.org/3/library/os.html#os.fstat has a "See also:" section, which features a wrong link. The same with os.lstat(). Some of this problem was fixed (among other things) in issue 10960. But since then, two more wrong

[issue5784] raw deflate format and zlib module

paul rubin added the comment: Hey, thanks for updating this. I still remember the nasty incident that got me filing this report in the first place. I'll look at the patch more closely when I get a chance, but the immediate comment I'd make is it's worth adding a sentence saying explicitly to

[issue22544] Inconsistent cmath.log behaviour

Mark Dickinson added the comment: Per: yes, that's true. I don't think changing either division or multiplication is the way forward for this issue, though; I'd rather implement the less invasive change where `cmath.log` special-cases the situation where its second argument is real and positiv

[issue24059] Minor speed and readability improvement to the random module

Tim Peters added the comment: Good catch, Mark! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue24059] Minor speed and readability improvement to the random module

Mark Dickinson added the comment: Ah, I missed that the issue was already closed. Apologies for the excitement and the gratuitous exclamation marks in my previous messages. -- ___ Python tracker _

[issue24059] Minor speed and readability improvement to the random module

Mark Dickinson added the comment: Timing results on my machine: (Canopy 64bit) taniyama:~ mdickinson$ python3 -m timeit -s "from math import sqrt; x = 3.14" "sqrt(x)" 1000 loops, best of 3: 0.0426 usec per loop (Canopy 64bit) taniyama:~ mdickinson$ python3 -m timeit -s "from math import sq

[issue24017] Implemenation of the PEP 492 - Coroutines with async and await syntax

Yury Selivanov added the comment: > Could we have type slots for the new special methods? Otherwise, implementing > the protocol in C would be fairly inefficient, especially for async iteration. I don't think it's necessary to have slots for __aiter__, __anext__, __aenter__ and __aexit__. Asy

[issue24059] Minor speed and readability improvement to the random module

Mark Dickinson added the comment: Gah! Peephole optimizer! When you do a timeit for '3.14 ** 0.5', you're just evaluating the time to retrieve a constant! In general, `**` is going to be both slower *and* less accurate than math.sqrt. Please don't make this change! --

[issue23496] Steps for Android Native Build of Python 3.4.2

Cyd Haselton added the comment: On a related note, I managed to get pip working with this build...minus some errors with verbose mode. I first had to make some edits to setup.py and Modules/Setup so that the build would find and make the _ssl and lzip modules. After running make install, I ra

[issue24053] Define EXIT_SUCCESS and EXIT_FAILURE constants in sys

Antoine Pitrou added the comment: Those should be in the os module, not in sys. The os module is for interfaces to the operating system, while the sys module is for Python-specific stuff. As for the point of adding them, I don't find them useful, but I won't oppose it either :-) -- no

[issue23996] _PyGen_FetchStopIterationValue() crashes on unnormalised exceptions

Antoine Pitrou added the comment: Thanks for the patch! -- resolution: -> fixed stage: -> resolved status: open -> closed versions: -Python 3.3 ___ Python tracker ___

[issue23996] _PyGen_FetchStopIterationValue() crashes on unnormalised exceptions

Roundup Robot added the comment: New changeset 15c80f63ea1c by Antoine Pitrou in branch '3.4': Issue #23996: Avoid a crash when a delegated generator raises an unnormalized StopIteration exception. Patch by Stefan Behnel. https://hg.python.org/cpython/rev/15c80f63ea1c New changeset 9d0c6c66b0a

[issue24058] Compiler warning for readline extension

Benjamin Peterson added the comment: Does simply removing the "extern" work? -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue24059] Minor speed and readability improvement to the random module

Raymond Hettinger added the comment: Okay, I give up. -- resolution: -> rejected status: open -> closed ___ Python tracker ___ ___ Py

[issue13567] HTTPError interface changes / breaks depending on what was passed to constructor

Changes by Demian Brecht : -- nosy: +demian.brecht ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue24017] Implemenation of the PEP 492 - Coroutines with async and await syntax

Stefan Behnel added the comment: Could we have type slots for the new special methods? Otherwise, implementing the protocol in C would be fairly inefficient, especially for async iteration. I'm asking because Cython's generator type is not Python's generator type, but implementing the rest of

[issue24061] Python 2.x breaks with address sanitizer

Changes by Hanno Boeck : -- type: -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue24061] Python 2.x breaks with address sanitizer

New submission from Hanno Boeck: Right now it is not possible to build python 2.7.9 with address sanitizer. This issue has been worked around for python 3 in bug #18596 by marking some functions with attributes to tell address sanitizer to ignore them. I have attached a patch that will apply t

[issue24018] add a Generator ABC

Ludovic Gasc added the comment: Sorry guys to be basic for you, but if I take my "AsyncIO end-user" hat, I'm not sure to understand the potential end-user source code impacts to use Cython with Python 3.5 and AsyncIO. In concrete terms, it's only a low-level change, Cython will monkeypatch CP

[issue23852] Wrong computation of max_fd on OpenBSD

Changes by Berker Peksag : -- stage: patch review -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue24021] Add docstring to urllib.urlretrieve

Changes by Berker Peksag : -- keywords: +easy stage: -> needs patch title: document urllib.urlretrieve -> Add docstring to urllib.urlretrieve type: -> enhancement versions: +Python 3.4, Python 3.5 ___ Python tracker

[issue23356] In argparse docs simplify example about argline

Berker Peksag added the comment: Thanks py.user. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ _

[issue23356] In argparse docs simplify example about argline

Roundup Robot added the comment: New changeset 050e0c0b3d90 by Berker Peksag in branch '2.7': Issue #23356: Simplify convert_arg_line_to_args example. https://hg.python.org/cpython/rev/050e0c0b3d90 -- ___ Python tracker

[issue23356] In argparse docs simplify example about argline

Roundup Robot added the comment: New changeset bd8b99034121 by Berker Peksag in branch '3.4': Issue #23356: Simplify convert_arg_line_to_args example. https://hg.python.org/cpython/rev/bd8b99034121 New changeset 2d3ed019bc9f by Berker Peksag in branch 'default': Issue #23356: Simplify convert_ar

[issue22881] show median in benchmark results

Stefan Behnel added the comment: Any more comments on the patch, or can it be applied? -- ___ Python tracker ___ ___ Python-bugs-list

[issue23342] run() - unified high-level interface for subprocess

Changes by Berker Peksag : -- stage: commit review -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9951] introduce bytes.hex method (also for bytearray and memoryview)

Changes by Berker Peksag : -- stage: commit review -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue23996] _PyGen_FetchStopIterationValue() crashes on unnormalised exceptions

Changes by Stefan Behnel : -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue20485] Enable non-ASCII extension module names

Stefan Behnel added the comment: PEP 489 (Redesigning extension module loading) includes the proposal to fix this by using punycode. -- ___ Python tracker ___ __

[issue22486] Add math.gcd()

Stefan Behnel added the comment: Any more comments on this? The deadlines for new features in Py3.5 are getting closer. It seems we're just discussing details here, but pretty much everyone wants this feature. So, what are the things that still need to be done? Serhiy submitted working patche