[issue28184] Trailing whitespace in C source code

2016-09-16 Thread Francisco Couzo
Changes by Francisco Couzo : Added file: http://bugs.python.org/file44706/trailing_whitespace2.patch ___ Python tracker ___

[issue27761] Private _nth_root function loses accuracy

2016-09-16 Thread Tim Peters
Tim Peters added the comment: Let me give complete code for the last idea, also forcing the scaling multiplication to use the correct context: import decimal c = decimal.DefaultContext.copy() c.prec = 25 c.Emax = decimal.MAX_EMAX c.Emin = decimal.MIN_EMIN def erootn(x,

[issue28184] Trailing whitespace in C source code

2016-09-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Modules/expat/expat.h and Modules/expat/expat_external.h are external files. They should left unchanged. -- nosy: +ned.deily, serhiy.storchaka ___ Python tracker

[issue28145] Fix whitespace in C source code

2016-09-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: See also issue15550 and issue8912. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue28185] Tabs in C source code

2016-09-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- dependencies: +Misleading Indentation in C source code nosy: +serhiy.storchaka ___ Python tracker

[issue27806] 2.7 32-bit builds fail on macOS 10.12 Sierra due to dependency on deleted header file QuickTime/QuickTime.h

2016-09-16 Thread Ned Deily
Ned Deily added the comment: Thanks, Alexander and especially Jeremy, for the reviews and suggestions. Thanks again sashk for the patches. Committed for release in 2.7.13. -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed title: 2.7 32-bit builds fail on

[issue26149] Suggest PyCharm Community as an editor for Unix platforms

2016-09-16 Thread Guido van Rossum
Guido van Rossum added the comment: You did the right thing. Check out the "review" link. -- ___ Python tracker ___

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4030300fcb18 by sashk in branch '2.7': Issue #27806: Fix 32-bit builds on macOS Sierra 10.12 broken by removal of https://hg.python.org/cpython/rev/4030300fcb18 -- nosy: +python-dev ___ Python tracker

[issue26149] Suggest PyCharm Community as an editor for Unix platforms

2016-09-16 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: Hmm.. not sure if I did this correctly. I uploaded another patch file, is this right? Or, how can I edit my original patch? Thanks. -- ___ Python tracker

[issue26149] Suggest PyCharm Community as an editor for Unix platforms

2016-09-16 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: Thanks for the feedback :) As suggested, I removed all other IDEs and just link to the wiki. -- Added file: http://bugs.python.org/file44705/docupdate2.patch ___ Python tracker

[issue28168] Use _winapi.WaitForMultipleObjects in Popen.wait()

2016-09-16 Thread STINNER Victor
STINNER Victor added the comment: > I decided to make it an error to pass an empty sequence It makes sense since the original WaitForMultipleObjects() also requires at least one object: https://msdn.microsoft.com/en-us/library/windows/desktop/ms687025(v=vs.85).aspx nCount [in] The

[issue28168] Use _winapi.WaitForMultipleObjects in Popen.wait()

2016-09-16 Thread STINNER Victor
STINNER Victor added the comment: Oh nice, you implemented the PEP 475 for _winapi.WaitForMultipleObjects()! I missed this function when implementing this PEP :-) -- nosy: +haypo ___ Python tracker

[issue28185] Tabs in C source code

2016-09-16 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue28185] Tabs in C source code

2016-09-16 Thread Francisco Couzo
Changes by Francisco Couzo : Added file: http://bugs.python.org/file44704/tabs_h.patch ___ Python tracker ___

[issue28185] Tabs in C source code

2016-09-16 Thread Francisco Couzo
Changes by Francisco Couzo : Removed file: http://bugs.python.org/file44703/tabs_h.patch ___ Python tracker ___

[issue28185] Tabs in C source code

2016-09-16 Thread Francisco Couzo
Changes by Francisco Couzo : -- versions: +Python 3.7 Added file: http://bugs.python.org/file44703/tabs_h.patch ___ Python tracker

[issue28185] Tabs in C source code

2016-09-16 Thread Francisco Couzo
New submission from Francisco Couzo: Files I didn't change: Python/dup2.c, Python/strdup.c (Since they are external dependencies) -- files: tabs_c.patch keywords: patch messages: 276762 nosy: franciscouzo, josh.r, mark.dickinson, martin.panter, r.david.murray, terry.reedy priority:

[issue28184] Trailing whitespace in C source code

2016-09-16 Thread Francisco Couzo
New submission from Francisco Couzo: As per Terry's recommendations (#28145), I'm going to open a new issue for each case. -- files: trailing_whitespace.patch keywords: patch messages: 276761 nosy: franciscouzo, josh.r, mark.dickinson, martin.panter, r.david.murray, terry.reedy

[issue28168] Use _winapi.WaitForMultipleObjects in Popen.wait()

2016-09-16 Thread Eryk Sun
Eryk Sun added the comment: Hopefully this is my last change until someone reviews this. I decided to make it an error to pass an empty sequence, which previously would implicitly wait on the SIGINT event. This way simplifies the code and prevents someone from accidentally waiting forever on

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-16 Thread sashk
sashk added the comment: Ned, please see attached third version of the patch with workaround suggested by Jeremy for older versions of OS X. -- Added file: http://bugs.python.org/file44699/issue27806_v3.patch ___ Python tracker

[issue28168] Use _winapi.WaitForMultipleObjects in Popen.wait()

2016-09-16 Thread Eryk Sun
Changes by Eryk Sun : Added file: http://bugs.python.org/file44698/issue_28168_03.patch ___ Python tracker ___

[issue28168] Use _winapi.WaitForMultipleObjects in Popen.wait()

2016-09-16 Thread Eryk Sun
Changes by Eryk Sun : Removed file: http://bugs.python.org/file44673/issue_28168_01.patch ___ Python tracker ___

[issue28168] Use _winapi.WaitForMultipleObjects in Popen.wait()

2016-09-16 Thread Eryk Sun
Changes by Eryk Sun : Removed file: http://bugs.python.org/file44674/issue_28168_02.patch ___ Python tracker ___

[issue22493] Deprecate the use of flags not at the start of regular expression

2016-09-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Patch LGTM (but I changed tests a little). Thanks Tim! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue22493] Deprecate the use of flags not at the start of regular expression

2016-09-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset c35a528268fd by Serhiy Storchaka in branch '3.6': Issue #22493: Warning message emitted by using inline flags in the middle of https://hg.python.org/cpython/rev/c35a528268fd New changeset 9d0f4da4d531 by Serhiy Storchaka in branch 'default': Issue

[issue28183] Clean up and speed up dict iteration

2016-09-16 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +methane, xiang.zhang ___ Python tracker ___

[issue27761] Private _nth_root function loses accuracy

2016-09-16 Thread Tim Peters
Tim Peters added the comment: Oops! The `D2**e` in that code should be `pow(D2, e)`, to make it use the correct decimal context. -- ___ Python tracker

[issue28183] Clean up and speed up dict iteration

2016-09-16 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: In some circumstances iterating dict under 3.6 can be 20% slower than under 3.5. $ ./python -m perf timeit -s "d = dict.fromkeys(range(10**6))" -- "list(d)" Python 3.5: Median +- std dev: 33.8 ms +- 0.7 ms Python 3.6: Median +- std dev: 37.8 ms +- 0.5 ms

[issue27761] Private _nth_root function loses accuracy

2016-09-16 Thread Tim Peters
Tim Peters added the comment: Mark, thanks for the counterexample! I think I can fairly accuse you of thinking ;-) I expect the same approach would be zippy for scaling x by 2**e, provided that the scaled value doesn't exceed the dynamic range of the decimal context. Like so: def

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-16 Thread Jeremy Sequoia
Jeremy Sequoia added the comment: sys/cdefs.h (on new enough darwin) does this for such cases: #ifndef __has_include #define __has_include(x) 0 #endif but of course that isn't present in sys/cdefs.h on older SDKs, so you can just shove that above the check and it should fallback the way you

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-16 Thread Ned Deily
Ned Deily added the comment: sashk, thanks for the patches! The general approach LGTM as well. Unfortunately, we need the fix to work with gcc-4.2 since the Python 2.7 installers are still built and supported on OS X 10.5 and 10.6 and the __has_include preprocessor construct is not

[issue16902] Add OSS module support for Solaris

2016-09-16 Thread Tim Mooney
Tim Mooney added the comment: Sooo It's been 3 years. Brian's patch has bit-rotted a bit, but it's easy to update for recent Python. What are the hold-ups to getting this applied? -- ___ Python tracker

[issue16700] Document that bytes OS API can returns unusable results on Windows

2016-09-16 Thread Mark Lawrence
Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue28179] Segfault in test_recursionlimit_fatalerror

2016-09-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +ned.deily priority: normal -> release blocker ___ Python tracker ___

[issue28179] Segfault in test_recursionlimit_fatalerror

2016-09-16 Thread Terry J. Reedy
Terry J. Reedy added the comment: Running with fresh build from IDLE in a subprocess on Win10, with 15 instead of 10, I quickly get a fatal Python error and the Windows box equivalent to a segfault. -- nosy: +terry.reedy ___ Python tracker

[issue15443] datetime module has no support for nanoseconds

2016-09-16 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Another advantage of a single nanoseconds field is that currently microseconds are packed in 3 bytes and nanoseconds would fit in 4 - a 1 byte increase, but to add a 0-999 field, one would need at least 2 bytes. -- versions: +Python 3.7 -Python

[issue15443] datetime module has no support for nanoseconds

2016-09-16 Thread Steve Holden
Steve Holden added the comment: I agree on reflection that a single nanoseconds integral value makes more sense. This then requires refactoring of the existing code so that existing tests continue to pass using a microsecond property. Code using ONLY nanoseconds is a disjoint case, for which

[issue28145] Fix whitespace in C source code

2016-09-16 Thread Terry J. Reedy
Terry J. Reedy added the comment: Converting tabs to spaces and deleting trailing whitespace are separate issues and should be discussed and possibly done separately. I think trailing whitespace should be uniformly fixed and prohibited for C files as it seems to be for most other files, for

[issue22493] Deprecate the use of flags not at the start of regular expression

2016-09-16 Thread Tim Graham
Tim Graham added the comment: Yes, I found that Django needs an update to support that syntax in URLpatterns. Thanks. -- ___ Python tracker ___

[issue25283] Make tm_gmtoff and tm_zone available on all platforms

2016-09-16 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: The problem of computing tm_gmtoff on platforms without it was solved by tzcode some time ago. [1,2] Consider stealing some of their logic. [1]: http://mm.icann.org/pipermail/tz/2014-September/021601.html [2]:

[issue27761] Private _nth_root function loses accuracy

2016-09-16 Thread Mark Dickinson
Mark Dickinson added the comment: > And it's still the case that I haven't found a case where its result isn't > correctly rounded. Here's one: :-) >>> rootn(1 + 2**-52, 2) 1.0002 The correctly rounded result would be 1.0. -- ___

[issue27761] Private _nth_root function loses accuracy

2016-09-16 Thread Mark Dickinson
Mark Dickinson added the comment: > Decimal pow doesn't special-case integer exponents; the solution will still > be based on exp and ln. Ah, sorry; I'm wrong. That was true for the Python version of the decimal module, not for the C implementation. --

[issue27761] Private _nth_root function loses accuracy

2016-09-16 Thread Mark Dickinson
Mark Dickinson added the comment: > It does use the Decimal pow(), but with an integer exponent, so this specific > use of pow() doesn't invoke the Decimal exp() or ln() either. Decimal pow doesn't special-case integer exponents; the solution will still be based on exp and ln. --

[issue27761] Private _nth_root function loses accuracy

2016-09-16 Thread Mark Dickinson
Mark Dickinson added the comment: > Mark, the code I showed in roots.py is somewhat more accurate and highly > significantly faster than the code you just posted. Okay, fair enough. In that case, we still need a solution for computing rootn(x * 2**e) in the case where x*2**e itself overflows

[issue16700] Document that bytes OS API can returns unusable results on Windows

2016-09-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Maybe this issue is outdated in 3.6 (thanks to PEP 529), but this still is a problem under 3.5 and 2.7. -- status: closed -> open versions: +Python 3.5 -Python 3.3, Python 3.4 ___ Python tracker

[issue27761] Private _nth_root function loses accuracy

2016-09-16 Thread Tim Peters
Tim Peters added the comment: Mark, the code I showed in roots.py is somewhat more accurate and highly significantly faster than the code you just posted. It's not complicated at all: it just uses Decimal to do a single Newton correction with extended precision. Since it doesn't use the

[issue28111] geometric_mean can raise OverflowError for large input length

2016-09-16 Thread Mark Dickinson
Changes by Mark Dickinson : -- title: geometric_mean can raise OverflowError when checking for inf -> geometric_mean can raise OverflowError for large input length ___ Python tracker

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-16 Thread Jeremy Sequoia
Jeremy Sequoia added the comment: Thanks, yep that looks much nicer to me. Containing the core logic at a central choke point makes maintenance much easier. I'll work to get this into MacPorts. -- ___ Python tracker

[issue27922] Make IDLE tests less flashy

2016-09-16 Thread Terry J. Reedy
Terry J. Reedy added the comment: It is more a matter of tradeoffs rather than 'okay'. There is no general pydev rule against gui flashing. The tk and ttk gui tests still do, but that is primarily Serhiy's concern. The IDLE tests are at most perhaps a third complete, so they would have

[issue28176] Fix callbacks race in asyncio.SelectorLoop.sock_connect

2016-09-16 Thread STINNER Victor
STINNER Victor added the comment: The timeout of 3 seconds seem to be too short for some buildbots like "AMD64 FreeBSD CURRENT Non-Debug 3.x". http://buildbot.python.org/all/builders/AMD64%20FreeBSD%20CURRENT%20Non-Debug%203.x/builds/295/steps/test/logs/stdio

[issue27761] Private _nth_root function loses accuracy

2016-09-16 Thread Mark Dickinson
Mark Dickinson added the comment: Here's the error analysis, for the record. It's crude, but effective. Assume our decimal context precision is p (so p = 20 for the above code). 1. d is represented exactly with value in [1.0, 2.0). (Conversions from float to Decimal are exact.) 2. c.ln(d)

[issue24416] Return a namedtuple from date.isocalendar()

2016-09-16 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- assignee: -> belopolsky nosy: +belopolsky versions: +Python 3.7 -Python 3.6 ___ Python tracker

[issue26149] Suggest PyCharm Community as an editor for Unix platforms

2016-09-16 Thread Guido van Rossum
Guido van Rossum added the comment: Hm, maybe the list should just removed and only the link to the wiki preserved? Agreed that the list here feels outdated. And updating it is always going to be a political game (e.g. why isn't Wing IDE listed?) -- nosy: +gvanrossum

[issue28111] geometric_mean can raise OverflowError when checking for inf

2016-09-16 Thread Mark Dickinson
Mark Dickinson added the comment: See msg276732 in issue 27761 for a possible solution. -- ___ Python tracker ___

[issue27761] Private _nth_root function loses accuracy

2016-09-16 Thread Mark Dickinson
Mark Dickinson added the comment: I think this whole nth root discussion has become way more complicated than it needs to be, and there's a simple and obvious solution. Two observations: 1. What we actually need is not nth_root(x), but nth_root(x*2**e) for a float x and integer e. That's

[issue28128] Improve the warning message for invalid escape sequences

2016-09-16 Thread Eric V. Smith
Eric V. Smith added the comment: Tim: Cool! That's way more useful than I thought it would be. Serhiy: It's a proof of concept. Lots of design remains to be done. I'm not sure we've agreed on the concept yet, so I don't think it's worthwhile designing the API. --

[issue28128] Improve the warning message for invalid escape sequences

2016-09-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The basic concept LGTM. first_invalid_escape_char is redundant, it is just s[first_invalid_escape_idx]. Or maybe better to return a pointer instead of an index. bytes literals need similar solution. -- ___

[issue1284316] Win32: Security problem with default installation directory

2016-09-16 Thread Mark Lawrence
Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue28180] sys.getfilesystemencoding() should default to utf-8

2016-09-16 Thread STINNER Victor
STINNER Victor added the comment: > is this someday already?) Not yet :-) -- ___ Python tracker ___ ___

[issue28128] Improve the warning message for invalid escape sequences

2016-09-16 Thread Tim Graham
Tim Graham added the comment: Eric, your patch was good enough to allow me to easily identify and fix all the warnings in Django: https://github.com/django/django/pull/7254. Thanks! -- ___ Python tracker

[issue26081] Implement asyncio Future in C to improve performance

2016-09-16 Thread Rémi Cardona
Changes by Rémi Cardona : -- nosy: +RemiCardona ___ Python tracker ___ ___ Python-bugs-list

[issue1284316] Win32: Security problem with default installation directory

2016-09-16 Thread Steve Dower
Steve Dower added the comment: Changing the default install directory in a maintenance release is not okay. Users who are concerned about security can change the install directory, and bugs that arise as a result will be considered on their own merits. Alternatively, you can obtain Python 2.7

[issue28147] Unbounded memory growth resizing split-table dicts

2016-09-16 Thread INADA Naoki
INADA Naoki added the comment: This is patch for Python 3.5. The patch uses more conservative approach. -- Added file: http://bugs.python.org/file44696/fix-28147-py35.patch ___ Python tracker

[issue28151] testPythonOrg() of test_robotparser fails on validating python.org HTTPS certificate

2016-09-16 Thread Berker Peksag
Berker Peksag added the comment: Here's a patch that uses pythontest.net. -- keywords: +patch stage: needs patch -> patch review Added file: http://bugs.python.org/file44695/issue28151.diff ___ Python tracker

[issue28182] Expose OpenSSL verification results in SSLError

2016-09-16 Thread Chi Hsuan Yen
New submission from Chi Hsuan Yen: This was originally a post at python-ideas. Now I reformat it to be more like a feature request. Currently, Python raises SSLError with reason=CERTIFICATE_VERIFY_FAILED for all kinds of certificate verification failures. This results in difficulties in

[issue27973] urllib.urlretrieve() fails on second ftp transfer

2016-09-16 Thread Sohaib Ahmad
Sohaib Ahmad added the comment: Hi Senthil, Thanks for the review. Now that I look at it, even with a default value, an ftp specific parameter sure does break the open() API abstraction. -- ___ Python tracker

[issue28180] sys.getfilesystemencoding() should default to utf-8

2016-09-16 Thread R. David Murray
R. David Murray added the comment: I thought we "fixed" this by using surrogate escape when the locale was ASCII? We certainly have discussed changing the default and posix and so far have decided not to (someday that will change...is this someday already?) -- nosy: +r.david.murray

[issue27391] server_hostname should only be required when checking host names

2016-09-16 Thread Guido van Rossum
Changes by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___

[issue28143] ASDL compatibility with Python 3 system interpreter

2016-09-16 Thread R. David Murray
R. David Murray added the comment: If we go that route it doesn't, from a certain point of view, solve the problem for systems that *only* ship python3...but I think we can ignore that issue: IMO it would be fine in that scenario to say that if you want to run the python2 regen scripts you

[issue28128] Improve the warning message for invalid escape sequences

2016-09-16 Thread Emanuel Barry
Emanuel Barry added the comment: Personally I'd be fine with only one warning, reporting the first invalid escape. Presumably the string would be checked as a whole, or would get an r prefix. Patch seems like a good start; bytes would also need updating in that regard. Don't worry too much

[issue25270] codecs.escape_encode systemerror on empty byte string

2016-09-16 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the reviews everyone! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue25270] codecs.escape_encode systemerror on empty byte string

2016-09-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2a4fb01fa1a3 by Berker Peksag in branch '3.5': Issue #25270: Prevent codecs.escape_encode() from raising SystemError when an empty bytestring is passed https://hg.python.org/cpython/rev/2a4fb01fa1a3 New changeset 8a649009a0e9 by Berker Peksag in

[issue28128] Improve the warning message for invalid escape sequences

2016-09-16 Thread Eric V. Smith
Eric V. Smith added the comment: Also, I assume this is a problem with all such syntax warnings: you only see this warning/error when the file is originally compiled. Once the .pyc file exists, you'll never see a warning or error. Maybe that's okay, but it means there's a certain class of

[issue28128] Improve the warning message for invalid escape sequences

2016-09-16 Thread Eric V. Smith
Eric V. Smith added the comment: I forgot: this is what Nick's example now looks like: $ ./python -Wall escape_warning.py Traceback (most recent call last): File "escape_warning.py", line 1, in import bad_escape File "/home/eric/local/python/cpython/bad_escape.py", line 1

[issue28128] Improve the warning message for invalid escape sequences

2016-09-16 Thread Eric V. Smith
Eric V. Smith added the comment: Here is an extremely rough patch that shows the basic concept. I named the private function _PyUnicode_DecodeUnicodeEscape. The problems with this patch are: 1. it always raises an error, not a warning 2. the private function isn't declared in a .h file 3. the

[issue27973] urllib.urlretrieve() fails on second ftp transfer

2016-09-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: Hi Sohaib, I will get the proper fix for this issue. A comment on the patch. Changing the API to `def open(self, fullurl, data=None, ftp_retrieve=False):` just breaks the abstraction of the open method and may not be the way to go for this. Any changes

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-16 Thread sashk
sashk added the comment: Thank you for feedback. Here is second version of the patch. -- Added file: http://bugs.python.org/file44693/issue27806_v2.patch ___ Python tracker

[issue28181] Change URL in antigravity library file

2016-09-16 Thread Kaartic Sivaraam
Kaartic Sivaraam added the comment: Don't Mention. It was my long time wish to contribute to open source projects. -- ___ Python tracker ___

[issue28123] _PyDict_GetItem_KnownHash ignores DKIX_ERROR return

2016-09-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +rhettinger, serhiy.storchaka ___ Python tracker ___

[issue27391] server_hostname should only be required when checking host names

2016-09-16 Thread Jim Fulton
Jim Fulton added the comment: I'm not ignoring anything AFAICT. There are applications where server hostname isn't useful (no virtual hosts, client has server's public key). I'm not positive we're disagreeing, so let me put this another way. 1. If the given SSL context has check_hostname set

[issue27386] Asyncio server hang when clients connect and immediately disconnect

2016-09-16 Thread Jim Fulton
Jim Fulton added the comment: Cool, I will verify soon. -- ___ Python tracker ___ ___ Python-bugs-list

[issue28180] sys.getfilesystemencoding() should default to utf-8

2016-09-16 Thread Jan Niklas Hasse
Jan Niklas Hasse added the comment: Unfortunately no, as this would mean I'll have to change all my python invocations in my scripts and it wouldn't work for executable files with #!/usr/bin/env python3 would it? -- ___ Python tracker

[issue28123] _PyDict_GetItem_KnownHash ignores DKIX_ERROR return

2016-09-16 Thread Xiang Zhang
Xiang Zhang added the comment: Hah, Okay. I'll make the corresponding change then. -- ___ Python tracker ___

[issue28180] sys.getfilesystemencoding() should default to utf-8

2016-09-16 Thread STINNER Victor
STINNER Victor added the comment: > This is a duplicate of issue27781. issue27781 is specific to Windows. I'm not sure that it's the base in this issue. So I reopen the issue. @Jan Niklas Hasse: What is your OS? I proposed to add "-X utf8" command line option for UNIX to force utf8

[issue28123] _PyDict_GetItem_KnownHash ignores DKIX_ERROR return

2016-09-16 Thread STINNER Victor
STINNER Victor added the comment: Xiang Zhang: "I am still afraid changing it may break knowledge of devs that are already familiar with dict APIs" Come on, the function is only called 4 times in the whole code base, and the function is private. Private means that we are free to break its

[issue28181] Change URL in antigravity library file

2016-09-16 Thread Christian Heimes
Christian Heimes added the comment: Thanks for your contribution! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue28181] Change URL in antigravity library file

2016-09-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset b8ac4ee42ad3 by Christian Heimes in branch '3.5': Issue #28181: Get antigravity over HTTPS. Patch by Kaartic Sivaraam. https://hg.python.org/cpython/rev/b8ac4ee42ad3 New changeset 0820d023077e by Christian Heimes in branch '3.6': Issue #28181: Get

[issue28158] Implement LOAD_GLOBAL opcode cache

2016-09-16 Thread Antti Haapala
Antti Haapala added the comment: I wouldn't actually consider the builtin lookup speed almost at all, in all non-trivial applications the ratio of builtins to any other names will diminish; and if there is a tight loop, it is possible to always speed it up by `min = min` if you do not need to

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

2016-09-16 Thread Berker Peksag
Berker Peksag added the comment: Thank you Gergely and Markus! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

2016-09-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset a5e8fe666c6b by Berker Peksag in branch '3.5': Issue #25895: Enable WebSocket URL schemes in urllib.parse.urljoin https://hg.python.org/cpython/rev/a5e8fe666c6b New changeset 9bf370a33938 by Berker Peksag in branch '3.6': Issue #25895: Merge from

[issue27973] urllib.urlretrieve() fails on second ftp transfer

2016-09-16 Thread Sohaib Ahmad
Sohaib Ahmad added the comment: The attached patch fixes the problem with multiple ftp downloads while keeping the fix for issue1067702 intact. The fix basically uses a new parameter ftp_retrieve to change the behavior of ftpwrapper.retrfile() if it is being called by urlretrieve(). I am not

[issue25270] codecs.escape_encode systemerror on empty byte string

2016-09-16 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the review, Serhiy. Here's an updated patch. -- Added file: http://bugs.python.org/file44691/issue25270_v3.diff ___ Python tracker

[issue28128] Improve the warning message for invalid escape sequences

2016-09-16 Thread Eric V. Smith
Eric V. Smith added the comment: Couldn't we create a private version of PyUnicode_DecodeUnicodeEscape, to be called by ast.c, which passes back invalid escape info? Then have the actual warning raised by ast.c, which knows enough about the context to generate a better error/warning. I think

[issue28181] Change URL in antigravity library file

2016-09-16 Thread Christian Heimes
Christian Heimes added the comment: xkcd redirects http to https. It makes sense to fix the module and use https. -- nosy: +christian.heimes stage: -> patch review versions: +Python 3.5, Python 3.6 ___ Python tracker

[issue28158] Implement LOAD_GLOBAL opcode cache

2016-09-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There is too much magic in ceval_cache.h. Since the patch adds caching only for the LOAD_GLOBAL opcode, it would much clearer if write functions only for the LOAD_GLOBAL opcode, without multilayer macros. What will happen if there more than 255

[issue28181] Change URL in antigravity library file

2016-09-16 Thread Kaartic Sivaraam
New submission from Kaartic Sivaraam: I use a network that is monitored and filtered by Cyberoam. The use Cyberoam to block some websites, and some content. I came to know of the antigravity easter egg recently. I tried it using 'import antigravity' and it opened the xkcd website as

[issue28180] sys.getfilesystemencoding() should default to utf-8

2016-09-16 Thread Emanuel Barry
Emanuel Barry added the comment: This is a duplicate of issue27781. -- nosy: +ebarry resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Change sys.getfilesystemencoding() on Windows to UTF-8 ___ Python tracker

[issue28180] sys.getfilesystemencoding() should default to utf-8

2016-09-16 Thread Jan Niklas Hasse
New submission from Jan Niklas Hasse: Working with Docker I often end up with an environment where the locale isn't correctly set. In these cases it would be great if sys.getfilesystemencoding() could default to 'utf-8' instead of 'ascii', as it's the encoding of the future and ascii is a

[issue27415] regression: BaseEventLoop.create_server does not accept port=None

2016-09-16 Thread Marcus Cobden
Marcus Cobden added the comment: Ah thanks, that's fair. It seems a shame since this regression was introduced to 3.4 by a security/bugfix release. Since there's a workaround it's not a big deal. -- ___ Python tracker

[issue27415] regression: BaseEventLoop.create_server does not accept port=None

2016-09-16 Thread Berker Peksag
Berker Peksag added the comment: 3.4 is in security-fix-only mode so it doesn't get bugfix updates anymore. -- nosy: +berker.peksag resolution: -> out of date status: open -> closed versions: +Python 3.5 ___ Python tracker

  1   2   >