[issue16039] imaplib: unlimited readline() from connection

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +10351

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11617] Sporadic failure in test_httpservers

[STINNER Victor]

Change by STINNER Victor :


--
keywords: +patch
pull_requests: +10352
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Is this issue completely fixed?

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35394] Add __slots__ = () to asyncio protocols

[Andrew Svetlov]

Andrew Svetlov  added the comment:


New changeset 5344501ad166c1380be452644a863a4679c4291b by Andrew Svetlov in 
branch 'master':
bpo-35394: Add empty slots to abstract asyncio protocols (#10889)
https://github.com/python/cpython/commit/5344501ad166c1380be452644a863a4679c4291b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35455] Solaris thread_time doesn't work with current implementation

[Jakub Kulik]

Change by Jakub Kulik :


--
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35456] asyncio.Task.set_result() and set_exception() missing docstrings (and Liskov sub. principle)

[Yury Selivanov]

Yury Selivanov  added the comment:

-1 on this; there is no clear win in doing this refactoring, only a hard to 
estimate chance of making a regression.

Yahya, feel free to tackle other asyncio bugs or improvements, this one is just 
something that we aren't comfortable doing right now.

--
resolution:  -> postponed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35463] mock uses incorrect signature for partial and partialmethod with autospec

[Karthikeyan Singaravelan]

New submission from Karthikeyan Singaravelan :

This is a bug report for https://bugs.python.org/issue17185#msg331149 that I 
was asked to raise as a separate issue.

1. When we call create_autospec it calls _get_signature_object that gets the 
signature for the given parameter. With functools.partial it returns a partial 
object and hence while getting the signature it returns the signature for the 
constructor of partial instead of the underlying function passed to 
functools.partial. I think a check needs to be added to make sure not to use 
func.__init__ when it's a partial object.

2. When we call create_autospect on a class that has a partialmethod the self 
parameter is not skipped in the signature and thus it creates a signature with 
self causing error. The fix would be to handle partialmethod also in _must_skip 
that determines whether to skip self or not.


Sample reproducer : 

from functools import partial, partialmethod
from unittest.mock import create_autospec
import inspect

def foo(a, b):
pass

p = partial(foo, 1)
m = create_autospec(p)
m(1, 2, 3) # passes since signature is set as (*args, **kwargs) the signature 
of functools.partial constructor. This should throw TypeError under autospec


class A:

def f(self, a, b):
print(a, b)

g = partialmethod(f, 1)

m = create_autospec(A)
m().g(1, 2) # passes since signature is set as (self, b) and self is not 
skipped in _must_skip thus self=1, b=2. This should throw TypeError under 
autospec since the valid call is m().g(2)

--
components: Library (Lib)
messages: 331631
nosy: cjw296, mariocj89, michael.foord, pablogsal, xtreak
priority: normal
severity: normal
status: open
title: mock uses incorrect signature for partial and partialmethod with autospec
type: behavior
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30230] Move quick test in PyObject_IsSubClass outside of PyType_CheckExact guard

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Any progress?

--
versions: +Python 3.8 -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22293] unittest.mock: use slots in MagicMock to reduce memory footprint

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

James, please confirm that this issue still exists in 3.6 and 3.7.

--
nosy: +serhiy.storchaka
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35433] Correctly detect installed SDK versions

[Jeremy Kloth]

Jeremy Kloth  added the comment:

All the Windows 3.6 windows buildbots are happy! Thanks to all!

--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35464] json.dumps very unclear exception

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

This was changed in 3.6 (issue26623). Upgrade to 3.6+ for better error messages.

--
nosy: +serhiy.storchaka
resolution:  -> out of date
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11617] Sporadic failure in test_httpservers

[STINNER Victor]

STINNER Victor  added the comment:

Hum, it seems like this bug still exists in Python 2.7. Error from Fedora CI:

test_head_via_send_error (test.test_httpservers.BaseHTTPServerTestCase) ... 
ERROR
(...)
ERROR: test_head_via_send_error (test.test_httpservers.BaseHTTPServerTestCase)
--
Traceback (most recent call last):
  File "/builddir/build/BUILD/Python-2.7.15/Lib/test/test_httpservers.py", line 
303, in test_head_via_send_error
res = self.con.getresponse()
  File "/builddir/build/BUILD/Python-2.7.15/Lib/httplib.py", line 1121, in 
getresponse
response.begin()
  File "/builddir/build/BUILD/Python-2.7.15/Lib/httplib.py", line 438, in begin
version, status, reason = self._read_status()
  File "/builddir/build/BUILD/Python-2.7.15/Lib/httplib.py", line 402, in 
_read_status
raise BadStatusLine(line)
BadStatusLine: ''

--
resolution: fixed -> 
status: closed -> open
versions: +Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11617] Sporadic failure in test_httpservers

[STINNER Victor]

Change by STINNER Victor :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35464] json.dumps very unclear exception

[Or]

New submission from Or :

when dumping a value coming from numpy.random.choice([True,False]) the 
exception raised is very unclear.

json.dumps(result)

  File 
"/usr/local/Cellar/python@2/2.7.15/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/encoder.py",
 line 184, in default
raise TypeError(repr(o) + " is not JSON serializable")

which prints "True is not JSON serializable" - but it should actually print 
" is not JSON serializable".

--
components: Library (Lib)
messages: 331632
nosy: orshemy
priority: normal
severity: normal
status: open
title: json.dumps very unclear exception
type: behavior
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11617] Sporadic failure in test_httpservers

[STINNER Victor]

STINNER Victor  added the comment:


New changeset d336b1c8a40d14054145393fafb54b782cc1a549 by Victor Stinner in 
branch '2.7':
bpo-11617: Try to strengthen test_httpservers (GH-11121)
https://github.com/python/cpython/commit/d336b1c8a40d14054145393fafb54b782cc1a549


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35446] incorrect example

[Eric Snow]

Change by Eric Snow :


--
pull_requests: +10353

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35097] IDLE add doc subsection for editor windows

[Terry J. Reedy]

Change by Terry J. Reedy :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12920] inspect.getsource only works for objects loaded from files, not interactive session

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Do we really need to say that getsource(object) can only get the object's 
source if it is accessible from the object?  Getsource also fails if a module 
is loaded from a .pyc with not corresponding .py available.

The problem is not the call being in __main__.  When I put the three lines 
(with the 3rd wrapped with print()) in an IDLE editor and run, and re-inspect, 
I get

 RESTART: F:\Python\a\tem3.py 
class A:
pass

>>> inspect.getsource(A)
'class A:\npass\n'

Ditto if I run > py -i -m a.tem3

If I continue in IDLE's Shell

>>> class B: pass

>>> inspect.getsource(B)
Traceback (most recent call last):
  File "", line 1, in 
inspect.getsource(B)
  File "F:\dev\37\lib\inspect.py", line 973, in getsource
lines, lnum = getsourcelines(object)
  File "F:\dev\37\lib\inspect.py", line 955, in getsourcelines
lines, lnum = findsource(object)
  File "F:\dev\37\lib\inspect.py", line 812, in findsource
raise OSError('could not find class definition')
OSError: could not find class definition

If I enter the three lines above in a fress python or IDLEs shell, I get the 
TypeError above.

IDLE does store interactive inputs into linecache, so that tracebacks contain 
the offending line (unlike interactive python). But it does so on a statement 
by statement basis, so that each entry is treated as a separate file.  In a 
traceback for an exception in a multiline statement, the line number is 
relative to the statement.

>>> def f():
# line2 of f
1/0


>>> f()
Traceback (most recent call last):
  File "", line 1, in 
f()
  File "", line 3, in f
1/0
ZeroDivisionError: division by zero

Interactive python displays '' as the file for all entries.  IDLE 
numbers them, so previous statements remained cached.  I consider enhanced 
interactive tracebacks to be an important feature.

But I don't see how to attach individual pseudofile names to classes and 
functions so that getsource could find their source lines.

--
nosy: +terry.reedy
versions: +Python 3.7, Python 3.8 -Python 2.7, Python 3.4, Python 3.5, Python 
3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33962] IDLE: use ttk.spinbox with configdialog

[Terry J. Reedy]

Change by Terry J. Reedy :


--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34857] IDLE: SyntaxWarning not handled properly

[Terry J. Reedy]

Change by Terry J. Reedy :


--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35423] Signal handling machinery still relies on "pending calls".

[Eric Snow]

Change by Eric Snow :


--
nosy: +emilyemorehouse

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35402] Upgrade macOS and Windows installers to Tcl 8.6.9 and Tk 8.6.9.1

[Steve Dower]

Steve Dower  added the comment:

Probably. I'm 99% sure it's a problem with the latest build tools, and nothing 
to do with Python. Though I haven't checked out whether we're injecting any 
compile time flags that may be causing extra things to be included - I have no 
idea why X11 is necessary, for example.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35423] Signal handling machinery still relies on "pending calls".

[Eric Snow]

Eric Snow  added the comment:

Correct.  The remaining call to Py_AddPendingCall in the signal-handling code 
is fine.

This issue is only indirectly related.  I suppose you could consider it a 
follow-up to #30703.  The PR for that issue (GH-2415) switches from using 
pending calls for signal handlers to using the pending calls machinery without 
actual pending calls.

So here I want to address taking the next step: deal with pending signals 
separately from pending calls.  That separation helps simplify efforts to adapt 
the pending calls machinery for use in arbitrary threads (rather than the main 
thread).  See #33608.

--
components: +Interpreter Core
nosy: +pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35446] incorrect example

[Eric Snow]

Change by Eric Snow :


--
pull_requests:  -10353

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35402] Upgrade macOS and Windows installers to Tcl 8.6.9 and Tk 8.6.9.1

[Steve Dower]

Steve Dower  added the comment:

Looks like Tix needs similar updates, since it imports the Tk headers. Perhaps 
it'll be easier to undef immediately after the X11\X.h include? Assuming the 
values aren't actually being used anywhere.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16516] argparse types (and actions) must be hashable

[Guido van Rossum]

Guido van Rossum  added the comment:

Luna and I talked a bit about this offline and we decided not to merge the PR 
(nor the original patch, which is the same). Instead Luna will add a note to 
the docs explaining the caveat.

--
nosy: +gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19348] Building _testcapimodule as a builtin results in compile error

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35466] Use a linked list for the ceval pending calls.

[Eric Snow]

Eric Snow  added the comment:

I suppose performance could have been a motivator originally.  However, I don't 
see a benefit now that signals handlers are no longer pending calls.  If it's a 
real problem then we can leverage a free list.

As to complexity, the motivator for this change was difficulty I had (along 
with another core dev) in quickly understanding the logic for manipulating the 
circular buffer.  I find the linked list much easier to understand.

--
nosy: +emilyemorehouse

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33987] IDLE: add ttk.Frame inside searchbaseToplevel

[Terry J. Reedy]

Change by Terry J. Reedy :


--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27477] IDLE: Switch search dialogs to ttk widgets, and other refinement

[Terry J. Reedy]

Change by Terry J. Reedy :


--
versions: +Python 3.7, Python 3.8 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17534] unittest keeps references to test cases alive

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Does this issue still relevant?

--
nosy: +serhiy.storchaka
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35402] Upgrade macOS and Windows installers to Tcl 8.6.9 and Tk 8.6.9.1

[Ned Deily]

Ned Deily  added the comment:

Should the problems be reported upstream?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

[Terry J. Reedy]

Change by Terry J. Reedy :


--
versions: +Python 3.8 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34976] IDLE: Replace the search dialog with a search bar

[Terry J. Reedy]

Change by Terry J. Reedy :


--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21880] IDLE: Ability to run 3rd party code checkers

[Terry J. Reedy]

Change by Terry J. Reedy :


--
versions: +Python 3.8 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35466] Use a linked list for the ceval pending calls.

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Was not a circular array used intentionally because this allows to avoid 
calling malloc()?

And the proposed code looks more complicated to me than the current code.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

[Gregory P. Smith]

Gregory P. Smith  added the comment:

I believe there are still some issues to deal with.  I don't want to close the 
issue until I've got my buildbot running.

--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35450] venv module doesn't create a copy of python binary by default

[Brett Cannon]

Change by Brett Cannon :


--
stage:  -> needs patch
versions: +Python 3.5, Python 3.6, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35387] Dialogs on IDLE are accompanied by a small black window

[Vlad Tudorache]

Vlad Tudorache  added the comment:

At the line 102 in editor.py, I see:

self.top = top = window.ListedToplevel(root, menu=self.menubar)

Looking at window.py it seems that ListedToplevel builds a new Toplevel (the 
black one?) instead of adding an existing one (the editor) at the list, I'll 
check it again, maybe I didn't see right.

The second window does not appear for me when using pure Tcl and toplevel 
widget (from Wish, for exemple) on MacOS, I don't think it's a Tk problem.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35466] Use a linked list for the ceval pending calls.

[Eric Snow]

New submission from Eric Snow :

Currently the list of pending calls (see Include/internal/pycore_ceval.h) is 
implemented as a circular buffer.  A linked list would be easier to understand 
and modify.  It also allows for removing the restriction on the number of 
pending calls.

--
assignee: eric.snow
components: Interpreter Core
messages: 331655
nosy: eric.snow
priority: normal
severity: normal
stage: needs patch
status: open
title: Use a linked list for the ceval pending calls.
type: enhancement
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35466] Use a linked list for the ceval pending calls.

[Eric Snow]

Change by Eric Snow :


--
keywords: +patch
pull_requests: +10354
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25219] Update doc for Idle command line options.

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Rather that leave this open indefinitely, I decided to close until a report or 
research says that more is needed.

--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5438] test_bigmem.test_from_2G_generator uses more memory than expected

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

tuple(range(size)) should consume approximately 90 GiB of memory and run for 
hours. I think this happens because it creates enormous number of integer 
objects, and this can lead to requesting additional memory for memory pools.

If details of memory management for small objects is not the purpose of this 
test, I think we can replace it with tuple(iter([42]*size)). It executes the 
same code in tuple creation: allocates a tuple of known size (both range and 
list iterators have __length_hint__) and fills it with values produced by the 
iterator. This allows significantly reduce memory requirements (to 16 GiB) and 
execution time (to 20 seconds on my computer).

The proposed PR implements this rewriting. It also fixes memory requirements 
for other tests, optimizes repr tests for tuples and lists (repr(False) is 
faster and longer than repr(0)), and expresses memory requirements in terms of 
character and pointer sizes.

--
versions: +Python 3.7, Python 3.8 -Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34708] Odd crashes/freezes when sys.stdout.shell.console is typed

[Terry J. Reedy]

Change by Terry J. Reedy :


--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10336] test_xmlrpc fails if gzip is not supported by client

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

The server for this test is ran in the different thread of the same process. 
The test is skipped if gzip is not supported. I don't see a way how it can fail.

--
nosy: +serhiy.storchaka
resolution:  -> not a bug
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18799] Resurrect and fix test_404 in Lib/test/test_xmlrpc.py

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Vajrasky, do you mind to create a pull request on GitHub for your patch?

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35267] reproducible deadlock with multiprocessing.Pool

[STINNER Victor]

Change by STINNER Victor :


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34313] IDLE crashes with Tk-related error on macOS with ActiveTcl 8.6

[Terry J. Reedy]

Change by Terry J. Reedy :


--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5438] test_bigmem.test_from_2G_generator uses more memory than expected

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +10355
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33065] IDLE debugger: failure stepping through module loading

[Terry J. Reedy]

Change by Terry J. Reedy :


--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35402] Upgrade macOS and Windows installers to Tcl 8.6.9 and Tk 8.6.9.1

[Steve Dower]

Steve Dower  added the comment:

I pushed the raw Tcl and Tk sources for 8.6.9.0 to cpython-source-deps, but it 
looks like we need some patches to be able to build on Windows (the X11 headers 
#define some names that the Windows headers want to use as struct members).

So far I've needed to #undef and redefine None and ControlMask around #include 
 in winmain.c and tkWin.h, but I think that will be enough.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35403] support application/wasm in mimetypes and http.server

[pmpp]

pmpp  added the comment:

Sure, but i was considering the cpython in the browser/webview/electron case 
where python modules are served as .wasm files, i'm about to do it for my port 
and pyodide already does. 
It would make sense to provide the *simplest* environnement for cpython to 
serve its own components.

scientific cpython stack in the browser:
https://github.com/iodide-project/pyodide

python repl in the browser experiment:
http://pmpp.pagesperso-orange.fr/python_em.html

Also i think cpython in the browser could be be already beyond testing and so 
far provides the best sandboxing configuration available around :
"run python in a sandbox, not the opposite" ( quoting Victor Stinner )

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35213] IDLE: use 'macOS' where appropriate.

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Any more changes can be a future issue.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35387] Dialogs on IDLE are accompanied by a small black window

[Vlad Tudorache]

Vlad Tudorache  added the comment:

No, I'm wrong, the editor window seems created by the ListedToplevel.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35136] test_ssl fails in AMD64 FreeBSD CURRENT Shared 3.6 buildbot

[Ned Deily]

Ned Deily  added the comment:

On the other hand and also FWIW, test_ssl does pass on the AMD64 FreeBSD 
CURRENT Shared 3.7 buildbot (the same system?) which also has 1.1.1a:
ssl.OPENSSL_VERSION: OpenSSL 1.1.1a  20 Nov 2018

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34162] idlelib/NEWS.txt for 3.8.0 (and backports)

[Terry J. Reedy]

Change by Terry J. Reedy :


--
stage: patch review -> needs patch
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22121] IDLE should start with HOME as the initial working directory

[Terry J. Reedy]

Change by Terry J. Reedy :


--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35379] IDLE's close fails when io.filename set to None

[Terry J. Reedy]

Change by Terry J. Reedy :


--
components: +macOS
nosy: +ned.deily, ronaldoussoren
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35465] Document add_signal_handler

[Hrvoje Nikšić]

New submission from Hrvoje Nikšić :

In https://stackoverflow.com/q/53704709/1600898 a StackOverflow user asked how 
the add_signal_handler event loop method differs from the signal.signal 
normally used by Python code.

The add_signal_handler documentation is quite brief - if we exclude the parts 
that explain the exceptions raised and how to pass keyword arguments to the 
callback, the meat is this sentence:

Set callback as the handler for the signum signal.

It is only after looking at the source, and understanding asyncio, that one 
comes to the conclusion that the idea is to run the handler along with other 
event loop callbacks and coroutines, at the time when it is actually safe to 
invoke asyncio code.

I think this deserves to be mentioned explicitly, for example:

Set callback as the handler for the signum signal.

The callback will be invoked in the thread that runs the event
loop, along with other queued callbacks and runnable coroutines.
Unlike signal handlers registered using signal.signal(), a 
callback registered with this function is allowed to interact
with the event loop.

--
assignee: docs@python
components: Documentation
messages: 331645
nosy: docs@python, hniksic
priority: normal
severity: normal
status: open
title: Document add_signal_handler
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35136] test_ssl fails in AMD64 FreeBSD CURRENT Shared 3.6 buildbot

[Ned Deily]

Ned Deily  added the comment:

FWIW, test_ssl currently passes on the other FreeBSD 3.6 buildbot: FreeBSD 
10-STABLE Non-Debug 3.6 buildbot.  Among any other differences, the SSL version 
there is older:
ssl.OPENSSL_VERSION: OpenSSL 1.0.1u-freebsd  22 Sep 2016

--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35450] venv module doesn't create a copy of python binary by default

[Brett Cannon]

Brett Cannon  added the comment:

Obviously if you're willing to create a PR, Marcin, that would be great!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35208] IDLE: Squeezed lines count ignores window width

[Terry J. Reedy]

Change by Terry J. Reedy :


--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35450] venv module doesn't create a copy of python binary by default

[Brett Cannon]

Brett Cannon  added the comment:

Correct, that should say something like "copy/symlink of the Python 
binary/binaries (as appropriate by the platform or arguments used at 
environment creation time)."

--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35468] [3.6/3.7] idlelib/help.html mentions 3.8alpha0 docs

[Matthias Klose]

New submission from Matthias Klose :

[3.6/3.7] idlelib/help.html mentions 3.8alpha0 docs:



Seen in the 3.6.8 and 3.7.2 release candidates

--
assignee: terry.reedy
components: IDLE
keywords: 3.6regression, 3.7regression
messages: 331671
nosy: doko, ned.deily, terry.reedy
priority: normal
severity: normal
status: open
title: [3.6/3.7] idlelib/help.html mentions 3.8alpha0 docs
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35387] Dialogs on IDLE are accompanied by a small black window

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Vlad, thank you.  The release candidates for 3.7.2 and 3.6.8 are due as soon as 
Ned can manage.  The Mac installers will come with the very recent tcl/tk 
8.6.9(.1) releases.  Existing tkinter-related issues for Mac should be 
re-tested when available and installed.

--
type: behavior -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34055] IDLE Shell: check syntax before smart indent

[Terry J. Reedy]

Terry J. Reedy  added the comment:

#35467 is about unwanted auto-pasting.

--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33963] IDLE macosx: add tests.

[Terry J. Reedy]

Change by Terry J. Reedy :


--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Change by Terry J. Reedy :


--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6835] doctest problem with decorated function when decorator is defined in separate file

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> duplicate
stage: needs patch -> resolved
status: open -> closed
superseder:  -> Problem with doctest and decorated functions

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33960] IDLE REPL: Strange indentation

[Terry J. Reedy]

Change by Terry J. Reedy :


--
versions: +Python 3.7, Python 3.8 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20800] Cannot run gui tests twice.

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

I have just tested on Windows and all works to me. Terry, can you confirm that 
this issue is gone?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35467] IDLE: unrequested pasting into Shell after restart

[Terry J. Reedy]

New submission from Terry J. Reedy :

IDLE very occasionally (frequency much less than .01), and AFAIK hapzardly, 
pastes previous shell output after I enter something at the prompt after a 
restart.  Not fatal but definitly annoying.  When it happened today, I decided 
to open this issue to start accumulating information that might point at where 
to start.

tem3.py:  (content likely not relevant)

import inspect
class A:
pass
print(inspect.getsource(A))
print(__name__)

Shell copy:
"""
...
OSError: could not find class definition
>>> 
 RESTART: F:\Python\a\tem3.py 
class A:
pass

__main__
>>> 1/0 RESTART: F:\Python\a\tem3.py 
>>> 
class A:
pass
SyntaxError: invalid syntax
>>> 1/0
Traceback (most recent call last):
...
"""

The paste, after '1/0', is the restart line and the first two lines of output 
(but not the last two).  It mixes text from IDLE and from the program, so it is 
not an echo from the run process).  It is colored as if typed in: 'class' and 
'pass' are keyword colored, the  I believe I hit ENTER  and got the paste 
instead of the exception.  I hit Entere after the paste to get the SyntaxError 
and a clean prompt.  Then I reentered 1/0.

I did more or less the same thing about 5 times without a repeat of the problem.

Possible factors:
exception before restart (probably not relevant).
restart, prompt, and entry (I believe these are essential elements).
running a file (I seldom restart other wise).
hitting return

Included Content:
restart line (I am pretty sure pasted text does not always include this).
output from before the restart (ever?).
output from after the restart (if always, must have run a file).
---

Raymond, I believe you have seen this on Mac.  Tal or Sheryl, how about linux?  
Anyone, more details on other examples are needed to know what is constant and 
what is incidental.

--
messages: 331668
nosy: cheryl.sabella, rhettinger, taleinat, terry.reedy
priority: normal
severity: normal
stage: needs patch
status: open
title: IDLE: unrequested pasting into Shell after restart
type: behavior
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34313] Tkinter crashes with Tk-related error on macOS with ActiveTcl 8.6

[Terry J. Reedy]

Change by Terry J. Reedy :


--
components:  -IDLE
title: IDLE crashes with Tk-related error on macOS with ActiveTcl 8.6 -> 
Tkinter crashes with Tk-related error on macOS with ActiveTcl 8.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35457] robotparser reads empty robots.txt file as "all denied"

[larsfuse]

New submission from larsfuse :

The standard (http://www.robotstxt.org/robotstxt.html) says:

> To allow all robots complete access:
> User-agent: *
> Disallow:
> (or just create an empty "/robots.txt" file, or don't use one at all)

Here I give python an empty file:
$ curl http://10.223.68.186/robots.txt
$

Code:

rp = robotparser.RobotFileParser()
print (robotsurl)
rp.set_url(robotsurl)
rp.read()
print( "fetch /", rp.can_fetch(useragent = "*", url = "/"))
print( "fetch /admin", rp.can_fetch(useragent = "*", url = "/admin"))

Result:

$ ./test.py
http://10.223.68.186/robots.txt
('fetch /', False)
('fetch /admin', False)

And the result is, robotparser thinks the site is blocked.

--
components: Library (Lib)
messages: 331595
nosy: larsfuse
priority: normal
severity: normal
status: open
title: robotparser reads empty robots.txt file as "all denied"
type: behavior
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33747] Failed separate test_patch_propogrates_exc_on_exit in test_unittest

[miss-islington]

miss-islington  added the comment:


New changeset 45a31a1ec11e75cd0ef487dd4cea7f9fc4f885c8 by Miss Islington (bot) 
in branch '3.7':
[3.7] bpo-33747: Avoid mutating the global sys.modules dict in unittest.mock 
tests (GH-8520) (GH-11031)
https://github.com/python/cpython/commit/45a31a1ec11e75cd0ef487dd4cea7f9fc4f885c8


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35455] Solaris thread_time doesn't work with current implementation

[Jakub Kulik]

Change by Jakub Kulik :


--
type:  -> crash

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35458] test_shutil.test_disk_usage() randomly fails when tests are run in parallel

[STINNER Victor]

New submission from STINNER Victor :

Extract of the test:

usage = shutil.disk_usage(os.path.dirname(__file__))
self.assertEqual(usage, shutil.disk_usage(__file__))

The test fails if another process creates or removes data on the disk 
partition. IMHO "self.assertEqual(usage, shutil.disk_usage(__file__))" must be 
removed, it cannot be reliable without mocking os.statvfs() / 
nt._getdiskusage().

Even if tests are run sequentially, the test can fail if a program creates a 
file between the two lines of code, the test cannot be reliable.

https://buildbot.python.org/all/#/builders/85/builds/1882

FAIL: test_disk_usage (test.test_shutil.TestShutil)
--
Traceback (most recent call last):
  File 
"/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/test/test_shutil.py",
 line 1366, in test_disk_usage
self.assertEqual(usage, shutil.disk_usage(__file__))
AssertionError: usage(total=1925696024576, used=1793793806336, 
free=131902218240) != usage(total=1925696024576, used=1793793818624, 
free=131902205952)

--
components: Tests
messages: 331601
nosy: pablogsal, vstinner
priority: normal
severity: normal
status: open
title: test_shutil.test_disk_usage() randomly fails when tests are run in 
parallel
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35459] Use PyDict_GetItemWithError() instead of PyDict_GetItem()

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
title: Use PyDict_GetItemWithError() with PyDict_GetItem() -> Use 
PyDict_GetItemWithError() instead of PyDict_GetItem()

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35460] Add PyDict_GetItemStringWithError

[Ronald Oussoren]

New submission from Ronald Oussoren :

PyDict_GetItemWithError is a variant of PyDict_GetItem that doesn't swallow 
unrelated exceptions.  While converting a project to use this API I noticed 
that there is similar variant of PyDict_GetItemString.

It would be nice to have PyDict_GetItemStringWithError as a public API to make 
it easier to convert existing code to the better API.

--
components: Interpreter Core
messages: 331607
nosy: ronaldoussoren
priority: normal
severity: normal
status: open
title: Add PyDict_GetItemStringWithError
type: enhancement
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35444] Unify and optimize the helper for getting a builtin object

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35454] Fix miscellaneous issues in error handling

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32557] allow shutil.disk_usage to take a file path on Windows also

[STINNER Victor]

STINNER Victor  added the comment:

The new test is unstable: see bpo-35458.

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35459] Use PyDict_GetItemWithError() with PyDict_GetItem()

[Serhiy Storchaka]

New submission from Serhiy Storchaka :

There is an issue with using PyDict_GetItem(). Since it silences all 
exceptions, it can return incorrect result when an exception like MemoryError 
or KeyboardInterrupt was raised in the user __hash__() and __eq__(). In 
addition PyDict_GetItemString() and _PyDict_GetItemId() swallow a MemoryError 
raised when fail to allocate a temporary string object.

In addition, PyDict_GetItemWithError() is a tiny bit faster than 
PyDict_GetItem(), because it avoids checking the exception state in successful 
case.

The proposed PR replaces most calls of PyDict_GetItem(), PyDict_GetItemString() 
and _PyDict_GetItemId() with calls of PyDict_GetItemWithError(), 
_PyDict_GetItemStringWithError() and _PyDict_GetItemIdWithError().

--
components: Extension Modules, Interpreter Core
messages: 331604
nosy: serhiy.storchaka, vstinner
priority: normal
severity: normal
status: open
title: Use PyDict_GetItemWithError() with PyDict_GetItem()
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35458] test_shutil.test_disk_usage() randomly fails when tests are run in parallel

[STINNER Victor]

STINNER Victor  added the comment:

Only the master branch is impacted (see bpo-32557).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15663] Investigate providing Tcl/Tk 8.6 with OS X installers

[Ned Deily]

Ned Deily  added the comment:


New changeset d0d09b511d7a438fb18a9a4703480763119b4eac by Ned Deily in branch 
'2.7':
[2.7] bpo-15663: the 10.6+ macOS installers for 3.6/2.7 now provide a private 
Tcl/Tk 8.6 (GH-0)
https://github.com/python/cpython/commit/d0d09b511d7a438fb18a9a4703480763119b4eac


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15663] Investigate providing Tcl/Tk 8.6 with OS X installers

[Ned Deily]

Ned Deily  added the comment:

Update: as of 3.6.8rc1 and the eventual 2.7.16rc1, both installer variants 
(10.9+ and 10.6+) provide a built-in Tcl/Tk 8.6.8. For python.org installers, 
Tcl/Tk 8.5.x is finally dead!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35444] Unify and optimize the helper for getting a builtin object

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset be6ec444729f727f304ae10f3a7e2feda3cc3aaa by Serhiy Storchaka 
(Miss Islington (bot)) in branch '3.6':
bpo-35444: Fix error handling when fail to look up builtin "getattr". 
(GH-11047) (GH-11107) (GH-11108)
https://github.com/python/cpython/commit/be6ec444729f727f304ae10f3a7e2feda3cc3aaa


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33747] Failed separate test_patch_propogrates_exc_on_exit in test_unittest

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33747] Failed separate test_patch_propogrates_exc_on_exit in test_unittest

[miss-islington]

miss-islington  added the comment:


New changeset 7d9f21950927e7c7fe69e5edeb06023a963c6f68 by Miss Islington (bot) 
in branch '3.6':
[3.6] bpo-33747: Avoid mutating the global sys.modules dict in unittest.mock 
tests (GH-8520) (GH-11032)
https://github.com/python/cpython/commit/7d9f21950927e7c7fe69e5edeb06023a963c6f68


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35458] test_shutil.test_disk_usage() randomly fails when tests are run in parallel

[STINNER Victor]

Change by STINNER Victor :


--
keywords: +patch
pull_requests: +10340
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35458] test_shutil.test_disk_usage() randomly fails when tests are run in parallel

[STINNER Victor]

STINNER Victor  added the comment:

The new test has been added by PR 9372:

commit c8c0249c9e8f61ab7670119a5a5278354df27bbb
Author: Joe Pamer 
Date:   Tue Sep 25 10:57:36 2018 -0400

bpo-32557: allow shutil.disk_usage to take a file path on Windows also 
(GH-9372)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35459] Use PyDict_GetItemWithError() instead of PyDict_GetItem()

[STINNER Victor]

STINNER Victor  added the comment:

My previous attempt: bpo-20615.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35459] Use PyDict_GetItemWithError() instead of PyDict_GetItem()

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +10341
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

[Chris Withers]

Chris Withers  added the comment:


New changeset f7fa62ef4422c9deee050a794fd8504640d9f8f4 by Chris Withers 
(Xtreak) in branch 'master':
bpo-17185: Add __signature__ to mock that can be used by inspect for signature 
(GH11048)
https://github.com/python/cpython/commit/f7fa62ef4422c9deee050a794fd8504640d9f8f4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

[miss-islington]

Change by miss-islington :


--
pull_requests: +10356

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

[Chris Withers]

Change by Chris Withers :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15663] Investigate providing Tcl/Tk 8.6 with OS X installers

[Ned Deily]

Ned Deily  added the comment:


New changeset f74cabd9203cf3be97fdb3821a7fa0b74d7b2263 by Ned Deily in branch 
'3.6':
[3.6] bpo-15663: the 10.6+ macOS installers for 3.6/2.7 now provide a private 
Tcl/Tk 8.6 (GH-11109)
https://github.com/python/cpython/commit/f74cabd9203cf3be97fdb3821a7fa0b74d7b2263


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35444] Unify and optimize the helper for getting a builtin object

[miss-islington]

Change by miss-islington :


--
pull_requests: +10337

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15663] Investigate providing Tcl/Tk 8.6 with OS X installers

[Ned Deily]

Change by Ned Deily :


--
pull_requests: +10339

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35456] asyncio.Task.set_result() and set_exception() missing docstrings (and Liskov sub. principle)

[INADA Naoki]

INADA Naoki  added the comment:

> One way to deal with that would be to let a Task have a Future.
> "Prefer composition over inheritance" as they say.
> 
> I want to work on PR for this if nobody goes against it...

I'm not against it, unless it doesn't have backward incompatibility
or performance regression.

But I'm not sure you estimate the difficulty correctly: there are C 
implementation of Future and Task.  You need to have deep knowledge of Python/C 
APIs.


> PS: I really don't like when some people says that Python core developers are 
> known to have poor knowledge in regard to OOP principles. So I really don't 
> like letting something like this in the standard library...

Personally speaking, I dislike treating OOP principles like Ten Commandments.  
Principles have some reasons.  And these reasons are reasonable not for all 
cases.  When people say "it's bad because it violates principle!", they may 
have poor knowledge about the prinicple.
If they really know the principle, they must describe real-world problem caused 
by the violation.

In this case, I agree that misleading docstring is a small real-world problem 
caused by the violation.  While it can be fixable without fixing the violation.

Generally, `set_result` or `set_exception` is called by the creator of the 
Future.  So requiring knowledge of concrete class is not a big problem.
On the other hand, awaiting future object without knowing concrete class is 
common.  But Task is awaitable.  So there are no problem here.

--
nosy: +inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com