Ned Deily added the comment:
The proposed patch with minor changes is now pushed. I believe all of the
review points have either been resolved or are covered by separate pip issues
with the exception of item 8. For item 6 (permissions not being forced), I
decided that there are so many
Nick Coghlan added the comment:
Victor, you can propose whatever you like for 3.5, but I'm not adding new
interpreter state two days before feature freeze when we don't have to.
Looking up the private CodecInfo attribute is still O(1) anyway.
--
___
Changes by Claudiu.Popa pcmantic...@gmail.com:
--
nosy: +Claudiu.Popa
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18864
___
___
Python-bugs-list
Claudiu.Popa added the comment:
Hello! Attached patch which uses ModuleSpec, tested with
http://hg.python.org/features/pep-451/ repo.
--
Added file: http://bugs.python.org/file32771/unittest_discovery_spec2.patch
___
Python tracker
Ned Deily added the comment:
If it is acceptable for the Remove option to be somewhat unpredictable in the
case where pip or setuptools was already installed and not by the installer,
would python -m pip uninstall --yes pip setuptools work? If not, should a
new issue be opened to find a
Changes by Richard Oudkerk shibt...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19599
___
Nick Coghlan added the comment:
I think Off by default is a reasonable solution for the beta (and
even 3.4 final), but a separate issue explaining *why* it's off by
default would be good. I can then ping the pip folks to ask for
suggestions - if they come up with something workable, we may be
anatoly techtonik added the comment:
Neither you nor docs answer the question when Assign node gets Tuple as
argument, when List and when Subscript.
While it is obvious to you, I personally don't know what a Subscript is. This
is the kind of stuff that I'd like to see documented.
--
STINNER Victor added the comment:
Test is failing on Windows:
http://buildbot.python.org/all/builders/x86%20Windows%20Server%202003%20%5BSB%5D%203.x/builds/1758/steps/test/logs/stdio
==
ERROR: test_SO_in_vars
STINNER Victor added the comment:
The test is failing:
http://buildbot.python.org/all/builders/x86%20Windows%20Server%202003%20%5BSB%5D%203.x/builds/1758/steps/test/logs/stdio
==
FAIL: test_enum_certificates
Nick Coghlan added the comment:
- switched to LookupError for the dedicated exception
- default value moved to a CodecInfo class attribute
- new private APIs guarded by PY_LIMITED_API
- used repr formatting where appropriate in the tests
- cleaned up the tests a bit by using
Marc-Andre Lemburg added the comment:
Nick: I've had a look at your second patch. A couple of notes:
* I think you should add the flag to the constructor of the CodecInfo
tuple subclass and then set this in the resp. codecs. The extra
constructor class method looks too much like a hack
New submission from Curtis Doty:
I first stumbled across this bug attempting to install use pip's cool editable
mode:
$ pip install -e git+git://github.com/appliedsec/pygeoip.git#egg=pygeoip
Obtaining pygeoip from git+git://github.com/appliedsec/pygeoip.git#egg=pygeoip
Cloning
Marc-Andre Lemburg added the comment:
On 22.11.2013 12:24, Marc-Andre Lemburg wrote:
Nick: I've had a look at your second patch. A couple of notes:
* I think you should add the flag to the constructor of the CodecInfo
tuple subclass and then set this in the resp. codecs. The extra
Nick Coghlan added the comment:
- switched the private flag from being set in a class method to using a keyword
only parameter to __init__
- updated the codecs.h comment as MAL suggested
--
Added file:
STINNER Victor added the comment:
If _is_text_encoding may change in Python 3.5, you should add a comment to warn
users to not use it and explain its purpose, maybe with a reference to this
issue.
--
We have talking about a very few codecs:
* base64: bytes = bytes
* bz2: bytes = bytes
*
Marc-Andre Lemburg added the comment:
On 22.11.2013 12:43, STINNER Victor wrote:
STINNER Victor added the comment:
If _is_text_encoding may change in Python 3.5, you should add a comment to
warn users to not use it and explain its purpose, maybe with a reference to
this issue.
+1
--
Eric V. Smith added the comment:
While I think that the dotted_name restriction should be relaxed and it should
instead be a style guide issue, I have to agree with Benjamin here: the
difference in grammar complexity is zero and shouldn't drive the decision.
--
STINNER Victor added the comment:
2013/11/22 Marc-Andre Lemburg rep...@bugs.python.org:
Anyway: Thanks to Nick for implementing this, to Serhiy for the black
list idea and Victor for the attribute idea :-)
In fact, the attribute idea comes from you :-)
Stefan Krah added the comment:
David is correct: No data is copied, but new memoryview objects with different
shape and strides are created. That is relatively cheap.
--
nosy: +skrah
resolution: - invalid
stage: - committed/rejected
status: open - closed
type: enhancement - behavior
Donald Stufft added the comment:
I'm honestly not sure what to do about #8 on your list. It's sort of a really
wierd edge case as far as pip is concerned right now because the support for
the versioned commands and differing them is sort of a hack job while we wait
for proper support from a
Nick Coghlan added the comment:
It turns out the codec cache and the refleak hunting mechanism in regrtest
*really* don't like each other if you use closures to implement your test
codecs :)
Anyway, the attached patch tweaks the tests to handle refleak hunting (and
running the refleak hunter
Nick Coghlan added the comment:
Well, that patch minus the debugging print that was still in there :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19619
___
Roundup Robot added the comment:
New changeset d68df99d7a57 by Nick Coghlan in branch 'default':
Issue #19619: Blacklist non-text codecs in method API
http://hg.python.org/cpython/rev/d68df99d7a57
--
nosy: +python-dev
___
Python tracker
Nick Coghlan added the comment:
3.4 has been dealt with. A similar functional patch should work in 3.3, but the
test changes will be different (since those test cases don't exist yet in 3.3,
and the wrapping ones aren't relevant at all).
--
versions: -Python 3.4
Nick Coghlan added the comment:
The 3.4 portion of issue 19619 has been addressed, so removing it as a
dependency again.
--
dependencies: -Blacklist base64, hex, ... codecs from bytes.decode() and
str.encode()
___
Python tracker
Roundup Robot added the comment:
New changeset 1e3b8601b098 by Nick Coghlan in branch 'default':
Issue #19619: Update What's New for codec blacklist
http://hg.python.org/cpython/rev/1e3b8601b098
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
Upstream: https://github.com/pypa/pip/pull/816
--
resolution: - invalid
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19685
Christian Heimes added the comment:
That's strange. It looks like the Win2k box has no root CA certs for serverAuth
installed whatsoever. I'm adding Matthias to this ticket.
--
nosy: +doko
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
The initial concern was a denial of service. Nick, can you backport your
changeset to Python 3.3?
This issue should avoid the denial of service attack when a compression codec
is used, see:
STINNER Victor added the comment:
Can we now remove wrap_codec_error()? And maybe more changes which were done to
workaround issues with non-Unicode codecs. bytes.decode/str.encode should no
more raise a TypeError with codecs of the Python standard library.
Related changesets:
changeset:
Antoine Pitrou added the comment:
A few weeks ago I suggested the addition of
ssl.create_default_context() to the stdlib. The patch implements my
proposal. It replaces code in several of modules with one central
function. The patch also removes ssl.wrap_socket() in favor for a
SSLContext
Christian Heimes added the comment:
Good point!
We need a purpose flag anyway in order to load the appropriate root CA certs.
The purpose flag can be used for purpose-specific verify mode:
SERVER_AUTH = _ASN1Object('1.3.6.1.5.5.7.3.1')
CLIENT_AUTH = _ASN1Object('1.3.6.1.5.5.7.3.2')
if
Nick Coghlan added the comment:
Since ensurepip needs to manipulate sys.path, I ended up running the -m
ensurepip using the venv Python in a subprocess. This both avoids side effects
on the current process and gets ensurepip the right target directory settings
automatically.
--
Donald Stufft added the comment:
That's similar to how virtualenv does it, so it's probably pretty reasonable.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19552
___
dellair jie added the comment:
Folks,
Is there a patch to apply on this, I tried to search online, found one similar
post but was solved until the poster switched to another version of xlc. Do we
need to use another compiler(I will have to build though)?
Please don't hesitate to contact me
New submission from Antoine Pitrou:
The RuntimeError documentation has a strange sentence embedded in it:
This exception is mostly a relic from a previous version of the interpreter;
it is not used very much any more
http://docs.python.org/dev/library/exceptions.html#RuntimeError
That's
Antoine Pitrou added the comment:
SERVER_AUTH = _ASN1Object('1.3.6.1.5.5.7.3.1')
CLIENT_AUTH = _ASN1Object('1.3.6.1.5.5.7.3.2')
That's a bit ugly. How about an enum?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19689
New submission from Antoine Pitrou:
Py_SAFE_DOWNCAST's name is a bit misleading: it isn't safe except in debug
mode. I propose to rename it to Py_DOWNCAST, so that developers are reminded
that the burden of the sanity checks is on them.
--
components: Interpreter Core
messages: 203764
Christian Heimes added the comment:
+1
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19692
___
___
Python-bugs-list mailing list
Unsubscribe:
Christian Heimes added the comment:
In my opinion enums are for a closed batch of known entities. There are at
least 20-30 purpose flags, maybe more. Everybody is allowed to define their own
OIDs, too.
--
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
I like Py_DOWNCAST name.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19692
___
___
Python-bugs-list mailing
Antoine Pitrou added the comment:
In my opinion enums are for a closed batch of known entities. There
are at least 20-30 purpose flags, maybe more. Everybody is allowed to
define their own OIDs, too.
Well, how many purposes are we going to expose? I don't think users
should know what ASN1
Roundup Robot added the comment:
New changeset 57fbab22ab4e by Nick Coghlan in branch 'default':
Close #19552: venv and pyvenv ensurepip integration
http://hg.python.org/cpython/rev/57fbab22ab4e
--
nosy: +python-dev
resolution: - fixed
stage: needs patch - committed/rejected
status:
Christian Heimes added the comment:
The objects already have a (more or less) nice representation:
ssl._ASN1Object.fromname(1.3.6.1.5.5.7.3.1)
_ASN1Object(nid=129, shortname='serverAuth', longname='TLS Web Server
Authentication', oid='1.3.6.1.5.5.7.3.1')
New submission from Nick Coghlan:
From issue #19553:
8. make install is a superset of make altinstall and one would expect the
results of (a) make install to be the same as (b) make altinstall make
install. However (b) results in python -m ensurepip --altinstall --upgrade
python -m
Nick Coghlan added the comment:
Issue 19693 covers an anomaly where make altinstall make install doesn't
quite do the same thing as make install (the pip3 script will be missing in
the former case)
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
I moved the make altinstall make install problem out to its own issue
(issue 19693)
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19553
Changes by Nick Coghlan ncogh...@gmail.com:
--
priority: release blocker - deferred blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19407
___
Changes by Nick Coghlan ncogh...@gmail.com:
--
assignee: - ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17916
___
___
Python-bugs-list
Antoine Pitrou added the comment:
Ok. Note that as long as they aren't actually passed to OpenSSL, they don't
need to be ASN1 objects at all, i.e. if it's only a parameter to
create_default_context(), it can perfectly well be a str or enum.
--
___
Roundup Robot added the comment:
New changeset d71251d9fbbe by Nick Coghlan in branch 'default':
Close #17916: dis.Bytecode based replacement for distb
http://hg.python.org/cpython/rev/d71251d9fbbe
--
nosy: +python-dev
resolution: - fixed
stage: needs patch - committed/rejected
status:
Nick Coghlan added the comment:
Thank you for the patch! It's nice to have this included for the initial
general availability of the new disassembly API :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17916
Changes by Barry A. Warsaw ba...@python.org:
--
assignee: - barry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19555
___
___
Python-bugs-list
Antoine Pitrou added the comment:
Done in 33f58b469a4d (forgot to mention the issue id there).
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
Issue 19694 is a new issue for one of the buildbots objecting to the new venv
tests.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19347
___
New submission from Nick Coghlan:
pip still relies on imp (due to cross-version compatibility requirements), so
it may trigger a pending deprecation warning, and potentially return a non-zero
return code:
Nick Coghlan added the comment:
Rather than reopening this (which is part of tracking the feature integration
for the beta), I opened issue 19694 to cover the stable buildbot that is
objecting to the new venv test (most of the others seem happy with it)
--
Roundup Robot added the comment:
New changeset de65df13ed50 by Christian Heimes in branch 'default':
Issue #17134: check certs of CA and ROOT system store
http://hg.python.org/cpython/rev/de65df13ed50
--
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
Actually, _Py_DOWNCAST may be better (not a public API).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19692
___
New submission from Brett Cannon:
While working on the PEP 451 code I realized that the way we are handling the
global import lock along with the per-module lock is a little ad-hoc. For
instance, what are we wanting to use the global lock for these days? Mutations
of anything off of sys?
Nick Coghlan added the comment:
No, we can't remove wrap_codec_error, as it is still needed in order
to cover direct use of the codec machinery and to handle non-text
codecs registered by third parties (the tests cover both these cases).
--
___
Roundup Robot added the comment:
New changeset 7d914d4b05fe by Christian Heimes in branch 'default':
Issue #19448: report name / NID in exception message of ASN1Object
http://hg.python.org/cpython/rev/7d914d4b05fe
--
___
Python tracker
STINNER Victor added the comment:
No, we can't remove wrap_codec_error, as it is still needed in order
to cover direct use of the codec machinery and to handle non-text
codecs registered by third parties (the tests cover both these cases)
I searched on the WWW for third party codecs, I only
Martin v. Löwis added the comment:
-1. The macro name doesn't claim the cast to be safe, i.e. it's not
Py_SAFELY_DOWNCAST, but safe downcast, i.e. it's an assertion that the cast
actually has been verified as being safe.
--
nosy: +loewis
___
Python
Nick Coghlan added the comment:
Victor, the general purpose codec infrastructure is more than a decade
old, and supported in both Python 2 and Python 3, so you're not going
to get it deprecated in the last few days before the 3.4 feature
freeze. You've already succeeded in inconveniencing
Antoine Pitrou added the comment:
-1. The macro name doesn't claim the cast to be safe, i.e. it's not
Py_SAFELY_DOWNCAST, but safe downcast, i.e. it's an assertion that
the cast actually has been verified as being safe.
It's not an assertion, it's a cast.
Otherwise it should be named
Tim Peters added the comment:
Goodness. Name it
_Py_DOWNCAST_AND_IN_DEBUG_MODE_ASSERT_UPCASTING_THE_RESULT_COMPARES_EQUAL_TO_THE_ORIGINAL_ARGUMENT
;-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19692
Antoine Pitrou added the comment:
Updated patch addressing review comments.
--
nosy: +neologix
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19673
___
Changes by Antoine Pitrou pit...@free.fr:
Added file: http://bugs.python.org/file32776/pathlib3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19673
___
New submission from Brett Cannon:
E.g. test_namespace_pkgs should be under test_importlib and so should
test_namespace_pkgs. test_import can conceivably stay out if it's updated to
only contain syntactic tests for the import statement.
This is so that it's easier to run import-related tests
Roundup Robot added the comment:
New changeset 331b7a8bb830 by Barry Warsaw in branch 'default':
A fix for issue 19555 on Windows.
http://hg.python.org/cpython/rev/331b7a8bb830
--
___
Python tracker rep...@bugs.python.org
Changes by Antoine Pitrou pit...@free.fr:
Removed file: http://bugs.python.org/file32776/pathlib3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19673
___
Changes by Antoine Pitrou pit...@free.fr:
Added file: http://bugs.python.org/file32777/pathlib3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19673
___
Changes by Barry A. Warsaw ba...@python.org:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19555
___
Antoine Pitrou added the comment:
I plan to commit soon, if there are no further comments.
Remember the pathlib API is provisional, so API changes can still be made later
if deemed necessary.
--
___
Python tracker rep...@bugs.python.org
Guido van Rossum added the comment:
So do you need anything on *this* issue?
(And are you asking me to review/approve the other issue? I haven't kept
track carefully enough for that, and the beta is looming.)
--
___
Python tracker
New submission from Brett Cannon:
So that e.g. __main__.__spec__.name is the actual name of the module being
executed.
--
components: Interpreter Core
messages: 203796
nosy: brett.cannon, eric.snow, ncoghlan
priority: normal
severity: normal
stage: test needed
status: open
title:
Changes by Brett Cannon br...@python.org:
--
dependencies: +refactor pythonrun.c to make use of specs (__main__.__spec__)
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18864
___
New submission from Brett Cannon:
Since _imp.init_builtin and _imp.load_dynamic don't take in a module to load,
need to create new functions which do. Afterwards can deprecate init_builtin,
load_dynamic, and init_frozen (the latter having been worked around thanks to
get_frozen_object).
Changes by Brett Cannon br...@python.org:
--
dependencies: +Implement _imp.exec_builtin and exec_dynamic
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18864
___
Larry Hastings added the comment:
Anybody have a better name for __textsig__ ?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19674
___
___
New submission from Brett Cannon:
Need to add find_spec and exec_module (or move over to a pure Python zipfile
importer).
--
components: Library (Lib)
messages: 203799
nosy: brett.cannon, eric.snow, ncoghlan
priority: normal
severity: normal
stage: test needed
status: open
title:
Changes by Brett Cannon br...@python.org:
--
components: Library (Lib)
nosy: brett.cannon, eric.snow, ncoghlan
priority: normal
severity: normal
stage: test needed
status: open
title: Update runpy for PEP 451
versions: Python 3.4
___
Python tracker
STINNER Victor added the comment:
Your commit doesn't compile on Windows.
CategoryNone
Changed by Eric Snow ericsnowcurren...@gmail.com
Changed at Fri 22 Nov 2013 16:17:09
Branch default
Revision07229c6104b16d0ab7cc63f3306157d3d2819fed
Comments
Implement PEP 451
Brett Cannon added the comment:
No longer blocking b1, now just blocking rc1.
--
dependencies: +Update zipimport for PEP 451
priority: release blocker - deferred blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18864
Changes by Brett Cannon br...@python.org:
--
dependencies: +Update runpy for PEP 451
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18864
___
___
New submission from Brett Cannon:
Specifically Lib/multiprocessing/spawn.py:import_main_path()
--
components: Library (Lib)
messages: 203802
nosy: brett.cannon
priority: normal
severity: normal
stage: test needed
status: open
title: Update multiprocessing for PEP 451
versions: Python
Changes by Brett Cannon br...@python.org:
--
dependencies: +Update multiprocessing for PEP 451
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18864
___
Changes by Brett Cannon br...@python.org:
--
components: Library (Lib)
nosy: brett.cannon, eric.snow, ncoghlan
priority: normal
severity: normal
stage: test needed
status: open
title: Update pickle to PEP 451
versions: Python 3.4
___
Python tracker
Changes by Brett Cannon br...@python.org:
--
components: Library (Lib)
nosy: brett.cannon, eric.snow, ncoghlan
priority: normal
severity: normal
status: open
title: Upate pydoc to PEP 451
versions: Python 3.4
___
Python tracker rep...@bugs.python.org
Changes by Brett Cannon br...@python.org:
--
dependencies: +Upate pydoc to PEP 451, Update pickle to PEP 451
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18864
___
Changes by Brett Cannon br...@python.org:
--
components: Tests
nosy: brett.cannon, eric.snow, ncoghlan
priority: normal
severity: normal
stage: needs patch
status: open
title: Update test.test_threaded_import to PEP 451
versions: Python 3.4
___
Changes by Brett Cannon br...@python.org:
--
dependencies: +Update test.test_threaded_import to PEP 451
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18864
___
Changes by Brett Cannon br...@python.org:
--
components: Tests
nosy: brett.cannon, eric.snow, ncoghlan
priority: normal
severity: normal
stage: needs patch
status: open
title: Update test.test_namespace_pkgs to PEP 451
versions: Python 3.4
___
Python
Roundup Robot added the comment:
New changeset 43377dcfb801 by Antoine Pitrou in branch 'default':
Issue #19673: Add pathlib to the stdlib as a provisional module (PEP 428).
http://hg.python.org/cpython/rev/43377dcfb801
--
nosy: +python-dev
___
Changes by Brett Cannon br...@python.org:
--
dependencies: +Update test.test_namespace_pkgs to PEP 451
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18864
___
Changes by Brett Cannon br...@python.org:
--
dependencies: +Check if inspect needs updating for PEP 451
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18864
___
Changes by Brett Cannon br...@python.org:
--
nosy: brett.cannon, eric.snow, ncoghlan
priority: normal
severity: normal
status: open
title: Check if inspect needs updating for PEP 451
versions: Python 3.4
___
Python tracker rep...@bugs.python.org
Changes by Brett Cannon br...@python.org:
--
components: Library (Lib)
nosy: brett.cannon, eric.snow, ncoghlan
priority: normal
severity: normal
status: open
title: Check if unittest.mock needs updating for PEP 451
versions: Python 3.4
___
Python
1 - 100 of 300 matches
Mail list logo
