[issue20473] inspect.Signature no longer handles builtin classes correctly

2014-02-02 Thread Yury Selivanov
Yury Selivanov added the comment: For instance if __text_signature__ and __signature__ are present simultaneously which one should be used, or the use of '($' to specify bound-methods first parameters etc. -- ___ Python tracker

[issue20473] inspect.Signature no longer handles builtin classes correctly

2014-02-02 Thread Larry Hastings
Larry Hastings added the comment: What semantics are unsettled? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue20473] inspect.Signature no longer handles builtin classes correctly

2014-02-02 Thread Yury Selivanov
Yury Selivanov added the comment: Committed. We'll likely need to modify the code again in 3.5, once we settle the exact semantics of __text_signature__. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue20473] inspect.Signature no longer handles builtin classes correctly

2014-02-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset c19f5e4fdbe0 by Yury Selivanov in branch 'default': inspect.signature: Add (restore) support for builtin classes #20473 http://hg.python.org/cpython/rev/c19f5e4fdbe0 -- nosy: +python-dev ___ Python tracke

[issue20350] Replace tkapp.split() to tkapp.splitlist()

2014-02-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I use Linux. Unfortunately these methods (as most methods in Tkinter) are not tested. IDLE doesn't use any of these methods. -- ___ Python tracker __

[issue17159] Remove explicit type check from inspect.Signature.from_function()

2014-02-02 Thread Yury Selivanov
Yury Selivanov added the comment: > This change is redundant since BuiltinFunctionType (which isbuiltin() tests > for) is already in _NonUserDefinedCallables, which is tested for right > afterwards. The code is more understandable, though. Anyways, I'm glad that the issue is now resolved. Also,

[issue17159] Remove explicit type check from inspect.Signature.from_function()

2014-02-02 Thread Stefan Behnel
Stefan Behnel added the comment: >> inspect.isbuiltin() returns False > Are you absolutely sure about this? Yes. The "inheritance" of Cython's function type from PyCFunction is a pure implementation detail of the object struct layout that is not otherwise visible in any way. Specifically, there

[issue20475] pystone.py in 3.4 still uses time.clock(), even though it's marked as deprecated since 3.3

2014-02-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Pystone should has an option to specify a timer (as timeit). -- nosy: +serhiy.storchaka ___ Python tracker ___ ___

[issue20485] Enable 'import .pyd'

2014-02-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > The hack msg209998 is interesting, but how to name submodule with non latin > like languages, especially keeping native reable? X( It is left to your discretion. You can use idna, punycode, utf-7, szm62 or romaji. --

[issue17159] Remove explicit type check from inspect.Signature.from_function()

2014-02-02 Thread Stefan Behnel
Stefan Behnel added the comment: > Also, PEP 8 forbids using annotations in the CPython library, which > includes all of CPython's builtins. So using annotations in any way > for this was off the table. Interesting, wasn't aware of that. Then let's wait what will happen when users start manuall

[issue20498] Update StringIO newline tests

2014-02-02 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Proposed patches adds several new checks and test cases to StringIO newline tests. It also fixes test_newline_lf which didn't use the newline argument. -- components: IO, Tests messages: 210080 nosy: benjamin.peterson, hynek, pitrou, serhiy.storchak

[issue20435] Discrepancy between io.StringIO and _pyio.StringIO with univeral newlines

2014-02-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for fixing this bug. Maybe I reported it too hastily. -- ___ Python tracker ___ ___ Pyth

[issue20497] Unclear word in socket document.

2014-02-02 Thread INADA Naoki
New submission from INADA Naoki: http://docs.python.org/3.3/library/socket.html#socket.getaddrinfo > Changed in version 3.2: parameters can now be passed as single keyword > arguments. What *single* means? I can use multiple keyword arguments: In [3]: socket.getaddrinfo('www.python.org', 80,

[issue20496] function definition tutorial encourages bad practice

2014-02-02 Thread Alan Isaac
New submission from Alan Isaac: Section 4.6 of the tutorial introduces function definition: http://docs.python.org/3/tutorial/controlflow.html#defining-functions The first example defines a function that *prints* a Fibonacci series. A basic mistake made by students new to programming is to use

[issue20485] Enable 'import .pyd'

2014-02-02 Thread Suzumizaki
Suzumizaki added the comment: Thank you for reply, STINNER. > You encode it to UTF-8 and use "\xHH\xHH\xHH..." syntax to keep ASCII > encoding for the C file? The NAME may also be mentionned in docstrings, > C comments, type names, etc. The main purpose of this issue is "I want use Cython like

[issue20368] Tkinter: handle the null character

2014-02-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: The core of the patch is a wrapper that traps UnicodeDecodeErrors, corrects the strings, and re-decodes. A Python version might look like def unicodeFromTclStringAndSize(s, size): try: return except UnicodeDecodeError: if b'\xc0\x80' in s: s.

[issue20495] test_read_pty_output() hangs on FreeBSD 7.2 buildbot

2014-02-02 Thread Guido van Rossum
Guido van Rossum added the comment: I guess this is not a total surprise given that OS X derives in some way from BSD... I wonder if we just need to make a matrix of which OS versions and which syscalls can handle PTYs correctly, and either put it in the docs or perhaps even refuse to accept

[issue20318] subprocess.Popen can hang in threaded applications in Python 2

2014-02-02 Thread STINNER Victor
Changes by STINNER Victor : -- title: subprocess.Popen can hang in threaded applications -> subprocess.Popen can hang in threaded applications in Python 2 ___ Python tracker ___

[issue19334] test_asyncio hanging for 1 hour (non-AIX version)

2014-02-02 Thread STINNER Victor
STINNER Victor added the comment: > It was hanging on FreeBSD 7.2 recently: > http://buildbot.python.org/all/builders/x86%20FreeBSD%207.2%203.x/builds/4917/steps/test/logs/stdio Oh, it still hangs on the latest version of the code. I opened #20495 to track this bug. -- resolution: ->

[issue20495] test_read_pty_output() hangs on FreeBSD 7.2 buildbot

2014-02-02 Thread STINNER Victor
New submission from STINNER Victor: http://buildbot.python.org/all/builders/x86%20FreeBSD%207.2%203.x/builds/4969/steps/test/logs/stdio --- [298/389/1] test_asyncio Timeout (1:00:00)! Current thread 0x28401040 (most recent call first): File "/usr/home/db3l/buildarea/3.x.bolen-freebsd7/build/Li

[issue20494] Backport of http://bugs.python.org/issue11849 to Python 2.7 (Make it more likely for the system allocator to release free()d memory arenas on glibc-based systems).

2014-02-02 Thread Benjamin Yolken
Benjamin Yolken added the comment: Attaching an updated version of the patch generated with autoconf 2.69 instead of 2.68. -- Added file: http://bugs.python.org/file33883/memory_fix_updated.patch ___ Python tracker

[issue20493] asyncio: OverflowError('timeout is too large')

2014-02-02 Thread Guido van Rossum
Guido van Rossum added the comment: Shouldn't this be fixed in the C implementation of the select module or in selectors.py? It seems likely that the exact range might be different for each syscall and possibly per OS or even OS version. -- ___ Pyth

[issue20405] Add io.BinaryTransformWrapper and a "transform" parameter to open()

2014-02-02 Thread STINNER Victor
STINNER Victor added the comment: > Ever used "recode" ? No, what is it? I once used iconv for short tests, but I never required iconv to convert a real document. > E.g. the example at the end of codecs.py allows using Latin-1 within > the application, while talking to the console using UTF-8.

[issue20414] Python 3.4 has two Overlapped types

2014-02-02 Thread STINNER Victor
STINNER Victor added the comment: Sorry Martin, I'm not sure that I understood your proposition. Here is a new patch. -- Added file: http://bugs.python.org/file33882/overlapped_dealloc-2.patch ___ Python tracker _

[issue20350] Replace tkapp.split() to tkapp.splitlist()

2014-02-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: I know split has been troublesome and I am generally in favor of removing semi-duplication. Here are my questions. What system are you developing and testing on? Should I try the patch on Windows? Have you used coveragepy to see if the patched areas are covered

[issue20428] _Py_open does not work with O_CREAT

2014-02-02 Thread STINNER Victor
STINNER Victor added the comment: > In file included from ./Modules/_localemodule.c:404:0, I don't see where _Py_open() is used in _localemodule.c. I didn't find a call to _Py_open() using O_CREAT. In fact, O_CREAT is not used in the C code of Python. (Except dbmopen in the dbm module, but it

[issue12187] subprocess.wait() with a timeout uses polling on POSIX

2014-02-02 Thread STINNER Victor
STINNER Victor added the comment: Ok, the new asyncio.subprocess module has been merged. Use asyncio.create_subprocess_exec/shell to create a subprocess and then use asyncio.wait_for(proc.wait(), timeout) to wait for the exit of the process with a timeout. The wait is asynchronous thanks to as

[issue20485] Enable 'import .pyd'

2014-02-02 Thread STINNER Victor
STINNER Victor added the comment: The PyInit_NAME symbol is not the only place where NAME is used. The NAME is also present in the PyModuleDef structure. It looks lie Python expects UTF-8 here. You encode it to UTF-8 and use "\xHH\xHH\xHH..." syntax to keep ASCII encoding for the C file? The N

[issue20494] Backport of http://bugs.python.org/issue11849 to Python 2.7 (Make it more likely for the system allocator to release free()d memory arenas on glibc-based systems).

2014-02-02 Thread Benjamin Yolken
New submission from Benjamin Yolken: We have found that http://bugs.python.org/issue11849 affects a number of our Python 2.7 systems in production. I took the changes in http://hg.python.org/cpython/rev/f8a697bc3ca8 and backported them to the head of the python 2.7 cpython hg branch. I have ve

[issue20493] asyncio: OverflowError('timeout is too large')

2014-02-02 Thread STINNER Victor
STINNER Victor added the comment: Attached patch fixes the issue, but it has no unit test :-( On Windows, it looks like IocpProactor can also raise an error if the timeout is too large: # GetQueuedCompletionStatus() has a resolution of 1 millisecond, # round away from z

[issue20493] asyncio: OverflowError('timeout is too large')

2014-02-02 Thread STINNER Victor
New submission from STINNER Victor: In asyncio, if the next event is in 2^40 seconds, epoll.poll() raises an OverflowError because epoll_wait() maximum value for the timeout is INT_MAX seconds. Test timeout_overflow.py to reproduce the issue. -- files: timeout_overflow.py messages: 21

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-02-02 Thread Guido van Rossum
Guido van Rossum added the comment: neologix, you are getting dangerously close to attacking the person instead of the issue. Can you live with the current state of the code? If so, let us know (or be silent if you prefer). If you cannot live with it, please show example code that fails or is

[issue20485] Enable 'import .pyd'

2014-02-02 Thread Suzumizaki
Suzumizaki added the comment: Thank you for reply. The hack msg209998 is interesting, but how to name submodule with non latin like languages, especially keeping native reable? X( The reason I don't use like "name.encode('unicode-escape').replace(b'\\', b'_')" is the length limits of the ide

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-02-02 Thread STINNER Victor
STINNER Victor added the comment: > So, to sum up: > - you write a fragile and unelegant patch without a good reason > - you commit it without review > - you're asked several times to provide an example of the problems your patch > is supposed to solve, but don't give any > - you don't take into

[issue20475] pystone.py in 3.4 still uses time.clock(), even though it's marked as deprecated since 3.3

2014-02-02 Thread STINNER Victor
STINNER Victor added the comment: > Besides, if time.clock() is deprecated, pystone will *have* to be modified > one day, anyway. If something is changed, I would prefer to simply drop this old tool. It is not reliable and so may give you wrong results. -- ___

[issue20475] pystone.py in 3.4 still uses time.clock(), even though it's marked as deprecated since 3.3

2014-02-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: Paul: > well, pystone has limits to its "scientificity", it's more like quick- > run-anywhere, there's pybench for "real" testing (it's maintained and > supported I hope) pybench is so synthetic it's almost a nano-benchmark. I would suggest using the benchmar

[issue20475] pystone.py in 3.4 still uses time.clock(), even though it's marked as deprecated since 3.3

2014-02-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: > If pystone uses a different clock in Python 3.4, you may not be able > to compare compare results with older Python versions. This sounds a bit silly. Typical pystone runs last a couple seconds at most, there won't be a significant clock drift in such a shor

[issue20472] test_write_pty() of test_asyncio fails on "x86 Tiger 3.x" buildbot

2014-02-02 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue20472] test_write_pty() of test_asyncio fails on "x86 Tiger 3.x" buildbot

2014-02-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 21a4ebf5a170 by Victor Stinner in branch 'default': Issue #20472: test_asyncio: skip PTY tests on Mac OS X older than 10.6 http://hg.python.org/cpython/rev/21a4ebf5a170 New changeset 0a71d29b970a by Victor Stinner in branch 'default': Issue #20472:

[issue20472] test_write_pty() of test_asyncio fails on "x86 Tiger 3.x" buildbot

2014-02-02 Thread Ned Deily
Ned Deily added the comment: With asyncio_pty_osx-2.patch, test_asyncio now passes on OS X 10.4.11 and 10.5.8. -- ___ Python tracker ___

[issue20472] test_write_pty() of test_asyncio fails on "x86 Tiger 3.x" buildbot

2014-02-02 Thread STINNER Victor
STINNER Victor added the comment: Oh, Ned told me that tests using the PollSelector are still failing. I forgot that poll() is also supported on OS X. Please try this new patch. -- Added file: http://bugs.python.org/file33878/asyncio_pty_osx-2.patch ___

[issue17159] Remove explicit type check from inspect.Signature.from_function()

2014-02-02 Thread Larry Hastings
Larry Hastings added the comment: > That's likely true for CPython itself, at least currently. > I don't think it's generally a safe assumption in the CPython > ecosystem, which includes things like Cython, Numba, Nuitka and others, While I'm happy to accommodate these other projects if it's eas

[issue15216] Support setting the encoding on a text stream after creation

2014-02-02 Thread Nick Coghlan
Nick Coghlan added the comment: It's a blunt instrument to be sure, but a necessary one, I think - otherwise we end with a scattering of API specific solutions rather than a single consistent approach. Here's a thought, though: what if we went with Serhiy's "reconfigure" idea, limited that to s

[issue20486] msilib: can't close opened database

2014-02-02 Thread Ned Deily
Changes by Ned Deily : -- nosy: +loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org

[issue20480] Add ipaddress property to get name of reverse DNS PTR record

2014-02-02 Thread Nick Coghlan
Nick Coghlan added the comment: >From a "principle of least surprise" point of view, non-specialists would likely be puzzled by a trailing dot and wonder why it was there. By contrast, specialists that know the trailing dot is technically *supposed* to be there are already going to be accustomed

[issue20426] Compiling a regex with re.DEBUG should force a recompile

2014-02-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: A simple workaround is to bypass the cache when DEBUG is passed. See attached patch. (not sure this applies as a bug fix, but DEBUG probably isn't used in production anyway: the potential for breakage is low) -- keywords: +patch stage: test needed -> p

[issue20475] pystone.py in 3.4 still uses time.clock(), even though it's marked as deprecated since 3.3

2014-02-02 Thread Paul Sokolovsky
Paul Sokolovsky added the comment: Yes, and my note about "scientificity" above. Also compare with your own account of time.perf_counter() above ("Usually time.perf_counter() is the expected function.") Also, I didn't want to start discussion on how to do benchmarking right, just to point out

[issue20435] Discrepancy between io.StringIO and _pyio.StringIO with univeral newlines

2014-02-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: I've fixed the reported bug. If other problems need fixing, better open a new issue :-) -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker

[issue20435] Discrepancy between io.StringIO and _pyio.StringIO with univeral newlines

2014-02-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3e61d8e06ef7 by Antoine Pitrou in branch '2.7': Issue #20435: Fix _pyio.StringIO.getvalue() to take into account newline translation settings. http://hg.python.org/cpython/rev/3e61d8e06ef7 -- ___ Python

[issue20435] Discrepancy between io.StringIO and _pyio.StringIO with univeral newlines

2014-02-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 99168e7d4a3d by Antoine Pitrou in branch '3.3': Issue #20435: Fix _pyio.StringIO.getvalue() to take into account newline translation settings. http://hg.python.org/cpython/rev/99168e7d4a3d New changeset aadcc71a4967 by Antoine Pitrou in branch 'def

[issue20435] Discrepancy between io.StringIO and _pyio.StringIO with univeral newlines

2014-02-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Current results for newline != '\n' looks meanless to me. They don't look meaningless to me, e.g.: >>> io.StringIO("a\r\nc\rd", newline=None).getvalue() 'a\nc\nd' >>> sio = io.StringIO(newline=None); sio.write("a\r\nc\rd"); sio.getvalue() 6 'a\nc\nd' There m

[issue20475] pystone.py in 3.4 still uses time.clock(), even though it's marked as deprecated since 3.3

2014-02-02 Thread STINNER Victor
STINNER Victor added the comment: > That's why I just propose to switch it to time.time(), which surely is > available on each and every Python version and implementation. It's not the same clock. time.clock() measures the process time, which is different from the wall clock time. Compare tim

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-02-02 Thread Charles-François Natali
Charles-François Natali added the comment: > > Once again: a slight early wakeup isn't an issue > > That's your opinion, but I disagree. > > Please open a new issue with a patch, or reopen at least this issue because > it is now closed. > > I already spent to much time on this issue. Buildbots a

[issue20475] pystone.py in 3.4 still uses time.clock(), even though it's marked as deprecated since 3.3

2014-02-02 Thread Paul Sokolovsky
Paul Sokolovsky added the comment: > The problem with pystone is that such tool is used to compare performances > between different versions of Python. That's why I just propose to switch it to time.time(), which surely is available on each and every Python version and implementation. If there

[issue20435] Discrepancy between io.StringIO and _pyio.StringIO with univeral newlines

2014-02-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: But how then other values of newline except '\n' can be useful? The problem is that newline converting is applied twice, in write() and in read(). When constructor uses write() and getvalue() returns same value as read(), we have no chance to get newlines en

[issue20479] Efficiently support weight/frequency mappings in the statistics module

2014-02-02 Thread Wolfgang Maier
Wolfgang Maier added the comment: > -Ursprüngliche Nachricht- > Von: Steven D'Aprano [mailto:rep...@bugs.python.org] > Gesendet: Sonntag, 2. Februar 2014 12:55 > An: wolfgang.ma...@biologie.uni-freiburg.de > Betreff: [issue20479] Efficiently support weight/frequency mappings in the > stat

[issue20470] "Fatal Python error: Bus error" on the SPARC Solaris 10 buildbot

2014-02-02 Thread STINNER Victor
STINNER Victor added the comment: Cool, the tests are no more crashing on this buildbot. I close the issue. -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue20455] test_asyncio hangs on Windows

2014-02-02 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue20472] test_write_pty() of test_asyncio fails on "x86 Tiger 3.x" buildbot

2014-02-02 Thread STINNER Victor
STINNER Victor added the comment: Here is a patch to skip the tests for SelectSelector on Mac OS X older than 10.6 (Snow Leopard). @Ned: Could you please try it? I don't have access to such old Mac OS X versions. (I now only have a iMac running 10.9). -- keywords: +patch Added file: h

[issue20475] pystone.py in 3.4 still uses time.clock(), even though it's marked as deprecated since 3.3

2014-02-02 Thread STINNER Victor
STINNER Victor added the comment: The problem with pystone is that such tool is used to compare performances between different versions of Python. If pystone uses a different clock in Python 3.4, you may not be able to compare compare results with older Python versions. In my opinion, such ch

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-02-02 Thread STINNER Victor
STINNER Victor added the comment: > Once again: a slight early wakeup isn't an issue That's your opinion, but I disagree. Please open a new issue with a patch, or reopen at least this issue because it is now closed. I already spent to much time on this issue. Buildbots are now happy, I don't

[issue20435] Discrepancy between io.StringIO and _pyio.StringIO with univeral newlines

2014-02-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: In other words, the bug is that _pyio.StringIO.getvalue() doesn't do any newline conversion; the patch fixes that. -- ___ Python tracker ___ __

[issue19761] test_tk fails on OS X with multiple test case failures with both Tk 8.5 and 8.4

2014-02-02 Thread Ned Deily
Ned Deily added the comment: The supplied patch fixed all of the failing test cases on OS X, tested on 3.3 and default with Cocoa Tk 8.5 & 8.6, Carbon Tk 8.4, and X11 Tk 8.6. I'll test on 2.7 after the modified patch is applied. Thanks, Serhiy! -- stage: patch review -> commit review

[issue20435] Discrepancy between io.StringIO and _pyio.StringIO with univeral newlines

2014-02-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: With the patch, getvalue() is consistent with read() and other methods. Without the patch, _pyio.StringIO.getvalue() returns a different value from _pyio.StringIO.read() *and* from _io.StringIO.getvalue(). Changing _pyio.StringIO.getvalue() is the path of least

[issue20481] Clarify type coercion rules in statistics module

2014-02-02 Thread Wolfgang Maier
Wolfgang Maier added the comment: Hi Oscar, well, I haven't used sympy much, and I have no experience with the others, but in light of your comment I quickly checked sympy and gmpy2. You are right about them still not using the numbers ABCs, however, on your advise I also checked how the curren

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-02-02 Thread Charles-François Natali
Charles-François Natali added the comment: > I don't think so. Please read again the issue #20452, for example this message: > > http://bugs.python.org/issue20452#msg209772 """ Ok, it looks better: waiting 99.9 ms took 99.6 ms and 99.9 ms, and waiting 9.9 ms took 9.7 ms. So as I said, the granul

[issue20435] Discrepancy between io.StringIO and _pyio.StringIO with univeral newlines

2014-02-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I rather think that it's a bug in _io.StringIO.getvalue(). -- ___ Python tracker ___ ___ Python-bu

[issue19990] Add unittests for imghdr module

2014-02-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset e2d013e90e88 by Ned Deily in branch '2.7': Issue #19990: Install test/imghdrdata. http://hg.python.org/cpython/rev/e2d013e90e88 New changeset 5fbe155e62b0 by Ned Deily in branch '3.3': Issue #19990: Install test/imghdrdata. http://hg.python.org/cpyt

[issue20491] textwrap: Non-breaking space not honored

2014-02-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thanks for the patch, Kaarle. Could you add some tests in Lib/test/test_textwrap? Also, for your contribution to be integrated, we'll need you to sign a contributor's agreement: http://www.python.org/psf/contrib/contrib-form/ -- nosy: +pitrou ___

[issue20452] test_timeout_rounding() of test_asyncio fails on "x86 Ubuntu Shared 3.x" buildbot

2014-02-02 Thread STINNER Victor
STINNER Victor added the comment: Buildbots are happy, I close the issue. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ _

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-02-02 Thread STINNER Victor
STINNER Victor added the comment: > Well, now that timeouts are properly rounded, the granularity is useless. I don't think so. Please read again the issue #20452, for example this message: http://bugs.python.org/issue20452#msg209772 -- ___ Python t

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-02-02 Thread Charles-François Natali
Charles-François Natali added the comment: Well, now that timeouts are properly rounded, the granularity is useless. -- ___ Python tracker ___ ___

[issue20423] io.StringIO newline param has wrong default

2014-02-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: The docs are now fixed, thank you! -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker _

[issue20423] io.StringIO newline param has wrong default

2014-02-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 82cfab2ad98d by Antoine Pitrou in branch '3.3': Issue #20423: fix documentation of io.StringIO's newline parameter http://hg.python.org/cpython/rev/82cfab2ad98d New changeset 69a2cc048c80 by Antoine Pitrou in branch '2.7': Issue #20423: fix document

[issue15216] Support setting the encoding on a text stream after creation

2014-02-02 Thread Nikolaus Rath
Nikolaus Rath added the comment: The attached patch now passes all testcases. However, every invocation of set_encoding() when there is buffered data leaks one reference. I haven't been able to find the error yet. As for adding a reopen() or configure() method: I don't like it very much, but

[issue20435] Discrepancy between io.StringIO and _pyio.StringIO with univeral newlines

2014-02-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: It's a bug in _pyio.StringIO.getvalue(). Attaching patch. -- keywords: +patch Added file: http://bugs.python.org/file33873/stringio_getvalue.patch ___ Python tracker __

[issue20491] textwrap: Non-breaking space not honored

2014-02-02 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +georg.brandl, serhiy.storchaka stage: -> test needed versions: +Python 2.7 -Python 3.5 ___ Python tracker ___ ___

[issue20492] test_tcl is failing on windows 2.7

2014-02-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Benjamin, I just have fixed it in issue19320. -- resolution: -> duplicate stage: -> committed/rejected status: open -> closed superseder: -> Tkinter tests ran with wantobjects is false ___ Python tracke

[issue19320] Tkinter tests ran with wantobjects is false

2014-02-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 515e6afd2f0f by Serhiy Storchaka in branch '2.7': Issue #19320: Fixed split/splitlist tests in test_tcl for Tcl 8.5.0-8.5.5. http://hg.python.org/cpython/rev/515e6afd2f0f New changeset e6363a42a9f0 by Serhiy Storchaka in branch '3.3': Issue #19320:

[issue16074] Bad error message in os.rename, os.link, and os.symlink

2014-02-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Larry, are you agree with this solution (remove ambiguous filename attribute from OSError raised by functions with two filename arguments)? -- ___ Python tracker ___

[issue20492] test_tcl is failing on windows 2.7

2014-02-02 Thread Benjamin Peterson
New submission from Benjamin Peterson: http://buildbot.python.org/all/builders/x86%20Windows%20Server%202003%20%5BSB%5D%202.7/builds/833/steps/test/logs/stdio -- assignee: serhiy.storchaka messages: 210014 nosy: benjamin.peterson, serhiy.storchaka priority: normal severity: normal status

[issue20491] textwrap: Non-breaking space not honored

2014-02-02 Thread Kaarle Ritvanen
New submission from Kaarle Ritvanen: The textwrap module does not distinguish non-breaking space (\xa0) from other whitespace when determining word boundaries. In the beginning of the module, the _whitespace variable is defined to address this issue but is not used in the regular expressions d

[issue20384] os.open() exception doesn't contain file name on Windows

2014-02-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Larry, what would you say about os.open() error? -- nosy: +larry ___ Python tracker ___ ___ Python

[issue20368] Tkinter: handle the null character

2014-02-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: If there are no objections I'll commit this patch tomorrow. -- assignee: -> serhiy.storchaka ___ Python tracker ___ _

[issue20350] Replace tkapp.split() to tkapp.splitlist()

2014-02-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: If there are no objections I'll commit this patch tomorrow. -- assignee: -> serhiy.storchaka ___ Python tracker ___ _

[issue19761] test_tk fails on OS X with multiple test case failures with both Tk 8.5 and 8.4

2014-02-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Ned for your great investigation. Here is a patch for these two bugs. A test for invalid bitmap is skipped (also added a test for bitmap specified in external file). For insertborderwidth tests the insertwidth value is explicitly increased (yes, t

[issue20102] shutil._make_zipfile possible resource leak

2014-02-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 767d034b3feb by Benjamin Peterson in branch '2.7': use with statement to ensure zipfile is always closed (closes #20102) http://hg.python.org/cpython/rev/767d034b3feb New changeset 838674d15b5b by Benjamin Peterson in branch '3.3': use with statemen

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-02-02 Thread STINNER Victor
STINNER Victor added the comment: Buildbots are happy, I close the issue. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ _

[issue20487] Odd words in unittest.mock document.

2014-02-02 Thread Michael Foord
Michael Foord added the comment: A "side effect" is a mechanism Mock provides for mocks to have special behaviour when called. http://docs.python.org/3.3/library/unittest.mock.html#unittest.mock.Mock.side_effect The term is used very widely throughout the mock documentation, so I don't think

[issue20490] Show clear error message on circular import

2014-02-02 Thread R. David Murray
Changes by R. David Murray : -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue20490] Show clear error message on circular import

2014-02-02 Thread Yury Selivanov
Changes by Yury Selivanov : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue20490] Show clear error message on circular import

2014-02-02 Thread Yury Selivanov
Changes by Yury Selivanov : -- nosy: +yselivanov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue20490] Show clear error message on circular import

2014-02-02 Thread Ram Rachum
New submission from Ram Rachum: If there's a circular import in my program, I don't want to see an error message, "Cannot import name 'foo'" and then say in my mind, "ah, I'm an experienced Python developer, I know that when Python says that it often means that there's a circular import proble

[issue20473] inspect.Signature no longer handles builtin classes correctly

2014-02-02 Thread Yury Selivanov
Yury Selivanov added the comment: Larry, Quoting your reply from #17159: > Also also, I remember specifically that the isinstance(type) code would fail > builtin classes. Could you please find an example of this? -- ___ Python tracker

[issue17159] Remove explicit type check from inspect.Signature.from_function()

2014-02-02 Thread Yury Selivanov
Yury Selivanov added the comment: Larry, > Also, I assumed that anything that had a __text_signature__ wasn't going to > have any other kind of signature information. Therefore, if the object had a > __text_signature__ attribute, then I already knew that's the best approach > and it should d

[issue17159] Remove explicit type check from inspect.Signature.from_function()

2014-02-02 Thread Yury Selivanov
Yury Selivanov added the comment: Stefan, > inspect.isbuiltin() returns False Are you absolutely sure about this? Please check that everything works with this latest change http://hg.python.org/cpython/rev/48c3c42e3e5c -- ___ Python tracker

[issue20485] Enable 'import .pyd'

2014-02-02 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: I'd use a much simpler encoding. Maybe something like name.encode('unicode-escape').replace(b'\\', b'_') As you said, simplicity is important for tools which generate code! -- nosy: +amaury.forgeotdarc ___ P

[issue20489] help() fails for zlib Compress and Decompress objects

2014-02-02 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: >>> import zlib >>> d = zlib.decompressobj() >>> d >>> c = zlib.compressobj() >>> c >>> zlib.DEF_BUF_SIZE 16384 >>> zlib.Z_FINISH 4 >>> help(c) Traceback (most recent call last): File "/home/serhiy/py/cpython/Lib/inspect.py", line 2243, in wrap_value

[issue16779] Fix compiler warning when building extension modules on 64-bit Windows

2014-02-02 Thread Stefan Krah
Changes by Stefan Krah : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16779] Fix compiler warning when building extension modules on 64-bit Windows

2014-02-02 Thread Stefan Krah
Changes by Stefan Krah : -- assignee: eric.araujo -> resolution: duplicate -> stage: committed/rejected -> needs patch status: closed -> open ___ Python tracker ___ ___

  1   2   >