[issue21432] samba.git from git://git.samba.org/samba.git samba.netcmd.main not found

2014-05-05 Thread Ned Deily

Changes by Ned Deily n...@acm.org:


--
stage:  - resolved

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21432
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21432] samba.git from git://git.samba.org/samba.git samba.netcmd.main not found

2014-05-05 Thread Ned Deily

Ned Deily added the comment:

Sorry, this is a tracker for bugs in Python, not a help forum.  Suggest you ask 
your question on a user forum, like Python list 
(https://mail.python.org/mailman/listinfo/python-list) or a samba group or 
perhaps http://superuser.com.

--
nosy: +ned.deily
resolution:  - not a bug
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21432
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20866] segfailt with os.popen and SIGPIPE

2014-05-05 Thread akira

akira added the comment:

Victor, where can you reproduce it (OS, python version, what C lib)?

I don't receive segfault, only sigpipe (see msg217818 ). Here's gdb backtrace 
after the signal:

Program received signal SIGPIPE, Broken pipe.
0x771e1040 in __write_nocancel () at 
../sysdeps/unix/syscall-template.S:82
82  ../sysdeps/unix/syscall-template.S: No such file or directory.
(gdb) backtrace
#0  0x771e1040 in __write_nocancel () at 
../sysdeps/unix/syscall-template.S:82
#1  0x77173883 in _IO_new_file_write (f=0x7e1f10, data=0x766cb034,
n=1097728) at fileops.c:1289
#2  0x7717374a in new_do_write (fp=0x7e1f10,
data=0x766cb034 0123456789\n...01...,
to_do=1097728) at fileops.c:543
#3  0x771741fe in _IO_new_file_xsputn (n=110, data=optimized out,
f=0x7e1f10) at fileops.c:1383
#4  _IO_new_file_xsputn (f=0x7e1f10, data=optimized out, n=110)
at fileops.c:1305
#5  0x77169cdd in _IO_fwrite (buf=optimized out, size=1, 
count=110,
fp=0x7e1f10) at iofwrite.c:45
#6  0x0042c23c in file_write (f=0x77f16540, args=optimized out)
at Objects/fileobject.c:1851

Note: the line is 1851, not 1852 (as in the latest 2.7 version [1]) as in your 
traceback.
And the calls inside _IO_new_file_xsputn() are also different.

[1]: http://hg.python.org/cpython/file/b768d41dec0a/Objects/fileobject.c#l1852

python2.7.6 is installed using `pythonz install 2.7.6` command.

Just to make sure that python2.7.6 *can* segfault:

  $ python2.7.6 -c'import ctypes; ctypes.memset(0,0,1)'
  Segmentation fault (core dumped)

core file is not written on my system:

  $ cat /proc/sys/kernel/core_pattern
  |/usr/share/apport/apport %p %s %c

But I can see in the log when a process segfaults e.g.,
the segfault due to memset is logged:

  $ tail -F /var/log/apport.log
  ERROR: apport (pid 8501) ... executable: 
~/.pythonz/pythons/CPython-2.7.6/bin/python2.7 \
  (command line python2.7.6 -cimport\ ctypes;\ ctypes.memset(0,0,1))


To find out where `fwrite` come from, I've done:

  $ nm $(which python2.7.6) | grep fwrite
   U fwrite@@GLIBC_2.2.5

  $ cat $(gcc -print-file-name=libc.so)
  /* GNU ld script
   ... */
  OUTPUT_FORMAT(elf64-x86-64)
  GROUP ( /lib/x86_64-linux-gnu/libc.so.6 ... )

  $ ldd $(which python2.7.6)
  ...
  libc.so.6 = /lib/x86_64-linux-gnu/libc.so.6
  ...

  $ /lib/x86_64-linux-gnu/libc.so.6
  GNU C Library (Ubuntu EGLIBC 2.15-0ubuntu10.5) stable release version 2.15, 
by Roland McGrath et al.
  Copyright (C) 2012 Free Software Foundation, Inc.
  ...
  Compiled by GNU CC version 4.6.3.
  Compiled on a Linux 3.2.50 system on 2013-09-30.
  ...

/usr/bin/python behaves similar -- it just has version that is not mentioned by 
the OP.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20866
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7850] platform.system() should be macosx instead of Darwin on OSX

2014-05-05 Thread Marc-Andre Lemburg

Marc-Andre Lemburg added the comment:

Caelyn: Thanks for the patch.

Some comments:

* Please use aliased=False instead of aliased=0 in the patch.
* It would be great if you could enhance the test a bit to actually check the 
return value. This would need a mock of the os.uname API for the test.
* Doc string if aliased is true should read If aliased is true

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7850
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7850] platform.system() should be macosx instead of Darwin on OSX

2014-05-05 Thread Marc-Andre Lemburg

Marc-Andre Lemburg added the comment:

Removing 2.7 as target, since this is a new feature.

--
versions:  -Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7850
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21132] Failure to import win32api

2014-05-05 Thread David Woakes

David Woakes added the comment:

This issue is not related to anything in the Python 3.4 release. It's a problem 
with the installer not asking to be installed as administrator.

Running C:\Python34\Scripts\pywin32_postinstall.py as administrator after 
installing fixes this.

--
resolution:  - third party
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21132
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21422] int 0: return the number unmodified

2014-05-05 Thread Mark Dickinson

Mark Dickinson added the comment:

BTW, there's also a behaviour change here.  Before the patch:

 True  0
1

After the patch:

 True  0
True

Which demonstrates another good reason to avoid trivial-looking optimisations: 
it's far too easy to accidentally change behaviour.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21422
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21434] python -3 documentation is outdated

2014-05-05 Thread Berker Peksag

New submission from Berker Peksag:

https://docs.python.org/2.7/using/cmdline.html#cmdoption-3

Currently, lib2to3 provides fixers for dict.has_key(), apply(), callable(),
execfile() and reduce() functions.

The reload fixer was added to Python 3.4 in issue 11797, but not backported 
to 2.7.

--
assignee: docs@python
components: Documentation
files: cmdline-3.diff
keywords: patch
messages: 217914
nosy: berker.peksag, docs@python
priority: normal
severity: normal
stage: patch review
status: open
title: python -3 documentation is outdated
versions: Python 2.7
Added file: http://bugs.python.org/file35151/cmdline-3.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21434
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21121] -Werror=declaration-after-statement is added even for extension modules through setup.py

2014-05-05 Thread Stefan Krah

Stefan Krah added the comment:

The current patch allows the user to specify e.g.:

CFLAGS_NODIST=-march=core2 ./configure


So it would be surprising to get:

 import sysconfig
 sysconfig.get_config_var('CFLAGS_NODIST')
''


Now, we could restrict ourselves entirely to internal PY_CFLAGS_NODIST,
but I think exposing the feature is really useful if users or
distributors want to specify optimizations, FPU behavior or other
things that should not generally show up in distutils.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21121
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21427] installer not working

2014-05-05 Thread Uwe

Uwe added the comment:

I guess this is merely describing the problem and not the solution?
(by the way I had no difficulties with the 64bit version on a 64bit 
win7 system)

Would it be possible to produce the binairies myself using the mingw
compiler? The readme says visual c++ is required.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21427
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17756] test_syntax_error fails when run in the installed location

2014-05-05 Thread Matthias Klose

Matthias Klose added the comment:

seen this again in our autopkg tester
https://jenkins.qa.ubuntu.com/view/Utopic/view/AutoPkgTest/job/utopic-adt-python3.4/12/

however now I can't reproduce this locally, and the test succeeds during the 
build.

--
status: pending - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17756
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21435] Segfault with cyclic reference and asyncio.Future

2014-05-05 Thread Peter Inglesby

New submission from Peter Inglesby:

The following code causes a segfault when run under Python3.4+ on OSX10.9.

# segfaulter.py
import asyncio
 
class A:
pass
 
class B:
def __init__(self, future):
self.future = future
 
def __del__(self):
self.a = None
 
@asyncio.coroutine
def do_work(future):
a = A()
b = B(asyncio.Future())
 
a.b = b
b.a = a
 
future.set_result(None)
 
future = asyncio.Future()
asyncio.Task(do_work(future))
loop = asyncio.get_event_loop()
loop.run_until_complete(future)


It does matter that the Future is passed to b's __init__ method.

It doesn't matter whether the Future has been resolved.

Attached is the problem report generated by OSX on the crash.

--
files: problemreport.txt
messages: 217918
nosy: inglesp
priority: normal
severity: normal
status: open
title: Segfault with cyclic reference and asyncio.Future
type: crash
versions: Python 3.4, Python 3.5
Added file: http://bugs.python.org/file35152/problemreport.txt

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21435
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21436] bring back importlib.load_source() et al.

2014-05-05 Thread Sebastian Rittau

New submission from Sebastian Rittau:

It was very easy to load plugin files in Python 2:

import imp
my_module = imp.load_source(what.ever, foo.py)

Unfortunately, this became much more obscure in Python 3.3:

import importlib.machinery
loader = importlib.machinery.SourceFileLoader(what.ever, foo.py)
my_module = loader.load_module(what.ever)

In Python 3.4 even this has been deprecated. There should be a way (preferable 
an easy-to-use one) to load a Python module by filename or by stream.

--
components: Library (Lib)
messages: 217919
nosy: srittau
priority: normal
severity: normal
status: open
title: bring back importlib.load_source() et al.
type: enhancement
versions: Python 3.4, Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21436
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21436] bring back importlib.load_source() et al.

2014-05-05 Thread Claudiu.Popa

Changes by Claudiu.Popa pcmantic...@gmail.com:


--
nosy: +Claudiu.Popa

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21436
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21436] bring back importlib.load_source() et al.

2014-05-05 Thread Berker Peksag

Changes by Berker Peksag berker.pek...@gmail.com:


--
nosy: +brett.cannon, eric.snow

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21436
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21392] Python on Cygwin: subprocess.call BlockingIOError: [Errno 11] Resource temporarily unavailable

2014-05-05 Thread dellair jie

dellair jie added the comment:

Eric,

Very much appreciated for your offer to help.
This issue is with Cygwin fork(), documented here:
http://cygwin.com/faq.html#faq.using.fixing-fork-failures

I am closing the issue.
Have a great day!

--
resolution:  - not a bug
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21392
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21437] document that asyncio.ProactorEventLoop doesn't support SSL

2014-05-05 Thread akira

New submission from akira:

In Lib/asyncio/proactor_events.py:419 [1]:

  def _start_serving(self, protocol_factory, sock, ssl=None, server=None):
if ssl:
  raise ValueError('IocpEventLoop is incompatible with SSL.')

[1]: 
http://hg.python.org/cpython/file/4f26430b03fd/Lib/asyncio/proactor_events.py#l419

ProactorEventLoop is mentioned in the docs that it should be used to run 
subprocesses on Windows. [2]

[2]: 
http://hg.python.org/cpython/file/4f26430b03fd/Doc/library/asyncio-subprocess.rst

It might be a good example to demonstrate the idiomatic way how two different 
event loops could be used (to support both subprocesses and ssl connections in 
the same program).

--
assignee: docs@python
components: Documentation
messages: 217921
nosy: akira, docs@python
priority: normal
severity: normal
status: open
title: document that asyncio.ProactorEventLoop doesn't support SSL
type: enhancement
versions: Python 3.4, Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21437
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21438] Document which importlib.machinery loaders don't require an argument for load_module()

2014-05-05 Thread Brett Cannon

New submission from Brett Cannon:

Multiple loaders don't require an argument for load_module() because the module 
name is provided as part of instance initialization. As such it doesn't hurt to 
document this fact to help shorten manual calls to the instances as when people 
do when transitioning off of the imp module.

--
assignee: brett.cannon
components: Documentation
messages: 217922
nosy: brett.cannon
priority: normal
severity: normal
status: open
title: Document which importlib.machinery loaders don't require an argument for 
load_module()
versions: Python 3.4, Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21438
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21436] Consider leaving importlib.abc.Loader.load_module()

2014-05-05 Thread Brett Cannon

Brett Cannon added the comment:

So it's not quite as bad as you think as SourceFileLoader.load_module() doesn't 
need an argument (I've opened http://bugs.python.org/issue21438 to fix the 
documentation). Admittedly it is a longer command than imp.load_source() to 
type, but there is no extra information required or a necessity that you break 
the command up into multiple lines.

Plus imp.load_source() is just plain bad. The reason the imp module is 
deprecated in Python 3.4 is because it does not expose the low-level details of 
import in a way that makes any sense since Python 2.3 (and yes, I meant to 
write 2.3 instead of 3.3; the problem has persisted _that_ long).

That being said, talks are just starting to consider undoing the documented 
deprecation of load_module() such that you can continue to use that as a 
substitute for imp.load_source()/imp.load_module().

I'm going to leave this bug open, hijack its title, and refocus this as to 
consider leaving importlib.abc.Loader.load_module() in importlib as the 
all-powerful fallback API which also simplifies transitioning from imp.

--
assignee:  - brett.cannon
nosy: +ncoghlan
title: bring back importlib.load_source() et al. - Consider leaving 
importlib.abc.Loader.load_module()

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21436
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17756] test_syntax_error fails when run in the installed location

2014-05-05 Thread Martin Pitt

Martin Pitt added the comment:

I can reproduce this here. In that test, I added the following:

with open('/tmp/debug', 'w') as f:
for call in self.stderr.method_calls:
f.write('call: %s\n' % str(call))

 
This gives:
=== 8 
call: call.write('Python MagicMock name=\'sys.version\' 
id=\'140431558254320\' on MagicMock name=\'sys.platform\' 
id=\'140431558262512\'\nType help, copyright, credits or license for 
more information.\n(InteractiveConsole)\n')
call: call.write('Traceback (most recent call last):\n')
call: call.write('  File /usr/lib/python3.4/code.py, line 90, in runcode\n')
call: call.write('')
call: call.write('exec(code, self.locals)')
call: call.write('\n')
call: call.write('  File console, line 1, in module\n')
call: call.write('NameError')
call: call.write(': ')
call: call.write(name 'undefined' is not defined)
call: call.write('\n')
call: call.write('\n')
=== 8 

Observe that the test checks

if 'NameError:' in ''.join(call[1]):

but the NameError and the : are in two different call lines. I don't know 
how self.stderr.method_calls is built, but this sounds like a race 
condition/timing or a stdin/out buffering issue? I. e. the original print that 
produces the NameError: certainly does that in two steps; perhaps the 
testsuite thing that repeatedly read()s on stderr catches these two as separate 
write()s then?

--
nosy: +pitti

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17756
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20383] Add a keyword-only spec argument to types.ModuleType

2014-05-05 Thread Brett Cannon

Brett Cannon added the comment:

My current thinking on this it to introduce in importlib.util:

  def module_from_spec(spec, module=None):
Create/initialize a module based on the provided spec.

If a module is provided then spec.loader.create_module()
will not be consulted.


This serves two purposes. One is that it abstracts the loader.create_module() 
dance out so that's no longer a worry. But more crucially it also means that if 
you have the function create the module for you then it will be returned with 
all of its attributes set without having to worry about forgetting that step. 
The module argument is just for convenience in those instances where you truly 
only want to override the module creation dance for some reason and really just 
want the attribute setting bit.

--
nosy: +aronacher

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20383
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21439] Numerous minor issues in Language Reference

2014-05-05 Thread Zachary Ware

New submission from Zachary Ware:

Reported by Feliks Kluzniak on docs@:


Hello!

I have been reading the Language Reference Manual in order to teach myself 
Python 3.  I noticed several minor errors, and a much larger number of 
linguistic or editorial infelicities.  I have listed them all in the enclosed 
document: I hope it will be useful.

Sincerely,
— Feliks Kluzniak

P.S. My apologies for not having the time to weed out those remarks which might 
already have been entered into the list of „documentation bugs”.


--
assignee: zach.ware
components: Documentation
files: PythonRefmanual_3_4_0_Errata.rtf
keywords: easy
messages: 217926
nosy: zach.ware
priority: normal
severity: normal
stage: test needed
status: open
title: Numerous minor issues in Language Reference
type: enhancement
versions: Python 3.4, Python 3.5
Added file: http://bugs.python.org/file35153/PythonRefmanual_3_4_0_Errata.rtf

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21439
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21439] Numerous minor issues in Language Reference

2014-05-05 Thread Zachary Ware

Changes by Zachary Ware zachary.w...@gmail.com:


--
nosy: +docs@python

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21439
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14019] Unify tests for str.format and string.Formatter

2014-05-05 Thread Eric V. Smith

Eric V. Smith added the comment:

The issue is about tests for str.format and string.Formatter, but in 
http://bugs.python.org/msg194709 and the associated patch there are tests for 
the formatter module to increase its coverage.

I suggested on the mentorship list that we break this into two issues.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14019
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21366] Document that return in finally overwrites prev value

2014-05-05 Thread Zachary Ware

Zachary Ware added the comment:

How's this, or is it too much?

--
keywords: +patch
nosy: +zach.ware
Added file: http://bugs.python.org/file35154/issue21366.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21366
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21366] Document that return in finally overwrites prev value

2014-05-05 Thread Zachary Ware

Changes by Zachary Ware zachary.w...@gmail.com:


--
stage:  - patch review
type: behavior - enhancement
versions: +Python 3.4, Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21366
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21366] Document that return in finally overwrites prev value

2014-05-05 Thread R. David Murray

R. David Murray added the comment:

I would remove the parenthetical (it was so stated in immediately preceding 
paragraph and thus is redundant), and instead of win, I would say will 
always be the last one executed.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21366
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18604] Consolidate gui available checks in test.support

2014-05-05 Thread Zachary Ware

Zachary Ware added the comment:

Thanks Ned.  Unfortunately, I don't have a Mac to test on, so I can't help much 
with figuring out what's going on.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18604
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21435] Segfault with cyclic reference and asyncio.Future

2014-05-05 Thread Tim Golden

Tim Golden added the comment:

I can confirm that this crashes on Windows as well. Failure actually occurs in 
gcmodule.c:finalize_garbage. Adding Guido as it looks as it's tied to asyncio.

--
nosy: +Guido.van.Rossum, tim.golden

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21435
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6839] zipfile can't extract file

2014-05-05 Thread Ethan Furman

Ethan Furman added the comment:

Ah, so when you (Adam) said extraction works fine, what you meant was 
extraction works fine *in other programs*.  Okay.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6839
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6839] zipfile can't extract file

2014-05-05 Thread Adam Polkosnik

Adam Polkosnik added the comment:

Both. Other programs, and in python scripts when raise() is removed in 
zipfile.py. Unless your results are different.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6839
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21393] Python/random.c: close hCryptProv at exit

2014-05-05 Thread Tim Golden

Tim Golden added the comment:

Unfortunately it looks as though this wasn't the correct way to close a Crypto 
handle. It isn't a conventional handle and we be using CryptReleaseContext to 
close it. cf 
http://msdn.microsoft.com/en-us/library/windows/desktop/aa382041%28v=vs.85%29.aspx
 for example.

At present it's giving a mismatched-pointer warning when building on Windows 
(because it's actually a pointer under the covers and not a simple numerical 
HANDLE).

Simple patch attached

--
Added file: 
http://bugs.python.org/file35155/issue21393.cryptreleasecontext.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21393] Python/random.c: close hCryptProv at exit

2014-05-05 Thread Tim Golden

Changes by Tim Golden m...@timgolden.me.uk:


--
status: closed - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21393] Python/random.c: close hCryptProv at exit

2014-05-05 Thread Tim Golden

Changes by Tim Golden m...@timgolden.me.uk:


--
resolution: fixed - 

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21440] Use support.rmtree in test_zipfile

2014-05-05 Thread Tim Golden

New submission from Tim Golden:

At present test_zipfile uses shutil.rmtree to remove its test artefacts. This 
intermittently but frequently fails to remove cleanly on a Windows development 
box. Changing it to use the test.support helper functions should reduce the 
incidence.

--
assignee: tim.golden
components: Tests
messages: 217935
nosy: tim.golden
priority: normal
severity: normal
stage: patch review
status: open
title: Use support.rmtree in test_zipfile
type: behavior
versions: Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21440
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21435] Segfault with cyclic reference and asyncio.Future

2014-05-05 Thread Guido van Rossum

Guido van Rossum added the comment:

Confirmed too (OSX 10.9 again, CPython 3.4 or 3.5; but it doesn't crash with 
CPython 3.3). There is no C code in asyncio, so I'm not sure how asyncio can be 
directly responsible for this crash. Probably some of the GC improvements have 
an edge case that is triggered by the example program. Adding Antoine and 
Victor, they probably understand that code better.

--
nosy: +gvanrossum, haypo, pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21435
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21440] Use support.rmtree in test_zipfile

2014-05-05 Thread Tim Golden

Changes by Tim Golden m...@timgolden.me.uk:


--
keywords: +patch
Added file: http://bugs.python.org/file35156/issue21440.test_zipfile.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21440
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21440] Use support.rmtree in test_zipfile

2014-05-05 Thread Tim Golden

Tim Golden added the comment:

Same goes for test_tarfile (updated patch attached)

--
Added file: http://bugs.python.org/file35157/issue21440.test_tarzipfile.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21440
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21440] Use support.rmtree in test_zipfile

2014-05-05 Thread Tim Golden

Tim Golden added the comment:

Adding Zach as another Windows dev

--
nosy: +zach.ware

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21440
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21441] Buffer Protocol Documentation Error

2014-05-05 Thread Jake Vanderplas

New submission from Jake Vanderplas:

The ``obj`` and ``buf`` structure elements are switched in the documentation of 
the Buffer Protocol.

Compare https://docs.python.org/3.3/c-api/buffer.html#Py_buffer to 
https://github.com/python/cpython/blob/master/Include/object.h#L179-180

--
assignee: docs@python
components: Documentation
files: bufferdoc.patch
keywords: patch
messages: 217939
nosy: Jake.Vanderplas, docs@python
priority: normal
severity: normal
status: open
title: Buffer Protocol Documentation Error
versions: Python 3.3, Python 3.4, Python 3.5
Added file: http://bugs.python.org/file35158/bufferdoc.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21441
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18314] Have os.unlink remove junction points

2014-05-05 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 5c1c14ff1f13 by Tim Golden in branch 'default':
Issue18314 Allow unlink to remove junctions. Includes support for creating 
junctions. Patch by Kim Gräsman
http://hg.python.org/cpython/rev/5c1c14ff1f13

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18314
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18314] Have os.unlink remove junction points

2014-05-05 Thread Zachary Ware

Zachary Ware added the comment:

Just skimming, I noticed something about replacing calloc() with 
PyMem_RawAlloc; note that there is now PyMem_Calloc or PyMem_RawCalloc that you 
should be able to use if you prefer.  See #21233.

--
nosy: +zach.ware

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18314
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21442] Win32 compiler warning in PyBytes_Concat

2014-05-05 Thread Zachary Ware

New submission from Zachary Ware:

Issue #21377 introduced a compiler warning on Windows:

..\Objects\bytesobject.c(2824): warning C4018: '' : signed/unsigned mismatch 
[P:\ath\to\cpython\PCbuild\pythoncore.vcxproj]

--
components: Build, Windows
messages: 217942
nosy: haypo, nikratio, pitrou, zach.ware
priority: normal
severity: normal
stage: needs patch
status: open
title: Win32 compiler warning in PyBytes_Concat
type: behavior
versions: Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21442
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18314] Have os.unlink remove junction points

2014-05-05 Thread Tim Golden

Tim Golden added the comment:

Thanks, Zach. I was aware that calloc was in the air, but I wasn't sure 
if it had been committed and I'd delayed on this enough so I thought I'd 
push for now. We can always revisit.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18314
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21393] Python/random.c: close hCryptProv at exit

2014-05-05 Thread Zachary Ware

Zachary Ware added the comment:

LGTM, Tim.

--
nosy: +zach.ware

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21393
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21440] Use support.rmtree in test_zipfile

2014-05-05 Thread Zachary Ware

Zachary Ware added the comment:

I don't see the intermittent failures (this machine may well just be too slow). 
 The patch looks good and doesn't cause failures, though, so +1 from me.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21440
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21440] Use support.rmtree in test_zipfile

2014-05-05 Thread Tim Golden

Tim Golden added the comment:

Thanks. I get them enough that it stops a test run being particularly 
useful, especially when I've just touched something (eg unlink) which 
might conceivably affect something like tarfile.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21440
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1628987] inspect trouble when source file changes

2014-05-05 Thread Jason R. Coombs

Jason R. Coombs added the comment:

This issue appears implicated in https://bitbucket.org/pypa/setuptools/issue/201

--
nosy: +jason.coombs

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1628987
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18314] Have os.unlink remove junction points

2014-05-05 Thread Roundup Robot

Roundup Robot added the comment:

New changeset e791a36ab6a2 by Tim Golden in branch 'default':
Issue18314 ACKS  NEWS
http://hg.python.org/cpython/rev/e791a36ab6a2

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18314
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18314] Have os.unlink remove junction points

2014-05-05 Thread Tim Golden

Tim Golden added the comment:

Buildbots seem happy. Thanks very much for the patches!

--
resolution:  - fixed
stage: patch review - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18314
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17735] inspect.findsource raises IndexError

2014-05-05 Thread Jason R. Coombs

Jason R. Coombs added the comment:

This issue appears implicated in https://bitbucket.org/pypa/setuptools/issue/201

--
nosy: +jason.coombs

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17735
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1218234] inspect.getsource doesn't update when a module is reloaded

2014-05-05 Thread Jason R. Coombs

Jason R. Coombs added the comment:

This issue appears implicated in https://bitbucket.org/pypa/setuptools/issue/201

--
nosy: +jason.coombs

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1218234
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21443] asyncoio logging documentation clarifications.

2014-05-05 Thread steven Michalske

New submission from steven Michalske:

The asyncio documentation should comment on how to mute and increase some of 
it's logging.

18.5.7.3. Logging
The asyncio module logs information with the logging module in the logger 
'asyncio'.


Adding a bit of text that mentions the following line would be great.

The default verbosity will include messages at logging.INFO level.
To modify the verbosity of asyncio logging add a similar line to your 
application.
`logging.getLogger('asyncio').setLevel(logging.WARNING)`



Note:
While this is clear to active users of the logging module, it is not clear to 
novices, who want INFO in their applications but not from asyncio.

--
assignee: docs@python
components: Documentation
messages: 217952
nosy: docs@python, hardkrash
priority: normal
severity: normal
status: open
title: asyncoio logging documentation clarifications.
type: enhancement
versions: Python 3.4, Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21443
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18314] Have os.unlink remove junction points

2014-05-05 Thread eryksun

eryksun added the comment:

For a junction reparse point, Sysinternals junction.exe shows the Print Name 
and Substitute Name are the same and it's not an NT \?? path (i.e. 
\DosDevices, i.e. \Global??). OTOH, the substitute name does use an NT 
DosDevices path when I use cmd's mklink or os.symlink to create a directory 
symbolic link to an absolute path. 

I modified the patch in a test program to see whether it's really necessary to 
include the DosDevices path in the substitute name. FYI, it seems to work fine 
without it, but it also doesn't seem to hurt to include it.

Sysinternals Junction
http://technet.microsoft.com/en-us/sysinternals/bb896768.aspx

--
nosy: +eryksun

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18314
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21316] mark test_devpoll to be meaningful only for Solaris

2014-05-05 Thread R. David Murray

R. David Murray added the comment:

There's no pressing reason to revisit this, but...I think it would be better to 
say works only on systems that support devpoll (ie: Solaris and derivatives)  
Also, as long as you are changing the try/except, you could use 
skipUnless(hasattr(select, 'devpoll'), ...) instead of an if.

--
nosy: +r.david.murray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21316
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18314] Have os.unlink remove junction points

2014-05-05 Thread Tim Golden

Tim Golden added the comment:

Thanks for the research, eryksun. As long as it doesn't hurt let's leave 
it as is for now.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18314
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21435] Segfault with cyclic reference and asyncio.Future

2014-05-05 Thread Antoine Pitrou

Antoine Pitrou added the comment:

Here is the gdb backtrace. The `gc` variable is equal to NULL.

0x0043d254 in finalize_garbage (collectable=0x7fffdc40, 
old=0x8fdae0 generations+64)
at Modules/gcmodule.c:788
788 if (!_PyGCHead_FINALIZED(gc) 
(gdb) bt
#0  0x0043d254 in finalize_garbage (collectable=0x7fffdc40, 
old=0x8fdae0 generations+64)
at Modules/gcmodule.c:788
#1  0x0043dac0 in collect (generation=2, n_collected=0x7fffdca8, 
n_uncollectable=0x7fffdcb0, nofail=0)
at Modules/gcmodule.c:1009
#2  0x0043dffc in collect_with_callback (generation=2) at 
Modules/gcmodule.c:1128
#3  0x0043eda0 in PyGC_Collect () at Modules/gcmodule.c:1604
#4  0x0041f332 in Py_Finalize () at Python/pythonrun.c:607
#5  0x0043c401 in Py_Main (argc=2, argv=0x980020) at Modules/main.c:788
#6  0x0041af96 in main (argc=2, argv=0x7fffdfc8) at 
./Modules/python.c:69

(gdb) p gc
$1 = (PyGC_Head *) 0x0

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21435
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21444] __len__ can't return big numbers

2014-05-05 Thread Ram Rachum

New submission from Ram Rachum:

I want to use big numbers for length.

 class A:
... __len__ = lambda self: 10 ** 20
 len(A())
Traceback (most recent call last):
  File pyshell#5, line 1, in module
len(A())
OverflowError: cannot fit 'int' into an index-sized integer

--
components: Interpreter Core
messages: 217957
nosy: cool-RR
priority: normal
severity: normal
status: open
title: __len__ can't return big numbers
versions: Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21444
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1218234] inspect.getsource doesn't update when a module is reloaded

2014-05-05 Thread Jean-Paul Calderone

Changes by Jean-Paul Calderone jean-p...@hybridcluster.com:


--
nosy:  -exarkun

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1218234
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11380] Improve reporting of broken stdout pipe during interpreter shutdown

2014-05-05 Thread Christopher Heiny

Changes by Christopher Heiny christopherhe...@gmail.com:


--
nosy: +Christopher.Heiny

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11380
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21444] __len__ can't return big numbers

2014-05-05 Thread R. David Murray

R. David Murray added the comment:

While this is classed as a CPython implementation detail (see issue 15718) it 
doesn't sound like it is likely to be changed (see issue 2723).

--
nosy: +r.david.murray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21444
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21435] Segfault with cyclic reference and asyncio.Future

2014-05-05 Thread Guido van Rossum

Guido van Rossum added the comment:

So should we just add

if (!gc)
break;

at the top of the for-loop body?  That prevents the crash for me.  But why is 
it needed?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21435
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21435] Segfault with cyclic reference and asyncio.Future

2014-05-05 Thread Tim Peters

Tim Peters added the comment:

Guido, that's no good.  The outer loop is traversing a doubly-linked circular 
list, and it should be flatly impossible for gc to ever be NULL - the list 
structure is insanely damaged if any gc_next or gc_prev field reachable from it 
is NULL (gc always comes from a gc_next or gc_prev field)

I'd wonder whether the `collectable` argument passed in was NULL to begin with, 
but Antoine's traceback shows that it's not.

So, like most crashes in gc, we're just seeing the end symptom of something 
that went wrong long before.  Guarding against gc != NULL is just hiding this 
particular symptom.

--
nosy: +tim.peters

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21435
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21435] Segfault with cyclic reference and asyncio.Future

2014-05-05 Thread Tim Peters

Tim Peters added the comment:

Thought question:  suppose finalize_garbage() is called with a collectable list 
all of whose members are in fact going to be destroyed?

I don't see how the loop iteration logic could reliably work then.  For 
concreteness, suppose there's only object - A - in the list.  It's a circular 
list so gc starts as A.  A is finalized, we see it's refcount is 1, `gc = 
gc-gc.gc_prev` sets gc to A again, and A is destroyed by the Py_DECREF.  We go 
back to the top of the loop, and then `gc = gc-gc.gc_next` reads up trash 
(free'd) memory.

Or so it seems to me ;-)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21435
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21435] Segfault with cyclic reference and asyncio.Future

2014-05-05 Thread Tim Peters

Tim Peters added the comment:

Noting that in a Windows debug build, at death gc is 0xdbdbdbdb, so we are in 
reading up free'd memory (0xdb is pymalloc's dead byte marker).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21435
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21435] Segfault with cyclic reference and asyncio.Future

2014-05-05 Thread Tim Peters

Tim Peters added the comment:

Also noting that the loop looks funny because it appears never to process the 
first element in the input list (unless the input list contains only one 
element).  That is, the loop starts by processing the second element in the 
list, and exits as soon as gc makes it back to the first element in the list.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21435
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21435] Segfault with cyclic reference and asyncio.Future

2014-05-05 Thread Tim Peters

Tim Peters added the comment:

Ah, fudge - I think I forgot that these circular lists also have dummy heads, 
in which case it's A Good Thing the first element is skipped, and  it should 
be impossible for one to become physically empty (the dummy header should 
always survive intact).  Never mind ;-)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21435
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17797] Visual C++ 11.0 reports fileno(stdin) == 0 for non-console program

2014-05-05 Thread Luke Dunstan

Changes by Luke Dunstan lukedunsta...@gmail.com:


--
nosy: +Luke.Dunstan
versions: +Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17797
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1234674] filecmp.cmp's shallow option

2014-05-05 Thread Steven Barker

Steven Barker added the comment:

Here's a patch against the default branch that fixes filecmp.cmp's behavior 
when shallow is True, including an update to the module's docs (correcting 
the previous ambiguity discussed in the 2011 python-dev thread mentioned by 
Sandro Tosi) and a couple of new tests of files where shallow comparisons 
should be expected get the answer wrong.

The changed behavior is very simple. The lines from Lib/filecmp.py in the 
original code:

if shallow and s1 == s2:
return True

are changed to:

if shallow:
return s1 == s2

This presumes answers to the questions asked by Georg Brandl back in 2005 of 
No, shallow comparisons never read the file contents and No, non-shallow 
comparisons don't care about mtimes (except for avoiding out of date cache 
entries).

If we only applied the test changes (not the behavior change) from my patch, 
one of the new tests would fail, as the current filecmp.cmp code never gives 
false negatives on comparisons in shallow mode (only false positives).

We probably don't want to commit the patch exactly as it stands, because the 
changed behavior causes several of the previously existing tests to fail. 
Almost all the dircmp tests fail for me, and the test_matching filecmp.cmp 
test does so intermittently (due to my system sometimes being fast enough at 
creating the files to beat my filesystem's mtime resolution).

The test failures are all because of shallow comparisons between files with the 
same contents, but (slightly) different mtimes. The new shallow comparison 
behavior is to say those files are unequal while the old code would fall back 
on testing the file contents despite the shallow parameter, and so it would 
return True. The failing tests can probably be updated to either explicitly set 
the file mtimes with sys.utime (as I do with the files used in the new tests), 
or we could rewrite some of the setup code to use something like shutil.copy2 
to make copies of files while preserving their mtimes.

I'm not very familiar with the best practices when it comes to writing unit 
tests, so I pretty much copied the style of the existing tests in 
Lib/test/test_filecmp.py (though I've split mine up a bit more).

I understand from reading other filecmp bug reports that that test style is 
considered to be pretty poor, so there's probably room to improve my code as 
well. I thought I'd post this patch before making an effort at fixing the older 
tests, in order to get some feedback. I'll be happy to incorporate any 
suggested improvements!

This issue has been open for almost 9 years. Hopefully my patch can help get it 
moving again towards being fixed!

--
keywords: +patch
versions: +Python 3.5
Added file: http://bugs.python.org/file35159/filecmp_real_shallow.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1234674
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18314] Have os.unlink remove junction points

2014-05-05 Thread Kim Gräsman

Kim Gräsman added the comment:

Thanks for helping me land this!

eryksun: interesting, thanks! I seem to remember having problems without the 
\??\ prefix, but it could have been something else causing it (filling the 
buffer to DeviceIoControl's satisfaction was... challenging.)

I have some ideas for small improvements, and I could try to fold the removal 
of \??\ into that. Do I just open a new enhancement issue?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18314
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20752] Difflib should provide the option of overriding the SequenceMatcher

2014-05-05 Thread Chris Rose

Chris Rose added the comment:

Ping? I'd like to know if the proposed solution passes muster, so that I can 
get this into ... well, whatever the right revision would be.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20752
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21435] Segfault with cyclic reference and asyncio.Future

2014-05-05 Thread Tim Peters

Tim Peters added the comment:

Sorry for the earlier noise.  I'm fighting a flu and my head is mush :-(

Anyway, this doesn't look obvious.  We get to this point:

if (Py_REFCNT(op) == 1) {
/* op will be destroyed */
gc = gc-gc.gc_prev;
}

and op is the type object for class B.  gc gets set to the previous object, a 
list.  Everything looks fine at this point.  But when we get back from:

Py_DECREF(op);

the list's gc.gc_next field has been overwritten with NULL.  That's why gc gets 
set to NULL on the next trip through the loop.

I spaced out stepping through all the type deallocation code, and didn't find 
exactly when the list's gc_next is overwritten.  The list's gc_prev is still 
fine.  Perhaps some code called _PyObject_GC_UNTRACK on the list object (which 
NULLs out the gc_next pointer but not the gc_prev pointer).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21435
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1218234] inspect.getsource doesn't update when a module is reloaded

2014-05-05 Thread Berker Peksag

Changes by Berker Peksag berker.pek...@gmail.com:


--
nosy: +yselivanov
versions: +Python 3.5 -Python 3.2, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1218234
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com