[issue23566] RFE: faulthandler.register() should support file descriptors

Wei Wu added the comment: I attached a patch that implements the solution described above. -- Added file: http://bugs.python.org/file38480/issue23566_fd_tests.patch ___ Python tracker __

[issue23187] Segmentation fault, possibly asyncio related

Guido van Rossum added the comment: So what do you make of this? PyObject_GC_Malloc(unsigned __int64 basicsize=4046951880) That's nearly 4 GB. I somehow doubt your app is actually trying to allocate that much memory -- maybe the type object a few lines below in the stack is overwritten, or mayb

[issue23661] Setting a exception side_effect on a mock from create_autospec does not work

Ignacio Rossi added the comment: The problem only affects autospecced functions. Apparently, the problem lies here (all code excerpts from Lib/unittest/mock.py): - When autospeccing functions, the Mock._mock_delegate field is populated at the end of _setup_func (and its the only place I found

[issue23529] Limit decompressed data when reading from LZMAFile and BZ2File

Nikolaus Rath added the comment: On Mar 06 2015, Martin Panter wrote: > Still to do: Need to find a better home for the _DecompressReader and > _BaseStream classes. Currently it lives in “lzma”, but apparently it > is possible for any of the gzip, bz2, lzma modules to not be > importable, so it

[issue23187] Segmentation fault, possibly asyncio related

Michael Goldish added the comment: I caught another crash just now, this time in update_refs(). A stack trace is attached below. I still think this is the same issue. static void update_refs(PyGC_Head *containers) { PyGC_Head *gc = containers->gc.gc_next; 67382D60 mov rdx,q

[issue23246] distutils fails to locate vcvarsall with Visual C++ Compiler for Python

Jason R. Coombs added the comment: The setuptools code is licensed under the ZPL and PSF licenses. If either of those licenses are insufficient, I'm happy to release my contribution in that file to the public domain. -- ___ Python tracker

[issue12641] Remove -mno-cygwin from distutils

Ned Deily added the comment: Michael, this issue is closed and the changes have long since been released. Comments here will likely be ignored. Please open a new issue describing the problem you are seeing and under what environment, with exact steps to reproduce it. -- nosy: +ned.d

[issue23187] Segmentation fault, possibly asyncio related

Michael Goldish added the comment: I don't see a reason to assume the machine was running out of memory. After each crash the process was kept alive by one of those Windows crash dialogs - "the process terminated unexpectedly" or similar. I could see exactly how much memory was occupied by the

[issue23624] str.center inconsistent with format "^"

Changes by Raymond Hettinger : -- assignee: -> rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue23187] Segmentation fault, possibly asyncio related

Guido van Rossum added the comment: Are we all in agreement that it's probably somehow running out of memory? -- ___ Python tracker ___ __

[issue23661] Setting a exception side_effect on a mock from create_autospec does not work

New submission from Ignacio Rossi: The following fails on python 3.4.2, 3.4.3 and 3.5.0a2 (downloaded from python.org and compiled on Ubuntu 14.04). The same happens when using mock.patch with autospec=True. >>> from unittest.mock import create_autospec >>> def function(): ... pass ... >>

[issue23556] Scope for raise without argument is different in Python 2 and 3

Changes by Ethan Furman : -- nosy: +ethan.furman ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue23639] Not documented special names

Terry J. Reedy added the comment: Idlelib.rpc uses the somewhat arbitrary *strings* '__methods__' and '__attributes__' as private signals in its protocol. They are not object or attribute names, special or otherwise, in the sense used here. The use of '__methods__' in idlelib.rpc (line 176) h

[issue12641] Remove -mno-cygwin from distutils

Michael Clerx added the comment: I'm seeing this bug in 2.7.9. The reason seems to be that the version detection doesn't work... This snippet: out = os.popen(gcc_exe + ' -dumpversion', 'r') out_string = out.read() returns an empty out_string, causing gcc_version = None < '4' Maybe the <

[issue23187] Segmentation fault, possibly asyncio related

Michael Goldish added the comment: > Why do you consider that it's the same issue? Because it's a very similar stack trace, the crash itself is in subtype_dealloc(), it happens once every few days, asyncio is involved, and the issue is relatively new - I couldn't find another bug report with a

[issue9679] unicode DNS names in urllib, urlopen

Changes by Berker Peksag : -- nosy: +berker.peksag versions: +Python 3.5 -Python 3.3, Python 3.4 ___ Python tracker ___ ___ Python-bugs

[issue9679] unicode DNS names in urllib, urlopen

Demian Brecht added the comment: Here's a simple patch that adds functionality matching that in http.client to urllib.request. As pointed out by John, I see no reason why urllib and http.client shouldn't have consistent handling if IDNs independent of IRIs (although IRI encoding would be a nic

[issue9679] unicode DNS names in urllib, urlopen

Changes by Demian Brecht : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue23614] Opaque error message on UTF-8 decoding to surrogates

Ezio Melotti added the comment: > Nice document. Is that actually how Python's decoder checks things? Yes, Python follows the Unicode standard. > * E0 followed by 80..9F: "non-shortest form" > * ED followed by A0..BF: "surrogate" > * F4 followed by 90..BF: "outside defined range" If you get a

[issue23042] Python 2.7.9 ctypes module doesn't build on FreeBSD x86

Danya Alexeyevsky added the comment: Faced the same problem on FreeBSD. I confirm: applying the reversed patch fixed it. Thanks! -- nosy: +Danya.Alexeyevsky ___ Python tracker

[issue23614] Opaque error message on UTF-8 decoding to surrogates

Chris Angelico added the comment: Nice document. Is that actually how Python's decoder checks things? Does the decoder have different definitions of "valid continuation byte" based on the lead byte? If that's the case... well, ten out of ten for complying with the spec, to be sure, but unfortu

[issue23643] Segmentation Fault with Large Simple Function

Ned Deily added the comment: (Closed by submitter.) -- nosy: +ned.deily resolution: -> duplicate stage: -> resolved superseder: -> stack overflow evaluating eval("()" * 3) ___ Python tracker

[issue23655] Memory corruption using pickle over pipe to subprocess

John Nagle added the comment: "minimize you data" - that's a big job here. Where are the tests for "pickle"? Is there one that talks to a subprocess over a pipe? Maybe I can adapt that. -- ___ Python tracker

[issue23658] multiprocessing: string arg to SystemExit

Davin Potts added the comment: Are you looking at the current code in the 2.7 branch or just at the code committed in https://hg.python.org/cpython/rev/da5b370f41a1 (done as part of issue13854)? The code in 2.7 has since been updated and appears to use an exitcode of 1 whenever a str is provi

[issue2211] Cookie.Morsel interface needs update

Changes by Demian Brecht : Added file: http://bugs.python.org/file38476/issue2211_4.patch ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue23655] Memory corruption using pickle over pipe to subprocess

Serhiy Storchaka added the comment: Could you please try to minimize you data and try to reproduce an issue without using third-party modules if this is possible? -- ___ Python tracker

[issue21518] Expose RegUnLoadKey in winreg

Martin v. Löwis added the comment: The naming of the function needs discussion. I think it should be UnLoadKey, as the API function behind it is RegUnLoadKey (not RegUnloadKey). It may be illogical(*) that the function is called that way in the API, but it would add confusion if Python called

[issue23637] Warnings error with non-ascii chars.

Serhiy Storchaka added the comment: Here is a patch that tries to coerce non-ascii filename and line to unicode using appropriate encoding if it is needed and possible. If it is not possible, the warning just gets lost, as in the case of IO error. -- keywords: +patch stage: -> patch r

[issue2052] Allow changing difflib._file_template character encoding.

Berker Peksag added the comment: Here is an updated patch. Thanks for the review, Serhiy. I will open a new issue for the HTML 5 part of the patch. -- Added file: http://bugs.python.org/file38474/issue2052_v2.diff ___ Python tracker

[issue23655] Memory corruption using pickle over pipe to subprocess

John Nagle added the comment: > Or just use pickle._Pickler instead of pickle.Pickler and like > (implementation detail!). Tried that. Changed my own code as follows: 25a26 > 71,72c72,73 < self.reader = pickle.Unpickler(self.proc.stdout)# set up reader < self.writer = pic

[issue23645] Incorrect doc for __getslice__

Roundup Robot added the comment: New changeset 3b91d834160f by Benjamin Peterson in branch '2.7': the default is sys.maxsize not sys.maxint (closes #23645) https://hg.python.org/cpython/rev/3b91d834160f -- nosy: +python-dev resolution: -> fixed stage: patch review -> resolved status: op

[issue23637] Warnings error with non-ascii chars.

Serhiy Storchaka added the comment: The problem is not only with the file.write(). If one of arguments is unicode (even if it doesn't contain non-ascii characters) and other argument is non-ascii string, we get this error. >>> warnings.showwarning(u'', DeprecationWarning, 'filè.py', 10) Traceb

[issue23645] Incorrect doc for __getslice__

Changes by Ezio Melotti : -- stage: -> patch review type: -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue23637] Warnings error with non-ascii chars.

Ezio Melotti added the comment: I think that the problem is actually with the file.write() in _show_warning(). If any of the arguments of formatwarning() are unicode, the result will be unicode, and if "file" (default sys.stderr) is opened in binary mode, Python will try to encode the unicode r

[issue23654] infinite loop in faulthandler._stack_overflow

Matt Frank added the comment: Yes, this is currently only a problem with the Intel compiler. The writes to buffer[] are dead (provably won't be ever used) at the point that the recursive call occurs. Actually gcc and llvm can figure this out. Thus all the space allocated for the first call c

[issue23566] RFE: faulthandler.register() should support file descriptors

Wei Wu added the comment: The last approach I proposed requires some change in "template code" of check_xxx methods. To make it better, we can add a bool parameter to the check_xxx functions, True value indicating a fd test. If a filename is given at the same time, then a fd can get from that

[issue23622] Deprecate unrecognized backslash+letter escapes in re

Changes by Serhiy Storchaka : -- title: Deprecate unrecognized backslash+letter escapes -> Deprecate unrecognized backslash+letter escapes in re ___ Python tracker ___ _

[issue23623] Python 3.5 docs need to clarify how to set PATH, etc

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue23614] Opaque error message on UTF-8 decoding to surrogates

Ezio Melotti added the comment: The Table 3-7 of http://www.unicode.org/versions/Unicode5.2.0/ch03.pdf (page 93 of the book, or 40 of the pdf) shows that if the start byte is ED the continuation byte must be in range 80..9F. This means that, in order to decode a sequence starting with ED, you

[issue23622] Deprecate unrecognized backslash+letter escapes

Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue23642] Interaction of ModuleSpec and C Extension Modules

Brett Cannon added the comment: The PEP is now live: https://www.python.org/dev/peps/pep-0489/ . If you want to participate in the discussion it will probably happen on the import-sig. -- ___ Python tracker __

[issue23628] See if os.scandir() could help speed up importlib

Brett Cannon added the comment: The answer is no. -- resolution: -> rejected status: open -> closed ___ Python tracker ___ ___ Python

[issue23658] multiprocessing: string arg to SystemExit

Changes by Serhiy Storchaka : -- nosy: +sbt ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue23539] Content-length not set for HTTP methods expecting body when body is None

James Rutherford added the comment: Ok I'll have a go at a consolidated python3 patch tomorrow. -- ___ Python tracker ___ ___ Python-b

[issue16318] FTP_TLS in ftplib not supporting prot_p storlines in FTP7.5

Nathan Cox added the comment: I have this issue intermittently with a server that I connect to, but the issue (at least for me) seems to be the minBytesPerSecond configuration triggering a remote disconnect of the connection. -- nosy: +Nathan Cox __

[issue23657] Don't do isinstance checks in zipapp

Paul Moore added the comment: Looks good. Would it be worth adding tests for providing pathlib.Path objects, or is that overkill? -- ___ Python tracker ___ _

[issue23660] Turtle left/right inverted when using different coordinates orientation

New submission from Andre Roberge: The turtle module using screen coordinates such that the vertical coordinate increases vertically on the screen. This orientation is different from the traditional orientation for graphics programs. It is possible to set coordinates with the "normal" orientat

[issue23659] csv.register_dialect doc string

Changes by Skip Montanaro : -- nosy: +skip.montanaro ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue23659] csv.register_dialect doc string

R. David Murray added the comment: Could you clarify what bug in python you are reporting? -- nosy: +r.david.murray ___ Python tracker ___ ___

[issue23659] csv.register_dialect doc string

New submission from Vladimir Ulupov: I use PyCharm. This IDE checks the signature functions. When I used the extra arguments to the function register_dialect - IDE reported error. This is what has generated IDE for this function. http://dumpz.org/1347592/ Apparently error here https://hg.pytho

[issue23658] multiprocessing: string arg to SystemExit

New submission from Dan Nawrocki: It seems that the fix for 13854 (http://bugs.python.org/issue13854) actually tried to solve 2 issues: 1. handle non-integer, non-string arg to SystemExit 2. use exit code of 0 when the arg was a string The change involved for #2 seems to go against the documen

[issue23643] Segmentation Fault with Large Simple Function

Changes by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue23657] Don't do isinstance checks in zipapp

Brett Cannon added the comment: Here is a proposed patch that does what I was thinking. What do you think? As for updating zipfile, it's possible but slightly risky because of backwards-compatibility. Since this is all-new code there is no worry about breaking someone's pre-existing code becau

[issue23491] PEP 441 - Improving Python Zip Application Support

Paul Moore added the comment: Thanks Brett! Apologies about the TESTFN issue - I changed it (from TemporaryDirectory, in fact) based on one of the review comments - it looks like I didn't test the change properly. My mistake, thanks for catching it. --

[issue23657] Don't do isinstance checks in zipapp

Paul Moore added the comment: That sounds reasonable. I'll have a look at this. The code was originally based on a similar pattern in the zipfile module, so maybe zipfile should be changed in the same way? -- ___ Python tracker

[issue23657] Don't do isinstance checks in zipapp

New submission from Brett Cannon: As it stand, zipapp's code checks for str and then otherwise assumes an object is a file-like object. It might work out better to do some duck typing and simply check if an object has 'read' and 'readline' attributes then it's a file-like object and otherwise

[issue23491] PEP 441 - Improving Python Zip Application Support

Brett Cannon added the comment: Thanks for the patch, Paul! I touched up the formatting to be more PEP 8 compliant and fixed the tests as they initially failed for me (TESTFN didn't exist prior to you trying to make a directory, so it just failed; switched to tempfile.TemporaryDirectory instea

[issue23491] PEP 441 - Improving Python Zip Application Support

Roundup Robot added the comment: New changeset d1e9f337fea1 by Brett Cannon in branch 'default': Issue #23491: Implement PEP 441: Improving Python Zip Application Support https://hg.python.org/cpython/rev/d1e9f337fea1 -- nosy: +python-dev ___ Python t

[issue23605] Use the new os.scandir() function in os.walk()

STINNER Victor added the comment: >> Are you testing the top-bottom or bottom-up? > My benchmark.py calls os.walk() with topdown=True, which is the default. Is it worth to mention in the os.walk() doc that topdown=False can be faster? -- ___ Python t

[issue23605] Use the new os.scandir() function in os.walk()

Ben Hoyt added the comment: > I don't understand your benchmark. Do you mean that os.walk() is slower > with fast_bottom-up.patch because islink() is called or because I replaced > "for entry in scandir(top):" with "entry = next(scandir_it)"? No, sorry, I was making two separate comments: 1) the

[issue23539] Content-length not set for HTTP methods expecting body when body is None

R. David Murray added the comment: It would...I've started twice to do the commit and gotten interrupted both times. Having a patch I can just apply would help. If you would be willing to also generate a patch for python3, that would be a help as well. -- ___

[issue23605] Use the new os.scandir() function in os.walk()

Serhiy Storchaka added the comment: You fast_bottom-up looks awesome, but much more correct. This is what I meant when warned that correct implementations with scandir() will be complex. Could you please add a test based on my example (i.e. converting symlinks to a directory during walking) an

[issue23605] Use the new os.scandir() function in os.walk()

STINNER Victor added the comment: I don't understand your benchmark. Do you mean that os.walk() is slower with fast_bottom-up.patch because islink() is called or because I replaced "for entry in scandir(top):" with "entry = next(scandir_it)"? Are you testing the top-bottom or bottom-up? Here

[issue23138] cookiejar parses cookie value as int with empty name-value pair and Expires

Serhiy Storchaka added the comment: Oh, this was incorrect example. The correct one is: $ ./python -m timeit -s "from http.cookiejar import parse_ns_headers" -- "parse_ns_headers(['foo=bar; path=/; version=1; Expires=Thu, 01 Jan 1970 00:00:10 GMT'])" Before: 1 loops, best of 3: 177 usec pe

[issue13290] get vars for object with __slots__

Changes by Serhiy Storchaka : -- Removed message: http://bugs.python.org/msg238021 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue13290] get vars for object with __slots__

Serhiy Storchaka added the comment: Oh, this was incorrect example. The correct one is: $ ./python -m timeit -s "from http.cookiejar import parse_ns_headers" -- "parse_ns_headers(['foo=bar; path=/; version=1; Expires=Thu, 01 Jan 1970 00:00:10 GMT'])" Before: 1 loops, best of 3: 177 usec pe

[issue23654] infinite loop in faulthandler._stack_overflow

STINNER Victor added the comment: > When the faulthandler module is compiled at -O3 (the default for non-debug > builds) with a compiler that does tailcall optimization ... test_faulthandler pass with GCC 4.9.2 (Fedora 21) when faulthandler.c is compiled in -O3 mode. I guess that such config d

[issue23566] RFE: faulthandler.register() should support file descriptors

Changes by Christoph Sieghart : -- nosy: -sigi ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue9679] unicode DNS names in urllib, urlopen

Changes by Demian Brecht : -- nosy: +demian.brecht ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue23566] RFE: faulthandler.register() should support file descriptors

STINNER Victor added the comment: I commited a fix to repair Windows buildbots. > Or we could reuse the file created by filename in subprocess? I tried to pass a file descriptor from the parent to the child process, but this option is complex. It's possible to pass a handle with close_fds=False

[issue23566] RFE: faulthandler.register() should support file descriptors

Roundup Robot added the comment: New changeset 211e29335e72 by Victor Stinner in branch 'default': Issue #23566: Skip "fd" tests of test_faulthandler on Windows https://hg.python.org/cpython/rev/211e29335e72 -- ___ Python tracker

[issue23539] Content-length not set for HTTP methods expecting body when body is None

James Rutherford added the comment: Hi all, apologies for the spam, but I just wanted to confirm that no-one is waiting on anything from me... I'm happy to consolidate the final minor points & make the patch against python3 if that would simplify things. -- ___

[issue17797] Visual C++ 11.0 reports fileno(stdin) == 0 for non-console program

Jean-Charles Lefebvre added the comment: Well, just in case, I've attached the patch to apply against 3.5.0a2. -- Added file: http://bugs.python.org/file38469/python-3.5.0a2-fdvalidation.patch ___ Python tracker __

[issue23645] Incorrect doc for __getslice__

Gaëtan de Menten added the comment: Thanks for creating the patch! PS: I know it is deprecated. But I am stuck on Python2 for that project and my class inherits from numpy ndarray, so I do not have a choice... -- ___ Python tracker

[issue23645] Incorrect doc for __getslice__

Alex Shkop added the comment: This is true. In ceval.c default value for end index is PY_SSIZE_T_MAX. Whereas in sysmodule.c defined: SET_SYS_FROM_STRING("maxsize", PyInt_FromSsize_t(PY_SSIZE_T_MAX)); SET_SYS_FROM_STRING("maxint", PyInt_FromLong(PyInt_Get

[issue23656] shutil.copyfile (or built-in open) releases sqlite3's transaction lock

New submission from Hiroaki Miyajima: When copying sqlite3's database file by shutil.copyfile while holding its transaction lock, its lock is released unexpectedly. Attached is a sample program showing this. Inside, process-1 and process-2 just do following steps respectively: (1) open a sql

[issue23655] Memory corruption using pickle over pipe to subprocess

Serhiy Storchaka added the comment: sys.modules['_pickle'] del sys.modules['pickle'] # if exists import pickle Or just use pickle._Pickler instead of pickle.Pickler and like (implementation detail!). -- nosy: +alexandre.vassalotti, pitrou, serhiy.storchaka stage: -> test needed type:

[issue23639] Not documented special names

Changes by Ian Lee : -- nosy: +IanLee1521 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.o

[issue23138] cookiejar parses cookie value as int with empty name-value pair and Expires

Serhiy Storchaka added the comment: As side effect the parsing is now twice faster. $ ./python -m timeit -s "from http.cookiejar import parse_ns_headers" -- "parse_ns_headers('foo=bar; Expires=Thu, 01 Jan 1970 00:00:10 GMT')" Before: 1000 loops, best of 3: 976 usec per loop After: 1000 loops,

[issue23138] cookiejar parses cookie value as int with empty name-value pair and Expires

Roundup Robot added the comment: New changeset 44c1c0cbdc06 by Serhiy Storchaka in branch '2.7': Issue #23138: Fixed parsing cookies with absent keys or values in cookiejar. https://hg.python.org/cpython/rev/44c1c0cbdc06 New changeset c1abcbcfefab by Serhiy Storchaka in branch '3.4': Issue #2313