R. David Murray added the comment:
Here is a version that keeps things clean by not diplaying the traceback. The
ctl-c does have an effect, but not a visible one unless one pays careful
attention :)
--
Added file: http://bugs.python.org/file38731/catch_additional_interrupt.patch
Robert Collins added the comment:
Implementation wise: this is not part of the generic rendering-of-tracebacks;
I'd like to make the traceback new stuff be tastefully extensible - I'd be
inclined to do this with a per-frame-callback on render (so we don't pay
overhead on unrendered tb's) and
Roundup Robot added the comment:
New changeset f6b41566ca28 by Victor Stinner in branch 'default':
Issue #22117: Add _PyTime_ROUND_CEILING rounding method for timestamps
https://hg.python.org/cpython/rev/f6b41566ca28
New changeset 0a8015a4ff97 by Victor Stinner in branch 'default':
Issue
R. David Murray added the comment:
The issue arose from the duplicated parameter name. I fixed it by (mostly)
copying the error recovery used by the older api (get_param).
Note that you don't need to specify both policy and _class. If you use the new
policies (such as default), it
Raymond Hettinger added the comment:
Also incorporate __mul__ and __imul__.
d = deque('abc')
d * 3
deque(['a', 'b', 'c', 'a', 'b', 'c', 'a', 'b', 'c'])
d *= 2
d
deque(['a', 'b', 'c', 'a', 'b', 'c'])
--
keywords: +needs review -patch
title: Support __add__
STINNER Victor added the comment:
I rewrite the implementation of this issue 2 or 3 times. At the end, I decided
to rewrite it again with a more incremental approach: add the new API, use the
new API, and then drop slowly the old API.
I was used to rewrite the implementation multiple times to
STINNER Victor added the comment:
Why do you want to optimize the pure Python FileIO?
I gave more examples than FileIO in this issue.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23754
Roundup Robot added the comment:
New changeset bc2a22eaa0af by Victor Stinner in branch 'default':
Issue #23752: When built from an existing file descriptor, io.FileIO() now only
https://hg.python.org/cpython/rev/bc2a22eaa0af
--
nosy: +python-dev
___
Changes by STINNER Victor victor.stin...@gmail.com:
--
title: PEP 475: handle EINTR in the socket module - PEP 475: handle EINTR in
the socket module (connect)
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23618
STINNER Victor added the comment:
Ok, here is a first patch just for select.select().
It took me some time to write this small patch, because I wanted first to push
my new API to handle time in pytime.h (Issue #22117). The new time C API has
been merged.
--
keywords: +patch
Added
Roundup Robot added the comment:
New changeset 2e1234208bab by Victor Stinner in branch 'default':
Issue #23694: Fix usage of _Py_open() in the _posixsubprocess module
https://hg.python.org/cpython/rev/2e1234208bab
--
___
Python tracker
Roundup Robot added the comment:
New changeset 6ef2cacec2e9 by Victor Stinner in branch '2.7':
Issue #22390: Fix test_gzip if unicode filename doesn't work
https://hg.python.org/cpython/rev/6ef2cacec2e9
--
___
Python tracker rep...@bugs.python.org
New submission from Nick Coghlan:
A colleague just ran into the issue where they created a json.py module in
their local directory and broke a previously working program. I picked up on
the mistake when I saw the following traceback snippet:
Traceback (most recent call last):
File
STINNER Victor added the comment:
Ok, I'm quite API with the new API and I have what I need to rework the select
module for the PEP 475, so I close this issue.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
The second (exception == NULL) check in _Py_PrintFatalError() looks suspicious.
When it is possible? And if it is possible, can it cause leaks?
--
___
Python tracker rep...@bugs.python.org
Changes by Berker Peksag berker.pek...@gmail.com:
--
components: -Tests
nosy: +berker.peksag
versions: +Python 3.4, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19023
___
Roundup Robot added the comment:
New changeset d938533b43f7 by Victor Stinner in branch 'default':
Issue #22117: Fix usage of _PyTime_AsTimeval()
https://hg.python.org/cpython/rev/d938533b43f7
New changeset 49d3ff81f31f by Victor Stinner in branch 'default':
Issue #22117: Add assertions to
Martin Panter added the comment:
I think your patch should be fine for all practical cases I can think of.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23792
___
Changes by STINNER Victor victor.stin...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23752
___
Nick Coghlan added the comment:
I had an idea for a possible importlib.util API to support this capability: an
ignore_entries=0 default arg to
https://docs.python.org/dev/library/importlib.html#importlib.util.find_spec
The new arg would say how many found entries to skip when looking for the
Ethan Furman added the comment:
Patch looks good.
Changing the raised exceptions to ValueError would require deprecation periods.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23466
___
STINNER Victor added the comment:
Changing the raised exceptions to ValueError would require deprecation
periods.
bytes%args is not a new feature of python 3.5? It sounds strange to
deprecate a part of a new feature.
--
___
Python tracker
Martin Panter added the comment:
I think I have often passed delete=False because of the documented deficiency
with Windows (see Issue 14243). Depending on the outcome of that issue,
allowing for deletion after close() might be useful too.
BTW, monkey-patching __del__() probably won’t work if
Serhiy Storchaka added the comment:
May be rename _PyTime_AsTimeval_impl() to _PyTime_AsTimeval_noraise() and check
a result to raise an exception in _PyTime_AsTimeval()?
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag, ghaering
stage: - patch review
versions: +Python 3.4, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23758
Robert Collins added the comment:
Why limit this to just stdlib shadowing?
A local module can shadow a top level module-or-package across the board. If we
don't limit it to stdlib names, it becomes a lot easier to implement.
--
___
Python tracker
STINNER Victor added the comment:
That last commit fixed compatibility with Django.
Good.
Instead of an assert(), you could use Py_FatalError() at the end of
_Py_CheckFunctionResult().
_Py_CheckFunctionResult() now calls Py_FatalError() in debug mode. By the way,
I fixed various issues
New submission from Arfrever Frehtes Taifersar Arahesis:
https://hg.python.org/cpython/rev/2a336cc29282 changed stacklevel of some
deprecation warnings.
However new value is still not useful, because either _frozen_importlib or
importlib/_bootstrap.py is now mentioned in deprecation warnings:
Changes by Ned Deily n...@acm.org:
--
nosy: +alex, christian.heimes, dstufft
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23804
___
___
STINNER Victor added the comment:
On Windows, test_idle modifies os.environ: TCL_xxx and TIX_xxx (sorry
for xxx, I don't remember the full variable name) are added. And
test_platform modifies os.environ['PATH'].
--
___
Python tracker
Ethan Furman added the comment:
Okay, in a perfect world that _enum_to_int function would be unnecessary, but
as Serhiy pointed out the C code is doing pointer comparison, so unless the
exact same int is passed in it does not work.
I'm looking at adjusting the C code.
--
Roundup Robot added the comment:
New changeset dc10c52c6539 by R David Murray in branch '3.4':
#23745: handle duplicate MIME parameter names in new parser.
https://hg.python.org/cpython/rev/dc10c52c6539
New changeset fe9a578d5f38 by R David Murray in branch 'default':
Merge: #23745: handle
Martin Panter added the comment:
Reopening because I think there are some review comments that need addressing,
at least the fromstring() one. I’m happy to make a patch if necessary.
--
status: closed - open
___
Python tracker rep...@bugs.python.org
New submission from Daniel Shahaf:
In the 'copy' module documentation, it wasn't fully clear to me how
__deepcopy__ implementations should treat the memo dict argument. The attached
patch clarifies that __deepcopy__ implementations should treat the memo dict
argument as an opaque type.
Serhiy Storchaka added the comment:
The test_urandom_fd_non_inheritable is constantly failed on AMD64 OpenIndiana
2.7 buildbot.
http://buildbot.python.org/all/builders/AMD64%20OpenIndiana%202.7/builds/2727/steps/test/logs/stdio
Changes by Serhiy Storchaka storch...@gmail.com:
--
keywords: +easy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23796
___
___
Python-bugs-list
Barry Alan Scott added the comment:
I should point out using Python2.7 with wxPython I do not see this issue.
This issue was exposed during my efforts to port pysvn from py2.7+wxPython to
py3.4+wxpython-phoenix.
I do setup locale on the main thread very early before starting the background
New submission from R. David Murray:
no_proxy (and what notation it supports) is mentioned in the python2 urllib
docs, but not in the python3 docs.
--
assignee: docs@python
components: Documentation
messages: 239493
nosy: docs@python, r.david.murray
priority: normal
severity: normal
R. David Murray added the comment:
Well, you'll need to look in your build log to see why _hashlib failed to
compile or failed to be usable.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23805
Benjamin Peterson added the comment:
lgtm
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23803
___
___
Python-bugs-list mailing list
New submission from Thana Annis:
Added a test to ensure that --locale cannot be called without --encoding. This
is targeting lines 654-656 of calendar.py.
--
components: Tests
files: test_calendar.patch
keywords: patch
messages: 239494
nosy: Bwaffles
priority: normal
severity: normal
Tuomas Suutari added the comment:
Thanks for the comments again!
I fixed the format(F(4, 27), '.1f') - 0.2 issue
Serhiy Storchaka reported. Fix for that was as simple as adding one to the
precision the decimals are calculated in, but while adding test cases for that
I realized two new things:
Roundup Robot added the comment:
New changeset c23713af8be7 by Serhiy Storchaka in branch '3.4':
Issue #23803: Fixed str.partition() and str.rpartition() when a separator
https://hg.python.org/cpython/rev/c23713af8be7
New changeset c48637f57e2b by Serhiy Storchaka in branch 'default':
Added
STINNER Victor added the comment:
This build was only triggered by one changeset 0b99d7043a99: Issue #23694:
Enhance _Py_open(), it now raises exceptions.
I was reproduce to issue on a buildbot and I got access to the buildbot. Using
gdb, I saw that a process was stuck in
Nick Coghlan added the comment:
On the implementation front, +1 for looking at a per-frame callback API rather
than hardcoding this directly into the existing traceback rendering code.
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan added the comment:
I proposed limiting it to stdlib names as that's the case where we see the most
beginner confusion (experimenting with sockets in a file named socket.py,
etc), and the one where we can generate a comprehensive list of known module
names ahead of time (so in
Changes by STINNER Victor victor.stin...@gmail.com:
--
title: Rework of exceptions are handled in the parser module (in
validate_repeating_list()) - Rework how exceptions are handled in the parser
module (in validate_repeating_list())
___
Python
Martin Panter added the comment:
Patch v9:
* Incorporated _PaddedFile.rewind() into seek() for simplicity
* Reverted to support fast-forwarding in non-seekable streams again
* Factored common checks into _check_can_seek()
* Documented “mtime” attribute and implemented it as a read-only
New submission from Freddy:
I just installed Python 3.5.0a2 from Source.
Debian 3.2.65-1+deb7u1 x86_64 GNU/Linux
[264/392] test_hashlib
/root/Downloads/Python-3.5.0a2/Lib/test/test_hashlib.py:52: UserWarning: Did a
C extension fail to compile? No module named '_hashlib'
warnings.warn('Did a
R. David Murray added the comment:
I would rather say simply The memo dictionary should be treated as an opaque
object. On the other hand, I doubt we will ever change the structure of the
memo dict, because I'm sure that somewhere out there there is code that is
*not* treating it as opaque
Changes by Anand B Pillai anandpil...@letterboxes.org:
--
nosy: +docs@python
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23746
___
___
Serhiy Storchaka added the comment:
Victor?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22390
___
___
Python-bugs-list mailing list
Changes by Anand B Pillai anandpil...@letterboxes.org:
--
assignee: - docs@python
components: +Documentation
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23746
___
Benjamin Peterson added the comment:
The loop might be more elegantly expressed as
for line in self.fp:
self.bytes_read += len(line)
if line.strip() != b-- + self.innerboundary:
break
but otherwise lgtm
--
nosy: +benjamin.peterson
R. David Murray added the comment:
The code you are modifying looks completely wrong-headed to me. Unfortunately
I don't have time to rewrite the cgi module right now :). Given that, your fix
looks fine: the first part of a multipart (up to the first inner boundary) is
the 'preamble', which
Stefan Behnel added the comment:
Meaning, something like this should work:
x = (nom * 10**(prec+1)) // den
if x % 10 5:
x = x // 10
else:
x = x // 10 + 1
print('%s.%s' % (x[:-prec], x[-prec:]))
--
___
Python tracker
Stefan Behnel added the comment:
Or, speaking of division with remainder:
n, r = divmod(nom * 10**prec, den)
if r * 5 = den:
n += 1
x = str(n)
print('%s.%s' % (x[:-prec], x[-prec:]))
... minus the usual off-by-one that the tests would quickly find :)
--
Serhiy Storchaka added the comment:
I think that Decimal is not needed for Fraction.__format__ (and I'm not sure
that issue23602v4.patch is correct). The correct way to format Fraction as
fixed-precision decimal is to use Fraction.__round__() or similar algorithm.
The implementation can look
New submission from Serhiy Storchaka:
Looks as a symlink on Windows 8 can has the FILE_ATTRIBUTE_DIRECTORY flag.
http://buildbot.python.org/all/builders/AMD64%20Windows8%203.4/builds/348/steps/test/logs/stdio
==
FAIL:
Changes by Berker Peksag berker.pek...@gmail.com:
--
resolution: - not a bug
stage: - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22500
___
Berker Peksag added the comment:
Thanks for the patch! I thought line 654-656 was already tested by
self.assertFailure('-L', 'en').
--
nosy: +berker.peksag, serhiy.storchaka
stage: - patch review
versions: +Python 3.4
___
Python tracker
Joshua Bronson added the comment:
Quoting Victor Stinner:
I may workaround the bug during Python finalization if more users report
this issue.
Read the above so reporting I'm hitting this too fwiw.
Thanks for the great work on asyncio.
--
nosy: +jab
Joshua Bronson added the comment:
Not sure if it's related / helpful but just in case, since upgrading from 3.4.2
to 3.4.3, I'm now seeing this printed to stderr sometimes when my program exits:
Exception ignored in: Exception ignored in: Exception ignored in: Exception
ignored in: Exception
Tuomas Suutari added the comment:
On 29 March 2015 at 19:54, Serhiy Storchaka wrote:
I think that Decimal is not needed for Fraction.__format__ (and I'm not sure
that issue23602v4.patch is correct).
Of course it's not needed. I'm using it to avoid re-implementing all
the various formatting
Stefan Behnel added the comment:
But these parameters could also be partly delegated to normal string (not
number) formatting, right?
One of the advantages of not depending on Decimal is, well, to not depend on
Decimal, which is a rather uncommon dependency when using Fractions in an
Serhiy Storchaka added the comment:
Oh, sorry, this was my local file.
--
resolution: - not a bug
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23798
Serhiy Storchaka added the comment:
Here is a patch that should fix the bug.
Can it be committed in 3.3 Georg? The patch is simple and fixes a bug in basic
type.
--
keywords: +patch
nosy: +georg.brandl
stage: needs patch - patch review
Added file:
New submission from Martin Panter:
The documentation claims that SSL socket objects provide some of the same
methods as plain socket objects, including recv(), and that the “bufsize”
parameter specifies the maximum amount of data to be received. With ordinary
sockets, socket.recv(0) always
Barry Alan Scott added the comment:
Mac OS X use the __CF_USER_TEXT_ENCODING env var to setup the locale in for
native libraries.
I found that for GUI python code I needed to convert the value in
__CF_USER_TEXT_ENCODING into a suitable call to setlocale().
The code I use is attached to
STINNER Victor added the comment:
The patch lacks unit test. You showed a test which fails also on little
endian.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23803
___
Donald Stufft added the comment:
Also adding Berker Peksag because they've touched this module recently :)
--
nosy: +berker.peksag
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23801
___
Serhiy Storchaka added the comment:
Added tests that fail on little and big endianess.
--
Added file: http://bugs.python.org/file38726/str_partition_kind_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23803
New submission from Serhiy Storchaka:
Tests added in b923eeaf8162 exposed a bug in str.partition() and
str.rpartition() in 3.4 on big-endian platforms. It should exist in 3.3 too. It
likely was fixed in 3.5 in issue23573.
Serhiy Storchaka added the comment:
Why not use just
self.assertEqual(sorted(it), list(map(sqr, list(range(10)
or
self.assertCountEqual(list(it), list(map(sqr, list(range(10)
?
--
nosy: +serhiy.storchaka
___
Python tracker
Serhiy Storchaka added the comment:
The bug can be reproduced on little-endian platform.
'ABCDEFGHIJKLMNOPQRSTUVWXYZ'.partition('Ā')
('A', 'Ā', 'B\x00C\x00D\x00E\x00F\x00G\x00H\x00I\x00J\x00K\x00L\x00M\x00')
'ABCDEFGHIJKLMNOPQRSTUVWXYZ'.rpartition('Ā')
Donald Stufft added the comment:
Added R David Murray to the nosy list because this is kinda similar to the
email stuff and there doesn't seem to be anyone better to look at this patch
that I can find...
--
nosy: +r.david.murray
___
Python tracker
Martin Panter added the comment:
Happy to when I get a chance. It should be easy to do, though it is not high on
my priority list because I don’t think the scenario is very important in real
world usage. I only encountered it when testing edge cases in another patch.
--
Søren Løvborg added the comment:
As mentioned python-dev, I'm not entirely sold on raising an exception on
overflow.
To recap the mailing list discussion, there was general agreement that the
current behavior is a bug, suggesting that there's no need to go through the
depreciation process.
R. David Murray added the comment:
The KeybaordInterrupt problem has been dealt with in issue 23792.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21398
___
Wolfgang Maier added the comment:
Initially, I also thought that this should be addressable with
Fraction.__round__ or an optimized variation of it, but Tuomas is right that it
gets complicated by the fact that you need to cope with the different format
specifiers and not all of them fit the
Roundup Robot added the comment:
New changeset b9364903d91c by Benjamin Peterson in branch 'default':
merge 3.4 (#23801)
https://hg.python.org/cpython/rev/b9364903d91c
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23801
Valentine Sinitsyn added the comment:
Seems like mentioning string was really a bad idea. They were only used as
(poor) example, forget them if they are confusing in any way.
In my understanding, any sequence in Python is iterable, bit not all iterables
are sequences (correct me if I'm
Roundup Robot added the comment:
New changeset 77c04e949b4b by R David Murray in branch '3.4':
#23792: Ignore KeyboardInterrupt when the pydoc pager is active.
https://hg.python.org/cpython/rev/77c04e949b4b
New changeset fe0c830b43bb by R David Murray in branch 'default':
Merge: #23792: Ignore
Serhiy Storchaka added the comment:
Then tests should be adapted for Windows 8.
--
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23808
___
Donald Stufft added the comment:
@Benjamin
The reason I didn't do that to begin with, was the code currently checks if the
first line is a bytes object or not in order to be able to raise an error if
it's returning str instead of bytes. I didn't want to redo that check on every
iteration, so
Benjamin Peterson added the comment:
Oh, I see. I think your way is fine then.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23801
___
___
Roundup Robot added the comment:
New changeset 3af77d1c5c47 by Donald Stufft in branch '3.4':
Closes #23801 - Ignore entire preamble to multipart in cgi.FieldStorage
https://hg.python.org/cpython/rev/3af77d1c5c47
--
nosy: +python-dev
resolution: - fixed
stage: - resolved
status: open
Changes by Donald Stufft don...@stufft.io:
--
stage: - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23801
___
___
Python-bugs-list
Paul Moore added the comment:
It returns True.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23808
___
___
Python-bugs-list mailing list
R. David Murray added the comment:
I've committed the fix. If someone wants to argue in favor of also handling
SIGQUIT, they can open a new issue.
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker
Donald Stufft added the comment:
Thanks everyone for taking a look at this!
--
stage: resolved -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23801
___
Roundup Robot added the comment:
New changeset 09f22b5d6cea by R David Murray in branch 'default':
#2211: properly document the Morsel behavior changes.
https://hg.python.org/cpython/rev/09f22b5d6cea
--
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
I made several changes to the patch.
The whatsnew docs didn't format correctly: there's an extra space on all the
lines after the first (a three space indent is apparently required there which
I don't understand, but it is also our standard for docs). Also
R. David Murray added the comment:
Now, anyone want to place bets on someone getting bitten by the new errors that
update will raise? :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2211
Roundup Robot added the comment:
New changeset 4d5826fa77a1 by Serhiy Storchaka in branch 'default':
Issue #14260: The groupindex attribute of regular expression pattern object
https://hg.python.org/cpython/rev/4d5826fa77a1
--
nosy: +python-dev
___
Roundup Robot added the comment:
New changeset f40984e7ceea by Serhiy Storchaka in branch '2.7':
Issue #22390: test.regrtest now emits a warning if temporary files or
https://hg.python.org/cpython/rev/f40984e7ceea
New changeset 05e6bab4db8f by Serhiy Storchaka in branch '3.4':
Issue #22390:
Roundup Robot added the comment:
New changeset e93eeadef0c3 by Victor Stinner in branch 'default':
Issue #22117: Use the _PyTime_t API in _datetime.datetime() constructor
https://hg.python.org/cpython/rev/e93eeadef0c3
New changeset b16fc95b66e4 by Victor Stinner in branch 'default':
Issue
STINNER Victor added the comment:
Exception ignored in: Exception ignored in: ...
Hum, I already saw such issues when exiting an asyncio application. It's
probably because they are some pending tasks or transports which are never
closed.
You can try to list tasks at exit using:
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23806
___
___
Python-bugs-list
STINNER Victor added the comment:
regrtest_warn_lost_files2.patch looks good to me.
I just ran the test suite with ./python -m test -j0 -rW on Linux, I didn't
get any warning.
When I modified test_os to create a file x, it was noticed by your patch.
Go ahead.
--
1 - 100 of 107 matches
Mail list logo