[issue30223] Add Lib/test/__main__.py in 2.7

New submission from Serhiy Storchaka: Following patch adds Lib/test/__main__.py in 2.7. This allows running tests with 'python -m test' as in 3.x. -- components: Tests messages: 292720 nosy: ezio.melotti, ncoghlan, serhiy.storchaka priority: normal severity: normal status: open title: A

[issue19903] Idle: Use inspect.signature for calltips

Louie Lu added the comment: Terry, only this case was failed, others in unittest work very well. -- ___ Python tracker ___ ___ Python-

[issue29943] PySlice_GetIndicesEx change broke ABI in 3.5 and 3.6 branches

Nathaniel Smith added the comment: I don't find it helpful to think of it as declaring 3.6.0 broken vs declaring 3.6.1 broken. 3.6.0 is definitely good in the sense that if you build a module on it then it will import on both 3.6.0 and 3.6.1, and 3.6.1 is definitely good in the sense that if y

[issue15987] Provide a way to compare AST nodes for equality recursively

Louie Lu added the comment: Update to AST base type richcompare. the unittest finished time was better than python version: Ran 7 tests in 0.278s -- ___ Python tracker ___

[issue29943] PySlice_GetIndicesEx change broke ABI in 3.5 and 3.6 branches

Serhiy Storchaka added the comment: Either 3.6.1 or 3.6.0 should be officially declared broken. If declare 3.6.1 broken we must port PR 1049 to 3.6 and release 3.6.1.1 or 3.6.2 as early as possible. Many third-party extensions built with 3.6.1 should be rebuild with a new release for compatibi

[issue29943] PySlice_GetIndicesEx change broke ABI in 3.5 and 3.6 branches

Nathaniel Smith added the comment: More collateral damage: apparently the workaround that Pandas used for this bug (#undef'ing PySlice_GetIndicesEx) broke PyPy, so now they need a workaround for the workaround: https://github.com/pandas-dev/pandas/pull/16192 Recording this here partly as a nud

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Jaysinh shukla added the comment: Thanks Mariatta for reminding. Please expect a Github PR from my side in next 2 days. -- ___ Python tracker ___ ___

[issue30221] Deprecate assertNotAlmostEqual

Serhiy Storchaka added the comment: If the absent of use cases is not good argument I close this issue. But this looks as a design mistake to me. -- resolution: -> wont fix stage: -> resolved status: open -> closed ___ Python tracker

[issue19903] Idle: Use inspect.signature for calltips

Terry J. Reedy added the comment: Thanks for the report. As Yuri pointed out in msg292701, and I verified, c.m2() raises "TypeError: meth() takes 0 positional arguments but 1 was given". The purpose of get_argspec is to tell the user how to call the function without getting such a TypeError.

[issue20401] inspect.signature removes initial starred method params (bug)

Terry J. Reedy added the comment: OK, we will change this example in test_calltips once calltips uses .signature (#19903). -- ___ Python tracker ___

[issue22385] Define a binary output formatting mini-language for *.hex()

Nick Coghlan added the comment: Minimalist proposal: def hex(self, *, bytes_per_group=None, delimiter=" "): """B.hex() -> string of hex digits B.hex(bytes_per_group=N) -> hex digits in groups separated by *delimeter* Create a string of hexadecimal numbers from a

[issue30220] Why are the custom messages for ValueError and TypeError suppressed in argparse?

paul j3 added the comment: In http://bugs.python.org/issue9353 Steven Bethard includes 'ArgumentTypeError' in a list of values that "look like they should be public but aren't in __all__::". I take that `__all__` list to be the ultimate authority on what's public or not, not omissions in th

[issue21790] Change blocksize in http.client to the value of resource.getpagesize

Martin Panter added the comment: For plain-text (non-SSL) HTTP uploads, perhaps using “socket.sendfile” would help: Issue 13559. Another idea would be to expose and document the low-level socket (or SSL wrapper) and let the user copy data with whatever chunk size they desire. -- nosy:

[issue29992] Expose parse_string in JSONDecoder

Levi Cameron added the comment: A less exotic use case than oberstet's: Converting code from python 2 -> 3 and trying to maintain python 2 behaviour of returning all strings as bytes rather than unicode strings. obsertet's solution works but is very much tied to the current implementation. --

[issue26362] Approved API for creating a temporary file path

Eryk Sun added the comment: > the lack of Windows' os.rename() atomicity rename/replace is two system calls: NtOpenFile to get a handle for the source file and NtSetInformationFile to rename it. The difference is only that replace() sets the ReplaceIfExists field in the FileRenameInformation.

[issue26362] Approved API for creating a temporary file path

Ben Finney added the comment: On 01-May-2017, Serhiy Storchaka wrote: > tempfile.mktemp() is not much more useful that just a function that > generates some names which unlikely matches the names of existing > files the directory. Yes. That is already useful enough to be in the standard library

[issue30221] Deprecate assertNotAlmostEqual

Robert Collins added the comment: We've now spent more time debating the deprecation that we would have saved if it had been deprecated. Deprecations cost user good will. Whilst I very much want to delete all assertions in favour of matchers, which would allow composed symmetry rather than th

[issue30205] socket.getsockname() type mismatch with AF_UNIX on Linux

Changes by Christian Heimes : -- nosy: +christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue30192] hashlib module breaks with 64-bit kernel and 32-bit user space

Christian Heimes added the comment: The issues seems to be resolved. In the future please add the expert for a topic or maintainer of a module to the nosy list of the ticket. -- nosy: +christian.heimes ___ Python tracker

[issue30205] socket.getsockname() type mismatch with AF_UNIX on Linux

Changes by Antoine Pitrou : -- pull_requests: +1479 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30205] socket.getsockname() type mismatch with AF_UNIX on Linux

Antoine Pitrou added the comment: Amusingly, binding to the empty string produces something different: >>> s = socket.socket(socket.AF_UNIX) >>> s.getsockname() b'' >>> s.bind(b'') >>> s.getsockname() b'\x05d' while binding to the nul byte string produces the expected result: >>> s = socke

[issue20401] inspect.signature removes initial starred method params (bug)

Yury Selivanov added the comment: > Is there any reason that the second case Terry provide still will failed with > ValueError? > class C: >def meth2(**kwds): pass > ip.signature(C().meth2) Yes, the reason is that `C().meth2` is an invalid method that can't be called. Try calling `C().m

[issue30214] make_zip.py lacks command a few line options.

Steve Dower added the comment: I disagree with this going into the core repo - this script is meant for producing our official packages, and is not a general purpose tool. If someone does make changes, please backport them as far as possible (so that bug fixes are easy to cherry pick) and don'

[issue22385] Define a binary output formatting mini-language for *.hex()

Eric V. Smith added the comment: The Unix "od" command pretty much has all of the possibilities covered. https://linuxconfig.org/od-1-manual-page Although "named characters" might be going a bit far. Float, too. -- ___ Python tracker

[issue27618] docs for threading.Lock claim it's a class (since 3.3), but it's not (and has never been, apparently)

Changes by Mariatta Wijaya : -- stage: -> patch review versions: +Python 2.7, Python 3.7 -Python 3.3, Python 3.4 ___ Python tracker ___ _

[issue30221] Deprecate assertNotAlmostEqual

Serhiy Storchaka added the comment: Google finds only 16 books for me. I have reviewed them, and all of them just list assertion methods, copying the official documentation or one other. Often the book contains just one mention of assertNotAlmostEqual (not including the contents and the index)

[issue26362] Approved API for creating a temporary file path

Serhiy Storchaka added the comment: > temp_name = tempfile.mktemp(dir=".") > os.link("a", temp_name) There is a race condition between generating file name and using it. tempfile.mktemp() is not much more useful that just a function that generates some names which unlikely matches the names

[issue30221] Deprecate assertNotAlmostEqual

Changes by Stefan Krah : -- nosy: -skrah ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.o

[issue30214] make_zip.py lacks command a few line options.

Decorater added the comment: Alright moved the bug part to http://bugs.python.org/issue30222. -- ___ Python tracker ___ ___ Python-bug

[issue30221] Deprecate assertNotAlmostEqual

Stefan Krah added the comment: > Do these books have any use cases for assertNotAlmostEqual() or just > enumerate the list of TestCase methods? I think this should be researched by the proponent of the change. -- ___ Python tracker

[issue30222] make_zip.py had a bug when setting up full 64 bit distribution.

New submission from Decorater: Basically running make_zip like this: ".\PCbuild\amd64\python.exe" ".\Tools\msi\make_zip.py" -a x64 -o ".\python36-x86-x64" Cuases make_zip mess up where none of the libs\*.lib, nor any of the assemblies are copied. And is reproducible on me. However doing some

[issue30119] (ftplib) A remote attacker could possibly attack by containing the newline characters

Giampaolo Rodola' added the comment: The relevant discussion of this bug is happening in https://github.com/python/cpython/pull/1214. -- ___ Python tracker ___ _

[issue30214] make_zip.py lacks command a few line options.

Decorater added the comment: Alright renamed it. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30214] make_zip.py lacks command a few line options.

Changes by Decorater : -- title: make_zip.py lacks command a few line options and has a bug. -> make_zip.py lacks command a few line options. ___ Python tracker ___

[issue30221] Deprecate assertNotAlmostEqual

Serhiy Storchaka added the comment: > Any peculiarity that applies to assertNotAlmostEqual also applies to > assertAlmostEqual, so I'm not sure how removing one but keeping the other > would simplify anything. There are use cases for assertAlmostEqual(). You can find examples in the CPython t

[issue26362] Approved API for creating a temporary file path

Tim Chase added the comment: I do have a workaround thanks to Gregory Ewing https://mail.python.org/pipermail/python-list/2017-May/721649.html which suffices for my particular use-case (generating a link to a file with a unique filename). As my use-case is predominantly for *nix environments, t

[issue30221] Deprecate assertNotAlmostEqual

Stefan Krah added the comment: There are 100 results in Google books alone. Are the books wrong (honest question, I did not check)? They will be wrong if we remove it. ;) I agree with Michael that assertNotAlmostEqual() doesn't hurt. -- nosy: +skrah _

[issue21790] Change blocksize in http.client to the value of resource.getpagesize

Clay Gerrard added the comment: I don't think the default is bad/wrong so much as it's an inflexible magic number. I think blocksize should be parameterized as an attribute on the connection - or at least a class attribute or module level constant so we can monkey patch it without having to c

[issue30221] Deprecate assertNotAlmostEqual

R. David Murray added the comment: Not only is not something to be surprised about, it would be surprising for it to be absent. So the user cognitive overhead of removing it is quite possibly higher than that of it being there. -- nosy: +r.david.murray ___

[issue30221] Deprecate assertNotAlmostEqual

Antoine Pitrou added the comment: Any peculiarity that applies to assertNotAlmostEqual also applies to assertAlmostEqual, so I'm not sure how removing one but keeping the other would simplify anything. Furthermore, such symmetry between positive and negative asserts is widespread in the unitt

[issue30145] Create a How to or Tutorial documentation for asyncio

STINNER Victor added the comment: Le 1 mai 2017 19:06, "Mariatta Wijaya" a écrit : Mariatta Wijaya added the comment: Sounds great! Thanks, Yury! Victor, do you think it's worth including a link to http://asyncio.readthedocs.io/en/latest/ somewhere in the docs, if we haven't already? Yes! -

[issue30214] make_zip.py lacks command a few line options and has a bug.

Brett Cannon added the comment: Can you separate out the bug report from the feature request as two separate issues? You can keep one here and rename the title if you want. -- nosy: +brett.cannon ___ Python tracker

[issue24119] Carry comments with the AST

Serhiy Storchaka added the comment: Where would comment be attached in the following case? a = ('start' # comment 1 'continuation') # comment 2 -- nosy: +serhiy.storchaka ___ Python tracker __

[issue24119] Carry comments with the AST

Brett Cannon added the comment: There's potentially some usefulness from other tools, but Raymond is right that the main motivation is definitely gone long-term. Dropping this down to "low" priority simply because others have asked for this kind of support before. -- priority: normal -

[issue30221] Deprecate assertNotAlmostEqual

Serhiy Storchaka added the comment: This will save time and memory of unittest users for reading the documentation, remembering it and trying to understand in which cases assertNotAlmostEqual() can be used. This will prevent them from using unsuitable method. I found only one case of using ass

[issue30221] Deprecate assertNotAlmostEqual

Antoine Pitrou added the comment: Agreed with Michael. -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue30207] Rename test.test_support to test.support in 2.7

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue30221] Deprecate assertNotAlmostEqual

Michael Foord added the comment: I agree it's not *very* useful, but I don't see any benefit in getting rid of it either. -- ___ Python tracker ___ _

[issue30208] Small typos in IDLE doc

Mariatta Wijaya added the comment: One PR per branch is correct. For future reference, preferably the commit hash to be cherry-picked is the one that is merged into CPython's master branch. It can be found at the original PR where it says merged commit into python:master. For PR 1353, it is

[issue29606] urllib FTP protocol stream injection

ecbftw added the comment: It was just pointed out by @giampaolo in (https://github.com/python/cpython/pull/1214) that an escaping mechanism does actually exist for FTP, as defined in RFC-2640. The relevant passage is as follows: When a character is encountered as part of a pathname it MU

[issue30145] Create a How to or Tutorial documentation for asyncio

Mariatta Wijaya added the comment: Sounds great! Thanks, Yury! Victor, do you think it's worth including a link to http://asyncio.readthedocs.io/en/latest/ somewhere in the docs, if we haven't already? -- ___ Python tracker

[issue30207] Rename test.test_support to test.support in 2.7

Serhiy Storchaka added the comment: New changeset 6bed8f95d72f622cb916bcebad651ccd3de6fe9d by Serhiy Storchaka in branch '2.7': bpo-30207: Install the Lib/test/support directory. (#1369) https://github.com/python/cpython/commit/6bed8f95d72f622cb916bcebad651ccd3de6fe9d --

[issue30221] Deprecate assertNotAlmostEqual

New submission from Serhiy Storchaka: The purpose of the assertNotAlmostEqual() method of TestCase is not clear. This method is never used in the CPython testsuite (except tests for it itself), it is never mentioned in the bug tracker (except one general issue about mass renaming methods in Te

[issue30220] Why are the custom messages for ValueError and TypeError suppressed in argparse?

Pedro added the comment: You can get around the message suppression by raising anything that isn't a ValueError, TypeError, or subclass thereof. It will propagate up past _get_value(). I still don't see the reason for giving special treatment to ValueError and TypeError. -- _

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

Mariatta Wijaya added the comment: Jaysinh, are you up for preparing a PR based on you patch? Start with the master branch. Thanks. -- ___ Python tracker ___ ___

[issue10945] bdist_wininst depends on MBCS codec, unavailable on non-Windows

Changes by Jelmer Vernooij : -- nosy: +Jelmer Vernooij, jelmer ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22385] Define a binary output formatting mini-language for *.hex()

Gregory P. Smith added the comment: Based on the ideas thread it isn't obvious that chunk size means "per byte". I suggest either specifying the number of base digits per delimiter. Or using a name other than chunk that indicates it means bytes. If we're going to do this, it should also be d

[issue30207] Rename test.test_support to test.support in 2.7

Serhiy Storchaka added the comment: Thank you for noticing this Zachary. -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue30207] Rename test.test_support to test.support in 2.7

Changes by Serhiy Storchaka : -- resolution: fixed -> stage: resolved -> patch review status: closed -> open ___ Python tracker ___ _

[issue30207] Rename test.test_support to test.support in 2.7

Changes by Serhiy Storchaka : -- pull_requests: +1478 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30220] Why are the custom messages for ValueError and TypeError suppressed in argparse?

New submission from Pedro: ArgumentParser._get_value() has two exception handlers: one for ArgumentTypeError, and one for (TypeError, ValueError). But in the latter case, any custom message I include the TypeError or ValueError is ignored and replaced with a generic "invalid value" message. I

[issue30190] unittest's assertAlmostEqual improved error message

Giampaolo Rodola' added the comment: New changeset 5d7a8d0c13737fd531b722ad76c505ef47aac96a by Giampaolo Rodola in branch 'master': bpo-30190: improved error msg for assertAlmostEqual(delta=...) (#1331) https://github.com/python/cpython/commit/5d7a8d0c13737fd531b722ad76c505ef47aac96a

[issue30219] webbrowser.open outputs xdg-open deprecation warning

Serhiy Storchaka added the comment: Seems it outputs the warning only on Gnome. Actually, xdg-open tries to run gvfs-open if it is installed and it is the tool now depreciated. This issue is fixed in mainstream. [1] [1] https://cgit.freedesktop.org/xdg/xdg-utils/commit/?id=0d6eebb27c562e8644c

[issue30160] BaseHTTPRequestHandler.wfile: supported usage unclear

Mike added the comment: My CLA signature has been verified, but based on the most recent comments, I'm not sure if something needs to change in this patch. Is there anything I can doto help this land? -- ___ Python tracker

[issue15987] Provide a way to compare AST nodes for equality recursively

Louie Lu added the comment: Provide a recursive way to compare AST nodes, it will compare with fields, but no attributes. The performance compare with ast.dump methods in unittest # Recursive compare ./python -m unittest test.test_ast.ASTCompareTest .. ---

[issue15987] Provide a way to compare AST nodes for equality recursively

Changes by Louie Lu : -- pull_requests: +1477 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue30219] webbrowser.open outputs xdg-open deprecation warning

Changes by Xiang Zhang : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30207] Rename test.test_support to test.support in 2.7

Zachary Ware added the comment: I like this change, but the install target in Makefile.pre.in needs to be adjusted accordingly: http://buildbot.python.org/all/builders/x86%20Gentoo%20Installed%20with%20X%202.7/builds/120 -- nosy: +zach.ware ___ Pyth

[issue22385] Define a binary output formatting mini-language for *.hex()

Nick Coghlan added the comment: Copying the amended proposal from that python-ideas thread into here: Start with a leading base format character (chosen to be orthogonal to the default format characters): "h": lowercase hex "H": uppercase hex "A": ASCII (using "." for unprintable &

[issue26362] Approved API for creating a temporary file path

Eryk Sun added the comment: For Windows, use os.replace instead of os.rename, which will replace the destination file if it exists. However, a request to replace an existing file will be denied access if the file is currently open. Unlinking an open file isn't allowed, even if it's open with d

[issue24119] Carry comments with the AST

Raymond Hettinger added the comment: After PEP 526, the need for this proposal may have evaporated. -- nosy: +rhettinger ___ Python tracker ___ __

[issue26362] Approved API for creating a temporary file path

R. David Murray added the comment: Yes, and I'm saying his example doesn't work on Windows (on windows, it does not accomplish his goal). So I'm not sure it is a use case appropriate for the standard library. I'm not saying it definitely isn't, I'm just raising a doubt. -- _

[issue30219] webbrowser.open outputs xdg-open deprecation warning

Changes by desbma : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.o

[issue30219] webbrowser.open outputs xdg-open deprecation warning

New submission from desbma: Python 3.6.1 (default, Mar 27 2017, 00:27:06) [GCC 6.3.1 20170306] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import webbrowser >>> webbrowser.open("https://www.google.com";) True >>> This tool has been deprecated, use 'gio ope

[issue26362] Approved API for creating a temporary file path

Ben Finney added the comment: On 01-May-2017, R. David Murray wrote: > You are depending on a non-portable feature of os.rename there What's the non-portable dependency? If you mean the expectation that ‘os.rename’ will be atomic on success: the documentation promises “If successful, the renami

[issue26362] Approved API for creating a temporary file path

R. David Murray added the comment: You are depending on a non-portable feature of os.rename there, so I'm not convinced this makes a good use case for the Python stdlib. -- nosy: +r.david.murray ___ Python tracker

[issue15987] Provide a way to compare AST nodes for equality recursively

Louie Lu added the comment: If we only need a binary True/False result, could we just return a compare of dump(a) == dump(b)? This can also add the include_attributes flags for need. -- nosy: +louielu ___ Python tracker

[issue24119] Carry comments with the AST

Louie Lu added the comment: Brett, which implement method will you prefer? If we want to carry comment at builtin_compile_impl, it will need to change the grammar since tokenize just drop the comment when dealing with source code. But if just using regex, will it be more easy with just combine

[issue30181] Correct the parsing of a test case docstring.

Louie Lu added the comment: Ben, if you have any problem about how to get on with GitHub, I can help you at #python-dev @ freenode, ping louielu on the chatroom. -- ___ Python tracker _

[issue30200] tkinter ListboxSelect

Frank Pae added the comment: Here some detailed information about Tcl / Tk versions: platform Windows-10-10.0.14393 AMD64 python 3.6.1 (v3.6.1:69c0db5, Mar 21 2017, 18:41:36) [MSC v.1900 64 bit (AMD64)] tkinterTcl/Tk 8.6.6 / 8.6.6 python 3.5.3 (v3.5.3:1880cb95a742, Jan 16 201

[issue30181] Correct the parsing of a test case docstring.

Louie Lu added the comment: > Thank you. I'll re-base my branch onto the master branch found at the GitHub > repository. You may re-clone a GitHub repository instead of rebase bitbucket repo. > I don't maintain repositories at GitHub. Does that mean the contribution must > be rejected? No,

[issue30181] Correct the parsing of a test case docstring.

Ben Finney added the comment: On 2017-05-01 17:45, Louie Lu wrote: > Ben, the process of submitting PR was migrated to GitHub Thank you. I'll re-base my branch onto the master branch found at the GitHub repository. > you will need to use a GitHub account to do it I don't maintain repositories

[issue30181] Correct the parsing of a test case docstring.

Louie Lu added the comment: Ben, the process of submitting PR was migrated to GitHub, you will need to use a GitHub account to do it. You can refer to devguide for how to submit a PR here: http://cpython-devguide.readthedocs.io/pullrequest.html --

[issue30181] Correct the parsing of a test case docstring.

Ben Finney added the comment: Howdy R. David, Okay, I have put together a series of commits to address this bug. The changes are in my personal fork of the ‘cpython’ repository, so this is a pull request from ‘wip/issue/issue30181_parse-docstring-using-pydoc’ in that repository. The following c