[issue35383] lib2to3 raises ParseError on argument called "print"

2018-12-07 Thread Martin Panter
Martin Panter added the comment: Previous related reports: * Issue 35260: “2to3” doesn’t parse Python 3’s “print” function by default because it is supposed to translate Python 2 syntax * Issue 2412: “2to3” should support “from __future__ import print_function”. That frees up the “print”

[issue35438] Extension modules using non-API functions

2018-12-07 Thread Josh Rosenberg
Josh Rosenberg added the comment: Batteries-included extension modules aren't limited to the public and/or limited API; they use tons of undocumented internal APIs (everything to do with Py_IDENTIFIERs being an obvious and frequently used non-public API). _PyObject_LookupSpecial is

[issue35438] Extension modules using non-API functions

2018-12-07 Thread Eddie Elizondo
Eddie Elizondo added the comment: Correction, this is not as trivial as just using `PyObject_GetAttrString`. Will investigate the correct behavior. -- ___ Python tracker ___

[issue35439] New class instance not initializing variables of type list

2018-12-07 Thread Ammar Askar
Ammar Askar added the comment: This is expected behavior, take a look at this section in the tutorial on classes: https://docs.python.org/3/tutorial/classes.html#class-and-instance-variables Unlike say Java, member variables need to be initialized in the constructor. -- nosy:

[issue35439] New class instance not initializing variables of type list

2018-12-07 Thread Arturo Inzunza
New submission from Arturo Inzunza : List type variables in a class are not reset on new instances of the class. Example: class Klazz: lst = [] def __init__(self, va): print(self.lst) self.lst.append(va) k = Klazz(1) [] -> This is correct as the lst value is

[issue35431] Add a function for computing binomial coefficients to the math module

2018-12-07 Thread Steven D'Aprano
Steven D'Aprano added the comment: Brett, what was the purpose of the title change? > title: The math module should provide a function for computing > binomial coefficients -> Add a function for computing binomial > coefficients to the math module --

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread Steve Dower
Steve Dower added the comment: > In general, I don't think we've done that great a job of publicising > the various install options on Windows - we still get pip users trying > to install packages into the embedded distribution, which they are > using as if it were a standalone interpreter,

[issue35429] Incorrect use of raise NotImplemented

2018-12-07 Thread Brett Cannon
Brett Cannon added the comment: This was fixed by https://github.com/python/cpython/pull/10934 -- nosy: +brett.cannon stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue35431] Add a function for computing binomial coefficients to the math module

2018-12-07 Thread Brett Cannon
Change by Brett Cannon : -- title: The math module should provide a function for computing binomial coefficients -> Add a function for computing binomial coefficients to the math module ___ Python tracker

[issue35376] modulefinder skips nested modules with same name as top-level bad module

2018-12-07 Thread Brett Cannon
Brett Cannon added the comment: PRs should always be against 'master' unless the issue is already fixed there. -- nosy: +brett.cannon ___ Python tracker ___

[issue35376] modulefinder skips nested modules with same name as top-level bad module

2018-12-07 Thread Brett Cannon
Change by Brett Cannon : -- nosy: +jvr ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35376] modulefinder skips nested modules with same name as top-level bad module

2018-12-07 Thread Brett Cannon
Change by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35376] modulefinder skips nested modules with same name as top-level bad module

2018-12-07 Thread Brett Cannon
Change by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33747] Failed separate test_patch_propogrates_exc_on_exit in test_unittest

2018-12-07 Thread miss-islington
Change by miss-islington : -- pull_requests: +10269 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33747] Failed separate test_patch_propogrates_exc_on_exit in test_unittest

2018-12-07 Thread miss-islington
Change by miss-islington : -- pull_requests: +10268 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33747] Failed separate test_patch_propogrates_exc_on_exit in test_unittest

2018-12-07 Thread Brett Cannon
Brett Cannon added the comment: New changeset 3cf74384b53b998fa846dc2590cedf9ad2a0d5fd by Brett Cannon (Anirudha Bose) in branch 'master': bpo-33747: Avoid mutating the global sys.modules dict in unittest.mock tests (GH-8520)

[issue35438] Extension modules using non-API functions

2018-12-07 Thread Eddie Elizondo
New submission from Eddie Elizondo : Three extension modules: _testcapimodule.c, posixmodule.c, and mathmodule.c are using `_PyObject_LookupSpecial` which is not API. These should instead use `PyObject_GetAttrString`, `PyType_GetSlot`. -- components: Library (Lib) messages: 331364

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread Paul Moore
Paul Moore added the comment: Thanks for the clarification. > In all the cases I've tested, regular Python install shows up first. If it's > not installed, the Store app shows up much of the time. This feels like the > right design (with the caveat about "much of the time" requiring changes

[issue35435] Discourage external links to old docs.

2018-12-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: I changed the title to better state the actual issue and goal of action. The termination solution is rejected, but further revisions to docs and site need not be. Adding the auto updated https://docs.python.org/3/ was a good move (and a reason to not

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

2018-12-07 Thread Steve Dower
Steve Dower added the comment: Bin and source dependency repos are updated - just needs the project updates now and testing. -- ___ Python tracker ___

[issue35403] support application/wasm in mimetypes and http.server

2018-12-07 Thread Terry J. Reedy
Change by Terry J. Reedy : -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35402] Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1

2018-12-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: ... and master. I believe for Windows the policy has been to stick with one tcl/tk version for a Python version. But I don't know that this is written on stone. If not too much trouble, I would like master updated occasionally during the a1 period rather

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread Ethan Smith
Change by Ethan Smith : -- nosy: +Ethan Smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35383] lib2to3 raises ParseError on argument called "print"

2018-12-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: In 2.x, 'print' is a reserved keyword and compiling foo fails with SyntaxError. AFAIK, 2to3 expects the input to be *valid* 2.x code that compiles. So it seems to me that the bug is in the input, not 2to3, and that this issue should be closed as 'not a

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread Steve Dower
Steve Dower added the comment: > How will the Windows Store install work alongside the PSF one? Oh, and since I didn't mention it in my direct answer, the Store install goes to a totally different location (per machine, no elevation required), as do packages installed using pip

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread Steve Dower
Steve Dower added the comment: > The first thing I'll note is that I'm not aware of any documentation > on the Windows Store installer, and how it works. Right now, correct. > How will the Windows Store install work alongside the PSF one? It will go into PATH under the same names as on

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread Paul Moore
Paul Moore added the comment: > > Steve, assuming that I can access the Store, should I be able to install > > both PSF 3.7.2 and Windows Store 3.7.2 simultaneously? So I could test > > both IDLEs that beginners might install? > > Yes, absolutely. (To be clear, both are PSF approved and

[issue32417] fromutc does not respect datetime subclasses

2018-12-07 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32417] fromutc does not respect datetime subclasses

2018-12-07 Thread Guido van Rossum
Guido van Rossum added the comment: OK. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35435] Documentation of 3.3 is available

2018-12-07 Thread Ned Deily
Ned Deily added the comment: > I think as it stands, this ticket is "not a bug". Indeed, this is not only not a bug, it's a feature that the docs for every Python release family are available on-line. That said, we do have two sets of URLs that point to these docs: 1.

[issue32417] fromutc does not respect datetime subclasses

2018-12-07 Thread Paul Ganssle
Paul Ganssle added the comment: > What's the use case for subclassing DateTime? These classes were not designed > with subclassing as a use case in mind. There are several reasons for doing it, of various levels of legitimacy. The overall theme is that people want different behaviors from

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread Steve Dower
Steve Dower added the comment: Thanks Terry, great questions. > I want this to be and remain an added alternative rather than a replacement > of the current installer directly available on python.org. Can you assure us > that the latter are not going away? Absolutely. The current

[issue31354] Fixing a bug related to LTO only build

2018-12-07 Thread Charalampos Stratakis
Charalampos Stratakis added the comment: Hi Ned, I recently pushed a fix on the master and 3.7 for this exact issue: https://bugs.python.org/issue35351 but it builds on top of https://github.com/python/cpython/pull/10922 which is not yet in 3.6. Thus 3.7 is fine for the rc cutoff. However

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: Various questions and comments: 0. Steve: For more than one reason, I want this to be and remain an added alternative rather than a replacement of the current installer directly available on python.org. Can you assure us that the latter are not going away?

[issue32417] fromutc does not respect datetime subclasses

2018-12-07 Thread Guido van Rossum
Guido van Rossum added the comment: What's the use case for subclassing DateTime? These classes were not designed with subclassing as a use case in mind. -- nosy: +gvanrossum ___ Python tracker

[issue35435] Documentation of 3.3 is available

2018-12-07 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: > put a prominent note at the top of each page "This is an unsupported version > of the docs, for the latest version see blah blah blah" and link to the most > recent version. Not sure how straightforward it will be to do this, and whether it will worth

[issue32417] fromutc does not respect datetime subclasses

2018-12-07 Thread Paul Ganssle
Paul Ganssle added the comment: Ah, that's my mistake. I have always been under the impression that "Versions" meant "versions affected", not "versions that this needs to be fixed for". I usually just selected the ones where I had verified that it's a problem. I do not think this should be

[issue31354] Fixing a bug related to LTO only build

2018-12-07 Thread Ned Deily
Ned Deily added the comment: This issue is still open and blocking the upcoming 3.7.2rc1 and 3.6.8rc1 releases. -- ___ Python tracker ___

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

2018-12-07 Thread Steve Dower
Steve Dower added the comment: I'm getting the cpython-source-deps repo updated now, and will do the Windows updates shortly after. -- ___ Python tracker ___

[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

2018-12-07 Thread Mario Corchero
Mario Corchero added the comment: Agree that it sounds reasonable to just set `__signature__` to tell `inspect` where to look at (thanks PEP 362 :P). Not an expert here though. For the partials bug, I'll add Pablo as we were speaking today about something similar :) but that might be

[issue32417] fromutc does not respect datetime subclasses

2018-12-07 Thread STINNER Victor
STINNER Victor added the comment: > I am somewhat uneasy about backporting this to Python 2.7 because changing > the return type of `SomeDateTime + timedelta` could be seen as a breaking > change. I have sent a message to the datetime-SIG mailing list about this for > more visibility. You

[issue32417] fromutc does not respect datetime subclasses

2018-12-07 Thread Paul Ganssle
Paul Ganssle added the comment: I am somewhat uneasy about backporting this to Python 2.7 because changing the return type of `SomeDateTime + timedelta` could be seen as a breaking change. I have sent a message to the datetime-SIG mailing list about this for more visibility. If it is

[issue32417] fromutc does not respect datetime subclasses

2018-12-07 Thread STINNER Victor
STINNER Victor added the comment: Since the C code is only a few lines, what do you think of also fixing Python 2.7? -- nosy: +vstinner ___ Python tracker ___

[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x

2018-12-07 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +10267 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22005] datetime.__setstate__ fails decoding python2 pickle

2018-12-07 Thread Paul Ganssle
Change by Paul Ganssle : -- nosy: -p-ganssle ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22005] datetime.__setstate__ fails decoding python2 pickle

2018-12-07 Thread Paul Ganssle
Paul Ganssle added the comment: I do not care enough about this to fight about it. The issue has been open long enough that I do not think it justified the urgency of rushing through a patch just before the release and merging without review, but now that it is in the release of multiple

[issue35431] The math module should provide a function for computing binomial coefficients

2018-12-07 Thread kellerfuchs
kellerfuchs added the comment: @Steven D'Aprano: > all call this nCr, and nPr for the permutation version. This matches > the notation taught in secondary school maths classes in Australia. > That's common and familiar notation for secondary school students, but > personally I'm not

[issue9566] Compilation warnings under x64 Windows

2018-12-07 Thread STINNER Victor
STINNER Victor added the comment: New changeset 028f0ef4f3111d2b3fc5b971642e337ba7990873 by Victor Stinner in branch 'master': bpo-9566: Fix compiler warnings in peephole.c (GH-10652) https://github.com/python/cpython/commit/028f0ef4f3111d2b3fc5b971642e337ba7990873 --

[issue35431] The math module should provide a function for computing binomial coefficients

2018-12-07 Thread kellerfuchs
kellerfuchs added the comment: > I'd personally prefer that floats not be accepted; I think this was a > misfeature of `factorial` that we shouldn't compound. OK; I only went with that because I assumed there were Good Reasons© that factorial did it, but if rejecting integral floats isn't

[issue35431] The math module should provide a function for computing binomial coefficients

2018-12-07 Thread kellerfuchs
kellerfuchs added the comment: @Mark Dickinson: > You don't mean the "k=0" part of that, right? Indeed not; the tests in the PR actually assert binomial(n, n) == binomial(n, 0) == 1. -- ___ Python tracker

[issue35431] The math module should provide a function for computing binomial coefficients

2018-12-07 Thread kellerfuchs
kellerfuchs added the comment: @Serhiy Storchaka: > I think that it is better to add this function in a new module imath, which > could contain other integer functions imath is a fine idea, and you already started a discussion in python-ideas@, but it's a much bigger undertaking than just

[issue22005] datetime.__setstate__ fails decoding python2 pickle

2018-12-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This issue is already open for a long time. There is a problem which can not be worked around from the user side. I want to get it solved in 3.6, and today is the last chance for this. This is important for migrating from Python 2 to Python 3. You can

[issue22005] datetime.__setstate__ fails decoding python2 pickle

2018-12-07 Thread Paul Ganssle
Paul Ganssle added the comment: @Serhiy Any chance we can roll these back before the release so that they can have some time for discussion? I have serious concerns about having to support some Python 2/3 compatibility hack in datetime for the next 6 years. If this is worth doing at all, I

[issue22005] datetime.__setstate__ fails decoding python2 pickle

2018-12-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is the same hack as in NumPy, so we are at least consistent here. I think we have to keep it some time after 2020, maybe to 2025. -- ___ Python tracker

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +10266 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35427] logging UnicodeDecodeError from undecodable strftime output

2018-12-07 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35436] Add missing PyErr_NoMemory() calls

2018-12-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Backporting to 2.7 is not so trivial due to the number of conflicts. Zackery, do you mind to create a backport for 2.7? -- ___ Python tracker

[issue35436] Add missing PyErr_NoMemory() calls

2018-12-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 2d6bc25dbc3dc5662f13917eb759f92842bf6de6 by Serhiy Storchaka in branch '3.6': bpo-35436: Add missing PyErr_NoMemory() calls and other minor bug fixes. (GH-11015) (GH-11020) (GH-11026)

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +10265 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35433] Correctly detect installed SDK versions

2018-12-07 Thread Jeremy Kloth
Jeremy Kloth added the comment: > Is it a warning or an error? What is the warning/error message? What is your > buildbot? It is a compiler error as you point out below (with message). By buildbot is: https://buildbot.python.org/all/#/workers/12 > Right now, it seems like only "AMD64

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread Steve Dower
Steve Dower added the comment: >> We haven't done RC yet - why is pushing this now so bad? > I reverted your change because it broke all Windows buildbots, and we have a > policy to revert a change if buildbots turn red and no fix can be found in 2 > hours I don't dispute that policy, but

[issue35437] Almost all Windows buildbots are failing to compile

2018-12-07 Thread STINNER Victor
STINNER Victor added the comment: I revert the changes, so buildbots should go back to green. I asked Steve Dower to use a custom build to avoid such hiccup on the next attempt to merge his change. -- priority: release blocker -> resolution: -> fixed stage: -> resolved status:

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +10264 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +10263 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22005] datetime.__setstate__ fails decoding python2 pickle

2018-12-07 Thread Paul Ganssle
Paul Ganssle added the comment: I'm not sure I agree with how this was resolved. We're adding complexity to the datetime unpickler to support unpickling pickles created in Python 2 in Python 3? I also don't really understand the encoding parts of it, but it smells very fishy to me. I agree

[issue35436] Add missing PyErr_NoMemory() calls

2018-12-07 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +10262 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35433] Correctly detect installed SDK versions

2018-12-07 Thread STINNER Victor
STINNER Victor added the comment: After I reverted bpo-34977 change, most Windows buildbots are back to green. > In the process of eliminating compiler warnings on my buildbot, I needed to > update VS2015 to the latest toolset (VS2015 Update 3). This in turn now > causes an error due about

[issue35431] The math module should provide a function for computing binomial coefficients

2018-12-07 Thread Steven D'Aprano
Steven D'Aprano added the comment: On Fri, Dec 07, 2018 at 01:37:36PM +, Mark Dickinson wrote: > I'd personally prefer that floats not be accepted; Agreed. We can always add support for floats later, but its hard to remove it if it turns out to be problematic. We ought to require n, r

[issue35431] The math module should provide a function for computing binomial coefficients

2018-12-07 Thread Steven D'Aprano
Steven D'Aprano added the comment: > > Mathematically, `binomial(n, k)` for `k > n` is defined as 0. > > It's not so clear cut. You can find different definitions out there. > Knuth et. al., for example, in the book "Concrete Mathematics", extend > the definition not just to negative k, but

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread STINNER Victor
STINNER Victor added the comment: Since the first attempt broke all Windows buildbot workers, it would be nice to use a custom build before merging a new attempt :-) See instructions in the devguide: https://devguide.python.org/buildbots/?highlight=custom#custom-builders Note: Pablo used

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread STINNER Victor
STINNER Victor added the comment: > We haven't done RC yet - why is pushing this now so bad? I reverted your change because it broke all Windows buildbots, and we have a policy to revert a change if buildbots turn red and no fix can be found in 2 hours:

[issue35433] Correctly detect installed SDK versions

2018-12-07 Thread Jeremy Kloth
Jeremy Kloth added the comment: Sorry Victor, I should have added more context when I nosy'ed you to this issue. Since you seem to be the "buildbot keeper" as of late, I wanted to give you a pointer to the reason for my failing buildbot. Which, as I surmised, is failing compile due to the

[issue22005] datetime.__setstate__ fails decoding python2 pickle

2018-12-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 1133a8c0efabf6b33a169039cf6e2e03bfe6cfe3 by Serhiy Storchaka in branch 'master': bpo-22005: Fix condition for unpickling a date object. (GH-11025) https://github.com/python/cpython/commit/1133a8c0efabf6b33a169039cf6e2e03bfe6cfe3 --

[issue35431] The math module should provide a function for computing binomial coefficients

2018-12-07 Thread Steven D'Aprano
Steven D'Aprano added the comment: On Fri, Dec 07, 2018 at 12:04:44AM +, Raymond Hettinger wrote: > Also, I'm not sure what the predominant choice for variable names > should be, "n things taken r at a time" or "n things taken k at time". > > Also, it's worth considering whether the

[issue35437] Almost all Windows buildbots are failing to compile

2018-12-07 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: @Steve Notice that 468a15aaf9206448a744fc5eab3fc21f51966aad is currently reverted, so you need to push it again if you plan to add something on top of it. -- ___ Python tracker

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread Steve Dower
Steve Dower added the comment: We haven't done RC yet - why is pushing this now so bad? Most of the change is purely additive and does not modify the code base, the rest is Windows-only or tests. I'll add checks for outdated build machines, but there has to be a release of this or it

[issue35433] Correctly detect installed SDK versions

2018-12-07 Thread Steve Dower
Steve Dower added the comment: No, it just automates something that's been manual for a while. Installing VS 2017 on build bots is still a manual process ;) -- ___ Python tracker

[issue35437] Almost all Windows buildbots are failing to compile

2018-12-07 Thread Steve Dower
Steve Dower added the comment: Okay, so apparently the buildbots are still building with VS 2015, and not VS 2017. I'll add a check for the new executable and repush. This was caused solely by the new code and not by any of the changes to existing code. --

[issue22005] datetime.__setstate__ fails decoding python2 pickle

2018-12-07 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +10261 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22005] datetime.__setstate__ fails decoding python2 pickle

2018-12-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 19f6e83bf03b3ce22300638906bd90dd2dd5c463 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6': bpo-22005: Fixed unpickling instances of datetime classes pickled by Python 2. (GH-11017) (GH-11022) (GH-11024)

[issue35431] The math module should provide a function for computing binomial coefficients

2018-12-07 Thread Mark Dickinson
Mark Dickinson added the comment: One more decision that needs to be made: should the new function accept integer-valued floats? Or should any `float` input give a TypeError. I'd personally prefer that floats not be accepted; I think this was a misfeature of `factorial` that we shouldn't

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread STINNER Victor
STINNER Victor added the comment: > Revert "[3.7] bpo-34977: Add Windows App Store package (GH-10245)" (GH-11021) That should repair buildbots, so I remove "release blocker" priority. -- priority: release blocker -> ___ Python tracker

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread STINNER Victor
STINNER Victor added the comment: New changeset 783b794a5e6ea3bbbaba45a18b9e03ac322b3bd4 by Victor Stinner in branch '3.7': Revert "[3.7] bpo-34977: Add Windows App Store package (GH-10245)" (GH-11021) https://github.com/python/cpython/commit/783b794a5e6ea3bbbaba45a18b9e03ac322b3bd4

[issue35431] The math module should provide a function for computing binomial coefficients

2018-12-07 Thread Mark Dickinson
Mark Dickinson added the comment: @kellerfuchs: > From a mathematical standpoint, (n choose k) is defined for all non-negative > k, n, with (n chooze k) = 0 when k>n or k=0. You don't mean the "k=0" part of that, right? -- ___ Python tracker

[issue35431] The math module should provide a function for computing binomial coefficients

2018-12-07 Thread Mark Dickinson
Mark Dickinson added the comment: > Mathematically, `binomial(n, k)` for `k > n` is defined as 0. It's not so clear cut. You can find different definitions out there. Knuth et. al., for example, in the book "Concrete Mathematics", extend the definition not just to negative k, but to

[issue22005] datetime.__setstate__ fails decoding python2 pickle

2018-12-07 Thread miss-islington
Change by miss-islington : -- pull_requests: +10260 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22005] datetime.__setstate__ fails decoding python2 pickle

2018-12-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 0d5730e6437b157f4aeaf5d2e67abca23448c29a by Serhiy Storchaka in branch '3.7': [3.7] bpo-22005: Fixed unpickling instances of datetime classes pickled by Python 2. (GH-11017) (GH-11022)

[issue35436] Add missing PyErr_NoMemory() calls

2018-12-07 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: -10257 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35324] ssl: FileNotFoundError when do handshake

2018-12-07 Thread Windson Yang
Windson Yang added the comment: I can't reproduce on my laptop. Would you please upload a minimal example? -- nosy: +Windson Yang ___ Python tracker ___

[issue35434] Wrong bpo linked in What's New in 3.8

2018-12-07 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: My bad. Thanks for fixing it. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread STINNER Victor
STINNER Victor added the comment: > I suggest to revert this change from Python 3.7: it broke all Windows > buildbots, see bpo-35437. I reverted the change in master and I will merge PR 11021 once tests pass to revert in 3.7 as well. > It doesn't seem like a good idea to push such change

[issue35433] Correctly detect installed SDK versions

2018-12-07 Thread STINNER Victor
STINNER Victor added the comment: Is this issue related to bpo-34977: Add Windows App Store package? -- ___ Python tracker ___ ___

[issue35436] Add missing PyErr_NoMemory() calls

2018-12-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 602d307ac5e8a2da38a193dca3bdfef5994dfe67 by Serhiy Storchaka (Zackery Spytz) in branch '3.7': bpo-35436: Add missing PyErr_NoMemory() calls and other minor bug fixes. (GH-11015) (GH-11020)

[issue22005] datetime.__setstate__ fails decoding python2 pickle

2018-12-07 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +10259 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread STINNER Victor
STINNER Victor added the comment: New changeset cb0b78a070ea3b704416e74f64046178ae0dff3e by Victor Stinner in branch 'master': Revert "bpo-34977: Add Windows App Store package (GH-10245)" (GH-11019) https://github.com/python/cpython/commit/cb0b78a070ea3b704416e74f64046178ae0dff3e

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +10258 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34977] Release Windows Store app containing Python

2018-12-07 Thread STINNER Victor
STINNER Victor added the comment: > Making the release experimental as part of the next 3.7 update was approved > by Ned (over email), so I merged the build. I suggest to revert this change from Python 3.7: it broke all Windows buildbots, see bpo-35437. It doesn't seem like a good idea to

[issue35437] Almost all Windows buildbots are failing to compile

2018-12-07 Thread STINNER Victor
STINNER Victor added the comment: See also bpo-35433: "Correctly detect installed SDK versions". -- ___ Python tracker ___ ___

[issue22005] datetime.__setstate__ fails decoding python2 pickle

2018-12-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 8452ca15f41061c8a6297d7956df22ab476d4df4 by Serhiy Storchaka in branch 'master': bpo-22005: Fixed unpickling instances of datetime classes pickled by Python 2. (GH-11017)

[issue35411] FTP tests of test_urllib2net fail on Travis CI: 425 Security: Bad IP connecting.

2018-12-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Seems this is a glitch of Travis CI. PR 794 was created long time ago, and while it was regularly merged with master, tests become failing after recent updated. I expect that similar issues can be repeated with other old PRs. After creating a copy of that

  1   2   >