Éric Araujo mer...@netwok.org added the comment:
I will try tomorrow, thanks for reminding me.
That was a fresh clone.
I did.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6011
Éric Araujo mer...@netwok.org added the comment:
with also replaces open-try-do stuff-finally-close, the correct idiom for
ensuring file handles are always closes in all VMs.
I don’t think the doc style guide is the right place, since this is a code
issue. with is advertised in
http
Éric Araujo mer...@netwok.org added the comment:
Fixed indeed.
Dave: Please open a feature request, this is a good idea.
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
Certainly. Here is my secret grep:
$ cd py3k/Doc
$ grep -n --color=auto -d skip -I --exclude-dir .svn --exclude-dir .hg -R
open\(.*\).read *.rst c-api distutils documenting extending faq howto library
reference tutorial using
List without
Éric Araujo mer...@netwok.org added the comment:
Thanks for the patch John. Instead of low-level use of TESTFN, you can use
distutils.tests.support.TempdirManager to create a temporary directory and
write files to it in a few lines.
--
assignee: tarek - eric.araujo
stage: needs patch
Changes by Éric Araujo mer...@netwok.org:
--
resolution: works for me - invalid
stage: - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10463
Éric Araujo mer...@netwok.org added the comment:
I will review your patch later today.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10351
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10424
___
___
Python-bugs-list
Éric Araujo mer...@netwok.org added the comment:
Yes, that’s it. Please don’t change whitespace in your patches.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10461
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue665194
___
___
Python-bugs-list
Éric Araujo mer...@netwok.org added the comment:
Eli, SilentGhost: Please open other bug reports for doc errors like the struct
one in stdlib2 or the r/rb one.
SilentGhost: with statement used with open *is* about file reading :)
Raymond: I agree about try/finally. I agree with Alexander
Éric Araujo mer...@netwok.org added the comment:
Thank you for the fix Priscila. Can you submit it as a diff file? (guidelines
on http://www.python.org/dev/patches/)
Tarek: I wonder if we should backport pydoc_server from d2 to test behavior
bugs like this one
Éric Araujo mer...@netwok.org added the comment:
Thanks for correcting me!
--
resolution: - fixed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9199
Changes by Éric Araujo mer...@netwok.org:
--
versions: -Python 2.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3709
___
___
Python-bugs-list
Éric Araujo mer...@netwok.org added the comment:
Fixed in r86601 and r86605 (py3k), r86606 (3.1), r86609 (2.7). Thanks!
--
resolution: - fixed
stage: - committed/rejected
status: pending - closed
___
Python tracker rep...@bugs.python.org
http
Changes by Éric Araujo mer...@netwok.org:
--
components: -Extension Modules
nosy: +eric.araujo -BreamoreBoy
title: transparent gzip compression in liburl2 - transparent gzip compression
in urllib
___
Python tracker rep...@bugs.python.org
http
Éric Araujo mer...@netwok.org added the comment:
The existing discover subcommand would enter the deprecation process, right?
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10470
Changes by Éric Araujo mer...@netwok.org:
--
keywords: +easy
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10470
Éric Araujo mer...@netwok.org added the comment:
Looks good to me, with one exception:
if temp_dir_abspath.startswith('./'):
Wouldn’t this be better:
if not _os.path.isabs(temp_dir_abspath)
(P.S. file is not a builtin anymore in 3.x, it’s used for example as an
argument to the print
Éric Araujo mer...@netwok.org added the comment:
Looks good, modulo two nitpicks:
1) Using literals for constants would avoid a lookup and call of range.
2) Please remove four leading spaces in your docstring.
--
nosy: +eric.araujo
___
Python
Éric Araujo mer...@netwok.org added the comment:
Nice. Now you can sit back, relax and wait for Nick to commit the patch or
make further comments.
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +d...@python -georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4246
___
___
Python
Éric Araujo mer...@netwok.org added the comment:
TempdirManager hasn’t caused buildbots failures so far, so there is no need to
change it. You can use it, it’s convenient and works :)
--
___
Python tracker rep...@bugs.python.org
http
Éric Araujo mer...@netwok.org added the comment:
distutils docs only get changes that fix a bug (e.g. an example that does not
work), not improvements or reorganization. Your patch is in a gray area; I
think we should not accept it in distutils but re-target it at distutils2.
Even if you
Éric Araujo mer...@netwok.org added the comment:
Doc patch looks good.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9746
___
___
Python-bugs
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1043134
___
___
Python-bugs-list
Éric Araujo mer...@netwok.org added the comment:
Invocation without arguments does not work. I have a fix, I’ll add a test and
commit.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10292
___
___
Python-bugs-list
Éric Araujo mer...@netwok.org added the comment:
Regarding your fix to copy_script, I will have to ask python-dev about PEP 291
in py3k (i.e., should 3.2 code really be compatible with 2.3?).
--
___
Python tracker rep...@bugs.python.org
http
Changes by Éric Araujo mer...@netwok.org:
--
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8647
Éric Araujo mer...@netwok.org added the comment:
Patch committed in r86625 (py3k), r86627 (3.1) and r86627 (2.7).
Regarding API conformance, I ran this simple test, courtesy of Daniel in
msg109784:
for cls in str, bytes, bytearray, list, tuple, range:
... print(cls, [method for method
Changes by Éric Araujo mer...@netwok.org:
--
resolution: - duplicate
stage: needs patch - committed/rejected
status: open - closed
superseder: - mimetypes.guess_extension('text/plain') == '.ksh' ???
title: mimetypes does not give cannonical extension for guess_extension with
text
Éric Araujo mer...@netwok.org added the comment:
This can be kept open as a separate report, since it was caused by the Big
Distutils Revert in 3.2. We’ve already discussed how to fix that in private
email and IRC thanks to Ezio. Because of compat requirements, we’ll probably
have to use
Changes by Éric Araujo mer...@netwok.org:
--
superseder: distutils upload command crashes when displaying server response -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10367
Éric Araujo mer...@netwok.org added the comment:
FTR, note that “svn diff file1 file2...” will give you one file for many edits.
It’s easier to review and apply.
Regarding the change, I don’t know if wsgiref 3.2 has to be compatible with
Python 2.1, which would exclude using the ternary
Changes by Éric Araujo mer...@netwok.org:
--
assignee: - tarek
components: +Distutils2
nosy: +eric.araujo
versions: +3rd party, Python 3.2 -Python 2.6, Python 3.0
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue969718
Éric Araujo mer...@netwok.org added the comment:
This is not a bug in Python but in the third-party pyffi project. Please
report it to them.
--
nosy: +eric.araujo
resolution: - invalid
stage: - committed/rejected
status: open - closed
___
Python
Éric Araujo mer...@netwok.org added the comment:
Thanks for the review. I agree and committed changes in r86632.
The problem with :option:`-c` is probably that Sphinx wants to find a “..
cmdoption:: -c” joined with the latest program directive it has seen, and thus
can’t find the -c defined
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10445
___
___
Python-bugs-list
Éric Araujo mer...@netwok.org added the comment:
If the release manager agrees, I think the change is okay.
--
nosy: +benjamin.peterson, eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10406
Éric Araujo mer...@netwok.org added the comment:
Can you propose a patch, as a diff or even plain English in a reply?
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10405
Éric Araujo mer...@netwok.org added the comment:
Platform consistency is a worthy criterion for changes, but I suspect such a
behavior change can’t make it into stable branches.
--
nosy: +benjamin.peterson, eric.araujo
___
Python tracker rep
Éric Araujo mer...@netwok.org added the comment:
Just for fun, I tried using my tiny understanding of C to write a patch. I am
attaching my current result, which passes the test suite except for
test_unittest:
FAIL: test_loadTestsFromName__unknown_module_name
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10370
___
___
Python-bugs-list
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10369
___
___
Python-bugs-list
Éric Araujo mer...@netwok.org added the comment:
2.6 only gets security fixes. Can you reproduce the bug with current versions?
--
nosy: +eric.araujo
versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.6
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
Looks good. You’ll want to use assertEqual here:
self.assertTrue(1, len(file_list.files))
Do you want to patch filelist.py now?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
One buildbot also shows a bug in quiet or test_quiet:
Traceback (most recent call last):
File
D:\cygwin\home\db3l\buildarea\3.x.bolen-windows\build\lib\test\test_compileall.py,
line 227, in test_quiet
self.assertTrue(len(noise) len(quiet
Éric Araujo mer...@netwok.org added the comment:
I hadn’t seen your patch Michele. I find mine more readable:
http://pastealacon.com/26257 . That was just the easy part though; do you want
to write a test?
--
___
Python tracker rep
Éric Araujo mer...@netwok.org added the comment:
Jesús: There are a lot of literal \n in the current code, so I will assume that
they work for now and change them only if there is a bug report. Thanks for
noticing nonetheless.
--
___
Python
Éric Araujo mer...@netwok.org added the comment:
Thanks for the reply Martin. Tarek has pronounced in favor of this change, so
I will commit it tomorrow.
--
assignee: tarek - eric.araujo
components: +Distutils2
resolution: - accepted
status: open - pending
versions: +3rd party
Éric Araujo mer...@netwok.org added the comment:
Apologies, I had misread your message: I thought the keybinding was wrong but
working. Your fix should be committed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10404
Éric Araujo mer...@netwok.org added the comment:
Thanks. Do you want to work on a patch? We need to had a test to reproduce
the error and then fix the code.
--
nosy: +orsenthil
stage: - needs patch
type: - behavior
versions: +Python 3.1, Python 3.2 -Python 2.6
Éric Araujo mer...@netwok.org added the comment:
2.5 and 2.6 don’t get bug fixes anymore, only security fixes. If you want to
try to fix the code, there are some guidelines at
http://www.python.org/dev/patches/
--
___
Python tracker rep
Changes by Éric Araujo mer...@netwok.org:
--
assignee: - d...@python
components: +Documentation -Demos and Tools
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8890
Changes by Éric Araujo mer...@netwok.org:
--
nosy: -BreamoreBoy
resolution: accepted -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1475523
Éric Araujo mer...@netwok.org added the comment:
Looks good to me too. Steven, does this require a test?
--
nosy: +eric.araujo
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9509
Éric Araujo mer...@netwok.org added the comment:
No reply, closing.
--
resolution: - wont fix
stage: - committed/rejected
status: pending - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8561
Éric Araujo mer...@netwok.org added the comment:
This is related to the more general issue of how to report a wrong number of
arguments in a method call; I don’t remember if it was a python-dev discussion,
a python-ideas one or a bug report.
random is not the only module where instance
Éric Araujo mer...@netwok.org added the comment:
Thanks for the patch. I commented there.
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue940286
Changes by Éric Araujo mer...@netwok.org:
Removed file: http://bugs.python.org/file19696/unnamed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10461
Éric Araujo mer...@netwok.org added the comment:
I noticed in the output of pydoc that get_makefile_filename does not have a
docstring. I added one in my local copy (“Return the path of the Makefile.”)
and also removed “s” in verbs in other docstrings to comply with PEP 257.
Shall I commit
Éric Araujo mer...@netwok.org added the comment:
Patch looks good, thanks! Does it integrate Catherine’s tests?
--
components: +Library (Lib)
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
Patch for test_quiet looks good, thanks.
Do you want to write test_noargs?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
Éric Araujo mer...@netwok.org added the comment:
assertEquals is deprecated, I’ll change to assertEqual.
What filelist.py patch are you referring to? I've tested this on py3k
with no changes to filelist.py.
The goal of a test is to show an error so that it can be fixed. In this case
Éric Araujo mer...@netwok.org added the comment:
I don’t know enough of the test_argparse magic to assess the new test, but
Stephan, the author and maintainer of argparse, will certainly comment when he
gets some time. Thanks for the patch
Éric Araujo mer...@netwok.org added the comment:
sys.std* should not be used as default values in a function definition, because
they may be rebound to other objects. The usual idiom is to have None as
default value and check it at call time.
The patch also needs tests and docs.
(FTR
Éric Araujo mer...@netwok.org added the comment:
I will commit the patch this week unless someone opposes to it.
We still need a doc change as described in Terry’s original message.
--
assignee: d...@python - eric.araujo
resolution: - accepted
stage: needs patch - patch review
status
Éric Araujo mer...@netwok.org added the comment:
os.path.abspath actually checks for isabs first, so I think you can leave the
test out and always call abspath.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7325
Éric Araujo mer...@netwok.org added the comment:
Thank you. I uploaded your patch to Rietveld and reviewed it:
http://codereview.appspot.com/3169042/
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8525
Éric Araujo mer...@netwok.org added the comment:
“I also think the doc for 'class' should say that the default inheritance is
from the base class *object*”
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10366
Éric Araujo mer...@netwok.org added the comment:
Beware of UUOC: http://en.wikipedia.org/wiki/Cat_%28Unix%29#Useless_use_of_cat
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10494
Changes by Éric Araujo mer...@netwok.org:
--
resolution: accepted -
title: test_distutils fails on MacOSX 10.6 - test_distutils should honor
PYTHONDONTWRITEBYTECODE
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9831
Éric Araujo mer...@netwok.org added the comment:
Thanks, done as r86662 and [fbcddbb92b14].
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9877
Éric Araujo mer...@netwok.org added the comment:
Raymond: I made a single diff for easier review. I’m not 100% sure I should
change 'r' to 'rb' in logging: It’s unrelated to with, and the rest of the file
has not been checked for similar errors. I prefer to do commits that don’t mix
things
Changes by Éric Araujo mer...@netwok.org:
--
assignee: d...@python - eric.araujo
status: pending - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5088
New submission from Éric Araujo mer...@netwok.org:
I found two calls to gettext that are incorrect. See attached patch.
--
components: Library (Lib)
files: gettext-argparse.diff
keywords: patch
messages: 122068
nosy: bethard, eric.araujo
priority: normal
severity: normal
stage: patch
Changes by Éric Araujo mer...@netwok.org:
Removed file: http://bugs.python.org/file19375/unnamed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10200
Éric Araujo mer...@netwok.org added the comment:
test_quiet hopefully fixed in r86668.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10453
Éric Araujo mer...@netwok.org added the comment:
The patch actually already contained a doc change addressing Terry’s second
request, thank you Xuanji Li. I reverted the changes to howto as per Raymond’s
comment, made some other slight editions (like removing trailing whitespace
Éric Araujo mer...@netwok.org added the comment:
Not fixed:
http://www.python.org/dev/buildbot/all/builders/AMD64%20Windows%20Server%202008%203.x/builds/54/steps/test/logs/stdio
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
I like this version. HTML and LaTex build without warning; all-pdf takes
forever and spits out a metric ton of messages, so I haven’t checked its result.
The markup trickery is unfortunate, though, I’d like a pronouncement from Georg
about
Éric Araujo mer...@netwok.org added the comment:
Is this still relevant?
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7283
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9771
___
___
Python-bugs-list mailing list
Changes by Éric Araujo mer...@netwok.org:
--
assignee: d...@python - georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8416
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +d...@python -georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9264
___
___
Python
Éric Araujo mer...@netwok.org added the comment:
New features can only go into 3.2, so you have to test with an updated checkout
of the Subversion branch named py3k. See the link I have in a previous message.
(P.S. Would you be so kind as to edit quoted text out of your replies? It’s
Changes by Éric Araujo mer...@netwok.org:
--
stage: unit test needed - patch review
versions: +Python 2.7, Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue940286
Éric Araujo mer...@netwok.org added the comment:
Whatsnew documents are not edited after the corresponding release is done.
Using either /home/user or tempfile depending on the example seems good to me.
--
stage: needs patch - patch review
Éric Araujo mer...@netwok.org added the comment:
Review time!
+elif [ in text:
+self.matches = self.dict_key_matches(text)
Does this complete only dicts? What about other mappings? What about other
sequences implementing __getitem__? One of the function name
Éric Araujo mer...@netwok.org added the comment:
I tried to use “make patchcheck” after edits to reST files and it hung. Do you
have the same behavior? I suspect reindent-rst is the culprit.
I’m wondering about the reindenting; other checks in patchcheck don’t edit
files, they just print
Éric Araujo mer...@netwok.org added the comment:
Can you post on #10453? Thanks in advance.
--
nosy: +eric.araujo
resolution: - duplicate
stage: patch review - committed/rejected
status: open - closed
superseder: - Add -h/--help option to compileall
Changes by Éric Araujo mer...@netwok.org:
--
superseder: documentation for new SSL module - readline configuration for
shared libs w/o curses dependencies
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1676121
Éric Araujo mer...@netwok.org added the comment:
Thank you for the report. This is how I understand the part of the spec you
quoted: Strictly valid HTTP uses CRLF, but servers and clients should be
liberal in what they accept and deal with LF too. Senthil, do you agree
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +loewis
versions: -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10500
Éric Araujo mer...@netwok.org added the comment:
I am reviewing this and making some edits to the patch. Will post this week.
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2001
Éric Araujo mer...@netwok.org added the comment:
Does the plan include deprecating collections.Callable?
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10518
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10516
___
___
Python-bugs-list
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +benjamin.peterson, eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10520
Éric Araujo mer...@netwok.org added the comment:
LGTM.
--
assignee: - pje
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5800
___
___
Python-bugs
1 - 100 of 7396 matches
Mail list logo
