Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue45615>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
A side-effect of keeping tests inside the package, is that they appear in the
package contents module docstring, which may be slightly confusing to new users.
>>> import sqlite3
>>> help(sqlite3)
Help on package sqlite3:
NAME
sq
Erlend E. Aasland added the comment:
FYI, it is also possible to change the threaded mode using sqlite3_config(),
however that API is not exposed to the sqlite3 module, and there is no plans
for doing so in the near future :)
--
___
Python
Erlend E. Aasland added the comment:
BTW, I've verified that the overhead of adding this query is negligible.
$ python -m pyperf compare_to --min-speed 1 main.json patched.json
Benchmark hidden because not significant (1): sqlite_synth
git switch -
Switched to branch 'main'
$ ./python.exe
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue45614>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +27491
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/29227
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue45613>
___
___
Python-bugs-list mailing list
Unsub
Erlend E. Aasland added the comment:
> My understanding is that this entire class of code changes has been put on
> hold pending Steering Council approval.
Can you please point me to the official SC statement regarding this? I cannot
find it.
> It represents a great deal of c
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +27444
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/29171
___
Python tracker
<https://bugs.python.org/issu
New submission from Erlend E. Aasland :
Currently, we call _pysqlite_seterror() if sqlite3_open_v2() returns !=
SQLITE_OK. However, if a memory failure occurs during sqlite3_open_v2(), the
database handle is explicitly set to NULL. This _may_ cause
_pysqlite_seterror() to segfault, since we
Erlend E. Aasland added the comment:
New failure today:
https://github.com/python/cpython/runs/3979900415?check_suite_focus=true
test_sendfile_close_peer_in_the_middle_of_receiving
(test.test_asyncio.test_sendfile.SelectEventLoopTests) ... ok
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue45618>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
Pablo, can this be closed?
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue42545>
___
___
Pytho
Change by Erlend E. Aasland :
--
resolution: -> out of date
___
Python tracker
<https://bugs.python.org/issue40866>
___
___
Python-bugs-list mailing list
Un
Change by Erlend E. Aasland :
--
pull_requests: +27497
pull_request: https://github.com/python/cpython/pull/29234
___
Python tracker
<https://bugs.python.org/issue42
Erlend E. Aasland added the comment:
BTW, this only affects the code in main.
--
components: +Extension Modules
type: -> behavior
versions: +Python 3.11
___
Python tracker
<https://bugs.python.org/issu
New submission from Erlend E. Aasland :
In Modules/_sqlite/statement.c pysqlite_statement_create() and
Modules/_sqlite/cursor.c pysqlite_cursor_executescript_impl(), we incorrectly
use SQLITE_LIMIT_LENGTH to check statement length. However, the correct limit
is *SQLITE_LIMIT_SQL_LENGTH
Erlend E. Aasland added the comment:
I'm leaning towards alt 1. It is also easy to test all paths with that option.
But I also think alt 3 is ok. It makes for easier code to maintain.
Alt 2 is, as you say, the weakest alternative.
> What happens if set SQLITE_LIMIT_SQL_LENGTH t
Change by Erlend E. Aasland :
--
pull_requests: +27736
pull_request: https://github.com/python/cpython/pull/29485
___
Python tracker
<https://bugs.python.org/issue45
Change by Erlend E. Aasland :
--
pull_requests: +27737
pull_request: https://github.com/python/cpython/pull/29486
___
Python tracker
<https://bugs.python.org/issue45
Erlend E. Aasland added the comment:
> > What happens if set SQLITE_LIMIT_SQL_LENGTH to 0 [...]
In this case, the limit is actually zero:
>>> cx.setlimit(sqlite3.SQLITE_LIMIT_SQL_LENGTH, 0)
1024
>>> cx.execute("select 1")
Traceback (most rece
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +27740
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/29489
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
AC_CHECK_TYPE is obsolete and it's use is discouraged. There are some gotchas
we need to check before switching to AC_CHECK_TYPES.
See:
-
https://www.gnu.org/software/autoconf/manual/autoconf-2.70/html_node/Obsolete-Macros.html
-
https://www.gnu.org
Erlend E. Aasland added the comment:
Also, SQLITE_LIMIT_LENGTH and SQLITE_LIMIT_SQL_LENGTH is inclusive in SQLite.
We should treat them likewise.
--
___
Python tracker
<https://bugs.python.org/issue45
Erlend E. Aasland added the comment:
I believe it is best to go with alternative 1. The error strings produced by
SQLite may change from release to release, so for example a buildbot update may
suddenly break the CI.
--
___
Python tracker
<ht
Change by Erlend E. Aasland :
--
pull_requests: +27749
pull_request: https://github.com/python/cpython/pull/29500
___
Python tracker
<https://bugs.python.org/issue45
Erlend E. Aasland added the comment:
AC_SEARCH_LIBS() will search libc before checking external libraries, FWIW.
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue45
New submission from Erlend E. Aasland :
"Autoconfiscate" SQLite detection. Plan:
- Detect header/library using AC_CHECK_HEADERS/AC_CHECK_LIB
- Check required version using AC_COMPILE_IFELSE
- Use AC_CHECK_LIB to check if sqlite3_load_extension is present, and if the
result
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +27758
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/29507
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
Nice. I think I'll steal some of your ideas tomorrow :)
--
___
Python tracker
<https://bugs.python.org/issue45774>
___
___
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue45292>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
See also discussion on Discourse:
https://discuss.python.org/t/avoid-addressing-the-user-directly-when-writing-docs/11671
--
___
Python tracker
<https://bugs.python.org/issue45
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue45731>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
> Congratulations, and thanks for your work and determination to get this done
> :)
Thanks, and thank you for helping out, Petr :) Also a big thanks to Dong-hee,
Berker, Serhiy, Pablo, and Victor for reviews and guidance with this &q
Change by Erlend E. Aasland :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Erlend E. Aasland :
--
Removed message: https://bugs.python.org/msg405698
___
Python tracker
<https://bugs.python.org/issue1635741>
___
___
Python-bug
Change by Erlend E. Aasland :
--
Removed message: https://bugs.python.org/msg405713
___
Python tracker
<https://bugs.python.org/issue28124>
___
___
Python-bug
Change by Erlend E. Aasland :
--
Removed message: https://bugs.python.org/msg405706
___
Python tracker
<https://bugs.python.org/issue40257>
___
___
Python-bug
Change by Erlend E. Aasland :
--
Removed message: https://bugs.python.org/msg405711
___
Python tracker
<https://bugs.python.org/issue18458>
___
___
Python-bug
Change by Erlend E. Aasland :
--
components: -email
nosy: +Etienne Le Sueur, Russell.Jurney, jcea, mkleehammer, mrichman,
ned.deily, nneonneo, python-dev, ronaldoussoren -ahmedsayeed1982, barry,
r.david.murray
versions: -Python 3.11
___
Python
Change by Erlend E. Aasland :
--
nosy: +AdamGold, eric.araujo, gregory.p.smith, kj, lemburg, mcepl,
miss-islington, ned.deily, orsenthil, pablogsal, petr.viktorin, rschiron,
serhiy.storchaka, vstinner -ahmedsayeed1982
versions: +Python 3.10, Python 3.6, Python 3.7, Python 3.9
Change by Erlend E. Aasland :
--
components: +Interpreter Core -Argument Clinic
nosy: +Arach, Arfrever, Huzaifa.Sidhpurwala, Jim.Jewett, Mark.Shannon,
PaulMcMillan, Zhiping.Deng, alex, barry, benjamin.peterson, christian.heimes,
cvrebert, dmalcolm, eric.araujo, eric.snow, fx5
Change by Erlend E. Aasland :
--
Removed message: https://bugs.python.org/msg405707
___
Python tracker
<https://bugs.python.org/issue13703>
___
___
Python-bug
Erlend E. Aasland added the comment:
Yes, cleaning up ahmedsayeed1982 spam. I did my best to revert the nosy list,
component, versions, and assigned to changes. What did I mess up?
--
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
assignee: docs@python ->
components: +Interpreter Core, Subinterpreters -Documentation
nosy: +erlendaasland -ahmedsayeed1982, docs@python
versions: +Python 3.10 -Python 3.6
___
Python tracker
<
Change by Erlend E. Aasland :
--
nosy: +Jim Fasarakis-Hilliard, TCsaba, amaury.forgeotdarc, christian.heimes,
corona10, eric.snow, h-vetinari, isoschiz, koubaa, kylotan, lukasz.langa,
miss-islington, orsenthil, pconnell, petr.viktorin, phsilva, python-dev,
santoso.wijaya
Change by Erlend E. Aasland :
--
Removed message: https://bugs.python.org/msg405708
___
Python tracker
<https://bugs.python.org/issue34956>
___
___
Python-bug
Change by Erlend E. Aasland :
--
assignee: docs@python ->
components: +Documentation, SSL -Build
nosy: +cheryl.sabella, christian.heimes, docs@python, miss-islington
-ahmedsayeed1982
versions: +Python 3.8 -Python 3.7
___
Python tracker
<
Change by Erlend E. Aasland :
--
components: +macOS -Parser
nosy: +anthonypjshaw, dimpase, miss-islington, ned.deily, ronaldoussoren,
wordtech -ahmedsayeed1982, lys.nikolaou, pablogsal
versions: +Python 3.6, Python 3.8
___
Python tracker
<ht
Change by Erlend E. Aasland :
--
components: +Library (Lib) -Interpreter Core
nosy: +eamanu, gvanrossum, levkivskyi, lukasz.langa, mark.dickinson, mbussonn,
ncoghlan, serhiy.storchaka, tcaswell, terry.reedy, veky, xtreak -ahmedsayeed1982
versions: +Python 3.9 -Python 3.6
Change by Erlend E. Aasland :
--
Removed message: https://bugs.python.org/msg405710
___
Python tracker
<https://bugs.python.org/issue14001>
___
___
Python-bug
Change by Erlend E. Aasland :
--
components: +Library (Lib), XML -email
nosy: +Arfrever, dmalcolm, ezio.melotti, flox, iankko, loewis, neologix,
orsenthil, pitrou, python-dev, rosslagerwall, schmir -ahmedsayeed1982, barry,
r.david.murray
Change by Erlend E. Aasland :
--
Removed message: https://bugs.python.org/msg405709
___
Python tracker
<https://bugs.python.org/issue42967>
___
___
Python-bug
Change by Erlend E. Aasland :
--
Removed message: https://bugs.python.org/msg405705
___
Python tracker
<https://bugs.python.org/issue12419>
___
___
Python-bug
Change by Erlend E. Aasland :
--
components: +Library (Lib) -Installation
nosy: +flub, python-dev, vinay.sajip -ahmedsayeed1982
versions: -Python 3.6
___
Python tracker
<https://bugs.python.org/issue12
Erlend E. Aasland added the comment:
See bpo-12168 for a similar cleanup by Eryk Sun. There was approx. 20 spammed
issues. Eryk fixed most of them; I did a couple.
--
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
pull_requests: +27640
pull_request: https://github.com/python/cpython/pull/29382
___
Python tracker
<https://bugs.python.org/issue24
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue45743>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue45723>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
pull_requests: +27719
pull_request: https://github.com/python/cpython/pull/29466
___
Python tracker
<https://bugs.python.org/issue45
Erlend E. Aasland added the comment:
IMO, GH-29053 improves readability, mainly because of these factors:
- Argument Clinic now takes care of the ref count dance, and as a bonus, it is
more self-documenting (stating clearly that it accepts str and None)
- Begin statement validation has been
Erlend E. Aasland added the comment:
> 1) __APPLE_USE_RFC_3542 should have been in socketmodule.c from the start,
> not sure why it was added in setup.py.
FTR, it was added by me in bpo-35569, GH-19526. I moved the check to setup.py
because Ned made me do it :P
https://github.com/
Change by Erlend E. Aasland :
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue45748>
___
___
Python-bugs-list mailing list
Unsub
Change by Erlend E. Aasland :
--
nosy: +ned.deily -serhiy.storchaka
status: pending -> open
___
Python tracker
<https://bugs.python.org/issue45748>
___
___
Py
Erlend E. Aasland added the comment:
Python 3.6 is in security-fix only mode. I'm sorry, but I don't think this
counts as a security issue.
--
nosy: +erlendaasland
status: open -> pending
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
> What is wrong with addressing the reader as "you"?
I remember this was discussed on python-dev last year (?). IIRC, the majority
was in favour of changing the documentation to avoid addressing the reader
personally. Let us ask the
Change by Erlend E. Aasland :
--
pull_requests: +27609
pull_request: https://github.com/python/cpython/pull/29343
___
Python tracker
<https://bugs.python.org/issue45
Erlend E. Aasland added the comment:
(Nosying Mariatta and Carol from the CPython DWG)
--
nosy: +Mariatta, willingc
___
Python tracker
<https://bugs.python.org/issue45
Erlend E. Aasland added the comment:
Thanks for reviewing, Dong-hee!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Erlend E. Aasland :
--
pull_requests: +27596
pull_request: https://github.com/python/cpython/pull/29327
___
Python tracker
<https://bugs.python.org/issue10
New submission from Erlend E. Aasland :
The sqlite3 docs could need a little makeover. Here's some things that could be
improved:
- avoid addressing the reader as "you"
- avoid using affirmative tone
- establish a "Security Considerations" or "Common Mistakes"
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +27595
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/29326
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
Thanks, Petr. Yes, that is correct. PEP 630 (I assume you meant 630, not 640)
still describes the _rationale_ very well. I guess what's needed is a Standards
Track PEP based on PEP 630 (IIUC).
--
___
Python
Erlend E. Aasland added the comment:
Petr:
> Hmm, the best I can find is
> https://github.com/python/steering-council/blob/main/updates/2021-02-steering-council-update.md#february-08
Perfect, thanks!
Christian: Thanks for your input. If this was a discussion on Discourse, I'd
press
Erlend E. Aasland added the comment:
Oh, I found PEP 3121 (Extension Module Initialization and Finalization). It is
a Standards Track PEP and it is accepted.
The abstract is pretty short. Let me just repost it here, for convenience:
Extension module initialization currently has a few
New submission from Erlend E. Aasland :
Some DB-API 2.0 attributes are undocumented:
- apilevel
- threadsafety
- paramstyle
These attributes should be documented.
See also:
- bpo-8196
-
https://discuss.python.org/t/is-sqlite3-threadsafety-the-same-thing-as-sqlite3-threadsafe-from-the-c
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +27482
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/29219
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue37095>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Erlend E. Aasland :
Currently, the sqlite3 module docstring is the old pysqlite copyright comment
in the start of Lib/sqlite3/__init__.py. This is not very helpful to the
general user. Suggesting to add a more helpful docstring, a la the 're' or
'array' modules (those two
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +27488
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/29224
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
pull_requests: +27573
pull_request: https://github.com/python/cpython/pull/29304
___
Python tracker
<https://bugs.python.org/issue10
Erlend E. Aasland added the comment:
I'm unable to reproduce on macOS 11.6 as well (head at
49444fb807ecb396462c8e5f547eeb5c6bc5d4de).
--
___
Python tracker
<https://bugs.python.org/issue45
Erlend E. Aasland added the comment:
Also unable to reproduce with HEAD at 8a45ca542a65ea27e7acaa44a4c833a27830e796.
Perhaps it is related to your build/dev environment?
--
___
Python tracker
<https://bugs.python.org/issue45
Erlend E. Aasland added the comment:
Also unable to reproduce with HEAD at 49444fb807ecb396462c8e5f547eeb5c6bc5d4de.
--
___
Python tracker
<https://bugs.python.org/issue45
Erlend E. Aasland added the comment:
Unable to reproduce on macOS 12 with latest 3.11 official build, and my most
recent dev build (HEAD at b394af13f69c1a2ac0e7d32dabf6d86443606ab2).
--
nosy: +erlendaasland
___
Python tracker
<ht
Erlend E. Aasland added the comment:
Quoting msg407949:
> [...] We should do something like
>
> ZLIB_CFLAGS=${ZLIB_CFLAGS:-""}
> ZLIB_LIBS=${ZLIB_LIBS:-"-lz"}
>
> for all env vars.
I think we should use ${VAR-default} instead of ${VAR:-default}; we
Erlend E. Aasland added the comment:
The _testcapi modules should stay as it is, ref. msg384272 on bpo-40077:
Yes, please keep _testcapimodule.c as it is. Static types are still
supported and need to be tested.
--
nosy: +erlendaasland
resolution: -> not a bug
st
Erlend E. Aasland added the comment:
Reopening: the current detection is a little bit weak; many SQLite API's may be
disabled at SQLite compile time using SQLITE_OMIT_* defines. We must make sure
we've got all vital functions in place before marking the sqlite3 module as
present and usable
Change by Erlend E. Aasland :
--
pull_requests: +28240
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/30016
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
pull_requests: +28248
pull_request: https://github.com/python/cpython/pull/30024
___
Python tracker
<https://bugs.python.org/issue45
Erlend E. Aasland added the comment:
FWIW, the XCode SDKs for macOS 11 and 12 use the NetBSD editline library.
$ grep "NetBSD: readline"
/Library/Developer/CommandLineTools/SDKs/MacOSX*.sdk/usr/include/readline/readline.h
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/u
Change by Erlend E. Aasland :
--
pull_requests: +28254
pull_request: https://github.com/python/cpython/pull/30029
___
Python tracker
<https://bugs.python.org/issue45
Change by Erlend E. Aasland :
--
pull_requests: +28251
pull_request: https://github.com/python/cpython/pull/30026
___
Python tracker
<https://bugs.python.org/issue45
New submission from Erlend E. Aasland :
The sqlite3.Connection.create_collation() function limits collation names to
ASCII characters only. As sqlite3_create_collation_v2() (and
sqlite3_create_collation()) support UTF8, there is no need for this limitation
anymore.
See https://github.com
Change by Erlend E. Aasland :
--
pull_requests: +25818
pull_request: https://github.com/python/cpython/pull/27273
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25928
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27395
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue34828>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
Marked as a release blocker. See python-committers post:
https://mail.python.org/archives/list/python-committ...@python.org/thread/7OWGAL4UL5HNKKQFUGH6N6L4JDVPEN7R/
--
priority: normal -> release bloc
Change by Erlend E. Aasland :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
601 - 700 of 828 matches
Mail list logo