Filip Gruszczyński grusz...@gmail.com added the comment:
First draft of patch with this functionality. Test, patch and docs are
included. I'll gladly work further on this, so I would appreciate some advice
and suggestions.
--
keywords: +patch
nosy: +gruszczy
Added file: http
Filip Gruszczyński grusz...@gmail.com added the comment:
Test for releasing unacquired lock and aliasing exception.
--
keywords: +patch
nosy: +gruszczy
Added file: http://bugs.python.org/file20936/11140.patch
___
Python tracker rep...@bugs.python.org
Filip Gruszczyński grusz...@gmail.com added the comment:
But this is exactly how strptime in C. Consider this:
#include time.h
#include stdio.h
#include stdlib.h
#include string.h
int main(){
char buf[255];
struct tm tm;
memset(tm, 0, sizeof(tm));
strptime(123, %m%d
Filip Gruszczyński grusz...@gmail.com added the comment:
Here is a simple patch, that sets metadata version in PKG-INFO to 1.1, if finds
classifier or download_url parametres in setup. If it's any good, I'll try to
write a test. If not, I'll be happy to get some advice on how to provide
Filip Gruszczyński grusz...@gmail.com added the comment:
Amaury, could you elaborate a little more on this? I am pretty new to all this
and I would happily write the patch, if only you could give me some clue on how
I should approach
New submission from Filip Gruszczyński grusz...@gmail.com:
webbrowser module doesn't allow to open url in an unobtrusive way. Right now if
browser is minimized it is brought to the top. Furthermore if you browser is
already in the top, new tab is opened and user is moved to this top. It would
Filip Gruszczyński grusz...@gmail.com added the comment:
I have created a small patch, that introduces BadGzipFile exception. It is a
subclass of IOError, so it would be backward compatible and will be still
caught by old code, but this way is distinct from IOError.
--
keywords
Filip Gruszczyński grusz...@gmail.com added the comment:
Modified patch with test, that catches both BadGzipFile and IOError exceptions.
--
Added file: http://bugs.python.org/file16566/6584_2.patch
___
Python tracker rep...@bugs.python.org
http
Filip Gruszczyński grusz...@gmail.com added the comment:
I have created a small patch, that adds method that formats using a dict. It's
the first time I have written anything in python implementation, so I would
very appreciate any advice. Change allows the following:
m = Mapping(a='b
Filip Gruszczyński grusz...@gmail.com added the comment:
My first intention was simply to push mapping from args to kwargs, just like
Eric suggested, but that didn't help with __missing__, only with accepting a
dict instead of pushing keyword arguments.
I didn't like explicitly asking
Filip Gruszczyński grusz...@gmail.com added the comment:
Could you point me, where to add tests and documentation? I would happily add
those.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6081
Filip Gruszczyński grusz...@gmail.com added the comment:
Ok, unfortunately this code won't work for certain tests. Take those:
self.assertEqual(My name is {0}.format('Fred'), My name is Fred)
We pass only one argument, which is a dict and this won't satisfy such test. We
need to think
Filip Gruszczyński grusz...@gmail.com added the comment:
I have created a new patch, that should be satisfying now. There is help
(though it is quite small, I tried to mimic those that were already in
unicode.c) and tests. Right now format_using_mapping is called like
Filip Gruszczyński grusz...@gmail.com added the comment:
The bug is triggered by input, not by print. The exact place is
_PyUnicode_AsStringAndSize, where unicode check happens. Then print checks
PyError_Occured and catches this error. Either this error should not be raised
or should
Filip Gruszczyński grusz...@gmail.com added the comment:
The problem occurs in line in bltinmodule.c:
po = PyUnicode_AsEncodedString(stringpo,
_PyUnicode_AsString(stdout_encoding), NULL);
Where _PyUnicode_AsString returns NULL, since stdout_encoding
Filip Gruszczyński grusz...@gmail.com added the comment:
I have written a small patch, that solves the problem, but is disgusting. Could
anyone tell me, how I can get some default encoding from Python internals (I
have no idea where to look) and return it inside _PyUnicode_AsStringAndSize
Filip Gruszczyński grusz...@gmail.com added the comment:
Ok, I have found Py_FileDefaultSystemEncoding and use it, however I had to cast
it to (char *), because it's a const char *. Maybe I could do it better?
--
Added file: http://bugs.python.org/file16689/8256_2.patch
Filip Gruszczyński grusz...@gmail.com added the comment:
I have read, that I shouldn't directly use Py_FileSystemDefaultEncoding and
rather use PyUnicode_GetDefaultEncoding, so I have changed the code a little.
--
Added file: http://bugs.python.org/file16700/8256_3.patch
Changes by Filip Gruszczyński grusz...@gmail.com:
Removed file: http://bugs.python.org/file16688/8256_1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8256
Changes by Filip Gruszczyński grusz...@gmail.com:
Removed file: http://bugs.python.org/file16689/8256_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8256
Filip Gruszczyński grusz...@gmail.com added the comment:
Are you saying, that for example for this:
grusz...@gruszczy-laptop:~/Programs/logbuilder$ ./logbuilder --help
Usage: logbuilder [options] repo
Options:
--version show program's version number and exit
-h, --help
Filip Gruszczyński grusz...@gmail.com added the comment:
I'll take a look at optparse code and try to provide a patch. But first
holidays must finish and I must come back to ma usual residence, where I have
programming environment.
--
___
Python
Filip Gruszczyński grusz...@gmail.com added the comment:
Patch for optparse with tests. If it's ok, I'll sit down to argparse.
--
keywords: +patch
Added file: http://bugs.python.org/file16985/4256_1.patch
___
Python tracker rep...@bugs.python.org
Filip Gruszczyński grusz...@gmail.com added the comment:
I guess I am using my English too little, that's why I am using polish
expressions too often. What I meant was of course, that I will do argparse
patch too.
I haven't provided docs for --help-options yet, becuase it is not clear to me
Filip Gruszczyński grusz...@gmail.com added the comment:
Ok, here comes patch for argparse too.
--
Added file: http://bugs.python.org/file16996/4256_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4256
Filip Gruszczyński grusz...@gmail.com added the comment:
I'll be happy to both fix things pointed by Steven and try some other approach,
if that's required, but I would rather do it after a consesus is reached, so I
don't have to do the same stuff several times (changing argparse tests
Filip Gruszczyński grusz...@gmail.com added the comment:
So, is there any decision here, so that I could get down to providing better
patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4256
Filip Gruszczyński grusz...@gmail.com added the comment:
Bump! Is there anything happening about this bug? Is my patch any good or
should I try to work on something different?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Filip Gruszczyński grusz...@gmail.com added the comment:
I'll try to code a small test this evening.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8256
Filip Gruszczyński grusz...@gmail.com added the comment:
I have created some naive patch, that makes sqlite module raise
ProgrammingError for SQLITE_ERROR code. But I don't know, whether it
might raise ProgrammingError in situation, when OperationalError should be.
Sqlite docs says:
#define
Filip Gruszczyński grusz...@gmail.com added the comment:
I'll get down to it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8933
___
___
Python
Changes by Filip Gruszczyński grusz...@gmail.com:
Removed file: http://bugs.python.org/file20942/8933.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8933
Filip Gruszczyński grusz...@gmail.com added the comment:
Patch with tests. Hope this is enough.
--
Added file: http://bugs.python.org/file20956/8933.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8933
Filip Gruszczyński grusz...@gmail.com added the comment:
I'd be happy to provide a patch.
How about extending getopt api to something like this:
optlist, args = getopt.getopt(['-b'], 'e', not_recognized=no %s option,
mate!)
GetoptError: no -b option, mate!
Or maybe you should provide
Filip Gruszczyński grusz...@gmail.com added the comment:
One more solution. Maybe getopt should expose variables that hold error
messages (rather than have them hardcoded in the code), that can be simply
substituted by the user before he runs getopt? But I don't really like this one
Filip Gruszczyński grusz...@gmail.com added the comment:
I understand I should do something similar to what is done in argparse:
from gettext import gettext as _, ngettext
...
message = ngettext('conflicting option string: %s',
'conflicting option strings: %s
Filip Gruszczyński grusz...@gmail.com added the comment:
Here is a small patch. Could you advise me, how can I test it now? Or is it an
issue, that doesn't require writing new tests?
--
keywords: +patch
Added file: http://bugs.python.org/file20970/8841.patch
New submission from Filip Gruszczyński grusz...@gmail.com:
In http://bugs.python.org/issue8841 Eric asked to open a new ticket about
localisation of getopt error messages. I attach a patch.
--
files: 8841.patch
keywords: patch
messages: 129865
nosy: eric.araujo, gruszczy
priority
Filip Gruszczyński grusz...@gmail.com added the comment:
Here it is: http://bugs.python.org/issue11371
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8841
Filip Gruszczyński grusz...@gmail.com added the comment:
Yes, I have run
./python -m test -v test_getopt
and it was ok.
Running
xgettext --from-code utf-8 getopt.py
produces no output.
--
___
Python tracker rep...@bugs.python.org
http
Filip Gruszczyński grusz...@gmail.com added the comment:
Cool, thanks for all your advice.
--
status: pending - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11371
Changes by Filip Gruszczyński grusz...@gmail.com:
--
nosy: +gruszczy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1559549
___
___
Python-bugs
Filip Gruszczyński grusz...@gmail.com added the comment:
This is a draft of a patch. I have only used this new ImportError api in once
place, so it would work with following code:
try:
... import nosuchmodule
... except ImportError as e:
... print(e.module)
...
nosuchmodule
I have
Filip Gruszczyński grusz...@gmail.com added the comment:
I am sorry again for those mistakes, it's all completely new to me. I have
fixed those issues and created new patch. Using hg export, that now spans over
two commits. Is it the way those patches should be provided, or should I gather
Filip Gruszczyński grusz...@gmail.com added the comment:
Bump! How about applying this patch, Eric? Or maybe there is something else,
that needs to be done. If so, I'll be happy to do it.
--
___
Python tracker rep...@bugs.python.org
http
Filip Gruszczyński grusz...@gmail.com added the comment:
Sure :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8933
___
___
Python-bugs-list
Filip Gruszczyński grusz...@gmail.com added the comment:
Here is patch for distutils2. Or maybe you would prefer a patch made by hg
export?
--
Added file: http://bugs.python.org/file21095/disutils2_8933.patch
___
Python tracker rep
Filip Gruszczyński grusz...@gmail.com added the comment:
Bump! How about commiting this patch? Or maybe there is something missing? I'll
be happy to fix it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6584
Filip Gruszczyński grusz...@gmail.com added the comment:
I'll be very happy to fix this after Friday. Thanks for your comments.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6584
Filip Gruszczyński grusz...@gmail.com added the comment:
I had some time today, so I managed to fix the patch. I hope now everything is
ok.
--
Added file: http://bugs.python.org/file21209/6584_3.patch
___
Python tracker rep...@bugs.python.org
http
Filip Gruszczyński grusz...@gmail.com added the comment:
I didn't know about this mq extension. I will do a proper patch with a test
after friday.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1559549
Filip Gruszczyński grusz...@gmail.com added the comment:
Bump! Hi Eric, there was no negative feedback for two weeks. How about
commiting the patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11371
Changes by Filip Gruszczyński grusz...@gmail.com:
Removed file: http://bugs.python.org/file21020/1559549_1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1559549
Changes by Filip Gruszczyński grusz...@gmail.com:
Removed file: http://bugs.python.org/file21031/1559549_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1559549
Filip Gruszczyński grusz...@gmail.com added the comment:
Ok, here is a patch created using mq. I have a problem, however. I managed to
solve following situation:
try:
raise ImportError('failed import' module_name='somemodule')
except ImportError as e:
print(e.module_name)
that would
Filip Gruszczyński grusz...@gmail.com added the comment:
Well, since you are the designer of the package, I believe you have better
knowledge on how to extend it :-). I just provided a patch according to what
you described in the first message. Anyway having separate help formatter seems
Filip Gruszczyński grusz...@gmail.com added the comment:
Here is a test and a patch.
--
keywords: +patch
nosy: +gruszczy
Added file: http://bugs.python.org/file21426/9696.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Filip Gruszczyński grusz...@gmail.com added the comment:
Here is a simple patch with a test. Depending o bytes in this library seems
strange, maybe it should be changed somehow? Anyway, this simple patch should
be a quick fix to the problem.
--
keywords: +patch
nosy: +gruszczy
Added
New submission from Filip Gruszczyński grusz...@gmail.com:
xdrlib defines ConversionError, but very seldom uses it. For example:
def pack_float(self, x):
try: self.__buf.write(struct.pack('f', x))
except struct.error as msg:
raise ConversionError(msg
Filip Gruszczyński grusz...@gmail.com added the comment:
I believe this should be applied also against 3.3. I was working on this using
3.3 code base, so it is not working there too.
--
___
Python tracker rep...@bugs.python.org
http
Filip Gruszczyński grusz...@gmail.com added the comment:
I'm sorry, I wasn't hurrying you. Just wanted to make sure you know.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9696
Changes by Filip Gruszczyński grusz...@gmail.com:
--
nosy: +mark.dickinson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9544
___
___
Python-bugs
Changes by Filip Gruszczyński grusz...@gmail.com:
--
nosy: +gruszczy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11707
___
___
Python-bugs-list
Filip Gruszczyński grusz...@gmail.com added the comment:
Is following change in GzipFile class enough:
def read1(self, n):
return self.read(n)
? This satisfies TextIOWrapper to run readline correctly.
--
nosy: +gruszczy
___
Python
Changes by Filip Gruszczyński grusz...@gmail.com:
--
nosy: +gruszczy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11740
___
___
Python-bugs-list
Filip Gruszczyński grusz...@gmail.com added the comment:
The culprit seems to be Differ._fancy_replace. There is a nasty quadratic loop
there, that has pretty complex internal code. I have done a quick a fix, that
makes example run below a second at the expense of not calling _fancy_replace
Changes by Filip Gruszczyński grusz...@gmail.com:
--
nosy: +gruszczy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8905
___
___
Python-bugs-list
Filip Gruszczyński grusz...@gmail.com added the comment:
Check also this:
http://bugs.python.org/issue11740
--
nosy: +gruszczy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6931
Filip Gruszczyński grusz...@gmail.com added the comment:
Here is a patch that passes functools tests. I'll be happy to work on it
further.
--
keywords: +patch
Added file: http://bugs.python.org/file21504/11707.patch
___
Python tracker rep
Filip Gruszczyński grusz...@gmail.com added the comment:
Ok, here is patch that keep python implementation of cmp_to_key if C version
can't be imported.
Thanks again for you help :-)
--
Added file: http://bugs.python.org/file21505/11707_2.patch
Filip Gruszczyński grusz...@gmail.com added the comment:
I worked a little on the tests. Only then I have noticed, that cmp_to_key tests
weren't run, so I have encountered some problems, when I finally turned them
on. I have added some of my tests, fixed some things in the patch and now
Filip Gruszczyński grusz...@gmail.com added the comment:
Here are some example performance results:
def cmp(x, y):
return y - x
sorted(range(1, 1000), key=cmp_to_key(cmp))
'''
C version:
real0m19.994s
user0m8.053s
sys 0m1.044s
Python version:
real0m28.825s
user
Filip Gruszczyński grusz...@gmail.com added the comment:
I have a follow-up question: why keyobject_type needed traverse function? From
what I read in docs I assumed it is required for GC tracked types. Why was it
required here and how it is used
Filip Gruszczyński grusz...@gmail.com added the comment:
I see. Thanks :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11707
___
___
Python
Filip Gruszczyński grusz...@gmail.com added the comment:
Shouldn't this be your responsibility to close this descriptor in the object
used as self._factory? When self._factory is called it should read from the
file like object and then simply close it, just as get_message (when
self._factory
Filip Gruszczyński grusz...@gmail.com added the comment:
Here is a new patch, that uses with in __getitem__. I wonder, if we shouldn't
check for an AttributeError in case object returned by get_file doesn't have
__exit__ method, but does have close and use close instead of with. But it's
Filip Gruszczyński grusz...@gmail.com added the comment:
I am sorry. This is the first time I see contextlib and haven't understood,
that I should use a function from it. Here is a version with mock object having
close method and __getitem__ using contextlib.closing.
--
Added file
Filip Gruszczyński grusz...@gmail.com added the comment:
I have no idea how I should do this. If you explain to me, how it should be
done, I'll be happy to do this from now on :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Filip Gruszczyński grusz...@gmail.com added the comment:
Here it is.
--
keywords: +patch
Added file: http://bugs.python.org/file21588/11740.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6931
New submission from Filip Gruszczyński grusz...@gmail.com:
In argparse documentation parametres of add_subparsers are not listed. And yet
there are some really useful parametres like parser_class. It would be useful,
it they were described there well and one wouldn't have to look into the code
Changes by Filip Gruszczyński grusz...@gmail.com:
--
nosy: +bethard
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11807
___
___
Python-bugs-list
Filip Gruszczyński grusz...@gmail.com added the comment:
Here is a patch for this. I am not much of technical writer, so please be
patient with me. I tried to provide all the information about parameters, that
can be inferred from the code and experimenting. I have left out one parameter
Filip Gruszczyński grusz...@gmail.com added the comment:
Here is a patch that I made against distutils2 tip. I have changed
_FINAL_MARKER from 'f' to 'z', which works with rc. Also I have added constant
_FINAL_MARKER_CHAR, since later in the code you make a check against 'f' and it
surprised
Filip Gruszczyński grusz...@gmail.com added the comment:
Actually documentation doesn't say that it supports only bytes, but:
The following methods support packing strings, bytes, and opaque data:
Also under python2 you can easily do this:
In [1]: import xdrlib
In [2]: p = xdrlib.Packer
Filip Gruszczyński grusz...@gmail.com added the comment:
I am well aware of this, Benjamin. I am not trying to force any solution, but
rather trying to point out, that current documentation is misleading. There
might be no need for patching the code, but rather updating the docs to say
Filip Gruszczyński grusz...@gmail.com added the comment:
I'll provide docs patch.
--
assignee: - docs@python
components: +Documentation -None
nosy: +docs@python
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9544
Filip Gruszczyński grusz...@gmail.com added the comment:
The reason for the use of two constants is that previously there was comparison
in the code with a hardcoded 'f':
if postdev[0] == 'f':
I think it's a common practice to create constants for such hardcoded values.
Also
Filip Gruszczyński grusz...@gmail.com added the comment:
I understand that ML is mailing list, but I have no idea what is fellowship
mailing list. Could you elaborate on this?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Filip Gruszczyński grusz...@gmail.com added the comment:
Bump! How about commiting this patch, Eric?
--
status: pending - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8933
New submission from Filip Gruszczyński grusz...@gmail.com:
I have proposed on Core Mentorship list to add get(index, default) method to
list object. I was suggested to bring it up here and also told, that improving
operator module could be a better solution. This is why I would like to ask
Filip Gruszczyński grusz...@gmail.com added the comment:
Nick Coghlan suggested, that operator.getitem could be extended to accept
default value. How does it sound to you?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Filip Gruszczyński grusz...@gmail.com added the comment:
Patch with tests.
--
keywords: +patch
nosy: +gruszczy
Added file: http://bugs.python.org/file23906/13544.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13544
Filip Gruszczyński grusz...@gmail.com added the comment:
c.execute(insert into testdate values ('now'))
This works, but you actually are putting string now into a field with DATE
type. When conversion occurs after retrieving data, there is an error. Also if
you use datetime() function
Filip Gruszczyński grusz...@gmail.com added the comment:
I didn't know about `make patchcheck`, next time I will use it, thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13544
Filip Gruszczyński grusz...@gmail.com added the comment:
Fixed tests.
--
Added file: http://bugs.python.org/file23912/13544_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13544
Filip Gruszczyński grusz...@gmail.com added the comment:
I have written a patch and a test, but since it's changing C code, I am far
from being sure if it's achieve the expected behavior in the right way. There
are also tests and running whole test suite didn't bring any errors
Filip Gruszczyński grusz...@gmail.com added the comment:
Also: I'll be happy to work further on this patch, if I get some comments and
advice.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13521
Filip Gruszczyński grusz...@gmail.com added the comment:
Done.
--
Added file: http://bugs.python.org/file23918/13521_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13521
Filip Gruszczyński grusz...@gmail.com added the comment:
Pleasure :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13544
___
___
Python-bugs
Filip Gruszczyński grusz...@gmail.com added the comment:
I haven't given it much thought, when I was making the choice of using nonlocal
rather than self.count. I was rather excited to see, if the change will work as
I wanted it to. If you believe it would be better to use an attribute, I'll
1 - 100 of 133 matches
Mail list logo
