[issue9344] please add posix.getgrouplist()

2010-12-12 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Attached is a patch (against the latest revision, 87178) which adds the functionality to the posix module as well as adds a testcase for it. I haven't added it to the os module, I'm not sure if that should be done. I tested it on Linux

[issue6791] httplib read status memory usage

2010-12-15 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Attached is a unit test which tests the issue. Unfortunately, since it uses the resource module to limit memory to a workable size, it will only work on Unix. The given patch appears to fix the issue well. I think this should be taken

[issue6791] httplib read status memory usage

2010-12-15 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: A py3k patch against revision 87228. -- Added file: http://bugs.python.org/file20049/i6791_py3k.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6791

[issue6791] httplib read status memory usage

2010-12-15 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: That's true. Near the bottom of the code, it says: # The status-line parsing code calls readline(), which normally # get the HTTP status line. For a 0.9 response, however, this is # actually the first line of the body! Limiting

[issue10714] httpserver request length

2010-12-15 Thread Ross Lagerwall
New submission from Ross Lagerwall rosslagerw...@gmail.com: BaseHTTPRequestHandler in http.server does not limit the length of the request line so a malicious client can cause the server to run out of memory with a malicious request. This patch limits the length to 64K (like Apache) and sends

[issue10714] httpserver request length

2010-12-15 Thread Ross Lagerwall
Changes by Ross Lagerwall rosslagerw...@gmail.com: -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10714 ___ ___ Python-bugs-list

[issue10714] httpserver request length

2010-12-16 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: OK, here is an updated patch using threading 0 as a port number. -- Added file: http://bugs.python.org/file20076/httpserver_py3k_v2.patch ___ Python tracker rep...@bugs.python.org http

[issue10739] Subprocess behavior on Windows

2010-12-19 Thread Ross Lagerwall
New submission from Ross Lagerwall rosslagerw...@gmail.com: On Windows, creating a subprocess does not work when stdin (or stdout or stderr) is set as a file object created from socket.makefile(). An IOError is thrown. This works fine on Unix so I assume it is a platform limitation rather

[issue10739] Subprocess behavior on Windows

2010-12-19 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Attached is a patch to document this. -- keywords: +patch Added file: http://bugs.python.org/file20116/subprocessdoc.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue10739] Subprocess behavior on Windows

2010-12-20 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Since the code in subprocess gets the underlying fileno of the file-like object (line 819 of subprocess.py), I presume it is an example of the general problem of files and sockets not mixing very well on Windows. So, I have attached

[issue4761] create Python wrappers for openat() and others

2010-12-21 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Attached is a patch that adds: faccessat, fchmodat, fchownat, fstatat, futimesat, linkat, mkdirat, mknodat, openat, readlinkat, renameat, symlinkat, unlinkat, utimensat and mkfifoat. Each function has documentation and a unit test

[issue4761] create Python wrappers for openat() and others

2010-12-21 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Attached is an updated patch which: - fixes badly indented C code - uses support.unlink consistently - cleans up tests better using finally -- Added file: http://bugs.python.org/file20133/i4761_v2.patch

[issue4761] create Python wrappers for openat() and others

2010-12-21 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Ok, attached is a patch with the documentation updated as per recommendation. -- Added file: http://bugs.python.org/file20135/i4761_v3.patch ___ Python tracker rep...@bugs.python.org http

[issue10755] Add posix.fdlistdir

2010-12-21 Thread Ross Lagerwall
New submission from Ross Lagerwall rosslagerw...@gmail.com: Along with #4761, the *at wrappers, it would be nice to have a patch adding the use of fdopendir. This patch adds a function fdlistdir, a unittest and documentation. -- components: Extension Modules files: i_fdlistdir.patch

[issue10755] Add posix.fdlistdir

2010-12-22 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: When maintaining an fd to implement a per thread current directory, you can use it to get a list of files in the directory. For security reasons, instead of a named path, you can keep an fd to a directory so that if the path is changed

[issue4761] create Python wrappers for openat() and others

2010-12-22 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: New patch *should* have fixed up reference counting and version tags. I standardized all the error calls to posix_error. -- Added file: http://bugs.python.org/file20137/i4761_v4.patch

[issue4761] create Python wrappers for openat() and others

2010-12-22 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: This new patch has proper octal mode strings and another doc update. I'll leave faccessat until #10758 has been resolved. -- Added file: http://bugs.python.org/file20138/i4761_v5.patch

[issue10758] posix_access swallows all errors

2010-12-22 Thread Ross Lagerwall
Changes by Ross Lagerwall rosslagerw...@gmail.com: -- nosy: +rosslagerwall ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10758 ___ ___ Python-bugs

[issue10755] Add posix.fdlistdir

2010-12-22 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Hi, Attached is a slightly updated patch that improves doc and changes fdlistdir to always return strings, not bytes. -- Added file: http://bugs.python.org/file20145/i10755.patch ___ Python

[issue10784] os.getpriority() and os.setpriority()

2010-12-27 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Patch looks good, just one thing: In setpriority(), it should be possible to use the Py_RETURN_NONE; macro instead of INCREFing manually. -- components: +Extension Modules nosy: +rosslagerwall type: - feature request

[issue7995] On Mac / BSD sockets returned by accept inherit the parent's FD flags

2010-12-30 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Attached is a patch (the original one in patch form) against py3k with unit test. It seems to work well - tested on Linux FreeBSD. -- keywords: +patch nosy: +rosslagerwall Added file: http://bugs.python.org/file20201/7995_v1

[issue7322] Socket timeout can cause file-like readline() method to lose data

2010-12-31 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Attached is a patch which fixes the issue. Instead of allowing the readline method to lose data, it adds a check to SocketIO.readinto() to ensure that the socket does not have a timeout and throws an IOError if it does. Also does

[issue7322] Socket timeout can cause file-like readline() method to lose data

2010-12-31 Thread Ross Lagerwall
Changes by Ross Lagerwall rosslagerw...@gmail.com: -- nosy: +loewis, pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7322 ___ ___ Python-bugs

[issue7995] On Mac / BSD sockets returned by accept inherit the parent's FD flags

2010-12-31 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: issue1515839 seems to be a duplicate of this one. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7995

[issue7995] On Mac / BSD sockets returned by accept inherit the parent's FD flags

2010-12-31 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: From what I coud see, the same applied to NetBSD so I enabled it for NetBSD as well - if there are any other OSes that need it enabled, they can be added. The updated patch checks for fcntl() failing and simply leaves the socket

[issue5870] subprocess.DEVNULL

2011-01-01 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Here is a fairly simple patch that adds the subprocess.DEVNULL constant. -- keywords: +patch nosy: +rosslagerwall versions: +Python 3.3 -Python 2.7 Added file: http://bugs.python.org/file20215/5870_v1.patch

[issue9905] subprocess.Popen fails with stdout=PIPE, stderr=PIPE if standard descriptors (0, 1, 2) are closed.

2011-01-02 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: OK here is a patch + tests. Basically, it makes sure that the fd that it is closing is not 0, 1 or 2. I've set it for 2.7, 3.1 and 3.2. -- keywords: +patch nosy: +rosslagerwall versions: +Python 2.7, Python 3.1, Python 3.2

[issue5870] subprocess.DEVNULL

2011-01-02 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: I think if you look closely at the patch, the fd does not stay open the whole time. It is opened if necessary in _get_handles() with e.g.: elif stdin == DEVNULL: p2cread = self._get_devnull() and then closed in _execute_child

[issue7995] On Mac / BSD sockets returned by accept inherit the parent's FD flags

2011-01-02 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: OK try this one, it's now opt-out. -- Added file: http://bugs.python.org/file20222/7995_v3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7995

[issue10806] Subprocess error if fds 0,1,2 are closed

2011-01-02 Thread Ross Lagerwall
New submission from Ross Lagerwall rosslagerw...@gmail.com: There is an issue where if a python program closes all the std. file descriptors (e.g. a daemon) and then uses the subprocess module, the file descriptors may not be set up properly in the subprocess. This may actually be a fairly

[issue10806] Subprocess error if fds 0,1,2 are closed

2011-01-02 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Updated patch for debug mode. Does this also need to be applied for 3.1? -- Added file: http://bugs.python.org/file20228/subprocess_v2.patch ___ Python tracker rep...@bugs.python.org http

[issue10812] Add some posix functions

2011-01-03 Thread Ross Lagerwall
New submission from Ross Lagerwall rosslagerw...@gmail.com: Here's a patch that adds a bunch of posix functions that are missing from the posix module. Includes tests documentation. Tested on Linux FreeBSD. Specifically: futimes lutimes futimens fexecve

[issue6800] os.exec* raises OSError: [Errno 45] Operation not supported in a multithreaded application

2011-01-03 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: I tested this on FreeBSD 8.1 - it outputs 'hello world'. I think this should be closed - i think the os.exec* functions should mirror the operating system exec* functions. If the platform has a limitation then so be it. And it seems

[issue9344] please add posix.getgrouplist()

2011-01-03 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: A slightly updated patch. Targeting for 3.3. -- versions: +Python 3.3 -Python 3.2 Added file: http://bugs.python.org/file20253/9344_v2.patch ___ Python tracker rep...@bugs.python.org http

[issue8052] subprocess close_fds behavior should only close open fds

2011-01-04 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Does this mean that it's better to call the close() syscall 1000 or 1000 times rather than listing the open fds closing say a handful? On Linux, the listdir function results in an open() syscall, 2 or so getdents() calls

[issue10812] Add some posix functions

2011-01-04 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: This patch: Fixes test_lutimes(), Ignores a posix_fallocate() failure on Solaris due to ZFS, Changes readv() writev() signatures such that they take sequences instead of tuples, Changes readv() so that it takes a number of writable

[issue4489] shutil.rmtree is vulnerable to a symlink attack

2011-01-05 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Here is a draft patch. It uses the *at functions and fdlistdir consequently it only makes it safe if those functions are available. It works using a recursive implementation and an open file descriptor pointing to a directory, instead

[issue4489] shutil.rmtree is vulnerable to a symlink attack

2011-01-05 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Updated patch removes the race condition. Since an open follows symlinks, you can't just fstat the fd to see if it is a link. I followed the following to overcome this: https://www.securecoding.cert.org/confluence/display/seccode/POS35

[issue4489] shutil.rmtree is vulnerable to a symlink attack

2011-01-05 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: I think I misread the original implementation. Here is an updated version with that code just taken out. -- Added file: http://bugs.python.org/file20279/i4489_v3.patch ___ Python tracker rep

[issue10812] Add some posix functions

2011-01-06 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: This new patch reuses iov allocation code between readv writev. It reuses code between exec, execve fexecve. It reuses code for parsing off_t types. I've tried where possible to reuse code but I think though that the code seems pretty

[issue10812] Add some posix functions

2011-01-07 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: it's a bit asymmetric that gethostname is in the socket module and supports Windows, and sethostname is in the POSIX module. It would be useful to have a gethostname in the POSIX module also which is a) POSIX only and b) supports

[issue10812] Add some posix functions

2011-01-07 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Thanks for the comments. I implemented sethostid() - its not actually in the posix spec, but linux/*bsd have it although the signature for FreeBSD is a bit different. I implemented gethostname(). Both get/sethostname() now use FSDefault

[issue10812] Add some posix functions

2011-01-07 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: This patch takes out sethostname() and gethostname(). I'll open up a new issue to add sethostname() to the socket module. -- Added file: http://bugs.python.org/file20311/10812_v5.patch

[issue10866] Add sethostname()

2011-01-08 Thread Ross Lagerwall
New submission from Ross Lagerwall rosslagerw...@gmail.com: This patch adds sethostname to the socket module (since socket has gethostname()). -- components: Library (Lib) files: sethostname.patch keywords: patch messages: 125761 nosy: giampaolo.rodola, loewis, rosslagerwall priority

[issue10822] test_getgroups failure under Solaris

2011-01-10 Thread Ross Lagerwall
Changes by Ross Lagerwall rosslagerw...@gmail.com: -- nosy: +rosslagerwall ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10822 ___ ___ Python-bugs

[issue10882] Add os.sendfile()

2011-01-10 Thread Ross Lagerwall
New submission from Ross Lagerwall rosslagerw...@gmail.com: Attached is a patch which implements os.sendfile for unix systems (linux, freebsd, apple, solaris, dragonfly). It takes the iov initialization code and off_t parsing from i10812. It encapsulates all the functionality from the various

[issue10882] Add os.sendfile()

2011-01-10 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Ok, I figured it out to link with sendfile on solaris. Here is the updated patch. -- Added file: http://bugs.python.org/file20352/sendfile_v2.patch ___ Python tracker rep...@bugs.python.org

[issue10822] test_getgroups failure under Solaris

2011-01-10 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: It seems to work fine on OpenIndiana (running normally or as root). According to the posix specification, It is implementation-defined whether getgroups() also returns the effective group ID in the grouplist array. But, id -G prints

[issue4112] Subprocess: Popen'ed children hang due to open pipes

2011-01-11 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: This issue has been fixed on 3.2. -- nosy: +rosslagerwall versions: -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4112

[issue10885] multiprocessing docs

2011-01-11 Thread Ross Lagerwall
New submission from Ross Lagerwall rosslagerw...@gmail.com: I think there is a small docs bug: it says that multiprocessing.Semaphore is a bounded semaphore. Shouldn't it says that it is just a semaphore. Attached is a patch to fix this. -- components: Library (Lib) files

[issue10882] Add os.sendfile()

2011-01-11 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Just to be clear: There are 3 different interfaces. The basic one with the offset included no headers/trailers is supported by all the platforms, including Linux. The one with offset as None is only supported by Linux. The one

[issue10882] Add os.sendfile()

2011-01-11 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: I've just tried it against r87935 and it applies cleanly. Perhaps you didn't apply the patch correctly (it requires -p1 since it was a Mercurial diff), try: patch -p1 sendfile_v2.patch With regards to the different arguments, I

[issue10885] multiprocessing docs

2011-01-11 Thread Ross Lagerwall
Changes by Ross Lagerwall rosslagerw...@gmail.com: -- assignee: - d...@python components: +Documentation nosy: +d...@python ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10885

[issue10882] Add os.sendfile()

2011-01-11 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Oh sorry, that was because it changed configure.in so autoreconf needs to be run to regenerate configure pyconfig.h.in. I thought that patches weren't meant to include the regenerated files. Especially since differences

[issue7322] Socket timeout can cause file-like readline() method to lose data

2011-01-13 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: How about this? Instead of just losing the data that's been read so far in readline(), this patch adds the data as a new field to the exception that is thrown - this way the semantics remain exactly the same but the data

[issue7322] Socket timeout can cause file-like readline() method to lose data

2011-01-13 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: That complicates things quite a bit, especially given that it has to be grafted on at least two layers of the IO stack (the raw IO layer, and the buffered IO layer). Also the TextIO layer I think. That's my opinion too. So, instead

[issue7322] Socket timeout can cause file-like readline() method to lose data

2011-01-13 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Attached patch disallows further reads after a timeout. -- Added file: http://bugs.python.org/file20398/i7322.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7322

[issue1535504] CGIHTTPServer doesn't handle path names with embeded space

2011-01-14 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Shouldn't this be closed? CGIHTTPServer *has* been updated to use subprocess on windows and the dependency has been closed as wont fix. -- nosy: +rosslagerwall ___ Python tracker rep

[issue1227748] subprocess: inheritance of std descriptors inconsistent

2011-01-14 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: I think all that is needed is a documentation patch. Attached is a doc patch which changes the doc to explicitly describe what happens on unix windows (as described by Peter). -- components: +Documentation keywords: +patch

[issue9532] pipe.read hang, when calling commands.getstatusoutput in multi-threading code of python 2.4

2011-01-15 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: After trying to reproduce this bug in 2.7.1 3.2b2 and failing, I think this should be closed (even the OP couldn't reproduce it in anything other than 2.4). -- nosy: +rosslagerwall

[issue10916] mmap segfault

2011-01-15 Thread Ross Lagerwall
New submission from Ross Lagerwall rosslagerw...@gmail.com: If a mmap length 0 is used and an offset is used as well, the size to mmap() is calculated as the size of the file instead of the size of the file minus offset. This means that trying to access a certain part does not result

[issue2644] errors from msync ignored in mmap_object_dealloc

2011-01-17 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: I think this can be closed. msync() is only called in mmap.flush() and it is checked for an error. -- nosy: +rosslagerwall ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue4681] mmap offset should be off_t instead of ssize_t, and size calculation needs corrected

2011-01-17 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Attached is a fix to make offset use off_t. This means that mmap will work with offset 2GB on 32bit systems. It also fixes that mmap.size() returns the correct value for files 2GB on 32bit systems. The first issue of msg78055

[issue10451] memoryview can be used to write into readonly buffer

2011-01-18 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: From what I can see, this issue is in memoryview and allows memoryview to export a readonly buffer as writable (because memoryview.getbuffer() removes the writable flag from flags before calling the underlying buffer). This causes

[issue10451] memoryview can be used to write into readonly buffer

2011-01-18 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Attached is an updated patch with a simpler test. -- Added file: http://bugs.python.org/file20440/i10451_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10451

[issue10451] memoryview can be used to write into readonly buffer

2011-01-18 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: And a simple fix for the test_getargs2 test - it wraps the memoryview around a bytearray. -- Added file: http://bugs.python.org/file20441/testfix.patch ___ Python tracker rep

[issue6059] uuid.uuid4 cause segfault in emesene

2011-01-19 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: I tried to reproduce the bug on 2.7 3.2 using libuuid version 2.17.2 and up to 100 threads but couldn't. Perhaps there was an issue with the uuid library function that he was using and threading? -- nosy: +rosslagerwall

[issue4761] create Python wrappers for openat() and others

2011-01-20 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Fixed small #ifdef error with fstatat. -- Added file: http://bugs.python.org/file20460/i4761_v6.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4761

[issue10812] Add some posix functions

2011-01-20 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: A few small fixes for OS X: It has no return value for sethostid() and sets different errno if permission denied, waitid() is broken - so its disabled, the timeval struct used in futimes and lutimes is defined slightly differently

[issue10959] mmap crash

2011-01-20 Thread Ross Lagerwall
New submission from Ross Lagerwall rosslagerw...@gmail.com: The fix for issue10916 commited in r88022 introduces this line: map_size = st.st_size - offset; If offset st.st_size, map_size is negative. This should cause the mmap system call to return -1 and set errno. However, given a certain

[issue4216] subprocess.Popen hangs at communicate() when child exits

2011-01-21 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Yes I think subprocess is working correctly. Since this feature request is 2 years old now without any interest, I think it should be closed. If the functionality is needed, it can always be programmed by the user when needed

[issue5885] uuid.uuid1() is too slow

2011-01-22 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Attached is a patch based on the original patch, meant to have better performance. On my PC, this: import sys, time, uuid def uu(n): t = time.time() for x in range(n): uuid.uuid1() print('%.3f microseconds

[issue10882] Add os.sendfile()

2011-01-28 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Attached is a new sendfile patch which fixes the issue with FreeBSD (and Mac OS X DragonFly BSD from what I can see). With regards to anacrolix's request, I think what Martin said in msg126049. i.e. if we want to provide a unifying

[issue10882] Add os.sendfile()

2011-01-28 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Attached is an updated patch that uses keyword arguments. Using an offset with Linux was always supported although I have cleaned up the documentation a bit to make that clearer. E.g. the following script sends part of a file over

[issue10882] Add os.sendfile()

2011-01-28 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: OK, updated documentation and tests. Why special case these? Why can't Mac OS X and FreeBSD write those manually into the output file descriptor. These can be a crucial part of certain protocols such as HTTP to ensure that a minimal

[issue9127] subprocess.Popen.communicate() and SIGCHLD handlers

2011-02-02 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: This has been fixed in 2.7 and 3.2 so I think that this issue can be closed. -- nosy: +rosslagerwall ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9127

[issue7678] subprocess.Popen pipeline example code in the documentation is lacking

2011-02-03 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: The docs should be updated. This has been noted in msg54949 and http://www.enricozini.org/2009/debian/python-pipes/ Perhaps this example will make it clear: import subprocess p1 = subprocess.Popen([yes], stdout=subprocess.PIPE) p2

[issue10882] Add os.sendfile()

2011-02-05 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: For trailers to work, I think the line: self.assertEqual(data, abcde12345) should be: self.assertEqual(data, babcde12345) Also not that tests like this: if not sys.platform.startswith('linux'): perhaps should also include solaris

[issue10882] Add os.sendfile()

2011-02-06 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: With no changes, I get: == FAIL: test_trailers (test.test_os.TestSendfile) -- Traceback (most recent

[issue4681] mmap offset should be off_t instead of ssize_t, and size calculation needs corrected

2011-02-09 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: OK, this new patch applies cleanly, uses support.unlink and hexadecimal constants. I left the off_t handling as is (it seems to work on *nix testing). Perhaps someone can handle the Windows side? -- Added file: http

[issue10882] Add os.sendfile()

2011-02-09 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: OK, I'm happy to not return the file offset. However, I still think that headers and trailers should remain as is since this matches the native interface very closely. -- ___ Python tracker

[issue4681] mmap offset should be off_t instead of ssize_t, and size calculation needs corrected

2011-02-09 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: will this patch support off_t for mmap.resize as well? ftruncate uses off_t for the length of a file as well. No, it doesn't because resize() resizes the amount mmapped in memory which can't be more than ssize_t anyway. However

[issue4681] mmap offset should be off_t instead of ssize_t, and size calculation needs corrected

2011-02-10 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: 32-bit computers can address up to 4GiB of memory and 64-bit computers can address much more than this. mmap() allows a file to be mapped to a location in memory - the actual amount of memory that exists doesn't matter

[issue10882] Add os.sendfile()

2011-02-22 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Yes I agree it can go in now. Unless someone wants to do some tests on more OS's like FreeBSD 7.2, Solaris, etc. (I've only checked on Linux 2.6, FreeBSD 8.1, OpenIndiana and OS X 10.5

[issue10866] Add sethostname()

2011-02-26 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Here is a simplified version. -- Added file: http://bugs.python.org/file20904/sethostname_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10866

[issue10866] Add sethostname()

2011-02-26 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: The patch looks good. Just to be clear, on my system running autoreconf adds the correct stuff to pyconfig.h.in Isn't it best to leave it up to the committer to generate configure and pyconfig.h.in, especially since different autoconf

[issue10866] Add sethostname()

2011-02-26 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Ah, strange. I used autoconf and it didn't... From the man page of autoreconf: Run `autoconf' (and `autoheader', `aclocal', `automake', `autopoint' (formerly `gettextize'), and `libtoolize' where appropriate) repeatedly

[issue11372] Remove xrange from argparse docs

2011-03-02 Thread Ross Lagerwall
New submission from Ross Lagerwall rosslagerw...@gmail.com: As the title says, this patch replaces xrange with range for the 3.3 docs. -- assignee: docs@python components: Documentation files: doc.patch keywords: patch messages: 129876 nosy: docs@python, rosslagerwall priority: normal

[issue11404] support /dev/null for subprocess.call() and friends

2011-03-05 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: I think this is a duplicate of issue5870. -- nosy: +rosslagerwall ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11404

[issue11454] urllib.request import time

2011-03-09 Thread Ross Lagerwall
New submission from Ross Lagerwall rosslagerw...@gmail.com: While importing most modules has little effect on the start up time, importing urllib.request seems to take a considerable time. E.g.: without importing urllib.request: real0m0.072s user0m0.070s sys 0m0.000s with importing

[issue11454] urllib.request import time

2011-03-09 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: Ubuntu 10.10. I haven't investigated whether it is actually urllib.request that is causing the long import time or a module that it is dependent on. -- ___ Python tracker rep

[issue11459] Python select.select does not correctly report read readyness

2011-03-10 Thread Ross Lagerwall
Changes by Ross Lagerwall rosslagerw...@gmail.com: -- nosy: +rosslagerwall ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11459 ___ ___ Python-bugs

[issue11454] urllib.request import time

2011-03-10 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: OK, running this: import base64 import bisect import hashlib import io import os import posixpath import random import re import socket import sys import time import collections import io import os import socket import collections import

[issue11454] email.message import time

2011-03-11 Thread Ross Lagerwall
Changes by Ross Lagerwall rosslagerw...@gmail.com: -- title: urllib.request import time - email.message import time ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11454

[issue10885] multiprocessing docs

2011-03-14 Thread Ross Lagerwall
Changes by Ross Lagerwall rosslagerw...@gmail.com: -- assignee: docs@python - rosslagerwall resolution: - fixed stage: - committed/rejected status: open - closed versions: +Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue11459] Python select.select does not correctly report read readyness

2011-03-15 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: The Charles' patch fixes the problem but breaks [test_os test_poll test_popen test_select test_uuid] when running make test. Those two lines were introduced by Guido in [1f7891d84d93] but that was back in 2007 when subprocess used

[issue10812] Add some posix functions

2011-03-16 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: PyParse_off_t was already added when sendfile() was added as was the iovec_setup stuff. I'll upload a patch soon which updates it to take this and the other comments into account

[issue11459] Python select.select does not correctly report read readyness

2011-03-16 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: to get that behavior, change the =1 default to =io.DEFAULT_BUFFER_SIZE in ross's patch. The problem is, it doesn't seem like you can import and use io.DEFAULT_BUFFER_SIZE from inside os.py. Python fails to start. You can import

[issue5870] subprocess.DEVNULL

2011-03-16 Thread Ross Lagerwall
Changes by Ross Lagerwall rosslagerw...@gmail.com: -- assignee: gregory.p.smith - rosslagerwall resolution: - accepted stage: needs patch - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue10812] Add some posix functions

2011-03-16 Thread Ross Lagerwall
Ross Lagerwall rosslagerw...@gmail.com added the comment: This new patch, updated against the tip for 3.3: Shares the iov_setup and iov_cleanup code, py_parse_off_t with sendfile(). Removes gethostid and sethostid since they're deprecated. I think I was correct with referring to utime() since

  1   2   3   4   >