[issue21914] Create unit tests for Turtle guionly
Lita Cho added the comment: Feel free. On Tue, Jun 26, 2018, 3:21 AM RAJALAKSHMI V wrote: > > RAJALAKSHMI V added the comment: > > Hey, I am a new contributor here. Could I take this issue up? > > -- > nosy: +RAJALAKSHMI V > > ___ > Python tracker > <https://bugs.python.org/issue21914> > ___ > -- ___ Python tracker <https://bugs.python.org/issue21914> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Lita Cho added the comment: Here is a patch after SlientGhost's review. I have added back the newline and included the comments for the imaplib documentation. -- Added file: http://bugs.python.org/file41395/imaplib_after_silentghost_review.patch ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Lita Cho added the comment: Sounds good. On Tuesday, December 22, 2015, Maciej Szulik wrote: > > Maciej Szulik added the comment: > > Lita can you please apply the changes from latest review (from > SilentGhost). Especially the one regarding newline, which currently fails > to apply this patch on default. If all those will be cleaned I'll recommend > this patch for David for inclusion. > > -- > > ___ > Python tracker > > <http://bugs.python.org/issue21815> > ___ > -- ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Lita Cho added the comment: Applied the changes that berkerpeksag made. Please review, and let me know if further changes need to be made. -- Added file: http://bugs.python.org/file41366/imaplib_after_review.patch ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Lita Cho added the comment: Had some trouble setting up my dev environment for Python. Definitely going to work on it today and tomorrow. On Tue, Dec 8, 2015 at 12:33 PM, Maciej Szulik wrote: > > Maciej Szulik added the comment: > > Perfect, thanks! > > -- > > ___ > Python tracker > <http://bugs.python.org/issue21815> > ___ > -- ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Lita Cho added the comment: I apologize, I completely forgot. I will do it this week. Thanks for the reminder! -- ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Lita Cho added the comment: Hi Maciej, I am not seeing berkerpeksag review...? What was his comment? I apologize, but I haven't used the bug tracker in awhile. -- ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Lita Cho added the comment: Here is the patch merged together. I apologize for not getting it to you sooner. -- Added file: http://bugs.python.org/file37245/imaplib_bracket_fix.patch ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Lita Cho added the comment: Sure, let me combine it into one change. -- ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1186900] nntplib shouldn't raise generic EOFError
Lita Cho added the comment: Thank yo so much, Martin! I will incorporate these changes and add them soon! -- ___ Python tracker <http://bugs.python.org/issue1186900> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21585] Run Tkinter tests with wantobjects=False
Lita Cho added the comment: Hi Terry, I had no idea we were moving away from using test_main. So instead, of using support.run_unittest, we should import all the unittest from tkinter/test/ and wrap everything with that exec method, setting wantobjects=1 and again with wantobjects=0? Also, do you have an example of a unit test that doesn't use test_main? All the unit tests I've seen (tkinter, smtplib, nntplib) all use test_main. Lita -- ___ Python tracker <http://bugs.python.org/issue21585> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21933] Allow the user to change font sizes with the text pane of turtledemo
Lita Cho added the comment: ping! -- ___ Python tracker <http://bugs.python.org/issue21933> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Lita Cho added the comment: pinging for another review. I have included tests for the patch as well as documentation! -- ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21585] Run Tkinter tests with wantobjects=False
Lita Cho added the comment: Hi Serhiy, This patch was made while I was learning tkinter. I figured out how to run the tests twice while changing wantobjects variable without creating new tests. Fortunately, all the tests seem to fast when wantobjects is 0 or 1. The only annoying thing is that it doesn't merge the count of the amount of tests ran within that module, since I am calling support.run_unittest twice. Hopefully, that's okay. Otherwise, I need to figure out how to call the tests twice individually within the generator. -- Added file: http://bugs.python.org/file36291/wantobj_test.patch ___ Python tracker <http://bugs.python.org/issue21585> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21991] The new email API should use MappingProxyType instead of returning new dicts.
Changes by Lita Cho : -- nosy: +jesstess ___ Python tracker <http://bugs.python.org/issue21991> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21991] The new email API should use MappingProxyType instead of returning new dicts.
Lita Cho added the comment: Hi David, I can take this on as I am learning the email api currently. -- nosy: +Lita.Cho ___ Python tracker <http://bugs.python.org/issue21991> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1186900] nntplib shouldn't raise generic EOFError
Lita Cho added the comment: I'ved changed the comment to say Connection closed unexpectedly. -- Added file: http://bugs.python.org/file36264/nntplib_error_v2.patch ___ Python tracker <http://bugs.python.org/issue1186900> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1702036] Make Turtle thread-safe so it does not crash
Lita Cho added the comment: I also want to note that you can create duplicate turtles by using clone, and I am not sure why you would use multiple inheritance to draw more than 1 turtle running around. I didn't think turtle was meant to be used this way. In order to draw multiple turtles, I would use the clone method. Is this to draw turtles running at the same time? -- ___ Python tracker <http://bugs.python.org/issue1702036> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1702036] Make Turtle thread-safe so it does not crash
Lita Cho added the comment: Hey! So I have been investigating this bug, but I wanted to know is the issue the fact that korka wants to create multiple turtles or do you really want to use multiple threads with Turtle? I feel like this crash is due to Tkinter not being thread safe and I am not sure how turtle can go about working around this other than creating a scheduler within turtle. -- ___ Python tracker <http://bugs.python.org/issue1702036> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6639] turtle: _tkinter.TclError: invalid command name ".10170160"
Lita Cho added the comment: I can make it worth such that it doesn't raise a Terminator error. This works great when working with Turtle on the command line. I basically check if the root exists for all Tk canvas calls. If it got destroyed, then it just returns. However, if you run the following recursive code, it will just keep popping up a window forever unless you Ctrl+C out of the program. So that is not going to work. I still believe raising an error is the proper approach. -- ___ Python tracker <http://bugs.python.org/issue6639> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21933] Allow the user to change font sizes with the text pane of turtledemo
Lita Cho added the comment: Hi Terry, I've added to the patch, so that the user is able to change the font size through the GUI. I tried to match Google Doc's behaviour. I also added a max font size. I choose 400 since that is what Google Docs limits their font size. If you prefer to split out the GUI functionaly out of this patch and submit a new patch after this has been committed, that's totally cool! -- Added file: http://bugs.python.org/file36155/tfont_with_gui.patch ___ Python tracker <http://bugs.python.org/issue21933> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17172] Add turtledemo to IDLE menu
Lita Cho added the comment: Thanks for the input Ronald! How would I go about forcing the turtledemo to be in the foreground? Do I just need to call 'fg' on the subprocess? I've been Googling and couldn't find anything obvious. -- ___ Python tracker <http://bugs.python.org/issue17172> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21933] Allow the user to change font sizes with the text pane of turtledemo
Lita Cho added the comment: Hi Terry, I originally had txtfont as a list, but I guess I was worried about readability and accessing attributes by indices being unpythonic. But I might have been over-doing it for this case. :) In Mac, you don't need to divide event.delta by 120, only Windows and X11 systems. This is according to a Stackoverflow answer: http://stackoverflow.com/questions/17355902/python-tkinter-binding-mousewheel-to-scrollbar But maybe I'm wrong? I've attached my small change. -- Added file: http://bugs.python.org/file36124/tdemo-font-34_lita.diff ___ Python tracker <http://bugs.python.org/issue21933> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17172] Add turtledemo to IDLE menu
Lita Cho added the comment: I've updated this patch to include the changes Ned mentioned. I am waiting to hear from Ronald if he has a better solution about dealing with the focus problem with the keyboard and mouse. -- Added file: http://bugs.python.org/file36121/turtle_demo_v3.patch ___ Python tracker <http://bugs.python.org/issue17172> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21933] Allow the user to change font sizes with the text pane of turtledemo
Lita Cho added the comment: I was going to add a dropdown menu to change the font size as well, but I am going to wait till Serhiy's patch gets committed in issue22065 before I submit my patch. -- ___ Python tracker <http://bugs.python.org/issue21933> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17172] Add turtledemo to IDLE menu
Lita Cho added the comment: I wasn't aware of make patchcheck. I will run this script when submitting patches in the future. Thanks, Ned! -- ___ Python tracker <http://bugs.python.org/issue17172> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17172] Add turtledemo to IDLE menu
Lita Cho added the comment: Here is a new patch where it checks to see if turtledemo exists first before loading it onto the bindings. -- Added file: http://bugs.python.org/file36081/turtle_demo_v2.patch ___ Python tracker <http://bugs.python.org/issue17172> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21933] Allow the user to change font sizes with the text pane of turtledemo
Lita Cho added the comment: Here is an updated version of the patch now that Terry submitted the changes from issue21597. -- Added file: http://bugs.python.org/file36077/window_pane_font_size_v3.patch ___ Python tracker <http://bugs.python.org/issue21933> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22061] turtledemo doesn't launch due to changes in tkinter
Lita Cho added the comment: Looks like this method was not doing anything. I removed it and the demo is working just fine. Here is a patch. -- keywords: +patch Added file: http://bugs.python.org/file36076/tk_menubar_fix.patch ___ Python tracker <http://bugs.python.org/issue22061> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22061] turtledemo doesn't launch due to changes in tkinter
New submission from Lita Cho: I updated my source code, and it looks like turtledemo doesn't launch anymore. I get the following error: Traceback (most recent call last): File "/Users/litacho/Development/cpython/Lib/runpy.py", line 170, in _run_module_as_main "__main__", mod_spec) File "/Users/litacho/Development/cpython/Lib/runpy.py", line 85, in _run_code exec(code, run_globals) File "/Users/litacho/Development/cpython/Lib/turtledemo/__main__.py", line 328, in main() File "/Users/litacho/Development/cpython/Lib/turtledemo/__main__.py", line 324, in main demo = DemoWindow() File "/Users/litacho/Development/cpython/Lib/turtledemo/__main__.py", line 124, in __init__ self.mBar.tk_menuBar(self.ExamplesBtn, self.OptionsBtn) AttributeError: 'Frame' object has no attribute 'tk_menuBar' I dug into it and it looks like tk_menuBar was removed due to a fix in issue4350. If tk_menuBar needs to be removed, what method does turtledemo need to call instead to propagate its panels? -- messages: 223899 nosy: Lita.Cho, jesstess, serhiy.storchaka, terry.reedy priority: normal severity: normal status: open title: turtledemo doesn't launch due to changes in tkinter type: crash versions: Python 3.4, Python 3.5 ___ Python tracker <http://bugs.python.org/issue22061> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21597] Allow turtledemo code pane to get wider.
Lita Cho added the comment: Sorry about that!! Thanks for letting me know. -- ___ Python tracker <http://bugs.python.org/issue21597> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21597] Allow turtledemo code pane to get wider.
Lita Cho added the comment: Sweet! Thank you so much, Terry! On Wednesday, July 23, 2014, Terry J. Reedy wrote: > > Terry J. Reedy added the comment: > > No, I believe this is done ;-). Onward to font sizing. > Thank you for the hard work on this. It is a great improvement. > > -- > resolution: -> fixed > stage: commit review -> resolved > status: open -> closed > > ___ > Python tracker > > <http://bugs.python.org/issue21597> > ___ > -- ___ Python tracker <http://bugs.python.org/issue21597> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1598] unexpected response in imaplib
Changes by Lita Cho : -- nosy: -Lita.Cho ___ Python tracker <http://bugs.python.org/issue1598> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21597] Allow turtledemo code pane to get wider.
Lita Cho added the comment: Just to clarify, should I submit a new patch with outlined style changes? -- ___ Python tracker <http://bugs.python.org/issue21597> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21933] Allow the user to change font sizes with the text pane of turtledemo
Lita Cho added the comment: Oops! I was suppose to add 'Control' not 'Ctrl'. I can fix that quickly but I will wait till the other patch goes through. -- ___ Python tracker <http://bugs.python.org/issue21933> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21933] Allow the user to change font sizes with the text pane of turtledemo
Lita Cho added the comment:
Sounds good. I will wait till #21587 and create a small patch afterwards.
Thanks!
On Tue, Jul 22, 2014 at 9:33 PM, Terry J. Reedy
wrote:
>
> Terry J. Reedy added the comment:
>
> On windows, new patch gives this:
> Traceback (most recent call last):
> File "F:\Python\dev\4\py34\Lib\turtledemo\__main__.py", line 295, in
>
> demo = DemoWindow()
> File "F:\Python\dev\4\py34\Lib\turtledemo\__main__.py", line 73, in
> __init__
> graph_frame = self.makeGraphFrame(pane)
> File "F:\Python\dev\4\py34\Lib\turtledemo\__main__.py", line 115, in
> makeGraphFrame
> self._makeBindings(turtle._Screen._canvas._rootwindow)
> File "F:\Python\dev\4\py34\Lib\turtledemo\__main__.py", line 130, in
> _makeBindings
> root_window.bind_all('<%s-minus>' % shortcut, self._decreaseFont)
> File "F:\Python\dev\4\py34\lib\tkinter\__init__.py", line 1049, in
> bind_all
> return self._bind(('bind', 'all'), sequence, func, add, 0)
> File "F:\Python\dev\4\py34\lib\tkinter\__init__.py", line 992, in _bind
> self.tk.call(what + (sequence, cmd))
> _tkinter.TclError: bad event type or keysym "Ctrl"
>
> /Ctrl/Control in "shortcut = 'Control" and demo runs.
>
> root_window.bind_all('<%s-minus>' % shortcut, self._decreaseFont)
> root_window.bind_all('<%s-=>' % shortcut, self._increaseFont)
>
> ^- shrinks on -_ key and num keypad.
> &+ enlarges on =+ key but not num keypad. Fix by adding
> root_window.bind_all('<%s-plus>' % shortcut, self._increaseFont)
>
> ^wheel either way maked giant type -- evt.delta on my machine is +-120!
> self.txtfont['size'] += evt.delta // 120
> works like expected. And please spell out 'event'.
>
> Out general policy is one patch per issue. The one for #21587 already
> fixes two issues. After we finish that (see questions), produce a small
> patch for this.
>
> --
>
> ___
> Python tracker
> <http://bugs.python.org/issue21933>
> ___
>
--
___
Python tracker
<http://bugs.python.org/issue21933>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21597] Allow turtledemo code pane to get wider.
Lita Cho added the comment:
On Tue, Jul 22, 2014 at 8:20 PM, Terry J. Reedy
wrote:
>
> Terry J. Reedy added the comment:
>
> I reviewed code and made the following changes in uploaded file:
> Move some code and blank lines around.
> Since you left packing within mBar frame, removed
>self.mBar.grid_columnconfigure(0, weight=1)
> Since the only thing packed in the left frame was the text frame, renamed
> makeLeftFrame to makeTextFrame, removed the left frame and returned the
> text frame to be gridded directly. Works fine.
> Remove left_frame, graph_frame temporaries.
>
> The questions that stopped me from pushing this are about the following
> lines in makeGraphicFrame.
>
> self._canvas = turtle.ScrolledCanvas(root,
> 800, 600,
> self.canvwidth,
> self.canvheight)
> turtle._Screen._canvas = self._canvas #*
> turtle._Screen._canvas.adjustScrolls()
> turtle._Screen._canvas._rootwindow.bind('',
> self.onResize)
> turtle._Screen._canvas._canvas['borderwidth'] = 0
> turtle._Screen._canvas.grid(row=0, column=0, sticky='news') ##
> ...
> return turtle._Screen._canvas
>
It seems that in all lines except #*, 'turtle._Screen._canvas' could be
> replaced by 'self._canvas' or even a 'canvas' temporary. The ## line seems
> wrong, as the parent is root and 0,0 is not where the canvas shoud be
> gridded and indeed not where it is gridded after being returned. The demo
> seems fine after commenting out the line. So it seems that the following
> should work.
>
> self._Screen._canvas = self._canvas = canvas = (
> turtle.ScrolledCanvas(
> root, 800, 600, self.canvwidth, self.canvheight))
> canvas.adjustScrolls()
> canvas._rootwindow.bind('', self.onResize)
> canvas._canvas['borderwidth'] = 0
> ...
> return canvas
>
Yes! I like this a lot better. turtle._Screen._canvas was how the canvas
was being manipulated before. I was trying to follow the original
programmer's convention, but that works perfectly!
>
> Am I missing something? Just curious, what is the event? Or
> rather, what generates it?
>
>
The Configure event is triggered when the widget changes size. It is super
confusing. Look for '' in the documentation here:
http://effbot.org/tkinterbook/tkinter-events-and-bindings.htm
I had to override Turtle's onResize metbod because the canvas wasn't
centering properly when the sash was being moved.
> --
>
> ___
> Python tracker
> <http://bugs.python.org/issue21597>
> ___
>
--
___
Python tracker
<http://bugs.python.org/issue21597>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21867] Turtle returns TypeError when undobuffer is set to 0 (aka no undo is allowed)
Lita Cho added the comment: This is now fixed due to a patch in issue21868. -- resolution: -> fixed ___ Python tracker <http://bugs.python.org/issue21867> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21933] Allow the user to change font sizes with the text pane of turtledemo
Lita Cho added the comment: I've added it so that if the OS is Mac, it will use Command-minus and Command-=. If it is on Windows, it uses Ctrl-minus and Ctrl-= (I wasn't sure if Windows uses shift sa well, but I don't think it does.) When I tried the "pinch" movement in Mac, the MouseWheel event didn't trigger at all. It is only when I did the scroll (for me two fingers moving downward or upward) movement is when that event triggered. I currently have it so that when Control+MouseWheel makes the font size move. Let me know what you think. I can also try adding a widget so that the user can change the font through the GUI. -- Added file: http://bugs.python.org/file36040/window_pane_font_size_v2.patch ___ Python tracker <http://bugs.python.org/issue21933> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21933] Allow the user to change font sizes with the text pane of turtledemo
Lita Cho added the comment: Oh I see. And then pinch on the trackpad just generates a overall MouseWheel event, not a specific zoom-in event. For some reason, I thought there was a different event depending on operating systems. Before, Linux would trigger and events and not MouseWheel. On Jul 22, 2014, at 12:35 AM, Ned Deily wrote: > > Ned Deily added the comment: > > "However, I figure I still need to create separate bindings for Linux, > "Windows and Mac, right? Or does Tkinter unify all the mousewheel events? > > I'm not sure I understand: I think that Tk only provides one MouseWheel event > binding. Keyboard or menu items might differ, yes, e.g. Cmd-+ vs Ctrl-+. > > http://www.tcl.tk/man/tcl8.5/TkCmd/bind.htm#M9 > > -- > > ___ > Python tracker > <http://bugs.python.org/issue21933> > ___ -- ___ Python tracker <http://bugs.python.org/issue21933> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21933] Allow the user to change font sizes with the text pane of turtledemo
Lita Cho added the comment: What really? That is so awesome! I will check that out! However, I figure I still need to create separate bindings for Linux, Windows and Mac, right? Or does Tkinter unify all the mousewheel events? Lita On Tue, Jul 22, 2014 at 12:18 AM, Ned Deily wrote: > > Ned Deily added the comment: > > On OS X, the actions associated with trackpad gestures are controlled by > the Trackpad panel of System Preferences. The default settings map the > "pinch with two fingers" gesture to "Zoom in or out" which Tk apps see as > Mousewheel events: no programming needed! > > -- > > ___ > Python tracker > <http://bugs.python.org/issue21933> > ___ > -- ___ Python tracker <http://bugs.python.org/issue21933> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21933] Allow the user to change font sizes with the text pane of turtledemo
Lita Cho added the comment:
I completely agree about the mousewheel. However, would it make sense for
OS X to combine command with mousewheel? I have never seen that before. I
am not sure if I can bind the zoom gesture with tkinter, but I can find
out.
I also think the shortcuts are not intuitive as an OS X user, as command
should be used instead of Ctrl.
What I can do check the operating system and define the font shortcuts
accordingly. I am not sure about redefining the Menu shortcuts as that
seems like a separate issue.
On Mon, Jul 21, 2014 at 11:52 PM, Ned Deily wrote:
>
> Ned Deily added the comment:
>
> Lita, I tried the patch. From the perspective of an OS X user, while I
> might expect that using the zoom gesture on a mousepad or using a
> mousewheel (the equivalent) to increase or decrease the font size, I would
> even more expect scrolling to work especially if scrollbars are present.
> Clearly, scrolling is more important so, if it is not possible to bind Tk
> mousewheel events without affecting scrolling, I would abandon the
> mousewheel. On OS X, the standard way to provide size adjustment (of fonts
> or images) is to provide "Bigger" or "Smaller" menu items with the standard
> keyboard shortcuts of Command-Shift-Equal (and Command-Equal) which is
> displayed as "Command +" (so the user on a US keyboard just presses the
> Command key and the =/+ key) and Command-Hyphen ("Command -"). The Apple
> OS X Human Interface Guidelines go into more detail and you can see these
> shortcuts in action in many standard OS X applications (TextEdit, Mail,
> Safari, etc). As it stands today, turtledemo does not use the standard OS
> X menu bar where these commands would normally be placed. And that's a bit
> of a separate problem because since turtledemo doesn't change the root menu
> it defaults to a Tk-provided one which includes things "Run Widget Demo"
> under the file menu. To be a proper OS X app, turtledemo should customize
> the menu, at least removing the widget demo item and then it could add the
> Bigger and Smaller menu items to a Format menu. Actually, the turtledemo
> Examples and Help pulldown options would ideally also be available in the
> standard menu hierarchy. I'm not suggesting that is a requirement but
> that's what I think an OS X user would expect and what the Apple HIG would
> require.
>
>
> https://developer.apple.com/library/mac/documentation/userexperience/conceptual/applehiguidelines/KeyboardShortcuts/KeyboardShortcuts.html
>
> https://developer.apple.com/library/mac/documentation/userexperience/conceptual/applehiguidelines/Menus/Menus.html
>
> --
>
> ___
> Python tracker
> <http://bugs.python.org/issue21933>
> ___
>
--
___
Python tracker
<http://bugs.python.org/issue21933>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21933] Allow the user to change font sizes with the text pane of turtledemo
Lita Cho added the comment: Sounds good. I can wait till the sash code gets incorporated in order to add in the font code. I would have to generate a MOUSEWHEEL event and see if it fails. I have generated mouse clicks before. I'll try to see if I can generate a MOUSEWHEEL event and if it errors, not bind to it. Although it might be hard for me to test, as I just updated my tcl/tk. I will also try to figure out how to bind to Ctrl+MOUSEWHEEL and not just MOUSEWHEEL. Lita On Mon, Jul 21, 2014 at 11:35 PM, Terry J. Reedy wrote: > > Terry J. Reedy added the comment: > > MOUSEWHEEL should continue to scroll. > CONTROL+MOUSEWHEEL should change font size, as you said at the beginning. > At least on Windows, this seems pretty standard: Internet Explorer, > Firefox, Notepad++, LibreOffice (and, I imagin, OpenOffice, and Word), > Thunderbird. The only exception I can find that has a font size setting > but ignores ^wheel is Command Prompt, which breaks multiple UI rules. > Notepad does not allow font resizing. > > Get ^wheel to work right and I would like to add it to Idle, where ^wheel > scrolls along with wheel. > > ^+ and ^- are pretty standard also, though LibreOffice does not recognize > them. Perhaps this is because it is explicit cross platform. > > We can conditionally not bind wheel events on Mac setups where it fails. > Does #10731 have enough info to do that? In not... I have not yet looked > into generating key/mouse events from code, but perhaps it would be > possible to generate a wheel event inside try: except and unbind if there > is an exception. > > -- > > ___ > Python tracker > <http://bugs.python.org/issue21933> > ___ > -- ___ Python tracker <http://bugs.python.org/issue21933> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1702036] Make Turtle thread-safe so it does not crash
Changes by Lita Cho : -- nosy: +jesstess ___ Python tracker <http://bugs.python.org/issue1702036> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21933] Allow the user to change font sizes with the text pane of turtledemo
Lita Cho added the comment: Here is a patch for changing the font size using the scroll wheel. I also added the shortcuts "Ctrl-plus" to increase the font size and "Ctrl-minus" to decrease the font size. However, since the MouseWheel is now bound to changing the font size, the canvas won't scroll. I can try to fix this so that the mousewheel only changes the font size if the text pane is highlighted. But that might not be intuitive. Thoughts? Note, this patch also includes the window sash (issue21597). They are sort of dependent since I am also redefining the onResize method, so I clumped all the bindings to one method. But if you want that to be separate, I can try to make it into two separate patches. -- keywords: +patch Added file: http://bugs.python.org/file36019/window_pane_font_size.patch ___ Python tracker <http://bugs.python.org/issue21933> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21933] Allow the user to change font sizes with the text pane of turtledemo
Lita Cho added the comment: I have a version of this working with Ctrl-plus and Ctrl-minus. However, there is a bug with Tk 8.5.9 where binding to MouseWheel crashes Tkinter for Macs (issue10731), which I am running into. I need to update Tkinter to see if this works. -- ___ Python tracker <http://bugs.python.org/issue21933> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21597] Allow turtledemo code pane to get wider.
Lita Cho added the comment: Ping! Just wanted to see what the status was on getting this patch reviewed. I hope your eye is feeling better, Terry! -- ___ Python tracker <http://bugs.python.org/issue21597> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1598] unexpected response in imaplib
Lita Cho added the comment: Hi Roy, Oh I see. Should we close this out as "Won't Fix" due to the fact that we aren't sure how many users are using this with Domino servers? Lita On Fri, Jul 18, 2014 at 8:52 AM, Roy Hyunjin Han wrote: > > Roy Hyunjin Han added the comment: > > Hi Lita, > > I no longer have access to a Domino server. > > I'm not sure whether there are enough users trying to access Domino with > imaplib for this to warrant investigation. > > RHH > > -- > > ___ > Python tracker > <http://bugs.python.org/issue1598> > ___ > -- ___ Python tracker <http://bugs.python.org/issue1598> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1598] unexpected response in imaplib
Lita Cho added the comment: I spent the last 2 hours trying to setup a Lotus Server, which is ending up to be a lot more work then I thought in order to test this bug. Is there anyway I can get a test Lotus account on a Lotus Server to test this bug? -- ___ Python tracker <http://bugs.python.org/issue1598> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1598] unexpected response in imaplib
Lita Cho added the comment: Has this been determine as a server bug or a bug with imaplib? I am not able to reproduce this bug with Gmail. Do I need to use it with Lotus Server to recreate it? -- nosy: +Lita.Cho ___ Python tracker <http://bugs.python.org/issue1598> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Lita Cho added the comment: Updated my regex patch to include a comment about how we are violating the RFC and allowing all characters rather thane excluding the ] character. -- Added file: http://bugs.python.org/file35979/imap_regex.patch ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Lita Cho added the comment: Updated the documentation in imaplib.rst to describe the RFC violation. -- versions: -Python 3.4, Python 3.5 Added file: http://bugs.python.org/file35978/imap_doc.patch ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Lita Cho added the comment: Here is a patch for test_imaplib.py, adding the test for brackets. It should fail with the current version of imaplib, but should pass with the imap_regex.patch. -- Added file: http://bugs.python.org/file35977/test_imaplib.patch ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Lita Cho added the comment: Okay, sounds good. I will also create a patch in the documentation that explains this, as well as comment on the regex patch. -- ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Lita Cho added the comment:
>
> R. David Murray added the comment:
>
> Just to make sure I understand: the issue is that gmail may produce flags
> with [] in them, and imaplib currently fails to process such flags when it
> receives them from gmail?
>
> This is correct. Gmail allows you to create flags with [], and the
Response_code regex doesn't process them properly.
> In principle I think we would not want to allow imaplib to be used to
> create such flags unless the user specifies some sort of "I want to violate
> the RFC" flag (which they might want to do, for example, to run tests
> against gmail :) But currently it looks like it can? (I haven't looked at
> this in enough detail to be sure.) If that's true we probably have to
> continue to allow it for backward compatibility reasons, but we should
> document the RFC violation and possible consequences (an IMAP server
> rejecting such flags).
>
> Yes, currently we can. I've posted the code in order to do this. This is
basically the result.
>>> first_id = msg_ids.split()[0]
>>> mail.store(first_id, "+FLAGS", "[test]")
('OK', [b'1 (FLAGS (\\Seen Answered [test] NotJunk $NotJunk [Brackets]
[testing2]))'])
However, I would think it would be the server's job to uphold this rule,
not the library. The server should return with a BAD response, but right
now, Gmail allows you to do this.
Should we throw a warning in the "store" method? Otherwise, I can update
the documenation in the "store" method stating that having '[]' is allowed
but violates the RFC protocol.
> --
>
> ___
> Python tracker
> <http://bugs.python.org/issue21815>
> ___
>
--
___
Python tracker
<http://bugs.python.org/issue21815>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Lita Cho added the comment:
Here is the code in order to see the bug.
imaplib.Debug = 5
mail = imaplib.IMAP4_SSL('imap.gmail.com')
mail.login(username, password) # Enter your login here
mail.select('test')
--
___
Python tracker
<http://bugs.python.org/issue21815>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Lita Cho added the comment:
Yes! I agree, this change will need tests. I will start working on creating
those now.
Here is test I did to create a flag with brackets.
import imaplib
mail = imaplib.IMAP4_SSL('imap.gmail.com')
mail.login('usern...@gmail.com', 'password') # Enter your login here
mail.select('test') # Mailbox selection. I have a test inbox with 6
# messages in it.
code, [msg_ids] = mail.search(None, 'ALL')
first_id = msg_ids.split()[0]
mail.store(first_id, "+FLAGS", "[test]")
typ, response = mail.fetch(first_id, '(FLAGS)')
print("Flags: %s" % response)
mail.close()
mail.logout()
--
___
Python tracker
<http://bugs.python.org/issue21815>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Lita Cho added the comment: Here is a log of the output. -- Added file: http://bugs.python.org/file35963/imaplib_log_with_patch.txt ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Lita Cho added the comment: I have a patch for this. With my patch, the debug output is fixed. -- keywords: +patch Added file: http://bugs.python.org/file35962/imap_regex.patch ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Lita Cho added the comment: I was reading the RFC spec, and it looks like it doesn't specificy '[' and ']' are not allowed in the PERNANENTFLAGS names. I can try to add a fix for this. But if anyone else knows if you are not allowed to have '[' or ']' in flag names, please let me know. -- ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Changes by Lita Cho : -- nosy: +Lita.Cho, jesstess ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1186900] nntplib shouldn't raise generic EOFError
Lita Cho added the comment: Here is an updated patch. -- Added file: http://bugs.python.org/file35941/nntplib_error.patch ___ Python tracker <http://bugs.python.org/issue1186900> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1186900] nntplib shouldn't raise generic EOFError
Lita Cho added the comment: That's a good point. I can add that so the NNTPConnectError can inherit the EOFError -- ___ Python tracker <http://bugs.python.org/issue1186900> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21914] Create unit tests for Turtle guionly
Changes by Lita Cho : Added file: http://bugs.python.org/file35930/test_turtle_guionly_v2.patch ___ Python tracker <http://bugs.python.org/issue21914> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21914] Create unit tests for Turtle guionly
Lita Cho added the comment: Trying to attach a file again. I seem to be having trouble attaching it. -- ___ Python tracker <http://bugs.python.org/issue21914> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21914] Create unit tests for Turtle guionly
Lita Cho added the comment: Make some changes to patch. -- ___ Python tracker <http://bugs.python.org/issue21914> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17172] Add turtledemo to IDLE menu
Lita Cho added the comment: I personally think it would be better to check to see if the turtledemo exists during startup, and if so, add the menu entry. Otherwise, don't add it when loading up IDLE. -- ___ Python tracker <http://bugs.python.org/issue17172> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21655] Write Unit Test for Vec2 and TNavigator class in the Turtle Module
Lita Cho added the comment: Ingrid and I combined our tests. The patch now lives here: http://bugs.python.org/issue21916 -- resolution: -> duplicate status: open -> closed ___ Python tracker <http://bugs.python.org/issue21655> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3015] tkinter with wantobjects=False has been broken for some time
Lita Cho added the comment: That's perfect. I agree that this issue is closed! :) -- ___ Python tracker <http://bugs.python.org/issue3015> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21868] Tbuffer in turtle allows negative size
Lita Cho added the comment: Hi Raymond! Just wanted to check if you had time to test this yet. I ran the tests through the Turtle tests I wrote (issue21914), but those are still pending approval. This is off topic, but I also didn't realize till now that you gave a talk about "Transforming Code into Beautiful, Idiomatic Python", which is super awesome! Getting a patch reviewed by you is super exciting! :) -- ___ Python tracker <http://bugs.python.org/issue21868> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1186900] nntplib shouldn't raise generic EOFError
Lita Cho added the comment: I have a fix and added some test coverage in order to make sure the NNTFConnectError was being called. However, in the test case, I am monkey patching. If there is a way to do this with mock, I would appreciate the feedback. -- keywords: +patch Added file: http://bugs.python.org/file35922/nntplib_error.patch ___ Python tracker <http://bugs.python.org/issue1186900> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1186900] nntplib shouldn't raise generic EOFError
Lita Cho added the comment: I am going to fix it so that it raises the NNTPConnectionError rather than update the documentation. -- nosy: +Lita.Cho, jesstess ___ Python tracker <http://bugs.python.org/issue1186900> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21597] Allow turtledemo code pane to get wider.
Lita Cho added the comment: I personally like the FLAT look because it matches with the rest of the GUI. -- ___ Python tracker <http://bugs.python.org/issue21597> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21597] Allow turtledemo code pane to get wider.
Lita Cho added the comment: Hi Terry, So the shadow can easily be removed. I just went with the default sashrelief style. I am going to attach two patches with different sashrelief styles, both of which don't have the shadow. -- Added file: http://bugs.python.org/file35889/turtledemo_pane_scroll_FLAT.patch ___ Python tracker <http://bugs.python.org/issue21597> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21597] Allow turtledemo code pane to get wider.
Changes by Lita Cho : Added file: http://bugs.python.org/file35890/turtledemo_pane_scroll_SOLID.patch ___ Python tracker <http://bugs.python.org/issue21597> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21933] Allow the user to change font sizes with the text pane of turtledemo
New submission from Lita Cho: Currently, the turtledemo doesn't allow you to change font sizes of the demo code, and the default font size is really small. I can work on creating a patch to fix this. Best option be to have control-mousewheel change size, as is standard in browsers, as well as Ctrl + and Ctrl - to change sizes (since laptops don't have a mousewheel). If tk has a problem with that, a second choice would be a menu entry "Font size with choices such as the current size (9?), 10, 12, 14. Also, update the Help Text of this new feature. -- messages: 222466 nosy: Lita.Cho, jesstess, ned.deily, terry.reedy priority: normal severity: normal status: open title: Allow the user to change font sizes with the text pane of turtledemo versions: Python 2.7, Python 3.4, Python 3.5 ___ Python tracker <http://bugs.python.org/issue21933> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21597] Allow turtledemo code pane to get wider.
Lita Cho added the comment: I think I have a fix!! I made it so that centering works while fixing the tearing. For some reason, in the Turtle API, the adjustScrolls method creates a new scroll widget for x and y and deletes the old one. I am not sure why it does it this way. I'm sure there is a reason for it though. For the demo, I overwrote the onResize method so that it centers canvas but doesn't instantiate a new scroll widget and throws away the old one, which fixes the tearing! I would love for someone to review the patch. Thanks! -- Added file: http://bugs.python.org/file35878/turtledemo_pane_srcoll_fix.patch ___ Python tracker <http://bugs.python.org/issue21597> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21597] Allow turtledemo code pane to get wider.
Lita Cho added the comment: ?! After debugging for awhile, I got it so that PanedWindow doesn't cause the rightmost widget to tear! I had to disable the resizing binding on Turtle to make it work. However, now it seems like the canvas is no longer centered. Is there anyway for me to get around this? Maybe I disable the binding on the demo side and re-adjust the center when we initialize the canvas? I want to make sure it works for you guys first before digging into it. -- Added file: http://bugs.python.org/file35877/turtledemo_pane_srcoll_fix.patch ___ Python tracker <http://bugs.python.org/issue21597> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21597] Allow turtledemo code pane to get wider.
Lita Cho added the comment: I also put this patch out there. This doesn't have the PaneWindow, but I manually widen the text pane. This would be the compromise if I can't figure out the tearing due to the sash moving. -- Added file: http://bugs.python.org/file35874/turtledemo_grid.patch ___ Python tracker <http://bugs.python.org/issue21597> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21597] Allow turtledemo code pane to get wider.
Lita Cho added the comment: Hey Terry, So the reason why the tearing is a lot slower in 06/09 patch is because the canvas is using the turtle.ScrolledCanvas widget. Everytime the window resizes, it is calling a callback to `onResize` -> `adjustScrolls` to update the scrollbars. When I comment out that binding in turtle.py (line 358) it still tears, but it snaps back a lot quicker. The main widget is already a 2x2 grid (ScrolledCanvas). I tried just returning the ScrolledCanvas, but that didn't work either. I will try to ask in stackoverflow tomorrow and seeing what they say! -- ___ Python tracker <http://bugs.python.org/issue21597> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21597] Allow turtledemo code pane to get wider.
Lita Cho added the comment: Yes! This is the first version of the code without using ttk widgetd. Using Labels instead of buttons. -- ___ Python tracker <http://bugs.python.org/issue21597> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21597] Allow turtledemo code pane to get wider.
Lita Cho added the comment: Hm, when I upgrade to 8.6, I still get the tearing action on the very right of the window. Although, again, it doesn't seem that bad. I've attahed what I am seeing, just to confirm we are all talking about the same thing. -- Added file: http://bugs.python.org/file35859/tkinter_tear.mov ___ Python tracker <http://bugs.python.org/issue21597> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21597] Allow turtledemo code pane to get wider.
Lita Cho added the comment: Oh man, I was running version '8.5.9' using 'aqua'. I am going to try and upgrade and see if the artifacting goes away. Lita -- ___ Python tracker <http://bugs.python.org/issue21597> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21597] Allow turtledemo code pane to get wider.
Lita Cho added the comment: I feel like the PaneWindow is nice. I could also see down the road making the code text bigger. However, if on Windows, the artifacting is really bad, I can totally switch this back to the grid view. -- ___ Python tracker <http://bugs.python.org/issue21597> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21597] Allow turtledemo code pane to get wider.
Lita Cho added the comment: Oh I had no idea! That makes sense. How do I know which version of Tk I'm working with? I'm testing on Mac OSX as well! Would there be anyway for you to test my patch for turtledemo to see if the sash causes artifacting for you? I see tearing but it snap back into place within less than a second, which doesn't seem that bad. -- ___ Python tracker <http://bugs.python.org/issue21597> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21597] Allow turtledemo code pane to get wider.
Lita Cho added the comment: Should I file a bug? I feel like this a bug specifically related to Python 3 and Tkinter. -- ___ Python tracker <http://bugs.python.org/issue21597> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21597] Allow turtledemo code pane to get wider.
Lita Cho added the comment: Hi Terry, I started digging into this deeper and it looks like my tests doesn't tear in Python 2.7. I have tried on Python 3.5 and 3.4 and it tears on those versions. I also tried the ttk objects, and the widgets also teared when I added frames. Here is the code I tried. from tkinter import * from tkinter import ttk paned = ttk.Panedwindow(orient="horizontal") left = ttk.Frame(paned) left.pack(side='left', fill='both', expand=True) right = ttk.Frame(paned) right.pack(side='right', fill='both', expand=True) button = ttk.Button(left,text="lefgt pane") button.pack( fill='both', expand=True) button2 = ttk.Button(right, text="right pane") button2.pack( fill='both', expand=True) paned.add(left) paned.add(right) paned.pack(fill="both",expand=True, pady = (4,1), padx=4) mainloop() -- ___ Python tracker <http://bugs.python.org/issue21597> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21743] Create tests for RawTurtleScreen
Lita Cho added the comment: submitted a patch that tests all of this. Issue 21914 -- resolution: -> duplicate status: open -> closed ___ Python tracker <http://bugs.python.org/issue21743> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21914] Create unit tests for Turtle guionly
Lita Cho added the comment: I forgot to make it a patch. Created it as a patch for convenience. -- keywords: +patch Added file: http://bugs.python.org/file35847/test_turtle_guionly.patch ___ Python tracker <http://bugs.python.org/issue21914> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21914] Create unit tests for Turtle guionly
Lita Cho added the comment: I created tests for the gui portion of Turtle. This file combines both me and Ingrid's work that is specifically the gui tests. -- Added file: http://bugs.python.org/file35846/test_turtle_guionly.py ___ Python tracker <http://bugs.python.org/issue21914> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21914] Create unit tests for Turtle guionly
New submission from Lita Cho: Create unit tests for the Turtle library, specifically on their gui commands. -- components: Library (Lib), Tkinter messages: 59 nosy: Lita.Cho, jesstess priority: normal severity: normal status: open title: Create unit tests for Turtle guionly versions: Python 3.5 ___ Python tracker <http://bugs.python.org/issue21914> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21868] Tbuffer in turtle allows negative size
Changes by Lita Cho : -- versions: +Python 2.7 ___ Python tracker <http://bugs.python.org/issue21868> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21868] Tbuffer in turtle allows negative size
Changes by Lita Cho : -- versions: +Python 3.4, Python 3.5 ___ Python tracker <http://bugs.python.org/issue21868> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21868] Tbuffer in turtle allows negative size
Lita Cho added the comment: Hey Raymond, just wanted to ping you to see if you had a chance to review this patch yet. Thanks! -- ___ Python tracker <http://bugs.python.org/issue21868> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21868] Tbuffer in turtle allows negative size
Lita Cho added the comment: I should clarify. The right thing being that calling undo does nothing, and turtle keeps on running. This is the default behaviour when setundobuffer is called with no size. -- ___ Python tracker <http://bugs.python.org/issue21868> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21867] Turtle returns TypeError when undobuffer is set to 0 (aka no undo is allowed)
Lita Cho added the comment: That makes a lot of sense. Does that mea we shouldn't change this behaviour as there might be code that relies on these exceptions? The fix in issue21868 will make it so that undo doesn't cause turtle to crash. -- ___ Python tracker <http://bugs.python.org/issue21867> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21867] Turtle returns TypeError when undobuffer is set to 0 (aka no undo is allowed)
Lita Cho added the comment: The patch in issue21868 will fix this issue if it gets approved. -- ___ Python tracker <http://bugs.python.org/issue21867> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21868] Tbuffer in turtle allows negative size
Lita Cho added the comment: Here is a patch for this bug. Basically, when a user gives 0 and below, it doesn't create a TBuffer. Then "undo" does the right thing. -- keywords: +patch Added file: http://bugs.python.org/file35778/undobuffer_fix.patch ___ Python tracker <http://bugs.python.org/issue21868> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21868] Tbuffer in turtle allows negative size
Changes by Lita Cho : -- nosy: +jesstess ___ Python tracker <http://bugs.python.org/issue21868> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21868] Tbuffer in turtle allows negative size
New submission from Lita Cho: Currently, you can set the undobuffer size to negative numbers. Aka, the Tbuffer can be set to negative. s = turtle.Screen() raw = turtle.RawTurtle(s) raw.setundobuffer(-10) raw.undobuffer.bufsize == -10 <-- returns True This should not be possible. Tbuffer should not be allowed to have negative inputs. If the value is less than 0, it should just default to 0 or None. Otherwise, when you call undo, turtle just crashes. -- messages: 221530 nosy: Lita.Cho priority: normal severity: normal status: open title: Tbuffer in turtle allows negative size ___ Python tracker <http://bugs.python.org/issue21868> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
