[issue47000] Make encoding="locale" uses locale encoding even in UTF-8 mode is enabled.

2022-03-30 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Please see https://bugs.python.org/issue47000#msg415769 for what Victor suggested. In particular, the locale module uses the "no underscore" convention. Not sure whether it's good to start using snake case now, but I'm also not against it. I

[issue47072] Database corruption with the shelve module

2022-03-27 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 27.03.2022 09:56, Hubert Tournier wrote: > > The storage format used under Windows is completely different from the one > used under Unix (or *BSD). The shelve module uses the dbm module underneath and this will pick its storage mechan

[issue32642] add support for path-like objects in sys.path

2022-03-26 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 26.03.2022 08:59, Nick Coghlan wrote: > > The import system is already complex, so I think the hesitation about > allowing arbitrary Path-like objects is warranted. (For example: are > importlib's caching semantics really valid for *arb

[issue39298] add BLAKE3 to hashlib

2022-03-23 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Here's a wheel which only includes the portable code (I disabled all the special cases as you suggested). Archive: dist/blake3_experimental_c-0.0.1-cp310-cp310-linux_x86_64.whl Length DateTimeName

[issue39298] add BLAKE3 to hashlib

2022-03-23 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: With "lean" I meant: doesn't use much code and is easy to compile and install. I built a wheel from Jack's experimental package and it comes out to just under 100kB on Linux x64, compared to around the 1.1MB the Rust wheel needs

[issue39298] add BLAKE3 to hashlib

2022-03-23 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 23.03.2022 17:53, Larry Hastings wrote: > > Ok, I give up. Sorry to spoil the fun, but there's no need to throw everything in the bin ;-) A lean and fast blake3 C package would still be a great thing to have on PyPI, e.g. provide s

[issue39298] add BLAKE3 to hashlib

2022-03-23 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 23.03.2022 02:12, Gregory P. Smith wrote: > > I view the NIST standard hashes as important enough to attempt to guarantee > as present (all the SHAs and MD5) as built-in. Others should really > demonstrate practical application popula

[issue47000] Make encoding="locale" uses locale encoding even in UTF-8 mode is enabled.

2022-03-15 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: FWIW: I don't think the "locale" encoding is a good idea. Instead of trying to fix this to make it more usable, I'd suggest to deprecate and remove it again. When it comes to encodings, explicit is better than implicit. If an application wan

[issue44863] Allow TypedDict to inherit from Generics

2022-03-06 Thread Marc Mueller
Change by Marc Mueller : -- nosy: +cdce8p ___ Python tracker <https://bugs.python.org/issue44863> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46659] Deprecate locale.getdefaultlocale() function

2022-02-24 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Thanks, Victor. -- ___ Python tracker <https://bugs.python.org/issue46659> ___ ___ Python-bugs-list mailing list Unsub

[issue46662] Lib/sqlite3/dbapi2.py: convert_timestamp function failed to correctly parse timestamp

2022-02-09 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 08.02.2022 11:54, Erlend E. Aasland wrote: > > The sqlite3 timestamp converter is buggy, as already noted in the docs[^1]. > Adding timezone support is out of the question[^2][^3][^4][^5], but fixing it > to be able to discard any attac

[issue46659] Deprecate locale.getdefaultlocale() function

2022-02-06 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: > For these reasons, I propose to deprecate locale.getdefaultlocale(): > setlocale(), getpreferredencoding() and getlocale() should be used instead. Please see the discussion on https://bugs.python.org/issue43552: locale.getpreferredencoding()

[issue44791] Substitution of ParamSpec in Concatenate

2022-02-04 Thread Marc Mueller
Change by Marc Mueller : -- nosy: +cdce8p ___ Python tracker <https://bugs.python.org/issue44791> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46573] Python modules such as pyglet or pygame crash Python when tkinter message boxes are opened on MacOS.

2022-02-02 Thread Marc Culler
Marc Culler added the comment: The TKApplication class is a subclass of NSApplication which adds both attributes and methods. Those are used throughout the macOS port of Tk, and as Ronald says, the unique instance of NSApplication in Tk is actually a TKApplication. Every macOS Application

[issue43224] Add support for PEP 646

2022-02-01 Thread Marc Mueller
Change by Marc Mueller : -- nosy: +cdce8p ___ Python tracker <https://bugs.python.org/issue43224> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45382] platform() is not able to detect windows 11

2022-01-26 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 26.01.2022 01:29, Eryk Sun wrote: > > Eryk Sun added the comment: > >> Bit wmic seems nice solution. >> Is still working for windows lower than 11? > > wmic.exe is still included in Windows 10 and 11, but it's official

[issue46414] Add typing.reveal_type

2022-01-17 Thread Marc Mueller
Change by Marc Mueller : -- nosy: +cdce8p ___ Python tracker <https://bugs.python.org/issue46414> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46249] [sqlite3] move set lastrowid out of the query loop and enable it for executemany()

2022-01-12 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 11.01.2022 21:30, Erlend E. Aasland wrote: > >> I'd suggest to deprecate the cursor.lastrowid attribute and >> instead point people to the much more useful [...] > > Yes, I think mentioning the RETURNING ROWID trick in the sqli

[issue46249] [sqlite3] move set lastrowid out of the query loop and enable it for executemany()

2022-01-11 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 11.01.2022 20:46, Erlend E. Aasland wrote: > > If we are to revert to this behaviour, we'll have to start examining the SQL > we are given (search for INSERT and REPLACE keywords, determine if they are > valid (i.e. not a comment, not part

[issue46249] [sqlite3] move set lastrowid out of the query loop and enable it for executemany()

2022-01-11 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 08.01.2022 21:56, Erlend E. Aasland wrote: > > Marc-André: since Python 3.6, the sqlite3.Cursor.lastrowid attribute does no > longer comply with the recommendations of PEP 249: > > Previously, lastrowid was set to None for operat

[issue46338] libc_ver() runtime error when sys.executable is empty

2022-01-11 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 10.01.2022 23:01, Allie Hammond wrote: > > libc_ver() in platform.py (called from platform()) causes a runtime error if > sys.executable returns null. In my case, FreeRADIUS offers a module > rlm_python3 which allows you to run python cod

[issue12756] datetime.datetime.utcnow should return a UTC timestamp

2022-01-10 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Hi Tony, from practical experience, it is a whole lot better to not deal with timezones in data processing code at all, but instead only use naive UTC datetime values everywhere, expect when you have to prepare reports or output which has a requirement

[issue46249] [sqlite3] move set lastrowid out of the query loop

2022-01-04 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 04.01.2022 21:02, Erlend E. Aasland wrote: > > Erlend E. Aasland added the comment: > >> If possible, it's usually better to have the .executemany() create a >> cursor with an output array providing the row ids, e.g. using &qu

[issue46249] [sqlite3] move set lastrowid out of the query loop

2022-01-04 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 04.01.2022 11:02, Erlend E. Aasland wrote: > > Erlend E. Aasland added the comment: > > Thank you for your input Marc-André. > > For SQLite, it's pretty simple: we use an API called > sqlite3_last_insert_rowid() which takes th

[issue46249] [sqlite3] move set lastrowid out of the query loop

2022-01-04 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 04.01.2022 00:49, Erlend E. Aasland wrote: > > Erlend E. Aasland added the comment: > > I see that PEP 249 does not define the semantics of lastrowid for > executemany(). What's the precedence here, MAL? IMO, it would be nice to be

[issue46197] ensurepip bootstrap breaks out of isolated environment

2021-12-31 Thread Marc Mueller
Change by Marc Mueller : -- nosy: +cdce8p ___ Python tracker <https://bugs.python.org/issue46197> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46162] Make `builtins.property` generic

2021-12-24 Thread Marc Mueller
Change by Marc Mueller : -- nosy: +cdce8p ___ Python tracker <https://bugs.python.org/issue46162> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41921] REDoS in parseentities

2021-12-06 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Interesting that the tool still exists. It uses mxTextTools, but in a non-packaged version, so it's been broken for two decades now :-) I think it's safe to remove it from Tools\scripts. -- ___ Python tracker

[issue45938] EmailMessage as_bytes

2021-11-30 Thread Marc Villain
New submission from Marc Villain : I am parsing an email with a subject header where the encoding of a unicode character happens to be cut in half. When a second encoded unicode character is encountered, we get the following error: > 'utf-8' codec can't encode characters in position

[issue45927] timeit accepts -c/--clock and -t/--time without any functionality

2021-11-29 Thread Marc-Andre Lemburg
New submission from Marc-Andre Lemburg : >From the code: opts, args = getopt.getopt(args, "n:u:s:r:tcpvh", ["number=", "setup=", "repeat=", "time", "clock

[issue45902] Bytes and bytesarrays can be sorted with a much faster count sort.

2021-11-29 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 26.11.2021 10:56, Ruben Vorderman wrote: > > $ python -m timeit -c "from bytes_sort import bytes_sort" "bytes_sort(b'')" > 50 loops, best of 5: 495 nsec per loop Shouldn't this read: $ python -m timeit -s "

[issue45921] codecs module doesn't support iso-8859-6-i, iso-8859-6-e, iso-8859-8-i or iso-8859-8-i

2021-11-29 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Even though these are IANA recognized encodings, we need to apply he same logic as we do for all new encodings, which essentially boils down to: Are these encoding in wider spread use today ? Reading through the RFC 1556, it seems that the added -i

[issue45476] [C API] Disallow using PyFloat_AS_DOUBLE() as l-value

2021-11-15 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 15.11.2021 10:54, STINNER Victor wrote: > > I don't understand what you are trying to prove about compilers not inlining > when you explicitly ask them... not to inline. I'm not trying to prove anything, Victor. I'm only stating

[issue45476] [C API] Disallow using PyFloat_AS_DOUBLE() as l-value

2021-11-15 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 15.11.2021 08:54, Oleg Iarygin wrote: > > Oleg Iarygin added the comment: > > Marc-Andre: >> Inlining is something that is completely under the control of the > used compilers. Compilers are free to not inline function

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

2021-11-05 Thread Marc Culler
Marc Culler added the comment: Well, not exactly ... culler@abner ~ % export SYSTEM_VERSION_COMPAT=1 culler@abner ~ % sw_vers ProductName:Mac OS X ProductVersion: 10.16 BuildVersion: 20G224 culler@abner ~ % export SYSTEM_VERSION_COMPAT=0 culler@abner ~ % sw_vers

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

2021-11-04 Thread Marc Culler
Marc Culler added the comment: According to wikipedia, it was only the Big Sur beta that identified itself as 10.16. (And I observed this with the beta). But the release and, I think, the later Big Sur betas stopped doing that. But I did eventually find a page showing a tweet

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

2021-11-04 Thread Marc Culler
Marc Culler added the comment: Where do you think that "feature" is documented? -- ___ Python tracker <https://bugs.python.org/issue44828> ___ ___

[issue45698] Error on importing getopt

2021-11-03 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Could you please provide more details regarding the OS, whether you compiled Python yourself and the env settings you used ? Thanks, -- Marc-Andre Lemburg eGenix.com -- nosy: +lemburg ___ Python tracker

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

2021-11-02 Thread Marc Culler
Marc Culler added the comment: A (hypothetical) explanation: I think that each NSWindow maintains a queue of attached sheets. Failing to call the [parent endSheet] method left the file dialogue NSPanel in the queue, although it had been ordered offscreen and so was not visible. Opening

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

2021-11-02 Thread Marc Culler
Marc Culler added the comment: OK. Shift-Command-S works. I will attach the fossil diff which should have enough context to indicate where to add the one new line. Then I will merge this change into the 8.6.12 release candidate -- Added file: https://bugs.python.org/file50420

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

2021-11-02 Thread Marc Culler
Marc Culler added the comment: Yes that is what I meant. So I guess everything may be OK now. I did verify that the Tk demo can repeatedly open file save dialogs. When you press Command-S on a non-new edit window you do see the flash of the Save menu, so it would appear that a dialog

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

2021-11-02 Thread Marc Culler
Marc Culler added the comment: I found the cause of the zombie dialog window. I was supposed to call [parent endSheet] after calling [parent beginSheet]. Adding that stops the window from reappearing. But it does not solve the whole problem. Subsequent Command-S presses do not cause

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

2021-11-01 Thread Marc Culler
Marc Culler added the comment: Heads up! A strange Apple quirk has been identified which could affect the file dialog behavior if the Tk library is compiled on macOS 10.XX and used on macOS 11 or 12. (I am not sure if this applies here.) The fix for the broken file dialog was to use

[issue45653] Freeze the encodings module.

2021-10-30 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 30.10.2021 17:54, Filipe Laíns wrote: > > I just tested partially freezing the package, and it seems to working fine :) FWIW: I think it's best not bother and simply freeze the whole thing. It's mostly char mappings which compress well and t

[issue45548] Update Modules/Setup

2021-10-28 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 27.10.2021 22:58, Brett Cannon wrote: > > Brett Cannon added the comment: > >> Could Brett or you please add those notes back ? There's no other place > where such details are documented. > > It really depends on what &q

[issue45653] Freeze the encodings module.

2021-10-28 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: encodings is a package. I think you first have to check whether mixing frozen and non-frozen submodules are even supported. I've never tried having only part of a package frozen. Freezing the whole package certainly works. -- nosy: +lemburg

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

2021-10-28 Thread Marc Culler
Marc Culler added the comment: That is great news! I will now merge the changes into the Tk core-8-6-branch and core-8-6-12-rc branches. -- ___ Python tracker <https://bugs.python.org/issue44

[issue45562] python -d creates lots of tokenizer messages

2021-10-28 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Thanks, Pablo :-) -- ___ Python tracker <https://bugs.python.org/issue45562> ___ ___ Python-bugs-list mailing list Unsub

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

2021-10-28 Thread Marc Culler
Marc Culler added the comment: Hi Ned. Here is one more attempt, hopefully the final one. I tested with IDLE on 10.14 (VM), 10.15(hard), 11(hard), 12(VM). I used Python 3.10.0. I replaced libtk8.6.dylib with the Tk lib compiled from the tip of the macosx_filedialog branch. I could

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

2021-10-28 Thread Marc Culler
Marc Culler added the comment: Hmmm, the 10.15 segfault seems to occur when writing the filename into the entry widget on the dialog. So maybe it is actually an issue with reference counting an NSString. I will have to look at that more carefully

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

2021-10-28 Thread Marc Culler
Marc Culler added the comment: Thanks for doing all the testing, Ned. I guess that the path forward is now clear. I will revert to the 8.6.11 code for 10.15 and earlier and use the new code for 11 and later. Of course the 8.6.11 code already has two cases, for 10.14 and earlier and 10.15

[issue45562] python -d creates lots of tokenizer messages

2021-10-28 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Hi Pablo, I think you missed one instance: print_escape(stdout, tok->cur, tok->inp - tok->cur); Cheers -- ___ Python tracker <https://bugs.python.or

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

2021-10-27 Thread Marc Culler
Marc Culler added the comment: Hi Ned, I think this problem is fixed now in the tip of the Tk macosx_filedialog branch. I am attaching the tkMacOSXDialog.c file from that branch. I think you should be able to just replace the version in 8.6.11 and be able to build a working version. I

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

2021-10-27 Thread Marc Culler
Marc Culler added the comment: Thanks, Ned, for finding my mistake which you generously called a typo. I have fixed the inequality in the Tk fossil repository. Incidentally, there is now a core-8-6-12-rc branch of Tk, also containing the fix. So it should not be too long before 8.6.12

[issue42738] subprocess: don't close all file descriptors by default (close_fds=False)

2021-10-27 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Gregory P. Smith wrote: > A higher level "best practices for launching child processes module" with > APIs reflecting explicit intents (performance vs security vs simplicity) > rather than requiring users to understand subproces

[issue45548] Update Modules/Setup

2021-10-26 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 26.10.2021 20:47, Marc-Andre Lemburg wrote: >> Brett removed a lot of stuff in 01cf4fb9c1aa567484c2ffb1b11f9b3fe9949b05 to >> make the file more readable. I removed unnecessary -D, -I, and -L to make >> the file even more readable. Y

[issue45548] Update Modules/Setup

2021-10-26 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 26.10.2021 19:42, Christian Heimes wrote: > > Brett removed a lot of stuff in 01cf4fb9c1aa567484c2ffb1b11f9b3fe9949b05 to > make the file more readable. I removed unnecessary -D, -I, and -L to make the > file even more readable. You can

[issue45548] Update Modules/Setup

2021-10-26 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 26.10.2021 16:17, Christian Heimes wrote: > > Christian Heimes added the comment: > > Brett, we can use AM_CONDITIONAL() to conditionally enable/disable a feature > and AC_CONFIG_FILES() to create a Modules/Setup from a templat

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

2021-10-26 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 26.10.2021 16:02, Eric Snow wrote: > > FYI, I figured out the problem on my end. I wasn't using an installed > python. Once I did it worked fine. Oh, you mean you tried using it directly from the source tree ? I don't think I ever tried th

[issue45613] [sqlite3] set threadsafety attribute based on default SQLite threaded mode

2021-10-26 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: +1 on setting the attributes dynamically. Other DB-API modules use a similar approach. -- ___ Python tracker <https://bugs.python.org/issue45

[issue45548] Update Modules/Setup

2021-10-24 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 23.10.2021 21:30, Christian Heimes wrote: > > The trick would move the math function back into the core. Mark moved the > math functions out of the core on purpose, see bpo-7518. I don't follow you. With the _math.o target in Makefile.pre.in

[issue45548] Update Modules/Setup

2021-10-23 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 23.10.2021 20:04, Christian Heimes wrote: > > PR GH-29179 or GH-29181 address the issue with _math.o I think those patches are both taking things a bit too far. This is a build problem, not a code problem. It's perfectly good style to link a

[issue45548] Update Modules/Setup

2021-10-23 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: I'm using a very simple conditional logic in Setup, which is based on sed, mostly to add platform specific variables: In Setup: # @if macosx: TIME_DEFS= # @if not macosx: TIME_DEFS=-lrt time -DPy_BUILD_CORE_BUILTIN -I$(srcdir)/Include/internal

[issue45548] Update Modules/Setup

2021-10-23 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: FYI: I've been working with a fixed Setup file in PyRun for a long while. There are indeed a number of modules missing from Setup, since the whole logic was left behind a bit after things moved to setup.py. The issue with _math.o is actually in the main

[issue45563] inspect.getframeinfo() doesn't handle frames without lineno

2021-10-23 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Hmm, perhaps I should reopen the ticket, even though I now found the cause. After all, it is possible that lineno is None and inspect.getframeinfo() cannot handle it :-) And it may be worthwhile investigating why recreation of a code object using

[issue45563] inspect.getframeinfo() doesn't handle frames without lineno

2021-10-22 Thread Marc-Andre Lemburg
Change by Marc-Andre Lemburg : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue45563] inspect.getframeinfo() doesn't handle frames without lineno

2021-10-22 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Turns out this was a bug in the freeze.py script I was using. I had added a bug work-around for the modulefinder module and even though it should work as advertised, it seems to be missing some code object attributes when recreating the objects which

[issue45563] inspect.getframeinfo() doesn't handle frames without lineno

2021-10-22 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: I've looked at how the importlib freeze logic works, compared to Tools/freeze/freeze.py. The only difference I can spot is that importlib uses C to build the C array and does a compile followed by a marshal.dumps, whereas freeze.py loads all modules

[issue45563] inspect.getframeinfo() doesn't handle frames without lineno

2021-10-22 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: I see this in modules frozen by the Tools/freeze/ tool. The line numbers shown for such frozen modules in the frameinfo stack are a bit off as well, compared normal Python. Could this be an indication that there's something not working quite right

[issue45563] inspect.getframeinfo() doesn't handle frames without lineno

2021-10-22 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Update: I've been trying hard to find a short version which triggers the issue, but so far it seems to only trigger when using exec() from a frozen Python module. There don't appear to be many ways frame->f_lineno can end up being -1 (which then g

[issue45563] inspect.getframeinfo() doesn't handle frames without lineno

2021-10-22 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: In the case of setuptools, this would be the file setup.py, but I think the specific file is not relevant. I can try to come up with a shorter example. -- ___ Python tracker <https://bugs.python.

[issue45562] python -d creates lots of tokenizer messages

2021-10-22 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: I had left a comment on Github about using stderr instead of stdout, to make the output more consistent (other parser error messages go to stderr). Note sure whether that's something you still want to change before closing the issue. -- stage

[issue45563] inspect.getframeinfo() doesn't handle frames without lineno

2021-10-22 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: To add some more context: This came up while porting eGenix PyRun to Python 3.10. While installing setuptools 58.2.0 via "pyrun setup.py install", an exception was raised in getframeinfo(). PyRun uses exec() to run Python code

[issue45562] python -d creates lots of tokenizer messages

2021-10-22 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Yes, I know that (at the moment) it's only documented to work in the parser, but since Py_DebugFlag is a general purpose flag, this use could easily be extended to other parts of the interpreter as well, e.g. for parsing the command line

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

2021-10-21 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: I have an initial version of PyRun for Python 3.10 running as well. This created a few more headaches in order to make it work with setuptools and some glitches which appear to be bugs in 3.10 (https://bugs.python.org/issue45563 and https://bugs.python.org

[issue45563] inspect.getframeinfo() doesn't handle frames without lineno

2021-10-21 Thread Marc-Andre Lemburg
Change by Marc-Andre Lemburg : -- components: +Interpreter Core, Library (Lib), Parser nosy: +lys.nikolaou, pablogsal ___ Python tracker <https://bugs.python.org/issue45

[issue45562] python -d creates lots of tokenizer messages

2021-10-21 Thread Marc-Andre Lemburg
Change by Marc-Andre Lemburg : -- components: +Parser nosy: +lys.nikolaou, pablogsal ___ Python tracker <https://bugs.python.org/issue45562> ___ ___ Python-bug

[issue45562] python -d creates lots of tokenizer messages

2021-10-21 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: What's even worse is that those debug lines get written to stdout, not stderr. -- ___ Python tracker <https://bugs.python.org/issue45

[issue45563] inspect.getframeinfo() doesn't handle frames without lineno

2021-10-21 Thread Marc-Andre Lemburg
New submission from Marc-Andre Lemburg : In Python 3.10, it seems that top-level frames generated by running exec() have their f_lineno attribute set to None. inspect.getframeinfo() tries to build context lines and fails on this line in such a case: start = lineno - 1 - context//2

[issue45562] python -d creates lots of tokenizer messages

2021-10-21 Thread Marc-Andre Lemburg
New submission from Marc-Andre Lemburg : python3.9 -d: Python 3.9.7 (default, Oct 21 2021, 20:51:19) [GCC 7.5.0] on linux Type "help", "copyright", "credits" or "license" for more information. Loaded pyinteractive.py. >>> python3.10 -d: Py

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

2021-10-20 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 20.10.2021 16:25, Eric Snow wrote: > > Eric Snow added the comment: > > On Wed, Oct 20, 2021 at 6:01 AM Marc-Andre Lemburg > wrote: >> I have PyRun mostly working with Python 3.9. >> ... >> No changes were neces

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

2021-10-20 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 19.10.2021 18:47, Marc-Andre Lemburg wrote: > >> On Sat, Oct 16, 2021 at 5:01 AM Marc-Andre Lemburg >> wrote: >>> I can try to port PyRun to 3.9 and 3.10 to see whether I run into any >>> issues. >>> Would

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

2021-10-19 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 16.10.2021 21:20, Eric Snow wrote: > > On Sat, Oct 16, 2021 at 5:01 AM Marc-Andre Lemburg > wrote: >> I can try to port PyRun to 3.9 and 3.10 to see whether I run into any issues. >> Would that help ? > > Yeah, that wo

[issue19459] Python does not support the GEORGIAN-PS charset

2021-10-19 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 19.10.2021 10:44, Serhiy Storchaka wrote: > > Possible solutions (they can be combined): > > 1. Add support for the GEORGIAN-PS charset and all other encodings used in > libc (issue22679). The problem is that it is difficult to g

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

2021-10-16 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 16.10.2021 01:31, Eric Snow wrote: > > @MAL, who's maintaining Tools/freeze? I'm not aware of who's using it (other > than you, of course). It looks like PyRun isn't compatible with anything > newer than 3.5, so it seems like that isn

[issue45490] [meta][C API] Avoid C macro pitfalls and usage of static inline functions

2021-10-15 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Meta comment :-) ... wouldn't it be better to enable the Github wiki feature for such collections ? -- nosy: +lemburg ___ Python tracker <https://bugs.python.org/issue45

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

2021-10-15 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 14.10.2021 22:56, Eric Snow wrote: > > @MAL, what's the best way to make sure Tools/freeze is still working? I > don't see any tests for it in the test suite. I tried running the test in > Tools/freeze/test, but I can't get that to

[issue45476] [C API] Convert "AS" functions, like PyFloat_AS_DOUBLE(), to static inline functions

2021-10-15 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 15.10.2021 11:43, STINNER Victor wrote: > Again, I'm not aware of any performance issue caused by short static inline > functions like Py_TYPE() or the proposed PyFloat_AS_DOUBLE(). If there is a > problem, it should be addressed, since Py

[issue45476] [C API] Convert "AS" functions, like PyFloat_AS_DOUBLE(), to static inline functions

2021-10-15 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: I am with Raymond on this one. If "protecting against wrong use" is the only reason to go down the slippery path of starting to rely on compiler optimizations for performance critical operations, the argument is not good enough. If people do

[issue44828] Using tkinter.filedialog crashes on macOS Python 3.9.6

2021-10-11 Thread Marc Culler
Marc Culler added the comment: No, Apple is not going to do away with their NSOpenPanel. There is always some churn when they release a new OS. Subtle changes to APIs can occur with no warning and no documentation. Sometimes they are bugs. Sometimes they disappear when the OS is released

[issue44828] Using tkinter.filedialog crashes on macOS Python 3.9.6

2021-10-11 Thread Marc Culler
Marc Culler added the comment: Hi Ronald, There is no calendar scheduling for Tk releases. Don Porter decides when they happen. But I think we are due for another one soonish. In case it doesn't happen before the next Python release I will attach the patch file for commit a32262e9

[issue44828] Using tkinter.filedialog crashes on macOS Python 3.9.6

2021-10-10 Thread Marc Culler
Marc Culler added the comment: I was able to fix this problem for Tk on Monterey beta [21A5543b]. The fix has been committed to the tip of the core-8-6-branch in the Tk fossil repository. Here is a synopsis. Tk used to open the file dialog by calling [NSApp runModalForWindow:panel

[issue44828] Using tkinter.filedialog crashes on macOS Python 3.9.6

2021-10-10 Thread Marc Culler
Marc Culler added the comment: Unfortunately, I am still seeing this failure in Monterey beta 9. However, we are no longer alone. Here is a report of the same issue in Android Studio: https://stackoverflow.com/questions/69068842/android-studio-open-file-operation-failed-the-open-file

[issue45382] platform() is not able to detect windows 11

2021-10-08 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 08.10.2021 02:15, Eryk Sun wrote: > >> use the build number as reference instead of the major.minor > > It could check the (major, minor, build) tuple, which allows reporting 10.1+ > as "post11" and minimizes hard coding o

[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

2021-10-07 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 07.10.2021 16:40, Eric Snow wrote: > > On Thu, Oct 7, 2021 at 1:17 AM Marc-Andre Lemburg > wrote: >> I'm not sure I follow, but in any case, please make sure that >> the freeze tool in Tools/ continues to work with the new mechan

[issue29410] Moving to SipHash-1-3

2021-10-07 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 07.10.2021 15:29, Christian Heimes wrote: > > Christian Heimes added the comment: > > JP got back to me > > On 07/10/2021 14.34, Jean-Philippe Aumasson wrote: >> xxHash is much faster indeed, but collisions seem trivial

[issue29410] Moving to SipHash-1-3

2021-10-07 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 07.10.2021 12:48, Christian Heimes wrote: > >> I don't quite follow. Why is it fine that you discuss DoS, but it's not > fine when others discuss DoS ? > > But this BPO is not about discussing mitigations against DoS attacks in >

[issue29410] Moving to SipHash-1-3

2021-10-07 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: BTW: We already use (a slight variant of) xxHash for tuples: https://bugs.python.org/issue34751 The issues is an interesting read, in particular on how xxHash was eventually chosen, with a whole set of other hash algorithms in between

[issue29410] Moving to SipHash-1-3

2021-10-07 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 07.10.2021 12:16, Christian Heimes wrote: > >> That's certainly true, but at the same time, just focusing on string > hashes only doesn't really help either, e.g. it is very easy to > create a DoS with numeric keys or other objects wh

[issue29410] Moving to SipHash-1-3

2021-10-07 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 07.10.2021 11:49, Inada Naoki wrote: > Hash DoS is not only for HTTP headers. Everywhere creating dict from > untrusted source can be attack vector. > For example, many API servers receive JSON as HTTP request body. Limiting > HTTP

  1   2   3   4   5   6   7   8   9   10   >