[issue46480] Implement typing.assert_type

2022-03-23 Thread Shantanu
Change by Shantanu : -- nosy: +hauntsaninja nosy_count: 5.0 -> 6.0 pull_requests: +30158 pull_request: https://github.com/python/cpython/pull/32069 ___ Python tracker <https://bugs.python.org/issu

[issue46998] Allow subclassing Any at runtime

2022-03-12 Thread Shantanu
Change by Shantanu : -- keywords: +patch pull_requests: +29941 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31841 ___ Python tracker <https://bugs.python.org/issu

[issue46998] Allow subclassing Any at runtime

2022-03-12 Thread Shantanu
New submission from Shantanu : Discussed on typing-sig at https://mail.python.org/archives/list/typing-...@python.org/thread/GULRKYI7XOB3FLAEFC6OYSTBS5FIA5PU/ -- components: Library (Lib) messages: 415023 nosy: JelleZijlstra, hauntsaninja priority: normal severity: normal status: open

[issue46831] Outdated comment for __build_class__ in compile.c

2022-02-22 Thread Shantanu
Change by Shantanu : -- keywords: +patch pull_requests: +29649 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31522 ___ Python tracker <https://bugs.python.org/issu

[issue46831] Outdated comment for __build_class__ in compile.c

2022-02-22 Thread Shantanu
New submission from Shantanu : https://github.com/python/cpython/blob/cf345e945f48f54785799390c2e92c5310847bd4/Python/compile.c#L2537 ``` /* ultimately generate code for: = __build_class__(, , *, **) where: is a function/closure created from the class body

[issue40059] Provide a toml module in the standard library

2022-01-11 Thread Shantanu
Shantanu added the comment: This is now PEP 680: https://www.python.org/dev/peps/pep-0680/ Currently being discussed at: https://discuss.python.org/t/pep-680-tomllib-support-for-parsing-toml-in-the-standard-library/13040 -- ___ Python tracker

[issue40059] Provide a toml module in the standard library

2022-01-02 Thread Shantanu
Shantanu added the comment: We've started a PEP draft. https://github.com/hauntsaninja/peps/blob/toml-pep/pep-.rst shows a rendered version. https://github.com/hauntsaninja/peps/pull/1 is a PR from the toml-pep branch to main, to help ease of review / discussion. If you're following

[issue40059] Provide a toml module in the standard library

2022-01-01 Thread Shantanu
Shantanu added the comment: pradyunsg kindly pointed me to an ongoing thread in Packaging discuss: https://discuss.python.org/t/adopting-recommending-a-toml-parser/4068/84 So seems like a PEP will be necessary. I'm happy to do legwork for that. (The PEP that I'll write differs from

[issue40059] Provide a toml module in the standard library

2022-01-01 Thread Shantanu
Shantanu added the comment: > You will need to address where the code is coming from, why that code should > be used, what's the API, etc. Happy new year, potentially-toml-wanting friends! I wrote up a draft of a proposal here: https://gist.github.com/haunts

[issue40059] Provide a toml module in the standard library

2021-12-12 Thread Shantanu
Shantanu added the comment: Given that this currently seems blocked on the broad question of "how should additions and removals to the stdlib be managed", I'd like to not focus too hard just yet on the specifics of tomli. I assume it's unlikely, but for all we know, the SC could

[issue40059] Provide a toml module in the standard library

2021-11-17 Thread Shantanu
Shantanu added the comment: Hopefully tomli being less than a year old should not be a blocker, after all, TOML v1.0.0 is itself less than a year old. Despite tomli being new code, it's pretty widely used. Reverse dependencies include pip, pytest, mypy, black, flit, coverage, setuptools-scm

[issue40059] Provide a toml module in the standard library

2021-11-17 Thread Shantanu
Shantanu added the comment: I'd love it if we could make this happen for Python 3.11. What can I do to help, e.g. would it be helpful if I drafted a PEP? Several projects have switched to using tomli (https://github.com/hukkin/tomli), which is fully compatible with TOML v1.0.0 and is maybe

[issue45121] Regression in 3.9.7 with typing.Protocol

2021-09-06 Thread Shantanu
Shantanu added the comment: Sorry if my message was confusing. Hopefully the following makes things clear: 3.9.6: snippet runs without error 3.9.7, with bpo-44806: (a probably reasonable) TypeError, but a breaking change main, with bpo-45081: RecursionError

[issue45121] Regression in 3.9.7 with typing.Protocol

2021-09-06 Thread Shantanu
Shantanu added the comment: As I mentioned in the post, bpo-45081 actually makes this issue worse, since we get a RecursionError. I think `TypeError: Protocols cannot be instantiated` is probably okay behaviour (as opposed to RecursionError), more just unfortunate that it seems

[issue45121] Regression in 3.9.7 with typing.Protocol

2021-09-06 Thread Shantanu
Change by Shantanu : -- nosy: +lukasz.langa ___ Python tracker <https://bugs.python.org/issue45121> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45121] Regression in 3.9.7 with typing.Protocol

2021-09-06 Thread Shantanu
New submission from Shantanu : Consider: ``` from typing import Protocol class P(Protocol): ... class C(P): def __init__(self): super().__init__() C() ``` This code passes without error on 3.9.6. With 3.9.7, we get: ``` Traceback (most recent call last): File "/

[issue38250] enum.Flag should be more set-like

2021-05-02 Thread Shantanu
Change by Shantanu : -- nosy: +hauntsaninja nosy_count: 6.0 -> 7.0 pull_requests: +24506 pull_request: https://github.com/python/cpython/pull/25820 ___ Python tracker <https://bugs.python.org/issu

[issue44006] symbol documentation still exists

2021-05-01 Thread Shantanu
Shantanu added the comment: Do you see what's generating it? As far as I can tell, the RST was removed a while ago in https://github.com/python/cpython/pull/21624 -- nosy: +hauntsaninja ___ Python tracker <https://bugs.python.org/issue44

[issue43798] Add position metadata to alias AST type

2021-04-11 Thread Shantanu
Shantanu added the comment: FYI, probably unavoidable, but this appears to have broken pytest https://github.com/pytest-dev/pytest/issues/8539 -- nosy: +hauntsaninja ___ Python tracker <https://bugs.python.org/issue43

[issue16396] Importing ctypes.wintypes on Linux gives a ValueError instead of an ImportError

2020-12-25 Thread Shantanu
Change by Shantanu : -- nosy: +hauntsaninja nosy_count: 12.0 -> 13.0 pull_requests: +22798 pull_request: https://github.com/python/cpython/pull/23951 ___ Python tracker <https://bugs.python.org/issu

[issue39791] New `files()` api from importlib_resources.

2020-12-08 Thread Shantanu
Change by Shantanu : -- nosy: +hauntsaninja nosy_count: 8.0 -> 9.0 pull_requests: +22577 pull_request: https://github.com/python/cpython/pull/23715 ___ Python tracker <https://bugs.python.org/issu

[issue42195] Inconsistent __args__ between typing.Callable and collections.abc.Callable

2020-11-29 Thread Shantanu
Shantanu added the comment: You're right that Callable[[P], int] is invalid, so a flat representation isn't currently ambiguous. But a flat representation would foist the responsibility for checking that to all users of `__args__`. If your code isn't ParamSpec aware, your failures

[issue42195] Inconsistent __args__ between typing.Callable and collections.abc.Callable

2020-11-22 Thread Shantanu
Shantanu added the comment: I think ((int, int), str) is superior to the others and if it can be made to work, that's what we should do. Note that if variadic type proposals go anywhere (https://docs.google.com/document/d/1oXWyAtnv0-pbyJud8H5wkpIk8aajbkX-leJ8JXsE318/edit#), my

[issue42102] Make builtins.callable "generic"

2020-11-16 Thread Shantanu
Shantanu added the comment: My implementation in PR 22848 turns callable into a type and uses `__new__`. It isn't too bad. It does appear to affect performance of callable though. Here's some data on how often typing imports are used. This is the number of files in which `from typing import

[issue42102] Make builtins.callable "generic"

2020-10-21 Thread Shantanu
Shantanu added the comment: Sure, I put together a draft PR here: https://github.com/python/cpython/pull/22848 Tests pass cleanly, though timeit indicates callable is slower. I haven't added instancecheck, which we should consider doing, since `isinstance(x, callable)` would now return

[issue42102] Make builtins.callable "generic"

2020-10-21 Thread Shantanu
Change by Shantanu : -- keywords: +patch pull_requests: +21796 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22848 ___ Python tracker <https://bugs.python.org/issu

[issue42102] Make builtins.callable "generic"

2020-10-20 Thread Shantanu
New submission from Shantanu : In the post PEP 585 world, it seems like a bit of a stumbling block for builtins.callable to not able to be parametrised (in a runtime context). Post PEP 604, I'd expect typing.Callable to be the most used typing import after typing.Any, so much of PEP 585's

[issue28002] ast.unparse can't roundtrip some f-strings

2020-10-12 Thread Shantanu
Shantanu added the comment: Bumping again! -- ___ Python tracker <https://bugs.python.org/issue28002> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41696] asyncio.run interacts surprisingly with debug mode

2020-09-02 Thread Shantanu
Change by Shantanu : -- keywords: +patch pull_requests: +21159 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22069 ___ Python tracker <https://bugs.python.org/issu

[issue41696] asyncio.run interacts surprisingly with debug mode

2020-09-02 Thread Shantanu
New submission from Shantanu : To quote the docs (https://docs.python.org/3/library/asyncio-dev.html): ``` By default asyncio runs in production mode. In order to ease the development asyncio has a debug mode. There are several ways to enable asyncio debug mode: Setting

[issue39349] Add "cancel_futures" parameter to concurrent.futures.Executor.shutdown()

2020-09-01 Thread Shantanu
Change by Shantanu : -- pull_requests: +21145 pull_request: https://github.com/python/cpython/pull/22048 ___ Python tracker <https://bugs.python.org/issue39

[issue39349] Add "cancel_futures" parameter to concurrent.futures.Executor.shutdown()

2020-08-31 Thread Shantanu
Change by Shantanu : -- pull_requests: +21123 pull_request: https://github.com/python/cpython/pull/22023 ___ Python tracker <https://bugs.python.org/issue39

[issue39349] Add "cancel_futures" parameter to concurrent.futures.Executor.shutdown()

2020-08-30 Thread Shantanu
Shantanu added the comment: I was working on updating typeshed stubs to reflect this change. It looks like the parameter wasn't actually added to the base class (https://github.com/python/cpython/blob/c3a651ad2544d7d1be389b63e9a4a58a92a31623/Lib/concurrent/futures/_base.py#L608), even

[issue28724] Add method send_io, recv_io to the socket module.

2020-08-30 Thread Shantanu
Shantanu added the comment: I was looking at adding stubs for these to typeshed. Is it intentional that we ignore the flags and address arguments in the implementation? -- nosy: +hauntsaninja ___ Python tracker <https://bugs.python.org/issue28

[issue28002] ast.unparse can't roundtrip some f-strings

2020-08-02 Thread Shantanu
Shantanu added the comment: Just bumping this issue, as per dev guide, since https://github.com/python/cpython/pull/19612 has been ready for about two months. Would be grateful for review :-) -- ___ Python tracker <https://bugs.python.

[issue40614] ast.parse doesn't respect feature_version for debug f-strings

2020-05-27 Thread Shantanu
Change by Shantanu : -- pull_requests: +19718 pull_request: https://github.com/python/cpython/pull/20466 ___ Python tracker <https://bugs.python.org/issue40

[issue20928] xml.etree.ElementInclude does not include nested xincludes

2020-05-26 Thread Shantanu
Change by Shantanu : -- nosy: +hauntsaninja nosy_count: 8.0 -> 9.0 pull_requests: +19695 pull_request: https://github.com/python/cpython/pull/20438 ___ Python tracker <https://bugs.python.org/issu

[issue33187] Document ElementInclude (XInclude) support in ElementTree

2020-05-26 Thread Shantanu
Change by Shantanu : -- nosy: +hauntsaninja nosy_count: 6.0 -> 7.0 pull_requests: +19694 pull_request: https://github.com/python/cpython/pull/20438 ___ Python tracker <https://bugs.python.org/issu

[issue20177] Derby #8: Convert 28 sites to Argument Clinic across 2 files

2020-05-19 Thread Shantanu
Change by Shantanu : -- nosy: +hauntsaninja nosy_count: 5.0 -> 6.0 pull_requests: +19505 pull_request: https://github.com/python/cpython/pull/20208 ___ Python tracker <https://bugs.python.org/issu

[issue40676] Use Argument Clinic for csv

2020-05-18 Thread Shantanu
Change by Shantanu : -- keywords: +patch pull_requests: +19499 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20200 ___ Python tracker <https://bugs.python.org/issu

[issue40676] Use Argument Clinic for csv

2020-05-18 Thread Shantanu
New submission from Shantanu : To do all the functions in csv, we'd need to have support for **kwargs, tracked in https://bugs.python.org/issue20291. Am attaching a PR for the ones that can be made to work today. -- components: Argument Clinic messages: 369314 nosy: hauntsaninja

[issue40614] ast.parse doesn't respect feature_version for debug f-strings

2020-05-18 Thread Shantanu
Change by Shantanu : -- keywords: +patch pull_requests: +19496 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20196 ___ Python tracker <https://bugs.python.org/issu

[issue13601] sys.stderr should be line-buffered when stderr is not a TTY

2020-05-17 Thread Shantanu
Change by Shantanu : -- pull_requests: +19467 pull_request: https://github.com/python/cpython/pull/20168 ___ Python tracker <https://bugs.python.org/issue13

[issue40662] ast.get_source_segment behaviour with missing location info doesn't match docstring

2020-05-17 Thread Shantanu
Shantanu added the comment: The code works on 3.8 for me, but has regressed on 3.9 master. Looks like this is caused by https://bugs.python.org/issue36287 (https://github.com/python/cpython/pull/18843) -- nosy: +hauntsaninja ___ Python tracker

[issue40665] Use Argument Clinic for bisect

2020-05-17 Thread Shantanu
Change by Shantanu : -- keywords: +patch pull_requests: +19463 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20163 ___ Python tracker <https://bugs.python.org/issu

[issue40665] Use Argument Clinic for bisect

2020-05-17 Thread Shantanu
New submission from Shantanu : As the title says! Am submitting a PR. -- components: Argument Clinic messages: 369153 nosy: hauntsaninja, larry priority: normal severity: normal status: open title: Use Argument Clinic for bisect ___ Python tracker

[issue34556] Add --upgrade-deps to venv module

2020-05-16 Thread Shantanu
Change by Shantanu : -- nosy: +hauntsaninja nosy_count: 4.0 -> 5.0 pull_requests: +19440 pull_request: https://github.com/python/cpython/pull/20135 ___ Python tracker <https://bugs.python.org/issu

[issue13601] sys.stderr should be line-buffered when stderr is not a TTY

2020-05-15 Thread Shantanu
Shantanu added the comment: I'm wondering if this should be mentioned in Python 3.9's What's New, potentially at https://docs.python.org/3.9/whatsnew/3.9.html#sys ? This change broke one of mypy's tests on 3.9 and it was a little tricky to find what had changed. -- nosy

[issue40586] Pydoc should support https for hyperlinks.

2020-05-15 Thread Shantanu
Shantanu added the comment: This looks like a duplicate of https://bugs.python.org/issue38786, which was fixed in https://github.com/python/cpython/pull/17143 That PR wasn't backported, but maybe it should be. -- nosy: +hauntsaninja ___ Python

[issue40495] compileall: option to hardlink duplicate optimization levels bytecode cache files

2020-05-15 Thread Shantanu
Change by Shantanu : -- nosy: +hauntsaninja nosy_count: 6.0 -> 7.0 pull_requests: +19428 pull_request: https://github.com/python/cpython/pull/19806 ___ Python tracker <https://bugs.python.org/issu

[issue40621] Python crashes with new parser on invalid exception handlers

2020-05-14 Thread Shantanu
Change by Shantanu : -- keywords: +patch pull_requests: +19390 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20086 ___ Python tracker <https://bugs.python.org/issu

[issue40621] Python crashes with new parser on invalid exception handlers

2020-05-14 Thread Shantanu
New submission from Shantanu : ``` ~/dev/cpython master λ ./python.exe --version --version Python 3.9.0a6+ (heads/master:a15c9b3a05, May 14 2020, 00:31:47) [Clang 11.0.0 (clang-1100.0.33.17)] # should raise a syntax error, instead crashes ~/dev

[issue40614] ast.parse doesn't respect feature_version for debug f-strings

2020-05-13 Thread Shantanu
New submission from Shantanu : ``` ~master λ python3.8 Python 3.8.2 (default, Apr 21 2020, 00:39:48) [Clang 11.0.0 (clang-1100.0.33.17)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> impor

[issue40334] PEP 617: new PEG-based parser

2020-05-04 Thread Shantanu
Change by Shantanu : -- nosy: +hauntsaninja nosy_count: 7.0 -> 8.0 pull_requests: +19226 pull_request: https://github.com/python/cpython/pull/19911 ___ Python tracker <https://bugs.python.org/issu

[issue40493] Pegen can't parse some function type comments

2020-05-03 Thread Shantanu
Change by Shantanu : -- keywords: +patch pull_requests: +19205 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19894 ___ Python tracker <https://bugs.python.org/issu

[issue40493] Pegen can't parse some function type comments

2020-05-03 Thread Shantanu
New submission from Shantanu : Currently fails if we don't have any arguments before *args and **kwargs ``` ~ λ python3.9 Python 3.9.0a6+ (heads/master:c95e691, May 3 2020, 19:57:46) [Clang 11.0.0 (clang-1100.0.33.17)] on darwin Type "help", "copyright", "credi

[issue40491] Typo in SyntaxError produced by pegen for numeric literals

2020-05-03 Thread Shantanu
Change by Shantanu : -- keywords: +patch pull_requests: +19204 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19893 ___ Python tracker <https://bugs.python.org/issu

[issue40491] Typo in SyntaxError produced by pegen for numeric literals

2020-05-03 Thread Shantanu
New submission from Shantanu : ``` ~ λ python3.9 Python 3.9.0a6+ (heads/master:c95e691, May 3 2020, 19:57:46) [Clang 11.0.0 (clang-1100.0.33.17)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> impo

[issue39691] Allow passing Pathlike objects to io.open_code

2020-04-30 Thread Shantanu
Change by Shantanu : -- keywords: +patch nosy: +hauntsaninja nosy_count: 3.0 -> 4.0 pull_requests: +19145 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19824 ___ Python tracker <https://bugs.python.org/i

[issue40447] compile_file's stripdir does not accept pathlib.Path

2020-04-30 Thread Shantanu
Shantanu added the comment: If it helps triage, this is the BPO for where the changes to compileall were made: https://bugs.python.org/issue38112 -- ___ Python tracker <https://bugs.python.org/issue40

[issue40447] compile_file's stripdir does not accept pathlib.Path

2020-04-30 Thread Shantanu
New submission from Shantanu : Python 3.9 added the stripdir argument to compileall functions. From https://docs.python.org/3.9/library/compileall.html#compileall.compile_file: > The stripdir, prependdir and limit_sl_dest arguments correspond to the -s, -p > and -e options described

[issue40445] compileall.compile_dir docs aren't updated for bpo-38112

2020-04-29 Thread Shantanu
Change by Shantanu : -- keywords: +patch pull_requests: +19127 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19806 ___ Python tracker <https://bugs.python.org/issu

[issue40445] compileall.compile_dir docs aren't updated for bpo-38112

2020-04-29 Thread Shantanu
New submission from Shantanu : While the signature was updated in the documentation, the text below wasn't, and still reflects the old default of 10. https://docs.python.org/3.9/library/compileall.html#compileall.compile_dir -- assignee: docs@python components: Documentation messages

[issue40222] "Zero cost" exception handling

2020-04-21 Thread Shantanu
Change by Shantanu : -- nosy: +hauntsaninja ___ Python tracker <https://bugs.python.org/issue40222> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40349] Python3.9 changes col_offset for some ast nodes

2020-04-20 Thread Shantanu
New submission from Shantanu : With Python 3.8: ``` Python 3.8.1 (default, Jan 23 2020, 23:36:06) [Clang 11.0.0 (clang-1100.0.33.17)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> import ast

[issue28002] ast.unparse can't roundtrip some f-strings

2020-04-19 Thread Shantanu
Change by Shantanu : -- keywords: +patch pull_requests: +18946 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19612 ___ Python tracker <https://bugs.python.org/issu

[issue28002] ast.unparse can't roundtrip some f-strings

2020-04-14 Thread Shantanu
Shantanu added the comment: Now that `ast.unparse` is being added to stdlib, I thought I'd bump this thread. The third party library `astunparse` (which attempts to support multiple Python versions while staying very close to Tools/parser/unparse.py) has an implementation that works

[issue39722] decimal differs between pure Python and C implementations

2020-02-21 Thread Shantanu
Shantanu added the comment: Sounds good, thought I'd check! :-) Definitely looks annoying to remove from the Python version too. -- ___ Python tracker <https://bugs.python.org/issue39

[issue39723] io.open_code should accept PathLike objects

2020-02-21 Thread Shantanu
Change by Shantanu : -- keywords: +patch pull_requests: +17969 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18602 ___ Python tracker <https://bugs.python.org/issu

[issue39723] io.open_code should accept PathLike objects

2020-02-21 Thread Shantanu
New submission from Shantanu : Currently io.open_code (added in Python 3.8) only accepts str arguments. As per PEP 519, it should probably also accept PathLike. It might be worth extending it to accept bytes as well, both for convenience and because documentation claims it should

[issue39722] decimal differs between pure Python and C implementations

2020-02-21 Thread Shantanu
New submission from Shantanu : The dunder methods on decimal.Decimal accept an extra context argument in the pure Python version which the C version does not (violating PEP 399). This came up in https://github.com/python/typeshed/pull/3633, where Sebastian provided the following summary

[issue39719] tempfile.SpooledTemporaryFile still has softspace property

2020-02-21 Thread Shantanu
Change by Shantanu : -- keywords: +patch pull_requests: +17966 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18599 ___ Python tracker <https://bugs.python.org/issu

[issue39719] tempfile.SpooledTemporaryFile still has softspace property

2020-02-21 Thread Shantanu
New submission from Shantanu : The softspace attribute of files was removed in Python 3 (mentioned in https://raw.githubusercontent.com/python/cpython/master/Misc/HISTORY) However, tempfile.SpooledTemporaryFile still has a softspace property that attempts to return read the softspace

[issue39718] TYPE_IGNORE, COLONEQUAL missing from py38 changes in token docs

2020-02-21 Thread Shantanu
Change by Shantanu : -- keywords: +patch pull_requests: +17965 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18598 ___ Python tracker <https://bugs.python.org/issu

[issue39718] TYPE_IGNORE, COLONEQUAL missing from py38 changes in token docs

2020-02-21 Thread Shantanu
New submission from Shantanu : Changed in version 3.8 section of https://docs.python.org/3/library/token.html should mention the addition of TYPE_IGNORE and COLONEQUAL -- assignee: docs@python components: Documentation messages: 362436 nosy: docs@python, hauntsaninja priority: normal

[issue39559] uuid.getnode() has unused argument

2020-02-05 Thread Shantanu
Shantanu added the comment: Github code search isn't great, but I was unable to find any usage of `uuid.getnode(getters=`, whereas I was able to find usage of `uuid.uuid1(node=` (even though `node` is optional and can be passed positionally). I'd be surprised if it was used in practice

[issue39559] uuid.getnode() has unused argument

2020-02-05 Thread Shantanu
Change by Shantanu : -- keywords: +patch pull_requests: +17743 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18369 ___ Python tracker <https://bugs.python.org/issu

[issue28009] Fix uuid.uuid1() core logic of uuid.getnode() needs refresh

2020-02-05 Thread Shantanu
Change by Shantanu : -- pull_requests: +17744 pull_request: https://github.com/python/cpython/pull/18369 ___ Python tracker <https://bugs.python.org/issue28

[issue39504] inspect.signature throws RuntimeError on select.epoll.register

2020-01-30 Thread Shantanu
New submission from Shantanu : >From the documentation of `inspect.signature` it seems we should never have a >RuntimeError: ``` Raises ValueError if no signature can be provided, and TypeError if that type of object is not supported. ``` The easiest thing to do is just turn the Runtim

[issue39495] xml.etree.ElementTree.TreeBuilder.start differs between pure Python and C implementations

2020-01-29 Thread Shantanu
Change by Shantanu : -- keywords: +patch pull_requests: +17650 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18275 ___ Python tracker <https://bugs.python.org/issu

[issue39495] xml.etree.ElementTree.TreeBuilder.start differs between pure Python and C implementations

2020-01-29 Thread Shantanu
Shantanu added the comment: Based on https://github.com/python/cpython/blob/master/Modules/_elementtree.c#L2700 and the behaviour at runtime, something like the following patch could work: ``` diff --git a/Lib/xml/etree/ElementTree.py b/Lib/xml/etree/ElementTree.py index c8d898f328

[issue39495] xml.etree.ElementTree.TreeBuilder.start differs between pure Python and C implementations

2020-01-29 Thread Shantanu
New submission from Shantanu : The C accelerated version of `xml.etree.ElementTree.TreeBuilder.start` has a default value for `attrs`, whereas the pure Python version does not. ``` In [41]: sys.version

[issue39493] typing.py has an incorrect definition of closed

2020-01-29 Thread Shantanu
Change by Shantanu : -- keywords: +patch pull_requests: +17642 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18265 ___ Python tracker <https://bugs.python.org/issu

[issue39493] typing.py has an incorrect definition of closed

2020-01-29 Thread Shantanu
New submission from Shantanu : Hello! typing.py has the following definition of `closed`: https://github.com/python/cpython/blob/master/Lib/typing.py#L1834 ``` @abstractmethod def closed(self) -> bool: pass ``` This is inconsistent with the behaviour at runtime: ``` In