Antoine Pitrou added the comment:
Since nobody seems to object to the patch, I'm commit it :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18772
___
Roundup Robot added the comment:
New changeset 2f1bac39565a by Antoine Pitrou in branch 'default':
Issue #18772: fix the gdb plugin after the set implementation changes
http://hg.python.org/cpython/rev/2f1bac39565a
--
___
Python tracker
Antoine Pitrou added the comment:
Well, it should be ok now (at least now the test passes here).
--
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18772
Raymond Hettinger added the comment:
I just applied the dict version of dummy to sets in
http://hg.python.org/cpython/rev/f0202c3daa7a
and it unexpectedly broke test_gdb again:
FAIL: test_sets (test.test_gdb.PrettyPrintTests)
Verify the pretty-printing of sets
Antoine Pitrou added the comment:
Checking for dummies in dicts in python-gdb.py is implicit (see
PyDictObjectPtr.iteritems()): entries whose value is NULL are not printed.
Set entries do not have values, so instead pySetObjectPtr.write_repr() uses a
hack with the repr() of the key to check
Raymond Hettinger added the comment:
Attaching a patch, but I don't have a way to test it.
--
Added file: http://bugs.python.org/file31438/fix_dummy.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18772
Antoine Pitrou added the comment:
Checking repr() perpetuates the original hack so, why it may work, I think it's
better if we take the opportunity to solve it cleanly.
I'll try to take a look tonight (I suppose you're under Windows?).
--
___
Python
Antoine Pitrou added the comment:
Attached patch solves the issue and removes the repr()-based hack in the gdb
plugin.
--
Added file: http://bugs.python.org/file31444/gdb_sets_repr2.patch
___
Python tracker rep...@bugs.python.org
Raymond Hettinger added the comment:
Antoine, can you please verify the gdb plug-in is working again?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18772
___
Antoine Pitrou added the comment:
Antoine, can you please verify the gdb plug-in is working again?
test_gdb works fine here, yes.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18772
___
Raymond Hettinger added the comment:
Thank you.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18772
___
Antoine Pitrou added the comment:
In other words, we're paying a price for the dummy object being
printable as a string.
Which is pointless, I agree.
Antoine, thanks to the link to the python-dev discussion. I hope we
can come with a solution that doesn't involve going back to unicode
Raymond Hettinger added the comment:
I'll get on it this evening. Please be patient.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18772
___
Roundup Robot added the comment:
New changeset be29efa60b68 by Raymond Hettinger in branch 'default':
Issue 18772: Restore set dummy object back to unicode and restore the identity
checks in lookkey().
http://hg.python.org/cpython/rev/be29efa60b68
--
nosy: +python-dev
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
Removed message: http://bugs.python.org/msg195720
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18772
___
Antoine Pitrou added the comment:
Raymond, if you don't have time for this issue, I'd prefer your patch to be
reverted. It hasn't been proven to accelerate any benchmark, and the problems
it triggered need solving.
--
___
Python tracker
Dave Malcolm added the comment:
Antoine's patch looks reasonable to me, FWIW.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18772
___
___
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
assignee: - rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18772
___
___
Raymond Hettinger added the comment:
This is a bummer. The internal comments made the claim that any python object
would suffice. The use of a unicode object was unfortunate because it isn't
guaranteed to be unique (i.e. a user can legitimately store dummy as a
valid member of a set). As
Antoine Pitrou added the comment:
See also the python-dev thread about other drawbacks of the new dummy approach:
http://mail.python.org/pipermail/python-dev/2013-August/128025.html
--
___
Python tracker rep...@bugs.python.org
Changes by Antoine Pitrou pit...@free.fr:
--
title: Fix test_gdb for new sets dummy object - Fix gdb plugin for new sets
dummy object
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18772
___
21 matches
Mail list logo
